[issue17741] event-driven XML parser

Stefan Behnel added the comment: > I agree, but this assumes there is a "better API". I would like to see > an API proposal and a patch before I give an opinion :-) Well, I have already proposed an API throughout this thread, and then given a usage example and an almost complete sketch of the i

[issue18695] os.statvfs() not working well with unicode paths

Giampaolo Rodola' added the comment: > I'm not sure that it's a good idea to invest time on fixing Unicode > issues in Python 2, especially in a minor version (Python 2.7.x). I admit I sort of share the same doubts, but considering 2.7 a "minor python version", especially at this point, would

[issue18700] test_cgi raises ResourceWarning

New submission from Madison May: I'm currently running the tests on a 64-bit Ubuntu 13.04 laptop using the default branch of python. ``/home/mmay/cpython/Lib/test/test_cgi.py:276: ResourceWarning: unclosed file <_io.BufferedRandom name=3>`` -- components: Tests messages: 194782 nosy:

[issue18606] Add statistics module to standard library

Steven D'Aprano added the comment: On 31/07/13 20:23, Antoine Pitrou added the comment: > > I suppose you should write a PEP for the module inclusion proposal Done. http://www.python.org/dev/peps/pep-0450/ I hope to have an updated reference implementation, plus unittests, up later today or t

[issue18699] What is Future.running() for in PEP 3148 / concurrent.futures.Future?

Guido van Rossum added the comment: (Note that my change to PEP 3156 is somewhat separate -- Tulip's Future doesn't have to follow all of the PEP 3148 API and its running() method did nothing anyway. But concurrent.futures.Future has been released for several cycles and we must consider the r

[issue18699] What is Future.running() for in PEP 3148 / concurrent.futures.Future?

Roundup Robot added the comment: New changeset 922c0fe6ebee by Guido van Rossum in branch 'default': Get rid of Future.running(); see bug 18699. http://hg.python.org/peps/rev/922c0fe6ebee -- nosy: +python-dev ___ Python tracker

[issue18673] Add and use O_TMPFILE for Linux 3.11

Changes by Tshepang Lekhonkhobe : -- nosy: +tshepang ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue18660] os.read behavior on Linux

Changes by Tshepang Lekhonkhobe : -- nosy: +tshepang ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue18416] Move to absolute file paths for module.__file__

Madison May added the comment: I quickly ran the tests with each of the above edits to see what bits of the test suite would break. With option 1 (edits to PathFinder only): ``1 test failed: test_importlib`` With option 2 (edits to FileFinder only): ``3 tests failed: test_import te

[issue18699] What is Future.running() for in PEP 3148 / concurrent.futures.Future?

New submission from Guido van Rossum: >From glyph (in a particularly snarky mood): """ P.S.: I realize that this isn't really within the scope of this message, but as I was reviewing Future's documentation while writing it, I realized what Future.running() does. Wow. What a completely pointl

[issue18698] importlib.reload() does not return the module in sys.modules

New submission from Eric Snow: Currently reload() returns the module that loader.load_module() returns, rather than returning the one in sys.modules. This is different from what happens during normal import. I would expect reload() to return what's in sys.modules. Perhaps this got overlooke

[issue4708] os.pipe should return inheritable descriptors (Windows)

STINNER Victor added the comment: os.pipe() creates non-inheritable pipes on Windows, whereas it creates inheritable pipes on UNIX. IMO the reason is an implementation artifact: os.pipe() calls CreatePipe() on Windows (native API), whereas it calls pipe() on UNIX (POSIX API). The call to Creat

[issue18571] Implementation of the PEP 446: non-inheritable file descriptors

Changes by STINNER Victor : -- title: Implementation of the PEP 446: non-inheriable file descriptors -> Implementation of the PEP 446: non-inheritable file descriptors ___ Python tracker __

[issue18695] os.statvfs() not working well with unicode paths

STINNER Victor added the comment: > The script above works fine on Python 3.3 but on 2.7 you'll get: ... Cool, you now have a good reason to upgrade to Python 3 ;-) I'm not sure that it's a good idea to invest time on fixing Unicode issues in Python 2, especially in a minor version (Python 2.7

[issue8112] xmlrpc.server: ServerHTMLDoc.docroutine uses (since 3.0) deprecated function "inspect.getargspec()"

Claudiu.Popa added the comment: Here's a patch with tests attached. -- keywords: +patch nosy: +Claudiu.Popa versions: +Python 3.4 -Python 3.1 Added file: http://bugs.python.org/file31210/xmlrpc.patch ___ Python tracker

[issue17741] event-driven XML parser

Antoine Pitrou added the comment: Le vendredi 09 août 2013 à 20:34 +, Eli Bendersky a écrit : > Antoine, I'm not yet very well versed in the release process, but ISTM that > if: > > 1. We know that a better API can be created > 2. The implementation is not overly difficult > > It makes sens

[issue18644] Got ResourceWarning: unclosed file when using test function from formatter module

STINNER Victor added the comment: "Why is the `formatter` module still part of Python 3? This was a dependency for the `htmllib` module in Python 2 only, and that module was deprecated and removed from Python 3." The formatter module was deprecated? When? -- nosy: +haypo

[issue17741] event-driven XML parser

Eli Bendersky added the comment: On Fri, Aug 9, 2013 at 12:34 PM, Antoine Pitrou wrote: > > Antoine Pitrou added the comment: > > > Can we agree on discarding the current implementation for now and then > > rewriting it based on a tree builder instead of a parser wrapper? > > Only if it actually

[issue18643] implement socketpair() on Windows

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue18673] Add and use O_TMPFILE for Linux 3.11

STINNER Victor added the comment: > use O_TEMPFILE in tempfile module when it's supported by the current kernel How do you detect that a kernel does not support the flag? Try to use the flag and handle the error? -- nosy: +haypo ___ Python tracker

[issue18583] Idle: enhance FormatParagraph

Phil Webster added the comment: In the case of no selection would it make sense to only format if the cursor is in a string/comment? If not in a string or comment, the single line that the cursor is in could be formatted with a line ending backslash or not at all. Otherwise Format Paragraph wi

[issue18600] email.policy doc example passes 'policy' to as_string, but that doesn't work

R. David Murray added the comment: Committed with changes pointed out by Antoine (thank you Antoine). -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___

[issue18600] email.policy doc example passes 'policy' to as_string, but that doesn't work

Roundup Robot added the comment: New changeset 53287858e71f by R David Murray in branch 'default': #18600: add policy to add_string, and as_bytes and __bytes__ methods. http://hg.python.org/cpython/rev/53287858e71f New changeset 8fbaf4e649af by R David Murray in branch '3.3': #18600: In 3.3, as_

[issue18675] Daemon Threads can seg fault

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue18685] Restore re performance to pre-PEP393 level

Antoine Pitrou added the comment: Ok, here are some results from the benchmarks suite: Report on Linux fsol 3.8.0-27-generic #40-Ubuntu SMP Tue Jul 9 00:17:05 UTC 2013 x86_64 x86_64 Total CPU cores: 4 ### regex_effbot ### Min: 0.058952 -> 0.054367: 1.08x faster Avg: 0.059060 -> 0.054378: 1.09x

[issue18695] os.statvfs() not working well with unicode paths

Serhiy Storchaka added the comment: Functions such as rename(), popen(), mkfifo(), mknod(), etc have the same issue. -- nosy: +haypo, serhiy.storchaka ___ Python tracker ___

[issue15301] os.chown: OverflowError: Python int too large to convert to C long

Antoine Pitrou added the comment: The Windows buildbots are broken: == ERROR: test_chown_uid_gid_arguments_must_be_index (test.test_os.MakedirTests) -- Traceba

[issue18683] Core dumps on CentOS

STINNER Victor added the comment: It might be related to #14432. Could you try patch Python with a patch of the issue #14432? -- nosy: +haypo ___ Python tracker ___

[issue18685] Restore re performance to pre-PEP393 level

Serhiy Storchaka added the comment: I'm under 32-bit Linux with gcc 4.6.3. The above test is only one example for which I expect largest difference. I suppose other tests will show a gain too. -- ___ Python tracker

[issue18685] Restore re performance to pre-PEP393 level

Matthew Barnett added the comment: With the patch the results are: C:\Python34\python.exe -m timeit -s "import re; f = re.compile(b'abc').search; x = b'x'*10" "f(x)" 1 loops, best of 3: 113 usec per loop C:\Python34\python.exe -m timeit -s "import re; f = re.compile('abc').search; x

[issue18685] Restore re performance to pre-PEP393 level

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue18600] email.policy doc example passes 'policy' to as_string, but that doesn't work

R. David Murray added the comment: Turns out even with as_string accepting a policy keyword, the example still failed. It needs to be generating a bytes object, not a string. Before I even realized that, though, I decided I wanted to add as_bytes (and __bytes__). So the attached patch does

[issue17741] event-driven XML parser

Antoine Pitrou added the comment: > Can we agree on discarding the current implementation for now and then > rewriting it based on a tree builder instead of a parser wrapper? Only if it actually brings something (feature-wise, performance-wise, maintenance-wise, whatever) that the current implem

[issue18685] Restore re performance to pre-PEP393 level

Antoine Pitrou added the comment: > @Antoine: Are you on the same OS as Serhiy? I don't know, I'm under Linux with gcc (on a x86-64 machine) :-) > IIRC, wasn't the performance regression that wxjmfauth complained > about in Python 3.3 apparent on Windows, but not on Linux? I don't know, but I'

[issue18688] Document undocumented Unicode object API

Serhiy Storchaka added the comment: It will be good first resolve issue18697. -- ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue18697] Unify arguments names in Unicode object C API documentation

New submission from Serhiy Storchaka: In declarations of Unicode object C API functions in Doc/c-api/unicode.rst the first Unicode object argument has different names: "unicode", "str", "u", "s". It will be good to unify these names. Of course there is no need to change reasonable argument nam

[issue17741] event-driven XML parser

Stefan Behnel added the comment: What about this idea: instead of changing the internal C implementation, we could provide a simple parser target wrapper class (say, "EventBuilder") that the parser would simply recognise with isinstance(). Then it would unpack the wrapped target and configure

[issue18655] GUI apps take long to launch on Windows

Terry J. Reedy added the comment: This tracker is for patching CPython, not Windows or 3rd-party C libraries. Ramchandra is right, Python does not display windows. In the cases you mention, this is done by 3-rd party cross-platform graphics libraries interacting with Windows' native graphics s

[issue17741] event-driven XML parser

Stefan Behnel added the comment: Ok, finally. ;) Can we agree on discarding the current implementation for now and then rewriting it based on a tree builder instead of a parser wrapper? "Because we'd need to change internal code" is not a good argument for adding a new API, IMHO. --

[issue18670] Using read_mime_types function from mimetypes module gives resource warning

R. David Murray added the comment: Since the TESTFN file is created only in this test, rather than use a tearDown method, it would be better to use addCleanup in the test method itself. -- nosy: +r.david.murray ___ Python tracker

[issue18696] In unittest.TestCase.longMessage doc remove a redundant sentence

R. David Murray added the comment: I think the text is OK as it stands. The first sentence is a technical description of the result of setting the attribute, the last sentence is a conceptual discussion of why you would want to set the attribute. -- nosy: +r.david.murray

[issue18685] Restore re performance to pre-PEP393 level

Matthew Barnett added the comment: @Antoine: Are you on the same OS as Serhiy? IIRC, wasn't the performance regression that wxjmfauth complained about in Python 3.3 apparent on Windows, but not on Linux? -- ___ Python tracker

[issue18696] In unittest.TestCase.longMessage doc remove a redundant sentence

New submission from py.user: http://docs.python.org/3/library/unittest.html#unittest.TestCase.longMessage "If set to True then any explicit failure message you pass in to the assert methods will be appended to the end of the normal failure message. The normal messages contain useful information

[issue17741] event-driven XML parser

Antoine Pitrou added the comment: > > Unless I'm reading it wrong, when _setevents() is called, the > > internal > > hooks are rewired to populate the events list, rather than call the > > corresponding TreeBuilder methods. So, yes, there's a TreeBuilder > > somewhere, but it stands unused. > >

[issue17741] event-driven XML parser

Eli Bendersky added the comment: On Fri, Aug 9, 2013 at 8:44 AM, Stefan Behnel wrote: > > Stefan Behnel added the comment: > > > ask to be added to the experts list for ET > > Already done, see the corresponding python-dev thread. > Done. 747970502b23 -- __

[issue17741] event-driven XML parser

Stefan Behnel added the comment: > ask to be added to the experts list for ET Already done, see the corresponding python-dev thread. > Now back to a productive discussion please... I think we already are. Keep reading through the rest of the posts. -- ___

[issue17741] event-driven XML parser

Eli Bendersky added the comment: > It's easy to say that as a core developer with commit rights who > can > simply hide changes in a low frequented bug tracker without > notifying those who have to know about these changes. It's pure > luck > I noticed this change during the alpha release cycle

[issue17741] event-driven XML parser

Stefan Behnel added the comment: > Unless I'm reading it wrong, when _setevents() is called, the internal > hooks are rewired to populate the events list, rather than call the > corresponding TreeBuilder methods. So, yes, there's a TreeBuilder > somewhere, but it stands unused. Yes, you *are* re

[issue17741] event-driven XML parser

Antoine Pitrou added the comment: > > Well, I would rather like to understand yours. > > My point is that the IncrementalParser uses a TreeBuilder that builds > an XML tree in the back. So I'm wondering why you are saying that it > doesn't build a tree. Unless I'm reading it wrong, when _seteve

[issue17741] event-driven XML parser

Stefan Behnel added the comment: > TreeBuilder doesn't do parsing, it takes already parsed data: it has a > start() method to open a tag, and a data() method to add raw text > inside that tag. That is correct. However, the XMLParser has a feed() method that sends new data into the parser, and a

[issue17741] event-driven XML parser

Antoine Pitrou added the comment: > It's easy to say that as a core developer with commit rights > who can simply hide changes in a low frequented bug tracker without > notifying those who have to know about these changes. It's > pure luck I noticed this change during the alpha release cycle. It

[issue17741] event-driven XML parser

Stefan Behnel added the comment: > Well, I would rather like to understand yours. My point is that the IncrementalParser uses a TreeBuilder that builds an XML tree in the back. So I'm wondering why you are saying that it doesn't build a tree. > Whatever IncrementalParser uses internally need

[issue17741] event-driven XML parser

Antoine Pitrou added the comment: > But IncrementalParser uses an XMLParser internally, which in turn > uses a TreeBuilder internally. So what exactly is your point? Well, I would rather like to understand yours. Whatever IncrementalParser uses internally needn't impact what API it exposes to th

[issue17741] event-driven XML parser

Stefan Behnel added the comment: But IncrementalParser uses an XMLParser internally, which in turn uses a TreeBuilder internally. So what exactly is your point? -- ___ Python tracker __

[issue17741] event-driven XML parser

Stefan Behnel added the comment: > But worse than no change at all. Arguing about API naming is a bit > futile, *especially* when the ship has sailed. It's easy to say that as a core developer with commit rights who can simply hide changes in a low frequented bug tracker without notifying those

[issue17741] event-driven XML parser

Antoine Pitrou added the comment: > A change in an alpha release is still way better than a change after > a final release. But worse than no change at all. Arguing about API naming is a bit futile, *especially* when the ship has sailed. -- ___ Pytho

[issue17741] event-driven XML parser

Antoine Pitrou added the comment: > > The point is not to build a tree of potentially unbounded size > > (think > > XMPP). The point is to yield events in a non-blocking way > > (iterparse() > > is blocking, which makes it useless for non-blocking applications). > > Ok, but that's the only diffe

[issue17741] event-driven XML parser

Stefan Behnel added the comment: > About the patch: I think changing the API names now that alpha1 has been > released is a bit gratuitous. Sorry for being late, but I can't see it being my fault. A change in an alpha release is still way better than a change after a final release. Eventually,

[issue17741] event-driven XML parser

Stefan Behnel added the comment: > The point is not to build a tree of potentially unbounded size (think > XMPP). The point is to yield events in a non-blocking way (iterparse() > is blocking, which makes it useless for non-blocking applications). Ok, but that's the only difference. Instead of g

[issue17741] event-driven XML parser

Antoine Pitrou added the comment: About the patch: I think changing the API names now that alpha1 has been released is a bit gratuitous. I would like to keep the encapsulation part but ditch the naming changes. -- ___ Python tracker

[issue17741] event-driven XML parser

Changes by Antoine Pitrou : -- status: closed -> open ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue17741] event-driven XML parser

Antoine Pitrou added the comment: > Antoine, is there a reason why you had to add this _setevents() method > to the XMLParser, instead of making the IncrementalParser an > IncrementalTreeBuilder? The point is not to build a tree of potentially unbounded size (think XMPP). The point is to yield

[issue17741] event-driven XML parser

Stefan Behnel added the comment: Thinking about the original patch some more - I wonder why it doesn't use a wrapper for TreeBuilder to process the events. Antoine, is there a reason why you had to add this _setevents() method to the XMLParser, instead of making the IncrementalParser an Increm

[issue17741] event-driven XML parser

Stefan Behnel added the comment: Oh, and could we reopen this ticket, please? -- ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue18685] Restore re performance to pre-PEP393 level

Antoine Pitrou added the comment: I get the same kind of results as Serhiy: $ python3.2 -m timeit -s "import re; f = re.compile(b'abc').search; x = b'x'*10" "f(x)" 1 loops, best of 3: 81.7 usec per loop $ python3.2 -m timeit -s "import re; f = re.compile('abc').search; x = 'x'*10"

[issue18695] os.statvfs() not working well with unicode paths

New submission from Giampaolo Rodola': From: https://code.google.com/p/psutil/issues/detail?id=416 # -*- coding: utf-8 -*- from __future__ import unicode_literals import os, errno name = "ƒőő" try: os.mkdir(name) except OSError as err: if err.errno != errno.EEXIST: raise os.stat

[issue18606] Add statistics module to standard library

Oscar Benjamin added the comment: One small point: I think that the argument `m` to variance, pvariance, stdev and pstdev should be renamed to `mu` for pvariance/pstdev and `xbar` for variance/stdev. The doc-strings should carefully distinguish that `mu` is the true/population mean and `xbar` is

[issue17741] event-driven XML parser

Changes by Stefan Behnel : Added file: http://bugs.python.org/file31206/iterparse_api_cleanup.patch ___ Python tracker ___ ___ Python-bugs-lis

[issue17741] event-driven XML parser

Stefan Behnel added the comment: Actually, let me take that last paragraph back. There is an Obvious Way to do it, and that's the feed() and close() methods. They are the existing and established ElementTree interface for incremental parsing. The fact that close() doesn't clean up all state is

[issue17741] event-driven XML parser

Stefan Behnel added the comment: Copying the discussion between Antoine and me from python-dev: >> IMO it should mimic the interface of the TreeBuilder, which >> calls the data reception method "feed()" and the termination method >> "close()". There is no reason to add yet another set of methods

[issue17741] event-driven XML parser

Changes by Stefan Behnel : -- components: +XML ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue17741] event-driven XML parser

Stefan Behnel added the comment: Here is a patch that cleans up the current implementation to avoid making the result of iterparse() an IncrementalParser (with all of its new API). Please note that the tulip mailing list is not an appropriate place to discuss additions to the XML libraries, an

[issue18688] Document undocumented Unicode object API

Changes by Antoine Pitrou : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue17974] Migrate unittest to argparse

Serhiy Storchaka added the comment: > Does it maintain the ability to pass the discovery arguments positionally and > by keyword? Yes, of course. Only such command line are not supported more: ./python Lib/test/test_colorsys.py discover -v Lib/test/test_json/ or ./python -m test.test

[issue17974] Migrate unittest to argparse

Michael Foord added the comment: The patch looks like an improvement. Does it maintain the ability to pass the discovery arguments positionally and by keyword? If so then it can go in. I like the improved error reporting for nonsenical input to unittest.main. -- __

[issue18381] unittest warnings counter

Michael Foord added the comment: Looks good to me, except the backslash continuation is unneeded. Needs documentation. -- assignee: -> michael.foord ___ Python tracker ___

[issue18226] IDLE Unit test for FormatParagrah.py

Terry J. Reedy added the comment: I got rid of the shutdown warning by replacing EditorWindow with a simple mock, as explained in the test file. Doing so also reduced the running time from about .40 seconds to .25 (it was 1.0+ before I reduced the redundancy of the tests). All the asserts pass

[issue18685] Restore re performance to pre-PEP393 level

Changes by Antoine Pitrou : -- nosy: +tim_one ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue18690] memoryview not considered a sequence

Changes by Antoine Pitrou : -- nosy: +mark.dickinson, skrah type: behavior -> enhancement versions: -Python 2.7, Python 3.1, Python 3.2, Python 3.3, Python 3.5 ___ Python tracker __