Changes by Antoine Pitrou pit...@free.fr:
--
superseder: module shutdown procedure based on GC - Stop purging modules which
are garbage collected before shutdown
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue812369
Changes by Michael Bikovitsky moshe.b...@gmail.com:
--
keywords: +patch
Added file: http://bugs.python.org/file31393/doc_fix.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18790
___
Changes by Michael Bikovitsky moshe.b...@gmail.com:
--
nosy: +Michael.Bikovitsky
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18790
___
___
Charles-François Natali added the comment:
Just to be explicit (there are typos in Victor's original messages): it's about
select.devpoll, for Solaris-derivatives with /dev/poll, and not for
select.poll, based on poll() syscall.
--
___
Python
Charles-François Natali added the comment:
I've lost track -- who is waiting for whom? I reviewed the patch
selector-12.diff and received zero response AFAICT. (Maybe the email from
Rietveld didn't make it?)
I was on vacation, and then had to cope with many emails :-)
I'll update the
Charles-François Natali added the comment:
Some ftplib tests sometimes time out. Seem they seem to try to connect to
localhost (rather than 127.0.0.1), I was wondering if this could be a DNS
issue and if we should resolve localhost in advance like Charles-François
did for some other tests
New submission from Raymond Hettinger:
AFAICT, there is no reason for sets to incref and decref dummy objects. The
dummy object address is used as placeholders in the hash table but it is never
accessed by set the logic. As long the one reference is held at the time the
dummy object is
Antoine Pitrou added the comment:
Hard-cording 127.0.0.1 for this test should be OK, because the server
setup explicitly binds an AF_INET socket. We'll probably have to check
the rest of the test suite for similar issues.
Ok, let's do it!
--
keywords: +easy
Changes by Raymond Hettinger raymond.hettin...@gmail.com:
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18797
___
___
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +Mark.Shannon, tim.peters
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18797
___
___
Antoine Pitrou added the comment:
I can't think of any counter-indication but I think we shouldn't distinguish
between debug and non-debug mode. That way the debug hooks can check that the
refcounting optimization is right.
--
___
Python tracker
Antoine Pitrou added the comment:
Here is a patch for default.
--
keywords: +patch
Added file: http://bugs.python.org/file31395/support_host.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18792
Changes by Serhiy Storchaka storch...@gmail.com:
--
dependencies: +PyNumber_Index() is not int-subclass friendly (or
operator.index() docos lie)
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18712
koobs added the comment:
Antoine, did you see: #18762 ? It references the samee failures on 9.x as well.
Do you want to close this as a dupe, or maintain separate issues for each OS?
--
___
Python tracker rep...@bugs.python.org
Antoine Pitrou added the comment:
Ha, you're right, we can close this one as a duplicate.
--
superseder: - error in test_multiprocessing_forkserver
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18793
STINNER Victor added the comment:
Just to be explicit (there are typos in Victor's original messages): it's
about select.devpoll, for Solaris-derivatives with /dev/poll, and not for
select.poll, based on poll() syscall.
Oops sorry, yes, I'm talking about select.devpoll, its structure has a
Michael Foord added the comment:
Cool, thanks!
--
assignee: - michael.foord
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14971
___
___
Serhiy Storchaka added the comment:
Yet some nitpicks.
Currently the code of _PyLong_FromNbInt() is inlined and the do_decref flag is
used to prevent needless change refcounts of int objects (see also issue18797).
In proposed patch common code is extracted into the _PyLong_FromNbInt()
STINNER Victor added the comment:
I like the idea of renaming select to _select, and add Lib/select.py
for the high-level wrapper (Selector). In my opinion, adding a module
just for 5 classes is overkill. Selector classes are a very thin
abstraction over the low-level objects. A new module can
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +serhiy.storchaka
stage: - needs patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18794
___
R. David Murray added the comment:
I think the essential use case is using a python program in a unix pipeline.
I'm very sympathetic to that use case, despite my unease.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18713
R. David Murray added the comment:
I believe the module already supports sorting by time and cumulative time
(determining the top consumers of cpu is a major part of the point of the
profile module, after all).
What exactly is the change that you are proposing? If you post a diff instead
Alexandre Dias added the comment:
It does support sorting by total time and cumulative time spent on a function,
but not by the time per each call of that function.
I've uploaded a diff of the patch.
-Alexandre
--
versions: +Python 3.4 -Python 2.7
Added file:
Serhiy Storchaka added the comment:
On PyPy 1.8.0 operator.index(True) returns 1.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17576
___
___
Charles-François Natali added the comment:
Changing support.HOST from 'localhost' to '127.0.0.1' means that on dual-stack
hosts (I don't think the test suite would run on IPv6-only hosts anyway), the
tests will now always use IPv4, whereas they are currently using either IPv6 or
IPv4 addresses
R. David Murray added the comment:
It would be clearer, I think, to call it average time. I must admit to not
being sure why that is useful. I'm also worried there might be backward
compatibility issues with changing the ordering of the data structure. If new
fields are going to be added
STINNER Victor added the comment:
This all sounds fine to fix without waiting for anything else -- can you
attach a patch here?
I opened the issue as a reminder for me. Here is a patch.
* Add close() and fileno() methods and a closed attribute (property) to
devpoll object
* Document closed
New submission from Vajrasky Kok:
Typo in line 11:
# Skip test if no fnctl module.
Unused variables rv in test_fcntl_file_descriptor method.
Attached the patch to clean up the test.
--
components: Tests
files: fix_typo_unused_variables_in_test_fcntl.patch
keywords: patch
messages:
STINNER Victor added the comment:
Currently, Python 3 fails miserabily when it gets a non-ASCII
character from stdin or when it tries to write a byte encoded as a
Unicode surrogate to stdout.
It works fine when OS data can be decoded from and encoded to the
locale encoding. Example on Linux
Antoine Pitrou added the comment:
Changing support.HOST from 'localhost' to '127.0.0.1' means that on
dual-stack
hosts (I don't think the test suite would run on IPv6-only hosts
anyway), the
tests will now always use IPv4, whereas they are currently using
either IPv6 or
IPv4 addresses
Serhiy Storchaka added the comment:
poll, devpoll, epoll and kqueue are tested in test_poll.py, test_devpoll.py,
test_epoll.py and test_kqueue.py test files.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18794
Serhiy Storchaka added the comment:
And yet one nitpick. For int subclasses which doesn't overload the __int__
method the patch calls default int.__int__ which creates a copy of int object.
This is redundant in PyLong_As* functions because they only extract C int value
and drop Python int
Serhiy Storchaka added the comment:
print(member)
%s % member
{}.format(member)
Would you seriously use either of those last two in either the debugger
or the command line?
Yes, of course. When you need debug output from function or loop inners.
for ...:
...
Roundup Robot added the comment:
New changeset 8e1194c39bed by Christian Heimes in branch '3.3':
Issue #18747: Re-seed OpenSSL's pseudo-random number generator after fork.
http://hg.python.org/cpython/rev/8e1194c39bed
New changeset 49e23a3adf26 by Christian Heimes in branch 'default':
Issue
Changes by Serhiy Storchaka storch...@gmail.com:
--
stage: commit review - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18743
___
Serhiy Storchaka added the comment:
I'm proposing to split this issue on two issues. One for C-style formatting (I
guess everyone agree that '%i' % int-like object should return decimal
representation of its numerical value) and other for format() which is more
questionable.
--
Claudiu.Popa added the comment:
Here's a basic patch, using a classmethod. It doesn't support the full distb
API (if the traceback is not given, try to retrieve the last one), because
Bytecode.from_tb() looks pretty weird.
--
keywords: +patch
nosy: +Claudiu.Popa
Added file:
Christian Heimes added the comment:
I have taken care of Antoine's and Victor's reviews. The fix has landed in
Python 2.7, 3.3 and 3.4. What about 2.6, 3.1 and 3.2? After all it's a security
fix (although I don't consider its severity as high).
--
nosy: +barry, benjamin.peterson,
Charles-François Natali added the comment:
That would only be true if the server we are contacting happens to
listen on both IPv6 and IPv4, right? I don't think we have such a
situation in the test suite.
Ah, I thought some code was using getaddrinfo() to select an arbitrary
bind() address
Serhiy Storchaka added the comment:
I think we should just use PyNumber_ToBase() for any int and int subclass. The
calling __str__() for special case looks weird.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18780
STINNER Victor added the comment:
3.52 +#if 0
3.53 +fprintf(stderr, PySSL_RAND_atfork_child() seeds %i
bytes in pid %i\n,
3.54 +(int)sizeof(seed), seed.pid);
3.55 +#endif
Don't you want to remove this debug code?
1.8 +def test_random_fork(self):
1.9 +
Charles-François Natali added the comment:
Christian Heimes added the comment:
I have taken care of Antoine's and Victor's reviews. The fix has landed in
Python 2.7, 3.3 and 3.4. What about 2.6, 3.1 and 3.2? After all it's a
security fix (although I don't consider its severity as high).
irdb added the comment:
Sorry, it's probably has the same problem as what Martin suggested. Although I
think it's better than having program interrupted.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15809
Christian Heimes added the comment:
Am 21.08.2013 14:08, schrieb Charles-François Natali:
And basically, because PySSL_RAND_atfork_child() is not async-signal
safe, the interpreter is now subject to random deadlocks/crash in
multi-threaded processes. I personally don't consider this a
Ethan Furman added the comment:
Serhiy Storchaka added the comment:
I'm proposing to split this issue on two issues. One for C-style formatting
(I guess everyone agree that '%i' % int-like object should return decimal
representation of its numerical value) and other for format() which is
Charles-François Natali added the comment:
Which part of the function is not async-signal safe? It doesn't interact
with any file descriptors nor does it use any syscalls except for
getpid() and time().
gettimeofday() and RAND_add()
The functions which are guaranteed to be async-signal safe
Christian Heimes added the comment:
Do you have a proposal for a better way to fix the issue? I don't think that we
can hope for a fix from OpenSSL.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18747
Antoine Pitrou added the comment:
Do you have a proposal for a better way to fix the issue? I don't
think that we can hope for a fix from OpenSSL.
Instead of reseeding in the child, you can perturb the state in the parent
after fork. As far as I understand, only the child callback in
Serhiy Storchaka added the comment:
Not sure that's necessary. The code to fix the C-style %-formatting is
already (I think) in the last patch I attached.
Could you please extract this part of the patch and add tests? It can be
reviewed and committed separately. See also issue18780, there
Eric V. Smith added the comment:
I agree splitting this makes sense, so as to not delay the %-formatting fix.
While similar in principle, the fixes are unrelated. We may as well keep this
issue the __format__ part, since it's been most discussed here.
--
Eli Bendersky added the comment:
On Wed, Aug 21, 2013 at 6:40 AM, Eric V. Smith rep...@bugs.python.orgwrote:
Eric V. Smith added the comment:
I agree splitting this makes sense, so as to not delay the %-formatting
fix. While similar in principle, the fixes are unrelated. We may as well
Serhiy Storchaka added the comment:
How about passing on UnicodeError?
I don't see how it will resolve any problem.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15809
___
Eli Bendersky added the comment:
Serhiy, if you feel this is related to #18780 maybe they can be merged into a
single issue (since the comment on #18780 says the fix here will work there
too)?
--
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
I rather think that two discussions about two almost unrelated series of
patches in same issue will be confused.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18738
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +barry, eli.bendersky, eric.smith, ethan.furman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18780
___
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18713
___
irdb added the comment:
Oops! My problem is that I get Unsupported characters in input when trying to
type any Unicode string in IDLE's interactive mode.
e.g. a simple command like: s = u'Русский текст' gives: Unsupported characters
in input
Probably unrelated to the issue at hand. I don't
Charles-François Natali added the comment:
2013/8/21 Antoine Pitrou rep...@bugs.python.org:
Instead of reseeding in the child, you can perturb the state in the parent
after fork.
As far as I understand, only the child callback in pthread_atfork() needs
to be async-signal-safe:
That's not
Richard Oudkerk added the comment:
On 21/08/2013 3:46pm, Charles-François Natali wrote:
Another, probably cleaner way would be to finally add the atfork()
module (issue #16500), and register this reseed hook (which could then
be implemented in ssl.py).
Wouldn't that still suffer from the
Antoine Pitrou added the comment:
[snip insightful explanation]
So it's not really safe either, although the window is narrower.
Gosh. Well, the narrower window would be fine with me :-)
--
___
Python tracker rep...@bugs.python.org
Raymond Hettinger added the comment:
Antoine, can you please verify the gdb plug-in is working again?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18772
___
New submission from Vajrasky Kok:
There is a dormant test in Lib/test/test_xmlrpc.py (line 579):
# [ch] The test 404 is causing lots of false alarms.
def XXXtest_404(self):
# send POST with http.client, it should return 404 header and
# 'Not Found' message.
conn
Guido van Rossum added the comment:
On Wed, Aug 21, 2013 at 2:37 AM, STINNER Victor rep...@bugs.python.orgwrote:
STINNER Victor added the comment:
I like the idea of renaming select to _select, and add Lib/select.py
for the high-level wrapper (Selector). In my opinion, adding a module
Christian Heimes added the comment:
Oh heck, signal, threads and fork really don't mix. :(
Under which condition can a non-async safe function cause trouble? Is it just
fork() inside a signal handler or can an incoming signal during fork() also
cause havoc?
The OpenSSL PRNG is only buggy when
Roundup Robot added the comment:
New changeset 84d74eb7a341 by Charles-François Natali in branch '2.7':
Issue #15233: Python now guarantees that callables registered with the atexit
http://hg.python.org/cpython/rev/84d74eb7a341
--
___
Python tracker
Charles-François Natali added the comment:
Another, probably cleaner way would be to finally add the atfork()
module (issue #16500), and register this reseed hook (which could then
be implemented in ssl.py).
Wouldn't that still suffer from the double-fork() issue?
Not for the officially
Charles-François Natali added the comment:
Backported to 2.7.
--
resolution: - fixed
stage: commit review - committed/rejected
status: open - closed
versions: -Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15233
Charles-François Natali added the comment:
LGTM
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18792
___
___
Python-bugs-list mailing list
R. David Murray added the comment:
A lot of false alarms means usually it works, but then sometimes it doesn't.
So just testing it on a couple of platforms isn't sufficient, unfortunately.
--
nosy: +r.david.murray
___
Python tracker
New submission from icedream91:
The document (http://docs.python.org/3/library/fractions.html) doesn't mention
Fraction's numerator and denominator properties, I knew these properties from
dir().
Since sometimes these two properties are very useful, for example:
Oscar Benjamin added the comment:
I just noticed today that the fix that implemented by these patches
(only providing -mno-cygwin if gcc_ver 4) is also used by numpy's
distutils. You can see the relevant code here:
Changes by Charles-François Natali cf.nat...@gmail.com:
--
nosy: +sbt
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18763
___
___
Python-bugs-list
Raymond Hettinger added the comment:
I think we shouldn't distinguish between debug and non-debug mode.
That makes good sense.
Attaching a new patch without the #ifdefs.
--
Added file: http://bugs.python.org/file31402/no_refcnt_dummy2.diff
___
R. David Murray added the comment:
Backward compatibility is a concern. However, having the flags test true when
present, which they don't currently, should be considered a bug fix, I think.
So, I added a some tests to confirm the current behavior, and wrote a new patch
that *just* fixes the
R. David Murray added the comment:
Woops, corrupted patch, and I see a bug...
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16611
___
___
Changes by R. David Murray rdmur...@bitdance.com:
Removed file: http://bugs.python.org/file31403/cookie_flags.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16611
___
Ethan Furman added the comment:
I'll get my patch separated and over here when I get back home (on a business
trip at the moment).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18780
___
R. David Murray added the comment:
Corrected patch.
--
Added file: http://bugs.python.org/file31405/cookie_flags.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16611
___
STINNER Victor added the comment:
Updated patch: move tests to the right test files and test that close() can be
called more than once.
--
Added file: http://bugs.python.org/file31404/devpoll_close-2.patch
___
Python tracker rep...@bugs.python.org
Changes by Richard Oudkerk shibt...@gmail.com:
--
resolution: - duplicate
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18793
___
Changes by Charles-François Natali cf.nat...@gmail.com:
--
resolution: - duplicate
stage: needs patch - committed/rejected
status: open - closed
superseder: - Add an 'atfork' module
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset e1fdd79cfb01 by Richard Oudkerk in branch 'default':
Issue #18762: Print debug info on failure to create new forkserver process.
http://hg.python.org/cpython/rev/e1fdd79cfb01
--
nosy: +python-dev
___
Changes by Guido van Rossum gu...@python.org:
--
nosy: -gvanrossum
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18794
___
___
Python-bugs-list
Roundup Robot added the comment:
New changeset 6bc533d06cf1 by Serhiy Storchaka in branch '3.3':
Issue #17119: Fixed integer overflows when processing large strings and tuples
http://hg.python.org/cpython/rev/6bc533d06cf1
New changeset b500daaee7d0 by Serhiy Storchaka in branch 'default':
Issue
Changes by vengefulgash45 turkeysa...@gmail.com:
Added file: http://bugs.python.org/file31406/test1.html
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12641
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
status: open - pending
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15175
___
___
Changes by Charles-François Natali cf.nat...@gmail.com:
--
title: Test - Remove -mno-cygwin from distutils
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12641
___
Changes by fancyguidebook6 turkeysa...@gmail.com:
--
title: Remove -mno-cygwin from distutils - Test
Added file: http://bugs.python.org/file31407/test1.html
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12641
Changes by Eric Snow ericsnowcurren...@gmail.com:
--
nosy: +eric.snow
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16938
___
___
Python-bugs-list
Changes by spiffykismet73 turkeysa...@gmail.com:
--
title: Remove -mno-cygwin from distutils - Test
Added file: http://bugs.python.org/file31408/test1.html
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12641
Changes by Eric Snow ericsnowcurren...@gmail.com:
--
nosy: +eric.snow
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17972
___
___
Python-bugs-list
Changes by Éric Araujo mer...@netwok.org:
Removed file: http://bugs.python.org/file31406/test1.html
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12641
___
Changes by Éric Araujo mer...@netwok.org:
Removed file: http://bugs.python.org/file31407/test1.html
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12641
___
Changes by Éric Araujo mer...@netwok.org:
Removed file: http://bugs.python.org/file31408/test1.html
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12641
___
New submission from Eric Snow:
pprint.pprint(inspect.classify_class_attrs(object))
[Attribute(name='__class__', kind='data', defining_class=class 'object',
object=attribute '__class__' of 'object' objects),
...
Attribute(name='__init__', kind='method', defining_class=class 'object',
Changes by Christian Heimes li...@cheimes.de:
--
title: Test - Remove -mno-cygwin from distutils
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12641
___
Alexandre Dias added the comment:
Average time would indeed be a better description.
As for its usefulness: let's say that for example you would want to find the
function in which your code spends the most time on average, in order to later
optimise said function. If one of the calls to
gaudyallure52 added the comment:
Test
--
nosy: +gaudyallure52
title: Remove -mno-cygwin from distutils - Test
Added file: http://bugs.python.org/file31409/test1.html
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12641
Changes by Éric Araujo mer...@netwok.org:
--
Removed message: http://bugs.python.org/msg195820
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12641
___
Changes by Benjamin Peterson benja...@python.org:
Removed file: http://bugs.python.org/file31409/test1.html
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12641
___
1 - 100 of 148 matches
Mail list logo
