Stefan Behnel added the comment:
The way the XMLPullParser is implemented in lxml.etree now is that it simply
inherits from XMLParser. This would also make sense for ElementTree, even
before supporting arbitrary targets. The patch in ticket #18990 makes this
simple to do.
For reference, here
Stefan Behnel added the comment:
The way the XMLPullParser is implemented in lxml.etree now is that it simply
inherits from XMLParser. This would also make sense for ElementTree, even
before supporting arbitrary targets. The patch in ticket #18990 makes this
simple to do.
For reference, here
Senthil Kumaran added the comment:
I have a slight fear that this patch could be considered as a feature addition
in 2.7 urllib.py, I would like to quell that and ensure that behaviour
expectation is consistent when using urllib or urllib2 and latest
urllib/request.py modules.
Also, tests +
Roundup Robot added the comment:
New changeset a58b620e4dc9 by Senthil Kumaran in branch '2.7':
Fix SimpleHTTPServer's request handling case on trailing '/'.
http://hg.python.org/cpython/rev/a58b620e4dc9
New changeset 1fcccbbe15e2 by Senthil Kumaran in branch '3.3':
Fix http.server's request
Senthil Kumaran added the comment:
Thanks for the patches, Vajrasky and Karl. Fixed in currently active (3.4,3.3
and 2.7) versions of python.
--
assignee: - orsenthil
resolution: - fixed
stage: test needed - committed/rejected
status: open - closed
versions: -Python 3.2
Serhiy Storchaka added the comment:
Here is a patch. It get rid of TextWrap.shorten() because TextWrap.fill()
supersedes it and because placeholder now a parameter of TextWrap. Module
level shorten() is left but I doubt about it.
--
keywords: +patch
stage: test needed - patch review
Serhiy Storchaka added the comment:
Oh, seems I again did not attach a patch. Now I understand why there were no
any feedback so long time.
--
keywords: +needs review, patch
Added file: http://bugs.python.org/file31737/re_group_type.patch
___
Python
Antoine Pitrou added the comment:
Are there tests for all the builtin scalars?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18682
___
___
Roundup Robot added the comment:
New changeset c7fdb0637d0b by Serhiy Storchaka in branch 'default':
Issue #18818: The encodingname part of PYTHONIOENCODING is now optional.
http://hg.python.org/cpython/rev/c7fdb0637d0b
--
nosy: +python-dev
___
Serhiy Storchaka added the comment:
Thank you Ezio and Vajrasky for the review.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
type: behavior - enhancement
versions: -Python 2.7, Python 3.3
___
Python tracker
Lars Buitinck added the comment:
Ok. Do you (or jnoller?) have time to review my proposed patch, at least before
3.4 is released? I didn't see it in the release schedule, so it's probably not
planned soon, but I wouldn't want the API to change *again* in 3.5.
--
Changes by Serhiy Storchaka storch...@gmail.com:
--
status: open - pending
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9951
___
___
New submission from Laurence McGlashan:
Traceback (most recent call last):
File string, line 1, in module
File /usr/lib64/python2.7/site-packages/sk1/__init__.py, line 21, in
module
app.main.main()
File /usr/lib64/python2.7/site-packages/sk1/app/main.py, line 150, in main
Michael Foord added the comment:
Well, they actually test slightly different scenarios - they're *not* just
duplicates of each other.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18993
Changes by Laurence McGlashan laurence.mcglas...@gmail.com:
--
type: - crash
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19008
___
___
Roundup Robot added the comment:
New changeset 63f25483c8f6 by Eli Bendersky in branch '3.3':
Issue #18945: Add tests for tempfile name collision handling.
http://hg.python.org/cpython/rev/63f25483c8f6
New changeset c902ceaf7825 by Eli Bendersky in branch 'default':
Issue #18945: Add tests for
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
resolution: - duplicate
status: open - closed
superseder: - Security bug in tkinter allows for untrusted, arbitrary code
execution.
___
Python tracker rep...@bugs.python.org
Eli Bendersky added the comment:
Thanks Vlad, committed to 3.3/3.4; would you like to provide the 2.7 patch?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18945
___
Changes by Eli Bendersky eli...@gmail.com:
--
nosy: -eli.bendersky
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18911
___
___
Python-bugs-list
Eli Bendersky added the comment:
I can't reproduce it with the most recent default branch (Python 3.4.0a2+
(default:c7fdb0637d0b, Sep 13 2013, 05:29:00)) either.
Unless I'm missing something, there's no issue here. Let me know if something
else can be done. Otherwise I'll close the issue in a
Changes by Vlad Shcherbina vlad.shcherb...@gmail.com:
Added file: http://bugs.python.org/file31739/tempfile_collision_tests_27
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18945
___
Roundup Robot added the comment:
New changeset 39823ebfc731 by Eli Bendersky in branch '3.3':
Issue #18997: fix ElementTree crash with using pickle and __getstate__.
http://hg.python.org/cpython/rev/39823ebfc731
New changeset bda5a87df1c8 by Eli Bendersky in branch 'default':
Merge for Issue
Eli Bendersky added the comment:
Fixed the patch and committed. Thanks.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18997
R. David Murray added the comment:
We don't generally backport tests unless they are part of a bug fix. It's not
a blanket prohibition, but normally the risk of false positives in a
maintenance release on platforms not covered by our buildbots outweighs the
benefits of adding the tests.
Arnon Yaari added the comment:
You can follow the discussion I linked in the ticket description for an answer:
http://psf.upfronthosting.co.za/roundup/tracker/issue3532
Mainly the answer is: to conform to PEP 358 and to provide the opposite of
bytes.fromhex.
I agree that you can use binascii,
Serhiy Storchaka added the comment:
Patch updated. Added tests. The locale_alias mapping updated to be
self-consistency (i.e. for every name in locale_alias.values() normalize(name)
== name).
--
assignee: docs@python - serhiy.storchaka
keywords: -easy
nosy: +lemburg
stage: needs
Eli Bendersky added the comment:
On Fri, Sep 13, 2013 at 6:28 AM, R. David Murray rep...@bugs.python.orgwrote:
R. David Murray added the comment:
We don't generally backport tests unless they are part of a bug fix. It's
not a blanket prohibition, but normally the risk of false positives
Changes by Eli Bendersky eli...@gmail.com:
--
nosy: -eli.bendersky
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18844
___
___
Python-bugs-list
New submission from Kristján Valur Jónsson:
Some applications require reading http response data in long polls as it
becomes available. This is used, e.g. to receive notifications over a HTTP
stream.
Using response.read(large_buffer) is not possible because this will attempt to
fullfill the
R. David Murray added the comment:
It would be great if this could get a review by MAL, since it looks like a
non-trivial change.
Also, you have some (commented out) debug prints in there.
--
___
Python tracker rep...@bugs.python.org
Eli Bendersky added the comment:
I agree with David. This is yet another case where we try to go against Python
and make enum special, and I'm against this. Nothing prevents users from
accidentally overriding their own members and methods in normal classes as
well. This is trivially
Marc-Andre Lemburg added the comment:
On 13.09.2013 15:30, Serhiy Storchaka wrote:
Serhiy Storchaka added the comment:
Patch updated. Added tests. The locale_alias mapping updated to be
self-consistency (i.e. for every name in locale_alias.values()
normalize(name) == name).
Could you
Serhiy Storchaka added the comment:
What type should be a result of slicing? List, tuple, deque, other?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17394
___
Claudiu.Popa added the comment:
Serhiy, at the first glance, that repr doesn't make sense to me, thus it seems
a little difficult to comprehend.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17087
Serhiy Storchaka added the comment:
Also, you have some (commented out) debug prints in there.
These debug prints were in old code.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5815
R. David Murray added the comment:
Ah, I see. I only scanned the patch quickly, obviously.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5815
___
R. David Murray added the comment:
If they are part of a bug fix, then sure. That wasn't clear from this issue,
though. On the other hand, if the tests in that other issue cover the actual
bug, and these have any chance of *introducing* test failures (especially if
they are heisenburgs,
Serhiy Storchaka added the comment:
Could you elaborate on the alias changes ?
Were those coming from an updated X11 local.alias file ?
No, they are not from X11 local.alias file. They are a result of the
test_locale_alias self-test, I have fixed all failures.
This test can't be backported
Sam Ferencik added the comment:
Are you asking *what* distutils does?
It tackles the problem completely differently on Windows, Unix, and OS X.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18987
Serhiy Storchaka added the comment:
Here is a patch without changes to locale_alias.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5815
___
___
Changes by Serhiy Storchaka storch...@gmail.com:
Added file: http://bugs.python.org/file31742/locale_parse_2a.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5815
___
Antoine Pitrou added the comment:
Are you asking *what* distutils does?
Yup :-) I'm not a distutils maintainer, so I hardly know how it does
things internally.
It tackles the problem completely differently on Windows, Unix, and
OS X.
Ah... but does it compute the result by itself or simply
Antoine Pitrou added the comment:
This sounds ok on the principle. I suppose one can't simply wrap the fp
inside a BufferedReader?
I think it would be good to add tests for the peek() implementation, though.
--
nosy: +orsenthil, pitrou, serhiy.storchaka
stage: - patch review
versions:
Stefan Behnel added the comment:
Also, +1 for allowing start-ns and end-ns event callbacks on parser targets,
although that's a different feature entirely.
Actually, I take that back. I can't see a use case for this feature, and it
doesn't really fit with the notion of fully qualified tag
Éric Araujo added the comment:
FTR the Mac OS code does some normalization:
http://hg.python.org/cpython/file/bda5a87df1c8/Lib/_osx_support.py#l473
Code for linux just returns the value from uname, as Same said:
http://hg.python.org/cpython/file/bda5a87df1c8/Lib/distutils/util.py#l75
Antoine Pitrou added the comment:
What if I redefine an existing key inside a subclass?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18989
___
Ethan Furman added the comment:
One cannot subclass an Enum that has already defined keys.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18989
___
Kristján Valur Jónsson added the comment:
The problem is that self.fp is already a Buffered stream, and such streams are
documented to have their read() and readinto() calls make multiple system calls
to fullfill the request.
My original goal was actually to make response.read(amt) not try to
Antoine Pitrou added the comment:
On Unix, specifically, the return value is heavily based on os.uname().
Ouch. Then I'm afraid this is a probably a won't fix :-/
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18987
Ethan Furman added the comment:
Perhaps you meant, what if you define a key in a subclass that shadows a
method/property in a parent class?
I'm inclined to say that would be acceptable, since one reason for subclassing
is to add or make changes to the parent class' behavior.
--
Sam Ferencik added the comment:
It's very hacky on all of Windows, Unix, and OS X. That's why I don't feel
confident to propose a solution.
On Unix, specifically, the return value is heavily based on os.uname(). It
seems that the maintainers of OS X have started with the same but then chose
Marc-Andre Lemburg added the comment:
On 13.09.2013 16:34, Serhiy Storchaka wrote:
Serhiy Storchaka added the comment:
Could you elaborate on the alias changes ?
Were those coming from an updated X11 local.alias file ?
No, they are not from X11 local.alias file. They are a result of
Ethan Furman added the comment:
In any other (normal) class, this works:
==
--class Okay:
... red = 1
... green = 2
... blue = 3
... red = 4
Antoine Pitrou added the comment:
My original goal was actually to make response.read(amt) not try to
make multiple read() calls, so that one could have other delimiters
than newline. It is simple for the chunked case, but I don't know
how to bypass it for response.fp, since it is already a
Serhiy Storchaka added the comment:
Then I don't understand changes such as:
-'chinese-s':'zh_CN.eucCN',
+'chinese-s':'zh_CN.gb2312',
or
-'sp': 'sr_CS.ISO8859-5',
-'sp_yu':
Sam Ferencik added the comment:
Well, the maintainers of Mac OS didn't consider it a won't fix - and have this
working properly. I don't see why we couldn't try to copy what they did.
Actually, I think the impact of changing this for 32-bit Python on 64-bit Linux
should be quite small, no?
R. David Murray added the comment:
See also issue 13541?
--
nosy: +r.david.murray
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19009
___
___
Kristján Valur Jónsson added the comment:
Intersting. I didn't know about that. My excuse is that I never use 3.x except
when I'm porting some CCP enhancements for cpython.
Here's a thought: HTTPResponse inherits from RawIOBase. Only the BufferedIO
classes have read1() and are documented
Valerie Lambert added the comment:
Great! Thanks for putting together a list. I've incorporated SuppressCoreFiles
into these tests and have used the test suite without any errors. Again, I'm
testing these on Ubuntu.
--
keywords: +patch
Added file:
Kristján Valur Jónsson added the comment:
I should add, I fully support the use case that response.read(amt=None) needs
to read to the end of the response. It is only the read(amt=bufsize) use case
I'm thinking of, and that could be handled with a read1() method.
--
Eli Bendersky added the comment:
Benjamin, what do you think?
--
nosy: +benjamin.peterson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18945
___
Serhiy Storchaka added the comment:
Well, then first will commit a simpler patch. I left comments on Rietveld.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17087
___
Stefan Behnel added the comment:
I created a separate ticket #19010 for the inheritance issue.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18902
___
Antoine Pitrou added the comment:
Well, the maintainers of Mac OS didn't consider it a won't fix - and
have this working properly. I don't see why we couldn't try to copy
what they did.
Ah, ok. Then a patch would be welcome :-)
Actually, I think the impact of changing this for 32-bit
New submission from Stefan Behnel:
As mentioned in tickets #18902 and #17741, the XMLPullParser in the external
lxml.etree package inherits from the existing XMLParser class. This makes the
interface simpler, both simpler to explain and to implement.
The implementation in ElementTree should
Claudiu.Popa added the comment:
Here's the new version. I added a few replies on the Rietveld.
--
Added file: http://bugs.python.org/file31744/sre_repr2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17087
New submission from Chris Lambacher:
The use case for this is that when you are in a template and you want to use
the Enum instances in a conditional, then you need to pass the Enum class to
the template or start using someenumvariable.__class__.someenumvalue. Instead
it would be useful to be
Ethan Furman added the comment:
-- class Test:
... this = 'that'
... these = 'those'
...
-- Test.this
'that'
-- Test.this.these
Traceback (most recent call last):
File stdin, line 1, in module
AttributeError:
Vajrasky Kok added the comment:
Okay, I found the difference.
The second test case is to test the case on which we delete the attribute of
the mock instance before being referenced by any variable. The we make sure the
attribute is gone for good.
The first test case is to test the case on
Terry J. Reedy added the comment:
I thought that that was the specification*: the encoding comment should be the
first line unless it has to be the second line to allow for an executable
comment. Executing a non-comment first line twice is definitely contrary to the
intent of the PEP.
* I
Claudiu.Popa added the comment:
Added the new version.
--
Added file: http://bugs.python.org/file31746/sre_repr3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17087
___
Ethan Furman added the comment:
My apologies, you are correct.
I am still against this for the Alice reason, but lets see what the others
think.
--
resolution: rejected -
status: closed - open
___
Python tracker rep...@bugs.python.org
Chris Lambacher added the comment:
You are not comparing the same thing. Normally when there is a class parameter,
those are available from instances of the class.
class Test:
...pass
...
Test.this = Test()
Test.that = Test()
Test.this.that
__main__.Test instance at 0x7ff681bd3560
Marc-Andre Lemburg added the comment:
On 13.09.2013 19:24, Terry J. Reedy wrote:
Terry J. Reedy added the comment:
I thought that that was the specification*: the encoding comment should be
the first line unless it has to be the second line to allow for an executable
comment. Executing
Terry J. Reedy added the comment:
[The information in titles, especially long titles that do not fit in the title
box (on my system, at least) should be repeated in the opening message.]
The point of the patch is to use the same name for the same object in the two
columns* and to use a single
Terry J. Reedy added the comment:
Which behavior do you propose to change? Does PEP263 specify the response to a
self-contradictory encoding comment? What do you think it should say?
I raising is the better behavior.
Idle notices that it cannot save the file with iso8859-15 encoding, so it
Changes by Terry J. Reedy tjre...@udel.edu:
--
nosy: +benjamin.peterson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18965
___
___
Roundup Robot added the comment:
New changeset 540a9c69c2ea by Charles-François Natali in branch 'default':
Issue #16201: socket: Use inet_pton()/inet_addr() instead of ad-hoc parsing for
http://hg.python.org/cpython/rev/540a9c69c2ea
--
nosy: +python-dev
Chris Lambacher added the comment:
For what it's worth, I was confused by the inability to access the class
members from the instance for like 3 or 4 weeks until I realized that the
instances were not actually on the class and the implications of that for class
attribute access.
--
Changes by Terry J. Reedy tjre...@udel.edu:
--
nosy: +terry.reedy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18968
___
___
Python-bugs-list
Changes by Terry J. Reedy tjre...@udel.edu:
--
components: +Tests
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18968
___
___
Python-bugs-list
Changes by Terry J. Reedy tjre...@udel.edu:
--
nosy: +terry.reedy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18974
___
___
Python-bugs-list
Terry J. Reedy added the comment:
I like the current division, but agree that
The TestCase class provides a number of methods to check for and
report failures, such as:
is slightly misleading. I would change it to
The TestCase class provides a number of methods to check for and
report
Brett Cannon added the comment:
Attached is my rough attempt at a script to auto-generate Misc/NEWS from commit
logs. Key points:
- Works from the hg log in XML format as dumped to a file
- Considers a commit newsworthy if it isn't a merge and either has an issue
number or has an interesting
Roy Smith added the comment:
The new text suggested by terry.reedy works for me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19006
___
___
Antoine Pitrou added the comment:
I like the script name :-)... Other than that, can you attach a NEWS file such
as generated by this script?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18967
py.user added the comment:
ok, I will repeat patch contents in message by words to avoid guessing
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18951
___
Brett Cannon added the comment:
Example file at Antoine's request. Just don't forget, very rough and not at all
finished. =) We probably can't use something like this until Python 3.5 in
order to make sure everyone uses commit messages that make sense, but you can
get a sense of whether it
py.user added the comment:
Senthil Kumaran changed the pattern
from: r'^See (http://www\.python\.org/[^/]+/license.html)$'
to: r'^See (http://www\.python\.org/download/releases/[^/]+/license/)$'
test doesn't pass
[guest@localhost cpython]$ ./python
Python 3.4.0a2+ (default, Sep 14 2013,
Ezio Melotti added the comment:
Fixed, thanks for the report and the patch!
I also updated the table entry for assertRaisesRegex and assertWarnsRegex.
I avoid using regex instead of re or r to keep it short and avoid
confusion with the re/regex modules. The documentation of the methods uses
Changes by Tshepang Lekhonkhobe tshep...@gmail.com:
--
nosy: +tshepang
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18967
___
___
Changes by py.user bugzilla-mail-...@yandex.ru:
--
status: closed - pending
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18206
___
___
Antoine Pitrou added the comment:
Decisions to make:
Another important question: how do we manage manual edits to Misc/NEWS? Is the
script smart enough to recognize those edits and not override them?
--
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset 03e94f9884ce by Ezio Melotti in branch '3.3':
#18951: use consistent names in unittest docs.
http://hg.python.org/cpython/rev/03e94f9884ce
New changeset eb332e3dc303 by Ezio Melotti in branch 'default':
#18951: merge with 3.3.
New submission from Sjoerd:
I'm sorry for providing very little information, but I don't have the system at
hand anymore. Therefore I will try to reproduce what I know, hoping that you
recognise the problem. If not, I will get back to the system and try to obtain
the necessary information.
Antoine Pitrou added the comment:
Question: should the default level threshold be INFO or WARNING?
My initial patch uses INFO, but WARNING might be better since that's also
logging's default level filter when not configured.
--
___
Python tracker
Serhiy Storchaka added the comment:
Here is an alternative C implementation. It adds to the dict class support of
the __transform__() method. If this method is defined in dict subclass it used
to transforming keys. collections.TransformDict is just utilizes this feature
as
Serhiy Storchaka added the comment:
Does it slow down regular dicts?
I were surprized, but yes. The ComplexPythonFunctionCalls test from pybench is
40% slower with ctransformdict.patch (and I still don't known why). With
dict__transform__.patch it is only 2% slower. All other pybench tests
New submission from Antoine Pitrou:
Nothing happens when you try to execute it on the command line:
$ ./python -m unittest.test
/home/antoine/cpython/default/python: No module named unittest.test.__main__;
'unittest.test' is a package and cannot be directly executed
$ ./python -m
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +scoder
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18059
___
___
Python-bugs-list
1 - 100 of 164 matches
Mail list logo
