[issue19378] Clean up Python 3.4 API additions in the dis module

2013-11-03 Thread Nick Coghlan
Nick Coghlan added the comment: I think it's a good idea in principle, but unrelated to this patch :) This one started as reworking line_offset as a more intuitive first_line parameter, and then testing and documenting that change proceeded to reveal a number of other issues with the 3.4 API

[issue19378] Clean up Python 3.4 API additions in the dis module

2013-11-03 Thread Nick Coghlan
Nick Coghlan added the comment: There was another change implemented as part of this: trailing whitespace is now stripped from the lines emitted by the disassembler, which made it possible to simplify the tests a bit (since they no longer have to strip that whitespace themselves, they can

[issue19484] Idle crashes when opening file

2013-11-03 Thread Jerry Barrington
Jerry Barrington added the comment: Thank you, that fix worked perfectly. Only one weird thing. I have IDLE's preferences set to At Startup: Open Shell Window. If I double click a *.py file while IDLE isn't running, the shell pops up, then the py file pops up, then the shell goes away. Not

[issue19440] Clean up test_capi

2013-11-03 Thread Zachary Ware
Zachary Ware added the comment: Well, this is embarrassing. I'm so used to there not being much difference between 3.3 and 3.4; I didn't even think about subTest being new, and obviously I didn't test it as I should have. Here's a new patch for 3.3 (tested this time!) that just removes the

[issue19391] Fix PCbuild/readme.txt in 2.7 and 3.3

2013-11-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 7b6ac858bb17 by Zachary Ware in branch '2.7': Issue #19391: Clean up PCbuild/readme.txt http://hg.python.org/cpython/rev/7b6ac858bb17 New changeset f28a2d072767 by Zachary Ware in branch '3.3': Issue #19391: Clean up PCbuild/readme.txt

[issue19391] Fix PCbuild/readme.txt in 2.7 and 3.3

2013-11-03 Thread Zachary Ware
Zachary Ware added the comment: Thanks for the lesson, Vajrasky and David, and thank you for the review Brian. The final commit did have a couple changes not in the posted patch, just fixes of the same two obvious typos in both branches (avalible - available, lniked - linked). --

[issue19488] idlelib tests are silently skipped by test.regrtest on 2.7

2013-11-03 Thread Ned Deily
New submission from Ned Deily: Running test_idle is supposed to cause the tests in Lib/idlelib/idle_test to be run. Unfortunately, under 2.7, when test.regrtest is used as the test runner, either directly or via make test (which buildbots use), the idlelib tests are currently silently

[issue15392] Create a unittest framework for IDLE

2013-11-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset dac6aea39814 by Ned Deily in branch '2.7': Issue #15392: Install idlelib/idle_test. http://hg.python.org/cpython/rev/dac6aea39814 New changeset e52dad892521 by Ned Deily in branch '3.3': Issue #15392: Install idlelib/idle_test.

[issue4331] Add functools.partialmethod

2013-11-03 Thread Vajrasky Kok
Vajrasky Kok added the comment: Should we add partialmethod to __all__ for consistency? -- nosy: +vajrasky ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4331 ___

[issue17883] Fix buildbot testing of Tkinter

2013-11-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 358496e67a89 by Zachary Ware in branch '2.7': Issue #17883: Backport test.test_support._is_gui_available() http://hg.python.org/cpython/rev/358496e67a89 -- ___ Python tracker rep...@bugs.python.org

[issue17883] Fix buildbot testing of Tkinter

2013-11-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 72c3ca3ed22a by Zachary Ware in branch '2.7': Issue #17883: Tweak test_tcl testLoadWithUNC to skip the test in the http://hg.python.org/cpython/rev/72c3ca3ed22a -- ___ Python tracker

[issue17883] Fix buildbot testing of Tkinter

2013-11-03 Thread Zachary Ware
Zachary Ware added the comment: I'll leave this open until the buildbots prove happy. I did make a couple extra changes to the patch to TclTest.testLoadWithUNC to make a couple of skip conditions actually report a skip instead of just returning, and to remove a superfluous 'import sys'.

[issue19488] idlelib tests are silently skipped by test.regrtest on 2.7

2013-11-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: Good catch. I confirmed the non-function, the silence, and the fix. Ned, because the patch included a commit message, hg import immediately committed the patch with the incomplete message. This surprised me since it has never happened before. Since the patch

[issue19486] Bump up version of Tcl/Tk in building Python in Windows platform

2013-11-03 Thread Zachary Ware
Zachary Ware added the comment: Vajrasky Kok wrote: When building Python in Windows in release mode (not debug mode), I had to download the Tcl/Tk binary build from ActiveState It is a bit of a hassle, but you can build your own Release mode Tcl/Tk; there are instructions in the newly

[issue18985] Improve the documentation in fcntl module

2013-11-03 Thread Vajrasky Kok
Vajrasky Kok added the comment: Except for the typo noticed by Victor, your patch looks good. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18985 ___

[issue19489] move quick search box above TOC

2013-11-03 Thread Georg Brandl
New submission from Georg Brandl: From Mark Summerfield:, The Quick search box is really useful, but it is annoying that its position varies from page to page. On pages with long tables of contents it is often out of sight. Why not put it above the Table of Contents. That way

[issue19488] idlelib tests are silently skipped by test.regrtest on 2.7

2013-11-03 Thread Ned Deily
Ned Deily added the comment: Terry, sorry the patch was confusing. Just FYI, if you are using hg import particularly when reviewing patches, you should always be using hg import --no-commit as explained in the devguide to avoid unintended changes. Whether or not a message is included in the

[issue19481] IDLE hangs while printing instance of Unicode subclass

2013-11-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: I am curious too, so I traced through the call chain. In PyShell.py 1343: PseudoOutputFile.write(s) calls: self.shell.write(s, self.tags) 914: shell is an instance of PyShell and self.tags is 'stdout', 'stderr', or 'console'. 1291: PyShell.write(s,tags) calls:

<    1   2