Eric Snow added the comment:
I'm fine with leaving __spec__ as None for those remaining cases. It
definitely simplifies this ticket. :) Do you see any reason to not close this
one at this point?
--
___
Python tracker rep...@bugs.python.org
Nick Coghlan added the comment:
I think we need to document this somewhere. Not exactly sure where though - a
new subsection in the import reference, perhaps?
--
title: refactor pythonrun.c to make use of specs (__main__.__spec__) -
Document the possible values for __main__.__spec__
Serhiy Storchaka added the comment:
Oh, I had not compiled the code after last change, so first patch is wrong.
Here is fixed patch.
--
Added file: http://bugs.python.org/file33307/source_encoding_second_line_2.patch
___
Python tracker
New submission from Thomas Levine:
This works fine in Python 2.7, but it fails in Python 3.3.
[tlevine@wildebeest mailfest-scoreboard]$ python3 --version
Python 3.3.3
[tlevine@wildebeest mailfest-scoreboard]$ python3 setup.py register sdist
running register
Traceback (most recent call last):
Roundup Robot added the comment:
New changeset ea0aa3e32ab5 by Martin v. Löwis in branch '3.3':
Issue #17432: Drop UCS2 from names of Unicode functions in python3.def.
http://hg.python.org/cpython/rev/ea0aa3e32ab5
New changeset 0ea09c824d9b by Martin v. Löwis in branch 'default':
Merge with
Thomas Levine added the comment:
The relevant section distutils/config.py seems no different in Python 2.7, so
now I see this as a bug in configparser.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20120
Thomas Levine added the comment:
Hmm now it looks to me like this is the intended behavior.
http://hg.python.org/cpython/file/ea0aa3e32ab5/Lib/test/test_configparser.py#l1541
Switching the single percent sign (%) to two (%%) in .pypirc makes it work.
Maybe we can make a nicer error message
Martin v. Löwis added the comment:
This is now fixed for 3.3 and 3.4. Sorry it took so long.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17432
___
Changes by Martin v. Löwis mar...@v.loewis.de:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19526
___
Martin v. Löwis added the comment:
Since 3.2 has seen its last bugfix release, this won't be added to 3.2 anymore.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13115
Changes by Antoine Pitrou pit...@free.fr:
--
stage: - needs patch
type: compile error - behavior
versions: +Python 3.3, Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20115
___
New submission from Fred Stober:
While trying to encode some binary data, I encountered this behaviour of the
quopri_codec:
'\r\n\n'.encode('quopri_codec').decode('quopri_codec')
'\r\n\r\n'
'\n\r\n'.encode('quopri_codec').decode('quopri_codec')
'\n\n'
If this behaviour is really intended,
Serhiy Storchaka added the comment:
Indeed. CPython parser reads first line '#\x00\n' and save it in the buffer.
But because C strings are used here (result of decode_str()), the line is
truncated to '#'. As far as this data is not ended by '\n', it considered
incomplete and next line is
Serhiy Storchaka added the comment:
Docstrings for new codecs mention bytes.transform() and bytes.untransform()
which are nonexistent.
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7475
Nick Coghlan added the comment:
Raymond, will you have a chance to look at this before 3.4rc1? Otherwise I'd
like to take it.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2226
___
Nick Coghlan added the comment:
Raymond, will you have a chance to look at this before 3.4rc1? Otherwise I'd
like to take it.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8743
___
Nick Coghlan added the comment:
Closing this as a duplicate of issue 7434 (which is about redesigning pprint to
make it easier to add support for new types)
--
nosy: +ncoghlan
resolution: accepted - duplicate
stage: patch review - committed/rejected
status: open - closed
superseder: -
Nick Coghlan added the comment:
With PEP 443 added for Python 3.4, I believe Łukasz intended to pursue a new
pprint implementation based on functools.singledispatch.
That has obviously missed feature freeze for Python 3.4, but it's still a
reasonable idea to pursue for 3.5.
In addition to
Richard Oudkerk added the comment:
It is probably harmless then.
I don't think increasing the timeout is necessary -- the multiprocessing tests
already take a long time.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20114
R. David Murray added the comment:
It could be an issue of which configparser is/was used.
--
nosy: +lukasz.langa, r.david.murray
versions: +Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20120
Changes by R. David Murray rdmur...@bitdance.com:
--
nosy: +r.david.murray
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20121
___
___
Benjamin Peterson added the comment:
I guess NULL bytes should just be banned.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20115
___
___
New submission from Serhiy Storchaka:
Proposed patch moves CallTips tests from Lib/idlelib/CallTips.py to
Lib/idlelib/idle_test/test_calltips.py and converts them to unittests.
Private keyword-only parameter _namespace was added to fetch_tip() and
get_entity().
--
components: IDLE,
Changes by Serhiy Storchaka storch...@gmail.com:
--
dependencies: +Move CallTips tests to idle_tests
versions: +Python 2.7 -Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16630
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
dependencies: +Move CallTips tests to idle_tests
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19903
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
dependencies: +Move CallTips tests to idle_tests
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16655
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
dependencies: +Move CallTips tests to idle_tests
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7883
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
dependencies: +Move CallTips tests to idle_tests
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16638
___
Roundup Robot added the comment:
New changeset b72c5573c5e7 by Serhiy Storchaka in branch 'default':
Issue #15027: Rewrite the UTF-32 encoder. It is now 1.6x to 3.5x faster.
http://hg.python.org/cpython/rev/b72c5573c5e7
--
nosy: +python-dev
___
Serhiy Storchaka added the comment:
I have doubts about this issue, so I have unassigned it from myself.
--
assignee: serhiy.storchaka -
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17576
Serhiy Storchaka added the comment:
Thank you Gregory for your review.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15027
Antoine Pitrou added the comment:
In 3.x, the ConfigParser class is 2.x's SafeConfigParser, and the parsing rules
are different (stricter, it seems).
It's probably a won't fix, I'd say.
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
Larry Hastings added the comment:
Yeah, unless there was a *huge* amount of support for changing this, it's way
too late for 3.4.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19977
___
Larry Hastings added the comment:
So, not to yank your chain, but... I'm okay with checking this in. Yes, we're
already in beta, but ModuleSpec is brand new, and the sense I get is that this
use case is obscure even for ModuleSpec. The only installed base is beta 1
users, and given that
R. David Murray added the comment:
More rational is probably closer to the truth :).
Yeah, it's probably a won't fix, but it would be nice to have Łukasz's input.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20120
Antoine Pitrou added the comment:
Ideally, we'd also have a standard lazy import mechanism in 3.5, so these
definitions could go in the collections module, but only installed if pprint
was also imported.
That sounds more like an on-import hook than a lazy import mechanism, no?
--
Antoine Pitrou added the comment:
Oops... no, it's not easy.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7434
___
___
Python-bugs-list
Antoine Pitrou added the comment:
Ok, so why did Roundup add the easy keyword and doesn't want to remove it?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7434
___
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
keywords: -easy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7434
___
___
Python-bugs-list
Larry Hastings added the comment:
Isn't this a new feature?
--
nosy: +larry
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15027
___
___
Larry Hastings added the comment:
I'm willing to risk it in 3.4. Can you check it in in the next twelve hours?
(Sorry for the short notice, it slipped my mind until just now.)
--
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset c4ababa110a2 by Larry Hastings in branch 'default':
Issue #19976: Argument Clinic METH_NOARGS functions now always
http://hg.python.org/cpython/rev/c4ababa110a2
--
nosy: +python-dev
___
Python tracker
Serhiy Storchaka added the comment:
Sorry if I have missed. Should I revert changeset b72c5573c5e7?
This patch doesn't introduce new functions and doesn't change behavior. Without
this patch the UTF-32 encoder is up to 2.5x slower in 3.4 than in 3.3 (due to
issue12892).
--
Larry Hastings added the comment:
Would you describe it as a bug fix or a security fix? If it's neither of
those things, then you need special permission to add it during beta. And
given that this patch has the possibility of causing bugs, I'd prefer to not
accept it for 3.4.
Please revert
Changes by Ned Deily n...@acm.org:
--
nosy: +georg.brandl
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20119
___
___
Python-bugs-list mailing
Serhiy Storchaka added the comment:
Here is a patch with tests for all supported compression types.
--
keywords: +patch
stage: needs patch - patch review
Added file: http://bugs.python.org/file33309/zipfile_eof.patch
___
Python tracker
Eric Snow added the comment:
I'll commit it in a little while. Thanks.
--
versions: +Python 3.4 -Python 3.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19927
___
Roundup Robot added the comment:
New changeset e2280bf5c263 by Larry Hastings in branch 'default':
Issue #19659: Added documentation for Argument Clinic.
http://hg.python.org/cpython/rev/e2280bf5c263
--
nosy: +python-dev
___
Python tracker
Larry Hastings added the comment:
I hid it in the howto directory. Nobody'll look in there! :D
--
assignee: - larry
resolution: - fixed
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset 1e345924f7ea by Serhiy Storchaka in branch 'default':
Reverted changeset b72c5573c5e7 (issue #15027).
http://hg.python.org/cpython/rev/1e345924f7ea
--
___
Python tracker rep...@bugs.python.org
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: fixed -
stage: committed/rejected - patch review
status: closed - open
versions: +Python 3.5 -Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15027
Antoine Pitrou added the comment:
I hid it in the howto directory. Nobody'll look in there! :D
I think using a dotfile would make the hiding more efficient.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19659
Gregory P. Smith added the comment:
I'd rather see it bake in psutils for a while longer regardless of
implementation.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19843
___
Roundup Robot added the comment:
New changeset acebe574ab08 by Eric Snow in branch 'default':
Issue #19708: Update pkgutil to use the new importer APIs.
http://hg.python.org/cpython/rev/acebe574ab08
--
nosy: +python-dev
___
Python tracker
Roundup Robot added the comment:
New changeset a18c1a4cf30a by Eric Snow in branch 'default':
Issue #19713: Move away from using find_module/load_module.
http://hg.python.org/cpython/rev/a18c1a4cf30a
--
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset a72a0e4dad20 by Eric Snow in branch 'default':
Issue #19927: Add __eq__ to path-based loaders in importlib.
http://hg.python.org/cpython/rev/a72a0e4dad20
--
nosy: +python-dev
___
Python tracker
Changes by Eric Snow ericsnowcurren...@gmail.com:
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19927
Eric Snow added the comment:
There wasn't much left to do for pkgutil after all. :)
--
resolution: - fixed
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19708
Eric Snow added the comment:
At this point the only places using find_module and load_module are pydoc,
importlib, and some oddballs that aren't worth worrying about. Issue #19703
covers the pydoc changes.
--
dependencies: +Update pydoc to PEP 451
New submission from Eric Snow:
I'm guessing this is a very seldom (never?) used code path. I've included a
patch to test and fix the problem. The patch includes several related tests
for pydoc.
$ py3 -c 'import pydoc;
Eric Snow added the comment:
Here's a new patch relative to the patch for issue #20123.
--
dependencies: +pydoc.synopsis fails to load binary modules
Added file: http://bugs.python.org/file33310/issue19703-use-new-api.diff
___
Python tracker
Changes by Eric Snow ericsnowcurren...@gmail.com:
Removed file: http://bugs.python.org/file33302/issue19703-use-new-api.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19703
___
Eric Snow added the comment:
FYI, I found this while working on issue #19703.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20123
___
___
Eric Snow added the comment:
I should clarify. That last commit was not the patch that adds the warnings.
I'm going to update that patch and attach it here when I get the chance.
--
___
Python tracker rep...@bugs.python.org
New submission from R. David Murray:
The docs say that you can specify 'atTime' with a 'when' of 'midnight', but
that makes no sense on the face of it. atTime with a weekday specification
makes sense, but it would also make sense to use atTime with a when of D (and
an interval), which is not
Arfrever Frehtes Taifersar Arahesis added the comment:
About last commit: Is there a way to avoid using private objects when removing
uses of load_module?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19713
Nick Coghlan added the comment:
Arfrever: not at this point. We really should have an
importlib.util.load_from_spec() that hides those internal details.
Larry - can we get away with adding that? It didn't become obvious it was a
missing API until Eric started doing these conversions.
New submission from Eric Snow:
In issue #19713, it came up that while PEP 451 deprecated Loader.load_module(),
it did not provide a suitable replacement for calling it directly. We've
worked around this in the stdlib by making calls to private APIs, but that
won't work so well for the
Eric Snow added the comment:
Hmm. That's a good question. There really isn't a simple, public-API
replacement. I've opened issue #20125 to discuss our options. Feel free to
offer any suggestions there. Thanks for bringing this up.
--
___
Changes by Eric Snow ericsnowcurren...@gmail.com:
--
nosy: +larry
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20125
___
___
Python-bugs-list
Larry Hastings added the comment:
Well please get a second opinion. I don't know why you added me, I'm not
qualified.
--
nosy: +brett.cannon, ncoghlan
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20123
Larry Hastings added the comment:
Doesn't help on Windows, junior!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19659
___
___
Python-bugs-list
Eric Snow added the comment:
Not sure why I nosy'ed you, either. :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20123
___
___
Larry Hastings added the comment:
You broke buildbots. Please fix.
http://buildbot.python.org/all/builders/AMD64%20FreeBSD%2010.0%203.x/builds/1389
--
assignee: - eric.snow
priority: normal - high
resolution: fixed -
stage: committed/rejected - needs patch
status: closed - open
Larry Hastings added the comment:
Hmm, hard to see how you caused that with the path loader change. Still please
take a quick look.
I fired off another build to see if it was a transient error, but that'll take
a while.
--
___
Python tracker
Eric Snow added the comment:
I'll take a look. It could be something with #19713 or #19708 that also failed
there.
The other failing buildbot for those 3 changesets is
http://buildbot.python.org/all/builders/x86%20Windows7%203.x/builds/7800.
--
R. David Murray added the comment:
In 2.7 the code just does an open. Victor changed it to call tokenize.open in
3.2, but tokenize.open obviously only works on python source files. So the
logic of that method is now completely wrong.
I'm not sure the logic made a lot of sense even
Eric Snow added the comment:
Thanks for taking a look. Here's the patch that I totally forget to attach.
--
keywords: +patch
Added file: http://bugs.python.org/file33311/issue20123-fix-pydoc-synopsis.diff
___
Python tracker rep...@bugs.python.org
New submission from lo...@blossomhillranch.com:
Events added after the scheduler is running, with a delay value before the next
event, do not run at the correct time.
import sched
import time
import threading
def event( eventNum ):
print( 'event', eventNum, time.time() )
s =
R. David Murray added the comment:
Is it the case that given a filename, it might be possible to load a module
even if open(filename) fails?
I think the logic is clearer in the form where it is not pulled out into a
separate helper function. You can avoid the double check on the extension by
New submission from Eric Snow:
While looking at the logs of a buildbot failure [1], I took a look at
Lib/test/test_threaded_import.py. In
ThreadedImportTests.check_parallel_module_init() it makes a bunch of threaded
calls to the module-level task() function. There may be a race condition in
Eric Snow added the comment:
The windows buildbot failure looks like a race condition in a test unrelated to
my changes (see issue #20127). I'm looking at the FreeBSD failure now.
--
___
Python tracker rep...@bugs.python.org
Eric Snow added the comment:
Which passed on the subsequent run...
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19927
___
___
Python-bugs-list
Eric Snow added the comment:
The FreeBSD failure happened in test_threading (apparently), where it was the
last test to finish. In the passing run it finished 339/388 -- the seed was
different (1253928 vs. 5389019).
This does not seem to be related to my 3 changesets. I'm guessing it's one
R. David Murray added the comment:
Made some review comments.
Looks good in general and it seems like the tests are fairly comprehensive. I
haven't tried to run any additional experiments, but I don't see how it could
make things worse, since the new code paths will only do something
R. David Murray added the comment:
I believe this is a duplicate of issue 16165, which has already been fixed.
--
nosy: +r.david.murray
resolution: - duplicate
stage: - committed/rejected
status: open - closed
superseder: - sched.scheduler.run() blocks scheduler
Changes by Eric Snow ericsnowcurren...@gmail.com:
Removed file:
http://bugs.python.org/file33311/issue20123-fix-pydoc-synopsis.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20123
___
Eric Snow added the comment:
Sounds good to me. Here's an updated patch.
--
Added file: http://bugs.python.org/file33312/issue20123-fix-pydoc-synopsis.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20123
R. David Murray added the comment:
Looks good, except you can replace those any calls with simple calls to
endswith using a tuple of strings (I forgot the call to tuple in my example).
--
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset d6c3fb8d5f84 by Eric Snow in branch 'default':
Issue 20123: Fix pydoc.synopsis() for binary modules.
http://hg.python.org/cpython/rev/d6c3fb8d5f84
--
nosy: +python-dev
___
Python tracker
Eric Snow added the comment:
Ah, I missed that in your earlier suggestion. I followed your recommendation.
Thanks for that. :)
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker
Changes by Martin Panter vadmium...@gmail.com:
--
nosy: +vadmium
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19729
___
___
Python-bugs-list
Eric Snow added the comment:
This broke one of the FreeBSD buildbots:
http://buildbot.python.org/all/builders/AMD64%20FreeBSD%209.0%203.x/builds/6102
--
status: closed - open
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset ff3be21338d5 by Eric Snow in branch 'default':
Issue 20123: try using a different builtin module in a pydoc test.
http://hg.python.org/cpython/rev/ff3be21338d5
--
___
Python tracker
Changes by moijes12 moije...@gmail.com:
--
nosy: -moijes12
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11681
___
___
Python-bugs-list mailing
Changes by moijes12 moije...@gmail.com:
--
nosy: -moijes12
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue724459
___
___
Python-bugs-list mailing
Changes by moijes12 moije...@gmail.com:
--
nosy: -moijes12
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2679
___
___
Python-bugs-list mailing
Changes by moijes12 moije...@gmail.com:
--
nosy: -moijes12
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16321
___
___
Python-bugs-list mailing
Roundup Robot added the comment:
New changeset efcf163d04f5 by Eric Snow in branch 'default':
Issue 20123: Disable a problematic test.
http://hg.python.org/cpython/rev/efcf163d04f5
--
___
Python tracker rep...@bugs.python.org
Eric Snow added the comment:
I've run out of time to trouble-shoot the failure (specific to 1 buildbot).
Until I can get back to it, I've disabled the problematic test (even though
it's only a problem on 1 buildbot).
--
___
Python tracker
1 - 100 of 118 matches
Mail list logo
