Gregory P. Smith added the comment:
I'm not comfortable changing this for 2.7 or 3.3 in case some code is
unfortunately is depending on this behavior. But as it is it does seem like
the kind of thing that can hide problems (tests that are passing that are not
expected to).
Here's a patch
Bohuslav Slavek Kabrda added the comment:
When building for Fedora, we usually use minimal buildroot, that doesn't have
net-tools (e.g. ifconfig and others) installed, so this test fails for us. It'd
probably be best to skip this based on whether ifconfig binary can be found or
not.
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
resolution: fixed -
stage: committed/rejected -
status: closed - open
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19804
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +christian.heimes, giampaolo.rodola, janssen, pitrou
versions: -Python 2.7, Python 3.1, Python 3.2, Python 3.3, Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20188
Vajrasky Kok added the comment:
Okay, here is my first attempt. I only worked on one file
(Modules/sha1module.c). I need to see whether I hit the mark or not. If yes, I
can do the other files as well. Anyway, handling the keyword argument was kinda
tough. There was no example so I had to
Changes by Nadeem Vawda nadeem.va...@gmail.com:
--
nosy: +nadeem.vawda
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20182
___
___
Changes by Nadeem Vawda nadeem.va...@gmail.com:
--
nosy: +nadeem.vawda
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20184
___
___
Changes by Nadeem Vawda nadeem.va...@gmail.com:
--
nosy: +nadeem.vawda
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20185
___
___
Larry Hastings added the comment:
Just one comment on your patch. The documentation already tells you how to
handle keyword arguments (section 8 tells you how to handle default values,
section 9 tells you how to handle | in the format string). If you have any
suggestions on how I could
New submission from Larry Hastings:
Stefan added some docstring text signatures by hand, only to discover that
inspect.Signature still didn't recognize them. Specifically,
decimal.Decimal.compare was unrecognized. This is a method_descriptor object,
which is a type that isn't even exposed
Larry Hastings added the comment:
Okay, learned some things.
1) inspect already has an ismethoddescriptor(). So I'll try to do this
properly by
2) The real problem is that method_descriptor doesn't have __text_signature__.
I only added that to PyCFunctionObject. I'll make the code
New submission from Martin Häcker:
I was quite surprised by this behavior:
dict() in [dict()]
True
dict() in []
False
dict() in dict(foo='bar').keys()
Traceback (most recent call last):
File stdin, line 1, in module
TypeError: unhashable type: 'dict'
dict() in list(dict(foo='bar').keys())
Changes by Martin Häcker spamfaen...@gmx.de:
--
title: dict() in dict(foo='bar') raises - dict() in dict(foo='bar').keys()
raises
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20190
___
STINNER Victor added the comment:
key in dict checks if dict has the specified key. Dictionary keys must be
hashable. Dictionaries are not hashable.
If it helps, this is also a regression from python 2.6/7 where this works as
expected.
dict.keys() return a list in Python 2, whereas it
STINNER Victor added the comment:
The synchronous executor has been implemented in Trollius 0.1.1. I now agree
with Antoine Pitrou that it's overkill to implement in CPython since only one
old platform don't support concurrent.futures. On FreeBSD 6: increase the limit
of POSIX semaphore, or
Roundup Robot added the comment:
New changeset 1437f499024d by Victor Stinner in branch '3.3':
Issue #20113: os.readv() and os.writev() now raise an OSError exception on
http://hg.python.org/cpython/rev/1437f499024d
New changeset cd50efdce294 by Victor Stinner in branch 'default':
(Merge 3.3)
New submission from STINNER Victor:
$ ./python -c 'import resource; resource.prlimit(-3, 11, \udbff\udfff)'
Erreur de segmentation (core dumped)
The problem is a generic problem with PyArg_Parse functions and (O) format.
With this format, the caller does not hold a reference to the object nor
Changes by STINNER Victor victor.stin...@gmail.com:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20113
___
Roundup Robot added the comment:
New changeset 1993a8ec3f19 by Victor Stinner in branch '3.3':
Issue #20113: Fix test_posix on OpenIndiana
http://hg.python.org/cpython/rev/1993a8ec3f19
New changeset f1f707dd7cae by Victor Stinner in branch 'default':
(Merge 3.3) Issue #20113: Fix test_posix on
Brett Cannon added the comment:
While replacing zipimport with a pure Python version using importlib would be a
great feather to have in importlib's cap, the dependencies in zipfile would
make that somewhat difficult:
http://hg.python.org/cpython/file/f1f707dd7cae/Lib/zipfile.py
--
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20189
___
___
Python-bugs-list
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20160
___
___
Python-bugs-list
Vajrasky Kok added the comment:
An example how to convert keyword argument would be very helpful. I searched
the example from existing code but nothing shows up.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20173
Larry Hastings added the comment:
To be precise: a keyword argument is something that happens on the caller
side. What you're talking about is a positional-or-keyword parameter. And
parameters are positional-or-keyword by default.
--
___
Python
Serhiy Storchaka added the comment:
Thank you for good example, Victor. See issue6083 for early discussion.
As for options:
- I afraid we can't raise an error if the second parameter is not a tuple right
now. Rather we should first emit deprecation warning, and raise an error only
several
New submission from Joseph Bylund:
Expected: pprint the object
Observed: crash with:
set([Traceback (most recent call last):
File ./test.py, line 7, in module
pp.pprint(myset)
File /usr/lib/python2.7/pprint.py, line 117, in pprint
self._format(object, self._stream, 0, 0, {}, 0)
Larry Hastings added the comment:
Here's a patch that adds __text_signature__ support for three more builtin
types:
method_descriptor
classmethod_descriptor
wrapper_descriptor
method-wrapper
The patch also modifies inspect.Signature so it recognizes these types.
--
Added file:
R. David Murray added the comment:
FYI, 'crash' is for when the CPython interpreter segfaults, not when python
produces a traceback.
Sets and frozensets are not comparable to anything except themselves, unlike
most other Python2 datatypes. In Python3, most disparate types are not
New submission from Serhiy Storchaka:
In progress. These modules have similar interfaces and common maintainer.
--
assignee: serhiy.storchaka
components: Extension Modules
messages: 207696
nosy: nadeem.vawda, serhiy.storchaka
priority: normal
severity: normal
status: open
title: Derby:
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +larry
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20193
___
___
Python-bugs-list
Changes by Brett Cannon br...@python.org:
--
assignee: brett.cannon
components: Documentation
nosy: brett.cannon
priority: normal
severity: normal
status: open
title: Add :deprecated: marker to formatter docs
versions: Python 3.4
___
Python tracker
Changes by Brett Cannon br...@python.org:
--
assignee: brett.cannon
components: Documentation
nosy: brett.cannon
priority: normal
severity: normal
status: open
title: Add :deprecated: marker to imp docs
versions: Python 3.4
___
Python tracker
Changes by Brett Cannon br...@python.org:
--
title: Add :deprecated: marker to formatter docs - Add :deprecated: marker to
formatter module docs
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20194
Changes by Jesús Cea Avión j...@jcea.es:
--
nosy: +jcea
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20188
___
___
Python-bugs-list mailing list
Larry Hastings added the comment:
Here's how the files were parceled out into the various bundles:
#20170
Derby #1: Convert 137 sites to Argument Clinic in Modules/posixmodule.c
Modules/posixmodule.c: 137 sites
#20171
Derby #2: Convert 115 sites to Argument Clinic in
Larry Hastings added the comment:
I'd prefer it if you use the existing Derby issues. It's hard enough for me to
keep track of what's going on as it is, and it's unhelpful of you to create a
redundant issue. If you'd like some help figuring out how to work with the
existing issues please
Larry Hastings added the comment:
So do you think there are any entry points worth converting in _tkinter, or
should we close this issue?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20168
New submission from Serhiy Storchaka:
Argument Clinic generates invalid code for optional parameter if there are no
mandatory parameters except self. Example:
/*[clinic input]
zlib.Decompress.flush
self: self(type=compobject *)
[
length: uint
the initial size of the output
Larry Hastings added the comment:
Good catch! It should be an easy fix, but I won't be able to get to it until
tomorrow.
--
assignee: - larry
stage: - needs patch
type: - behavior
___
Python tracker rep...@bugs.python.org
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20166
___
___
New submission from Fabrice Aneche:
Detect the webp file format (RIFF container + WEBP), return webp as format
detected.
--
components: Library (Lib)
files: imghdr_webp.patch
keywords: patch
messages: 207702
nosy: akhenakh, gregory.p.smith
priority: normal
severity: normal
status: open
Zachary Ware added the comment:
I'll take a stab at this one, but I may make you rue the day you said you'd
review until your eyes bleed ;)
Here's a partial patch to PC/winreg.c, converting only the CloseKey function
just to make sure I have some basic idea of what I'm doing.
(Also, if
Serhiy Storchaka added the comment:
Here are completed patches for the _bz2 and _lzma modules (only constructors
are not converted) and preliminary patch for the zlib module.
There are issues in the zlib module:
* Argument Clinic generates invalid code for zlib_Decompress_flush
(issue20196).
Changes by Serhiy Storchaka storch...@gmail.com:
Added file: http://bugs.python.org/file33369/lzma_clinic.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20193
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
keywords: +patch
Added file: http://bugs.python.org/file33368/bz2_clinic.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20193
___
Changes by Serhiy Storchaka storch...@gmail.com:
Added file: http://bugs.python.org/file33370/zlib_clinic.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20193
___
Zachary Ware added the comment:
To possibly ease review (and for keeping track of what I'm doing), I'm linking
hg.python.org/sandbox/zware#issue20172 where I'll try to do a commit per
converted function.
--
hgrepos: +216
___
Python tracker
Serhiy Storchaka added the comment:
You misunderstood me. I already have 1018-lines patch which converts about 24
functions and methods to Argument Clinic church. And I'm working on left
functions. Do you want to get unfinished patch?
--
___
Python
Changes by Claudiu.Popa pcmantic...@gmail.com:
--
nosy: +Claudiu.Popa
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20197
___
___
Python-bugs-list
Meador Inge added the comment:
Larry, I don't want to scatter patches for these related modules and merge
them with patches for totally unrelated modules. And I think it would be
cumbersome to Nadeem Vawda to make reviews in such circumstances.
Maybe so, but it will more productive if we
R. David Murray added the comment:
For future reference, because this patch changed the type of an error, it
should not have been applied to a maintenance release (3.3). Since the change
has already been released in 3.3.3, it is now better not to revert it.
--
nosy: +r.david.murray
Serhiy Storchaka added the comment:
I didn't even know for which of the dozens of random issues Larry randomly
assigned these modules. And this organization does not look productive.
--
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
This is not incompatible change because b32decode() already raised this type of
an error. Third-party code which use b32decode() was either incorrect (if it
catches only TypeError or binascii.Error when any of them could raised) or is
not broken by this
R. David Murray added the comment:
But code could be catching TypeError specifically looking for the alphabet
error, since that is how it was documented.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18011
Larry Hastings added the comment:
I did correct that where is file X problem; issue #20187 is a meta-issue for
the whole Derby, and it has a list of all the issues and what files they map
to. I'm sorry that this is not an optimal solution for organization, but it
should be workable, and it
Larry Hastings added the comment:
Oh, okay. That sounds fine, and I'm not in a hurry. Please post the patch
whenever you're ready, thanks!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20168
Richard Oudkerk added the comment:
The following from the docs is wrong:
... module globals are no longer forced to None during interpreter
shutdown.
Actually, in 3.4 module globals *sometimes* get forced to None during
interpreter shutdown, so the version the __del__ method can still
Larry Hastings added the comment:
* I have experimented in zlib_decompressobj, and I got good compact
code, but wrong docstring (decompressobj(wbits=None, zdict=None)).
Needed a way to specify optional parameters without default Python
values. Correct signature should be something like
Larry Hastings added the comment:
The piecemeal approach sounds fine, but I'm only going to review patches once
you post them here. (I'm not sure I can get to reviewing your patch today, but
definitely tomorrow.)
--
___
Python tracker
Larry Hastings added the comment:
Previous approach is not applicable to compressobj because
Py_buffer can't have default value. Seems as compressobj is
not compatible with Argument Clinic.
Then perhaps we can fix Argument Clinic to be compatible. Py_buffer doesn't
like default values
Larry Hastings added the comment:
I lied, I just looked at it. You said it was only one function, so it went
quickly.
It looks totally fine. In fact, Argument Clinic is generating better code than
the original!
--
___
Python tracker
Larry Hastings added the comment:
Oh, and, p.s. I was a Win32 developer for about fifteen years. I don't touch
it anymore, but I consider myself still competent to read patches for simple
stuff like the registry library.
--
___
Python tracker
Changes by Larry Hastings la...@hastings.org:
--
nosy: +tim.peters
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20189
___
___
Python-bugs-list
Larry Hastings added the comment:
I just realized, you're misunderstanding what the first line of the docstring
is.
When you run help(function_written_in_Python), the first line of the help is
the function's signature rendered in text. That's generated by pydoc, which
gets signature
New submission from bagrat lazaryan:
xml.etree.ElementTree.ElementTree.write method (and, as a derivative,
xml.etree.ElementTree.tostring function) sorts attributes in lexical order.
while an admissible behavior instead of the randomness inherited from ordinary
dict, this prevents a picky
Changes by bagrat lazaryan bagra...@live.com:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17390
___
Ryan Smith-Roberts added the comment:
Taking a crack at this.
socketmodule.h: just a comment, skipping.
_functools.c: kind-of skipping, because the relevant functions are not normally
directly called (pickle protocol __reduce__ and __setstate__ on partial,
__call__ on cmp wrapper). Will add
New submission from R. David Murray:
The whatsnew currently says that module_for_loader is pending deprecation in
favor of utils.module_to_load, but there is no such function. Instead there is
a private function utils._module_to_load...even though there is a news entry
that claimed that the
New submission from Ryan Smith-Roberts:
The custom converter declaration is wrapped with [clinic input] when it should
be [python input].
Patch attached.
--
files: argument_clinic_docfix.patch
keywords: patch
messages: 207724
nosy: rmsr
priority: normal
severity: normal
status: open
Changes by Zachary Ware zachary.w...@gmail.com:
--
assignee: - docs@python
components: +Documentation
nosy: +docs@python, larry
stage: - patch review
versions: +Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20200
Eric Snow added the comment:
utils.module_to_load() has been removed (it was introduced in 3.4) and
module_for_loader() remains deprecated. The import machinery now does the work
that both functions did, rendering them unnecessary. I guess I failed to take
a look at whatsnew relative all
Changes by Ryan Smith-Roberts r...@lab.net:
--
keywords: +patch
Added file: http://bugs.python.org/file33372/argument_clinic_functools.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20174
Ryan Smith-Roberts added the comment:
I'm such a goofball, how about some bug metadata
--
components: +Build
type: - compile error
versions: +Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20201
New submission from Ryan Smith-Roberts:
Following the howto's instructions on the new syntax for the 'w*' argument, one
gets an exception:
...
File Tools/clinic/clinic.py, line 1780, in converter_init
elif types == (bytearray_type | rwuffer_type):
NameError: global name 'rwuffer_type' is
Changes by Berker Peksag berker.pek...@gmail.com:
--
nosy: +larry
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20201
___
___
Python-bugs-list
New submission from Ryan Smith-Roberts:
Almost didn't catch that PyBuffer_Release isn't needed. Also we need a
verb/adjective for applying AC. Cure?
zlibmodule has already been cured.
--
assignee: docs@python
components: Documentation
messages: 207728
nosy: docs@python, larry, rmsr
Changes by Serhiy Storchaka storch...@gmail.com:
--
dependencies: +Argument Clinic generates invalid code for optional parameter
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20168
___
Stefan Behnel added the comment:
IMHO, it makes sense to support this. My intuition tells me that lxml also
handles this as expected, by accident through iteration.
Not sure how to do this correctly in ET, though. Special case dict? Or special
case OrderedDict? Both would leave some
Stefan Behnel added the comment:
My intuition tells me that lxml also handles this as expected, by accident
through iteration.
And, obviously, it doesn't. It sorts, too. :)
I'm ok with switching for both libraries.
--
___
Python tracker
79 matches
Mail list logo
