Serhiy Storchaka added the comment:
Well, then it LGTM.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20162
___
___
Python-bugs-list mailing
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20086
Serhiy Storchaka added the comment:
Raymond, what do you think?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16572
___
___
Python-bugs-list
Neil Schemenauer added the comment:
I'm attaching v2 of my proposed patch. This one is quite a bit better, IMHO.
- Introduce __ascii__ as a special method, like __str__ but required to exist
only if an ASCII-only format exists.
- Extract PyString_Format from Python 2.7 and update it for
Changes by STINNER Victor victor.stin...@gmail.com:
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20284
___
___
Python-bugs-list
STINNER Victor added the comment:
I reviewed your second patch on Rietveld.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20284
___
___
STINNER Victor added the comment:
@Christian: Are you ok with siphash_ppc64.patch? I'm going to push the fix.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20162
___
Neil Schemenauer added the comment:
Uploading new patch with the following changes:
- Allow length 1 bytes object as argument to %c.
- Make %r an alias for %a.
I will upload a draft PEP (proposed as a replacement for 461).
Victor, thanks for the review. My reply is:
- regarding duplicated
Changes by Neil Schemenauer nas-pyt...@arctrix.com:
Added file: http://bugs.python.org/file33507/pep-draft.txt
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20284
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
keywords: +patch
Added file: http://bugs.python.org/file33508/sre_pattern_string_keyword.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20283
Changes by Serhiy Storchaka storch...@gmail.com:
Removed file: http://bugs.python.org/file33508/sre_pattern_string_keyword.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20283
___
Changes by Serhiy Storchaka storch...@gmail.com:
Added file: http://bugs.python.org/file33509/sre_pattern_string_keyword.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20283
___
Serhiy Storchaka added the comment:
Left files with mismatched executable bits and shebangs:
Python 3.4:
- ./Doc/includes/email-unpack.py
- ./Doc/includes/email-alternative.py
- ./Doc/includes/email-dir.py
x ./Tools/scripts/pydocgui.pyw
x ./Lib/idlelib/idle.bat
-
Steve added the comment:
I just noticed that this is reporducible consistently with the python
requests[1] module, if you route your request through a proxy. I was wondering
whether I should report this as a 'requests' bug or would this be the right
place to add a 'me too' ? Here's the
Serhiy Storchaka added the comment:
Can Argument Clinic be simplified when drop support for all alternative outputs
besides a side file?
* args and kwargs variables in C renamed to _args and _kwargs
Why this is needed? If buildin function has args or kwargs keyword
arguments, C variables
Stefan Krah added the comment:
IMO the .bat files should have the executable bit as a reminder that they're
executable on Windows.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19936
___
New submission from Anders Hammarquist:
Python 2.7 HTMLParse.py lines 185-199 (similar lines still exist in Python 3.4)
match = charref.match(rawdata, i)
if match:
...
else:
if ; in rawdata[i:]: #bail by
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
assignee: - ezio.melotti
nosy: +ezio.melotti
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20288
___
Ezio Melotti added the comment:
http://docs.python.org/3/faq/design.html#why-are-default-values-shared-between-objects
--
nosy: +ezio.melotti
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20135
New submission from Brett Cannon:
It has a file attribute which contains a file, so making it so it can be closed
faster than cgi.FieldStorage.__del__ would be good.
--
components: Library (Lib)
messages: 208338
nosy: brett.cannon
priority: normal
severity: normal
stage: test needed
Brett Cannon added the comment:
While you're right, Marcel, that code which pulls out the file object form
FieldStorage would probably have the file closed from underneath it, I don't
know if I agree that it's a bad thing. The FieldStorage object created that
file, implicitly putting it in
Roundup Robot added the comment:
New changeset c9706c13a005 by Zachary Ware in branch '3.3':
Issue #20266: Update parts of the Windows FAQ
http://hg.python.org/cpython/rev/c9706c13a005
New changeset 3cb048463ea7 by Zachary Ware in branch 'default':
Issue #20266: Merge with 3.3
R. David Murray added the comment:
Requests may well want to put a workaround in place. To fix it in 2.7, we need
a patch that actually respects the size argument, and a unit test.
--
___
Python tracker rep...@bugs.python.org
R. David Murray added the comment:
I *thought* there was a FAQ entry for that. Didn't think to look for it in the
design section though :(. Nor is the title likely to catch the eye of someone
wondering why their default argument modifications are being unexpectedly
persistent. Also, the
Changes by Brett Cannon br...@python.org:
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18394
___
___
Python-bugs-list
Roundup Robot added the comment:
New changeset 13d04a8713ad by Brett Cannon in branch 'default':
Issue #18394: Document that cgi.FieldStorage now cleans up after its
http://hg.python.org/cpython/rev/13d04a8713ad
--
___
Python tracker
Roundup Robot added the comment:
New changeset 863b8e71cfee by Brett Cannon in branch 'default':
Issue #20208: Clarify some things in the Python porting HOWTO.
http://hg.python.org/cpython/rev/863b8e71cfee
--
nosy: +python-dev
___
Python tracker
Changes by Brett Cannon br...@python.org:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20208
___
New submission from Roundup Robot:
New changeset 30013dbb5bc2 by Brett Cannon in branch 'default':
Issues #20194,20195: Add missing :deprecated: markers to some module
http://hg.python.org/cpython/rev/30013dbb5bc2
--
nosy: +python-dev
___
Python
New submission from Brett Cannon:
Fixed by changeset 30013dbb5bc2
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20195
___
Changes by Brett Cannon br...@python.org:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20194
___
Brett Cannon added the comment:
I'm going to start tackling some of these today and checking them in directly.
If I don't finish I will update the bug with what I didn't get to.
--
assignee: - brett.cannon
___
Python tracker rep...@bugs.python.org
kespindler added the comment:
Those new examples look good. I appreciate your revisiting the issue.
On Wed, Jan 15, 2014 at 7:12 AM, Vinay Sajip rep...@bugs.python.org wrote:
Vinay Sajip added the comment:
Cookbook updated. See changesets 7c4f0c3dedaf and 0056aaf42bf7 for more
information
Mark Lawrence added the comment:
The faq doesn't mention the new launcher for Windows. Rather than write too
much I'd simply cross reference this
http://docs.python.org/3/using/windows.html#python-launcher-for-windows. I
think this also impacts on the section How do I make Python scripts
Ezio Melotti added the comment:
Thanks for the report, this is indeed a bug.
This behavior was covered by a test (see Lib/test/test_htmlparser.py:164), but
_run_check feeds the chars one by one to the parser, and in that case it works
correctly. While feeding the parser a whole chunk I was
Brett Cannon added the comment:
Patch for multibytecodec.c.
Not sure how you calculated locations, Larry, but this file had 11 things to
change, so some other work divisions might be off.
--
Added file: http://bugs.python.org/file33510/multibytecodec_derby.diff
Cory Benfield added the comment:
I've been messing around trying to write a test for this, and it looks like
genuinely the only place this can be hit is in _tunnel(). None of the other
readline() calls can be hit with the LineAndFileWrapper() wrapping the file
descriptor.
--
nosy:
Brett Cannon added the comment:
After finding out that the initial site counts were off I went through and
manually counted each file in this Derby group to get a more accurate idea of
how much work each file would be.
Modules/cmathmodule.c: 8 sites
Modules/arraymodule.c: 27 sites
Changes by Brett Cannon br...@python.org:
Added file: http://bugs.python.org/file33511/grp_derby.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20152
___
Cory Benfield added the comment:
Alright, here's a patch.
I'm not ecstatic about this test: it's utterly contrived, but it also seems to
be the least bad way to reproduce this bug. Let me know if you strongly object
and I'll take another swing at it (it'll probably involve extending the
Changes by Brett Cannon br...@python.org:
Added file: http://bugs.python.org/file33513/spwd_derby.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20152
___
Larry Hastings added the comment:
If I removed support for all destinations except files, I might
be able to remove fifty lines or so. However, I'm not planning
on doing that. Does cryptmodule.c, which has exactly one function,
really need a 20-line separate file?
Also, the file approach
Changes by Brett Cannon br...@python.org:
Added file: http://bugs.python.org/file33514/multibytecodec_derby.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20152
___
Changes by Brett Cannon br...@python.org:
Removed file: http://bugs.python.org/file33510/multibytecodec_derby.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20152
___
Changes by Brett Cannon br...@python.org:
Added file: http://bugs.python.org/file33515/pwd_derby.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20152
___
Neil Schemenauer added the comment:
Another revision of the patch, now quite close to PEP 461 as proposed. Changes
from PEP 461:
- include %a
- add -2 command-line flag. When enabled have %s fallback to calling
PyObject_Str() and encoding to ASCII and also enable %r as alias for %a.
Brett Cannon added the comment:
Might pick this up later today (or never), but taking a break for now.
Larry, I have patches for grp, spwd, _multibytecodec, and pwd I'd like you to
give a once-over to make sure I didn't miss anything.
The only one that I think has an obvious improvement is in
Guido van Rossum added the comment:
Now looking. Note that a few parts of the patch no longer cleanly apply:
hg import --no-c http://bugs.python.org/review/download/issue20189_10572.diff
applying http://bugs.python.org/review/download/issue20189_10572.diff
patching file Modules/_cursesmodule.c
Larry Hastings added the comment:
Updating / merging / resolving now, but it will take me a few minutes.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20189
___
Larry Hastings added the comment:
Here's a fresh patch against trunk. It applies cleanly against current tip
(725bc24f5492).
--
Added file:
http://bugs.python.org/file33517/larry.support.text_signature.on.more.types.diff.4.txt
___
Python tracker
Larry Hastings added the comment:
I have backed out the args - _args change. Not because I'm giving up on
it, or that I necessarily think it's a bad idea, but because there
are some changes happening in #20189 that will make it easier / that would
conflict if I attacked it now.
The resulting
Changes by Zachary Ware zachary.w...@gmail.com:
--
nosy: +zach.ware
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20189
___
___
Python-bugs-list
New submission from cqxz:
When two files have the same name and the first changes directory to the
second, the inspect module can retrieve the source code for the latter
incorrectly, so a simple call to inspect.stack() can be incorrect, and will
fail if there are less lines in the nested
Terry J. Reedy added the comment:
On python-list, Jean-Michel Pichavant pointed out that the status of object is
different in 2.7. 'for new-style classes' would have to be added. 2.7 currently
has the same output, but the meaning is slightly different as type and class
are slightly different
Terry J. Reedy added the comment:
Rather, 'all classes' should be 'all new-style classes'.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20285
___
Guido van Rossum added the comment:
I limited myself to the four files you mentioned, and they look totally fine.
Together with Nick's view you should have enough core review now, right?
--
___
Python tracker rep...@bugs.python.org
Larry Hastings added the comment:
I do. Thanks for your time!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20189
___
___
Python-bugs-list
Roundup Robot added the comment:
New changeset fc52b657bcd9 by Zachary Ware in branch '3.3':
Issue #20265: Updated some parts of the Using Windows document.
http://hg.python.org/cpython/rev/fc52b657bcd9
New changeset 5a9171e70573 by Zachary Ware in branch 'default':
Issue #20265: Merge with 3.3
Zachary Ware added the comment:
A few issues with this patch:
1) help(os) raises ValueError
Traceback (most recent call last):
File stdin, line 1, in module
File P:\ath\to\cpython\lib\_sitebuiltins.py, line 99, in __call__
return pydoc.help(*args, **kwds)
File
Yury Selivanov added the comment:
Can somebody review the patch? I'd be cool if this lands in 3.4.
--
nosy: +larry
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17481
___
Terry J. Reedy added the comment:
I think /file/open/ would work.
--
nosy: +michael.foord, terry.reedy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20222
___
Terry J. Reedy added the comment:
This strikes me as a bug introduced with the new 3.4 feature and thus a Type:
behavior issue eligible for 3.4. inspect.signature should work correctly with
any python-coded callable and not return a wrong answer. (And we are trying to
get inspect to work with
Changes by Terry J. Reedy tjre...@udel.edu:
--
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20223
___
___
Python-bugs-list
Serhiy Storchaka added the comment:
The patch is too large and I don't very conversant with this code, so I just
left several minor comments on Rietveld. At first glance all looks good.
All works with my patches, results are good. But I see that side fail names
have extension .clinic.c. The
Terry J. Reedy added the comment:
I took the sentence to mean 1) more that 2). I agree that it should be revised.
--
nosy: +terry.reedy
versions: -Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20237
Changes by Terry J. Reedy tjre...@udel.edu:
--
nosy: +pitrou, terry.reedy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20254
___
___
Larry Hastings added the comment:
I have a fix already in place for the clinic_test.py problem.
I disagree with your proposed foo.c.clinic nomenclature, and there are
advantages to foo.clinic.c: double-clicking on them will launch the correct
editor, and editors will automatically color them
Terry J. Reedy added the comment:
How nasty. I agree that this is a code bug. Unfortunately in this case, the C
code does keyword matching of arguments and 'corrects' the doc for anyone who
tries 'string='.
pat.search(string='xabc', pos=1)
Traceback (most recent call last):
File pyshell#6,
Ryan Smith-Roberts added the comment:
socketmodule has three builtins which use PyLong_AsUnsignedLong on their
arguments and would benefit from these converters, but only if they raise
OverflowError. So I vote for #2.
I don't think it's unreasonable to continue to have locally-defined
Björn Lindqvist added the comment:
The bug is still present on the default build which many distros uses which
produces an invalid build. That means
./configure make make install
is broken! --enable-shared should be turned on by default because many (most?)
distros build with the
Changes by Ethan Furman et...@stoneleaf.us:
--
nosy: +ethan.furman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20284
___
___
Python-bugs-list
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14480
___
___
Roundup Robot added the comment:
New changeset 7f6712954d5d by Larry Hastings in branch 'default':
Issue #20287: Argument Clinic's output is now configurable, allowing
http://hg.python.org/cpython/rev/7f6712954d5d
--
nosy: +python-dev
___
Python
Larry Hastings added the comment:
Done!
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20287
___
New submission from Larry Hastings:
Argument Clinic currently prevents the impl function from ever seeing the
args tuple or the kwargs dict. There should be a way to ask it to pass
those values in to the impl function.
--
assignee: larry
messages: 208380
nosy: larry, meador.inge
Larry Hastings added the comment:
Meador: I'm going to change Argument Clinic so you can get the args and
kwargs values passed in to the impl. That's issue #20291; I already added
you to it nosy list. With that change in you'll be able to convert
sqlite3.connect.
--
Changes by Ethan Furman et...@stoneleaf.us:
--
nosy: +ethan.furman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18574
___
___
Python-bugs-list
Changes by Ethan Furman et...@stoneleaf.us:
--
nosy: +ethan.furman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12704
___
___
Python-bugs-list
Changes by Ethan Furman et...@stoneleaf.us:
--
nosy: +ethan.furman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7776
___
___
Python-bugs-list
Changes by Ethan Furman et...@stoneleaf.us:
--
nosy: +ethan.furman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17814
___
___
Python-bugs-list
Changes by Ethan Furman et...@stoneleaf.us:
--
nosy: +ethan.furman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17811
___
___
Python-bugs-list
Nikolaus Rath added the comment:
Rebased patch on current tip.
--
Added file: http://bugs.python.org/file33520/issue7776.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7776
___
Changes by Terry J. Reedy tjre...@udel.edu:
--
versions: -Python 3.1, Python 3.2, Python 3.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17814
___
Changes by Terry J. Reedy tjre...@udel.edu:
--
versions: -Python 2.6, Python 3.1, Python 3.2, Python 3.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7776
___
Nikolaus Rath added the comment:
I have started working on this (partial patch attached), but I am unsure how to
handle cases where the docstring definition utilizes a macro. For example:
PyDoc_STRVAR(strftime_doc,
strftime(format[, tuple]) - string\n\
\n\
Convert a time tuple to a string
New submission from Ryan Smith-Roberts:
Find test file attached. The exception:
Exception raised during parsing:
Traceback (most recent call last):
...
File proj/python/trunk.hg/Tools/clinic/clinic.py, line 1535, in render
self.parse_argument(data.parse_arguments)
File
Benjamin Peterson added the comment:
A test would be good.
--
nosy: +benjamin.peterson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18574
___
___
Benjamin Peterson added the comment:
IMO, it should just refer to the glossary entry for bytes-like object.
--
nosy: +benjamin.peterson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17811
Roundup Robot added the comment:
New changeset 946257d3c648 by Benjamin Peterson in branch '3.3':
describe type of Popen streams (closes #17814)
http://hg.python.org/cpython/rev/946257d3c648
New changeset 1a7d416c57ff by Benjamin Peterson in branch 'default':
merge 3.3 (#17814)
89 matches
Mail list logo
