Changes by Serhiy Storchaka storch...@gmail.com:
Removed file: http://bugs.python.org/file33709/zlib_clinic_3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20193
___
Serhiy Storchaka added the comment:
Synchronized with recent Argument Clinic changes.
--
Added file: http://bugs.python.org/file33719/zlib_clinic_3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20193
Terry J. Reedy added the comment:
I removed the incorrect * comment.
Attached is a 2.7 port of the 3.3 patch. It turns out that textwrap.TextWrap in
2.7 is an old-style class. Such did not work previously because they do not
have .__call__ and failed the hasattr() check, now a try:except
Serhiy Storchaka added the comment:
The patch did not upload correctly.
Oh, sorry. Here is correct patch.
I propose to apply soft patch (which preserves support for old keyword
parameter name) to 2.7 and 3.3, and apply hard patch (which just renames
keyword parameter name) to 3.4.
Or we
Terry J. Reedy added the comment:
Coverity appears concerned about the division by q. It apparently knows inrate
!= 0. I do not see any division by len. If q is cleared up, I presume it will
check bytes_per_frame.
--
nosy: +terry.reedy
___
Python
Changes by Terry J. Reedy tjre...@udel.edu:
Removed file:
http://bugs.python.org/file33705/sre_deprecate_pattern_keyword.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20283
___
Georg Brandl added the comment:
For 3.3 I prefer the soft patch.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20283
___
___
Python-bugs-list
Serhiy Storchaka added the comment:
LGTM. But I prefer larger indent.
Perhaps we need explicit tests for constructors of old- and new-style classes,
with __new__, with __init__, and without __new__ and __init__.
--
___
Python tracker
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8260
___
___
New submission from Serhiy Storchaka:
Argument Clinic had added about half-thousand lines of code to
Modules/_pickle.c. This generated code is mixed with handwritten code. Last 8
changes of Modules/_pickle.c are caused by Argument Clinic evolution, and I
afraid that many future Argument
Nadeem Vawda added the comment:
The latest patch for zlib seems to be missing Modules/zlibmodule.clinic.c
I suppose that zdict=b'' have same effect as not specifying zdict. Am I right?
Probably, but to be on the safe side I'd prefer that we preserve the behavior of
not calling
Larry Hastings added the comment:
Alexandre: We're still figuring out best practices with Argument Clinic. So,
right now, there's no standard policy of where should we put all the generated
code?, and we're leaving it up to the owners of the individual modules.
Putting it in a second file
Larry Hastings added the comment:
We're not allowing changes in semantics for Argument Clinic conversion for 3.4.
If it doesn't currently accept None, we can't add it right now, and we'll have
to save it for 3.5.
--
___
Python tracker
Larry Hastings added the comment:
I nominate this text:
**
To make these errors go away, merge the contents of
build/suspicious/suspicious.csv to tools/sphinxext/susp-ignored.csv.
Serhiy Storchaka added the comment:
Ah, sorry, here is full patch. Generated file is now named
Modules/clinic/zlibmodule.c.h.
The behavior is preserved. This case is exact analogue of _sha1.sha1(). No one
additional function called when the parameter is not specified, but if it is
specified
Changes by Serhiy Storchaka storch...@gmail.com:
Removed file: http://bugs.python.org/file33719/zlib_clinic_3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20193
___
Larry Hastings added the comment:
Since Ezio asked me, I guess I wasn't clear:
This message should be displayed at the bottom, after the errors, and only when
there are alleged suspicious documentation activities.
--
___
Python tracker
Glenn Langford added the comment:
@Brian - Ah, I see now what you are referring to. The patch has changes to
_create_and_install_waiters() which should not be there. The only code that
needs to change is waiter removal as I originally suggested. I am set up with a
dev environment now and will
Larry Hastings added the comment:
Here's a first cut at a patch. All signatures now start with sig=(.
I also added a special marker: if the first parameter starts with $, we know
for certain it's a self (or module or type) parameter. This means we can
lose the heuristics for do we have a
Larry Hastings added the comment:
Georg: you're accepting this patch into 3.3? I'm surprised.
I would only want the soft approach. But I haven't said yes yet. I want
to discuss it a little more. (Hey, it's python core dev. Discussing things
endlessly is our job.)
--
Serhiy Storchaka added the comment:
If you want the soft approach, then you should revert your changes to
_sre.SRE_Pattern.match.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20283
___
Larry Hastings added the comment:
You can do it, if I accept the patch for 3.4. There's no point in doing it in
two stages.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20283
___
Larry Hastings added the comment:
Alternatively, we could use this cheap hack:
/*[python input]
class hidden_object_converter(object_converter):
show_in_signature = False
[python start generated code]*/
/*[clinic input]
module _sre
class _sre.SRE_Pattern PatternObject * Pattern_Type
Glenn Langford added the comment:
This patch shows the minimal desired outcome. It is not elegant in its current
form, but does only what is necessary. Ultimately I think as_completed() should
go its own way and not lock all Futures at once (#20297).
--
Added file:
Tom Edwards added the comment:
Still an issue in 3.3.3. Igor's fix still works, thankfully.
--
nosy: +Artfunkel
versions: +Python 3.3 -Python 2.7
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17213
Stefan Krah added the comment:
I like the sig= and the $. There seems to be a small glitch in __rdivmod__:
help(int.__rdivmod__)
__rdivmod__(self, value)
sig=($self, value)
Returns divmod(value, self).
The sig line is shown (and the preferred form is the imperative Return
divmod).
Serhiy Storchaka added the comment:
Try this patch.
--
nosy: +serhiy.storchaka
Added file: http://bugs.python.org/file33726/make_suspicious.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15759
Changes by Tom Edwards cont...@steamreview.org:
--
versions: +Python 2.7
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17213
___
___
Georg Brandl added the comment:
Looks good. Maybe Larry will want his line of stars though :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15759
___
Nick Coghlan added the comment:
Stefan actually picked up on an existing bug there, that this patch just
changes the spelling of:
int.__rdivmod__.__doc__
'__rdivmod__(self, value)\nReturns divmod(value, self).'
int.__rdivmod__.__text_signature__
'(self, value)'
When reviewing Larry's
Nick Coghlan added the comment:
Aside from that glitch, the new scheme looks good to me. I also like the fact
it allows the text signature to be included in the docstring normally if
inspect.Signature doesn't support it, so help(f) can still be generated
automatically.
--
Larry Hastings added the comment:
Nick: you lost me. Change the macro how? What is the redundant info? I
already changed those macros so they generate signatures, both currently in
trunk and in my patch.
--
___
Python tracker
Larry Hastings added the comment:
Stefan: I made the change. I left Implements something alone as Implement
something sounded wrong, but all the rest dropped their s's.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20326
New submission from Larry Hastings:
A minor bug, but still one that could cause confusion. It's already bitten me
once.
If I change the code generator in clinic.py, then --make everything, files
using the file destination often won't change. All the changes to the
generated code will go in
Changes by Serhiy Storchaka storch...@gmail.com:
Removed file: http://bugs.python.org/file33726/make_suspicious.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15759
___
Serhiy Storchaka added the comment:
It was not such good. Here is better patch.
--
Added file: http://bugs.python.org/file33727/make_suspicious.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15759
Larry Hastings added the comment:
Can we use unicode characters? I'd like little ships, or U+1F4A9.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15759
___
Serhiy Storchaka added the comment:
It should first touch source file and then generated file. So that the date of
generated file is always later the date of source file.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20396
Stefan Krah added the comment:
What is the redundant info?
{__rdivmod__, __builtin_offsetof (PyHeapTypeObject, as_number.nb_divmod),
(void *)(slot_nb_divmod), wrap_binaryfunc_r, sig=($self, value)\n
sig=($self, value)\nReturns divmod(value, self).}
There are two sig instances. What Nick
New submission from Marcus von Appen:
Using the --record argument with distutils' install command currently assumes
that all .py files can be compiled (and optimized) successfully.
If this is not the case for whatever reason, you end up with invalid entries in
the record list.
Glenn Langford added the comment:
Ah...ok, here is a patch that includes an update to
Doc/library/concurrent.futures.rst as well.
--
Added file: http://bugs.python.org/file33728/issue20367.patch
___
Python tracker rep...@bugs.python.org
Tal Einat added the comment:
Using the latest clinic.py from default branch, everything in itertools works
like a charm :)
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20385
Nick Coghlan added the comment:
With Serhiy's modification, sounds like a reasonable plan to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20396
___
Nick Coghlan added the comment:
Right, the macros I quoted all include the signature automatically
(because it's consistent) and *then* the DOC that is passed in. So
when you use them, the signature should be left out of the slot
definition itself. Currently, we're defining it in both places,
Roundup Robot added the comment:
New changeset b27352f87404 by Nick Coghlan in branch 'default':
Close #20105: set __traceback__ when chaining exceptions in C
http://hg.python.org/cpython/rev/b27352f87404
--
nosy: +python-dev
resolution: - fixed
stage: test needed - committed/rejected
Ram Rachum added the comment:
New patch attached. Not tested.
--
Added file: http://bugs.python.org/file33729/pathlib.readwrite4.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20218
___
Serhiy Storchaka added the comment:
The 3.4 patch LGTM, but the 3.3 patch perhaps has a bug.
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16074
___
New submission from lothar:
setup: python 3.2 ; cygwin64
python crashes with a stackdump, which is attached.
stem is a python controller module for tor.
stem-1.1.1 can be had from here:
https://pypi.python.org/pypi/stem/
the code is in version 2 form, but python3 setup install runs 2to3 on
Raymond Hettinger added the comment:
LGTM, but may be write Py3k compatible names at first place?
+1
--
nosy: +rhettinger
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19863
___
Nick Coghlan added the comment:
Patch looks good to me, but if any specific features are needed to work around
misbehaving codecs (as per issue 20132), a comment in the appropriate place
referencing that issue would be helpful.
And if that workaround means we can remove the special casing
Vajrasky Kok added the comment:
I already have a patch addressing your concerns, Serhiy. But before I upload it
here, some questions:
1. Yes, we can add unencodable tarinfo.linkname later. Just add tests for
external tar files. You mean, we need to create a tar file containing
unencodable
R. David Murray added the comment:
I'm tagging this for 3.5 instead, since there are backward compatibility
concerns and the 3.4 RC will probably be a couple weeks from now.
--
nosy: +r.david.murray
versions: +Python 3.5 -Python 3.4
___
Python
Serhiy Storchaka added the comment:
1. No. Just use existing nonmodified testtar.tar now. Later we will add new
items in it.
2. The encoding of sys.stdout is not always the same as default locale
encoding. You can redirect sys.stdout to text file (opened with different
encoding) or to socket
R. David Murray added the comment:
For anyone else who wants to look at this: it doesn't look like stem involves
any C code, and the 'signal' method appears to be a text-based interprocess
communication.
Can you reproduce this with 3.3.3? 3.2 is in security-fix-only mode, and while
a crash
Serhiy Storchaka added the comment:
Actually this patch doesn't work around misbehaving codecs. It just makes
specific tests (one readline, one read) be passed. More complex tests which use
multiple readline's or read's still can fail with these misbehaving codecs.
--
Claudiu.Popa added the comment:
Hello! Here's the new version of the patch, with tests proposed by Serhiy.
--
Added file: http://bugs.python.org/file33731/test_imghdr_3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19990
Roundup Robot added the comment:
New changeset e24265eb2271 by Serhiy Storchaka in branch '2.7':
Issue #8260: The read(), readline() and readlines() methods of
http://hg.python.org/cpython/rev/e24265eb2271
New changeset 9c96c266896e by Serhiy Storchaka in branch '3.3':
Issue #8260: The read(),
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8260
___
Roundup Robot added the comment:
New changeset 58b0f3e1ddf8 by Guido van Rossum in branch 'default':
Fix issue #20367: concurrent.futures.as_completed() for duplicate arguments.
http://hg.python.org/cpython/rev/58b0f3e1ddf8
--
nosy: +python-dev
___
Changes by Guido van Rossum gu...@python.org:
--
resolution: - fixed
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20367
___
Claudiu.Popa added the comment:
Hi. Here's a patch.
--
keywords: +patch
nosy: +Claudiu.Popa
Added file: http://bugs.python.org/file33732/test_deque_19898.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19898
Guido van Rossum added the comment:
AFAICT the changes to selectmodule.c have been rolled back, both in the 3.3 and
the 3.4 (default) branches. That takes care of backwards compatibility. :-)
So what we're talking about is whether (a) the selectors module (new in 3.3)
should export a
Serhiy Storchaka added the comment:
Looks as you forgot to include some test files in the patch.
And these files are too large. Much smaller images would be enough. For example
you can use python.org icon: http://www.python.org/favicon.ico.
--
___
Jeff Edwards added the comment:
It's interesting how long this issue has been around. It seems to be because
the form-urlencoded spec is specified as url-percent-encoding EXCEPT for ' ' -
'+', which does seem to be unintuitive.
To note, there are a few known cases where the exception does
Claudiu.Popa added the comment:
Here's a smaller patch. Serhiy, what test files are missing?
--
Added file: http://bugs.python.org/file33733/test_imghdr_4.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19990
Serhiy Storchaka added the comment:
Last patch contains only pbm and xbm test files, while test_imghdr expects 11
different image files: png, gif, bmp, etc.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19990
Claudiu.Popa added the comment:
Ah, I understand now. Maybe it is related to the fact that I used `hg diff
--git`? Doing the following works for me, both Windows and FreeBsd and all the
files are present afterwards:
1. hg diff --git patch
2. hg import --no-commit patch
Although I'm not sure
Serhiy Storchaka added the comment:
Oh, yes, my bad. I used the patch utility. Sorry.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19990
___
Antoine Pitrou added the comment:
If this is a cygwin build (rather than a standard MSVC build), I'm afraid
that's not a supported platform at all. Did you compile Python yourself?
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
Antoine Pitrou added the comment:
+1 for a separate file from me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20395
___
___
Python-bugs-list
Nadeem Vawda added the comment:
The patch for zlib looks good to me. Thanks for working on this, Serhiy.
We're not allowing changes in semantics for Argument Clinic conversion for
3.4. If it doesn't currently accept None, we can't add it right now, and
we'll have to save it for 3.5.
Fair
Gregory P. Smith added the comment:
I refactored the unittests a bit and added another test for subimports when a
directory within the .zip file is in sys.path as well.
The quizzical wtf TODO I had in the code has been answered in that I am
unable to trigger a situation where path != buf and
New submission from fin swimmer:
Comparison by using memoryview seems not to work completely.
This works:
memoryview(bytearray(range(5))) != memoryview(bytearray(range(5)))
False
memoryview(bytearray(range(5))) == memoryview(bytearray(range(5)))
True
But:
memoryview(bytearray(range(5)))
fin swimmer added the comment:
This is exactly what I need!
Would be a great work.
--
nosy: +fin.swimmer
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20339
___
Ethan Furman added the comment:
Okay, staying with SocketKind.
This patch also has a very small doc enhancement.
--
keywords: +patch
Added file: http://bugs.python.org/file33735/issue20386.stoneleaf.03.patch
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset b28909d501c0 by Serhiy Storchaka in branch '2.7':
Issue #19990: Added tests for the imghdr module.
http://hg.python.org/cpython/rev/b28909d501c0
New changeset fde9e9832749 by Serhiy Storchaka in branch '3.3':
Issue #19990: Added tests for the
Serhiy Storchaka added the comment:
Thank you Claudiu.
I have reorganized tests somewhat and added new test for file position.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker
Roundup Robot added the comment:
New changeset 6f217456b9ba by Serhiy Storchaka in branch 'default':
Issue #20193: The zlib module now uses Argument Clinic.
http://hg.python.org/cpython/rev/6f217456b9ba
--
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
Thank you for reviews, Nadeem, Larry.
--
dependencies: -pydoc fails with the unspecified default value
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker
Serhiy Storchaka added the comment:
Since Argument Clinic no more supports unspecified default value, this issue
can be closed.
--
resolution: - out of date
stage: - committed/rejected
status: open - closed
___
Python tracker
Roundup Robot added the comment:
New changeset 1dac8c954488 by Victor Stinner in branch 'default':
Issue #20367: Add Glenn Langford to Misc/ACKS
http://hg.python.org/cpython/rev/1dac8c954488
--
___
Python tracker rep...@bugs.python.org
STINNER Victor added the comment:
@Guido: Why not fixing the issue in Python 3.3? You forgot to add Gleen
Langford to Misc/ACKS!
@Gleen: Congrats for your first commit :)
--
___
Python tracker rep...@bugs.python.org
Guido van Rossum added the comment:
Sorry, I suppose it needs to be backported to 3.3.
If someone wants to do that, please do (I'm afraid I'd mess up the merge).
--
resolution: fixed - remind
status: closed - open
___
Python tracker
Serhiy Storchaka added the comment:
Thank you Merlijn for your information.
So which patch is more preferable?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19456
___
Antoine Pitrou added the comment:
Here are updated patches for 3.3 and 3.4. Changed tests for 3.4, a patch for
3.3 is changed more. Unfortunately in 3.3 exceptions still can be raised when
try to emit a warning during shutdown. Is there any way to determine the
shutdown mode?
There's
Nikolaus Rath added the comment:
I am working on this now.
--
nosy: +nikratio
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15216
___
___
Merlijn van Deen added the comment:
I'm not sure whether that question was aimed at me -- I think both options have
their merits, but I'd suggest to adopt the .NET semantics. The semantics are
also explicitly defined [1] and the behavior seems to be acceptable for the
.NET world.
[1]
New submission from STINNER Victor:
I reported the issue in Tulip project:
http://code.google.com/p/tulip/issues/detail?id=115
I consider this issue as as serious API flaw and I would like to fix it before
Python 3.4 final.
--
messages: 209366
nosy: gvanrossum, haypo, larry
priority:
Glenn Langford added the comment:
@Victor: Thank you, and I appreciate all your advice! I am still learning the
dev environment but hope to be helpful. :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20367
Christian Heimes added the comment:
Coverity is concerned about the value of `q` when `len 0`. The expression
Py_ssize_t q = len 0 ? 1 + (len - 1) / inrate : 0;
returns a positive, non-null value for len 0. Another check ensures that len
!= 0 a couple of lines earlier. In theory it is
Alexandre Vassalotti added the comment:
+1 from me as well for a separate file.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20395
___
___
Roundup Robot added the comment:
New changeset c2e425a05d35 by Christian Heimes in branch 'default':
Issue #20193: Fix commit r6f217456b9ba by including clinic/zlibmodule.c.h
instead
http://hg.python.org/cpython/rev/c2e425a05d35
--
___
Python
Roundup Robot added the comment:
New changeset bf52f2dbfdde by Christian Heimes in branch 'default':
Issue #20394: Attempt to silence CID 1164423: Division or modulo by zero in
audioop_ratecv_impl()
http://hg.python.org/cpython/rev/bf52f2dbfdde
--
nosy: +python-dev
Changes by Berker Peksag berker.pek...@gmail.com:
--
nosy: +amaury.forgeotdarc, belopolsky, meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19023
___
Changes by Berker Peksag berker.pek...@gmail.com:
--
nosy: +loewis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20391
___
___
Python-bugs-list
Roundup Robot added the comment:
New changeset d960c4cabb2b by Terry Jan Reedy in branch '2.7':
Issue #20338: Increase allowed tip width slightly and wrap long signagure lines.
http://hg.python.org/cpython/rev/d960c4cabb2b
New changeset 7dcc19308a7b by Terry Jan Reedy in branch '3.3':
Issue
Antoine Pitrou added the comment:
This sounds reasonable, at least when the two memoryviews have the same shape.
--
components: +Interpreter Core -Library (Lib)
nosy: +pitrou, skrah
type: behavior - enhancement
___
Python tracker
Terry J. Reedy added the comment:
I increased indent to 4 spaces and made it easier to change.
I believe old-styles classes do not have .__new__, so test of TextWrapper will
ensure that they work.
Inspect.signature should have correct logic to handle .__new__, with or without
.__init__. (I
Gregory P. Smith added the comment:
Updated to make that function (zipimporter_init) easier to follow by not
repurposing the path variable mid-function and allocate the local path buffer
rather than keeping it on the stack.
--
Added file:
Nikolaus Rath added the comment:
Question:
What is the point of the
old_encoding = codecs.lookup(self._encoding).name
encoding = codecs.lookup(encoding).name
if encoding == old_encoding and errors == self._errors:
# no change
return
dance? Isn't
1 - 100 of 139 matches
Mail list logo
