Georg Brandl added the comment:
Paul, could you confirm that backing out the 2807a5f011e4 changeset on the 3.3
branch fixes the problem?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20621
Paul Moore added the comment:
Georg - see http://bugs.python.org/issue20621#msg211209 for what I did. That
shows backing out did *not* fix the issue. But I did backout on the default
branch, and my backout may not have worked as I explained.
I just tried to do hg backout on the 3.3 branch and
Georg Brandl added the comment:
Yeah, just tried the backout, it doesn't apply cleanly anymore --
Modules/zipimport.c has apparently changed some more afterwards.
I think using the parent changeset is the best thing to do at the moment, until
Greg comes up with a patch.
--
assignee:
Tal Einat added the comment:
FYI, with some help from Roger answering various questions, I've cooked up a
version of ClearWindow supporting the current version of IDLE. This includes
integration with the Squeezer extension.
I haven't tested it, however, nor written appropriate tests. I hope
New submission from Xavier de Gaye:
Occurs on the tip of the Python default branch on ArchLinux when running 'make
html PYTHON=python2' from Doc/.
Traceback attached.
--
assignee: docs@python
components: Documentation
files: sphinx-err-DH3qAl.log
messages: 211311
nosy: docs@python,
Georg Brandl added the comment:
Which revision is your tip?
In the latest revision, the documentation should refuse being built with 1.0.7.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20638
Paul Moore added the comment:
OK, confirmed.
Backing out to just before revision 2807a5f011e4 the problem has disappeared.
Re-applying just 2807a5f011e4 causes the issue to appear again.
--
___
Python tracker rep...@bugs.python.org
Jeroen Ruigrok van der Werven added the comment:
Just to confirm that I, indeed, did not run into problems any more with RC1
trying to upgrade setuptools.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20570
Antoine Pitrou added the comment:
Wow, really? Thanks for finding this!
--
nosy: +Mark.Shannon, benjamin.peterson, pitrou
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20637
July Tikhonov added the comment:
Proposed patch attached.
--
Added file: http://bugs.python.org/file34100/pathlib-with_suffix.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20639
___
New submission from July Tikhonov:
The changeset ef2b2ddd27c8 restricted the argument of Path.with_suffix() too
much, and caused some strange behavior.
Case 1: removing suffix completely is disallowed now.
The following code worked before the fix:
pathlib.PurePath('a', 'b.c').with_suffix('')
Nick Coghlan added the comment:
Donald, since you haven't been through an RC period before - just a reminder
that Larry is going to need time to cherry pick the update into the release
clone before rc2 on the 23rd.
--
___
Python tracker
Changes by A.M. Kuchling a...@amk.ca:
--
stage: needs patch - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16728
___
___
New submission from Saimadhav Heblikar:
This patch adds tests for Idle's configHelpSourceEdit.py module.
There is however, a minor issue related to this patch,which is an attribute
error occurring due to lines 108,115,128,139 on
Mark Shannon added the comment:
Well spotted.
I don't think that the line
COPYVAL(tp_dictoffset);
should be removed.
inherit_special() is called from PyType_Ready
which is used to initialise static TypeObjects.
So builtin class B which doesn't set tp_dictoffset,
but has builtin class A as its
Benjamin Peterson added the comment:
pootle.python.org has been disabled.
--
nosy: +benjamin.peterson
resolution: - wont fix
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13663
Changes by Todd Rovito rovit...@rovitotv.org:
--
nosy: +Todd.Rovito
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20640
___
___
Python-bugs-list
Roundup Robot added the comment:
New changeset 3ad7725b5013 by Andrew Kuchling in branch '3.3':
#12211: clarify math.copysign() documentation and docstring
http://hg.python.org/cpython/rev/3ad7725b5013
--
nosy: +python-dev
___
Python tracker
Changes by Mark Dickinson dicki...@gmail.com:
--
resolution: - wont fix
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9009
___
A.M. Kuchling added the comment:
Applied. I added two sentences describing the NaN behaviour.
--
nosy: +akuchling
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
Mark Dickinson added the comment:
The paragraph about NaNs isn't correct. For example:
from math import copysign
copysign(1.0, float('nan'))
1.0
copysign(1.0, -float('nan'))
-1.0
Though it doesn't really make sense to talk about 'positive' or 'negative'
NaNs, a NaN still has a sign bit,
A.M. Kuchling added the comment:
OK; I'll just drop the 'If y is NaN' sentence.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12211
___
___
Mark Dickinson added the comment:
More examples, showing that `y` is not ignored when `x` is a NaN.
result1 = copysign(float('nan'), 1.0)
result2 = copysign(float('nan'), -1.0)
copysign(1.0, result1) # result1 is a NaN whose sign bit is cleared.
1.0
copysign(1.0, result2) # result2 is a
A.M. Kuchling added the comment:
Actually ISTM the 'if x is NaN' sentence can also go; it seems to just copy the
sign bit no matter what x and y are.
from math import *
nan = float('nan')
neg = -nan
copysign(+1, copysign(nan, neg))
-1.0
--
___
Changes by Terry J. Reedy tjre...@udel.edu:
--
assignee: docs@python -
components: +Library (Lib), Tests
nosy: +loewis
title: os.rename documentation slightly inaccurate - Improve os.rename
documentation and tests
___
Python tracker
Mark Dickinson added the comment:
It seems to just copy the sign bit no matter what x and y are.
Yep, that's exactly what happens. The sign bit from y just gets blindly
transferred to x, with no regard to any meaning of x or y. So it works exactly
the same way for zeros, NaNs, infinities,
Simon Cross added the comment:
Genshi is affected by the 3.4 regression too (it has a class that defines
__getnewargs__ and __getattr__).
--
nosy: +hodgestar
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16251
Roundup Robot added the comment:
New changeset b01f4ed077fa by Andrew Kuchling in branch '3.3':
#12211: remove paragraph about NaNs
http://hg.python.org/cpython/rev/b01f4ed077fa
--
___
Python tracker rep...@bugs.python.org
Simon Cross added the comment:
I have an ugly work-around for those affected:
def __getattr__(self, name):
# work around for pickle bug in Python 3.4
# see http://bugs.python.org/issue16251
if name == __getnewargs_ex__:
raise AttributeError(%r has no
Mark Dickinson added the comment:
Thanks! (And apologies for the nitpicking.)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12211
___
___
Donald Stufft added the comment:
Yea, I'll get it done. Was planning on doing it this weekend but I had a
medical issue. I'll see about getting all the things get done asap.
--
___
Python tracker rep...@bugs.python.org
Martin v. Löwis added the comment:
I fail to see the relevant difference between overlapped_dealloc.patch and
overlapped_dealloc-2.patch. What I was asking was that
default:
be replaced with
case ERROR_IO_INCOMPLETE:
and a new
default:
be added that handles all other errors.
Changes by Gregory P. Smith g...@krypto.org:
Added file: http://bugs.python.org/file34103/issue20621-34-rollbacks-gps01.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20621
___
Gregory P. Smith added the comment:
if you look at the zipimport.c file log there was one additional tiny change to
fix a potential memory leak made after the change I suggested backing out:
http://hg.python.org/cpython/log/fb5f4cfc3230/Modules/zipimport.c
anyways, yes, backing up to the
Berker Peksag added the comment:
This was also fixed in default: http://hg.python.org/cpython/rev/2d62ee3c7617
--
nosy: +berker.peksag
resolution: - fixed
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
Terry J. Reedy added the comment:
The new file is modeled on test_config_name.py, as appropriate. I think this
was a good choice for a first test file. The complication you stumbled across
is that the config help-source dialog has two entry boxes, whereas the config
name dialog only has one.
Roundup Robot added the comment:
New changeset b328f8ccbccf by Benjamin Peterson in branch 'default':
look up __getnewargs__ and __getnewargs_ex__ on the object type (#16251)
http://hg.python.org/cpython/rev/b328f8ccbccf
--
nosy: +python-dev
___
Benjamin Peterson added the comment:
Fixed. Should be in 3.4.0.
I'll deal with #16251 in 3.5.
--
assignee: docs@python - larry
nosy: +benjamin.peterson, larry
priority: normal - release blocker
superseder: pickle special methods are looked up on the instance rather than
the type -
Benjamin Peterson added the comment:
(See http://hg.python.org/cpython/rev/b328f8ccbccf)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20261
___
Changes by Benjamin Peterson bp+pyb...@benjamin-peterson.org:
--
assignee: eric.snow - benjamin.peterson
versions: +Python 3.5 -Python 2.7, Python 3.2, Python 3.3, Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16251
Paul Moore added the comment:
OK, I can confirm that both the patches fix the issue when applied to the
relevant branches.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20621
___
Georg Brandl added the comment:
OK. What do you think about rolling a 3.3.5 rc1 release next weekend, with the
final a week later?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20621
___
Donald Stufft added the comment:
I put out the email that I'll be rolling 1.5.3 tues/weds of next week (so 18th
or 19th). Hopefully that's a reasonable time schedule.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20570
Roundup Robot added the comment:
New changeset 3dd8b0d31543 by Benjamin Peterson in branch '2.7':
backout #19081 to fix #20621
http://hg.python.org/cpython/rev/3dd8b0d31543
--
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset 5330de5c9d2d by Benjamin Peterson in branch '3.3':
backout 2807a5f011e4 for causing #20621
http://hg.python.org/cpython/rev/5330de5c9d2d
New changeset 52ab9e1ff46a by Benjamin Peterson in branch 'default':
merge backout for #20621
Benjamin Peterson added the comment:
Okay, I backed out the world.
--
nosy: +benjamin.peterson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20621
___
Benjamin Peterson added the comment:
Note everything was backed out for #19081.
--
nosy: +benjamin.peterson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19081
___
Serhiy Storchaka added the comment:
My fault. I tested the patch with 8.5 and 8.6, but was too lazy to check it
with 8.4. Here is updated patch with workarounded 8.4 peculiarities.
I'm not sure about test_place_forget(). I have removed the check, hope this
will help.
Thank you Ned.
Roundup Robot added the comment:
New changeset 10f09881320d by Benjamin Peterson in branch '2.7':
finish backing out #19081
http://hg.python.org/cpython/rev/10f09881320d
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19081
Roundup Robot added the comment:
New changeset 3350c6b7aa28 by Benjamin Peterson in branch '2.7':
remove tests for #19081
http://hg.python.org/cpython/rev/3350c6b7aa28
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19081
Gregory P. Smith added the comment:
What do you mean by everything? How much did you back out? I *ONLY* wanted
the patches I posted in 20621 backed out as those were the source of the
problem.
The changes made on 2014-01-06 and 2014-01-07 were good even though they only
addressed part of
Benjamin Peterson added the comment:
In 2.7, I backed out 8dbf8edb7128 - f9c54ada1b32 in zipimport. Most of the
commits mentioned this issue, so I assumed they were related. I apologize if
that was too much. It was quite messy with all the subsequent fixups with the
original commit.
Benjamin Peterson added the comment:
Anyway, isn't the change 20b77ff040b6 on Jan 07 exactly what is backed out in
the patch on #20621?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19081
Benjamin Peterson added the comment:
On 3.3/default, d28242a636c7, 2807a5f011e4, fafac90b69c4 were removed.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19081
___
Gregory P. Smith added the comment:
Confirmed that Modules/zipimport.c in the 3.3 and default branches is identical
to the version from late last year. Both should be good for 3.3.5 and 3.4.0
releases.
--
___
Python tracker rep...@bugs.python.org
Gregory P. Smith added the comment:
At this point i'll be reapplying things since 8dbf8edb7128 to 2.7 and trying to
untangle where the problem came in. I confirmed with diff that you've backed
everything out to the pre-January state in all branches.
I've had part of those 2.7 patches
Serhiy Storchaka added the comment:
I think it is worth to mention this in Doc/whatsnew/3.4.rst, as this is a
little incompatible change.
Python 3.3:
x = OSError(2, 'No such file or directory', 'foo', 0, 'bar')
x.args
(2, 'No such file or directory', 'foo', 0, 'bar')
Python 3.4:
x =
Peter Ingebretson added the comment:
Thanks Mark, I agree.
I thought that assigning to tp_dictoffset in inherit_special was redundant with
the assignment in inherit_slot and the assignment I added, but I see that
COPYSLOT and COPYVAL are slightly different and extension types won't go
Claudiu.Popa added the comment:
Hi. Here's a simple patch for this.
--
keywords: +patch
nosy: +Claudiu.Popa
Added file: http://bugs.python.org/file34107/xmlrpc.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20627
New submission from Patrick Westerhoff:
When installing Python 3.4 with the MSI, you can choose to install pip as part
of the setup. With activated UAC on Windows (which is the recommended default),
the installer will ask for elevated rights during the setup to copy the files
over to the
Changes by Andreas Stührk andy-pyt...@hammerhartes.de:
--
nosy: +Trundle
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20637
___
___
Roger Erens added the comment:
I did not fully realize the meaning of it being a sequence as it is referred to
a little later indeed. Which implies both a tuple and a list can be used,
right? So then the patch might look like:
+ The *fieldnames* parameter is a list or tuple of keys used for
New submission from Claudiu.Popa:
Hello!
Here's a patch for improving the performance of tuple deepcopy-ing.
Without patch:
# ./python -m timeit -s import copy; a=tuple(range(100)) -p
copy.deepcopy(a)
10 loops, best of 3: 1.45 sec per loop
With patch:
# ./python -m timeit -s import
Sean Rodman added the comment:
It looks like you are right. I have updated the patch to reflect that it could
be a list or a tuple.
--
Added file: http://bugs.python.org/file34109/DictReader_DictWriter_2.patch
___
Python tracker
Changes by Sean Rodman srodman7...@gmail.com:
Removed file: http://bugs.python.org/file34084/DictReader_DictWriter.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20628
___
New submission from Vladimir Rutsky:
In 3.4 docs after generator.close() description there is strange dot:
http://docs.python.org/3.4/reference/expressions.html#generator.close
Looks like it's due to following code in Doc/reference/expressions.rst:452:
.. class:: .
This line should be
Paul Moore added the comment:
Can anyone confirm if this is a Windows-only issue? I need to know whether I
should block Python 3.3.4 in virtualenv for everyone, or just for Windows.
I only have Windows I can test on.
--
___
Python tracker
New submission from Ned Deily:
eef7899ea7ab introduces changes to the documentation build process which
inadvertently breaks OS X installer builds. See, for example:
http://buildbot.python.org/all/builders/bolen-dmg-3.x/builds/513
Mac/BuildInstaller/build-installer.py should be modified to
Gregory P. Smith added the comment:
I believe this happens on all platforms.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20621
___
___
Roundup Robot added the comment:
New changeset d50a95fab002 by Victor Stinner in branch 'default':
Issue #20616: Add a format() method to tracemalloc.Traceback.
http://hg.python.org/cpython/rev/d50a95fab002
--
nosy: +python-dev
___
Python tracker
STINNER Victor added the comment:
Serhiy Interesting, how isolation mode works on Windows or if Python is
compiled in shared module? Should we keep these environment variables if the
__isolated keyword is used?
The __isolated parameter of script_helper._assert_python() don't start Python
Ned Deily added the comment:
Elevating to release blocker pending evaluation by Martin et al.
--
nosy: +larry, loewis, ncoghlan, ned.deily
priority: normal - release blocker
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20641
Changes by Brian Curtin br...@python.org:
--
nosy: -brian.curtin
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20614
___
___
Python-bugs-list
Roundup Robot added the comment:
New changeset 180e4b678003 by Victor Stinner in branch 'default':
Issue #20320: select.select() and select.kqueue.control() now round the timeout
http://hg.python.org/cpython/rev/180e4b678003
--
nosy: +python-dev
___
Changes by STINNER Victor victor.stin...@gmail.com:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20320
___
STINNER Victor added the comment:
The issue has been fixed.
changeset: 88979:260d6e1e9b0f
user:Yury Selivanov yseliva...@sprymix.com
date:Wed Feb 05 18:11:13 2014 -0500
files: Lib/asyncio/streams.py Lib/test/test_asyncio/test_streams.py
description:
asyncio.streams: Use
New submission from STINNER Victor:
I modified Python shutdown process in issue #19466 to clear Python thread state
earlier, but it introduced a regression: #20526. So I simply reverted my
changes until the real bugs are fixed.
Changeset of the revert: 1166b3321012.
--
assignee:
New submission from STINNER Victor:
In Python 3.4, poll and epoll were modified to round the timeout away from zero
to fix a performance issue in asyncio. I also modified select and kqueue for
the same reason.
changeset: 89230:180e4b678003
tag: tip
user:Victor Stinner
New submission from STINNER Victor:
As the author of the new tracemalloc of Python 3.4, I would to see this new
method in Python 3.4 final. See issue #20616 for more information.
changeset: 89229:d50a95fab002
user:Victor Stinner victor.stin...@gmail.com
date:Sun Feb 16
Mark Shannon added the comment:
This looks good to me.
Also, I think this should go into 3.4
It is a tiny patch and could result in significant memory saving for OO
programs with inheritance (e.g. Django)
--
___
Python tracker
STINNER Victor added the comment:
Also, I think this should go into 3.4
I think that it's too late for optimizations in Python 3.4 (RC1 is alread out).
It can wait Python 3.5, or maybe 3.4.1.
--
nosy: +haypo
___
Python tracker
Paul Moore added the comment:
Will someone make sure this gets logged the way it needs to for Larry's 3.4rc2
cherrypick process? Ta.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20621
New submission from STINNER Victor:
I consider that it's not too late to include these changes to Python 3.4 final
because asyncio module is new in Python 3.4. Very few people outside asyncio
developers are testing asyncio, so it's not surprising to see these changes
only recently. asyncio
Changes by STINNER Victor victor.stin...@gmail.com:
--
priority: normal - release blocker
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20648
___
STINNER Victor added the comment:
Does anyone know how to write a unit test to ensure that the regression will
not be reintroduced later?
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20621
Yury Selivanov added the comment:
I think we should just ask Larry to merge all commits for asyncio in 3.4.
I.e. we won't commit anything that should not go in 3.4 anyways.
--
___
Python tracker rep...@bugs.python.org
Guido van Rossum added the comment:
Right, that has been my understanding. Larry has said he'd give asyncio a
generous exception because it's all new in 3.4.
On Sunday, February 16, 2014, Yury Selivanov rep...@bugs.python.org wrote:
Yury Selivanov added the comment:
I think we should just
Guido van Rossum added the comment:
Then again Larry might appreciate a full list of what to cherrypick.
On Sunday, February 16, 2014, Guido van Rossum rep...@bugs.python.org
wrote:
Guido van Rossum added the comment:
Right, that has been my understanding. Larry has said he'd give asyncio
Changes by Martin Panter vadmium...@gmail.com:
--
nosy: +vadmium
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12849
___
___
Python-bugs-list
Changes by STINNER Victor victor.stin...@gmail.com:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20616
___
STINNER Victor added the comment:
Of all these, 4194303 is the smallest, it's only 2**22-1, i.e. 48 days in the
future
Maybe asyncio can uses a maximum timeout of 30 days? Or maybe even 1 day. Wake
up every day to recompute the timeout should not kill the battery of your
laptop or of your
Changes by Martin Panter vadmium...@gmail.com:
--
nosy: +vadmium
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20632
___
___
Python-bugs-list
Larry Hastings added the comment:
I agree: definitely not for 3.5, maybe for 3.4.1.
--
nosy: +larry
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20637
___
Charles-Axel Dein added the comment:
Updated patch following review.
--
Added file: http://bugs.python.org/file34110/add_csvdict_examples.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20351
Martin Panter added the comment:
I suggest using setdefault() in urllib.request.AbstractHTTPHandler.do_open():
headers.setdefault(Connection, close)
I am trying to work around a server that truncates its response when this
header is sent, and this change would allow me to specify
Brett Cannon added the comment:
Thanks for the patch, Cladiu! Since the 3.5 branch is not open yet it might not
be until late March or April when I can look at this patch and get it
committed, but I will get to it.
--
assignee: - brett.cannon
___
New submission from Brett Cannon:
http://docs.python.org/3.4/library/asyncio-dev.html
While a task in running in the event loop should be a task is running.
--
assignee: brett.cannon
components: Documentation
messages: 211389
nosy: brett.cannon
priority: low
severity: normal
stage:
New submission from Brett Cannon:
http://docs.python.org/3.4/library/asyncio-eventloop.html#asyncio.BaseEventLoop.run_in_executor
executor is a Executor instance, the default executor is used if executor is
None. could maybe be The executor argument should be an Executor instance.
The default
New submission from Gregory P. Smith:
Please cherry-pick 52ab9e1ff46a to roll back the zipimport brokenness.
This is the change that fixes issue20621 which is causing a rapid 3.3.5 brown
bag release.
--
assignee: larry
messages: 211391
nosy: gregory.p.smith, larry
priority: release
New submission from Vajrasky Kok:
From
http://docs.python.org/3.4/library/asyncio-task.html#example-future-with-run-until-complete
there is an example code:
import asyncio
@asyncio.coroutine
def slow_operation(future):
yield from asyncio.sleep(1)
future.set_result('Future in done!')
1 - 100 of 106 matches
Mail list logo
