[issue22695] open() declared deprecated in python 3 docs

2014-11-03 Thread Georg Brandl
Georg Brandl added the comment: LGTM. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.or

[issue22775] SimpleCookie not unpicklable with protocol 2+

2014-11-03 Thread Georg Brandl
Georg Brandl added the comment: Thanks! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue22758] Regression in Python 3.2 cookie parsing

2014-11-03 Thread Georg Brandl
Georg Brandl added the comment: That seems like the best course of action. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue22780] NotImplemented doc section needs update

2014-11-03 Thread Georg Brandl
Georg Brandl added the comment: You add a label before that section and then reference it with :ref:. -- ___ Python tracker ___ ___ Py

[issue22780] NotImplemented doc section needs update

2014-11-03 Thread Ethan Furman
Ethan Furman added the comment: How about: Special value which should be returned by the binary special methods (e.g. :meth:`__eq__`, :meth:`__lt__`, :meth:`__add__`, :meth:`__rsub__`, etc.) to indicate that the operation is not implemented with respect to the other type; may be

[issue21931] Nonsense errors reported by msilib.FCICreate for bad argument

2014-11-03 Thread Martin v . Löwis
Martin v. Löwis added the comment: I haven't had any time to work on Python in the last year, so it may take some more time for me to look into this. -- ___ Python tracker ___ _

[issue22780] NotImplemented doc section needs update

2014-11-03 Thread Ethan Furman
Ethan Furman added the comment: Thank you, Raymond, both for your concern and your discretion. My interest in changing the "can" or "may" to "should" is that, whatever the original intent of the PEP, the way Python works /now/ is that any class that doesn't return NotImplemented when it /shoul

[issue22789] Compress the marshalled data in PYC files

2014-11-03 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- Removed message: http://bugs.python.org/msg230580 ___ Python tracker ___ ___ Python-bugs-list mailin

[issue22789] Compress the marshalled data in PYC files

2014-11-03 Thread Raymond Hettinger
Raymond Hettinger added the comment: Looking into this further, I suspect that the cleanest way to implement this would be to add a zlib compression and decompression using to the marshal.c (bumping the version number to 5). -- ___ Python tracker <

[issue22789] Compress the marshalled data in PYC files

2014-11-03 Thread Raymond Hettinger
Raymond Hettinger added the comment: Looking into this further, I suspect that the cleanest way to implement this would be to add a marshal version 4 that compresses and decompresses using zlib. -- components: +Interpreter Core nosy: +brett.cannon, pitrou __

[issue22780] NotImplemented doc section needs update

2014-11-03 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- Removed message: http://bugs.python.org/msg230579 ___ Python tracker ___ ___ Python-bugs-list mailin

[issue22780] NotImplemented doc section needs update

2014-11-03 Thread Raymond Hettinger
Raymond Hettinger added the comment: FWIW, I think doc changes like this need to be made by the people most familiar with the implementation details and with the original design intent (i.e. the authors of PEP 207). The knowledge here is fragile and it would be easy to accidentally make-up new

[issue22725] improve documentation for enumerate() (built-in function)

2014-11-03 Thread Raymond Hettinger
Raymond Hettinger added the comment: static PyObject * > Why do you say that 'sequence' is a keyword? It is a keyword argument to enumerate(). Here's the relevant section of code: enum_new(PyTypeObject *type, PyObject *args, PyObject *kwds) { enumobject *en; PyObject *seq = NULL; P

[issue22719] os.path.isfile & os.path.exists bug in while loop

2014-11-03 Thread Zachary Ware
Zachary Ware added the comment: Aaron, what version of Python are you using on what version of Windows? Also, 32 or 64 bit on both? I can't reproduce this with any Python 3.3.6 or newer on 64-bit Windows 8.1. -- ___ Python tracker

[issue22789] Compress the marshalled data in PYC files

2014-11-03 Thread Raymond Hettinger
New submission from Raymond Hettinger: Save space and reduce I/O time (reading and writing) by compressing the marshaled code in files. In my code tree for Python 3, there was a nice space savings 19M to 7M. Here's some of the output from my test: 8792 -> 4629 ./Tools/scripts/__pyca

[issue22725] improve documentation for enumerate() (built-in function)

2014-11-03 Thread Tshepang Lekhonkhobe
Tshepang Lekhonkhobe added the comment: @raymond Why do you say that 'sequence' is a keyword? >>> enumerate() Traceback (most recent call last): File "", line 1, in TypeError: Required argument 'sequence' (pos 1) not found That means that 'sequence' can be changed to 'iterable' without worr

[issue17896] Move Windows external libs from \..\ to \externals

2014-11-03 Thread Zachary Ware
Zachary Ware added the comment: Good point, David. Jeremy, Trent, you're the only other Windows buildbot operators as far as I know; feel free to clean up the old externals locations as you like. Also, sorry to make it a bit hairier to operate, but I think this is a big enough improvement fo

[issue20160] broken ctypes calling convention on MSVC / 64-bit Windows (large structs)

2014-11-03 Thread Steve Dower
Steve Dower added the comment: Patch looks good to me, but given this issue, #11835, #22733, and probably more, should we be integrating from libffi (which apparently has fixes for some of these) more often? I know nothing about how we move code between that and ctypes. -- nosy: +stev

[issue22758] Regression in Python 3.2 cookie parsing

2014-11-03 Thread Tim Graham
Tim Graham added the comment: Georg, how do want to proceed with this issue? Should we backport #16611 (support for parsing secure/httponly flag) to 3.2 to fix this regression and then create a separate issue to fix the lax parsing issue on all versions? -- ___

[issue22787] ssl.SSLContext.load_cert_chain() backport regression with None as keyfile

2014-11-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset e54d0b197c82 by Benjamin Peterson in branch '2.7': allow keyfile argument to be None (closes #22787) https://hg.python.org/cpython/rev/e54d0b197c82 -- nosy: +python-dev resolution: -> fixed stage: -> resolved status: open -> closed __

[issue826897] Proto 2 pickle vs dict subclass

2014-11-03 Thread Tim Graham
Tim Graham added the comment: Cookie pickling issue should be fixed in #22775. -- nosy: +Tim.Graham ___ Python tracker ___ ___ Python

[issue22650] set up and use VM for net access in the test suite

2014-11-03 Thread Antoine Pitrou
Antoine Pitrou added the comment: Not to mention possible cookie tests, I suppose. (I would personally have preferred something like "comfychair.net", but I guess pythontest.net is ok too :-)) -- nosy: +pitrou ___ Python tracker

[issue22788] allow logging.handlers.HTTPHandler to take an SSLContext

2014-11-03 Thread Arfrever Frehtes Taifersar Arahesis
Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue22417] PEP 476: verify HTTPS certificates by default

2014-11-03 Thread Benjamin Peterson
Benjamin Peterson added the comment: Somehow the Windows bots are failing to verify python.org http://buildbot.python.org/all/builders/x86%20XP-4%203.x/builds/11179/steps/test/logs/stdio -- ___ Python tracker

[issue22780] NotImplemented doc section needs update

2014-11-03 Thread R. David Murray
R. David Murray added the comment: I was actually thinking of the Implementing the arithmetic operations section. Maybe we should copy the parenthetical from the datamodel description into the text you are modifying, and then link to the implementing section. -- _

[issue22780] NotImplemented doc section needs update

2014-11-03 Thread Ethan Furman
Ethan Furman added the comment: I found these items: Doc/c-api/object.rst .. c:var:: PyObject* Py_NotImplemented The ``NotImplemented`` singleton, used to signal that an operation is not implemented for the given type combination. Doc/extending/newtypes.rst

[issue7559] TestLoader.loadTestsFromName swallows import errors

2014-11-03 Thread R. David Murray
R. David Murray added the comment: I would love that, but I think the fix depends on a feature. Robert will know for sure. -- ___ Python tracker ___

[issue22780] NotImplemented doc section needs update

2014-11-03 Thread R. David Murray
R. David Murray added the comment: Sounds OK to me. There should already be a discussion of the consequences of returning it (I don't remember where, though), and it would be nice to link to that discussion. Note that any doc change should be applied to 3.4 first, and then merged to 3.5. ---

[issue21650] add json.tool option to avoid alphabetic sort of fields

2014-11-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: LGTM. -- stage: patch review -> commit review ___ Python tracker ___ ___ Python-bugs-list mailing

[issue22366] urllib.request.urlopen should take a "context" (SSLContext) argument

2014-11-03 Thread Arfrever Frehtes Taifersar Arahesis
Arfrever Frehtes Taifersar Arahesis added the comment: Please update versionchanged to 3.4.3 on default branch. -- ___ Python tracker ___

[issue22780] NotImplemented doc section needs update

2014-11-03 Thread Ethan Furman
Ethan Furman added the comment: + Special value which should be returned by the special methods + (:meth:`__eq__`, :meth:`__lt__`, :meth:`__add__`, etc.) to indicate + that the operation is not implemented with respect to the other type. After a discussion on python-dev, I think this wordi

[issue22735] Fix various crashes exposed through mro() customization

2014-11-03 Thread Benjamin Peterson
Benjamin Peterson added the comment: Thank you for the patchset. I wonder if we should just forbid most reentrancy i.e. set a flag on the type when it's being constructed and not let type_set_bases be called then. Setting __bases__ from within mro() doesn't seem very useful outside of producin

[issue22766] collections.Counter's in-place operators should return NotImplemented for unsupported types

2014-11-03 Thread Ethan Furman
Ethan Furman added the comment: Okay, the python-dev ruling is in, and raising an exception in the __ixxx__ methods is allowed, and even a good idea in the cases of mutable containers. However, doing the check on 'other' and raising a TypeError with an appropriate message would still be better

[issue22788] allow logging.handlers.HTTPHandler to take an SSLContext

2014-11-03 Thread Alex Gaynor
Alex Gaynor added the comment: Quick pass at a patch. No docs, and it should proabbly be an error to pass context with secure=False. -- keywords: +needs review, patch Added file: http://bugs.python.org/file37124/issue22788.diff ___ Python tracker

[issue7559] TestLoader.loadTestsFromName swallows import errors

2014-11-03 Thread Domen Kožar
Domen Kožar added the comment: Could we backport this one to 3.x and 2.7? It's leads to really bad UX. -- ___ Python tracker ___ ___ Py

[issue22417] PEP 476: verify HTTPS certificates by default

2014-11-03 Thread Benjamin Peterson
Benjamin Peterson added the comment: Okay, 3.4/3.5 have been dealt with. I had to hack up test_logging a bit. (#22788 would make that better). 2.7 now needs a backport. -- ___ Python tracker __

[issue22417] PEP 476: verify HTTPS certificates by default

2014-11-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 2afe5413d7af by Benjamin Peterson in branch '3.4': PEP 476: enable HTTPS certificate verification by default (#22417) https://hg.python.org/cpython/rev/2afe5413d7af New changeset 731375f83406 by Benjamin Peterson in branch 'default': merge 3.4 (#224

[issue22788] allow logging.handlers.HTTPHandler to take an SSLContext

2014-11-03 Thread Benjamin Peterson
Benjamin Peterson added the comment: Right then... -- title: allow HTTPHandler to take an SSLContext -> allow logging.handlers.HTTPHandler to take an SSLContext ___ Python tracker _

[issue22788] allow HTTPHandler to take an SSLContext

2014-11-03 Thread Alex Gaynor
Alex Gaynor added the comment: Hah! I didn't realize you meant *logging.handlers.HTTPHandler*, I thought you meant *urllib.request.HTTPHandler*. -- ___ Python tracker ___ __

[issue22788] allow HTTPHandler to take an SSLContext

2014-11-03 Thread Benjamin Peterson
Benjamin Peterson added the comment: emit() On Mon, Nov 3, 2014, at 15:33, Alex Gaynor wrote: > > Alex Gaynor added the comment: > > I'm not sure I follow, where does HTTPHandler ever construct an > HTTPSConnection? > > -- > nosy: +alex > > ___ > P

[issue22788] allow HTTPHandler to take an SSLContext

2014-11-03 Thread Alex Gaynor
Alex Gaynor added the comment: I'm not sure I follow, where does HTTPHandler ever construct an HTTPSConnection? -- nosy: +alex ___ Python tracker ___

[issue1539381] Add readinto method to StringIO and cStringIO

2014-11-03 Thread Silvio Ricardo Cordeiro
Silvio Ricardo Cordeiro added the comment: BufferedReader assumes that readinto is defined, but that's not the case for StringIO's. In the end, this cripples StringIO objects, because their data can never be peek()'ed as with all other file objects. -- components: +IO -Library (Lib) no

[issue22788] allow HTTPHandler to take an SSLContext

2014-11-03 Thread Benjamin Peterson
New submission from Benjamin Peterson: It would be nice if HTTPHandler could take an SSLContext as a parameter, which would be passed to HTTPSConnection to configure the security of the connection. -- components: Library (Lib) messages: 230549 nosy: benjamin.peterson, vinay.sajip priori

[issue22417] PEP 476: verify HTTPS certificates by default

2014-11-03 Thread Alex Gaynor
Alex Gaynor added the comment: Fix for the failing test_ssl testes. -- Added file: http://bugs.python.org/file37123/issue22417.diff ___ Python tracker ___ ___

[issue22766] collections.Counter's in-place operators should return NotImplemented for unsupported types

2014-11-03 Thread Ethan Furman
Ethan Furman added the comment: Ethan stated: >> The only problem with the design is that it does not play well with others. >> For >> duck-typeable just do a check on 'other' to see if it has an .items() >> method, and >> return NotImplemented if it does not. Oh, and check that 'self' is Cou

[issue22676] _pickle's whichmodule() is slow

2014-11-03 Thread Steve Dower
Steve Dower added the comment: (Looks like I was outsmarted by the tracker when trying to put line numbers in my links... is there a way to do that?) -- ___ Python tracker ___ _

[issue22676] _pickle's whichmodule() is slow

2014-11-03 Thread Steve Dower
Steve Dower added the comment: The fix for this now uses module without initializing it, which could lead to a crash if get_dotted_path() tries to raise an exception (it puts module into the error string with %R). See Modules/_pickle.c#l1656 and Modules/_pickle.c#l1538. I think the fix is to i

[issue22766] collections.Counter's in-place operators should return NotImplemented for unsupported types

2014-11-03 Thread Jim Jewett
Jim Jewett added the comment: If I know that a Counter (or any class X) can be updated in place, I will be surprised to find out that I'm using a different instance after a successful in-place operation. I would even consider that (replacement of the original instance) a security risk, though

[issue22784] test_asyncio fails without the ssl module

2014-11-03 Thread Guido van Rossum
Guido van Rossum added the comment: OK, them LGTM. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue22787] ssl.SSLContext.load_cert_chain() backport regression with None as keyfile

2014-11-03 Thread Alex Gaynor
Changes by Alex Gaynor : -- keywords: +needs review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue22417] PEP 476: verify HTTPS certificates by default

2014-11-03 Thread Alex Gaynor
Alex Gaynor added the comment: Latest patch fixes the urllib2_localnet tests. -- Added file: http://bugs.python.org/file37122/issue22417.diff ___ Python tracker ___ _

[issue22787] ssl.SSLContext.load_cert_chain() backport regression with None as keyfile

2014-11-03 Thread Alex Gaynor
Changes by Alex Gaynor : -- keywords: +patch Added file: http://bugs.python.org/file37121/issue22787.diff ___ Python tracker ___ ___ P

[issue22417] PEP 476: verify HTTPS certificates by default

2014-11-03 Thread Benjamin Peterson
Benjamin Peterson added the comment: % ./python Lib/test/regrtest.py -v test_urllib2_localnet == CPython 3.4.2+ (3.4:7be6ef737aaf+, Nov 3 2014, 10:03:11) [GCC 4.8.3] == Linux-3.16.5-gentoo-x86_64-Intel-R-_Core-TM-_i7-2860QM_CPU_@_2.50GHz-with-gentoo-2.2 little-endian == hash algorithm: siph

[issue22787] ssl.SSLContext.load_cert_chain() backport regression with None as keyfile

2014-11-03 Thread Alex Gaynor
Changes by Alex Gaynor : -- nosy: +alex, christian.heimes, dstufft, giampaolo.rodola, janssen, pitrou ___ Python tracker ___ ___ Pytho

[issue22787] ssl.SSLContext.load_cert_chain() backport regression with None as keyfile

2014-11-03 Thread Till Maas
Till Maas added the comment: sorry, it should be: requests.get("https://example.com";, cert="keycert.pem") -- ___ Python tracker ___ _

[issue22787] ssl.SSLContext.load_cert_chain() backport regression with None as keyfile

2014-11-03 Thread Till Maas
New submission from Till Maas: https://github.com/python/cpython/commit/71a4ee3ea2c6847b9fc4b33cbc8d565a7bf2424a introduces a regression in ssl.SSLContext.load_cert_chain() https://github.com/python/cpython/blob/2.7/Modules/_ssl.c#L2462 With this change it is not possible to specify None as ke

[issue22650] set up and use VM for net access in the test suite

2014-11-03 Thread Donald Stufft
Donald Stufft added the comment: It is configured using salt, see https://github.com/python/psf-salt/blob/master/salt/pythontest/init.sls. A separate domain just makes it easier to do whatever we need with it without needing to worry about getting confused between live sites and test sites. -

[issue2504] Add gettext.pgettext() and variants support

2014-11-03 Thread Éric Araujo
Changes by Éric Araujo : -- stage: patch review -> needs patch versions: -Python 3.2, Python 3.3, Python 3.4, Python 3.6 ___ Python tracker ___ __

[issue2504] Add gettext.pgettext() and variants support

2014-11-03 Thread Wichert Akkerman
Wichert Akkerman added the comment: Bump. Python 3 is still not on my radar, but I'll happily do a backport for Py2 and drop that on PyPI once this gets resolved. -- versions: +Python 3.3, Python 3.4, Python 3.5, Python 3.6 ___ Python tracker

[issue22766] collections.Counter's in-place operators should return NotImplemented for unsupported types

2014-11-03 Thread R. David Murray
R. David Murray added the comment: On Mon, 03 Nov 2014 10:53:09 +, Ethan Furman wrote: > > Ethan Furman added the comment: > > > I don't want to change the kind of exception being raised (an API change > > from > > AttributeError to TypeError) without a really good reason. > > Subclasses

[issue22650] set up and use VM for net access in the test suite

2014-11-03 Thread R. David Murray
R. David Murray added the comment: Why a separate domain rather than a subdomain? I'm not objecting, but I am curious. -- ___ Python tracker ___ ___

[issue22753] urllib2 localnet Changed test to lookup IP-address of localhost

2014-11-03 Thread Håkan Lövdahl
Håkan Lövdahl added the comment: Yes, I can confirm that changing 'URL' to be 'http://127.0.0.1' works. I think that would be a solution to this. -- ___ Python tracker ___ _

[issue6721] Locks in the standard library should be sanitized on fork

2014-11-03 Thread Nir Soffer
Changes by Nir Soffer : -- nosy: +nirs ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/m

[issue22766] collections.Counter's in-place operators should return NotImplemented for unsupported types

2014-11-03 Thread Ethan Furman
Ethan Furman added the comment: > I don't want to change the kind of exception being raised (an API change from > AttributeError to TypeError) without a really good reason. Subclasses cannot work with the current implementation. > In general, in-place methods are not required to return NotImple

[issue21650] add json.tool option to avoid alphabetic sort of fields

2014-11-03 Thread Berker Peksag
Changes by Berker Peksag : Added file: http://bugs.python.org/file37119/issue21650_v4.diff ___ Python tracker ___ ___ Python-bugs-list mailing

[issue8350] Document lack of support for keyword arguments in C functions

2014-11-03 Thread Yongzhi Pan
Changes by Yongzhi Pan : -- nosy: +fossilet ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue22650] set up and use VM for net access in the test suite

2014-11-03 Thread Georg Brandl
Georg Brandl added the comment: Nice! How do you plan to organize its setup? -- ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue22784] test_asyncio fails without the ssl module

2014-11-03 Thread Antoine Pitrou
Antoine Pitrou added the comment: The problem is the default value for `purpose` in the function declaration (the signature mocks the ssl.create_default_context() function, so I don't think it's ok to change the default parameter value here). -- ___

[issue22457] load_tests not invoked in root __init__.py when start=package root

2014-11-03 Thread Robert Collins
Changes by Robert Collins : Added file: http://bugs.python.org/file37118/issue22457.patch ___ Python tracker ___ ___ Python-bugs-list mailing