[issue22560] Add loop-agnostic SSL implementation to asyncio

2015-01-02 Thread Antoine Pitrou
Antoine Pitrou added the comment: Antoine, can you please elaborate the rationale of your patch? The patch adds SSL support for proactor-based event loops (any event loop supporting plain sockets, actually, so it could also work for libuv etc.). Is the legacy code only used on Python 3.4

[issue23150] urllib parse incorrect handing of params

2015-01-02 Thread Julian Reschke
New submission from Julian Reschke: urllib.parse tries to special-case params, which have been dropped from the general URI syntax back in RFC 2396 (16 years ago). In most cases this can be worked around by reconstructing the path from both path and params; however this fails for paths that

[issue23146] Incosistency in pathlib between / and \

2015-01-02 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: pathlib.PureWindowsPath('c:/a/b', '/x/y') PureWindowsPath('c:/x/y') pathlib.PureWindowsPath('//?/c:/a/b', '/x/y') PureWindowsPath('/x/y') pathlib.PureWindowsPath(r'\\?\c:\a\b', '/x/y') PureWindowsPath('//?/c:/x/y') I suppose this is because in

[issue23147] Possible error in _header_value_parser.py

2015-01-02 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: In UnstructuredTokenList._fold() at line 439 the fold() method is called with one positional argument. if part.has_fws: part.fold(folded) continue But there are no fold() methods with one positional parameter.

[issue23148] Missing the charset parameter in as_encoded_word()

2015-01-02 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: In Lib/email/_header_value_parser.py:460 the as_encoded_word() method is called without mandatory argument charset. -- components: Library (Lib), email messages: 233310 nosy: barry, r.david.murray, serhiy.storchaka priority: normal severity: normal

[issue23149] Typo in PEP-0008 - this PEP do not

2015-01-02 Thread Jonathan Sharpe
Changes by Jonathan Sharpe j.r.sharpe+pyt...@gmail.com: -- assignee: docs@python components: Documentation files: fix_pep8_typo.patch keywords: patch nosy: docs@python, jonrsharpe priority: normal severity: normal status: open title: Typo in PEP-0008 - this PEP do not type: enhancement

[issue23149] Typo in PEP-0008 - this PEP do not

2015-01-02 Thread Barry A. Warsaw
Changes by Barry A. Warsaw ba...@python.org: -- nosy: +barry ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23149 ___ ___ Python-bugs-list mailing

[issue1602] windows console doesn't print or input Unicode

2015-01-02 Thread Glenn Linderman
Glenn Linderman added the comment: Just to note that another side effect of this bug is that stepping through code where the source contains non-ASCII characters results in pdb producing an error when trying to print the source lines. This makes stepping through such source code impossible.

[issue21360] mailbox.Maildir should ignore files named with a leading dot

2015-01-02 Thread Vincent Davis
Changes by Vincent Davis vinc...@vincentdavis.com: -- nosy: +Vincentdavis ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21360 ___ ___

[issue18983] Specify time unit for timeit CLI

2015-01-02 Thread Berker Peksag
Berker Peksag added the comment: I've added a couple of comments on Rietveld. -- nosy: +berker.peksag ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18983 ___

[issue23151] _loggerClass is initialized twice

2015-01-02 Thread Vinay Sajip
Vinay Sajip added the comment: The code in Manager.getLogger() allows an overriding logger class for that manager instance only - if it's not set (which is the default), it uses the module global _loggerClass. The lines rv = (self.loggerClass or _loggerClass)(name) indicate this. The module

[issue23151] _loggerClass is initialized twice

2015-01-02 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: In Lib/logging/__init__.py at line 1089 _loggerClass is initialized to None. The code in Manager.getLogger() expects that it can be None. But at line 1549 _loggerClass is initialized to Logger. And there is no official way to set it to None. Looks as

[issue4431] Distutils MSVC doesn't create manifest file

2015-01-02 Thread Steve Dower
Steve Dower added the comment: It shouldn't be necessary for VS 2010 and later, and the `extra_link_args=['/MANIFEST']` workaround should be sufficient for cases where it is necessary (specific dependencies other than MSVCRT that require manifests). --

[issue23149] Typo in PEP-0008 - this PEP do not

2015-01-02 Thread Roundup Robot
New submission from Roundup Robot: New changeset 0c72bd524aed by Benjamin Peterson in branch 'default': conjugate 'do' correctly (closes #23149) https://hg.python.org/peps/rev/0c72bd524aed -- nosy: +python-dev resolution: - fixed stage: - resolved status: open - closed

[issue23058] argparse silently ignores arguments

2015-01-02 Thread Rémi Rampin
Rémi Rampin added the comment: I might use your workaround in ReproZip (https://github.com/ViDA-NYU/reprozip/issues/89), thanks. I agree that it doesn't look pretty... -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23058

[issue23151] _loggerClass is initialized twice

2015-01-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Is this causing some actual problem? No, this does not cause actual problem except that it looks confusing. So really this decreased readability to me. -- ___ Python tracker rep...@bugs.python.org

[issue23010] unclosed file warning when defining unused logging FileHandler in dictConfig

2015-01-02 Thread Vinay Sajip
Vinay Sajip added the comment: Sorry I've not had much time to look at this yet. I haven't forgotten. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23010 ___

[issue4431] Distutils MSVC doesn't create manifest file

2015-01-02 Thread Steve Dower
Steve Dower added the comment: And I suspect Matthew Brett's issue is that link_executable() does not expect an extension ('.exe') to be provided. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4431

[issue23151] _loggerClass is initialized twice

2015-01-02 Thread Vinay Sajip
Vinay Sajip added the comment: Okay, I'll see if I can make it clearer. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23151 ___ ___

[issue4431] Distutils MSVC doesn't create manifest file

2015-01-02 Thread Steve Dower
Steve Dower added the comment: /MANIFEST is probably assumed on VC9 since the CRT required it, but that was probably changed for VC10 without updating the documentation fully. Frankly I'd rather remove the MANIFESTFILE property added by distutils, since it doesn't add anything of value (on my

[issue23152] fstat64 required on Windows

2015-01-02 Thread Steve Dower
Steve Dower added the comment: Looks like the easiest fix here is to remove the HAVE_SYS_STAT_H definition and replace it with the include directly: /* Define to 1 if you have the sys/stat.h header file. */ /* #define HAVE_SYS_STAT_H 1 */ #ifndef MS_WINCE /* Rather than define

[issue15933] flaky test in test_datetime

2015-01-02 Thread Vincent Davis
Vincent Davis added the comment: Rather than dealing with the time delta how about getting the time twice and checking that we are between and at least once we have the same day. i.e. ts1 = time() today = self.theclass.today() ts2 = time() todayagain1 = self.theclass.fromtimestamp(ts1)

[issue4431] Distutils MSVC doesn't create manifest file

2015-01-02 Thread Matthew Brett
Matthew Brett added the comment: I think the argument previously was that VS 2010 was not the default compiler for Python 2.7, and so this problem was not important, but I'm happy to be corrected. I haven't tried building extensions for Python 2.7 with VS 2010 but I guess the problem will be

[issue23150] urllib parse incorrect handing of params

2015-01-02 Thread Senthil Kumaran
Senthil Kumaran added the comment: Hello Julian, Can you please provide a test case of this parsing misbehavior? It might be easier to identify with the testcase. Better yet, the patch changing the parsing logic will help identify if we are dealing with any regression. Thanks! --

[issue23152] fstat64 required on Windows

2015-01-02 Thread Steve Dower
Steve Dower added the comment: Okay, I'll try and find a way to redefine it only under Windows. Unfortunately, the CRT defines fstat() as a function, which makes it hard to redefine without eagerly including sys/stat.h. -- ___ Python tracker

[issue23153] Clarify Boolean Clause Results

2015-01-02 Thread Ethan Furman
Ethan Furman added the comment: `or` does not return the last item evaluated -- it returns the first truthy item, or, if no truthy items, the last false item: -- 0 or {} {} -- 0 or 1 or {} 1 -- nosy: +ethan.furman ___ Python tracker

[issue20544] Use specific asserts in operator tests

2015-01-02 Thread Vincent Davis
Vincent Davis added the comment: Looks like this is ready to be applied and closed or just closed. -- nosy: +Vincentdavis ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20544 ___

[issue18983] Specify time unit for timeit CLI

2015-01-02 Thread Vincent Davis
Vincent Davis added the comment: Anything else need to be done on this patch? -- nosy: +Vincentdavis ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18983 ___

[issue23152] fstat64 required on Windows

2015-01-02 Thread Steve Dower
New submission from Steve Dower: Currently test_largefile is failing on the Windows buildbots because an fstat() call in Modules/_io/fileio.c is failing. fstat() returns a 32-bit size, but the file being opened is larger than 2GB. This appears to be a change in the CRT where it would

[issue23136] BUG in how _strptime() handles week 0

2015-01-02 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Note that round-trip also fails in weeks 52-53. For example, datetime.strptime('2014 53 6', '%Y %W %w') datetime.datetime(2015, 1, 10, 0, 0) datetime.strptime('2014 53 6', '%Y %W %w').strftime('%Y %W %w') '2015 01 6' If we decide to make 2015 0 0

[issue23136] BUG in how _strptime() handles week 0

2015-01-02 Thread Jim Carroll
Jim Carroll added the comment: All the proposed patches are acceptable from my point of view, but it would be really great if we could get the fix in the 2.x line. It seems unlikely there could be any legacy code that would depend on the bug to exist (ie: to only be wrong when then date

[issue19143] Finding the Windows version getting messier (detect windows 8.1?)

2015-01-02 Thread eryksun
eryksun added the comment: if (not version.GetFileVersionInfoW(name, None, size, ver_block) or not ver_block): Arrays don't implement __bool__ and have fixed __len__, so ver_block is always True. You could look at ver_block[0] or ver_block.value (i.e. the C string value). --

[issue4431] Distutils MSVC doesn't create manifest file

2015-01-02 Thread Stephen Hansen
Stephen Hansen added the comment: Just to be clear, I ran into this exact issue recently in VS2010 professional as I indicated earlier. I don't know about what should or should not be needed, but the solution in the original comment fixed it exactly for me. --

[issue22128] patch: steer people away from codecs.open

2015-01-02 Thread Martin Panter
Martin Panter added the comment: Just pointing out there is a patch for Issue 19548 for Python 3 which also adds a pointer to the builtin open() function and updates the codecs.open() caveats. That issue doesn’t touch Python 2 though. -- nosy: +vadmium

[issue19143] Finding the Windows version getting messier (detect windows 8.1?)

2015-01-02 Thread Steve Dower
Steve Dower added the comment: Thanks for the feedback. Updated the attachment with some other tidying too. -- Added file: http://bugs.python.org/file37586/win32_ver.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19143

[issue19143] Finding the Windows version getting messier (detect windows 8.1?)

2015-01-02 Thread Steve Dower
Changes by Steve Dower steve.do...@microsoft.com: Removed file: http://bugs.python.org/file37578/win32_ver.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19143 ___

[issue12681] unittest expectedFailure could take a message argument like skip does

2015-01-02 Thread Robert Collins
Changes by Robert Collins robe...@robertcollins.net: -- nosy: +rbcollins ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12681 ___ ___

[issue22231] httplib: unicode url will cause an ascii codec error when combined with a utf-8 string header

2015-01-02 Thread Demian Brecht
Demian Brecht added the comment: A few notes: 1. Unicode hosts are not automatically IDNA-encoded (which they /could/ be rather than relying on the programmer to be aware of this), but this really has no bearing on this specific issue 2. Unicode paths are not automatically IRI-encoded (see

[issue23153] Clarify Boolean Clause Results

2015-01-02 Thread Josh Rosenberg
Josh Rosenberg added the comment: A few questions/comments: 1. How would the reference clarify matters? 2. Most languages is perhaps overstating the matter. Lower level languages and strictly typed languages tend to return a boolean value, but many high level scripting languages (among them

[issue23153] Clarify Boolean Clause Results

2015-01-02 Thread John Potelle
New submission from John Potelle: From v3.4 Tutorial section 5.7 It is possible to assign the result of a comparison or other Boolean expression to a variable. For example, string1, string2, string3 = '', 'Trondheim', 'Hammer Dance' string1 or string2 or string3 'Trondheim' bool(string1 or

[issue4431] Distutils MSVC doesn't create manifest file

2015-01-02 Thread Steve Dower
Steve Dower added the comment: Sorry, I was focused on the fact that you don't need a manifest with VS 2010 and not that distutils was forcing you to have one when building an executable. Either adding '/MANIFEST' as in paxan's patch (according to

[issue23152] fstat64 required on Windows

2015-01-02 Thread Josh Rosenberg
Josh Rosenberg added the comment: I believe explicitly calling the 64 bit version of a function is usually frowned upon. At least on *NIX systems, the standard solution is to define -D_FILE_OFFSET_BITS=64 during the build process, so off_t seamlessly becomes a 64 bit value, and the 64 bit

[issue4431] Distutils MSVC doesn't create manifest file

2015-01-02 Thread Matthew Brett
Matthew Brett added the comment: Steve - did you try my 'setup.py' example; it's standalone, as in `python setup.py build` will reproduce the error. This is specifically VS 2010. It doesn't make any difference for me if I specify an extension or not, so I don't think that is the problem.

[issue23152] fstat64 required on Windows

2015-01-02 Thread Antoine Pitrou
Antoine Pitrou added the comment: Josh is right, we would only need to use fstat64() under Windows here. fstat() under POSIX defines st_size as a off_t, which should usually be large enough even on modern 32-bit systems. -- ___ Python tracker

[issue23152] fstat64 required on Windows

2015-01-02 Thread Josh Rosenberg
Josh Rosenberg added the comment: Ugh. Looking into it further, POSIX systems tend to support _FILE_OFFSET_BITS=64, but Windows isn't POSIX-y enough. So Windows might need to be special cased regardless. Blech. -- ___ Python tracker

[issue23127] socket.setsockopt() is still broken for multicast TTL and Loop options

2015-01-02 Thread Benjamin Peterson
Benjamin Peterson added the comment: Application code should pass the correct length of value. -- resolution: - wont fix status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23127

[issue23137] Python 2.7.9 test_gdb fails on CentOS 7

2015-01-02 Thread Vinson Lee
New submission from Vinson Lee: Python 2.7.9 test_gdb fails on CentOS 7. $./python Lib/test/regrtest.py -v test_gdb == CPython 2.7.9 (default, Dec 22 2014, 10:54:52) [GCC 4.8.2 20140120 (Red Hat 4.8.2-16)] == Linux-3.10.0-123.13.2.el7.x86_64-x86_64-with-centos-7.0.1406-Core little-endian ==