[issue22812] Documentation of unittest -p usage wrong on windows.

2015-04-15 Thread Pam McA'Nulty
Pam McA'Nulty added the comment: Here's a version of the docs with double quotes -- Added file: http://bugs.python.org/file39033/cpython-22812-discovery-double-quotes-v3.patch ___ Python tracker rep...@bugs.python.org

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

2015-04-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Proposed patch converts _dbm and _gdbm modules to Argument Clinic. -- nosy: +serhiy.storchaka Added file: http://bugs.python.org/file39032/dbm_clinic.patch ___ Python tracker rep...@bugs.python.org

[issue17445] Handle bytes comparisons in difflib.Differ

2015-04-15 Thread Greg Ward
Greg Ward added the comment: OK I've revived my patch and rebased on latest trunk. http://hg.gerg.ca/cpython/rev/13161c1d9c5f Comments welcome. I'll push this in a couple of days if nobody objects. -- ___ Python tracker rep...@bugs.python.org

[issue23964] Update README documentation for IDLE tests.

2015-04-15 Thread Al Sweigart
Changes by Al Sweigart asweig...@gmail.com: -- type: - enhancement ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23964 ___ ___ Python-bugs-list

[issue23964] Update README documentation for IDLE tests.

2015-04-15 Thread Al Sweigart
New submission from Al Sweigart: It took me a while to read through the idle_test documentation to figure out how to run the test. Similar to the Profiler documentation, I've added Instant User's Manual section at the top of the file, as well as edited the text and formatting a bit.

[issue23898] inspect() changes in Python3.4 are not compatible with objects that implement special __bool__, __eq__

2015-04-15 Thread mike bayer
mike bayer added the comment: my star went through. let's merge. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23898 ___ ___ Python-bugs-list

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

2015-04-15 Thread Michael McFadden
Michael McFadden added the comment: Yes, I did miss that. (Root cause: `git diff` instead of `git diff --staging`) Sorry. I'm learning, and decided to take the git path - might not have been the best choice. I'll submit a new patch shortly. --

[issue2931] optparse: various problems with unicode and gettext

2015-04-15 Thread Greg Ward
Greg Ward added the comment: I've turned ash's test program into a bunch of test cases against Python 3.5 trunk. Is it worth committing them? Yeah, probably. Review comments... +try: +self.parser.error(RUSSIAN_TEXT) +except InterceptedError: +pass

[issue23963] Windows build error using original openssl source

2015-04-15 Thread Anselm Kruis
New submission from Anselm Kruis: I just had an issue rebuilding 2.7.9 with openssl-1.0.1m. Because this openssl version is not yet available from svn.python.org, I used the original source from https://www.openssl.org/source/openssl-1.0.1m.tar.gz. Of course Perl is installed. Problem The

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

2015-04-15 Thread Michael McFadden
Michael McFadden added the comment: I'm thinking also, maybe instead of putting script_helper into the test.support namespace, we could move the individual methods and helpers from script_helper into test.support, e.g.: test.support.run_python_until_end vs.

[issue23965] test_ssl failure on Fedora 22

2015-04-15 Thread Christian Heimes
Christian Heimes added the comment: I suspect that the FIPS version of OpenSSL can't create a SSLv3 server anymore. -- nosy: +alex, dstufft, giampaolo.rodola, janssen, pitrou ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23965

[issue22848] Subparser help does not respect SUPPRESS argument

2015-04-15 Thread Matt Long
Matt Long added the comment: I prefer the idea of help=SUPPRESSED resulting in a hidden subcommand. That is, one that does not show up at all in the usage/help output: import argparse parser = argparse.ArgumentParser(prog='myapp') parser.add_argument('--foo', action=CustomAction)

[issue13866] {urllib, urllib.parse}.urlencode should not use quote_plus

2015-04-15 Thread Arnon Yaari
Changes by Arnon Yaari wiggi...@gmail.com: Removed file: http://bugs.python.org/file39006/issue13866.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13866 ___

[issue23949] Number of elements display in error message is wrong while unpacking in traceback

2015-04-15 Thread Arnon Yaari
Changes by Arnon Yaari wiggi...@gmail.com: Removed file: http://bugs.python.org/file39011/issue23949.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23949 ___

[issue4254] _cursesmodule.c callable update_lines_cols()

2015-04-15 Thread R. David Murray
R. David Murray added the comment: Thanks for updating. In the doc change you say it updates environment variables, but in the whatsnew change you say it changes constants of the curses module. I believe the whats new version is correct? Also, doc lines should be wrapped to 80 columns.

[issue23949] Number of elements display in error message is wrong while unpacking in traceback

2015-04-15 Thread Skip Montanaro
Skip Montanaro added the comment: I like the idea of the too many and not enough messages being symmetric. If it's not too hard, I would prefer them to both identify the number of expected and received values. I don't have a recent checkout at hand though, so it's non-trivial for me to

[issue17445] Handle bytes comparisons in difflib.Differ

2015-04-15 Thread Berker Peksag
Berker Peksag added the comment: Some small comments: * diff_bytes needs to be documented in the difflib docs and in Doc/whatsnew/3.5.rst. * diff_bytes needs to be added to difflib.__all__ * This looks like a new feature to me, so it would be better to just commit it to the default branch.

[issue20172] Derby #3: Convert 67 sites to Argument Clinic across 4 files (Windows)

2015-04-15 Thread Steve Dower
Steve Dower added the comment: Reviewed v8 and it looks good to me. Not a clinic expert, but I assume that it'll fail at build if anything is really wrong. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20172

[issue23193] Please support numeric_owner in tarfile

2015-04-15 Thread Roundup Robot
Roundup Robot added the comment: New changeset 6b70f16d585a by Eric V. Smith in branch 'default': Issue 23193: Add numeric_owner to tarfile.TarFile.extract() and tarfile.TarFile.extractall(). https://hg.python.org/cpython/rev/6b70f16d585a -- nosy: +python-dev

[issue21642] _ if 1else _ does not compile

2015-04-15 Thread Steve Dower
Steve Dower added the comment: FTR, I think this was a bad fix and we should have just changed the spec to require a space between numeric literals and identifiers. Closing as by design would have been fine in my opinion as well, since the spec says spaces are required when it's ambiguous,

[issue13866] {urllib, urllib.parse}.urlencode should not use quote_plus

2015-04-15 Thread Arnon Yaari
Arnon Yaari added the comment: Fixed Martin's comments. -- Added file: http://bugs.python.org/file39036/issue13866.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13866 ___

[issue23193] Please support numeric_owner in tarfile

2015-04-15 Thread Eric V. Smith
Eric V. Smith added the comment: Thanks everyone for their help, especially Michael for the original patch. -- resolution: - fixed stage: patch review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org

[issue23965] test_ssl failure on Fedora 22

2015-04-15 Thread Kushal Das
New submission from Kushal Das: OpenSSL version openssl-1.0.1k-6.fc22.x86_64 ssl.OPENSSL_VERSION 'OpenSSL 1.0.1k-fips 8 Jan 2015' == ERROR: test_protocol_sslv23 (test.test_ssl.ThreadedTests) Connecting to an SSLv23 server

[issue4254] _cursesmodule.c callable update_lines_cols()

2015-04-15 Thread Arnon Yaari
Arnon Yaari added the comment: Fixed David's comments -- versions: +Python 3.5 -Python 3.2 Added file: http://bugs.python.org/file39037/issue4254.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4254

[issue4254] _cursesmodule.c callable update_lines_cols()

2015-04-15 Thread Arnon Yaari
Changes by Arnon Yaari wiggi...@gmail.com: Removed file: http://bugs.python.org/file38973/patch_4254.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4254 ___

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

2015-04-15 Thread Michael McFadden
Michael McFadden added the comment: Uploading new patch that includes the creation of Lib/test/support/script_helper.py -- Added file: http://bugs.python.org/file39038/iss9517_move_script_helpers_py.patch ___ Python tracker rep...@bugs.python.org

[issue2292] Missing *-unpacking generalizations

2015-04-15 Thread Steve Dower
Steve Dower added the comment: I have limited expertise in most of these areas, but I looked at starunpack40.diff and have these comments: * tests look to have good coverage of the feature (can't speak to coverage of the parser/compiler code) * parsermodule.c changes comprehension handling,

[issue23937] IDLE start maximized

2015-04-15 Thread Al Sweigart
Al Sweigart added the comment: It is egregious for apps to assume that they are the only thing running I would agree for most apps, but I tend to think of IDEs as something that is generally run full screen. I'll note that Eclipse starts maximized, while PyCharm starts windowed. Though both

[issue23949] Number of elements display in error message is wrong while unpacking in traceback

2015-04-15 Thread Arnon Yaari
Arnon Yaari added the comment: I couldn't find a way to add 'got %d' to the 'too many values' message. This would either require going over the rest of the iterator (which will take more time and may never return) or trying to figure out if it has a 'len' member. I didn't find any place in

[issue23948] Deprecate os.kill() on Windows

2015-04-15 Thread John Ehresman
John Ehresman added the comment: Part of the issue here is that GenerateConsoleCtrlEvent doesn't work like kill w/ SIGINT does on unix -- it only works if the the target process id is 0 and then it generates the signal in all processes that share the console. An alternate proposal here is to

[issue23949] Number of elements display in error message is wrong while unpacking in traceback

2015-04-15 Thread Arnon Yaari
Changes by Arnon Yaari wiggi...@gmail.com: Added file: http://bugs.python.org/file39042/issue23949-2.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23949 ___

[issue20172] Derby #3: Convert 67 sites to Argument Clinic across 4 files (Windows)

2015-04-15 Thread Larry Hastings
Larry Hastings added the comment: If * the diff looks clean * it compiles without any *new* (sigh) errors, and * it passes the unit test suite without any *new* (sigh) failures, then the Clinic conversion can generally be considered a success. --

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

2015-04-15 Thread R. David Murray
R. David Murray added the comment: I actually originally wanted to do just that (move the script helpers routine into the old support.py) but I was in the minority. test.support was turned into a package exactly so that script_helpers could become a sub-namespace. As I remember, it was Nick

[issue19907] gettext - Non ascii chars in header

2015-04-15 Thread Michael McFadden
Michael McFadden added the comment: This might be fixed by issue17156, which would explain why I can't recreate it. https://github.com/python/cpython/commit/f4273cfd16fa502f0eb8a0a8fd1c537ec63e47db -- ___ Python tracker rep...@bugs.python.org

[issue22848] Subparser help does not respect SUPPRESS argument

2015-04-15 Thread Matt Long
Matt Long added the comment: Here's a patch for the proposal in my previous comment. As Barry mentioned, it wasn't as straightforward as I had hoped due to parts of the usage text being generated by the state of both self._name_parser_map and self._choices_actions. -- Added file:

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

2015-04-15 Thread Christie
Christie added the comment: I would recommend still moving script_helper into test.support , and adding a list of symbols from script_helper.py into __init__ Sounds like a great plan to me @flipmcf! -- ___ Python tracker rep...@bugs.python.org

[issue22848] Subparser help does not respect SUPPRESS argument

2015-04-15 Thread R. David Murray
R. David Murray added the comment: This patch looks good to me, but I did not go through the argparse logic fully. Paul, can you review this and make sure itliteral_eval makes sense? There is a small concern about user code that provides a Mapping for choices having an attribute collision

[issue19907] gettext - Non ascii chars in header

2015-04-15 Thread Michael McFadden
Michael McFadden added the comment: issue18128 is not related methinks. This ticket: POT-Creation-Date issue18128: PO-Revision-Date -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19907

[issue23949] Number of elements display in error message is wrong while unpacking in traceback

2015-04-15 Thread Arnon Yaari
Arnon Yaari added the comment: I fixed the tests (that's important!) and changed the latter message to specify it is referring to the starred target (the term starred target appears in the docs in simple_stmts.rst). Looks like the number in that message was wrong before! The test looked like

[issue13940] imaplib: Mailbox names are not quoted

2015-04-15 Thread Maciej Szulik
Maciej Szulik added the comment: Joe is correct, according to the spec the names containing special chars (atom-specials) require names to be quoted (https://tools.ietf.org/html/rfc3501#section-5.1): 1)Any character which is one of the atom-specials (see the Formal Syntax)

[issue4254] _cursesmodule.c callable update_lines_cols()

2015-04-15 Thread Arnon Yaari
Arnon Yaari added the comment: I'm adding patch without the update to Misc/NEWS. I'm not sure why, but the curses doc refers to LINES and COLS as environment variables. In the doc change I referred to them as just variables and used the notation that works for linking to them, using :envvar:

[issue17156] Tools/i18n/pygettext.py doesn't parse unicode string.

2015-04-15 Thread Michael McFadden
Michael McFadden added the comment: Also fixes 19907? -- nosy: +flipmcf ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17156 ___ ___

[issue23949] Number of elements display in error message is wrong while unpacking in traceback

2015-04-15 Thread Arnon Yaari
Changes by Arnon Yaari wiggi...@gmail.com: Added file: http://bugs.python.org/file39043/issue23949-3.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23949 ___

[issue21642] _ if 1else _ does not compile

2015-04-15 Thread R. David Murray
R. David Murray added the comment: My impression is that it was fixed the way it was because it makes the internal tokenizer match the what the tokenize module does. See also issue 3353. As for changing it in a point release, it turns something that was an error into something that isn't,

[issue22980] C extension naming doesn't take bitness into account

2015-04-15 Thread Nick Coghlan
Nick Coghlan added the comment: Matthias's latest patch looks good to me - I'm filing a separate issue about the fact that the native and cross-platform build info isn't really exposed properly at the Python level, and is confusing in various ways. --

[issue23966] More clearly expose/explain native and cross-build target information

2015-04-15 Thread Nick Coghlan
New submission from Nick Coghlan: Discussion of issue 22980 made it clear to me that part of the problem with the cross-build support is that the difference between the build time information exposed in sysconfig and the live system information exposed in the platform module isn't clear.

[issue23948] Deprecate os.kill() on Windows

2015-04-15 Thread John Ehresman
John Ehresman added the comment: GenerateConsoleCtrlEvent has different limitations for CTRL_BREAK_EVENT and CTRL_C_EVENT according to MSDN; I was referring to the CTRL_C_EVENT limitations. Which python level signal handler will CTRL_BREAK_EVENT trigger? --

[issue23948] Deprecate os.kill() on Windows

2015-04-15 Thread eryksun
eryksun added the comment: it only works if the the target process id is 0 and then it generates the signal in all processes that share the console. You can target a process group, which is a subset of the console's attached processes. That's why the console host, conhost.exe, routes

[issue23949] Number of elements display in error message is wrong while unpacking in traceback

2015-04-15 Thread Arnon Yaari
Arnon Yaari added the comment: Sorry, I got confused (which proves the point of the ticket :)) * the need more than 3 values error message wasn't wrong, just confusing. * Including into starred target in the message was incorrect, I removed it. * The message with expected at least ... (when

[issue7159] Urllib2 authentication memory.

2015-04-15 Thread Akshit Khurana
Akshit Khurana added the comment: Adding a patch for Python 3+ Some notes: * Adding a new password manager to handle this case * The new handler added in issue 19494 had couple of issues * test passes even if we use the old handler in added test * uses `request.host` instead of

[issue22980] C extension naming doesn't take bitness into account

2015-04-15 Thread Roundup Robot
Roundup Robot added the comment: New changeset 11c4f3f936e7 by doko in branch 'default': - Issue #22980: Under Linux, GNU/KFreeBSD and the Hurd, C extensions now include https://hg.python.org/cpython/rev/11c4f3f936e7 -- ___ Python tracker

[issue23967] Make inspect.signature expression evaluation more powerful

2015-04-15 Thread Larry Hastings
New submission from Larry Hastings: Peter's working on converting socket to use Argument Clinic. He had a default that really should look like this: min(SOME_SOCKET_MODULE_CONSTANT, 128) min wasn't something we'd needed before. I thought about it and realized we could do a much better

[issue22980] C extension naming doesn't take bitness into account

2015-04-15 Thread Roundup Robot
Roundup Robot added the comment: New changeset df6c73f0e375 by doko in branch 'default': - #22980: fix typo in Lib/test/test_sysconfig.py triplet test https://hg.python.org/cpython/rev/df6c73f0e375 -- ___ Python tracker rep...@bugs.python.org

[issue16864] sqlite3.Cursor.lastrowid isn't populated when executing a SQL REPLACE statement

2015-04-15 Thread R. David Murray
R. David Murray added the comment: Made some review comments. There also needs to be a documentation change since the docs currently say it is set for insert only. There should be a .. versionchanged directive. This may be small enough not to pass the what's new threshold, but I'd rather

[issue22411] Embedding Python on Windows

2015-04-15 Thread Steve Dower
Steve Dower added the comment: The 3.5 installer contains the option to install the debug binaries, so that side is solved and I'm closing this as fixed. In the video at https://www.youtube.com/watch?v=D9RlT06a1EI I demonstrate how you can build a debug EXE against a release python34.dll

[issue23948] Deprecate os.kill() on Windows

2015-04-15 Thread eryksun
eryksun added the comment: Which python level signal handler will CTRL_BREAK_EVENT trigger? The CRT maps it to a non-standard signal, SIGBREAK (21). It's defined in the signal module. GenerateConsoleCtrlEvent has different limitations for CTRL_BREAK_EVENT and CTRL_C_EVENT according to

[issue1284316] Win32: Security problem with default installation directory

2015-04-15 Thread Steve Dower
Steve Dower added the comment: Closing this as fixed, as the discussions I've had at PyCon have largely suggested that the fix I've implemented is good. In short: * the default (obvious) install will be per-user only into %LocalAppData%\Programs\Python\Python35 - fully modifiable by whoever

[issue23948] Deprecate os.kill() on Windows

2015-04-15 Thread John Ehresman
John Ehresman added the comment: Interesting -- I didn't know about removing the ignore flag in the child process. The question is whether this is close enough to the kill w/ SIGINT behavior on unix to use the same name. I think that there are enough differences to warrant a Windows

[issue22980] C extension naming doesn't take bitness into account

2015-04-15 Thread Matthias Klose
Matthias Klose added the comment: now fixed on the trunk. opened a new issue #23969 for setting the SOABI on MacOSX. -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22980

[issue18128] pygettext: non-standard timestamp format in POT-Creation-Date

2015-04-15 Thread Michael McFadden
Michael McFadden added the comment: Post-review - new patch -- Added file: http://bugs.python.org/file39050/issue18128.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18128 ___

[issue18162] Add index attribute to IndexError

2015-04-15 Thread Ofer Schwarz
Ofer Schwarz added the comment: I'm working on this now (patch hopefully coming soon), and I've hit an interesting issue: PySequence methods take care of negative indexes by adding +len before calling the subclass method (s.t. -1 becomes len-1 etc.). This means that if the subclass raises an

[issue15625] Support u and w codes in memoryview

2015-04-15 Thread Steve Dower
Steve Dower added the comment: Closing sounds good to me -- nosy: +steve.dower resolution: - out of date status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15625 ___

[issue23217] help() function incorrectly captures comment preceding a nested function

2015-04-15 Thread Raúl Cumplido
Raúl Cumplido added the comment: I am not sure what the expected behavior is. Based on the code on pydoc.py we can find: def getdoc(object): Get the doc string or comments for an object. result = inspect.getdoc(object) or inspect.getcomments(object) So if the doc string is not found it

[issue19933] Round default argument for ndigits

2015-04-15 Thread Roundup Robot
Roundup Robot added the comment: New changeset e3cc75b1000b by Steve Dower in branch 'default': Issue 19933: Provide default argument for ndigits in round. Patch by Vajrasky Kok. https://hg.python.org/cpython/rev/e3cc75b1000b -- nosy: +python-dev

[issue19933] Round default argument for ndigits

2015-04-15 Thread Steve Dower
Changes by Steve Dower steve.do...@microsoft.com: -- resolution: - fixed status: open - closed versions: +Python 3.5 -Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19933 ___

[issue18162] Add index attribute to IndexError

2015-04-15 Thread Ram Rachum
Ram Rachum added the comment: Looking forward to your patch Ofer! Thanks for working on this! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18162 ___

[issue23496] Steps for Android Native Build of Python 3.4.2

2015-04-15 Thread Ryan Gonzalez
Ryan Gonzalez added the comment: Can you try to see exactly *which* line of the function is segfaulting? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23496 ___

[issue4254] _cursesmodule.c callable update_lines_cols()

2015-04-15 Thread Arnon Yaari
Arnon Yaari added the comment: Adding a test that only calls the function. -- Added file: http://bugs.python.org/file39048/issue4254-2.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4254

[issue23968] rename the platform directory from plat-$(MACHDEP) to plat-$(PLATFORM_TRIPLET)

2015-04-15 Thread Matthias Klose
New submission from Matthias Klose: Currently there is only one platform directory for all linux architectures, there are two reasons to have a separate directory for each architecture: - the contents of the files in this directory differ (most prominent case are the RTLD_* constants on

[issue23883] __all__ lists are incomplete

2015-04-15 Thread Joel Taddei
Joel Taddei added the comment: I took care of the tarfile module. Added the following according to the first message: tarfile.CompressionError tarfile.HeaderError tarfile.ReadError tarfile.open The following were included in __all__ that were not explicitly mentioned in the first message

[issue5438] test_bigmem.test_from_2G_generator uses more memory than expected

2015-04-15 Thread Joe Jevnik
Joe Jevnik added the comment: I can look into rewriting the framework to use multiprocessing; however, should we split this into a separate issue or block this one until that work is done. -- ___ Python tracker rep...@bugs.python.org

[issue15625] Support u and w codes in memoryview

2015-04-15 Thread Arnon Yaari
Arnon Yaari added the comment: The documentation already specifies that 'u' is deprecated and doesn't mention the 'w' code. I think we can close this issue. -- nosy: +wiggin15 ___ Python tracker rep...@bugs.python.org

[issue23969] please set a SOABI for MacOSX

2015-04-15 Thread Matthias Klose
New submission from Matthias Klose: split out from http://bugs.python.org/issue22980#msg232065 please consider setting the SOABI for MacOSX. Afaics MacOSX is now the only major platform not setting these, at least including the SOABI. The idea is that it would be possible to ship fat wheels,

[issue23969] please set a SOABI for MacOSX

2015-04-15 Thread Ned Deily
Changes by Ned Deily n...@acm.org: -- assignee: - ned.deily components: +Build, Macintosh stage: - needs patch versions: +Python 3.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23969 ___

[issue7159] Urllib2 authentication memory.

2015-04-15 Thread R. David Murray
R. David Murray added the comment: Added some review comments. I think the urllib documentation does not really explain how to *use* these classes, and it should, but that is a separate issue. -- ___ Python tracker rep...@bugs.python.org

[issue22278] urljoin duplicate slashes

2015-04-15 Thread Berker Peksag
Changes by Berker Peksag berker.pek...@gmail.com: -- stage: patch review - resolved ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22278 ___ ___

[issue23971] dict(list) and dict.fromkeys() doesn't account for 2/3 fill ratio

2015-04-15 Thread Serhiy Storchaka
Changes by Serhiy Storchaka storch...@gmail.com: -- nosy: +rhettinger type: behavior - performance ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23971 ___

[issue23971] dict(list) and dict.fromkeys() doesn't account for 2/3 fill ratio

2015-04-15 Thread Larry Hastings
New submission from Larry Hastings: Matt Mackall brought this over to me today. If list l has one million pairs and you do dict(l) it creates the dict, then resizes it to a million elements, then starts adding name/value pairs. But since it's sized to a million elements, it gets beyond its

[issue22980] C extension naming doesn't take bitness into account

2015-04-15 Thread Roundup Robot
Roundup Robot added the comment: New changeset 948745d0d9cf by doko in branch 'default': #22980: fix triplet configure test for powerpc-linux-gnu https://hg.python.org/cpython/rev/948745d0d9cf -- ___ Python tracker rep...@bugs.python.org

[issue22137] Test imaplib API on all methods specified in RFC 3501

2015-04-15 Thread Maciej Szulik
Maciej Szulik added the comment: Milan one more thing to change in your patch, in all your TCs you're modifying client state, I mean this part: # lets cheat a bit here: client.state = 'SELECTED' It's OK to do that on the mocked server, but this is not acceptable doing on the tested library.

[issue4254] _cursesmodule.c callable update_lines_cols()

2015-04-15 Thread Steve Dower
Steve Dower added the comment: Arnon has signed the CLA at PyCon, it just hasn't been processed yet. -- stage: patch review - commit review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4254

[issue4254] _cursesmodule.c callable update_lines_cols()

2015-04-15 Thread Roundup Robot
Roundup Robot added the comment: New changeset 132b5376bf34 by Steve Dower in branch 'default': Issue #4254: Adds _curses.update_lines_cols() Patch by Arnon Yaari https://hg.python.org/cpython/rev/132b5376bf34 -- nosy: +python-dev ___ Python tracker

[issue2292] Missing *-unpacking generalizations

2015-04-15 Thread Neil Girdhar
Changes by Neil Girdhar mistersh...@gmail.com: Added file: http://bugs.python.org/file39059/starunpack41.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2292 ___

[issue23883] __all__ lists are incomplete

2015-04-15 Thread Martin Panter
Martin Panter added the comment: Regarding tarfile: Two of the extra errors are documented, so I agree they should be added: * tarfile.StreamError * tarfile.ExtractError However I’m not so sure about main(), TarIter, and the HeaderError subclasses. They aren’t mentioned in the documentation.

[issue23703] urljoin() with no directory segments duplicates filename

2015-04-15 Thread Roundup Robot
Roundup Robot added the comment: New changeset fc0e79387a3a by Berker Peksag in branch 'default': Issue #23703: Fix a regression in urljoin() introduced in 901e4e52b20a. https://hg.python.org/cpython/rev/fc0e79387a3a -- nosy: +python-dev ___ Python

[issue18162] Add index attribute to IndexError

2015-04-15 Thread Ofer Schwarz
Changes by Ofer Schwarz os.uran...@gmail.com: -- keywords: +patch Added file: http://bugs.python.org/file39055/indexerror.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18162 ___

[issue18162] Add index attribute to IndexError

2015-04-15 Thread Ofer Schwarz
Changes by Ofer Schwarz os.uran...@gmail.com: Added file: http://bugs.python.org/file39056/indexerror.tests ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18162 ___

[issue17445] Handle bytes comparisons in difflib.Differ

2015-04-15 Thread Terry J. Reedy
Terry J. Reedy added the comment: Now the review button appears for the big patch. Lets see if another submission makes it appear for the smaller version. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17445

[issue17445] Handle bytes comparisons in difflib.Differ

2015-04-15 Thread Augie Fackler
Augie Fackler added the comment: Changes to 3.4 aren't going to help Mercurial. Given that bytes formatting is new in 3.5, I won't be attempting a port that supports a version of Python 3 any older than 3.5. At this point, just a difflib.diff_bytes method in 3.5 would be sufficient to satisfy

[issue23970] Update distutils.msvccompiler for VC14

2015-04-15 Thread Steve Dower
New submission from Steve Dower: Because of the compiler change, we need to rework the detection of MSVC for Python 3.5. I took the opportunity to clean up the entire module and remove msvc9compiler, and updated the tests. -- assignee: steve.dower components: Windows files:

[issue17445] Handle bytes comparisons in difflib.Differ

2015-04-15 Thread Terry J. Reedy
Terry J. Reedy added the comment: I tried the [Create Patch] button. Two problems: the result is about 90% concerned with other issues; it is not reviewable on Rietveld. I will unlink it and upload a cut-down version. Wtiht the test changes suggested by Berker, I agree that it is time to

[issue23703] urljoin() with no directory segments duplicates filename

2015-04-15 Thread Berker Peksag
Berker Peksag added the comment: Thanks! -- resolution: - fixed stage: patch review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23703 ___

[issue18128] pygettext: non-standard timestamp format in POT-Creation-Date

2015-04-15 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: @rdm: I'm pretty sure you're right about nobody noticing. :) Make it so! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18128 ___

[issue17445] Handle bytes comparisons in difflib.Differ

2015-04-15 Thread Terry J. Reedy
Changes by Terry J. Reedy tjre...@udel.edu: Added file: http://bugs.python.org/file39053/13161c1d9c5f.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17445 ___

[issue22189] collections.UserString missing some str methods

2015-04-15 Thread Joe Jevnik
Joe Jevnik added the comment: I have added a patch to add these to UserString. I also wrote a test case that would check the UserString, UserList, and UserDict's methods to make sure that new methods to str, list, or dict (or the removal of one of those methods from the User* version) will

[issue18162] Add index attribute to IndexError

2015-04-15 Thread Ofer Schwarz
Changes by Ofer Schwarz os.uran...@gmail.com: Added file: http://bugs.python.org/file39060/indexerror_all.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18162 ___

[issue7159] Urllib2 authentication memory.

2015-04-15 Thread Akshit Khurana
Akshit Khurana added the comment: Updated patch with review changes -- Added file: http://bugs.python.org/file39062/auth10.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7159 ___

[issue6818] remove/delete method for zipfile/tarfile objects

2015-04-15 Thread Dave Sawyer
Dave Sawyer added the comment: The zipfile way to delete or rename would be to just change the index. It really doesn't want to be re-written as it is designed to span disks. Many old versions of files can be scattered within the zip. In addition self-extracting zip files will have executable

[issue23969] please set a SOABI for MacOSX

2015-04-15 Thread Ned Deily
Ned Deily added the comment: what about iOS? isn't __APPLE__ there defined too? It is but we currently don't have any iOS-specific checks snywhere in CPython. I have an additional patch to handle iOS here but I didn't want to break builds until adding full support for iOS as part of

[issue23670] Modifications to support iOS as a cross-compilation target

2015-04-15 Thread Matthias Klose
Matthias Klose added the comment: not reviewing everything, but - libffi_ios* will be bitrot. I understand that you'll need an unreleased version, however I would much prefer that any additional patches are added in the repo, and maybe then patching libffi from the iOS build

  1   2   >