Gregory P. Smith added the comment:
code review comments addressed.
--
Added file: http://bugs.python.org/file39464/issue24230-gps02.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24230
Ned Deily added the comment:
Ronald, the change to set the SOABI was pushed several weeks ago (but, because
I left out a #, the commit message did not also show up here as I intended):
New changeset 32c24eec035f by Ned Deily in branch 'default':
Issues #22980, 23969: For OS X, use PEP
Roundup Robot added the comment:
New changeset 490720fc1525 by Raymond Hettinger in branch 'default':
Issue #24221: Small optimizations for heapq.
https://hg.python.org/cpython/rev/490720fc1525
--
nosy: +python-dev
___
Python tracker
Changes by Raymond Hettinger raymond.hettin...@gmail.com:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24221
___
Gleb Dubovik added the comment:
We used a very old version of python shipped with 12.04 LTS. The bug was fixed
in 2.7.3 in 2ab3a97d544c by Vinay.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
Nick Coghlan added the comment:
The patch mostly looks good to me, but I suggest using
test.support.check_warnings for the cases where you're checking that the
warning is raised as expected:
https://docs.python.org/3/library/test.html#test.support.check_warnings
It's slightly simpler than
Changes by Ned Deily n...@acm.org:
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24264
___
___
Python-bugs-list mailing
Martin Panter added the comment:
Looks good in general. I think the signatures in Doc/library/tempfile.rst need
updating for the following functions (possibly also version changed notices
added somewhere):
* NamedTemporaryFile
* TemporaryFile
* SpooledTemporaryFile
* TemporaryDirectory
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24257
___
eryksun added the comment:
My reluctance to commit the os.access patch is because it will
cause such a behaviour change in a function which has been
pretty stable for a long while.
The original behavior could be preserved as the default. A keyword-only
argument could enable checking
Stefan Behnel added the comment:
There are calls to PyObject_RichCompareBool() in the loops, which means that
user code might get executed. What if that's evil code that modifies the heap
list? Couldn't that lead to list resizing and thus invalidation of the list
item pointer?
--
Roundup Robot added the comment:
New changeset bccaba8a5482 by Serhiy Storchaka in branch '2.7':
Issue #24257: Fixed segmentation fault in sqlite3.Row constructor with faked
https://hg.python.org/cpython/rev/bccaba8a5482
New changeset c7b9645a6f35 by Serhiy Storchaka in branch '3.4':
Issue
New submission from JohnLeitch:
Several functions within the imageop module are vulnerable to exploitable
buffer overflows due to unsafe arithmetic in check_multiply_size(). The problem
exists because the check to confirm that size == product / y / x does not take
remainders into account.
Tim Golden added the comment:
That is a possibility which hadn't occurred to me. @eryksun, would you
mind eyeballing the patch over on issue2582? It almost certainly won't
apply cleanly as it's been almost two years since I last refreshed it,
but you can hopefully gauge the intent.
--
eryksun added the comment:
Ok, I think I understand now. You chose an indirect check to avoid the race
condition. If we have write access to the directory, then the PermissionError
must be because a directory exists with the same name.
Unfortunately os.access doesn't currently tell us this
Changes by Ned Deily n...@acm.org:
--
components: -Unicode
nosy: +rbcollins
versions: +Python 3.5 -Python 3.2, Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24263
___
Serhiy Storchaka added the comment:
The list item pointer is updated just after calling PyObject_RichCompareBool().
The code LGTM.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24221
___
Changes by Ned Deily n...@acm.org:
--
nosy: +vinay.sajip
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24262
___
___
Python-bugs-list mailing list
Changes by sih4sing5hong5 ihc...@gmail.com:
--
components: Unicode
nosy: ezio.melotti, haypo, sih4sing5hong5
priority: normal
severity: normal
status: open
title: Why VALID_MODULE_NAME in unittest/loader.py is r'[_a-z]\w*\.py$' not
r'\w+\.py$' ?
type: behavior
versions: Python 3.2,
Dmitry Kazakov added the comment:
Please, do tell me if I'm wrong deleting that literal and it actually serves
some purpose...
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24219
___
Rolf Krahl added the comment:
I disagree. I believe that the suggested modification of
AbstractHTTPHandler.do_request_() belongs into this change set for the
following reasons:
1. This module [http.client] defines classes which implement the client side
of the HTTP and HTTPS protocols. It
Yury Selivanov added the comment:
I'm copying/pasting my latest commit message on this issue here:
Add a note about deprecating old inspect APIs to whatsnew.
Also, deprecate formatargspec, formatargvalues, and getargvalues
functions. Since we are deprecating 'getfullargspec' function in
3.5
Raymond Hettinger added the comment:
This patch looks reasonable.
--
nosy: +rhettinger
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24204
___
___
Raymond Hettinger added the comment:
It's mostly pedagogical - similar to normal functions
vs generator functions,
I see a need for this but object to calling it a generator rather than a
function that makes a generator or generator creating function or somesuch.
There is a huge semantic
Raymond Hettinger added the comment:
Sorry, I don't want to any of these changes (though it is a close call on a
couple of them).
Before the particulars, here are some high-level thoughts (not definitive). I
would like to confine the optimizations and complexities to the more important
Berker Peksag added the comment:
Just a minor comment on the patch:
+warnings.warn(inspect.getargspec() is deprecated,
+ use inspect.signature() instead, DeprecationWarning)
Can you also add stacklevel=2?
--
nosy: +berker.peksag
Roundup Robot added the comment:
New changeset 254b8e68959e by Steve Dower in branch 'default':
Issue 24244: Prevents termination when an invalid format string is encountered
on Windows.
https://hg.python.org/cpython/rev/254b8e68959e
--
nosy: +python-dev
Eric Snow added the comment:
Include/opcode.h shouldn't be in the change (and won't be when committed). I'm
guessing it being there is related to one of the recent merges I did from
default into the feature branch.
--
___
Python tracker
Steve Dower added the comment:
The support is in and the option remains named applocal.
Hopefully this (and the ZIP file version, which will include the preconfigured
pyvenv.cfg) will help with app distributions, though I'm still open to make
changes if it doesn't.
--
resolution: -
Roundup Robot added the comment:
New changeset 117af4bc0513 by Benjamin Peterson in branch '2.7':
make idlever.py self-updating (closes #24199)
https://hg.python.org/cpython/rev/117af4bc0513
--
resolution: - fixed
stage: needs patch - resolved
status: open - closed
Roundup Robot added the comment:
New changeset 666e5b554f32 by Yury Selivanov in branch 'default':
Issue 20438: Adjust stacklevel of inspect.getargspec() warning.
https://hg.python.org/cpython/rev/666e5b554f32
--
___
Python tracker
Roundup Robot added the comment:
New changeset 620a247b4960 by Steve Dower in branch 'default':
Issue #23955: Add pyvenv.cfg option to suppress registry/environment lookup for
generating sys.path.
https://hg.python.org/cpython/rev/620a247b4960
--
nosy: +python-dev
Steve Dower added the comment:
That handles Python 3.5 and future versions, even if the supported formats
change.
Is there something that needs fixing in 3.4? I don't get a crash, just the
ValueError...
--
___
Python tracker rep...@bugs.python.org
Changes by Raymond Hettinger raymond.hettin...@gmail.com:
--
assignee: docs@python - rhettinger
nosy: +rhettinger
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24219
___
Brian Quinlan added the comment:
Ethan: I'm -0 so I'd happily go with the consensus. Does anyone have a strong
opinion?
Ram: What did you mean by Possible issues? Did you mean that to be an example
using the executor.map() technique?
--
___
Python
Roundup Robot added the comment:
New changeset 830bcf4fb29b by Raymond Hettinger in branch 'default':
Issue #21448: Improve performance of the email feedparser
https://hg.python.org/cpython/rev/830bcf4fb29b
--
___
Python tracker
Matthias Klose added the comment:
so what you could do is to define more than one SOABI. The code in
Python/dynload_shlib.c reads:
. SOABI .so,
.abi PYTHON_ABI_STRING .so,
.so,
so it still recognizes .so names. If you want to recognize architecture
specific sonames, then you
Nick Coghlan added the comment:
I don't think we should rush this one, especially as PEP 484 provides the
possibility for tools (including educational tools) to infer the appropriate
return types for generator and coroutine functions.
Bumping the target version to 3.6 accordingly.
--
Martin Panter added the comment:
So far the only reasons that have been given to override this header (mine and
the one in Issue 15943) seem to be to work around buggy servers. It is already
documented that HTTP 1.1 and “Connection: close” are used, so if this issue is
only about working
Martin Panter added the comment:
Okay perhaps a new issue at this stage isn’t the best idea, especially if you
want both modules updated at the same time.
With the urlopen() API, it currently has no explicit support for file objects.
So you either have to make sure they get treated like any
Roundup Robot added the comment:
New changeset cabd7261ae80 by Raymond Hettinger in branch 'default':
Issue #23086: Add start and stop arguments to the Sequence.index() mixin method.
https://hg.python.org/cpython/rev/cabd7261ae80
--
nosy: +python-dev
Raymond Hettinger added the comment:
Devin, thanks for the patch.
Serhiy, I added a performance note discussing the computational complexity.
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker
Raymond Hettinger added the comment:
What is left to do with this issue?
Nothing that I can see.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15535
Roundup Robot added the comment:
New changeset 870899ce71f4 by Gregory P. Smith in branch 'default':
Issue 24230: The tempfile module now accepts bytes for prefix, suffix and dir
https://hg.python.org/cpython/rev/870899ce71f4
--
nosy: +python-dev
___
Roundup Robot added the comment:
New changeset c06b2480766d by Raymond Hettinger in branch 'default':
Issue 22189: Add missing methods to UserString
https://hg.python.org/cpython/rev/c06b2480766d
--
nosy: +python-dev
___
Python tracker
Raymond Hettinger added the comment:
Thanks Joe.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22189
___
Changes by Raymond Hettinger raymond.hettin...@gmail.com:
--
assignee: rhettinger -
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21448
___
Matthias Klose added the comment:
ping? I would like to get this into 3.5.
--
keywords: +needs review -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23968
___
Martin Panter added the comment:
The proposed patch looks good to me. A test case would be nice though.
Also I wonder why the “malformed URL” logic needs to be in urllib.request.
Surely it either belongs in urljoin(), or in the underlying http.client. That
needs more thought, but either way
Nick Coghlan added the comment:
I vary between +0 and -0 for the addition of the concrete method.
When I'm at +0, the main rationale is that we *don't* have the Where do we
stop? risk here that itertools faces, as we're just replicating the
synchronous builtins.
When I'm at -0, the main
Gregory P. Smith added the comment:
that should take care of it. if you see any other issues with this post
commit, either raise them here or fix them directly. the reviews were helpful.
--
resolution: - fixed
stage: patch review - commit review
status: open - closed
Eric Snow added the comment:
If I still the following at Lib/test/test_configparser.py:328:
print(len(cf._proxies), len(list(cf._proxies)), list(cf._proxies))
print(len(cf._sections), len(list(cf._sections)), list(cf._sections))
I get unexpected results that are a clear indication of a
Roundup Robot added the comment:
New changeset 645a03e93008 by Raymond Hettinger in branch '3.4':
Issue #24219: Remove duplicate literal in docs.
https://hg.python.org/cpython/rev/645a03e93008
--
nosy: +python-dev
___
Python tracker
Eric Snow added the comment:
Just to narrow things down a bit further, the failure happens specifically
under ConfigParserTestCaseNoValue:
PYTHONHASHSEED=7 ./python -m unittest
test.test_configparser.ConfigParserTestCaseNoValue.test_basic -v
--
Martin Panter added the comment:
Also applies to the interactive interpreter mode.
--
nosy: +vadmium
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24266
___
Augie Fackler added the comment:
I just removed my hack that gave us unicode to hand to mkdtemp() and everything
still passes with your new commit. Thanks much for the quick response!
--
___
Python tracker rep...@bugs.python.org
Raymond Hettinger added the comment:
Closing this because it was never an active proposal, just more of a thought
experiment that I didn't want to lose track of.
--
resolution: - not a bug
status: open - closed
___
Python tracker
Martin Panter added the comment:
I am no IPv6 expert, but this looks like a reasonable first approximation. The
“http.server” module documentation should also be updated to say IPv6 addresses
are supported on the command line, and I guess there should be a test case
added.
But maybe see
Changes by Raymond Hettinger raymond.hettin...@gmail.com:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24219
___
Martin Panter added the comment:
I’m no IPv6 expert, but see Lib/smtpd.py:657 and Issue 14758 for how this sort
of thing was done for the SMTP server using getaddrinfo(). I think it is
similar to David’s suggestion.
I also left a comment about the documentation. And it probably needs a test
Yury Selivanov added the comment:
Thanks Berker!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20438
___
___
Python-bugs-list mailing list
Roundup Robot added the comment:
New changeset 621e98bfc74b by Yury Selivanov in branch 'default':
Issue 20438: Add a note about deprecating old inspect APIs to whatsnew.
https://hg.python.org/cpython/rev/621e98bfc74b
--
___
Python tracker
Steve Dower added the comment:
We don't strictly need this for beta 1, but I'd like to get it in. Final call
for feedback (I'll probably hold off checking in until tomorrow morning, ~18
hours from now)
--
___
Python tracker rep...@bugs.python.org
New submission from ppperry:
When I run python -m idlelib.idle -sc [command] from the command line, IDLE
runs the startup file, but then pops up an error message saying the Python
Shell window is already executing a command;please wait until it is finished.
When the error window is closed,
Changes by ppperry maprea...@olum.org:
--
type: - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24265
___
___
Python-bugs-list mailing
Changes by R. David Murray rdmur...@bitdance.com:
--
resolution: fixed - out of date
stage: - resolved
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24262
___
R. David Murray added the comment:
I believe you are correct.
--
nosy: +r.david.murray
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24219
___
___
Stefan Behnel added the comment:
Ah, sorry, yes. I somehow misread the arguments being passed *into* richcompare
as subsequent array access. LGTM too. Sorry for the noise.
--
___
Python tracker rep...@bugs.python.org
Yury Selivanov added the comment:
Nick, I updated the code to use assertWarnsRegex (thanks for suggestion,
Berker!)
Closing the issue.
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker
Changes by Yury Selivanov yseliva...@gmail.com:
--
resolution: - fixed
stage: - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20438
___
Roundup Robot added the comment:
New changeset 2771a0ac806b by Yury Selivanov in branch 'default':
Issue 24237: Raise PendingDeprecationWarning per PEP 479
https://hg.python.org/cpython/rev/2771a0ac806b
--
___
Python tracker rep...@bugs.python.org
Berker Peksag added the comment:
Another alternative is using assertWarnsRegex.
--
nosy: +berker.peksag
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24237
___
Roundup Robot added the comment:
New changeset 2771a0ac806b by Yury Selivanov in branch 'default':
Issue 24237: Raise PendingDeprecationWarning per PEP 479
https://hg.python.org/cpython/rev/2771a0ac806b
--
nosy: +python-dev
___
Python tracker
Roundup Robot added the comment:
New changeset c8a3e49f35e7 by Yury Selivanov in branch 'default':
docs: Mention PEP 479 in whatsnew.
https://hg.python.org/cpython/rev/c8a3e49f35e7
--
___
Python tracker rep...@bugs.python.org
Changes by sping sebast...@pipping.org:
Added file: http://bugs.python.org/file39468/raw_input__minimal.py
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24266
___
New submission from sping:
Hi!
A college of mine ran into a bug with raw_input.
We have a shell derived from stdlib module cmd here but the bug shows
with plain raw_input, as well (see demo code).
For the symptoms: the shell is executing commands from history that the
user explicitly chose
Yury Selivanov added the comment:
Closing this issue.
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24180
___
Yury Selivanov added the comment:
Nick, Berker, a kind reminder -- please review the patch if we want to have it
in 3.5.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24056
___
Roundup Robot added the comment:
New changeset 3a5fec5e025d by Yury Selivanov in branch 'default':
Issue 20438: Deprecate inspect.getargspec() and friends.
https://hg.python.org/cpython/rev/3a5fec5e025d
--
nosy: +python-dev
___
Python tracker
Berker Peksag added the comment:
I'm not the ideal candidate to review the second patch since I'm not familiar
with the best practices of C :)
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24056
Petr Viktorin added the comment:
Just a reminder: if you want this to be in Python 3.5, please review the patch
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23699
___
Demian Brecht added the comment:
FWIW, I was intending to address the issues Rolf raised. Also, I agree that a
patch shouldn't knowingly have negative knock-on effects to dependents.
--
___
Python tracker rep...@bugs.python.org
Terry J. Reedy added the comment:
With 'leading end' and 'trailing end' replaced by 'left and 'right', the
addition looks good to me.
--
nosy: +terry.reedy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24204
Roundup Robot added the comment:
New changeset 951318b651be by Zachary Ware in branch 'default':
Issue #20035: Reimplement tkinter._fix module as a C function.
https://hg.python.org/cpython/rev/951318b651be
--
___
Python tracker
Zachary Ware added the comment:
Committed, thanks for the reviews, Serhiy and Steve!
--
assignee: - zach.ware
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
Changes by Demian Brecht demianbre...@gmail.com:
--
nosy: +demian.brecht
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24209
___
___
Terry J. Reedy added the comment:
3.2 and 3.3 only get security fixes. I condensed the title to be visible in
display boxes. It would help if you signed the PSF Contributor Agreement
https://www.python.org/psf/contrib/
https://www.python.org/psf/contrib/contrib-form/
and contributed a usable
Serhiy Storchaka added the comment:
I like the look of the repr Terry proposes better. For generator objects the
repr is either coroutine object %S at %p or generator object %S at %p.
coroutine function %S at %p and generator function %S at %p would be
consistent with this. It also shows the
Serhiy Storchaka added the comment:
This behavior annoyed me long time, but I had no idea how to fix this.
--
nosy: +pitrou, serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24266
Gregory P. Smith added the comment:
updated, thanks for the great reviews.
--
Added file: http://bugs.python.org/file39469/issue24230-gps03.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24230
Terry J. Reedy added the comment:
To my understanding, the presence of int.__int__ and float.__float__ are
implementation issues. I presume that float(ob) just calls ob.__float__
without slowing down for an isinstance(ob, float) check. Ditto for int(ob).
The processing for complex(args)
Jim Jewett added the comment:
Why does generated file Include/opcode.h show up as changed? It looks like
pure whitespace, but I wonder if a similar whitespace change might be making
something a space too long somewhere.
--
nosy: +Jim.Jewett
___
92 matches
Mail list logo
