[issue24724] Element.findall documentation misleading

2015-07-25 Thread Eric S
New submission from Eric S: Documentation states: Element.findall() finds only elements with a tag which are direct children of the current element. More accurate to say direct descendents as direct children implies only one generation below whereas function goes down to all g...children.

[issue24724] Element.findall documentation misleading

2015-07-25 Thread Raymond Hettinger
Changes by Raymond Hettinger raymond.hettin...@gmail.com: -- components: +Documentation nosy: +eli.bendersky, scoder ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24724 ___

[issue24724] Element.findall documentation misleading

2015-07-25 Thread Raymond Hettinger
Raymond Hettinger added the comment: The phrase occurs in https://docs.python.org/3/library/xml.etree.elementtree.html#finding-interesting-elements I think it should say, In this example, Element.findall() finds only elements with a tag which are direct children of the current element. Later

[issue24613] array.fromstring Use After Free

2015-07-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: The patch doesn't apply correctly. Looks as it is encoded with UTF-16. For future please provide a patch in the encoding of the source file (should be ASCII compatible, without BOM). -- ___ Python tracker

[issue24683] Type confusion in json encoding

2015-07-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: There is similar issue with key_separator and item_separator in 3.x. They are used with _PyAccu_Accumulate that performs a type check only in assert(). Here is a patch. -- keywords: +patch stage: needs patch - patch review versions: +Python 2.7,

[issue24683] Type confusion in json encoding

2015-07-25 Thread Raymond Hettinger
Raymond Hettinger added the comment: Patch LGTM. -- nosy: +rhettinger ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24683 ___ ___ Python-bugs-list

[issue24724] Element.findall documentation misleading

2015-07-25 Thread Raymond Hettinger
Changes by Raymond Hettinger raymond.hettin...@gmail.com: -- keywords: +patch Added file: http://bugs.python.org/file40026/etree_clarify.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24724

[issue24613] array.fromstring Use After Free

2015-07-25 Thread Roundup Robot
Roundup Robot added the comment: New changeset 2d39777f3477 by Serhiy Storchaka in branch '2.7': Issue #24613: Calling array.fromstring() with self is no longer allowed https://hg.python.org/cpython/rev/2d39777f3477 -- nosy: +python-dev ___ Python

[issue18378] locale.getdefaultlocale() fails on Mac OS X with default language set to English

2015-07-25 Thread Ronald Oussoren
Ronald Oussoren added the comment: ping... I think the current behavior is a bug in Python and should be fixed in 2.7, 3.4, 3.5 and default (using Dmitry's patch). I'd like to commit the patch, but would like someone else's review of the patch before doing so. --

[issue24713] Import docs reference the deprecated imp.reload

2015-07-25 Thread Petr Viktorin
New submission from Petr Viktorin: In 3.4, `imp.reload` was deprecated in favor of `importlib.reload`. https://docs.python.org/3/library/imp.html -- assignee: docs@python components: Documentation files: docs.patch keywords: patch messages: 247319 nosy: docs@python, encukou,

[issue18378] locale.getdefaultlocale() fails on Mac OS X with default language set to English

2015-07-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Needed tests. With the patch: $ LC_CTYPE=UTF-8 ./python import locale locale.getdefaultlocale() (None, 'UTF-8') locale.getpreferredencoding() 'ANSI_X3.4-1968' locale.getlocale() (None, None) $ LC_CTYPE=en_US_UTF-8 ./python import locale

[issue18181] PEP447: Add type.__getdescriptor__

2015-07-25 Thread Ronald Oussoren
Ronald Oussoren added the comment: I've attached a new version of the patch (pep447-2015-07-25.txt). Changes in this version of the patch: 1) Works with the current trunk (as in all tests pass) 2) Types in C must explicitly set Py_TPFLAGS_GETDESCRIPTOR in tp_flags to enable the

[issue14373] C implementation of functools.lru_cache

2015-07-25 Thread Roundup Robot
Roundup Robot added the comment: New changeset 5345e5ce2eed by Serhiy Storchaka in branch '3.5': Issue #14373: Fixed segmentation fault when gc.collect() is called during https://hg.python.org/cpython/rev/5345e5ce2eed New changeset 9c6d11d22801 by Serhiy Storchaka in branch 'default': Issue

[issue14373] C implementation of functools.lru_cache

2015-07-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you Ned. Is anything left to do with this issue or it can be closed? -- priority: release blocker - normal status: open - pending ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14373

[issue18378] locale.getdefaultlocale() fails on Mac OS X with default language set to English

2015-07-25 Thread Serhiy Storchaka
Changes by Serhiy Storchaka storch...@gmail.com: -- nosy: +serhiy.storchaka versions: +Python 3.5, Python 3.6 -Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18378 ___

[issue24712] Docs page's sidebar vibrates on mouse wheel scroll on Chrome.

2015-07-25 Thread Biwin John
Biwin John added the comment: The problem exist with the Chrome on Ubuntu, Windows and OSX, but ony with the python docs for version 2.7. Docs for 2.6 use the same sidebar. But in 2.7 docs, the content of sidebar is positioned with the style added on scroll, style=float: left; margin-right:

[issue24714] Crash with string_at(None)

2015-07-25 Thread Michael Toews
New submission from Michael Toews: On Debian x64 stable with Python 2.7 and 3.4, the following causes a segmentation fault: from ctypes import string_at string_at(None) On Windows 64-bit with Python 2.7 it raises WindowsError and Python 3.3 raises OSError, both showing a message access

[issue18378] locale.getdefaultlocale() fails on Mac OS X with default language set to English

2015-07-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Perhaps the better way to solve this issue is to use aliases table. What is the LC_CTYPE environment variable set when the default language set to non-English? How different native MacOS X command-line programs behave when set LC_CTYPE to other encoding

[issue24714] Crash with string_at(None)

2015-07-25 Thread STINNER Victor
STINNER Victor added the comment: ctypes gives you a raw access to the memory. If you try to read unmapped memory areas, the program may or may not crash. Usually, you get a segmentation fault. https://en.wikipedia.org/wiki/Segmentation_fault Python doesn't provide a portable behaviour on

[issue24714] Crash with string_at(None)

2015-07-25 Thread Serhiy Storchaka
Changes by Serhiy Storchaka storch...@gmail.com: -- nosy: +amaury.forgeotdarc, belopolsky, meador.inge versions: +Python 3.5, Python 3.6 -Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24714

[issue24714] Crash with string_at(None)

2015-07-25 Thread STINNER Victor
Changes by STINNER Victor victor.stin...@gmail.com: -- status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24714 ___ ___

[issue19475] Add timespec optional flag to datetime isoformat() to choose the precision

2015-07-25 Thread Alessandro Cucci
Changes by Alessandro Cucci alessandro.cu...@gmail.com: -- keywords: +patch Added file: http://bugs.python.org/file40018/issue19475.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19475

[issue24721] The result of calling dict.* methods on OrderedDict is undefined.

2015-07-25 Thread Raymond Hettinger
Changes by Raymond Hettinger raymond.hettin...@gmail.com: -- assignee: docs@python - rhettinger ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24721 ___

[issue23670] Modifications to support iOS as a cross-compilation target

2015-07-25 Thread Marco Paolini
Changes by Marco Paolini markopaol...@gmail.com: -- nosy: +mpaolini ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23670 ___ ___ Python-bugs-list

[issue24721] The result of calling dict.* methods on OrderedDict is undefined.

2015-07-25 Thread Eric Snow
New submission from Eric Snow: (see issue24667) collections.OrderedDict subclasses dict so calling dict's methods on an OrderedDict works. However, neither the pure Python nor the C implementation of OrderedDict was written to support doing so. In fact, both of them currently enter an

[issue24721] The result of calling dict.* methods on OrderedDict is undefined.

2015-07-25 Thread Eric Snow
Eric Snow added the comment: Feel free to close this, Raymond. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24721 ___ ___ Python-bugs-list

[issue18181] PEP447: Add type.__getdescriptor__

2015-07-25 Thread Ronald Oussoren
Ronald Oussoren added the comment: Note: the error handling code for exceptions in __getdescriptor__ definitely isn't good enough yet. I'm writing tests and am hunting down the problems those tests find. I'm getting closer and will post a new version when I think I've found all bugs.

[issue24720] Python install help

2015-07-25 Thread Zachary Ware
Zachary Ware added the comment: 1) your paste appears to be invalid. You can just paste in a message here, or attach a screenshot (though text is preferable :)) 2) 3.5.0b2 is out of date, try with beta 3 (or beta 4, due out this weekend) -- components: +Installation, Windows nosy:

[issue24719] Resourc Leak in cPickle Module

2015-07-25 Thread Roundup Robot
Roundup Robot added the comment: New changeset a789ee93f152 by Benjamin Peterson in branch '2.7': possible memory leak in error case (closes #24719) https://hg.python.org/cpython/rev/a789ee93f152 -- nosy: +python-dev resolution: - fixed stage: - resolved status: open - closed

[issue24667] OrderedDict.popitem()/__str__() raises KeyError

2015-07-25 Thread Eric Snow
Eric Snow added the comment: Regarding this bug, it's clear now that the ordered keys and the underlying dict are getting out of sync somewhere. This is either due to a bug in the C OrderedDict implementation or the use of the concrete dict C-API (or dict.* methods; thanks Mark). It's

[issue24721] The result of calling dict.* methods on OrderedDict is undefined.

2015-07-25 Thread Raymond Hettinger
Raymond Hettinger added the comment: This is a consequence of subclassing a builtin type Not really. This is how subclassing works in general. Any time you a user calls a parent class directly on an instance of subclass, they are bypassing whatever the subclass needs to do to maintain its

[issue24667] OrderedDict.popitem()/__str__() raises KeyError

2015-07-25 Thread Mark Shannon
Mark Shannon added the comment: The attached test case raises a KeyError for __str__() -- nosy: +Mark.Shannon Added file: http://bugs.python.org/file40019/test.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24667

[issue24720] Python install help

2015-07-25 Thread node
New submission from node: I am trying to install Python 3.5.0b2 on Win 8.1 but cannot get it loaded http://pastebin.com/hKU2bvds the error. hoping some one can help. -- messages: 247352 nosy: node priority: normal severity: normal status: open title: Python install help type: behavior

[issue23496] Steps for Android Native Build of Python 3.4.2

2015-07-25 Thread Marco Paolini
Changes by Marco Paolini markopaol...@gmail.com: -- nosy: +mpaolini ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23496 ___ ___ Python-bugs-list

[issue24667] OrderedDict.popitem()/__str__() raises KeyError

2015-07-25 Thread Eric Snow
Eric Snow added the comment: @Mark, note that you get the same behavior with the pure Python OrderedDict. Calling dict.* methods on an OrderedDict gives you undefined behavior. I expect the same is true for most subclasses of builtin types that override builtin methods. Anyway, the problem

[issue24721] The result of calling dict.* methods on OrderedDict is undefined.

2015-07-25 Thread Eric Snow
Eric Snow added the comment: Ah, you're right. I was hung up on issue10977. :) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24721 ___ ___

[issue24708] strop.replace Integer Overflow

2015-07-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Here is modified patch. In new code we try to avoid integer wrap around. It is safer to raise MemoryError right after PyMem_MALLOC(), otherwise it would possible to reraise unrelated exception instead MemoryError if strop.replace() is called without

[issue24708] strop.replace Integer Overflow

2015-07-25 Thread Roundup Robot
Roundup Robot added the comment: New changeset 7b5513e5afd2 by Benjamin Peterson in branch '2.7': proper overflow checks for mymemreplace (closes #24708) https://hg.python.org/cpython/rev/7b5513e5afd2 -- nosy: +python-dev resolution: - fixed stage: patch review - resolved status: open

[issue24712] Docs page's sidebar vibrates on mouse wheel scroll on Chrome.

2015-07-25 Thread asal ada
Changes by asal ada asalad...@gmail.com: -- components: +2to3 (2.x to 3.x conversion tool), Benchmarks, Build, Cross-Build, Demos and Tools, IO, Installation, Interpreter Core, Library (Lib), Tests, Unicode, Windows, XML, email nosy: +barry, haypo, paul.moore, r.david.murray,

[issue11872] cPickle gives strange error for large objects.

2015-07-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Is this issue still actual? -- nosy: +serhiy.storchaka status: open - pending ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11872 ___

[issue2263] struct.pack() + numpy int raises SystemError

2015-07-25 Thread Serhiy Storchaka
Changes by Serhiy Storchaka storch...@gmail.com: -- status: open - pending ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2263 ___ ___

[issue24712] Docs page's sidebar vibrates on mouse wheel scroll on Chrome.

2015-07-25 Thread Steve Dower
Changes by Steve Dower steve.do...@microsoft.com: -- components: -2to3 (2.x to 3.x conversion tool), Benchmarks, Build, Cross-Build, Demos and Tools, IO, Installation, Interpreter Core, Library (Lib), Tests, Unicode, Windows, XML, email nosy: -steve.dower

[issue24715] Sorting HOW TO: bad example for reverse sort stability

2015-07-25 Thread Raymond Hettinger
Changes by Raymond Hettinger raymond.hettin...@gmail.com: -- assignee: docs@python - rhettinger nosy: +rhettinger ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24715 ___

[issue23496] Steps for Android Native Build of Python 3.4.2

2015-07-25 Thread Ryan Gonzalez
Ryan Gonzalez added the comment: So...I have *no* clue why _struct can't be found. Can you use gdb to get the segfault backtrace like you did before? On July 25, 2015 6:56:10 AM CDT, Cyd Haselton rep...@bugs.python.org wrote: Cyd Haselton added the comment: I assume so; I'm using whatever is

[issue24667] OrderedDict.popitem()/__str__() raises KeyError

2015-07-25 Thread Fabian
Fabian added the comment: Really this bug and not the one mentioned by Mark? I've been using 3.4(.3) since we use requests (and therefore urllib3) which happened a few months ago. I also can't remember any failure on a Python 3.4 Travis build. --

[issue24613] array.fromstring Use After Free

2015-07-25 Thread John Leitch
John Leitch added the comment: Attached is a patch that updates array.fromstring to throw a ValueError when self is passed. It also updates the unit tests to cover this new behavior. -- Added file: http://bugs.python.org/file40023/array.fromstring-Use-After-Free.patch

[issue24717] python logging handler not used when added after a process is started

2015-07-25 Thread Vinay Sajip
Vinay Sajip added the comment: This is not a bug - it's how processes work on POSIX. Multiprocessing on POSIX generally uses the fork system call, which happens when you create a another process via the Process(...) call. At this point, the created process is a copy of the original process.

[issue24585] Windows installer does not detect existing installs

2015-07-25 Thread Larry Hastings
Larry Hastings added the comment: Since we apparently can't test this without making the release, but it's important enough to not defer, I am in the unenviable position of shipping the last beta with this bug marked as a release blocker. Fingers crossed! -- nosy: +larry

[issue24635] test_typing is flaky

2015-07-25 Thread Larry Hastings
Larry Hastings added the comment: Deferring for beta 4. We should still fix before release. Preferably before RC1 depending on the availability of Certain Persons. -- nosy: +larry priority: release blocker - deferred blocker ___ Python tracker

[issue24723] The new typing module is not documented :-(

2015-07-25 Thread STINNER Victor
New submission from STINNER Victor: It looks like someone forgot to write the doc ;-) https://docs.python.org/dev/library/typing.html -- assignee: docs@python components: Documentation messages: 247399 nosy: docs@python, gvanrossum, haypo priority: normal severity: normal status: open

[issue24667] OrderedDict.popitem()/__str__() raises KeyError

2015-07-25 Thread Larry Hastings
Larry Hastings added the comment: It produces the same exception under Python 3.4, too. -- nosy: +larry ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24667 ___

[issue24619] async/await parser issues

2015-07-25 Thread Larry Hastings
Changes by Larry Hastings la...@hastings.org: -- status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24619 ___ ___

[issue24645] logging.handlers.QueueHandler should not lock when handling a record

2015-07-25 Thread Vinay Sajip
Changes by Vinay Sajip vinay_sa...@yahoo.co.uk: -- resolution: - not a bug status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24645 ___

[issue24667] OrderedDict.popitem()/__str__() raises KeyError

2015-07-25 Thread Larry Hastings
Larry Hastings added the comment: Mark's test case file produced a KeyError under 3.4 when I tried it. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24667 ___

[issue24716] Multiple fdopen() on mkstemp() descriptor crashes py27 interpreter

2015-07-25 Thread eryksun
eryksun added the comment: Reassigning f closes the first file object, but not before the second file object gets created. You can write to the already-closed file, assuming the write is small enough to not flush the FILE stream buffer (e.g. beer, given an empty 4 KiB buffer). However,

[issue24716] Multiple fdopen() on mkstemp() descriptor crashes py27 interpreter

2015-07-25 Thread STINNER Victor
STINNER Victor added the comment: As eryksun explained, you have a bug in your example. You should fix your code. I would not call it a bug in Python, but more yet another bug (or unexpected behaviour) of the C stdio of Windows. My list of bugs in the C stdio is already long:

[issue24720] Python install help

2015-07-25 Thread node
node added the comment: Steve, I have Admin privilege -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24720 ___ ___ Python-bugs-list mailing list

[issue24635] test_typing is flaky

2015-07-25 Thread STINNER Victor
Changes by STINNER Victor victor.stin...@gmail.com: -- nosy: +haypo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24635 ___ ___ Python-bugs-list

[issue24681] Put most likely test first in set_add_entry()

2015-07-25 Thread STINNER Victor
Changes by STINNER Victor victor.stin...@gmail.com: -- nosy: -haypo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24681 ___ ___ Python-bugs-list

[issue19475] Add timespec optional flag to datetime isoformat() to choose the precision

2015-07-25 Thread STINNER Victor
STINNER Victor added the comment: @acucci: Nice first try, but your patch contains multiple bugs. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19475 ___

[issue19475] Add timespec optional flag to datetime isoformat() to choose the precision

2015-07-25 Thread Alessandro Cucci
Alessandro Cucci added the comment: @haypo thanks for the review and the suggestions, I'll correct the code soon -- nosy: +acucci ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19475 ___

[issue19475] Add timespec optional flag to datetime isoformat() to choose the precision

2015-07-25 Thread Alessandro Cucci
Changes by Alessandro Cucci alessandro.cu...@gmail.com: Added file: http://bugs.python.org/file40024/issue19475_v2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19475 ___

[issue24720] Python install help

2015-07-25 Thread node
node added the comment: http://pastebin.com/D5eVxF1b Sorry, try this where to get the latest version pls.. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24720 ___

[issue24722] Python install help

2015-07-25 Thread node
New submission from node: http://pastebin.com/D5eVxF1b Sorry, where can I download the latest version? I went to python site and only saw this version -- messages: 247362 nosy: node priority: normal severity: normal status: open title: Python install help type: behavior versions:

[issue23496] Steps for Android Native Build of Python 3.4.2

2015-07-25 Thread Cyd Haselton
Cyd Haselton added the comment: As soon as I build a PIE gdb I can. And right now, running ./python -m test throws the ImportError...so I'll need to resolve that first On Jul 25, 2015 12:38 PM, Ryan Gonzalez rep...@bugs.python.org wrote: Ryan Gonzalez added the comment: So...I have *no*

[issue15989] Possible integer overflow of PyLong_AsLong() results

2015-07-25 Thread Robert Collins
Robert Collins added the comment: @serhiy - I'm a little confused about the state of this patch. It seems like you need more review? -- nosy: +rbcollins ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15989

[issue20544] Use specific asserts in operator tests

2015-07-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Backporting this to older releases is needed to help backporting future tests. We should keep tests consistent if possible. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20544

[issue24722] Python install help

2015-07-25 Thread Zachary Ware
Changes by Zachary Ware zachary.w...@gmail.com: -- resolution: - duplicate stage: - resolved status: open - closed superseder: - Python install help ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24722

[issue24715] Sorting HOW TO: bad example for reverse sort stability

2015-07-25 Thread Raymond Hettinger
Changes by Raymond Hettinger raymond.hettin...@gmail.com: -- keywords: +patch Added file: http://bugs.python.org/file40022/reverse_stablity.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24715

[issue23926] skipitem() in getargs.c still supports 'w' and 'w#', and shouldn't

2015-07-25 Thread Joe Jevnik
Joe Jevnik added the comment: bumping so that we don't forget about this. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23926 ___ ___

[issue24717] python logging handler not used when added after a process is started

2015-07-25 Thread Ned Deily
Changes by Ned Deily n...@acm.org: -- nosy: +vinay.sajip ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24717 ___ ___ Python-bugs-list mailing list

[issue12006] strptime should implement %G, %V and %u directives

2015-07-25 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Reverting to needs patch stage because there are still issues to be ironed out. -- stage: commit review - needs patch versions: +Python 3.6 -Python 3.5 ___ Python tracker rep...@bugs.python.org

[issue20544] Use specific asserts in operator tests

2015-07-25 Thread Raymond Hettinger
Raymond Hettinger added the comment: I don't think kind of shallow changes to the test suite should be backported. They probably shouldn't have been done at all. When you change code, the tests are a safety net. When you change tests, you have almost no safety net at all. If the original

[issue24710] Class name hardcoded in TracebackException.from_exception()

2015-07-25 Thread Robert Collins
Robert Collins added the comment: I know it 'works', I just think its not appropriate here. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24710 ___

[issue24720] Python install help

2015-07-25 Thread Steve Dower
Steve Dower added the comment: Are you being promoted for administrative privileges? Unfortunately there's no way around requiring them to install the C Runtime update, so if you are blocked from applying Windows Updates to your machine unfortunately there's no good way around this.

[issue20544] Use specific asserts in operator tests

2015-07-25 Thread Antoine Pitrou
Antoine Pitrou added the comment: Everyone except Raymond seems to agree the patch is a good think, so it should probably be applied. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20544

[issue21750] mock_open data is visible only once for the life of the class

2015-07-25 Thread Robert Collins
Changes by Robert Collins robe...@robertcollins.net: -- resolution: - fixed stage: needs patch - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21750 ___

[issue2091] file accepts 'rU+' as a mode

2015-07-25 Thread Roundup Robot
Roundup Robot added the comment: New changeset 1a5bbb31f740 by Robert Collins in branch 'default': - Issue #2091: error correctly on open() with mode 'U' and '+' https://hg.python.org/cpython/rev/1a5bbb31f740 -- nosy: +python-dev ___ Python tracker

[issue2091] file accepts 'rU+' as a mode

2015-07-25 Thread Robert Collins
Changes by Robert Collins robe...@robertcollins.net: -- resolution: - fixed stage: commit review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2091 ___

[issue2091] file accepts 'rU+' as a mode

2015-07-25 Thread Robert Collins
Robert Collins added the comment: @larry thanks - that was my inclination too. Applied to 3.6 @Serhiy I've not done a warning in 3.4/3.5 because - the behaviour is already broken, this patch just catches it a lot earlier (on open rather than subsequent operations). --

[issue24710] Class name hardcoded in TracebackException.from_exception()

2015-07-25 Thread Robert Collins
Robert Collins added the comment: We can't use from_exception in __init__ because from_exception's job is to look up __traceback__, but the legacy API allows arbitrary tb objects which may not be exc.__traceback__, and modifying exc.__traceback__ or creating a shim object just to be able to

[issue10388] spwd returning different value depending on privileges

2015-07-25 Thread Robert Collins
Robert Collins added the comment: Too late for 3.5 for this IMO. -- nosy: +rbcollins versions: +Python 3.6 -Python 3.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10388 ___

[issue18787] Misleading error from getspnam function of spwd module

2015-07-25 Thread Robert Collins
Robert Collins added the comment: Sounds like we want something analogous to http://bugs.python.org/file33404/fix_error_message_getspall_v2.patch for this bug. Moving to patch needed. It looks like it would be easily tested too, so I'd like to see a test too please. -- nosy:

[issue20544] Use specific asserts in operator tests

2015-07-25 Thread Robert Collins
Robert Collins added the comment: Looks sane to me. Should go in 3.6 if we're going to do this or get closed to remove cognitive overhead in the issue tracker. No point backporting this to older releases. -- nosy: +rbcollins versions: +Python 3.6 -Python 2.7, Python 3.4, Python 3.5

[issue24710] Class name hardcoded in TracebackException.from_exception()

2015-07-25 Thread Robert Collins
Robert Collins added the comment: Oh I see, - different things could have been meant but that application will work. But - please don't use self.from_exception: its a class method, so TracebackException.from_exception(...) is the right spelling. --

[issue24710] Class name hardcoded in TracebackException.from_exception()

2015-07-25 Thread Serhiy Storchaka
Changes by Serhiy Storchaka storch...@gmail.com: -- resolution: fixed - stage: resolved - patch review status: closed - open ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24710 ___

[issue24710] Class name hardcoded in TracebackException.from_exception()

2015-07-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: self.from_exception() works as well. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24710 ___ ___

[issue24721] The result of calling dict.* methods on OrderedDict is undefined.

2015-07-25 Thread Raymond Hettinger
Changes by Raymond Hettinger raymond.hettin...@gmail.com: -- resolution: - not a bug status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24721 ___

[issue24710] Class name hardcoded in TracebackException.from_exception()

2015-07-25 Thread Robert Collins
Changes by Robert Collins robe...@robertcollins.net: -- resolution: - fixed stage: patch review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24710 ___

[issue24710] Class name hardcoded in TracebackException.from_exception()

2015-07-25 Thread Roundup Robot
Roundup Robot added the comment: New changeset 1be4d7388279 by Robert Collins in branch 'default': Issue #24710: Use cls in TracebackException.from_exception. https://hg.python.org/cpython/rev/1be4d7388279 -- nosy: +python-dev ___ Python tracker

[issue24710] Class name hardcoded in TracebackException.from_exception()

2015-07-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: We can use from_exception() in __init__ because in both cases first three arguments of TracebackException() are type(e), e, e.__traceback__. Without this change changing from_exception() makes less sense. Here is a patch. -- Added file:

[issue24651] Mock.assert* API is in user namespace

2015-07-25 Thread Robert Collins
Robert Collins added the comment: Some great points raised here. Yes, we'd need .calls and .returnvalue and so on all made accessible via another route, and that would be a less direct spelling. e.g. a_mock.returnvalue = 3 - # function set_returnvalue(a_mock, 3) or # separate object to get

[issue2091] file accepts 'rU+' as a mode

2015-07-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Perhaps the 'U' mode should just raise an exception in 3.6. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2091 ___

[issue24651] Mock.assert* API is in user namespace

2015-07-25 Thread Robert Collins
Changes by Robert Collins robe...@robertcollins.net: -- priority: normal - low ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24651 ___ ___

[issue15989] Possible integer overflow of PyLong_AsLong() results

2015-07-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Yes, it would be good if other's pair of eyes will look on the patch. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15989 ___

[issue10388] spwd returning different value depending on privileges

2015-07-25 Thread Robert Collins
Robert Collins added the comment: I'm moving this back to patch review - it needs a test, particularly because of the question I have around setspent. -- stage: commit review - patch review ___ Python tracker rep...@bugs.python.org

[issue10388] spwd returning different value depending on privileges

2015-07-25 Thread Robert Collins
Robert Collins added the comment: The man page for setspent says this: The functions that return a pointer return NULL if no more entries are available or if an error occurs during processing. The functions which have int as the return value return 0 for success and -1 for failure,

[issue24712] Docs page's sidebar vibrates on mouse wheel scroll on Chrome.

2015-07-25 Thread Ned Deily
Changes by Ned Deily n...@acm.org: -- nosy: +georg.brandl ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24712 ___ ___ Python-bugs-list mailing

[issue20544] Use specific asserts in operator tests

2015-07-25 Thread Robert Collins
Robert Collins added the comment: So, is this specific patch ok to apply, or are we going to reject it? I don't particularly care either way, but having this issue open and stalled just adds cognitive load to working with the bug tracker. FWIW I agree that it should not be backported.

[issue20544] Use specific asserts in operator tests

2015-07-25 Thread Raymond Hettinger
Raymond Hettinger added the comment: Antoine, I'm surprised, usually you're the first to oppose backporting anything other than bug-fixes and were generally supportive of Guido's admonitions about holistic refactoring. It seems you feel strongly enough about the patch to warrant telling all

  1   2   >