[issue25590] tab-completition on instances repeatedly accesses attribute/descriptors values

2015-11-09 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Agreed with all your suggestions Martin. Do you want to write a patch? -- stage: test needed -> needs patch ___ Python tracker ___ ___

[issue11822] Improve disassembly to show embedded code objects

2015-11-09 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- assignee: rhettinger -> ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue23883] __all__ lists are incomplete

2015-11-09 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I have added comments on Rietveld. Besides few stylistic nitpicks Issue23883_support_check__all__.v5.patch LGTM. > But passing "self" to it feels a bit weird. This is not new. There are other testing helpers in test.support that needs passing "self". If the

[issue25593] _sock_connect_cb can be called twice resulting in InvalidStateError

2015-11-09 Thread Alexander Mohr
New submission from Alexander Mohr: asyncio.selector_events.BaseSelectorEventLoop._sock_connect_cb is a callback based on the selector for a socket. There are certain situations when the selector triggers twice calling this callback twice, resulting in an InvalidStateError when it sets the Fut

[issue25592] distutils docs: data_files always uses sys.prefix

2015-11-09 Thread Jeroen Demeyer
New submission from Jeroen Demeyer: The documentation for distutils claims that sys.exec_prefix is used in certain cases to install data_files, but this is simply not true (maybe it was true in the past or this sentence was copy/pasted from somewhere else?) -- assignee: docs@python com

[issue25585] Bad path leads to: ImportError: DLL load failed: %1 is not a valid Win32 application.

2015-11-09 Thread Steve Dower
Steve Dower added the comment: Correction, *import* not found, and the only way to resolve it is to do a second scan of sys.path for the sole purpose of diagnostics. Probably more harmful than helpful. -- ___ Python tracker

[issue25585] Bad path leads to: ImportError: DLL load failed: %1 is not a valid Win32 application.

2015-11-09 Thread Steve Dower
Steve Dower added the comment: For 3.6 I think it's fine, but people are almost certainly relying on the current message on their system and changing it at all for any existing release is unnecessary pain (3.5.1 *might* be okay, but only because it's so recent). It would be nice to invest in s

[issue25567] shlex.quote doesn't work on bytestrings

2015-11-09 Thread Nan Wu
Nan Wu added the comment: Added a patch for support this in `quote` method. What is a good example or a group of examples to demonstrate the usage in the document? -- keywords: +patch nosy: +Nan Wu Added file: http://bugs.python.org/file40992/shlex_quote_bytes_support.patch ___

[issue1103213] Adding a recvexactly() to socket.socket: receive exactly n bytes

2015-11-09 Thread Martin Panter
Martin Panter added the comment: I can’t say I’ve often wanted this kind of method for socket objects. I guess this would treat a zero-length message (e.g. UDP datagram) as end-of-stream. Maybe it would be more useful as a general function or method for RawIOBase (maybe also BufferedIOBase) st

[issue19645] decouple unittest assertions from the TestCase class

2015-11-09 Thread Martin Panter
Martin Panter added the comment: Looking at Gregory and Robert’s “matchers” link, which also covers “assertThat”, it seems to provide a library of matcher assertion objects. E.g. instead of this TestCase-coupled code: self.assertEquals(something, "expected value") you would write from testto

[issue23883] __all__ lists are incomplete

2015-11-09 Thread Martin Panter
Martin Panter added the comment: Berker (or anyone else), do you have a preference on how we move forward? I am inclined to use Jacek’s function as it is. I think it is certainly an improvement over the current state. People can propose an alternative version of the function later if they want

[issue25589] test_ascii_formatd fails on Mac when built with Intel compiler

2015-11-09 Thread Ned Deily
Changes by Ned Deily : -- nosy: -ned.deily ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue25589] test_ascii_formatd fails on Mac when built with Intel compiler

2015-11-09 Thread Ned Deily
Ned Deily added the comment: Thanks for the updates. Since it's not at all clear what the issue is or that it is Mac-specific, I'm going to bow out of this and remove the Mac tag for now. -- components: -Macintosh, Tests nosy: -ronaldoussoren ___

[issue25465] Pickle uses O(n) memory overhead

2015-11-09 Thread Martin Panter
Martin Panter added the comment: FWIW my usual workaround is to enable Linux’s SysRq handler, then press Ctrl+Alt+(SysRq, F) to manually invoke the OOM killer. It beats waiting between 30 and infinity minutes for it to manually kick in :) -- ___ Pyt

[issue25583] os.makedirs with exist_ok=True raises PermissionError on Windows 7^

2015-11-09 Thread Martin Panter
Martin Panter added the comment: I don’t think we patch 3.2 or 3.3 any more unless it is a security concern. That is why I removed them. I understand 3.4 is due for its last non-security release in a couple weeks. I was actually referring to your original suggestion in

[issue25590] tab-completition on instances repeatedly accesses attribute/descriptors values

2015-11-09 Thread Martin Panter
Martin Panter added the comment: Illustration of why I think removing the attribute on errors is bad: >>> class Foo: ... @property ... def bar(self): return self._bar ... @bar.setter ... def bar(self, value): self._bar = value ... >>> f = Foo() >>> f.bar = ... # Tab completion fails in

[issue25528] Attempt to further increase test coverage of calendar module

2015-11-09 Thread Martin Panter
Martin Panter added the comment: Rohit, it looks like your patch is reversed. The lines with a + sign already exist; are the - lines your proposed additions? Equivalently, revision f7db966c9fee already exists; is fb9d4ccbadf0 your new proposed revision? Assuming the patch is reversed, I sugges

[issue25583] os.makedirs with exist_ok=True raises PermissionError on Windows 7^

2015-11-09 Thread Daniel Plachotich
Daniel Plachotich added the comment: You mean msg254341? As I mentioned recently, it still will raise an exception in case of EROFS, ENOSPC and possibly other values, which, as in the case with Windows, can be quite unexpected depending on platform and circumstances. Of course there is no practi

[issue25590] tab-completition on instances repeatedly accesses attribute/descriptors values

2015-11-09 Thread Martin Panter
Martin Panter added the comment: Long story short: it is accessed due to the callable suffix check (Issue 449227), and this check is less than optimal, meaning the attribute gets accessed up to four times per Tab press. In 3.6, there are only two calls, one for the hasattr() call, and one for

[issue13940] imaplib: Mailbox names are not quoted

2015-11-09 Thread Maciej Szulik
Maciej Szulik added the comment: Currently working on a patch for this. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue25591] improve test coverage for the imaplib

2015-11-09 Thread Maciej Szulik
New submission from Maciej Szulik: Our current imaplib implementation lacks quite a few of tests and the ones present are written in different styles. I'd like to propose rewriting the test case with this new style I've developed during PyCon sprints along with David. Once we'll have the entir

[issue25583] os.makedirs with exist_ok=True raises PermissionError on Windows 7^

2015-11-09 Thread Martin Panter
Martin Panter added the comment: Yes that looks like an improvement, though I wonder what’s wrong with your original proposal (performance maybe?). In any case, it definitely needs a comment explaining the first isdir() avoids competing failures that mask EEXIST, and the exception handling avo

[issue25590] tab-completition on instances repeatedly accesses attribute/descriptors values

2015-11-09 Thread Ezio Melotti
New submission from Ezio Melotti: Pressing to invoke autocompletition on instances repeatedly accesses attributes/descriptors values: >>> # is used to indicate when/where I press >>> class Foo: ... @property ... def bar(self): print('Foo.bar called') ... >>> f = Foo() >>> f.Foo.bar call

[issue25584] a recursive glob pattern fails to list files in the current directory

2015-11-09 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Please open new issue for glob() optimization Xavier. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker _

[issue25586] socket.sendall broken when a socket has a timeout

2015-11-09 Thread STINNER Victor
STINNER Victor added the comment: I don't really understand why do even you consider the behaviour has a bug or a trap. On timeout, the most common behaviour is to give up on the whole client. I don't know code trying to resend the same data in case of timeout. Describing the behaviour on the

[issue25584] a recursive glob pattern fails to list files in the current directory

2015-11-09 Thread Roundup Robot
Roundup Robot added the comment: New changeset 4532c4f37429 by Serhiy Storchaka in branch '3.5': Issue #25584: Fixed recursive glob() with patterns starting with '**'. https://hg.python.org/cpython/rev/4532c4f37429 New changeset 175cd763de57 by Serhiy Storchaka in branch 'default': Issue #25584:

[issue25586] socket.sendall broken when a socket has a timeout

2015-11-09 Thread Martin Panter
Martin Panter added the comment: Personally I would avoid big red warning boxes in 90% of the cases people suggest them, including this one. But maybe we can see what others think. -- ___ Python tracker __

[issue25585] Bad path leads to: ImportError: DLL load failed: %1 is not a valid Win32 application.

2015-11-09 Thread eryksun
eryksun added the comment: Steve, do you think it's OK to abandon localization for exception messages? If so, should we be using English for all FormatMessage calls? It's a bit ugly that Python's exceptions and the CRT error messages are in English, but then whenever we call FormatMessage with

[issue25555] Fix parser and AST: fill lineno and col_offset when compiling AST from Python objects

2015-11-09 Thread STINNER Victor
STINNER Victor added the comment: I backported the fix to Python 3.5. Since I'm not convinced that the bug can be triggered without modifying CPython (the bug only impacts FAT Python which installs a hook on the AST compiler), I don't want to backport it to Python 2.7 to avoid the risk of regr

[issue25589] test_ascii_formatd fails on Mac when built with Intel compiler

2015-11-09 Thread STINNER Victor
STINNER Victor added the comment: See also issue #24999 about ICC compiler. -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-lis

[issue1602] windows console doesn't print or input Unicode

2015-11-09 Thread Adam Bartoš
Adam Bartoš added the comment: dead1ne: Hello, I'm maintaining a package that tries to solve this issue: https://github.com/Drekin/win-unicode-console . There are actually many related problems. -- ___ Python tracker

[issue25589] test_ascii_formatd fails on Mac when built with Intel compiler

2015-11-09 Thread Chris Hogan
Chris Hogan added the comment: Ned, the test is in Lib/test/test_ascii_formatd.py. Sorry, I spelled it wrong originally. Also, I guess it's only in 2.7. My mistake. -- versions: -Python 3.5 ___ Python tracker

[issue25555] Fix parser and AST: fill lineno and col_offset when compiling AST from Python objects

2015-11-09 Thread Roundup Robot
Roundup Robot added the comment: New changeset 2d8988f64cea by Victor Stinner in branch '3.5': Issue #2: Fix parser and AST: fill lineno and col_offset of "arg" node when https://hg.python.org/cpython/rev/2d8988f64cea -- ___ Python tracker

[issue25589] test_ascii_formatd fails on Mac when built with Intel compiler

2015-11-09 Thread Ned Deily
Ned Deily added the comment: Chris, how exactly are you running this test that fails and where does the test come from? I may be overlooking something but I do not see any spelling of a test_ascii_formatted in the Python 3.5 source including its embedded ctypes. The ctypes shipped with Pytho

[issue1602] windows console doesn't print or input Unicode

2015-11-09 Thread dead1ne
dead1ne added the comment: I've tried addressing the output problem by subclassing TextIOWrapper to use the windows functions GetConsoleOutputCP and WideCharToMultiByte. I've tested this as well as I can without figuring out how to install a better font for the windows console. It appears to w

[issue25582] Fixed memory leaks in test_ctypes

2015-11-09 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: There is still 32 MB leak in PointersTestCase.test_pointer_type_str_name in test_pointers.py in 2.7. -- stage: patch review -> needs patch type: behavior -> resource usage versions: -Python 3.4, Python 3.5, Python 3.6 ___

[issue25582] Fixed memory leaks in test_ctypes

2015-11-09 Thread Roundup Robot
Roundup Robot added the comment: New changeset e5d7cf9d6469 by Serhiy Storchaka in branch '3.4': Issue #25582: Fixed 100 MB memory leak in test_ctypes. https://hg.python.org/cpython/rev/e5d7cf9d6469 New changeset f14f6bce3321 by Serhiy Storchaka in branch '2.7': Issue #25582: Fixed 100 MB memory

[issue25589] test_ascii_formatd fails on Mac when built with Intel compiler

2015-11-09 Thread Zachary Ware
Zachary Ware added the comment: Also, I haven't had an issue with this on my own machine. -- ___ Python tracker ___ ___ Python-bugs-li

[issue25589] test_ascii_formatd fails on Mac when built with Intel compiler

2015-11-09 Thread Zachary Ware
Zachary Ware added the comment: This doesn't seem to be a problem on the ICC buildbot; David, did you do anything special for libffi/ctypes? -- nosy: +r.david.murray, zach.ware ___ Python tracker _

[issue7267] format method: c presentation type broken in 2.7

2015-11-09 Thread Berker Peksag
Changes by Berker Peksag : -- stage: commit review -> resolved ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue25589] test_ascii_formatd fails on Mac when built with Intel compiler

2015-11-09 Thread Chris Hogan
New submission from Chris Hogan: I successfully built Python on OS X 10.10 with the Intel compiler v15. However, running the regression tests gives me a "segmentation fault: 11" on test_ascii_formated. I think this has to do with libffi, because when I build with the --use-system-ffi flag (u

[issue25584] a recursive glob pattern fails to list files in the current directory

2015-11-09 Thread Xavier de Gaye
Xavier de Gaye added the comment: glob('invalid_dir/**', recursive=True) triggers the assert that was added by my patch in _rlistdir(). This new patch fixes this: when there is no magic character in the dirname part of a split(), and dirname is not an existing directory, then there is nothing

[issue21818] cookielib documentation references Cookie module, not cookielib.Cookie class

2015-11-09 Thread Georg Brandl
Georg Brandl added the comment: The rules are as they are mostly for backwards compatibility. But it is rarely a problem since there is only one object with a given name. :class:`Cookie` within the docs for cookielib would not be able to link to Cookie.Cookie since it is not found in its scope

[issue24999] ICC compiler: ICC treats denormal floating point numbers as 0.0

2015-11-09 Thread STINNER Victor
Changes by STINNER Victor : -- title: Segfault in test_re.test_sre_character_class_literals() when Python is compiled by ICC -> ICC compiler: ICC treats denormal floating point numbers as 0.0 ___ Python tracker _

[issue25585] Bad path leads to: ImportError: DLL load failed: %1 is not a valid Win32 application.

2015-11-09 Thread Steve Dower
Steve Dower added the comment: It does, but you need to identify the error code precisely and use that to provide the parameters when obtaining the message. It's more about localization than a general way of obtaining error text. Better off just using our own message in this case (which is pro

[issue25585] Bad path leads to: ImportError: DLL load failed: %1 is not a valid Win32 application.

2015-11-09 Thread STINNER Victor
STINNER Victor added the comment: Does Windows provide a function to format a string using %1, %2, etc.? Note: Python 3.6 uses the same code than Python 2.7. -- nosy: +haypo ___ Python tracker

[issue24999] Segfault in test_re.test_sre_character_class_literals() when Python is compiled by ICC

2015-11-09 Thread Zachary Ware
Zachary Ware added the comment: Stefan Krah wrote: > If anyone worries that "-fp-model strict" will slow > things down: In the Python context these settings have > no measurable impact: A while ago I tested setting/restoring > the control word *for every operation*, and even that did > not have

[issue25585] Bad path leads to: ImportError: DLL load failed: %1 is not a valid Win32 application.

2015-11-09 Thread R. David Murray
R. David Murray added the comment: OK, so it sounds like there are improvements we could make here if someone wants to work on it. -- ___ Python tracker ___

[issue7267] format method: c presentation type broken in 2.7

2015-11-09 Thread STINNER Victor
STINNER Victor added the comment: Walter Dörwald added the comment: > Don't worry, I've switched to using Python 3 in 2012, where this isn't a > problem. ;) Wow, cool! We still have 1 or 2 customers stuck with Python 2, haha. -- ___ Python tracker

[issue25465] Pickle uses O(n) memory overhead

2015-11-09 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: There is a workaround for memory consumption, and Linux freezing is not Python issue. -- resolution: -> wont fix stage: -> resolved status: open -> closed ___ Python tracker _

[issue22499] [SSL: BAD_WRITE_RETRY] bad write retry in _ssl.c:1636

2015-11-09 Thread Stefan Krah
Stefan Krah added the comment: I had a similar issue with ucspi-ssl that was fixed by following the O'Reilly book's recommendations w.r.t WANT_READ/WANT_WRITE with non-blocking sockets to the letter. The recommendations are quite complex since apparently WANT_READ/WANT_WRITE mean different thing

[issue25263] test_tkinter fails randomly on the buildbots "AMD64 Windows10" (3.4, 3.5, 3.x)

2015-11-09 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Looks as there is also Tk bug. Perhaps on Windows (and Unix?) "winfo id" can return 64-bit integer, but the -use option works only with 32-bit integers. Opened Tk ticket: http://core.tcl.tk/tk/tktview?name=5ee8af61e5 . -- assignee: -> serhiy.storcha

[issue25465] Pickle uses O(n) memory overhead

2015-11-09 Thread Stefan Krah
Stefan Krah added the comment: It's a Linux issue. Disable overcommitting of memory (at your own peril) or set user limits (for example with djb's softlimit), then the process will be killed instead of freezing the machine. -- nosy: +skrah ___ Python

[issue25584] a recursive glob pattern fails to list files in the current directory

2015-11-09 Thread Xavier de Gaye
Xavier de Gaye added the comment: FWIW the patch looks good to me. I find the code in glob.py difficult to read as it happily joins regular filenames together with os.path.join() or attempts to list the files contained into a regular file (sic). The attached diff makes the code more correct a

[issue25587] Useless addition in PyTuple_New

2015-11-09 Thread STINNER Victor
STINNER Victor added the comment: The line "nbytes += " was removed 5 years ago by the changeset 7be8129ee0fd. It's maybe time to update your Python version? :-) Only Python < 2.7 has the line, it was removed before Python 2.7.0 was tagged. -- nosy: +haypo resolution: -> fixed status:

[issue25263] test_tkinter fails randomly on the buildbots "AMD64 Windows10" (3.4, 3.5, 3.x)

2015-11-09 Thread Roundup Robot
Roundup Robot added the comment: New changeset 3f8998c2fbf9 by Serhiy Storchaka in branch 'default': Issue #25263: Trying to fix test_use on Windows. https://hg.python.org/cpython/rev/3f8998c2fbf9 -- ___ Python tracker

[issue7267] format method: c presentation type broken in 2.7

2015-11-09 Thread Walter Dörwald
Walter Dörwald added the comment: Don't worry, I've switched to using Python 3 in 2012, where this isn't a problem. ;) -- ___ Python tracker ___ _

[issue25263] test_tkinter fails randomly on the buildbots "AMD64 Windows10" (3.4, 3.5, 3.x)

2015-11-09 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Didn't help. http://buildbot.python.org/all/builders/AMD64%20Windows8%203.x/builds/1494/steps/test/logs/stdio == ERROR: test_use (tkinter.test.test_tkinter.test_widgets.ToplevelTest) (wid='0x

[issue25465] Pickle uses O(n) memory overhead

2015-11-09 Thread Herbert
Herbert added the comment: It may be fair to note that I have no swap installed on one of the machines, just 16GB of RAM, on which the 'crash' happens. Hence I'm not sure how this affects paging, I would think there is no paging if there is no swap. I can verify that the machine is 'stuck' for

[issue7267] format method: c presentation type broken in 2.7

2015-11-09 Thread STINNER Victor
STINNER Victor added the comment: > Then feel free to commit your patch please. It LGTM. Thanks for the review ;-) @Walter: Sorry for the late fix (6 years later!). -- resolution: -> fixed status: open -> closed ___ Python tracker

[issue7267] format method: c presentation type broken in 2.7

2015-11-09 Thread Roundup Robot
Roundup Robot added the comment: New changeset 2f2c52c9ff38 by Victor Stinner in branch '2.7': Issue #7267: format(int, 'c') now raises OverflowError when the argument is not https://hg.python.org/cpython/rev/2f2c52c9ff38 -- nosy: +python-dev ___ Pyth

[issue7267] format method: c presentation type broken in 2.7

2015-11-09 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Then feel free to commit your patch please. It LGTM. -- stage: patch review -> commit review ___ Python tracker ___ ___

[issue25583] os.makedirs with exist_ok=True raises PermissionError on Windows 7^

2015-11-09 Thread Daniel Plachotich
Daniel Plachotich added the comment: Maybe the solution is to leave OSError catching after the conditional (probably with some additional comments): if not (exist_ok and path.isdir(name)): try: mkdir(name, mode) except OSError as e: if not exist_ok or e.errno !

[issue22643] Integer overflow in case_operation

2015-11-09 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue7267] format method: c presentation type broken in 2.7

2015-11-09 Thread STINNER Victor
STINNER Victor added the comment: > Both ways, with OverflowError and Py3k DeprecationWarning, are good to me. > What would you say about this Benjamin? I prefer an OverflowError. I don't like having to enable a flag to fix a bug :-( According to the issue title, it's really a bug: "format met

[issue25586] socket.sendall broken when a socket has a timeout

2015-11-09 Thread Jakub Stasiak
Jakub Stasiak added the comment: This is exactly what I'm thinking. Do you think it's sensible to move that sentence + some additional information (following your suggestion) into a "Warning" block? -- ___ Python tracker

[issue21818] cookielib documentation references Cookie module, not cookielib.Cookie class

2015-11-09 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Georg, is it possible to tune Sphinx rules? -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue7267] format method: c presentation type broken in 2.7

2015-11-09 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Ping. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue25587] Useless addition in PyTuple_New

2015-11-09 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: There is no such code in current sources. -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Py

[issue25584] a recursive glob pattern fails to list files in the current directory

2015-11-09 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file40987/rglob_zero_dirs_2.patch ___ Python tracker ___ ___ Python-bugs-list

[issue25588] Run test suite from IDLE idlelib.run subprocess

2015-11-09 Thread Terry J. Reedy
New submission from Terry J. Reedy: This issue proposes stress testing idlelib.run by running code that already reports whether results are as expected or not -- the test_suite. Since this one test will take at least as long as the test suite, and will probably need human intervention anyway,