[issue25677] Syntax error caret confused by indentation

Martin Panter added the comment: Michael, see the review comments if you already haven’t. There is an unused variable “p” in the last two patches. -- ___ Python tracker

[issue10131] deepcopying an xml.dom.minidom.Document generates an invalid XML document

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: test needed -> resolved status: open -> closed ___ Python tracker ___

[issue25677] Syntax error caret confused by indentation

Changes by Martin Panter : -- stage: test needed -> patch review ___ Python tracker ___

[issue10131] deepcopying an xml.dom.minidom.Document generates an invalid XML document

Serhiy Storchaka added the comment: Thank you Marian for your patch. Committed modified patch with tests. For compatibility with data pickled by unpatched Python we have to keep __setstate__. The discrepancy between pickle and copy module is different not easy issue. --

[issue4712] Document pickle behavior for subclasses of dicts/lists

Serhiy Storchaka added the comment: The order in copy was changed by issue1100562. -- ___ Python tracker ___

[issue4712] Document pickle behavior for subclasses of dicts/lists

Changes by Serhiy Storchaka : -- nosy: +alexandre.vassalotti, pitrou ___ Python tracker ___

[issue10131] deepcopying an xml.dom.minidom.Document generates an invalid XML document

Roundup Robot added the comment: New changeset 0eea57ddb75f by Serhiy Storchaka in branch '2.7': Issue #10131: Fixed deep copying of minidom documents. Based on patch https://hg.python.org/cpython/rev/0eea57ddb75f New changeset aa304ad32292 by Serhiy Storchaka in branch '3.4': Issue #10131:

[issue10131] deepcopying an xml.dom.minidom.Document generates an invalid XML document

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka nosy: +alexandre.vassalotti, pitrou, serhiy.storchaka versions: +Python 3.4, Python 3.5, Python 3.6 -Python 3.2, Python 3.3 Added file: http://bugs.python.org/file41170/copying_NodeList.patch

[issue1100562] deepcopying listlike and dictlike objects

Serhiy Storchaka added the comment: Note that this change added discrepancy between pickle and copy modules and broke deepcopying of minidom documents (issue10131). -- nosy: +serhiy.storchaka ___ Python tracker

[issue22233] http.client splits headers on non-\r\n characters

Martin Panter added the comment: For the record, this is a simplified version of the original scenario, showing the low-level HTTP protocol: >>> request = ( ... b"GET /%C4%85 HTTP/1.1\r\n" ... b"Host: graph.facebook.com\r\n" ... b"\r\n" ... ) >>> s =

[issue25738] http.server doesn't handle RESET CONTENT status correctly

New submission from SpaceOne: The status 205 RESET CONTENT is not correctly evaluated by http.server. It MUST NOT write a response body to the client. Patch: https://github.com/spaceone/cpython/commit/17048e2e7349cc4861c7fe90299f2c092b8e1604 -- components: Library (Lib) messages:

[issue25739] Add PAYLOAD_TOO_LARGE / URI_TOO_LONG (new name in RFC 7231)

Martin Panter added the comment: In general, I’m not sure it is worth adding aliases for various names used in different RFCs. But you could argue that this is appropriate because the old names are unnecessarily long. Another example would be HTTPStatus.REQUESTED_RANGE_NOT_SATISFIABLE vs

[issue25464] Tix HList header_exists should be "exist"

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka ___ Python tracker ___

[issue25739] Add PAYLOAD_TOO_LARGE (new name in RFC 7231)

New submission from SpaceOne: Add PAYLOAD_TOO_LARGE status code to http package. Patch: https://github.com/spaceone/cpython/commit/5d9427a07bde43b523386322b1fc377618eadb76 -- components: Library (Lib) messages: 255444 nosy: spaceone priority: normal severity: normal status: open title:

[issue25740] multiple issues in http.client

Martin Panter added the comment: I missed seeing the _get_hostport() change in the commit. So you are saying that values out of range 1–65535 should raise InvalidURL("nonnumeric port . . ."). The error message isn’t quite right. -- ___ Python

[issue24960] Can't use pip or easy_install with embeddable zip file.

Florian Hassanen added the comment: got this traceback: Traceback (most recent call last): File "setup.py", line 169, in dist = setuptools.setup(**setup_params) File "distutils\core.py", line 134, in setup File "...\setuptools\setuptools\dist.py", line 299, in parse_command_line

[issue25723] ConfigParser should never write broken configurations

SpaceOne added the comment: Of course both of you have reasonable arguments. For compatibility with overridden SECTRE attributes it should not raise ValueError for characters like [ and ]. (too bad that SECTRE is a public attribute otherwise it could also be used to validate the name

[issue25739] Add PAYLOAD_TOO_LARGE / URI_TOO_LONG (new name in RFC 7231)

SpaceOne added the comment: Also URI_TOO_LONG has been changed. https://tools.ietf.org/html/rfc7231#section-6.5.11 https://tools.ietf.org/html/rfc7231#section-6.5.12 -- title: Add PAYLOAD_TOO_LARGE (new name in RFC 7231) -> Add PAYLOAD_TOO_LARGE / URI_TOO_LONG (new name in RFC 7231)

[issue25740] multiple issues in http.client

Martin Panter added the comment: Thanks for these fixes. It might be better to open other report(s) for the FIXME comments, so you can explain them better, and propose any ideas or possible solutions. For some of them, it may be more appropriate to just fix them in the next (3.6) release,

[issue25740] multiple issues in http.client

New submission from SpaceOne: * RESET_CONTENT not evaluated * negative chunk size accepted * invalid ports accepted * success status !== 200 ignored Patch: https://github.com/spaceone/cpython/commit/3289080306408db971f8b816d3e9f0ab44ed392b Part of github Pull Request

[issue25738] http.server doesn't handle RESET CONTENT status correctly

Martin Panter added the comment: I left some comments about the tangential changes on Git Hub. Can you write a test case for this? -- nosy: +martin.panter stage: -> patch review type: -> behavior ___ Python tracker

[issue25660] tabs don't work correctly in python repl

Martin Panter added the comment: Yury or anyone else: can you confirm if the patch works properly with a proper OS X or BSD libedit (rather than my questionable Linux version?). If so, I think it is okay to ignore my Linux problems, and I could look at fixing the compatibility when the

[issue25736] smtplib can't send 8bit encoded utf-8 message

Ervin Hegedüs added the comment: Here is a workaround: server.sendmail(mailfrom, rcptto, msg.encode("utf8")) May be this would be better inside of smtplib? -- ___ Python tracker

[issue25730] invisible sidebar content with code snippets

hiroaki itoh added the comment: Because there are a couple of ways (places) to fix this, I'll try them, so please wait. For testing, I think we can only visit all htmls manually and I'll make an effort. -- ___ Python tracker

[issue25707] Add the close method for ElementTree.iterparse() object

Changes by Serhiy Storchaka : -- dependencies: +Verify the etree_parse and etree_iterparse benchmarks are working appropriately ___ Python tracker

[issue25622] Enable ctypes.test.test_values.Win_ValuesTestCase for non-Windows

Roundup Robot added the comment: New changeset 0325eca1927e by Martin Panter in branch '3.4': Issue #25622: Rename to PythonValuesTestCase and enable for non-Windows https://hg.python.org/cpython/rev/0325eca1927e New changeset 18a74ef65d3f by Martin Panter in branch '3.5': Issue #25622: Merge

[issue21228] Missing enumeration of HTTPResponse Objects methods of urllib.request.urlopen's http.client.HTTPResponse?

Roundup Robot added the comment: New changeset fa3c9faabfb0 by Martin Panter in branch '3.4': Issues #22989, #21228: Document HTTP response object for urlopen() https://hg.python.org/cpython/rev/fa3c9faabfb0 New changeset b55c006b79bc by Martin Panter in branch '3.5': Issue #22989, #21228:

[issue22989] HTTPResponse.msg not as documented

Roundup Robot added the comment: New changeset fa3c9faabfb0 by Martin Panter in branch '3.4': Issues #22989, #21228: Document HTTP response object for urlopen() https://hg.python.org/cpython/rev/fa3c9faabfb0 New changeset b55c006b79bc by Martin Panter in branch '3.5': Issue #22989, #21228:

[issue21228] Missing enumeration of HTTPResponse Objects methods of urllib.request.urlopen's http.client.HTTPResponse?

Changes by Martin Panter : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue21228] Missing enumeration of HTTPResponse Objects methods of urllib.request.urlopen's http.client.HTTPResponse?

Changes by Martin Panter : -- versions: +Python 3.6 ___ Python tracker ___ ___

[issue22989] HTTPResponse.msg not as documented

Martin Panter added the comment: The documentation now mentions the “msg” quirk and the info() method. -- resolution: -> fixed stage: -> resolved status: open -> closed versions: +Python 3.5, Python 3.6 ___ Python tracker

[issue25622] Enable ctypes.test.test_values.Win_ValuesTestCase for non-Windows

Roundup Robot added the comment: New changeset 7b12b04f4f18 by Martin Panter in branch '2.7': Issue #25622: Rename to PythonValuesTestCase and enable for non-Windows https://hg.python.org/cpython/rev/7b12b04f4f18 -- ___ Python tracker

[issue21668] The select and time modules uses libm functions without linking against it

Chi Hsuan Yen added the comment: Bump. For rev c6930661599b timemodule.c and selectmodule.c no longer calls libm functions, while audioop.c and _ctypes_test.c still do. I have my updated patch here based on previous patches. Note that the introduction of detect_math_libs() is my naive try.

[issue21668] The select and time modules uses libm functions without linking against it

Chi Hsuan Yen added the comment: Well, the hg revision of Python in two tests are different, because I `hg pull -u` each time I build. -- ___ Python tracker

[issue25622] Enable ctypes.test.test_values.Win_ValuesTestCase for non-Windows

Martin Panter added the comment: The buildbots don’t seem to be having any troubles with test_ctypes, so I assume my change is good. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue25737] array is not a Sequence

New submission from berdario: >>> from array import array >>> from collections.abc import Sequence >>> isinstance(array('I', [1]), Sequence) False -- components: Interpreter Core messages: 255413 nosy: berdario priority: normal severity: normal status: open title: array is not a

[issue25737] array is not a Sequence

Changes by Ezio Melotti : -- nosy: +ezio.melotti, rhettinger, stutzbach type: -> behavior ___ Python tracker ___

[issue25737] array is not a Sequence

berdario added the comment: Ok, basically `Sequence` does not implement `__subclasshook__` and is manually hardcoded to ``` Sequence.register(tuple) Sequence.register(str) Sequence.register(range) Sequence.register(memoryview) ``` This is not by design, is it? --

[issue25737] array is not a Sequence

Eryk Sun added the comment: This is a duplicate of issue 23864, i.e. only the "one-trick ponies" work: >>> issubclass(array.array, abc.Sized) True >>> issubclass(array.array, abc.Iterable) True >>> issubclass(array.array, abc.Container) True -- nosy: +eryksun

[issue25528] Attempt to further increase test coverage of calendar module

Stéphane Wirtel added the comment: no problem about the second patch of Rohit. pass the test with default and I have tested the code in the REPL. -- nosy: +matrixise ___ Python tracker

[issue25528] Attempt to further increase test coverage of calendar module

Serhiy Storchaka added the comment: The problem with Rohit's patch is that it throws out existing test case. -- nosy: +serhiy.storchaka ___ Python tracker

[issue25677] Syntax error caret confused by indentation

Michael Layzell added the comment: Martin's solution seemed like the least work, so that's what I ended up using. I also switched over to assertRegex, and I agree that it produces better error messages. I added a comment to explain the use of the ugly multiline regex, and removed some of its

[issue13330] Attempt full test coverage of LocaleTextCalendar.formatweekday

Serhiy Storchaka added the comment: The test depends on the en_US locale. Only existing of POSIX locale is guarantied. The test should be skipped instead of failed if the en_US locale is not available. It would be nice to test also with other locales. For example with de_DE, fr_FR, tr_TR,

[issue25730] invisible sidebar content with code snippets

Terry J. Reedy added the comment: I intentionally said 'test' rather than 'unittest' or 'automated test' to allow for the possibility of a human-operated view test script posted here on the issue. IDLE now has a view test framework to run tests for either one or all modules with visual

[issue12568] Add functions to get the width in columns of a character

Serhiy Storchaka added the comment: I think this function would be very useful in many parts of interpreter core and standard library. From displaying tracebacks to formatting helps. Otherwise we are doomed to implement imperfect variants in multiple places. -- resolution: out of date

[issue13330] Attempt full test coverage of LocaleTextCalendar.formatweekday

Serhiy Storchaka added the comment: And it looks that only empty locale works on Windows (issue21731). -- ___ Python tracker ___

[issue25528] Attempt to further increase test coverage of calendar module

Stéphane Wirtel added the comment: Sure, But the patch is correct. Now, you are right, we have to ask him a new patch where the function is really tested. -- ___ Python tracker

[issue25723] ConfigParser should never write broken configurations

R. David Murray added the comment: I view this as similar to the corresponding issue with email headers, where we fixed a similar security issue. The special danger of \n is that it allows you to create a *new* header, or in this case section, with an arbitrary value, possibly overriding an

[issue25736] smtplib can't send 8bit encoded utf-8 message

R. David Murray added the comment: Although that will work for text-only messages if you know what RFC format looks like, you really don't want to do that in the general case, since you can't express messages that have binary non-text content using unicode. What you want to do is prepare

[issue25736] smtplib can't send 8bit encoded utf-8 message

R. David Murray added the comment: Oh, and as for why this worked in python2: in python2 strings were binary, not unicode, so the non-ascii stuff was already in bytes form. -- ___ Python tracker

[issue25730] invisible sidebar content with code snippets

R. David Murray added the comment: Ah, I see what you mean. It's still tricky for web stuff, though, because what you see can completely depend on things like window size and browser version. So a detailed description of how to produce the error would be good, and we'll see if we actually

[issue13275] Recommend xml.etree for XML processing

Changes by Serhiy Storchaka : -- resolution: -> out of date stage: -> resolved status: open -> closed ___ Python tracker ___

[issue14988] _elementtree: Raise ImportError when importing of pyexpat fails

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: test needed -> resolved status: pending -> closed ___ Python tracker

[issue10942] xml.etree.ElementTree.tostring returns type bytes, expected type str

Changes by Serhiy Storchaka : -- resolution: -> out of date stage: needs patch -> resolved status: pending -> closed ___ Python tracker

[issue24858] python3 -m test -ugui -v test_tk gives 3 failures under Debian unstable (sid)

Changes by Serhiy Storchaka : -- resolution: -> third party stage: -> resolved status: pending -> closed ___ Python tracker ___

[issue15504] pickle/cPickle saves invalid/incomplete data

Changes by Serhiy Storchaka : -- resolution: -> out of date stage: -> resolved status: pending -> closed ___ Python tracker ___

[issue8426] multiprocessing.Queue fails to get() very large objects

Changes by Serhiy Storchaka : -- resolution: -> not a bug stage: -> resolved status: pending -> closed ___ Python tracker ___

[issue25040] xml.sax.make_parser makes bad use of parser_list argument default value

Changes by Serhiy Storchaka : -- resolution: -> not a bug stage: -> resolved status: pending -> closed ___ Python tracker ___

[issue25106] Hash computation speedup for {buffer, string, unicode}object

Serhiy Storchaka added the comment: Ping. -- status: pending -> open ___ Python tracker ___ ___

[issue12340] Access violation when using the C version of the io module

Changes by Serhiy Storchaka : -- resolution: -> out of date stage: -> resolved status: pending -> closed ___ Python tracker ___

[issue11872] cPickle gives strange error for large objects.

Changes by Serhiy Storchaka : -- resolution: -> out of date stage: needs patch -> resolved status: pending -> closed ___ Python tracker

[issue25194] Opt-in motivations & affiliations page for core contributors

Roundup Robot added the comment: New changeset b360bad24805 by R David Murray in branch 'default': #25194: add my entry to 'motivations'. https://hg.python.org/devguide/rev/b360bad24805 New changeset 2d4907e5b51c by R David Murray in branch 'default': #25194: Fix indentation in Nick's entry.

[issue23513] Add support for classes/object model in multiprocessing/pickle

Serhiy Storchaka added the comment: Support of pickling nested classes and methods with all protocols was added in issue23611. -- resolution: -> out of date stage: -> resolved status: pending -> closed ___ Python tracker

[issue25106] Hash computation speedup for {buffer, string, unicode}object

Gregory P. Smith added the comment: Reopen this if you find a reproducible way for this patch to prove useful. -- resolution: -> rejected status: open -> closed ___ Python tracker

[issue25194] Opt-in motivations & affiliations page for core contributors

R. David Murray added the comment: As I finalized my entry it occurred to me that in fact the PSF has expressed willingness to pay me for some contract work around the tracker, but I haven't managed to make the proposal yet. The good news in that is that in fact I have a good bit of open

[issue25736] smtplib can't send 8bit encoded utf-8 message

Ervin Hegedüs added the comment: David, many thanks for your information. I think my e-mail format was correct - I've copied it from a maildir, as an "email file". As I wrote, there is a solution: before the code passes the 'msg' argument to sendmail() function, it needs to encode() it as

[issue18911] minidom does not encode correctly when calling Document.writexml

Changes by Serhiy Storchaka : -- keywords: +easy stage: -> needs patch versions: +Python 3.5, Python 3.6 -Python 3.3 ___ Python tracker

[issue4712] Document pickle behavior for subclasses of dicts/lists

Serhiy Storchaka added the comment: The copy module uses the same __reduce__ protocol, but reconstruct the object in different order, first set state, then add items. This discrepancy causes a difference between results of pickle/unpickle and copy operations. Example: >>> class L(list): ...

[issue23914] pickle fails with SystemError

Zachary Ware added the comment: This broke test_xpickle with python 2.4 and 2.5 due to 'b' prefixes and an import that's not actually used in the 2.7 patch; now fixed. The ware-gentoo-x86 buildslave now has pythons 2.4, 2.5, and 2.6 installed for test_xpickle to use. -- nosy:

[issue23914] pickle fails with SystemError

Serhiy Storchaka added the comment: Great! I afraid there were no buildbots with 2.4 and 2.5 for testing test_xpickle. Thank you Zachary! -- ___ Python tracker

[issue23914] pickle fails with SystemError

Roundup Robot added the comment: New changeset 322060740b64 by Zachary Ware in branch '2.7': Issue #23914: Fix test_xpickle with python 2.4 and 2.5 https://hg.python.org/cpython/rev/322060740b64 -- ___ Python tracker