[issue25889] Find_BOM accepts a char*, but is passed an unsigned char*; and related usage

Roundup Robot added the comment: New changeset 2481ae1ce35c by Serhiy Storchaka in branch 'default': Issue #25889: Got rid of warning about mixing signed/unsigned char pointers. https://hg.python.org/cpython/rev/2481ae1ce35c -- nosy: +python-dev ___

[issue25893] Second variable DWORD reqdSize in getpythonregpath is initialized but not used

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___

[issue25899] Unnecessary non-ASCII characters in standard library

Chris Angelico added the comment: Whoops! Meant to include that as a second attachment. Now attached. It's a quickly-thrown-together thing and not fully PEP 8 compliant. -- Added file: http://bugs.python.org/file41346/nonascii.py ___ Python tracker

[issue24103] Use after free in xmlparser_setevents (1)

Serhiy Storchaka added the comment: Proposed patch fixes both this issue and issue24104. With the special macro proposed in issue20440 it can be better. -- assignee: -> serhiy.storchaka keywords: +patch stage: needs patch -> patch review versions: +Python 3.6 -Python 3.4 Added file:

[issue25899] Unnecessary non-ASCII characters in standard library

Chris Angelico added the comment: There are non-ASCII dashes and apostrophes in .rst files; are they worth cleaning up? -- ___ Python tracker ___

[issue25899] Unnecessary non-ASCII characters in standard library

Chris Angelico added the comment: Oops, didn't see Victor's comment. (How do I get notified when someone posts a patch review?) New patch uploaded which does this. Note that Steven D'Aprano has expressed the opposite desire - that non-ASCII text be kept, as it should be acceptable and its

[issue25899] Unnecessary non-ASCII characters in standard library

Chris Angelico added the comment: Misc/NEWS has a UTF-8 BOM. Otherwise, it and Misc/HISTORY look fine (all names and other legit cases). Lib/idlelib/CREDITS.txt and Lib/idlelib/README.txt both have non-UTF8 text in them. I don't understand what's with the first line of .bzrignore, so I'm (pun

[issue25899] Unnecessary non-ASCII characters in standard library

Chris Angelico added the comment: Another version of detection script attached. -- Added file: http://bugs.python.org/file41350/nonascii.py ___ Python tracker

[issue25899] Unnecessary non-ASCII characters in standard library

Serhiy Storchaka added the comment: All in Modules/_ctypes/libffi/ is third-party code. The ACUTE ACCENT character at the start of .bzrignore was added in b635462a5798 by Benjamin. I think this is just a typo. The patch LGTM (if address Victor's comment). -- nosy: +benjamin.peterson

[issue25889] Find_BOM accepts a char*, but is passed an unsigned char*; and related usage

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___

[issue25900] unittest ignores the first ctrl-c when it shouldn't

New submission from Marius Gedminas: unittest.signals._InterruptHandler is very nice: on first ^C it tells any registered unittest Result instances to gracefully stop the test run, and on any subsequent ^C it defers to the default interrupt handler, which immediately terminates the test run

[issue25899] Unnecessary non-ASCII characters in standard library

Chris Angelico added the comment: As an alternative to checking only *.py, the second version uses the 'file' command to recognize text files. Run from the cpython top-level directory (rather than Lib/), it finds a large number of additional results, many of which appear to have a UTF-8 BOM.

[issue25899] Unnecessary non-ASCII characters in standard library

Serhiy Storchaka added the comment: In .rst files they are good. Add | (LC_ALL=C egrep "$(printf '[\x80-\xff]+')";) in the pipe after your script to highligh non-ASCII characters. -- ___ Python tracker

[issue25899] Unnecessary non-ASCII characters in standard library

Serhiy Storchaka added the comment: Non-ASCII apostrophes and dashes in docstrings can be considered as a bug, since they can lead pydoc or help() to fail. The patch LGTM. Could you please provide your script used to search non-ASCII sources Chris? Are there doubtful non-ASCII inclusions in

[issue25901] make test crash

New submission from fluyy: I Compile the Python interpreter statically. $ uname -a Linux ubuntu 4.2.0-16-generic #19-Ubuntu SMP Thu Oct 8 15:35:06 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux fluyy@ubuntu:~/tmp/Python-3.5.1$ gcc -v Using built-in specs. COLLECT_GCC=gcc

[issue25899] Unnecessary non-ASCII characters in standard library

Serhiy Storchaka added the comment: I think yes if this is not Windows-specific file. See also 4796dec0a7d0, 7255af1a1c50, a8568ea83599, 652baf23c368. -- ___ Python tracker

[issue25899] Unnecessary non-ASCII characters in standard library

Roundup Robot added the comment: New changeset c87b2f61650f by Serhiy Storchaka in branch '3.5': Issue #25899: Converted non-ASCII characters in docstrings and manpage https://hg.python.org/cpython/rev/c87b2f61650f New changeset 1eeb25f08cfd by Serhiy Storchaka in branch 'default': Issue

[issue25890] PyObject *po in _listdir_windows_no_opendir is initialized but not used

Roundup Robot added the comment: New changeset 3f32bacd353d by Serhiy Storchaka in branch 'default': Issue #25890: Removed yet one unused variable. https://hg.python.org/cpython/rev/3f32bacd353d -- ___ Python tracker

[issue25890] PyObject *po in _listdir_windows_no_opendir is initialized but not used

Serhiy Storchaka added the comment: Thank you Alexander for your reports. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker

[issue25892] PyObject *exc in encode_code_page_strict is initialized but not used

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___

[issue25891] Stray variable meth_idx in enable_symlink

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___

[issue25892] PyObject *exc in encode_code_page_strict is initialized but not used

Roundup Robot added the comment: New changeset 77bd84a6964a by Serhiy Storchaka in branch 'default': Issues #25890, #25891, #25892: Removed unused variables in Windows code. https://hg.python.org/cpython/rev/77bd84a6964a -- nosy: +python-dev ___

[issue25890] PyObject *po in _listdir_windows_no_opendir is initialized but not used

Roundup Robot added the comment: New changeset 77bd84a6964a by Serhiy Storchaka in branch 'default': Issues #25890, #25891, #25892: Removed unused variables in Windows code. https://hg.python.org/cpython/rev/77bd84a6964a -- nosy: +python-dev ___

[issue25891] Stray variable meth_idx in enable_symlink

Roundup Robot added the comment: New changeset 77bd84a6964a by Serhiy Storchaka in branch 'default': Issues #25890, #25891, #25892: Removed unused variables in Windows code. https://hg.python.org/cpython/rev/77bd84a6964a -- nosy: +python-dev ___

[issue25902] Fixed various refcount issues in ElementTree iteration

New submission from Serhiy Storchaka: ElementTree iteration code holds borrowed references when call user code (comparison with the tag, concatenating text and tail lazy lists, testing text and tail for empty). User code can make borrowed references invalid and this can lead to a crash. One

[issue25873] Faster ElementTree iterating

Serhiy Storchaka added the comment: Thank you for your review Martin. I have opened a separate issue25902 for refcount bugs in iteration. Its patch is purposed for all versions, while this issue is for developer version only. -- ___ Python tracker

[issue25899] Unnecessary non-ASCII characters in standard library

Serhiy Storchaka added the comment: > Are there any locale encodings where \x92 isn't an apostrophe? Latin1 and all ISO-8859-*. CP437 and perhaps all DOS codepages. KOI8 family. And of course UTF-8. -- ___ Python tracker

[issue25899] Unnecessary non-ASCII characters in standard library

Chris Angelico added the comment: So Lib/idlelib/README.txt would decode wrongly in anything other than a Windows codepage? Seems a good reason to asciify line 3. -- ___ Python tracker

[issue25903] SUGGESTION: Optimize code in PYO

New submission from Devyn Johnson: I have a suggestion. When Python code is byte-compiled to *.pyo files, what if byte-compiler were to be made to enhance some of the code. For instance, "if type(OBJECT) == int:" would be changed to "if isinstance(OBJECT, int):". Python is used in numerous

[issue25904] SUGGESTION: New Datatypes

New submission from Devyn Johnson: As we all know, Python is sometimes used to computer large numbers and precise numbers (i.e. doubles) with the help of third-party modules. In my opinion, it seems that Python may benefit from gaining new data-types such as "longint" (a "long long" in C) and

[issue25899] Unnecessary non-ASCII characters in standard library

Serhiy Storchaka added the comment: Lib/idlelib/CREDITS.txt and Lib/idlelib/README.txt are read by IDLE. The first with the iso-8859-1 encoding, the second with locale encoding. Both are wrong if files are in UTF-8. -- ___ Python tracker

[issue25899] Unnecessary non-ASCII characters in standard library

Roundup Robot added the comment: New changeset 505593490f4c by Serhiy Storchaka in branch 'default': Issue #25899: Converted Objects/listsort.txt to UTF-8. https://hg.python.org/cpython/rev/505593490f4c -- ___ Python tracker

[issue25899] Unnecessary non-ASCII characters in standard library

Changes by Serhiy Storchaka : -- nosy: +terry.reedy ___ Python tracker ___ ___

[issue25899] Unnecessary non-ASCII characters in standard library

Chris Angelico added the comment: Ah, got it. That definitely settles Idle's CREDITS.txt. Are there any locale encodings where \x92 isn't an apostrophe? -- ___ Python tracker

[issue25898] Check for subsequence inside a sequence

Sebastian Linke added the comment: @Josh What is the point of using iterators here? If the user wants an iterator to be checked then he can throw that iterator right away because it was exhausted by the function. I think that in most cases the user wants to do some postprocessing on a

[issue25905] IDLE fails to display the README file

New submission from Serhiy Storchaka: When open the About IDLE dialog and press the README button on bottom line, I get the UnicodeDecodeError: Exception in Tkinter callback Traceback (most recent call last): File "/home/serhiy/py/cpython/Lib/tkinter/__init__.py", line 1548, in __call__

[issue25899] Unnecessary non-ASCII characters in standard library

Serhiy Storchaka added the comment: Opened issue25905 for IDLE-related files. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker

[issue25782] CPython hangs on error __context__ set to the error itself

Serhiy Storchaka added the comment: And added more comments to your patch. -- ___ Python tracker ___ ___

[issue22908] ZipExtFile in zipfile can be seekable

Daniel Kessel added the comment: It would be great to have the ZipFileExt class seekable. This would help in implementing features in other projects. For example, pydicom would gain the ability to read from ZIP files, as mentioned in https://github.com/darcymason/pydicom/issues/219 --

[issue25903] SUGGESTION: Optimize code in PYO

Emanuel Barry added the comment: *.pyo files have been removed from the language as of 3.5; instead, the optimization is done directly to the *.pyc files. Are you suggesting re-introducing *.pyo files or changing this behaviour in the current model? Also, 'if type(obj) is int' is *not* the

[issue25906] Worker stall in multiprocessing.Pool

New submission from Christian Schou Oxvig: I am experiencing some seemingly random stalls in my scientific simulations that make use of a multiprocessing.Pool for parallelization. It has been incredibly difficult for me to come up with an example that consistently reproduces the problem. It

[issue25782] CPython hangs on error __context__ set to the error itself

Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file41354/set_context_reordering.patch ___ Python tracker ___

[issue25782] CPython hangs on error __context__ set to the error itself

Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file41353/set_context_reordering.patch ___ Python tracker ___

[issue25782] CPython hangs on error __context__ set to the error itself

Serhiy Storchaka added the comment: Here is a patch that illustrates my idea (the documentation could be better). -- Added file: http://bugs.python.org/file41353/set_context_reordering.patch ___ Python tracker

[issue25782] CPython hangs on error __context__ set to the error itself

Yury Selivanov added the comment: > Serhiy Storchaka added the comment: > > The patch LGTM (but I prefer reordering solution). Serhiy, could you please describe your solution in more detail? An elaborate example would help. Perhaps I just misunderstand your idea. And thanks for the review!

[issue25904] SUGGESTION: New Datatypes

Mark Dickinson added the comment: Are you aware that Python's int type is already effectively arbitrary precision? >>> 23**100 14886191506363039393791556586559754231987119653801368686576988209222433278539331352152390143277346804233476592179447310859520222529876001 >>> type(23**100) For the

[issue25773] Deprecate deleting with PyObject_SetAttr, PyObject_SetAttrString and PySequence_SetItem

Serhiy Storchaka added the comment: The conclusion of the discussion is to not deprecate this behavior in the code, but just warn in the documentation. That has done in issue25701. -- resolution: -> rejected stage: patch review -> resolved status: open -> closed

[issue25844] Pylauncher, launcher.c: Assigning NULL to a pointer instead of testing against NULL

Serhiy Storchaka added the comment: To the fix for this bug we have to provoke the unsufficient memory error just at this point. This is unlikely worth. Thank you Alexander for your reports. -- nosy: +serhiy.storchaka resolution: -> fixed stage: test needed -> resolved status: open

[issue25864] collections.abc.Mapping should include a __reversed__ that raises TypeError

R. David Murray added the comment: You can write a patch if you like, but we haven't come to a consensus on actually doing anything. I'm leaning toward Andrew's position, but not strongly, so we need some more core dev opinions. -- ___ Python

[issue25900] unittest ignores the first ctrl-c when it shouldn't

Changes by R. David Murray : -- nosy: +michael.foord, rbcollins ___ Python tracker ___

[issue25903] SUGGESTION: Optimize code in PYO

R. David Murray added the comment: pyo files weren't removed, they were just renamed, and -O differentiated from -OO. The provides the opportunity to introduce additional "optimized byte code" versions that do other optimizations, which several people are working on. There are also other

[issue25856] The __module__ attribute of non-heap classes is not interned

Serhiy Storchaka added the comment: Actually this is not specific to itertools. Every non-heap class not from the builtins module is affected. Proposed patch just interns the __module__ value. The patch also cleans up the code. -- keywords: +patch stage: -> patch review title: The

[issue19771] runpy should check ImportError.name before wrapping it

SilentGhost added the comment: Martin, could you please escape * in Misc/NEWS, it causes a warning when building documentation. -- nosy: +SilentGhost ___ Python tracker

[issue25907] Documentation i18n: Added trans tags in sphinx templates

Changes by Emanuel Barry : -- nosy: +ebarry ___ Python tracker ___ ___ Python-bugs-list

[issue25718] itertools.accumulate __reduce__/__setstate__ bug

Serhiy Storchaka added the comment: What would you say about the patch Kristján? -- ___ Python tracker ___

[issue25898] Check for subsequence inside a sequence

R. David Murray added the comment: If I were trying to channel Raymond I'd suggest posting the python as a recipe and see if there is uptake. However, I could be wrong and he might be interested. (I can't say that I've ever needed this check myself.) I'd be inclined to agree that it should

[issue25907] Documentation i18n: Added trans tags in sphinx templates

New submission from Julien: o/ # Context I'm trying to resuscitate the translation of Python doc in french, [python_doc_fr](https://github.com/AFPy/python_doc_fr). I finished the translation of `tutorial.po` (that was partially translated by the AFPY team around 2012) and now working on

[issue25906] Worker stall in multiprocessing.Pool

Changes by R. David Murray : -- nosy: +davin, sbt ___ Python tracker ___ ___

[issue25846] Use of Py_ARRAY_LENGTH on pointer in posixmodule.c, win32_wchdir

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___

[issue25862] TextIOWrapper assertion failure after read() and SEEK_CUR

Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka stage: -> needs patch ___ Python tracker ___

[issue25908] ProcessPoolExecutor deadlock on KeyboardInterrupt

New submission from Thomas Jackson: If a KeyboardInterrupt is received while a worker process is grabbing an item off of the queue that worker process dies with an uncaught exception. This means that the ProcessPool now has lost a process, and currently has no mechanism to recover from dead

[issue25863] ISO-2022 seeking forgets state

Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka stage: -> needs patch ___ Python tracker ___

[issue25880] u'..'.encode('idna') → UnicodeError: label empty or too long

Serhiy Storchaka added the comment: The bare UnicodeError is raised also by following codecs: utf_16, utf_32, punycode, undefined, and East-Asian multibyte codecs, and by undocumented an unused function urllib.urlparse.to_bytes(). I think it would be nice to be more specific if possible.

[issue25880] u'..'.encode('idna') → UnicodeError: label empty or too long

R. David Murray added the comment: I wonder if we originally only had UnicodeError and it got split later but these codecs were never updated. The codecs date back to the start of unicode support in python2, I think. Adding MAL, he's likely to have an opinion on this ;) Oh, right. The more

[issue25908] ProcessPoolExecutor deadlock on KeyboardInterrupt

Thomas Jackson added the comment: Seems that I accidentally hit submit, so let me finish the last bit of my message here: An alternate approach is to actually change multiprocessing.Queue.get() to leave the item on the queue if it is interrupted with a keyboard interrupt. Then the worker

[issue25898] Check for subsequence inside a sequence

Ethan Furman added the comment: +1 for sequences +1 for subsequence_index instead of has_subsequence +1 for returning None when not found ;) -- nosy: +ethan.furman ___ Python tracker

[issue25860] os.fwalk() silently skips remaining directories when error occurs

Serhiy Storchaka added the comment: LGTM. Here is a patch with tests. -- assignee: -> serhiy.storchaka nosy: +serhiy.storchaka stage: -> patch review versions: +Python 3.6 -Python 3.4 Added file:

[issue1322] Deprecate platform.dist() and platform.linux_distribution() functions

Andy Maier added the comment: Nir, I appreciate very much what you are doing. I was about to do the same ;-) I'll review your code shortly. I like the idea to use /etc/os-release, as it has the most complete information. Stay tuned. Andy Am 6. Dezember 2015 18:12:52 MEZ, schrieb Nir Cohen

[issue25880] u'..'.encode('idna') → UnicodeError: label empty or too long

Marc-Andre Lemburg added the comment: On 18.12.2015 20:25, R. David Murray wrote: > I wonder if we originally only had UnicodeError and it got split later but > these codecs were never updated. The codecs date back to the start of > unicode support in python2, I think. UnicodeDecodeError and

[issue14911] generator.throw() documentation inaccurate

Martin Panter added the comment: This one is based on the public 3.5 branch, so should work. I corrected a small typo made in the previous patch. -- versions: -Python 3.4 Added file: http://bugs.python.org/file41360/throw-3x.v3.patch ___ Python

[issue25904] SUGGESTION: New Datatypes

Changes by Mark Dickinson : -- resolution: -> rejected status: open -> closed ___ Python tracker ___

[issue25903] SUGGESTION: Optimize code in PYO

Chris Angelico added the comment: The trouble with that example is that the semantics aren't the same. The isinstance check will also be true for subclasses of int (for instance, isinstance(True,int) is True), but the equality check will catch only exact matches. And that's even before

[issue12346] Python source code build fails with old mercurial

R. David Murray added the comment: Luke: since this issue is closed, please open a new 2.7 only issue with a reference to this one. -- ___ Python tracker

[issue557704] netrc module can't handle all passwords

R. David Murray added the comment: To clarify: other FTP programs handling passwords with spaces *in the .netrc file*. -- ___ Python tracker ___

[issue557704] netrc module can't handle all passwords

R. David Murray added the comment: This issue was closed because other FTP programs also did not handle passwords with spaces. If this has subsequently changed (passwords with spaces are now widely accepted by other FTP programs) then the issue could be reopened. -- nosy:

[issue19771] runpy should check ImportError.name before wrapping it

Martin Panter added the comment: I think Serhiy just fixed this in revision ed2420379b8d, so it should be okay now. -- ___ Python tracker ___

[issue25864] collections.abc.Mapping should include a __reversed__ that raises TypeError

Terry J. Reedy added the comment: Unless this somehow breaks the philosophy of ABCs, I would be inclined to add the negative methods. -- nosy: +terry.reedy ___ Python tracker

[issue25827] Support ICC in configure

Zachary Ware added the comment: After testing, I think I like '-fp-model strict' better in CFLAGS_NODIST. On Ubuntu, `CC=gcc ./python -m test.test_distutils` passes when the flag is in CFLAGS_NODIST, but fails when it's in BASECFLAGS. On OSX, it fails both ways, due to deployment target

[issue25905] IDLE fails to display the README file

Terry J. Reedy added the comment: Strange and accidental. This is the one line I kept from the old version, before deleting the old and adding the new. I believe I edited either with IDLE or Notepad++, and I would be surprised if the latter, an editor for programmers, would turn ' into ’.

[issue25905] IDLE fails to display the README file

Roundup Robot added the comment: New changeset 11c789c034fe by Terry Jan Reedy in branch '2.7': Issue #25905: Revert unwanted conversion of ' to ’ RIGHT SINGLE QUOTATION MARK. https://hg.python.org/cpython/rev/11c789c034fe New changeset 42963dd81600 by Terry Jan Reedy in branch '3.4': Issue

[issue25905] IDLE fails to display the README file

Terry J. Reedy added the comment: For CREDITS.txt, the only issue is 'Löwis' (ö has latin-1 code 246), which was changed from Loewis in 2003. If not changed back to the ascii form, what matters is that the encoding used for decoding from bytes to unicode matches the actual encoding. AFAIK,

[issue25908] ProcessPoolExecutor deadlock on KeyboardInterrupt

Thomas Jackson added the comment: Some more investigation, it seems that the alternate `Queue` fix is a non-starter. From my investigation it seems that the ProcessPoolExecutor is assuming that multiprocess.Queue is gauranteed delivery, and it isn't (because of the pickling). So the issue is

[issue25589] test_ascii_formatd fails on Mac when built with Intel compiler

Zachary Ware added the comment: This one is officially weird. I can reliably reproduce the segfault in test_ascii_formatd on OSX with ICC 15 or 16, using the included libffi in Modules/_ctypes/libffi_osx. There are also segfaults in test_ctypes, test_multiprocessing, and test_threading (all

[issue22227] Simplify tarfile iterator

Roundup Robot added the comment: New changeset a8f24e26abc7 by Serhiy Storchaka in branch 'default': Issue #7: The TarFile iterator is reimplemented using generator. https://hg.python.org/cpython/rev/a8f24e26abc7 -- nosy: +python-dev ___ Python

[issue22227] Simplify tarfile iterator

Serhiy Storchaka added the comment: Thanks Martin and Raymond for reviews. -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker