[issue4806] Function calls taking a generator as star argument can mask TypeErrors in the generator

Changes by Martin Panter : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue26782] subprocess.__all__ incomplete on Windows

Changes by Martin Panter : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue26554] PC\bdist_wininst\install.c: Missing call to fclose()

Josh Snider added the comment: I suggested some changes to your patch. Your patch should also add your name to the Misc/ACKS file as I don't currently see an Aatish listed there. -- nosy: +Josh Snider ___ Python tracker

[issue26717] wsgiref.simple_server: mojibake with cp1252 bytes in PATH_INFO

Roundup Robot added the comment: New changeset 1f2cfcd5a83f by Martin Panter in branch '3.5': Issue #26717: Stop encoding Latin-1-ized WSGI paths with UTF-8 https://hg.python.org/cpython/rev/1f2cfcd5a83f New changeset 815a4ac67e68 by Martin Panter in branch 'default': Issue #26717: Merge

[issue4806] Function calls taking a generator as star argument can mask TypeErrors in the generator

Roundup Robot added the comment: New changeset eef8f72ddb00 by Martin Panter in branch '2.7': Issue #4806: Avoid masking TypeError when *-unpacking a generator https://hg.python.org/cpython/rev/eef8f72ddb00 -- ___ Python tracker

[issue23883] __all__ lists are incomplete

Changes by Martin Panter : -- dependencies: +subprocess.__all__ incomplete on Windows ___ Python tracker ___

[issue26778] More typo fixes

Martin Panter added the comment: I think there are two outstanding problems; see Lib/tkinter/tix.py and Misc/HISTORY. -- ___ Python tracker ___

[issue26785] repr of -nan value should contain the sign

Eric V. Smith added the comment: Changing versions. I left in 2.7, but I doubt we'd make any changes to 2.7 with regards to this. -- versions: -Python 3.2, Python 3.3 ___ Python tracker

[issue26785] repr of -nan value should contain the sign

Changes by Eric V. Smith : -- nosy: +eric.smith ___ Python tracker ___ ___

[issue26782] subprocess.__all__ incomplete on Windows

Roundup Robot added the comment: New changeset 386712b16c74 by Martin Panter in branch '3.5': Issue #26782: Acknowledge the incomplete status of __all__ in 3.5 https://hg.python.org/cpython/rev/386712b16c74 New changeset 728370e7a29d by Martin Panter in branch 'default': Issue #26782: Merge

[issue26659] slice() leaks memory when part of a cycle

Changes by Martin Panter : -- versions: +Python 3.5 ___ Python tracker ___ ___

[issue26786] bdist_msi duplicates directories with names in ALL CAPS to a bogus location

New submission from Ivan Pozdeev: If a package has directories with names in APP CAPS, distutils.commands.bdist_msi creates properties for them that are also in all caps. Such properties are handled specially by MSI and are called "public properties

[issue26659] slice() leaks memory when part of a cycle

Roundup Robot added the comment: New changeset 879da9400529 by Benjamin Peterson in branch '2.7': add gc support to slice (closes #26659) https://hg.python.org/cpython/rev/879da9400529 New changeset 9e2176d18965 by Benjamin Peterson in branch '3.5': add gc support to slice (closes #26659)

[issue26751] Possible bug in sorting algorithm

Changes by Benjamin Peterson : -- resolution: -> not a bug status: open -> closed ___ Python tracker ___

[issue26571] turtle regression in 3.5

Ellison Marks added the comment: Just as an update, I've been working around this by manually setting TurtleScreen._RUNNING to True before calling Turtle() again, which produces the desired behaviour in both 3.4 and 3.5. Haven't noticed any bad effects so far. --

[issue26780] Illustrate both binary operator conventions in PEP-8

Guido van Rossum added the comment: Patch LGTM. Note that the and/or example was in the PEP before this discussion broke out. The discussion also at some point (before your Knuth quote was discovered) veered in the direction of making and/or a special case, perhaps because it's more likely

[issue19791] test_pathlib should use can_symlink or skip_unless_symlink from test.support

Changes by Berker Peksag : -- nosy: +berker.peksag stage: -> patch review type: behavior -> enhancement versions: +Python 3.6 -Python 3.5 ___ Python tracker

[issue25642] Setting maxsize breaks asyncio.JoinableQueue/Queue

Changes by Berker Peksag : -- stage: -> resolved status: open -> closed type: crash -> behavior ___ Python tracker ___

[issue7694] DeprecationWarnings in distutils are pointless

Berker Peksag added the comment: > [...] I think the DeprecationWarnings in distutils should just be removed, as > they serve no useful purpose. There are no DeprecationWarning warnings (only four PendingDeprecationWarning warnings -- two of them are for 'check_metadata') in distutils

[issue24173] curses HOWTO/implementation disagreement

Berker Peksag added the comment: Thanks for the report! 3.x docs have already been updated. -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed type: -> behavior ___ Python tracker

[issue24173] curses HOWTO/implementation disagreement

Roundup Robot added the comment: New changeset 5c9cda2bdfd2 by Berker Peksag in branch '2.7': Issue #24173: Fix curses.wrapper link in curses HOWTO https://hg.python.org/cpython/rev/5c9cda2bdfd2 -- nosy: +python-dev ___ Python tracker

[issue15933] flaky test in test_datetime

Berker Peksag added the comment: The assert was changed (somewhat similar to issue15933.diff) in bc67e8d39164. I've checked last 18 builds (from 800 to 818) on http://buildbot.python.org/all/builders/x86%20OpenIndiana%203.5 and test_today wasn't one of the failed tests. I'm closing this as

[issue26785] repr of -nan value should contain the sign

Hrvoje Abraham added the comment: Reported issue was created in 64-bit Python 3.5.1 (v3.5.1:37a07cee5969, Dec 6 2015, 01:54:25) [MSC v.1900 64 bit (AMD64)] on win32. Now I noticed that in Py 2.7 even copysign part does not work as expected. Python 2.7.11 (v2.7.11:6d1b6a68f775, Dec 5 2015,

[issue13340] list.index does not accept None as start or stop

Berker Peksag added the comment: See http://thread.gmane.org/gmane.comp.python.devel/127502 for the python-dev thread. -- nosy: +berker.peksag versions: +Python 3.6 -Python 3.4 ___ Python tracker

[issue25989] documentation version switcher is broken fro 2.6, 3.2, 3.3

Berker Peksag added the comment: Thanks for the report, but as I said in the GitHub issue, the version switcher works as expected (we don't build docs of security-only-fix branches). -- nosy: +berker.peksag resolution: -> not a bug stage: -> resolved status: open -> closed

[issue25731] Assigning and deleting __new__ attr on the class does not allow to create instances of this class

Benjamin Peterson added the comment: I believe the correct behavior is actually Traceback (most recent call last): File "", line 1, in File "bar.py", line 7, in C() TypeError: foo.A.__new__(C) is not safe, use foo.B.__new__() This is because A comes before B in the mro, and, indeed,

[issue26781] os.walk max_depth

Serhiy Storchaka added the comment: os.walk() allows more flexible control. for root, dirs, files in os.walk(top): if is_too_deep(root): dirs.clear() continue ... You can even walk up to different depth on different parts of the tree. You can limit

[issue23029] test_warnings produces extra output in quiet mode

Changes by Berker Peksag : -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker

[issue23029] test_warnings produces extra output in quiet mode

Roundup Robot added the comment: New changeset 009e36e6d16d by Berker Peksag in branch '2.7': Issue #23029: Fix catch_warnings() in test_filename_none https://hg.python.org/cpython/rev/009e36e6d16d -- nosy: +python-dev ___ Python tracker

[issue26785] repr of -nan value should contain the sign

Changes by Serhiy Storchaka : -- nosy: +mark.dickinson ___ Python tracker ___ ___

[issue26784] regular expression problem at umlaut handling

Serhiy Storchaka added the comment: Because "[\s\w]*" matches only a part of "Bläh": "Bl\xc3". -- ___ Python tracker ___

[issue26785] repr of -nan value should contain the sign

New submission from Hrvoje Abraham: repr of -nan value should contain the sign so the round-trip could be assured. NaN value sign (bit) could be seen as not relevant or even uninterpretable information, but it is actually used in real-life situations, the fact substantiated by section 6.3 of

[issue26784] regular expression problem at umlaut handling

Marcus added the comment: When I replace the first "ä" with a random letter the untouched expression has not problems to match the second word which contains also an "ä" s = "E-112233-555-11 | Bläh - Bläh" #untuched string s = "E-112233-555-11 | Bloh - Bläh" #string where the first ä is

[issue26781] os.walk max_depth

Changes by Aviv Palivoda : Added file: http://bugs.python.org/file42494/os-walk-max-depth-2.patch ___ Python tracker ___

[issue24922] assertWarnsRegex doesn't allow multiple warning messages

Berker Peksag added the comment: Agreed. Let's close this then. -- nosy: +berker.peksag resolution: -> rejected stage: needs patch -> resolved status: open -> closed ___ Python tracker

[issue26780] Illustrate both binary operator conventions in PEP-8

Changes by Brandon Rhodes : -- type: -> enhancement ___ Python tracker ___ ___

[issue26780] Illustrate both binary operator conventions in PEP-8

Brandon Rhodes added the comment: Another important objection against the current text is that it stacks a series of `and` and `or` operators at the same level of indentation, as though they naturally evaluate in the order the programmer writes them. In fact, they have different levels of

[issue26784] regular expression problem at umlaut handling

Serhiy Storchaka added the comment: Sorry, I don't understand you. If the regex failed to match the first "ä", it can't match the second "ä". Do you have an example? -- ___ Python tracker

[issue24922] assertWarnsRegex doesn't allow multiple warning messages

Serhiy Storchaka added the comment: I think there is a little need for this feature. On other hand, its use looks complicated, and it will likely complicate the implementation. If tested types are same, but messages differ, messages can be combined in on regex: 'msg1|msg2'. If tested types

[issue26784] regular expression problem at umlaut handling

Marcus added the comment: Thx for your explanation. You explained why [\s\w] didn't match for "ä". In my situation it didn't matches for the first "ä" but the second time I used [\s\w] in the same regex it matched at the second "ä". What's the explanation for this? --

[issue26784] regular expression problem at umlaut handling

Serhiy Storchaka added the comment: First, in the context of Python a crash means a core dump or an analogue on Windows. In this case the code just works not as you expected. The short answer: s should be a unicode. In your code "ä" is encoded as 8-bit string '\xc3\xa4'. When matched, every

[issue21274] define PATH_MAX for GNU/Hurd in Python/pythonrun.c

Berker Peksag added the comment: Python 3.4 is in security-fix-only mode so we can close this now. -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker

[issue20739] PEP 463 (except expression) implementation

Changes by Berker Peksag : -- resolution: -> rejected stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue26784] regular expression problem at umlaut handling

Changes by SilentGhost : -- components: +Regular Expressions nosy: +ezio.melotti, mrabarnett, pitrou, serhiy.storchaka ___ Python tracker

[issue26784] regular expression problem at umlaut handling

New submission from Marcus: Working with this example string "E-112233-555-11 | Bläh - Bläh" with the following code leeds under python 2.7.10 (OSX) to an exception whereas the same code works under python 3.5.1 (OSX). s = "E-112233-555-11 | Bläh - Bläh" expr =

[issue24922] assertWarnsRegex doesn't allow multiple warning messages

Changes by Berker Peksag : -- components: +Library (Lib) -Interpreter Core type: behavior -> enhancement versions: -Python 3.5 ___ Python tracker

[issue17859] improve error message for saving ints to file

Changes by Serhiy Storchaka : -- resolution: -> duplicate stage: needs patch -> resolved status: open -> closed superseder: -> add "buffer protocol" to glossary ___ Python tracker

[issue17859] improve error message for saving ints to file

random832 added the comment: This bug should be closed since #16518 was accepted and the error is now "TypeError: a bytes-like object is required, not 'int'" -- nosy: +random832 ___ Python tracker

[issue26781] os.walk max_depth

random832 added the comment: Wouldn't the "symlink infinite loop" case be better handled by making it track where it's already been? This can be done by inode and dev number on Unix; I'm not sure what equivalent exists on Windows (though symlinks are uncommon on Windows) but you could fall

[issue26783] test_os.WalkTests.test_walk_topdown don't test fwalk and Bytes

Roundup Robot added the comment: New changeset e44a2dc62c11 by Serhiy Storchaka in branch '3.5': Issue #26783: test_os.WalkTests.test_walk_topdown did't test fwalk and bytes. https://hg.python.org/cpython/rev/e44a2dc62c11 New changeset be96434b8777 by Serhiy Storchaka in branch 'default': Issue

[issue26783] test_os.WalkTests.test_walk_topdown don't test fwalk and Bytes

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker

[issue26783] test_os.WalkTests.test_walk_topdown don't test fwalk and Bytes

Serhiy Storchaka added the comment: The patch LGTM. Thank you Aviv. -- assignee: -> serhiy.storchaka nosy: +serhiy.storchaka stage: -> commit review type: -> behavior versions: +Python 3.5 ___ Python tracker

[issue10838] subprocess __all__ is incomplete

Martin Panter added the comment: See Issue 26782 for a follow-up with Windows. -- ___ Python tracker ___ ___

[issue26775] Improve test coverage on urllib.parse

Senthil Kumaran added the comment: Thanks for your contribution, Luiz. It's a useful improvement. Committed to all active branches. 2.7 changeset: 101012:e3ed950ad728 -- nosy: +orsenthil resolution: -> fixed stage: -> resolved status: open -> closed versions: +Python 2.7, Python 3.5

[issue26778] More typo fixes

Serhiy Storchaka added the comment: Thank you all for your reviews. Martin's patch LGTM. I agree that it would be safer to not change error messages in bugfix releases. Here is consolidated patch with fixed errors. -- Added file: http://bugs.python.org/file42493/typos2.patch

[issue26775] Improve test coverage on urllib.parse

Roundup Robot added the comment: New changeset 8f02747ff908 by Senthil Kumaran in branch '3.5': issue26775 - Improve test coverage for urllib.parse https://hg.python.org/cpython/rev/8f02747ff908 New changeset 401dca6ac084 by Senthil Kumaran in branch 'default': merge 3.5

[issue26783] test_os.WalkTests.test_walk_topdown don't test fwalk and Bytes

New submission from Aviv Palivoda: test_walk_topdown call os.walk directly instead of using self.walk. This test currently run 3 time's while checking the same thing. The test should use self.walk to check fwalk and Bytes as well. -- components: Tests files:

[issue26782] subprocess.__all__ incomplete on Windows

New submission from Martin Panter: After enabling test__all__() in test_subprocess on Windows (see Issue 10838), I find that STARTUPINFO is missing from __all__, and there is a class Handle that is ambiguous. Handle doesn’t seem to be documented, so I propose to add it to the

[issue26781] os.walk max_depth

New submission from Aviv Palivoda: I am suggesting to add max_depth argument to os.walk. I think this is very useful for two cases. The trivial one is when someone wants to walk on a directory tree up to specific depth. The second one is when you follow symlinks and wish to avoid infinite

[issue26780] Illustrate both binary operator conventions in PEP-8

Changes by Brandon Rhodes : Added file: http://bugs.python.org/file42489/pep8-knuth.patch ___ Python tracker ___

[issue26780] Illustrate both binary operator conventions in PEP-8

Changes by Brandon Rhodes : Removed file: http://bugs.python.org/file42487/pep8-knuth.patch ___ Python tracker ___

[issue26778] More typo fixes

Martin Panter added the comment: Should exception messages be corrected in old versions, or just 3.6? Apart from the few changes with comments, the rest look good to me. I found some more cases (my patch is independent of Serhiy’s). -- Added file:

[issue26780] Illustrate both binary operator conventions in PEP-8

New submission from Brandon Rhodes: I am delighted to see that PEP-8 has pivoted to breaking long formulae before, rather than after, each binary operator! But I would like to pivot the PEP away from citing my own PyCon Canada talk as the authority on the matter, and toward citing Knuth

[issue26779] pdb continue followed by an exception in the same frame shows incorrect frame linenumber

Changes by Senthil Kumaran : -- nosy: +orsenthil ___ Python tracker ___ ___

[issue26779] pdb continue followed by an exception in the same frame shows incorrect frame linenumber

Changes by SilentGhost : -- nosy: +georg.brandl versions: -Python 3.2, Python 3.3, Python 3.4 ___ Python tracker ___

[issue26779] pdb continue followed by an exception in the same frame shows incorrect frame linenumber

New submission from Sriram Rajagopalan: Consider this simple python program - 1 #!/usr/bin/python 2 3 import pdb 4 import sys 5 import traceback 6 7 def trace_exception( type, value, tb ): 8 traceback.print_tb( tb ) 9 pdb.post_mortem( tb ) 10 11 sys.excepthook =

[issue26778] More typo fixes

Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file42485/typos.patch ___ Python tracker ___

[issue26778] More typo fixes

Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file42484/typos.patch ___ Python tracker ___

[issue26778] More typo fixes

New submission from Serhiy Storchaka: Proposed patch fixes a number of typos (mainly about misusing "a/an") in the docs, docstrings, comments and error messages. -- files: typos.patch keywords: patch messages: 263552 nosy: martin.panter, serhiy.storchaka priority: normal severity:

[issue25942] subprocess.call SIGKILLs too liberally

Martin Panter added the comment: I don’t think Victor likes #2 because of the zombie. I would be interested in #4 (one of the documented purposes of subprocess is to replace os.system), but it might need careful consideration and discussion. Ignoring signals is such a significant change I

[issue26777] test_asyncio: test_timeout_disable() fails randomly

New submission from STINNER Victor: On the "AMD64 FreeBSD 9.x 3.5" buildbot, test_timeout_disable() fails randomly. http://buildbot.python.org/all/builders/AMD64%20FreeBSD%209.x%203.5/builds/701/steps/test/logs/stdio == FAIL:

[issue10838] subprocess __all__ is incomplete

Roundup Robot added the comment: New changeset cb38866e4c13 by Martin Panter in branch '3.5': Issue #10838: Run test__all__() everywhere, even if poll() is not available https://hg.python.org/cpython/rev/cb38866e4c13 -- ___ Python tracker

[issue26638] Avoid warnings about missing CLI options when building documentation

Martin Panter added the comment: This patch disables the warning, but I tend to think it is not a good long-term solution. -- Added file: http://bugs.python.org/file42482/disable-warning.patch ___ Python tracker

[issue26638] Avoid warnings about missing CLI options when building documentation

Changes by Martin Panter : Added file: http://bugs.python.org/file42481/doc-warnings.v2.patch ___ Python tracker ___

[issue26638] Avoid warnings about missing CLI options when building documentation

Martin Panter added the comment: I committed the parts of my patch that improve real links in the end result. doc-warnings.v2.patch has the remaining changes which add exclamation marks to mask undefined options. -- ___ Python tracker

[issue26470] Make OpenSSL module compatible with OpenSSL 1.1.0

Bernard Spil added the comment: Checking version numbers to see if a feature is available is a bad practice. How can features ever be removed this way! Would be better to check for the feature itself (using autoconf). The patch was mostly OK but any check for OPENSSL_VERSION_NUMBER for now

[issue26470] Make OpenSSL module compatible with OpenSSL 1.1.0

Bernard Spil added the comment: Testing this patch on HardenedBSD/LibreSSL (base SSL libs replaced with LibreSSL) -- nosy: +spil ___ Python tracker ___

[issue26776] Determining the failure of C API call is ambiguous

STINNER Victor added the comment: Ah yes. Some months (years?) ago, i started to add assertions to fail if some functions are called with an exception set. Checking if an exception is set at runtime adds a low overhead. Maybe it's better to fail with a fatal error (like an assertion error) in

[issue26774] Elide Py_atomic fences when WITH_THREAD is disabled?

STINNER Victor added the comment: I never liked the option to disable thread support. I don't think that anyone uses it but it requires many #ifdef in the code. I would prefer to drop the option. -- ___ Python tracker

[issue26753] Obmalloc lock LOCK_INIT and LOCK_FINI are never used

Larry Hastings added the comment: Oy veh, in editing the issue I dropped the attached file. Here it is. -- keywords: +patch Added file: http://bugs.python.org/file42479/larry.refresh.lock.macros.for.obmalloc.diff ___ Python tracker

[issue26753] Obmalloc lock LOCK_INIT and LOCK_FINI are never used

Larry Hastings added the comment: Patch attached. The basics were okay; however, there was no locking around access to a static variable (_Py_AllocatedBlocks) so I added some. The way the code managed _Py_AllocatedBlocks was a bit odd; this approach resulted in fewer lines, but it was hard

[issue26764] SystemError in bytes.__rmod__

Changes by Serhiy Storchaka : -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue26776] Determining the failure of C API call is ambiguous

New submission from Serhiy Storchaka: C API functions returns a special value unambiguously signaling about a raised exception (NULL or -1). But in some cases this is ambiguous, because the special value is a legitimate value (e.g. -1 for PyLong_AsLong() or NULL for PyDict_GetItem()). Needed

[issue26638] Avoid warnings about missing CLI options when building documentation

Roundup Robot added the comment: New changeset 23a884c32a39 by Martin Panter in branch '3.5': Issue #26638: Fix links to some CLI options and section headings https://hg.python.org/cpython/rev/23a884c32a39 New changeset 68b84643dffd by Martin Panter in branch 'default': Issue #26638: Merge link

[issue26775] Improve test coverage on urllib.parse

New submission from Luiz Poleto: urllib.parse has two methods, parse_qs and parse_qsl to parse a query string and return its parameters/values as a dictionary or a list, respectively. However, the unit tests only tests parse_qsl, which is also incomplete since both parse_qs and parse_qsl