[issue27922] Make IDLE tests less flashy

Xiang Zhang added the comment: After some tries, I think it seems to be caused by the second open in test_open_and_close in SearchDialogBaseTest. The second open calls self.top.deiconify. -- ___ Python tracker

[issue27922] Make IDLE tests less flashy

Xiang Zhang added the comment: Hi Terry, I think this issue may be not completed. While running idlelib test with -ugui, I can sometimes still get a window flash. I think it's due to test_searchbase. Running python -m idlelib.idle_test.test_searchbase can reproduce the flash and adding

[issue27923] PEP 467 -- Minor API improvements for binary sequences

Elias Zamaria added the comment: Martin, where am I supposed to get the patch URL from? Also, is it too soon to issue DeprecationWarnings? Would it be more appropriate if they are PendingDeprecationWarnings instead? -- ___ Python tracker

[issue27918] Running test suites without gui but still having windows flash

Terry J. Reedy added the comment: This issue only addresses and fixes the 1 flash per process from test.support.is_gui_available. I separately added root.withdraw to IDLE tests in #27922, to stop their flashes. Doing the same for tkinter tests would be a third issue. I believe it would be

[issue27918] Running test suites without gui but still having windows flash

Roundup Robot added the comment: New changeset de9e410e78d8 by Terry Jan Reedy in branch '2.7': Issue #27918# test.resource.is_gui_available no longer flashes tk window. https://hg.python.org/cpython/rev/de9e410e78d8 New changeset 756c27efe193 by Terry Jan Reedy in branch '3.5': Issue #27918#

[issue27950] Superfluous messages when running make

Xiang Zhang added the comment: Ohh, it's reasonable. I forgot # means also comments in shell. What a shame. :( But can we make it '@ #...'? Note there is a space. In my editor(Emacs), '@#' will break highlight and highlight it as a command, which is a hurt during reading. You can see it in

[issue21622] ctypes.util incorrectly fails for libraries without DT_SONAME

Martin Panter added the comment: I think it may be reasonable to change the code to return the library file name if no soname can be found. In the long term, I think always returning the filename rather than soname might be reasonable. Or even returning the full path, which we tried in Issue

[issue27951] the reply's additional "Re:" is ok

New submission from Martin Panter: Seif, you will have to give more details or context for people to make sense of this. -- nosy: +martin.panter stage: -> test needed status: open -> pending ___ Python tracker

[issue25825] AIX shared library extension modules installation broken

Changes by Martin Panter : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 2.7 ___ Python tracker

[issue25758] ensurepip/venv broken on Windows if path includes unicode

Steve Dower added the comment: Given a quick read, it looks like issue27781 (PEP 529) will resolve this? Not encoding the path at all is obviously better, but maybe I'll add this as supporting evidence to the PEP... -- ___ Python tracker

[issue27950] Superfluous messages when running make

Martin Panter added the comment: I think @# Comment would be just as good as (and slightly clearer than) @: # Comment They would both invoke the shell. The first has no command and just a shell comment; the second has a no-op command (:) with a comment. Let me know if you agree @# would be

[issue24837] await process.wait() does not work with a new_event_loop

Justin Mayfield added the comment: I agree with Guido. I spent a couple hours trying to debug some of my own code that turned out to be this issue. My use case is single threaded too. Perhaps I'm daft but I don't understand why the child watcher is part of the event loop policy. At first

[issue23591] enum: Add Flags and IntFlags

Vedran Čačić added the comment: > As a side note, I suspect there would be much less confusion with Flag if we > had an AutoEnum. No, there would be _different_ confusion. :-P Anyway, let's get back to the discussion. I am quite aware about what's the intended use, but you can't just assume

[issue27922] Make IDLE tests less flashy

Roundup Robot added the comment: New changeset 6e4475894a79 by Terry Jan Reedy in branch '2.7': Issue #27922: IDLE test_idlehistory no longer flash tk widgets. https://hg.python.org/cpython/rev/6e4475894a79 -- ___ Python tracker

[issue23591] enum: Add Flags and IntFlags

Roundup Robot added the comment: New changeset 8e9d3a5d47d5 by Ethan Furman in branch 'default': issue23591: more docs; slight change to repr https://hg.python.org/cpython/rev/8e9d3a5d47d5 -- ___ Python tracker

[issue27936] Inconsistent round behavior between float and int

Roundup Robot added the comment: New changeset 7108f2a708c9 by Raymond Hettinger in branch '3.5': Issue 27936: Update doc for round() to indicate that None is an allowable argument. https://hg.python.org/cpython/rev/7108f2a708c9 -- ___ Python

[issue25825] AIX shared library extension modules installation broken

David Edelsohn added the comment: I believe that everything is functioning correctly. -- ___ Python tracker ___

[issue26439] ctypes.util.find_library fails when ldconfig/glibc not available (e.g., AIX)

Michael Felt added the comment: Not always as elegant as I would wish (do not like the idea of "while 1:" and later a break... But, all in all, much improved by redoing the processing of the subprocess output and getting rid of more noise. Hope this meets your approval! p.s. This is a patch

[issue23591] enum: Add Flags and IntFlags

Ethan Furman added the comment: As a side note, I suspect there would be much less confusion with Flag if we had an AutoEnum. C'est la vie. -- ___ Python tracker

[issue23591] enum: Add Flags and IntFlags

Ethan Furman added the comment: > All my questions pertain to Flags. Ah, okay. > You said what to me seem like two contradictory things: > >> Not having 2 named has different consequences for Flag vs IntFlag >> (although *neither is an error*): Flag: no combination of flags will >> ever have

[issue27497] csv module: Add return value to DictWriter.writeheader

Ashish Nitin Patil added the comment: Also, I noticed in the documentation for `csv.DictWriter` (https://docs.python.org/3/library/csv.html#csv.DictWriter.writeheader) does not contain the following line - to the writer's file object, formatted according to the current dialect. Although

[issue27497] csv module: Add return value to DictWriter.writeheader

Ashish Nitin Patil added the comment: Hi, I have added the "return" to the writeheader method. I ran the tests for the csv library (./python -m test -v test_csv) and got no errors (Ran 101 tests in 0.322s; 1 test OK.). Kindly review the patch. -- keywords: +patch nosy:

[issue9351] argparse set_defaults on subcommands should override top level set_defaults

Changes by paul j3 : -- Removed message: http://bugs.python.org/msg274336 ___ Python tracker ___

[issue9351] argparse set_defaults on subcommands should override top level set_defaults

paul j3 added the comment: In http://bugs.python.org/issue27859 I've demonstrated how a subclass of _SubParsersAction can be used to revert the behavior to pre 2.7.9, passing the main namespace to the subparser. The only other change is to the parser registry: parser.register('action',

[issue27859] argparse - subparsers does not retain namespace

paul j3 added the comment: I've posted a file that runs your code as you expect. It uses a custom Action class (like your test case). It subclasses ._SubParsersAction, and replaces the 9351 namespace use with the original one. I use the registry to change the class that

[issue19500] Add client-side SSL session resumption

Changes by Christian Heimes : -- nosy: +alex stage: -> patch review title: Error when connecting to FTPS servers not supporting SSL session resuming -> Add client-side SSL session resumption type: behavior -> enhancement ___

[issue19500] Error when connecting to FTPS servers not supporting SSL session resuming

Christian Heimes added the comment: Here is my take on the SSLSession feature. The patch provides a SSLSession type, SSLSocket.session getter/setter and SSLSocket.session_reused getter. The setter makes sure that the session can only set for client sockets from the same SSLContext and before

[issue27928] Add hashlib.scrypt

Changes by Christian Heimes : Added file: http://bugs.python.org/file44361/Add-hashlib.scrypt-4.patch ___ Python tracker ___

[issue27954] makesetup does not take into account subdirectories

New submission from David D: https://hg.python.org/cpython/file/tip/Modules/makesetup#l202 If I try to create a built-in module with a source file named exactly as another source file that already exists in a different module, the script generates the same output path for the object files,

[issue26470] Make OpenSSL module compatible with OpenSSL 1.1.0

Changes by Christian Heimes : Added file: http://bugs.python.org/file44360/Port-Python-s-SSL-module-to-OpenSSL-1.1.0-5.patch ___ Python tracker

[issue27744] Add AF_ALG (Linux Kernel crypto) to socket module

Christian Heimes added the comment: I have removed binascii.(un)hexlify(). -- Added file: http://bugs.python.org/file44359/AF_ALG-kernel-crypto-support-for-socket-module-5.patch ___ Python tracker

[issue26798] add BLAKE2 to hashlib

Christian Heimes added the comment: Thanks for your review. I have addressed your points and updated/fixed/renamed documentation and comments. -- Added file: http://bugs.python.org/file44358/BLAKE2-hash-algorithm-for-CPython-5.patch ___ Python

[issue26798] add BLAKE2 to hashlib

Martin Panter added the comment: Maybe call the RST file hashlib-blake2.rst (hyphen, not dot), otherwise it looks like it is a separate submodule under the hashlib package. Also there seems to be a versionadded tag missing in the documentation. In setup.py, the os.uname().machine check seems

[issue27950] Superfluous messages when running make

Xiang Zhang added the comment: After more study, I think we can do just as what I have pointed out as the problem, ': #...". This can make us have an indent comment that won't be evaluated by the shell. And we only need to add @ before it so it won't be echoed. As for the part you comment,

[issue21622] ctypes.util incorrectly fails for libraries without DT_SONAME

Thom Wiggers added the comment: This bug is still present in Python 3.5. It breaks, probably among other things, this package: https://github.com/ahupp/python-magic/issues/114. -- nosy: +twiggers versions: +Python 3.5 ___ Python tracker

[issue27919] Deprecate and remove extra_path distribution kwarg

Jason R. Coombs added the comment: I've done more work breaking down the findings: pygoogle (7): All forks of a project of the same name. Ignorable since the name matches the project name. cancelbot (3): All forks of a project of the same name. Ignorable since the name matches the project

[issue27953] math.tan has poor accuracy near pi/2 on OS X Tiger

Changes by Mark Dickinson : -- title: tan has poor accuracy near pi/2 on OS X Tiger -> math.tan has poor accuracy near pi/2 on OS X Tiger ___ Python tracker

[issue26470] Make OpenSSL module compatible with OpenSSL 1.1.0

Christian Heimes added the comment: Antoine, I have reconsidered your idea. Let's make the default value PROTOCOL_TLS in 3.6 and deprecated the other protocol methods. We can remove them in 3.8 or 3.9. I'll push another patch later today. -- ___

[issue27928] Add hashlib.scrypt

Christian Heimes added the comment: Thanks Alex, multiple is the wrong term. The argument 'n' must be 2^m for m > 1. -- ___ Python tracker ___

[issue27427] Add new math module tests

Roundup Robot added the comment: New changeset d7c31c73b1bd by Mark Dickinson in branch 'default': Add Francisco Couzo to Misc/ACKS (for issue #27427 patch). https://hg.python.org/cpython/rev/d7c31c73b1bd -- ___ Python tracker

[issue27427] Add new math module tests

Mark Dickinson added the comment: Applied. Thank you, Francisco! -- components: +Extension Modules -Tests resolution: -> fixed stage: -> resolved status: open -> closed type: -> enhancement ___ Python tracker

[issue27427] Add new math module tests

Roundup Robot added the comment: New changeset eb98f6044638 by Mark Dickinson in branch 'default': Issue #27427: Additional tests for the math module. Thanks Francisco Couzo. https://hg.python.org/cpython/rev/eb98f6044638 -- nosy: +python-dev ___

[issue26439] ctypes.util.find_library fails when ldconfig/glibc not available (e.g., AIX)

Michael Felt added the comment: On 04/09/2016 06:11, Martin Panter wrote: > I do not know whether to fix the annotation (has 64 preceded by any number of > underscores), or whether to fix the regular expression (_?64). The later - _?64. Working on this today. Thank you for the correction.

[issue27953] tan has poor accuracy near pi/2 on OS X Tiger

Mark Dickinson added the comment: The relevant tests are now skipped on OS X < 10.5, and test_math and test_cmath are passing on the OS X Tiger buildbot. Closing (as "wont fix", since we haven't actually fixed the underlying issue). -- resolution: -> wont fix stage: -> resolved

[issue27953] tan has poor accuracy near pi/2 on OS X Tiger

Roundup Robot added the comment: New changeset b4d52df5595e by Mark Dickinson in branch 'default': Issue #27953: skip failing math and cmath tests for tan on OS X 10.4. https://hg.python.org/cpython/rev/b4d52df5595e -- nosy: +python-dev ___ Python

[issue26040] Improve coverage and rigour of test.test_math

Mark Dickinson added the comment: Opened #27953 to track the issue with tan on OS X Tiger. Re-closing here. -- status: open -> closed ___ Python tracker

[issue27953] tan has poor accuracy near pi/2 on OS X Tiger

New submission from Mark Dickinson: Opening this for the record; I intend to close as "wont fix". The tan function has poor accuracy for inputs near pi/2 on OS X 10.4. This is a direct consequence of a poor libm implementation, so there's little we can do about it short of re-implenting tan

[issue27450] bz2: BZ2File should expose compression level as an attribute

Josh Triplett added the comment: As part of a reproducible build project, to allow recompressing a file with the same compression level previously used. -- ___ Python tracker

[issue27450] bz2: BZ2File should expose compression level as an attribute

Martin Panter added the comment: I guess the compression level you want is the same as the 100–900 kB block size recorded as the third byte in the header. But I don’t see this as a particularly useful feature either. Why do you want to know the compression level? --

[issue27800] Regular expressions with multiple repeat codes

Serhiy Storchaka added the comment: LGTM. Thanks Martin. -- nosy: +serhiy.storchaka ___ Python tracker ___

[issue26040] Improve coverage and rigour of test.test_math

Mark Dickinson added the comment: > or at least, no more unhappy than before Not quite true: test_math and test_cmath are failing for the x86 Tiger 3.x buildbot: == FAIL: test_testfile (test.test_math.MathTests)

[issue27078] Make f'' strings faster than .format: BUILD_STRING opcode?

Antti Haapala added the comment: Though it is clean to do like this: let _PyUnicode_JoinArray have `NULL` mean empty string, as it is more logical anyway; then PyUnicode_Join itself just needs to: if (separator == NULL) { separator = PyUnicode_FromOrdinal(' '); /* check

[issue27800] Regular expressions with multiple repeat codes

Martin Panter added the comment: Here is a patch for the documentation. -- keywords: +patch stage: -> patch review Added file: http://bugs.python.org/file44356/multiple-repeat.patch ___ Python tracker

[issue23591] enum: Add Flags and IntFlags

Vedran Čačić added the comment: Ok, I believe you that you have the interface for IntFlags right (I always did, and I apologize if I didn't make it clear from the start). All my questions pertain to Flags. You said what to me seem like two contradictory things: > Not having 2 named has

[issue27950] Superfluous messages when running make

Xiang Zhang added the comment: That is not ideal. @# can silence the comment but actually it is still not a comment. The "# ..." part still will be evaluated by shell. -- ___ Python tracker

[issue27952] Finish converting fixcid.py from regex to re

New submission from Serhiy Storchaka: Tools/scripts/fixcid.py initially used old regex module. In 4727f260f6f8 it was converted to using new re module, but not all generated regular expressions were converted to new syntax. The script is not working since that time. -- components: