[issue28662] catch also PermissionError in tests when spawning a non existent program

Serhiy Storchaka added the comment: LGTM. -- assignee: -> xdegaye nosy: +serhiy.storchaka stage: patch review -> commit review ___ Python tracker ___

[issue28654] sys.stdout.isatty() returns True even if redirected to NUL

Kuno Meyer added the comment: 2) Yes, it should be `> /dev/null` instead of `> /dev/nul` (my bad). The output remains the same. -- ___ Python tracker

[issue26786] bdist_msi duplicates directories with names in ALL CAPS to a bogus location

Changes by Ivan Pozdeev : Removed file: http://bugs.python.org/file42496/bdist_msi.patch ___ Python tracker ___

[issue26786] bdist_msi duplicates directories with names in ALL CAPS to a bogus location

Changes by Ivan Pozdeev : Added file: http://bugs.python.org/file45437/bdist_msi.patch ___ Python tracker ___

[issue28661] Fix code example in Python 3.5 telnetlib documentation

Ivan Tomilov added the comment: I see, thanks for the clarification. But in my OS X the things are different and I spent about 1 hour trying this code to take off. Maybe it's better to change this code to avoid spending time for such subtle bugs? Say: tn.read_until(b"Password:") tn.read_eager()

[issue23839] Clear caches after every test

Raymond Hettinger added the comment: LGTM. -- nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list

[issue21145] Add the @cached_property decorator

Changes by Raymond Hettinger : -- nosy: +ncoghlan ___ Python tracker ___ ___

[issue28638] Creating namedtuple is too slow to be used in common stdlib (e.g. functools)

Raymond Hettinger added the comment: Thanks Nick. I'm going to mark this as closed, as the proposal to microscopic to warrant incurring technical debt. If someone comes forward with more fully formed idea for code generation or overall structural enchancement, that can be put in another

[issue28638] Creating namedtuple is too slow to be used in common stdlib (e.g. functools)

Nick Coghlan added the comment: I'll echo Raymond's concerns here, as we simply don't have the collective maintenance capacity to sustain a plethora of special case micro-optimisations aimed at avoiding importing common standard library modules. I will note however, that there has been

[issue28637] Python startup performance regression

Guido van Rossum added the comment: I think it's okay to add `enum` back into `re`. -- ___ Python tracker ___

[issue28637] Python startup performance regression

Ethan Furman added the comment: Leaving `re` out of site.py is fine; the current question is whether to add `enum` back to `re`. -- ___ Python tracker

[issue28618] Decorate hot functions using __attribute__((hot)) to optimize Python

STINNER Victor added the comment: I tried different patches and ran many quick & dirty benchmarks. I tried to use likely/unlikely macros (using GCC __builtin__expect): the effect is not significant on call_simple microbenchmark. I gave up on this part. __attribute__((hot)) on a few Python

[issue28658] MacOsX idle don't run

Changes by Andrew Kontokanis : -- nosy: +ned.deily ___ Python tracker ___ ___

[issue28618] Decorate hot functions using __attribute__((hot)) to optimize Python

Roundup Robot added the comment: New changeset 59b91b4e9506 by Victor Stinner in branch 'default': Issue #28618: Make hot functions using __attribute__((hot)) https://hg.python.org/cpython/rev/59b91b4e9506 -- nosy: +python-dev ___ Python tracker

[issue27854] Installed 2.7: IDLE Help disabled because help.html is missing

Terry J. Reedy added the comment: Does attached file look correct? -- keywords: +patch stage: -> commit review Added file: http://bugs.python.org/file45436/add_idle_help.diff ___ Python tracker

[issue25507] IDLE: user code 'import tkinter; tkinter.font' should fail

Changes by Terry J. Reedy : -- status: open -> closed ___ Python tracker ___ ___

[issue25507] IDLE: user code 'import tkinter; tkinter.font' should fail

Terry J. Reedy added the comment: Import is only needed for the warning issued when someone using IDLE 2.x puts a non-ascii character into code being edited and tries to save without adding an encoding declaration.

[issue25507] IDLE: user code 'import tkinter; tkinter.font' should fail

Roundup Robot added the comment: New changeset 137c7b92360e by Terry Jan Reedy in branch '2.7': Issue #25507: Add back import needed for 2.x encoding warning box. https://hg.python.org/cpython/rev/137c7b92360e -- status: pending -> open ___ Python

[issue28637] Python startup performance regression

STINNER Victor added the comment: Oh nice, python_startup benchmark at Nov 10 (rev at 8ebaa546a033) is now faster than python_startup at Feb 29 (rev dfeadfb4c8cc): new 16.8 ms, old 19.5. And it's much before when I opened the issue: 26.6 ms. Thanks.

[issue28662] catch also PermissionError in tests when spawning a non existent program

New submission from Xavier de Gaye: This is yet another idiosyncrasy of Android, the /sbin directory is in the $PATH of the adb shell used for running the tests on the emulator or on a device connected with usb to the build platform, and /sbin is readable and searchable only by root. For a

[issue28591] imghdr doesn't recognize some jpeg formats

Raul added the comment: New patch for imghdr bug, including unittets. This patch works on python 2.7 -- Added file: http://bugs.python.org/file45434/imghdr_py27.patch ___ Python tracker

[issue28661] Fix code example in Python 3.5 telnetlib documentation

R. David Murray added the comment: Well, the example code is correct for a typical telnet service running on a unix variant. That will output a space after the colon, so that the user's input is separated from the colon when they start to type. -- nosy: +r.david.murray

[issue28635] Update What's New for 3.6

Alexander Belopolsky added the comment: I spotted a small typo in the "PEP 495: Local Time Disambiguation" section: "The values of the fold attribute have the value 0 all instances ..." should be "The values of the fold attribute have the value 0 *for* all instances ..." -- nosy:

[issue21145] Add the @cached_property decorator

Carl Meyer added the comment: How do you propose that slots should be supported? Part of the value of cached_property is that cached access is a normal Python attribute access with no function call overhead. I am not interested in adding support for slots if it loses that benefit. I would not

[issue28591] imghdr doesn't recognize some jpeg formats

Raul added the comment: The issue16512 don't solve the problem, note how the patch it provide fails to detect all the valid JPEG images attached in this issue. -- ___ Python tracker

[issue28591] imghdr doesn't recognize some jpeg formats

Raul added the comment: Image used in the unit-tests of previous patch. Add it under Lib/test/imghdrdata/python1.jpg -- Added file: http://bugs.python.org/file45433/python1.jpg ___ Python tracker

[issue28591] imghdr doesn't recognize some jpeg formats

Raul added the comment: New patch for imghdr bug, including unittets. This patch works on python 3.x -- Added file: http://bugs.python.org/file45432/imghdr_py3.patch ___ Python tracker

[issue28638] Creating namedtuple is too slow to be used in common stdlib (e.g. functools)

Raymond Hettinger added the comment: > half a millisecond is reduced. I would like to caution against any significant changes to save microscopic amounts of time. Twisting the code into knots for minor time savings is rarely worth it and it not what Python is all about. > Half milliseconds

[issue21145] Add the @cached_property decorator

Serhiy Storchaka added the comment: The decorator should support classes with __slots__. -- ___ Python tracker ___

[issue21145] Add the @cached_property decorator

Carl Meyer added the comment: Attaching a patch with the simplest version of cached_property (tehnique is not original, similar code is found in Django, Bottle, Flask, the cached_property lib, and many other places). -- components: +Library (Lib) keywords: +patch versions: +Python 3.7

[issue28644] Document recent changes in typing.py

Changes by Guido van Rossum : -- title: Document recen changes in typing.py -> Document recent changes in typing.py ___ Python tracker

[issue28635] Update What's New for 3.6

Roundup Robot added the comment: New changeset 4c81a107ccab by Yury Selivanov in branch '3.6': Issue #28635: what's new in 3.6: remove mentions of backported fixes. https://hg.python.org/cpython/rev/4c81a107ccab New changeset 8ebaa546a033 by Yury Selivanov in branch 'default': Merge 3.6 (issue

[issue28635] Update What's New for 3.6

Elvis Pranskevichus added the comment: Thanks Serhiy. I removed mentions of things that were indeed fixes backported to 3.5. Other issue references are valid news, including new features to provisional modules backported to 3.5. It is customary to include these in the news for the major

[issue28635] Update What's New for 3.6

Serhiy Storchaka added the comment: +The disassembler now decodes ``FORMAT_VALUE`` argument. +(Contributed by Serhiy Storchaka in :issue:`28317`.) FORMAT_VALUE is new in 3.6. This change should be considered as a part of PEP 498 and is not deserve special mentioning. --

[issue27973] urllib.urlretrieve() fails on second ftp transfer

Changes by Senthil Kumaran : -- assignee: -> orsenthil ___ Python tracker ___ ___

[issue27973] urllib.urlretrieve() fails on second ftp transfer

Sohaib Ahmad added the comment: @Senthil, thanks for looking into this. Looking forward to your commit. Regards. -- ___ Python tracker ___

[issue28661] Fix code example in Python 3.5 telnetlib documentation

New submission from Ivan Tomilov: The code sample on page https://docs.python.org/3/library/telnetlib.html is a little confusing. The extra space in string "Password: " before the second quote basically hangs the example program when you try to run it. Please, check my answer on Stack

[issue28635] Update What's New for 3.6

Serhiy Storchaka added the comment: Patches for following issues was applied in 3.5. They may be bug fixes, not new features. #13248 #16113 #20476 #22115 #23517 #24764 #25590 #25593 #25913 #26470 #26733 #26754 #26801 #27040 #27041 #27243 #27392 #27598 #27691 #27766 #27850 #27932 #28370

[issue21145] Add the @cached_property decorator

Carl Meyer added the comment: I've used the cached_property pattern across many different projects, and never yet wanted a TTL. The simple "cache for the lifetime of the instance" behavior is easy to implement, easy to understand, and useful for a wide range of scenarios where instances are

[issue557704] netrc module can't handle all passwords

Cristian Măgherușan-Stanciu added the comment: Is there anything blocking this from being really fixed? It's still broken on 3.5. The patch added two years ago works well for quoted passwords, I think that's good enough, anyway having some support is much better than the current out of the

[issue28635] Update What's New for 3.6

Roundup Robot added the comment: New changeset c0060567f35d by Yury Selivanov in branch '3.6': Issue #28635: What's New in Python 3.6 updates https://hg.python.org/cpython/rev/c0060567f35d New changeset 69bdf8bdfd61 by Yury Selivanov in branch 'default': Merge 3.6 (issue #28635)

[issue28635] Update What's New for 3.6

Roundup Robot added the comment: New changeset bcd4ab982429 by Yury Selivanov in branch '3.6': Issue #28635: Fix a couple of missing/incorrect versionchanged tags https://hg.python.org/cpython/rev/bcd4ab982429 New changeset 5c4ce500dd35 by Yury Selivanov in branch 'default': Merge 3.6 (issue

[issue28641] Describe PEP 495 features in "What's New in Python 3.6" document

Yury Selivanov added the comment: Closing this one. -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed type: -> enhancement ___ Python tracker

[issue28635] Update What's New for 3.6

Elvis Pranskevichus added the comment: Attached patch for another pass on what's new. -- ___ Python tracker ___

[issue28635] Update What's New for 3.6

Changes by Elvis Pranskevichus : Added file: http://bugs.python.org/file45428/0001-Issue-28635-Fix-a-couple-of-missing-incorrect-versio.patch ___ Python tracker

[issue28641] Describe PEP 495 features in "What's New in Python 3.6" document

Elvis Pranskevichus added the comment: This should now be covered in #28635. -- ___ Python tracker ___ ___

[issue28635] Update What's New for 3.6

Changes by Elvis Pranskevichus : Added file: http://bugs.python.org/file45429/0002-Issue-28635-What-s-New-in-Python-3.6-updates.patch ___ Python tracker

[issue25658] PyThread assumes pthread_key_t is an integer, which is against POSIX

Masayuki Yamamoto added the comment: On, I got complex type in cloudABI. I see my patch doesn't solve it. https://github.com/NuxiNL/cloudlibc/blob/master/src/include/sys/types.h#L94 https://github.com/NuxiNL/cloudlibc/blob/master/src/include/_/types.h#L209 --

[issue28660] TextWrapper break_long_words=True, break_on_hyphens=True on long words

Changes by Serhiy Storchaka : -- components: +Library (Lib) nosy: +georg.brandl, serhiy.storchaka type: -> behavior versions: +Python 3.5, Python 3.6, Python 3.7 ___ Python tracker

[issue28656] build error in cygwin64 ,because pthread_key_t

Changes by Serhiy Storchaka : -- resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> PyThread assumes pthread_key_t is an integer, which is against POSIX ___ Python tracker

[issue25658] PyThread assumes pthread_key_t is an integer, which is against POSIX

Ed Schouten added the comment: CloudABI uses a structure type, which is exactly why I filed this bug report. Instead of speculating about what kind of type existing implementations use, please just focus on the specification to which we're trying to stick: POSIX.

[issue25658] PyThread assumes pthread_key_t is an integer, which is against POSIX

Masayuki Yamamoto added the comment: Umm, API seems a design that is passing into function by integer or pointer because the users don't need type detail. I think the implementation of complex type is not realistic. Actually, CouldABI and Cygwin are used pointer, and type detail is hided.

[issue28649] refleak in typing.py

Ivan Levkivskyi added the comment: I think tearDown() is not necessary. But on the other hand it could be nice to have a method in tests to force cache clear. I would propose it not as a default, but as an opt-in to check that cache works well, or that a certain tested feature is "cache

[issue28649] refleak in typing.py

Guido van Rossum added the comment: BTW, do we still want the tearDown()? Or is that no longer necessary? -- ___ Python tracker ___

[issue28660] TextWrapper break_long_words=True, break_on_hyphens=True on long words

New submission from Peter: Quoting https://docs.python.org/2/library/textwrap.html width (default: 70) The maximum length of wrapped lines. As long as there are no individual words in the input text longer than width, TextWrapper guarantees that no output line will be longer than width

[issue28649] refleak in typing.py

Yury Selivanov added the comment: Thank you Guido and Ivan! > Yury, when you're happy with the situation can you close this issue? I'll close it now, will reopen if something comes up. -- resolution: -> fixed status: open -> closed ___ Python

[issue28649] refleak in typing.py

Guido van Rossum added the comment: Thanks a bundle, Ivan! I've merged those two into CPython 3.5, 3.6, 3.7. We can now watch the build bots for a while and double-check the refleaks. Yury, when you're happy with the situation can you close this issue? --

[issue28649] refleak in typing.py

Roundup Robot added the comment: New changeset 555f0ca31587 by Guido van Rossum in branch '3.5': Issue #28649: fix second issue with _ForwardRef (#328) https://hg.python.org/cpython/rev/555f0ca31587 New changeset 0f863906cf2e by Guido van Rossum in branch '3.6': Issue #28649: fix second issue

[issue28649] refleak in typing.py

Roundup Robot added the comment: New changeset 0da2e381ad71 by Guido van Rossum in branch '3.5': Issue #28649: fix first issue with _ForwardRef (#327) https://hg.python.org/cpython/rev/0da2e381ad71 New changeset 249a1f0b2857 by Guido van Rossum in branch '3.6': Issue #28649: fix first issue

[issue28659] xml.etree.cElementTree.write misses opening tag

Xiang Zhang added the comment: is an empty tag. It closes it self, not '/>'. With some content, you can see it has start and end tag. >>> import xml.etree.cElementTree as ET >>> events = ET.Element('Events') >>> events.text = 'abc' >>> tree = ET.ElementTree(events) >>>

[issue28659] xml.etree.cElementTree.write misses opening tag

Xiang Zhang added the comment: s/not/note -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue28659] xml.etree.cElementTree.write misses opening tag

New submission from Stelios: import xml.etree.cElementTree as ET events = ET.Element('Events') tree = ET.ElementTree(events) tree.write('test.xml', xml_declaration=True, encoding='UTF-8') writes to file: Where opening tag is missing Python version: Python 3.5.2 -- components: XML

[issue28649] refleak in typing.py

Guido van Rossum added the comment: We discussed cache size previously and 128 is fine. --Guido (mobile) -- ___ Python tracker ___

[issue25658] PyThread assumes pthread_key_t is an integer, which is against POSIX

Ed Schouten added the comment: It can also be a structure or a union. -- ___ Python tracker ___ ___

[issue28649] refleak in typing.py

Yury Selivanov added the comment: Good work, Ivan! > Those two seem to fix everything, I tried various cache sizes with both C and > Python versions of lru_cache and found no refleaks. Speaking of lru_cache: typing currently doesn't configure maxsize, which means that the cache is limited to

[issue25658] PyThread assumes pthread_key_t is an integer, which is against POSIX

Masayuki Yamamoto added the comment: Hi, I came from #28656. I have read past discussions, And I've understood the pthread_key_t has possible of either integer or pointer. So I think there is a simple solution that replaces key type to intptr_t. Thus I wrote a patch, but it maybe need

[issue24329] __qualname__ and __slots__

Serhiy Storchaka added the comment: __qualname__ doesn't makes much sense if it doesn't match __module__. If _GeneratorWrapper patches __qualname__, I think it should patch __module__ too. -- ___ Python tracker

[issue28658] MacOsX idle don't run

New submission from Andrew Kontokanis: When I try and launch IDLE, the icon appears on the dock for a second and then disappears and the application doesn't run. I was trying to install new themes but when I managed to do find .idlerc folder I had messed up with some idle folder. I tried to

[issue24329] __qualname__ and __slots__

Changes by Antoine Pitrou : -- nosy: -pitrou ___ Python tracker ___ ___ Python-bugs-list

[issue28654] sys.stdout.isatty() returns True even if redirected to NUL

Марк Коренберг added the comment: 1. I think, that is not a bug. 2. It seems, that for Cygwin, `> /dev/nul` is a bug, it should be `/dev/null` does not it ? -- nosy: +mmarkk ___ Python tracker

[issue24329] __qualname__ and __slots__

Xiang Zhang added the comment: slots_special_v2 fixes a bug in the previous patch. -- Added file: http://bugs.python.org/file45425/slots_special_v2.patch ___ Python tracker

[issue28644] Document recen changes in typing.py

Ivan Levkivskyi added the comment: Guido, here is a new patch with your comments implemented. -- Added file: http://bugs.python.org/file45424/recent-typing-docs-v4.diff ___ Python tracker

[issue24329] __qualname__ and __slots__

Xiang Zhang added the comment: > What about other names set when creating a class? __module__, __class__, > __classcell__? __module__ remains in the class dict so I think it's a class variable. Will __class__ be set? It's inserted into the function scope. __classcell__ I think has the same

[issue28654] sys.stdout.isatty() returns True even if redirected to NUL

Kuno Meyer added the comment: http://stackoverflow.com/questions/3648711/detect-nul-file-descriptor-isatty-is-bogus, although a bit convoluted, might also help. It mentions GetConsoleMode() for stdin and GetConsoleScreenBufferInfo() for stdout. --

[issue28656] build error in cygwin64 ,because pthread_key_t

Serhiy Storchaka added the comment: See also issue25658. -- nosy: +serhiy.storchaka ___ Python tracker ___

[issue28657] cmd.Cmd.get_help() implementation can't see do_*() methods added dynamically by setattr()

New submission from Błażej Michalik: The issue here seems to originate from the implementation of Cmd.get_names(): def get_names(self): # This method used to pull in base class attributes # at a time dir() didn't do it yet.

[issue28649] refleak in typing.py

Ivan Levkivskyi added the comment: OK, here are the PRs: https://github.com/python/typing/pull/327 https://github.com/python/typing/pull/328 Those two seem to fix everything, I tried various cache sizes with both C and Python versions of lru_cache and found no refleaks. --

[issue19398] test_trace fails with -S

Serhiy Storchaka added the comment: The separator is needed if the relative path is not empty and the prefix doesn't end with the separator. This patch seems also fixes most problems of issue28655. -- assignee: -> serhiy.storchaka nosy: +serhiy.storchaka versions: +Python 3.5, Python

[issue28656] build error in cygwin64 ,because pthread_key_t

New submission from muzhong: ENV: CYGWIN_NT-6.1 2.6.0(0.304/5/3) 2016-08-31 14:32 x86_64 Cygwin gcc (GCC) 5.4.0 g++ (GCC) 5.4.0 Error Msg: Fatal Python error: Could not allocate TLS entry Cause: /usr/include/machine/types.h:typedef struct __pthread_key_t {char __dummy;}

[issue28654] sys.stdout.isatty() returns True even if redirected to NUL

Eryk Sun added the comment: Windows doesn't have terminal devices, so the C runtime's isatty() function just checks for a character device, which includes NUL among others. This can lead to hanging the REPL, albeit with a contrived example such as redirecting stdin to COM3: C:\>python <

[issue28655] Tests altered the execution environment in isolated mode

New submission from Serhiy Storchaka: Following tests altered the execution environment in isolated mode: test_asyncio test_ctypes test_email test_idle test_import test_importlib test_json test_lib2to3 $ ./python -I -S -m test.regrtest -vv test_asyncio test_ctypes test_email test_idle

[issue28649] refleak in typing.py

Ivan Levkivskyi added the comment: > BTW, if I set maxsize=10 for typing lru_cache, test_generic_forward_ref > crashes in refleak-test mode. Maybe this is another bug... This one is also related to the mentioned in my previous message. Namely, forward references are only evaluated once.

[issue24329] __qualname__ and __slots__

Changes by Xiang Zhang : Added file: http://bugs.python.org/file45421/slots_qualname_v2.patch ___ Python tracker ___

[issue28016] test_fileio fails on AIX

Matthieu S added the comment: Sorry for the late reply. I did some additional testing, and I can confirm that this assertion should also be skipped in Python 2.7 on AIX. And the test does not fail when run without a tty, so we can assume that this is what happens on the builbots. --

[issue28654] sys.stdout.isatty() returns True even if redirected to NUL

New submission from Kuno Meyer: [Python 3.5.2 on Windows] >py -c "import sys; print(sys.stdout.isatty(), file=sys.stderr)" > NUL True NUL is the Windows equivalent of /dev/nul, so the result should probably be False. Under Cygwin, the result is as expected: $ python3 -c "import sys;

[issue28649] refleak in typing.py

Ivan Levkivskyi added the comment: Guido, Yury, it looks like I solved the puzzle. All the remaining problems are because of forward references. In particular, _ForwardRef keeps a reference to the frame where it was defined: typing_globals = globals() frame = sys._getframe(1)

[issue24329] __qualname__ and __slots__

Xiang Zhang added the comment: I think of them but currently they don't pose a problem for practical codes like __qualname__. Maybe leaving them until there comes a real need? -- ___ Python tracker

[issue24329] __qualname__ and __slots__

Serhiy Storchaka added the comment: What about other names set when creating a class? __module__, __class__, __classcell__? -- ___ Python tracker ___