[issue28874] test_logging fails and freezes

2016-12-04 Thread Martin Panter
Changes by Martin Panter : -- title: test_logging fails -> test_logging fails and freezes type: -> behavior ___ Python tracker ___

[issue28875] test fails and freezes

2016-12-04 Thread Martin Panter
Changes by Martin Panter : -- resolution: -> duplicate status: open -> closed superseder: -> test_logging fails ___ Python tracker

[issue28875] test fails and freezes

2016-12-04 Thread Whitequill Riclo
New submission from Whitequill Riclo: while testing my build of cpython it hangs on test 198/404 and will not continue unless interrupted with ctrl-C. the build is fairly sound, but I can't test anything after test 198/404 cause it gets stuck. -- components: Tests files:

[issue28874] test_logging fails

2016-12-04 Thread Whitequill Riclo
New submission from Whitequill Riclo: while testing my build of cpython it hangs on test 198/404 and will not continue unless interrupted with ctrl-C. the build is fairly sound, but I can't test anything after test 198/404 cause it gets stuck. -- components: Tests files:

[issue28872] test_builtin failures when refleak hunting

2016-12-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This is a duplicate of issue13886. -- nosy: +serhiy.storchaka resolution: -> duplicate superseder: -> readline-related test_builtin failure ___ Python tracker

[issue28873] test_unittest failures when refleak hunting

2016-12-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This is a duplicate of issue25746. -- nosy: +serhiy.storchaka resolution: -> duplicate superseder: -> test_unittest failure in leaks searching mode ___ Python tracker

[issue28873] test_unittest failures when refleak hunting

2016-12-04 Thread Nick Coghlan
Nick Coghlan added the comment: Ned, I'm not sure if this should be a release blocker or not. Superficially, it looks like it's just a test bug arising from running the test multiple times in the same process, but I unfortunately don't have time to investigate further today. --

[issue28872] test_builtin failures when refleak hunting

2016-12-04 Thread Nick Coghlan
Nick Coghlan added the comment: Ned, I'm not sure if this should be a release blocker or not. Superficially, it looks like it's just a test bug arising from running the test multiple times in the same process, but I unfortunately don't have time to investigate further today. --

[issue23722] During metaclass.__init__, super() of the constructed class does not work

2016-12-04 Thread Nick Coghlan
Nick Coghlan added the comment: Thanks for the reviews Serhiy! The patch as merged addressed both your comments on the docs (including adding several new index entries) as well as the last couple of style comments on the code changes. I've filed separate issues for the test failures I'm

[issue28873] test_unittest failures when refleak hunting

2016-12-04 Thread Nick Coghlan
Changes by Nick Coghlan : -- nosy: +ned.deily ___ Python tracker ___ ___ Python-bugs-list

[issue28873] test_unittest failures when refleak hunting

2016-12-04 Thread Nick Coghlan
New submission from Nick Coghlan: test_unittest currently fails for me when hunting refleaks (Fedora 25): $ ./python -m test -R 3:3 -v test_unittest == ERROR: test_discover_with_init_module_that_raises_SkipTest_on_import

[issue28872] test_builtin failures when refleak hunting

2016-12-04 Thread Nick Coghlan
New submission from Nick Coghlan: test_builtin currently fails for me when hunting refleaks (Fedora 25): $ ./python -m test -R 3:3 -v test_builtin [snip] == FAIL: test_input_tty_non_ascii (test.test_builtin.PtyTests)

[issue27050] Demote run() below the high level APIs in subprocess docs

2016-12-04 Thread Nick Coghlan
Nick Coghlan added the comment: I've switched to using Vinay Sajip's "sarge" for my own subprocess invocation needs, which uses a similar all-in-one "run" API (albeit quite a different approach to capturing output). Accordingly, I don't think there's anything useful to be done specifically in

[issue23722] During metaclass.__init__, super() of the constructed class does not work

2016-12-04 Thread Roundup Robot
Roundup Robot added the comment: New changeset e33245800f1a by Nick Coghlan in branch '3.6': Issue #23722: improve __classcell__ compatibility https://hg.python.org/cpython/rev/e33245800f1a New changeset 9e5bc3d38de8 by Nick Coghlan in branch 'default': Merge #23722 from 3.6

[issue28596] on Android _bootlocale on startup relies on too many library modules

2016-12-04 Thread Chi Hsuan Yen
Chi Hsuan Yen added the comment: Thanks Victor. Here's new patch, which uses hasattr -- Added file: http://bugs.python.org/file45759/android-locale-utf8.patch ___ Python tracker

[issue28858] Fastcall uses more C stack

2016-12-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: That was my initial preference. Mainly because this doesn't add code churn. But I don't understand how PyObject_CallFunctionObjArgs() that uses _PyObject_CallArg1() and has many local variables can consume less stack than _PyObject_CallArg1() itself.

[issue28870] Refactor PyObject_CallFunctionObjArgs() and like

2016-12-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > What do you think of using alloca() instead of an "PyObject *small_stack[5];" > which has a fixed size? alloca() is not in POSIX.1. I afraid it would make CPython less portable. > Note: About your patch, try to avoid _PyObject_CallArg1() if you care of

[issue23722] During metaclass.__init__, super() of the constructed class does not work

2016-12-04 Thread Nick Coghlan
Nick Coghlan added the comment: I've hit a problem where test_builtin and test_unittest are failing for me when refleak hunting is enabled (as in actual test failures, not just leak reports), but those also appear for me without the patch applied. Current plan: - ensure "./python -m test -R

[issue28864] Add devnull file-like object

2016-12-04 Thread Martin Panter
Martin Panter added the comment: If you only need the readable interface, use BytesIO or StringIO. I once had an implementation like Serhiy’s, called dummywriter: . To fully implement the writable file API it should also

[issue28854] FIPS mode causes dead-lock in ssl module

2016-12-04 Thread Christian Heimes
Christian Heimes added the comment: It was a downstream bug in Fedora. Tomas Mraz has fixed the issue and will release openssl-1.0.2j-3 soon, https://bugzilla.redhat.com/show_bug.cgi?id=1400922 -- resolution: -> third party stage: -> resolved status: open -> closed

[issue28870] Refactor PyObject_CallFunctionObjArgs() and like

2016-12-04 Thread STINNER Victor
STINNER Victor added the comment: > But it doesn't affect a stack consumption. How do you check the stack consumption of PyObject_CallFunctionObjArgs()? -- ___ Python tracker

[issue28870] Refactor PyObject_CallFunctionObjArgs() and like

2016-12-04 Thread STINNER Victor
STINNER Victor added the comment: What do you think of using alloca() instead of an "PyObject *small_stack[5];" which has a fixed size? Note: About your patch, try to avoid _PyObject_CallArg1() if you care of the usage of the C stack, see issue #28858. --

[issue28869] __module__ attribute is not set correctly for a class created by direct metaclass call

2016-12-04 Thread Steven D'Aprano
Steven D'Aprano added the comment: I had a brief look at the source for ABCMeta, and it seems to me that the __module__ behaviour is coming from `type`. I'm not sure whether it can, or should, can be fixed in type, but I think that the correct behaviour for ABCMeta is to set __module__ to the

[issue28858] Fastcall uses more C stack

2016-12-04 Thread STINNER Victor
STINNER Victor added the comment: When I wrote the _PyObject_CallArg1(), it looks as a cool hack: #define _PyObject_CallArg1(func, arg) \ _PyObject_FastCall((func), (PyObject **)&(arg), 1) It hacks the declaration of an explicit "stack" like: PyObject *stack[1]; stack[0] = arg;

[issue28871] Destructor of ElementTree.Element is recursive

2016-12-04 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: The Element class in the xml.etree.ElementTree module is a collection. It can contain other Element's. But unlike to common Python collections (list, dict, etc) and pure Python classes, C implementation of Element doesn't support unlimited recursion. As

[issue28866] Unexpected behavior resulting from mro() and __setattr__ in interactive mode

2016-12-04 Thread Julien Palard
Julien Palard added the comment: Problem looks mainly due to the __setattr__ done on a different type than the getattr, and the cache of PyType_Lookup: - type_setattro will be called with Foo, "x", and the value to set - type_getattro will be called with FooProxy, "x" The timeline (with my

[issue28870] Refactor PyObject_CallFunctionObjArgs() and like

2016-12-04 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: Following patch I wrote in attempt to decrease a stack consumption of PyObject_CallFunctionObjArgs(), PyObject_CallMethodObjArgs() and _PyObject_CallMethodIdObjArgs(). But it doesn't affect a stack consumption. I still didn't measured what performance

[issue28858] Fastcall uses more C stack

2016-12-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thanks Victor. Following script includes several examples of achieving a stack overflow (most are real world examples or can be used in real world examples). It measures maximal deep for every type of recursion. -- Added file:

[issue28867] NamedTemporaryFile does not generate a ResourceWarning for unclosed files (unlike TemporaryFile)

2016-12-04 Thread R. David Murray
R. David Murray added the comment: __del__ is a destructor. If the file is open when it is called, it should emit a ResourceWarning. -- ___ Python tracker

[issue28858] Fastcall uses more C stack

2016-12-04 Thread STINNER Victor
STINNER Victor added the comment: > Serhiy Storchaka reported that Python 3.6 crashs earlier than Python 3.5 on > calling json.dumps() when sys.setrecursionlimit() is increased. Reference: http://bugs.python.org/issue23507#msg282190 (issue #23507). Serhiy Storchaka: "Yes, that is why I asked

[issue28858] Fastcall uses more C stack

2016-12-04 Thread Roundup Robot
Roundup Robot added the comment: New changeset d35fc6e58a70 by Victor Stinner in branch 'default': Backed out changeset b9c9691c72c5 https://hg.python.org/cpython/rev/d35fc6e58a70 -- nosy: +python-dev ___ Python tracker

[issue28869] __module__ attribute is not set correctly for a class created by direct metaclass call

2016-12-04 Thread Emanuel Barry
Emanuel Barry added the comment: Oh, nicely spotted! Apparently I was wrong, and it does create a key; defaulting to __name__. About the original issue, I don't think it's easily possible to fix, sadly. -- ___ Python tracker

[issue28866] Unexpected behavior resulting from mro() and __setattr__ in interactive mode

2016-12-04 Thread Julien Palard
Julien Palard added the comment: I'm able to reproduce the segmentation fault outside the interactive mode, see attached file. -- Added file: http://bugs.python.org/file45756/weird_without_interactive.py ___ Python tracker

[issue28869] __module__ attribute is not set correctly for a class created by direct metaclass call

2016-12-04 Thread Ivan Levkivskyi
Ivan Levkivskyi added the comment: > As a matter of fact, A.__module__ in this case is abc.ABCMeta.__module__. A > class body creates a __module__ key, while a direct metaclass call does not. But >>> A = ABCMeta('A', (), {}) >>> ABCMeta.__module__ = 'hi' >>> A.__module__ 'abc' >>>

[issue28867] NamedTemporaryFile does not generate a ResourceWarning for unclosed files (unlike TemporaryFile)

2016-12-04 Thread SilentGhost
SilentGhost added the comment: > The point of ResourceWarning it tell you when you are depending on > destructors for cleanup But there is an explicit call in __del__ to .close(), it's looks like intended behaviour and is ultimately the difference that Jon was seeing between

[issue28869] __module__ attribute is not set correctly for a class created by direct metaclass call

2016-12-04 Thread Emanuel Barry
Emanuel Barry added the comment: As a matter of fact, A.__module__ in this case is abc.ABCMeta.__module__. A class body creates a __module__ key, while a direct metaclass call does not. -- nosy: +ebarry ___ Python tracker

[issue28869] __module__ attribute is not set correctly for a class created by direct metaclass call

2016-12-04 Thread Ivan Levkivskyi
Changes by Ivan Levkivskyi : -- type: -> behavior ___ Python tracker ___ ___

[issue28868] Python advertising BeOpen.com domain

2016-12-04 Thread Emanuel Barry
Emanuel Barry added the comment: Part of the copyright notice, as SilentGhost mentioned. This can't be removed. -- nosy: +ebarry resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker

[issue28869] __module__ attribute is not set correctly for a class created by direct metaclass call

2016-12-04 Thread Ivan Levkivskyi
New submission from Ivan Levkivskyi: __module__ attribute is set differently depending on whether a metaclass is explicitly called or invoked in a class statement: >>> A = ABCMeta('A', (), {}) >>> A.__module__ 'abc' >>> class B(metaclass=ABCMeta): ... ... >>> B.__module__ '__main__'

[issue28868] Python advertising BeOpen.com domain

2016-12-04 Thread SilentGhost
SilentGhost added the comment: It's part of the copyright notice, just removing it is probably not an option. -- nosy: +SilentGhost ___ Python tracker

[issue28868] Python advertising BeOpen.com domain

2016-12-04 Thread rm
New submission from rm: There is BeOpen attribution in __builtins__() call, that may confuse users and generate some traffic to unrelated domain. For example: >>> import smtplib >>> smtplib.__builtins__ <...> Copyright (c) 2000 BeOpen.com. All Rights Reserved. <...> but beopen.com resolves

[issue28867] NamedTemporaryFile does not generate a ResourceWarning for unclosed files (unlike TemporaryFile)

2016-12-04 Thread R. David Murray
R. David Murray added the comment: The point of ResourceWarning it tell you when you are depending on destructors for cleanup, so this does look like a bug. -- nosy: +r.david.murray ___ Python tracker

[issue28857] SyncManager and Main Process fail to communicate after reboot or stoping with Ctrl - C

2016-12-04 Thread R. David Murray
R. David Murray added the comment: Hmm. I wasn't aware that multiprocessing used anything other than semaphores (ie: not files in /tmp). Clearly my knowledge is not enough to understand this problem, I'll leave it to the multiprocessing experts. -- nosy: +davin

[issue28864] Add devnull file-like object

2016-12-04 Thread R. David Murray
R. David Murray added the comment: Yes, in my mind open(os.devnull) is the "obvious way" to do this. -- nosy: +r.david.murray ___ Python tracker ___

[issue25591] refactor imaplib tests

2016-12-04 Thread R. David Murray
Changes by R. David Murray : -- versions: +Python 3.6 ___ Python tracker ___ ___

[issue25591] refactor imaplib tests

2016-12-04 Thread R. David Murray
R. David Murray added the comment: Revised patch LGTM. Once 3.6 is out the door I'll commit it, though you may need to remind me. -- stage: patch review -> commit review versions: +Python 3.7 -Python 3.6 ___ Python tracker

[issue28865] [MinGW32-x64]-PyList_Check PyDict_Check does not work

2016-12-04 Thread Steve Dower
Steve Dower added the comment: Is this the fork of MinGW specially for Python? I didn't think it supported 3.5 yet, because of the different CRT. Also, I can't easily tell right now, but if you're using the libpython35.a that's included with the regular install, you might want to regenerate

[issue28867] NamedTemporaryFile does not generate a ResourceWarning for unclosed files (unlike TemporaryFile)

2016-12-04 Thread SilentGhost
SilentGhost added the comment: Looking at the code it seems NamedTemporaryFile is closed on destruction of the object, so there is no need for ResourceWarning, because the file descriptor is not leaking. You also don't need to involve unittest here. Just running python with -Wall would

[issue28865] [MinGW32-x64]-PyList_Check PyDict_Check does not work

2016-12-04 Thread Mikhail
Mikhail added the comment: I made a small correction to the project. But the essence has not changed. With Microsoft Visual C++ Build Tools everything is fine. But I would like to use the GCC. -- Added file: http://bugs.python.org/file45755/PyAPITests.zip

[issue28865] [MinGW32-x64]-PyList_Check PyDict_Check does not work

2016-12-04 Thread Mikhail
Changes by Mikhail : Removed file: http://bugs.python.org/file45754/PyAPITests.zip ___ Python tracker ___

[issue28866] Unexpected behavior resulting from mro() and __setattr__ in interactive mode

2016-12-04 Thread Julien Palard
Julien Palard added the comment: FWIW, in _PyType_Lookup I see the "300" PyLong being cached, and later, just before the segfault, I see its address getting out of the cache (a cache hit) but it's no longer a PyLong, it's scrambled, so we're getting a real pointer with scrambled values on the

[issue28867] NamedTemporaryFile does not generate a ResourceWarning for unclosed files (unlike TemporaryFile)

2016-12-04 Thread Jon Dufresne
New submission from Jon Dufresne: When using unittest, I'll frequently enable -Wall to help catch code smells and potential bugs. One feature of this, I'm told when files aren't explicitly closed with an error like: "ResourceWarning: unclosed file <...>". I've noticed this warning is

[issue23722] During metaclass.__init__, super() of the constructed class does not work

2016-12-04 Thread Guido van Rossum
Changes by Guido van Rossum : -- nosy: -gvanrossum ___ Python tracker ___ ___

[issue24339] iso6937 encoding missing

2016-12-04 Thread Julien Palard
Julien Palard added the comment: LGTM, for me it's time to release it as a package on pypi to check the adoption rate and see it it's worth adding it in Python and maybe close this issue. -- ___ Python tracker

[issue28754] Argument Clinic for bisect.bisect_left

2016-12-04 Thread Julien Palard
Julien Palard added the comment: Hi Martin, Historically (lo=0, hi=None) was the implementation (in Python), until the C implementation, which used (lo=0, hi=-1). As my implementation allows for -1 and None, I don't think I'm breaking something. --

[issue28866] Unexpected behavior resulting from mro() and __setattr__ in interactive mode

2016-12-04 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- versions: +Python 2.7 ___ Python tracker ___

[issue28866] Unexpected behavior resulting from mro() and __setattr__ in interactive mode

2016-12-04 Thread Emanuel Barry
Emanuel Barry added the comment: Additionally, trying to access an attribute before assigning it will result in an AttributeError on all subsequent accesses (even if set). I didn't manage to get a segfault, however. -- nosy: +ebarry ___ Python

[issue28724] Add method send_io, recv_io to the socket module.

2016-12-04 Thread Julien Palard
Julien Palard added the comment: Unless somebody don't think so, I think this should go as a pypi module before going to the socket module, so this issue should probably be closed. -- ___ Python tracker

[issue28865] [MinGW32-x64]-PyList_Check PyDict_Check does not work

2016-12-04 Thread Mikhail
Mikhail added the comment: Project included. building output in the console: running build_ext building '_PyAPITests' extension swigging PyAPITests.i to PyAPITests_wrap.c z:\PortableApps\MyApps\Dev\SWIGWin\swigwin-3.0.10\swig.exe -python -py3 -o PyAPITests_wrap.c PyAPITests.i

[issue28707] add 'directory' option to the http.server module

2016-12-04 Thread Julien Palard
Julien Palard added the comment: @Victor you're right, I forgot that partial can also apply keyword arguments. Here is a new patch. -- Added file: http://bugs.python.org/file45753/issue28707.diff ___ Python tracker

[issue28866] Unexpected behavior resulting from mro() and __setattr__ in interactive mode

2016-12-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Python 2 is affected if make Foo a new style class. -- nosy: +serhiy.storchaka priority: normal -> high versions: +Python 3.6, Python 3.7 -Python 3.4 ___ Python tracker

[issue28866] Unexpected behavior resulting from mro() and __setattr__ in interactive mode

2016-12-04 Thread sjpalt
New submission from sjpalt: I ran into a strange bug while experimenting with metaclasses that implement a custom mro() method. It only seems to occur in interactive mode, either returning completely unrelated values or causing a segfault. Python 2 appears unaffected. I have been able to

[issue27305] Crash with "pip list --outdated" on Windows 10 with Python 2.7.12rc1

2016-12-04 Thread Steve Dower
Steve Dower added the comment: Since it's not crashing, it is different from this issue. You should open a new bug. -- ___ Python tracker ___

[issue28692] gettext: deprecate selecting plural form by fractional numbers

2016-12-04 Thread Julien Palard
Julien Palard added the comment: > It seems to me that a fractional number should be formatted with the same > form independently from it's value Ok, so 1.000 seconds, ok, LGTM. Should we mention something explicit about it? Not sure how to write it down, but I still fear that everyone's

[issue27305] Crash with "pip list --outdated" on Windows 10 with Python 2.7.12rc1

2016-12-04 Thread Максим Лукоянов
Максим Лукоянов added the comment: >>> import platform >>> platform.platform() 'Windows-10-10.0.14393' -- ___ Python tracker ___

[issue27305] Crash with "pip list --outdated" on Windows 10 with Python 2.7.12rc1

2016-12-04 Thread Максим Лукоянов
Максим Лукоянов added the comment: >>> import sys >>> print sys.version 2.7.12 (v2.7.12:d33e0cf91556, Jun 27 2016, 15:24:40) [MSC v.1500 64 bit (AMD64)] >>> from urllib2 import urlopen >>> urlopen('http://www.google.co.uk') Traceback (most recent call last): File "", line 1, in

[issue28596] on Android _bootlocale on startup relies on too many library modules

2016-12-04 Thread Chi Hsuan Yen
Chi Hsuan Yen added the comment: Patch version 3, using sys.getandroidapilevel() -- Added file: http://bugs.python.org/file45751/android-locale-utf8.patch ___ Python tracker

[issue24339] iso6937 encoding missing

2016-12-04 Thread John Helour
John Helour added the comment: Performance issue resolved, more info on error added. I've checked encoding and decoding on a two UTF-8 ~3MiB txt files. Except the first BOM mark (May I ignore it?) all seems work OK. -- ___ Python tracker

[issue24339] iso6937 encoding missing

2016-12-04 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka priority: normal -> low ___ Python tracker ___

[issue23722] During metaclass.__init__, super() of the constructed class does not work

2016-12-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Added two more style comments. And please take note of my comments to issue23722_documentation_updates.diff. Nothing critical, but would be nice to add more cross-references in the documentation. -- ___ Python

[issue23722] During metaclass.__init__, super() of the constructed class does not work

2016-12-04 Thread Nick Coghlan
Nick Coghlan added the comment: Assuming there are no further comments overnight, I'll go ahead and commit this tomorrow (after doing a local refleak hunting run). -- ___ Python tracker

[issue24339] iso6937 encoding missing

2016-12-04 Thread John Helour
Changes by John Helour : Added file: http://bugs.python.org/file45750/iso6937.py ___ Python tracker ___

[issue24339] iso6937 encoding missing

2016-12-04 Thread John Helour
Changes by John Helour : Removed file: http://bugs.python.org/file45740/iso6937.py ___ Python tracker ___

[issue24339] iso6937 encoding missing

2016-12-04 Thread John Helour
Changes by John Helour : Added file: http://bugs.python.org/file45749/check_iso6937.py ___ Python tracker ___

[issue23722] During metaclass.__init__, super() of the constructed class does not work

2016-12-04 Thread Nick Coghlan
Nick Coghlan added the comment: Updated patch for Serhiy's review comments: issue23722_classcell_reference_validation_v2.diff - avoids a spurious deprecation warning for metaclasses that don't return a type() instance at all - avoids even the appearance of a refleak in the __build_class__

[issue28865] [MinGW32-x64]-PyList_Check PyDict_Check does not work

2016-12-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Could you please provide a complete C file that is compiled? Output also PyType_GetFlags(Py_TYPE(result)). And check that result is not NULL. -- nosy: +serhiy.storchaka versions: -Python 3.4 ___ Python tracker

[issue28865] [MinGW32-x64]-PyList_Check PyDict_Check does not work

2016-12-04 Thread Mikhail
New submission from Mikhail: Windows 10 x64 Python 3.4, 3.5, Anaconda3 4.2 - x64 SWIG 3.0.8, 3.0.10 MinGW32/64 - TDM-GCC-64 5.1.0-2, x86_64-5.3.0-win32-sjlj-rt_v4-rev0, x86_64-6.2.0-win32-sjlj-rt_v5-rev1 The code in C compiles fine, there are no warnings. But then, in the finished module,

[issue24329] __qualname__ and __slots__

2016-12-04 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- dependencies: +During metaclass.__init__, super() of the constructed class does not work ___ Python tracker

[issue24329] __qualname__ and __slots__

2016-12-04 Thread Nick Coghlan
Nick Coghlan added the comment: "__classcell__" in __slots__ doesn't really make sense, as unlike __qualname__ (which turns into a real class level attribute and can be useful to override on instances), it's only a transient entry in a class definition namespace - types.__new__ pops it

[issue28692] gettext: deprecate selecting plural form by fractional numbers

2016-12-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: round() was used because it is the simplest way to convert fractional numbers to integers that doesn't involve strings-to-integer converting (as in int()). Perhaps math.trunc() looks a little more appropriate. math.ceil() returns a float in 2.7 and is

[issue27200] make doctest in CPython has failures

2016-12-04 Thread Marco Buttu
Marco Buttu added the comment: Here is a patch that makes all Doc/library/datetime.rst doctests pass. The tests only pass with Python 3.6 and 3.7 (the optional ``timespec`` argument of ``datetime.isoformat()`` has been introduced in Python 3.6). To apply the patch you should agree with issue

[issue28692] gettext: deprecate selecting plural form by fractional numbers

2016-12-04 Thread Julien Palard
Julien Palard added the comment: > But gettext formulas are not purposed to support non-integer values and can > return incorrect result Looks like the cast to integer is done *before* giving the value to the C gettext expression. > For example (in Ukrainian) As long as gettext expression

[issue23722] During metaclass.__init__, super() of the constructed class does not work

2016-12-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Added comments on Rietveld. -- nosy: +serhiy.storchaka ___ Python tracker ___

[issue24329] __qualname__ and __slots__

2016-12-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Nick, could you please look at the patch? Especially at the part about __classcell__. -- nosy: +ncoghlan ___ Python tracker

[issue28863] Doc/includes/*.py files and doctests

2016-12-04 Thread Marco Buttu
Marco Buttu added the comment: Here is the patch for the Sphinx conf.py file. -- keywords: +patch Added file: http://bugs.python.org/file45746/conf.py.patch ___ Python tracker

[issue28860] Fixed all the doctest failures in Doc/library/configparser.rst

2016-12-04 Thread Marco Buttu
Marco Buttu added the comment: Here is a 3rd patch. I used a generator expression argument to ``sorted()``, as recommend by Zachary. Thank you very much for all your suggestions -- Added file: http://bugs.python.org/file45745/configparser3rd.patch

[issue23722] During metaclass.__init__, super() of the constructed class does not work

2016-12-04 Thread Nick Coghlan
Nick Coghlan added the comment: I should have made my comments a bit clearer as to which patches they were referring to. The ones submitted for inclusion in 3.6.0rc1 are: * issue23722_classcell_reference_validation.diff (the compatibility fix) * issue23722_documentation_updates.diff (the