[issue29642] Why does unittest.TestLoader.discover still rely on existence of __init__.py files?

Changes by Berker Peksag : -- resolution: -> not a bug stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue26985] Information about CodeType in inspect documentation is outdated

Changes by Xiang Zhang : -- type: behavior -> versions: +Python 3.7 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue30038] Race condition in how trip_signal writes to wakeup fd

Nathaniel Smith added the comment: The attached script wakeup-fd-racer.py fails consistently for me using cpython 3.6.0 on my windows 10 vm: > python wakeup-fd-racer.py Attempt 0: start Attempt 0: FAILED, took 10.0160076 seconds select_calls = 2 (It may help that the VM only has 1 CPU?

[issue29933] asyncio: set_write_buffer_limits() doc doesn't specify unit of the parameters

Changes by Mariatta Wijaya : -- stage: -> needs patch ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue29933] asyncio: set_write_buffer_limits() doc doesn't specify unit of the parameters

Changes by Mariatta Wijaya : -- assignee: docs@python -> Mariatta nosy: +Mariatta ___ Python tracker ___ ___ Python-bugs-list mailing

[issue30045] Bad parameter name in re.escape()

Raymond Hettinger added the comment: "Pattern" seems right to me. -- nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list mai

[issue30048] If a task is canceled at the right moment, the cancellation is ignored

Yury Selivanov added the comment: Interesting. It doesn't work for both C and Python versions of the Task. I'll take a look in detail when I return from vacation. -- assignee: -> yselivanov nosy: +inada.naoki ___ Python tracker

[issue30048] If a task is canceled at the right moment, the cancellation is ignored

New submission from Evgeny Kapun: If I run this code: import asyncio as a @a.coroutine def coro1(): yield from a.ensure_future(coro2()) print("Still here") yield from a.sleep(1) print("Still here 2") @a.coroutine def coro2(): yield fr

[issue30040] new empty dict can be more small

INADA Naoki added the comment: > I mean creating a solo empty dict doesn't seem to make much sense. Although > it saves memory, but when it's populated, it's resized and the memory > occupation comes back. But sometimes it's not populated. class A: def __init__(self, **kwargs): se

[issue30047] Typos in Doc/library/select.rst

Changes by OSAMU NAKAMURA : -- pull_requests: +1230 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30047] Typos in Doc/library/select.rst

New submission from OSAMU NAKAMURA: In 18.3.2. Edge and Level Trigger Polling (epoll) Objects, there is duplicated 'on' in description of `EPOLLEXCLUSIVE`. Wake only ... objects polling on on a fd. ^ -- assignee: docs@python components: Documentat

[issue29994] site.USER_SITE is None for Windows embeddable Python 3.6

Steve Dower added the comment: This is by design - the embeddable Python is meant to exclude anything relating to the current user by default. If you're looking for a lightweight Python install that you can use for things like building or managing packages, you may be interested in the Nuget p

[issue29870] ssl socket leak

Antoine Pitrou added the comment: > Antoine, you might find multissl.py helpful. Very nice, thank you! -- ___ Python tracker ___ ___

[issue29966] typing.get_type_hints doesn't really work for classes with ForwardRefs

Simon Percivall added the comment: It think it's important to document this caveat in `get_type_hints`, that there is virtually _no_ way to use it safely with a class, and that there will always be a high risk of getting an exception unless using this function in a highly controlled setting.

[issue30046] csv: Inconsistency re QUOTE_NONNUMERIC

New submission from Thomas Lotze: A csv.writer with quoting=csv.QUOTE_NONNUMERIC does not quote boolean values, which makes a csv.reader with the same quoting behaviour fail on that value: csv.py -- import csv import io f = io.StringIO() writer = csv.writer(f, quoting=csv.Q

[issue30030] Simplify _RandomNameSequence

Serhiy Storchaka added the comment: Merged in f50354adaaafebe95ad09d09b825804a686ea843. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue30045] Bad parameter name in re.escape()

New submission from Serhiy Storchaka: Currently re.escape() parameter has a name "pattern", but in the documentation the name of the parameter is "string". The name "pattern" is not correct, and maybe even misleading. The argument of escape() is not a pattern, it is an arbitrary string, and es

[issue29870] ssl socket leak

Christian Heimes added the comment: Antoine, you might find multissl.py helpful. I wrote a script to automate testing with multiple versions of OpenSSL and libressl. The first time it takes about half an hour to download, compile and install all versions locally. https://github.com/tiran/multi

[issue29870] ssl socket leak

Changes by Christian Heimes : -- pull_requests: +1229 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue29870] ssl socket leak

Christian Heimes added the comment: Yes, I'm currently testing the change with a bunch of OpenSSL and LibreSSL versions. By the way the memory issue can be reproduced with any certificate that contains a CRL distribution point. Letsencrypt certs don't have a CRL DP. I guess Alexander's test c

[issue29870] ssl socket leak

Alexander Mohr added the comment: awesome! Thanks for finding a proposing fix pitrou! btw I found an example of freeing this structure here: http://www.zedwood.com/article/c-openssl-parse-x509-certificate-pem -- ___ Python tracker

[issue29870] ssl socket leak

Antoine Pitrou added the comment: So we should use it instead of sk_DIST_POINT_free()? I'd like to minimize potential breakage here. -- ___ Python tracker ___ __

[issue29870] ssl socket leak

Christian Heimes added the comment: CRL_DIST_POINTS_free() should be available in all supported OpenSSL versions. The function is defined by DECLARE_ASN1_FUNCTIONS(CRL_DIST_POINTS). -- ___ Python tracker _

[issue29870] ssl socket leak

Antoine Pitrou added the comment: The following addition fixes the leak: diff --git a/Modules/_ssl.c b/Modules/_ssl.c index bb40051..8f5facd 100644 --- a/Modules/_ssl.c +++ b/Modules/_ssl.c @@ -1203,6 +1203,8 @@ _get_crl_dp(X509 *certificate) { Py_XDECREF(lst); #if OPENSSL_VERSION_NUMBER <

[issue30040] new empty dict can be more small

R. David Murray added the comment: Sorry, but I no longer have access to that application (I'm a consultant, and the owner is no longer a client). -- ___ Python tracker ___

[issue30040] new empty dict can be more small

INADA Naoki added the comment: Thank you for your reply. Would you try to check how the patch [1] affects memory usage of your application? I think the patch can be applied to 3.6 easily. [1] https://patch-diff.githubusercontent.com/raw/python/cpython/pull/1080.patch -- __

[issue29870] ssl socket leak

Antoine Pitrou added the comment: Ok, thank you. I've tweaked the script to remove most threads and use maps.google.com (which is faster here), and I managed to bisect the leak to deduce that the offending changeset is 598894ff48e9c1171cb2ec1c798235826a75c7e0. -- _

[issue29870] ssl socket leak

Alexander Mohr added the comment: see graphs here: https://github.com/kennethreitz/requests/issues/3933, x-axis is number of requests not what it says (seconds). -- ___ Python tracker _

[issue29870] ssl socket leak

Antoine Pitrou added the comment: Google is not very fast here (a couple of requests / sec at most). How many requests does it take to see a clear tendency? -- ___ Python tracker _

[issue29870] ssl socket leak

Alexander Mohr added the comment: ya, my sample script hits google.com , it's pretty fast. It just does a "HEAD". > On Apr 11, 2017, at 9:14 AM, Antoine Pitrou wrote: > > > Antoine Pitrou added the comment: > > Is there a fast enough remote server that shows the leak? I

[issue29870] ssl socket leak

Antoine Pitrou added the comment: Is there a fast enough remote server that shows the leak? I've tested with my own remote server (https://pitrou.net/), but it doesn't leak. -- ___ Python tracker _

[issue19084] No way to use TLS-PSK from python ssl

Changes by chrysn : -- nosy: +chrysn ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/ma

[issue29870] ssl socket leak

Alexander Mohr added the comment: the interesting part is it doesn't leak with a local https server, it appears to need to be a remove server. -- ___ Python tracker ___

[issue30044] shutil.copystat should (allow to) copy ownership, and other attributes

New submission from Florent Coriat: shutil.copystat() copies permissions, timestamps and even flags and xattrs (if supported), but not ownership. Furthermore, shutil.copy2() documentation until 2.7 used to say it behaves like cp -p, which preserves ownership, and not xattr nor flags. (On my sys

[issue30034] csv reader chokes on bad quoting in large files

Keith Erskine added the comment: I should have said, Peter, an odd number of quotes does not necessarily mean the quoting is bad. For example, a line of: a,b",c will parse fine as ['a', 'b"', 'c']. Figuring out bad quoting is not easy, but if we know that there are no multiline fields in the

[issue29870] ssl socket leak

Antoine Pitrou added the comment: After adapting your test script to run against a local openssl server (`openssl s_server -www`), I can't see a single leak: the process is peaking at 20860 KB RSS. This is with Python 3.5 tip. Does it need a specific server to test against to showcase the lea

[issue30043] fcntl module for windows platform

STINNER Victor added the comment: The Python bug tracker is not a forum. Please ask such question on a Python help mailing list or any Python forum, but not here. Thank you ;-) (No, there is no fcntl module on Windows.) -- nosy: +haypo resolution: -> not a bug stage: -> resolved stat

[issue30034] csv reader chokes on bad quoting in large files

Keith Erskine added the comment: The csv reader already supports bad CSV - that's what I believe "strict" is for - but only in one specific scenario. My request is to make that "strict" attribute a bit more useful. Thank you for your suggestion, Peter. I have toyed with the idea of looking

[issue30040] new empty dict can be more small

R. David Murray added the comment: I've worked on an application (proprietary, unfortunately) that created a lot of empty dictionaries that only sometimes got populated. It involved sqlalchemy, but I don't remember if the dicts came from sqlalchemy itself or from the code that used it. That

[issue30043] fcntl module for windows platform

New submission from karan: is there any fcntl module alternative available that would support windows platform?? in any of futures release of python is it possible that fcntl would support windows?? -- messages: 291493 nosy: kk_pednekar priority: normal severity: normal status: open t

[issue30042] fcntl module for windows

Christian Heimes added the comment: Yes, it's Unix only: https://docs.python.org/2.7/py-modindex.html#cap-f -- nosy: +christian.heimes resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker

[issue29979] cgi.parse_multipart is not consistent with FieldStorage

Pierre Quentel added the comment: Senthil, Can you take a look at the Pull Request when you have time ? The correct PR is #991, not #990. -- ___ Python tracker ___

[issue30042] fcntl module foe windows

New submission from karan: NameError: global name 'fcntl' is not defined such error occurs while running software on windows. does fcntl module (urwid) is available for windows?? -- messages: 291490 nosy: kk_pednekar priority: normal severity: normal status: open title: fcntl module foe

[issue30031] Improve queens demo (use argparse and singular form)

Changes by Pavlo Kapyshin : -- pull_requests: +1228 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30042] fcntl module for windows

Changes by karan : -- title: fcntl module foe windows -> fcntl module for windows ___ Python tracker ___ ___ Python-bugs-list mailing

[issue29590] Incorrect stack traces when re-entering a generator/coroutine stack via .throw()

Changes by Mariatta Wijaya : -- components: +Interpreter Core ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue30040] new empty dict can be more small

INADA Naoki added the comment: While I think it's preferable that {} and d.clear() have same memory footprint, I need real world example which empty dict affects overall memory usage. I'll check memory usage difference with application I used in this ML thread. https://mail.python.org/pipermail/

[issue30038] Race condition in how trip_signal writes to wakeup fd

STINNER Victor added the comment: I know that it can be very difficult to write such test, but can you please try to write a script trying to reproduce the describe the race condition? Later, we can run the script in a test to check for non-regression. -- _

[issue30038] Race condition in how trip_signal writes to wakeup fd

STINNER Victor added the comment: "I think the idea in c13ef6664998 wasn't so much that we wanted the wakeup fd to be written to first, as that the way the code was written back then, the presence of 'if (is_tripped) return;' meant that it wasn't getting written to *at all* in some cases. Sinc

[issue30024] Treat `import a.b.c as m` as `m = sys.modules['a.b.c']`

Nick Coghlan added the comment: Huh, interesting - I'd missed that the only part of the "from a.b import c" that IMPORT_FROM implements is the LOAD_ATTR variant that falls back to sys.modules. The prior adjustment to get IMPORT_NAME to return "a.b" instead of "a" happens inside that opcode bas

[issue30040] new empty dict can be more small

Serhiy Storchaka added the comment: Use "--duplicate 100" when making microbenchmarks for such fast operations. The overhead of iterating can be significant and comparable with the time of the operation. -- nosy: +serhiy.storchaka stage: -> patch review __

[issue30038] Race condition in how trip_signal writes to wakeup fd

Nathaniel Smith added the comment: If it helps, notice that the SetEvent(sigint_event) call used to wake up the main thread on windows is also performed unconditionally and after the call to Py_AddPendingEvent. From the point of view of twisted/tornado/trio, this is exactly the same as the wri

[issue30040] new empty dict can be more small

Xiang Zhang added the comment: I mean creating a solo empty dict doesn't seem to make much sense. Although it saves memory, but when it's populated, it's resized and the memory occupation comes back. And this makes PyDict_New() hard to understand. :-( -- _

[issue29606] urllib FTP protocol stream injection

Changes by Plenty Su : -- nosy: +supl ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/m

[issue30040] new empty dict can be more small

INADA Naoki added the comment: macro bench result: $ ./python.default -m perf compare_to -G --min-speed=1 default.json patched.json Slower (11): - scimark_lu: 362 ms +- 13 ms -> 383 ms +- 22 ms: 1.06x slower (+6%) - unpickle_pure_python: 882 us +- 18 us -> 924 us +- 18 us: 1.05x slower (+5%) - r

[issue30040] new empty dict can be more small

INADA Naoki added the comment: > Isn't the latter case the more common one? Creating an empty dict and then > populate it. This is memory usage optimization, not performance optimization. (But I think memory efficiency makes multi process application faster because L3 cache size is limited res

[issue30038] Race condition in how trip_signal writes to wakeup fd

Nathaniel Smith added the comment: I think the idea in c13ef6664998 wasn't so much that we wanted the wakeup fd to be written to first, as that the way the code was written back then, the presence of 'if (is_tripped) return;' meant that it wasn't getting written to *at all* in some cases. Sinc

[issue30038] Race condition in how trip_signal writes to wakeup fd

STINNER Victor added the comment: Previous changes in signal handling. It's the commit c13ef66649985025382c64f6af8e3b956411e05b of the issue #8407 which changed the order: became . I really *hate* having to think to these evil things which are signals and threads... Signals and threads don't

[issue30038] Race condition in how trip_signal writes to wakeup fd

Nathaniel Smith added the comment: Err, libuv obviously doesn't use a Python-level signal handler. I just meant to include them as another example of a library I checked that uses a self-pipe to handle signals but relies on out-of-band information to transmit what the actual signal is :-). --

[issue30040] new empty dict can be more small

Xiang Zhang added the comment: Isn't the latter case the more common one? Creating an empty dict and then populate it. -- nosy: +xiang.zhang ___ Python tracker ___ _

[issue30038] Race condition in how trip_signal writes to wakeup fd

Nathaniel Smith added the comment: Right. My claim would be that the PR I just submitted is the correct fix for bpo-21645 as well. The approach asyncio uses is very elegant, but unfortunately it assumes that the wakeup fd has infinite buffer, which isn't true. If enough signals or other callb

[issue30041] subprocess: weird behavior with shell=True and args being a list

Martin Panter added the comment: This is as documented, but perhaps see Issue 20344 about clarifying the documentation. -- nosy: +martin.panter resolution: -> not a bug stage: -> resolved status: open -> closed superseder: -> subprocess.check_output() docs misrepresent what shell=Tru

[issue30038] Race condition in how trip_signal writes to wakeup fd

STINNER Victor added the comment: Last time I had to make a major change related to signal handling, it was in the asyncio module because of a race conditon which occurred on FreeBSD. commit fe5649c7b7bf52147480d6b1124a3d8e3597aee3 Author: Victor Stinner Date: Thu Jul 17 22:43:40 2014 +0200

[issue3041] autodoc does not support unicode docstrings

Changes by Dimitri Merejkowsky : -- pull_requests: +1227 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue30041] subprocess: weird behavior with shell=True and args being a list

New submission from Dimitri Merejkowsky: If you have: subprocess.run(["ls", "--help"], shell=True) you'll see that the command run is actually just "ls", not "ls --help" -- components: Library (Lib) messages: 291473 nosy: Dimitri Merejkowsky priority: normal severity: normal status: op

[issue30038] Race condition in how trip_signal writes to wakeup fd

Changes by Nathaniel Smith : -- pull_requests: +1226 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue29692] contextlib.contextmanager may incorrectly unchain RuntimeError

Nick Coghlan added the comment: New changeset e8a6bb4f3936123f3eca0b6cea05e2875a2722bc by Nick Coghlan in branch 'master': bpo-29692: Add missing ACKS entry (#1079) https://github.com/python/cpython/commit/e8a6bb4f3936123f3eca0b6cea05e2875a2722bc -- __

[issue30040] new empty dict can be more small

Changes by INADA Naoki : -- components: +Interpreter Core type: -> resource usage versions: +Python 3.7 ___ Python tracker ___ ___ Py

[issue30040] new empty dict can be more small

INADA Naoki added the comment: performance impact best case: $ ./python.patched -m perf timeit --compare-to=`pwd`/python.default -- '{}' python.default: . 36.9 ns +- 0.9 ns python.patched: . 25.3 ns +- 0.7 ns Mean +- std dev: [python.default] 36.9 ns +- 0

[issue30039] Resuming a 'yield from' stack is broken if a signal arrives in the middle

Changes by Nathaniel Smith : -- pull_requests: +1224 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue30040] new empty dict can be more small

Changes by INADA Naoki : -- pull_requests: +1223 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue30040] new empty dict can be more small

New submission from INADA Naoki: dict.clear() make the dict to empty key-sharing dict to reduce it's size. New dict can use same technique. $ ./python.default Python 3.7.0a0 (heads/master:6dfcc81, Apr 10 2017, 19:55:52) [GCC 6.2.0 20161005] on linux Type "help", "copyright", "credits" or "lice

[issue30039] Resuming a 'yield from' stack is broken if a signal arrives in the middle

New submission from Nathaniel Smith: If we have a chain of generators/coroutines that are 'yield from'ing each other, then resuming the stack works like: - call send() on the outermost generator - this enters _PyEval_EvalFrameDefault, which re-executes the YIELD_FROM opcode - which calls send()

[issue29692] contextlib.contextmanager may incorrectly unchain RuntimeError

Changes by Nick Coghlan : -- pull_requests: +1222 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue29692] contextlib.contextmanager may incorrectly unchain RuntimeError

Changes by Nick Coghlan : -- assignee: -> ncoghlan ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue29692] contextlib.contextmanager may incorrectly unchain RuntimeError

Nick Coghlan added the comment: This has been merged for 3.7, but cherry-picks to the other branches are still needed. I also inadvertently missed adding svelankar's name (Siddharth Velankar) to Misc/ACKS, so that oversight will need to be tidied up as well. -- resolution: -> fixed s

[issue30038] Race condition in how trip_signal writes to wakeup fd

New submission from Nathaniel Smith: In trip_signal [1], the logic goes: 1) set the flag saying that this particular signal was tripped 2) write to the wakeup fd 3) set the global is_tripped flag saying "at least one signal was tripped", and do Py_AddPendingCall (which sets some global flags th

[issue29692] contextlib.contextmanager may incorrectly unchain RuntimeError

Nick Coghlan added the comment: New changeset 00c75e9a45ff0366c185e9e8a2e23af5a35481b0 by Nick Coghlan (svelankar) in branch 'master': bpo-29692: contextlib.contextmanager may incorrectly unchain RuntimeError (GH-949) https://github.com/python/cpython/commit/00c75e9a45ff0366c185e9e8a2e23af5a35

[issue29881] Add a new private API clear private variables, which are initialized once, at Python shutdown

Changes by Louie Lu : -- nosy: +louielu ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org

[issue30037] inspect documentation on code attributes incomplete

Martin Panter added the comment: Looks like a there is already a patch discussed at Issue 26985. -- nosy: +martin.panter resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> Information about CodeType in inspect documentation is outdated _

[issue24076] sum() several times slower on Python 3 64-bit

Changes by Louie Lu : -- title: sum() several times slower on Python 3 -> sum() several times slower on Python 3 64-bit ___ Python tracker ___ __

[issue30036] The bugs website doesn't use httpS by default

Changes by Christian Heimes : -- assignee: christian.heimes -> components: +Documentation -SSL type: security -> behavior ___ Python tracker ___

[issue24076] sum() several times slower on Python 3

Changes by Louie Lu : -- versions: +Python 3.7 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue25828] PyCode_Optimize() (peephole optimizer) doesn't handle KeyboardInterrupt correctly

Changes by Louie Lu : -- pull_requests: +1221 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue30037] inspect documentation on code attributes incomplete

New submission from Dutcho: The table at the top of the inspect documentation (https://docs.python.org/3/library/inspect.html#types-and-members) omits co_cellvars, co_freevars, and co_kwonlyargcount attributes of type code (note: the type's doc string does provide these attributes) --

[issue25828] PyCode_Optimize() (peephole optimizer) doesn't handle KeyboardInterrupt correctly

Changes by Louie Lu : -- versions: +Python 3.7 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue30036] The bugs website doesn't use httpS by default

New submission from Dutcho: The footer of httpS://python.org links to httP://bugs.python.org, compromising user data for login and register options -- assignee: christian.heimes components: SSL messages: 291463 nosy: Dutcho, christian.heimes priority: normal severity: normal status: ope

[issue30034] csv reader chokes on bad quoting in large files

Peter Otten added the comment: While I don't think that the csv module should second-guess broken input you might consider "fixing" your data on the fly: def close_quote(line): if line.count('"') % 2: line = line.rstrip("\n") + '"\n' return line with open("data.csv") as f: