[issue30303] IDLE: Add _utest to textview and add textview tests

2017-05-27 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- pull_requests: -1923 ___ Python tracker ___ ___

[issue30290] IDLE: add tests for help_about.py

2017-05-27 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- pull_requests: -1922 ___ Python tracker ___ ___

[issue30290] IDLE: add tests for help_about.py

2017-05-27 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- pull_requests: +1927 ___ Python tracker ___ ___

[issue30486] Allow setting cell value

2017-05-27 Thread Lisa Roach
Changes by Lisa Roach : -- pull_requests: +1925 ___ Python tracker ___ ___

[issue13349] Non-informative error message in index() and remove() functions

2017-05-27 Thread Nick Coghlan
Nick Coghlan added the comment: While I agree it's reasonable to keep arbitrary value repr's out of these messages by default, I do think it would be desirable for someone sufficiently motivated to file a separate RFE about adding the value as a structured exception attribute so that custom

[issue30495] IDLE: modernize textview module

2017-05-27 Thread Terry J. Reedy
Terry J. Reedy added the comment: I plan to merge when checks pass. Not reusing module names avoids noise when grepping for a module name ;-). A final search for 'textview', match case, whole word, gave 18 hits, which were easy to check. -- ___

[issue30290] IDLE: add tests for help_about.py

2017-05-27 Thread Terry J. Reedy
Terry J. Reedy added the comment: pr 1839 is now attached to new issue #30495. This issue is closed except for trivial bugs in the two merged PRs and backports. -- ___ Python tracker

[issue30495] IDLE: modernize textview module

2017-05-27 Thread Terry J. Reedy
Terry J. Reedy added the comment: Grepping shows that other references to textview objects (other than in test_textview) are to unchanged class and function names. -- ___ Python tracker

[issue30495] IDLE: modernize textview module

2017-05-27 Thread Terry J. Reedy
Terry J. Reedy added the comment: The initial patch, https://github.com/python/cpython/pull/1839, adds missing docstrings to textview and changes names to conform to PEP 8. It was originally attached to #30290. I changed the bpo # in the title to 30495. We will see if Belvedere bot corrects

[issue30495] IDLE: modernize textview module

2017-05-27 Thread Cheryl Sabella
Changes by Cheryl Sabella : -- pull_requests: +1924 ___ Python tracker ___ ___

[issue30495] IDLE: modernize textview module

2017-05-27 Thread Terry J. Reedy
New submission from Terry J. Reedy: First get issue #. -- assignee: terry.reedy components: IDLE messages: 294622 nosy: csabella, terry.reedy priority: normal severity: normal stage: patch review status: open title: IDLE: modernize textview module type: enhancement versions: Python 3.6,

[issue30303] IDLE: Add _utest to textview and add textview tests

2017-05-27 Thread Cheryl Sabella
Changes by Cheryl Sabella : -- pull_requests: +1923 ___ Python tracker ___ ___

[issue30494] python.exe crashed when open long path in windows 7

2017-05-27 Thread Eryk Sun
Eryk Sun added the comment: Your example works fine for me in Windows 10, and I see no reason why it would fail in Windows 7. The crash dialog in your screenshot shows that the problem occurred in a DLL named "winhadnt.dll". I suspect that this is malware injected into the python.exe process.

[issue30290] IDLE: add tests for help_about.py

2017-05-27 Thread Cheryl Sabella
Cheryl Sabella added the comment: Thanks Terry. I've submitted a PR for the textview docstrings and PEP8 names and I'll work on the ttk conversion and the refactoring. -- ___ Python tracker

[issue30290] IDLE: add tests for help_about.py

2017-05-27 Thread Cheryl Sabella
Changes by Cheryl Sabella : -- pull_requests: +1922 ___ Python tracker ___ ___

[issue29626] Issue with spacing in argparse module while using help

2017-05-27 Thread Cheryl Sabella
Cheryl Sabella added the comment: I submitted a PR for this based on paul.j3's suggested change: def _format_action_invocation(self, action): for option_string in action.option_strings: if len(args_string)>0: parts.append('%s

[issue30494] python.exe crashed when open long path in windows 7

2017-05-27 Thread aokaywe
New submission from aokaywe: 1.

[issue30492] 'make clinic' does not work for out of tree builds / clinic.py is not in the devguide

2017-05-27 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 178418ad6791b6ef5ba610ed93fab75fc1567ad2 by Gregory P. Smith in branch 'master': bpo-30492: Allow make clinic to work out of tree. (#1836) https://github.com/python/cpython/commit/178418ad6791b6ef5ba610ed93fab75fc1567ad2 --

[issue30491] Add a lightweight mechanism for detecting un-awaited coroutine objects

2017-05-27 Thread Matthias Bussonnier
Changes by Matthias Bussonnier : -- nosy: +mbussonn ___ Python tracker ___ ___

[issue30290] IDLE: add tests for help_about.py

2017-05-27 Thread Terry J. Reedy
Terry J. Reedy added the comment: While reviewing, I decided to draw a widget tree. I believe it would have been easier if packs and grids were grouped. I want to continue with 'IDLE: modernize help-about' and ditto for textview. The help_about issue can begin with ttk conversion: change

[issue29626] Issue with spacing in argparse module while using help

2017-05-27 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Does an empty metavar make sense? This makes the option with argument non-distinguising from the option without argument. -- nosy: +serhiy.storchaka ___ Python tracker

[issue30493] Increase coverage of base64

2017-05-27 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Please don't change the code of base64. It is correct. 1. Python is a dynamically-typed language. Arbitrary exceptions can be raised in unexpected places. For example TypeError can be raised if `b[i:i + 5]` return non-iterable object. 2. `read(n)` of

[issue13349] Non-informative error message in index() and remove() functions

2017-05-27 Thread Raymond Hettinger
Raymond Hettinger added the comment: > I'm fine with not changing this Thanks Brett. I'm going to mark this as closed/rejected. After five years, it is time to put it to rest and let it stop consuming our mental clock cycles. > I don't think you're guaranteed to have access to the object >

[issue30431] input function truncates prompt by NULL byte

2017-05-27 Thread Eryk Sun
Eryk Sun added the comment: The solution to raise a ValueError for the PyOS_Readline case won't change the behavior of input() in cases where the prompt is written to sys.stdout. As to copying what print() would do, I guess it's possible to fake it for common platforms. You'd have to process

[issue29626] Issue with spacing in argparse module while using help

2017-05-27 Thread R. David Murray
Changes by R. David Murray : -- nosy: +r.david.murray ___ Python tracker ___ ___

[issue30493] Increase coverage of base64

2017-05-27 Thread Lee Cannon
Changes by Lee Cannon : -- pull_requests: +1921 ___ Python tracker ___ ___

[issue30493] Increase coverage of base64

2017-05-27 Thread Lee Cannon
New submission from Lee Cannon: Added tests to ensure a85decode correctly handles the 'y' character within the byte like object when foldspaces is true. While attempting to increase coverage I found two lines of code within base64.py that appear to never execute: - line 472 - line 501

[issue30386] Add a build infrastructure for Android

2017-05-27 Thread Xavier de Gaye
Xavier de Gaye added the comment: Details of commit "Add Makefile targets to implement the buildbot steps" in 543a287c32a714a668e426ceb80f4add92cc5de4: The following buildbot steps, as defined by the UnixBuild class of the master.cfg buildbot configuration file, have now their corresponding

[issue13349] Non-informative error message in index() and remove() functions

2017-05-27 Thread Brett Cannon
Brett Cannon added the comment: I'm fine with not changing this, but I did want to say that I don't think you're guaranteed to have access to the object that triggered the ValueError. If the value that is searched for is in some extension module where it's calculated using C code then you

[issue30290] IDLE: add tests for help_about.py

2017-05-27 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 5a346d5dbc1f0f70eca706a8ba19f7645bf17837 by terryjreedy (csabella) in branch 'master': bpo-30290: IDLE: Refactor help_about to PEP8 names (#1714) https://github.com/python/cpython/commit/5a346d5dbc1f0f70eca706a8ba19f7645bf17837 --

[issue30492] 'make clinic' does not work for out of tree builds / clinic.py is not in the devguide

2017-05-27 Thread Gregory P. Smith
Gregory P. Smith added the comment: My PR doesn't address the potential issue of needing to have done a make all before doing a make clinic. I'll leave that for something else, there could be bootstrapping issues in that situation depending on what the developer is doing. In that less common

[issue30492] 'make clinic' does not work for out of tree builds / clinic.py is not in the devguide

2017-05-27 Thread Gregory P. Smith
Changes by Gregory P. Smith : -- pull_requests: +1920 ___ Python tracker ___ ___

[issue13349] Non-informative error message in index() and remove() functions

2017-05-27 Thread Joe Jevnik
Changes by Joe Jevnik : -- pull_requests: +1919 ___ Python tracker ___ ___

[issue30477] tuple.index error message improvement

2017-05-27 Thread Brett Cannon
Changes by Brett Cannon : -- resolution: -> duplicate stage: -> resolved status: open -> closed ___ Python tracker ___

[issue30492] 'make clinic' does not work for out of tree builds / clinic.py is not in the devguide

2017-05-27 Thread Gregory P. Smith
Gregory P. Smith added the comment: The Makefile knows where the source tree is, I think we can make it tell clinic.py. Let me whip something up. -- ___ Python tracker

[issue29626] Issue with spacing in argparse module while using help

2017-05-27 Thread Cheryl Sabella
Changes by Cheryl Sabella : -- pull_requests: +1918 ___ Python tracker ___ ___

[issue30492] 'make clinic' does not work for out of tree builds / clinic.py is not in the devguide

2017-05-27 Thread Larry Hastings
Larry Hastings added the comment: I don't know how to fix it. "make clinic" needs to be run in-tree anyway as it's modifying the C source code in place. Can you suggest a patch? -- ___ Python tracker

[issue16500] Allow registering at-fork handlers

2017-05-27 Thread Gregory P. Smith
Changes by Gregory P. Smith : -- pull_requests: +1917 ___ Python tracker ___ ___

[issue30492] 'make clinic' does not work for out of tree builds / clinic.py is not in the devguide

2017-05-27 Thread Gregory P. Smith
New submission from Gregory P. Smith: I never do in-tree builds anymore because they make me feel dirty and leave build artifacts cluttering up my source tree. make clinic does not work for out of tree builds. To reproduce: ~$ git clone ...cpython repo... ~$ mkdir build && cd build ~/build$

[issue13349] Non-informative error message in index() and remove() functions

2017-05-27 Thread Raymond Hettinger
Raymond Hettinger added the comment: Thinking back over my 17 years of using Python, I really don't think this is needed at all. I can't think of a single situation where it would have helped. In some cases, the change would be detrimental to readability, introducing clutter into an

[issue22702] to improve documentation for join() (str method)

2017-05-27 Thread Raymond Hettinger
Raymond Hettinger added the comment: > Do you think that's sufficient to fully resolve the request here, Thanks Nick. That will suffice. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker

[issue30444] Add ability to change "-- more --" text in pager module

2017-05-27 Thread Raymond Hettinger
Raymond Hettinger added the comment: My preference is to keep pydoc focused on its primary task. This proposal seems like "feature creep" and the benefit is of questionable importance. -- nosy: +rhettinger ___ Python tracker

[issue20210] Support the *disabled* marker in Setup files

2017-05-27 Thread Xavier de Gaye
Changes by Xavier de Gaye : -- resolution: -> fixed stage: -> resolved status: open -> closed title: Provide configure options to enable/disable Python modules and extensions -> Support the *disabled* marker in Setup files ___

[issue20210] Provide configure options to enable/disable Python modules and extensions

2017-05-27 Thread Xavier de Gaye
Xavier de Gaye added the comment: New changeset c0364fc7c2693fb070917ee62aeb8d2551710821 by xdegaye in branch 'master': bpo-20210: Support the *disabled* marker in Setup files (GH-132) https://github.com/python/cpython/commit/c0364fc7c2693fb070917ee62aeb8d2551710821 --

[issue30444] Add ability to change "-- more --" text in pager module

2017-05-27 Thread Gautam krishna.R
Gautam krishna.R added the comment: Yes even if it was built for PyDoc why cant we can extend its functionality to make it work with others too, Without breaking its current functionality... -- ___ Python tracker

[issue29828] Allow registering after-fork initializers in multiprocessing

2017-05-27 Thread Antoine Pitrou
Antoine Pitrou added the comment: Superseded by issue 16500, which has now been resolved! -- resolution: -> duplicate stage: needs patch -> resolved status: open -> closed superseder: -> Allow registering at-fork handlers ___ Python tracker

[issue16500] Allow registering at-fork handlers

2017-05-27 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue16500] Allow registering at-fork handlers

2017-05-27 Thread Antoine Pitrou
Antoine Pitrou added the comment: New changeset 346cbd351ee0dd3ab9cb9f0e4cb625556707877e by Antoine Pitrou in branch 'master': bpo-16500: Allow registering at-fork handlers (#1715) https://github.com/python/cpython/commit/346cbd351ee0dd3ab9cb9f0e4cb625556707877e --

[issue30470] Deprecate invalid ctypes call protection on Windows

2017-05-27 Thread Mariatta Wijaya
Changes by Mariatta Wijaya : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___

[issue30470] Deprecate invalid ctypes call protection on Windows

2017-05-27 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: New changeset 2ee91c8ad825079cdfc0d98f3f439f3b1c8ca471 by Mariatta in branch '3.6': [3.6] bpo-30470: Deprecate invalid ctypes call protection on Windows. (GH-1810) (GH-1833) https://github.com/python/cpython/commit/2ee91c8ad825079cdfc0d98f3f439f3b1c8ca471

[issue30431] input function truncates prompt by NULL byte

2017-05-27 Thread Terry J. Reedy
Terry J. Reedy added the comment: As near as I can tell, the patch introduces a regression. The doc for input(prompt) says "If the prompt argument is present, it is written to standard output without a trailing newline." The handling of the prompt is up to stdout.write and thence physical

[issue30470] Deprecate invalid ctypes call protection on Windows

2017-05-27 Thread Mariatta Wijaya
Changes by Mariatta Wijaya : -- pull_requests: +1916 ___ Python tracker ___ ___

[issue30470] Deprecate invalid ctypes call protection on Windows

2017-05-27 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: New changeset f931fd1c2ad969db72460d3ab41e3d1a4a62c371 by Mariatta in branch 'master': bpo-30470: Deprecate invalid ctypes call protection on Windows. (GH-1810) https://github.com/python/cpython/commit/f931fd1c2ad969db72460d3ab41e3d1a4a62c371 --

[issue29960] _random.Random state corrupted on exception

2017-05-27 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: Thanks Bryan and Serhiy. -- resolution: -> fixed stage: backport needed -> resolved status: open -> closed ___ Python tracker

[issue29960] _random.Random state corrupted on exception

2017-05-27 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: New changeset 1626a479e22db3d44bcd6736d571243433cb6d0e by Mariatta in branch '2.7': [2.7] bpo-29960 _random.Random corrupted on exception in setstate(). … (#1289) https://github.com/python/cpython/commit/1626a479e22db3d44bcd6736d571243433cb6d0e --

[issue29960] _random.Random state corrupted on exception

2017-05-27 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: New changeset 94d8261d1ca3f0c551d9d43a4db342d806af7a6a by Mariatta in branch '3.6': [3.6] bpo-29960 _random.Random corrupted on exception in setstate(). … (#1287) https://github.com/python/cpython/commit/94d8261d1ca3f0c551d9d43a4db342d806af7a6a --

[issue29960] _random.Random state corrupted on exception

2017-05-27 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: New changeset 440bc4f4b2690b99541e87bedfdb0dc4abbc0501 by Mariatta in branch '3.5': [3.5] bpo-29960 _random.Random corrupted on exception in setstate(). … (#1288) https://github.com/python/cpython/commit/440bc4f4b2690b99541e87bedfdb0dc4abbc0501 --

[issue30431] input function truncates prompt by NULL byte

2017-05-27 Thread Terry J. Reedy
Terry J. Reedy added the comment: Experiments running 3.6.1 on Windows in console: >python -c "print('some\0 text') some text # \0 printed as ' ', as determined by # >python -c "for c in 'some text': print(ord(c))" printing 32 32 >python -c "input('some\0 text') some In IDLE, both print

[issue30310] tkFont.py assumes that all font families are encoded as ascii in Python 2.7

2017-05-27 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset a92adf8f0782a1ccdc68942767bdb357a9281b30 by Serhiy Storchaka in branch 'master': bpo-30310: Add a test for non-ascii font family. (#1567) (#1832) https://github.com/python/cpython/commit/a92adf8f0782a1ccdc68942767bdb357a9281b30 --

[issue30398] Add a docstring for re.error

2017-05-27 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue30398] Add a docstring for re.error

2017-05-27 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset a815b5a100f38b883b08d39567c5557de2c19a53 by Serhiy Storchaka in branch '3.5': [3.5] bpo-30398: Add a docstring for re.error. (GH-1647) (#1831) https://github.com/python/cpython/commit/a815b5a100f38b883b08d39567c5557de2c19a53 --

[issue30398] Add a docstring for re.error

2017-05-27 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset b52c68a5a3f546cbbe1589f8bb3e51bfd55a6c15 by Serhiy Storchaka in branch '3.6': [3.6] bpo-30398: Add a docstring for re.error. (GH-1647) (#1830) https://github.com/python/cpython/commit/b52c68a5a3f546cbbe1589f8bb3e51bfd55a6c15 --

[issue30310] tkFont.py assumes that all font families are encoded as ascii in Python 2.7

2017-05-27 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- pull_requests: +1915 ___ Python tracker ___ ___

[issue30398] Add a docstring for re.error

2017-05-27 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- pull_requests: +1914 ___ Python tracker ___ ___

[issue30398] Add a docstring for re.error

2017-05-27 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- pull_requests: +1913 ___ Python tracker ___ ___

[issue30398] Add a docstring for re.error

2017-05-27 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 12d6b5d156377c0877931a03ef2439dccb2f3711 by Serhiy Storchaka in branch 'master': bpo-30398: Add a docstring for re.error. (#1647) https://github.com/python/cpython/commit/12d6b5d156377c0877931a03ef2439dccb2f3711 --

[issue30482] socket.getservbyname(), socket.getservbyport(), socket.getprotobyname() are not threadsafe

2017-05-27 Thread Nathaniel Smith
Changes by Nathaniel Smith : -- nosy: +njs ___ Python tracker ___ ___ Python-bugs-list

[issue30491] Add a lightweight mechanism for detecting un-awaited coroutine objects

2017-05-27 Thread Nathaniel Smith
New submission from Nathaniel Smith: A common problem when working with async functions is to attempt to call them but forget the 'await', which eventually leads to a 'Warning: coroutine ... was never awaited' (possibly buried in the middle of a bunch of traceback shrapnel caused by follow-on

[issue30486] Allow setting cell value

2017-05-27 Thread Nick Coghlan
Nick Coghlan added the comment: +1 from me, as this also has potential value in testing use cases and in dealing with some of the consequences of the zero-arg super() design (i.e. it will make the injected __class__ cell writable) -- ___ Python