[issue33671] Efficient zero-copy for shutil.copy* functions (Linux, OSX and Win)

2018-05-28 Thread Stefan Behnel
Stefan Behnel added the comment: Regarding the benchmarks, just to be sure, did you try reversing the run order to make sure you don't get unfair caching effects for the later runs? -- ___ Python tracker

[issue32038] Add API to intercept socket.close()

2018-05-28 Thread Yury Selivanov
Yury Selivanov added the comment: Closing this one. Using private socket.socket APIs works fine for uvloop/asyncio. -- resolution: -> rejected stage: -> resolved status: open -> closed type: -> enhancement ___ Python tracker

[issue33667] Mock calls on mutable objects

2018-05-28 Thread R. David Murray
Change by R. David Murray : -- resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> Python unittest.mock.mock_calls stores references to arguments instead of their values ___ Python tracker

[issue32610] asyncio.all_tasks() should return only non-finished tasks.

2018-05-28 Thread Yury Selivanov
Yury Selivanov added the comment: After an off-list discussion I think I was able to convince Andrew to change the behaviour of the newly added asyncio.all_tasks() to return only pending tasks. The logic behind this is that: 1. there's no good known use case for returning a list of all

[issue32458] test_asyncio: test_start_tls_server_1() fails randomly

2018-05-28 Thread miss-islington
miss-islington added the comment: New changeset 4b828467a3fcec0c1947e8326f67b8db12a4f303 by Miss Islington (bot) in branch '3.7': bpo-32458: Further tune start_tls tests (GH-7166) https://github.com/python/cpython/commit/4b828467a3fcec0c1947e8326f67b8db12a4f303 -- nosy:

[issue33674] asyncio: race condition in SSLProtocol

2018-05-28 Thread STINNER Victor
STINNER Victor added the comment: loop.start_tls() method is new in Python 3.7. If possible, I would prefer to not see it with a builtin race condition, since such race condition is really hard to debug :-( So I raise the priority to release blocker. Sorry again Ned! -- nosy:

[issue32458] test_asyncio: test_start_tls_server_1() fails randomly

2018-05-28 Thread STINNER Victor
STINNER Victor added the comment: While Yury seems unable to reproduce the bug, it's easy for me to reproduce it on Linux. After 2 hours of debugging, I found the root issue: a race condition not in the test, but in asyncio itself! => bpo-33674 "asyncio: race condition in SSLProtocol".

[issue32610] asyncio.all_tasks() should return only non-finished tasks.

2018-05-28 Thread Yury Selivanov
Change by Yury Selivanov : -- keywords: +patch pull_requests: +6809 stage: -> patch review ___ Python tracker ___ ___

[issue32458] test_asyncio: test_start_tls_server_1() fails randomly

2018-05-28 Thread Yury Selivanov
Yury Selivanov added the comment: New changeset 8267ea2e84d355f00654dec3ad782fc7b1f680f1 by Yury Selivanov in branch 'master': bpo-32458: Further tune start_tls tests (#7166) https://github.com/python/cpython/commit/8267ea2e84d355f00654dec3ad782fc7b1f680f1 --

[issue33614] Compilation of Python fails on AMD64 Windows8.1 Refleaks 3.x

2018-05-28 Thread miss-islington
miss-islington added the comment: New changeset c489a767af46f33e73d96a5746e46a7365814db2 by Miss Islington (bot) in branch '3.6': bpo-33614: Ensures module definition files for the stable ABI on Windows are correctly regenerated. (GH-7165)

[issue31647] asyncio: StreamWriter write_eof() after close raises mysterious AttributeError

2018-05-28 Thread Yury Selivanov
Yury Selivanov added the comment: New changeset 7e8819a589c7630db9d440826143ad0a1daf948e by Yury Selivanov (Miss Islington (bot)) in branch '3.6': bpo-31647: Fix write_eof() after close() for SelectorSocketTransport (GH-7149) (#7154)

[issue33674] asyncio: race condition in SSLProtocol

2018-05-28 Thread STINNER Victor
STINNER Victor added the comment: Workaround: diff --git a/Lib/asyncio/sslproto.py b/Lib/asyncio/sslproto.py index 2bfa45dd15..4a5dbb38a1 100644 --- a/Lib/asyncio/sslproto.py +++ b/Lib/asyncio/sslproto.py @@ -592,7 +592,7 @@ class SSLProtocol(protocols.Protocol): # (b'', 1) is a

[issue33674] asyncio: race condition in SSLProtocol

2018-05-28 Thread STINNER Victor
New submission from STINNER Victor : While debugging bpo-32458 (functional test on START TLS), I found a race condition in SSLProtocol of asyncio/sslproto.py. Sometimes, _sslpipe.feed_ssldata() is called before _sslpipe.shutdown(). * SSLProtocol.connection_made() ->

[issue33614] Compilation of Python fails on AMD64 Windows8.1 Refleaks 3.x

2018-05-28 Thread Steve Dower
Steve Dower added the comment: Thanks! I guess we were getting lucky in the past, as that error could have shown up for any number of reasons... -- ___ Python tracker ___

[issue33672] Fix Task.__repr__ crash when trying to format Cython's bogus coroutines

2018-05-28 Thread miss-islington
Change by miss-islington : -- pull_requests: +6808 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32523] inconsistent spacing in changelog.html

2018-05-28 Thread Ned Deily
Ned Deily added the comment: @mdk, Would you have time to take a look at this? Thanks! -- nosy: +mdk versions: +Python 3.8 ___ Python tracker ___

[issue12486] tokenize module should have a unicode API

2018-05-28 Thread Thomas Kluyver
Thomas Kluyver added the comment: The tests on PR #6957 are passing now, if anyone has time to have a look. :-) -- ___ Python tracker ___

[issue33672] Fix Task.__repr__ crash when trying to format Cython's bogus coroutines

2018-05-28 Thread Yury Selivanov
New submission from Yury Selivanov : New changeset 989b9e0e6d7dd2fa911f9bfd4744e7f3a82d6006 by Yury Selivanov in branch 'master': bpo-33672: Fix Task.__repr__ crash with Cython's bogus coroutines (GH-7161) https://github.com/python/cpython/commit/989b9e0e6d7dd2fa911f9bfd4744e7f3a82d6006

[issue32410] Implement loop.sock_sendfile method

2018-05-28 Thread Yury Selivanov
Change by Yury Selivanov : -- pull_requests: +6807 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33671] Efficient zero-copy for shutil.copy* functions (Linux, OSX and Win)

2018-05-28 Thread Stefan Behnel
Stefan Behnel added the comment: Nice, I really like this. Apart from the usual bit of minor style issues, I couldn't see anything inherently wrong with the PR, but I'll leave the detailed reviews to those who'd have to maintain the code in the future. :) -- nosy: +scoder

[issue33614] Compilation of Python fails on AMD64 Windows8.1 Refleaks 3.x

2018-05-28 Thread Ned Deily
Ned Deily added the comment: Steve - PR 7165 appears to have caused a buildbot failure: http://buildbot.python.org/all/#/builders/12/builds/910 -- ___ Python tracker ___

[issue33614] Compilation of Python fails on AMD64 Windows8.1 Refleaks 3.x

2018-05-28 Thread miss-islington
Change by miss-islington : -- pull_requests: +6803 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33614] Compilation of Python fails on AMD64 Windows8.1 Refleaks 3.x

2018-05-28 Thread miss-islington
Change by miss-islington : -- pull_requests: +6802 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33614] Compilation of Python fails on AMD64 Windows8.1 Refleaks 3.x

2018-05-28 Thread Steve Dower
Steve Dower added the comment: New changeset e97ba4c690613d734843db218aeedce2f0e5937f by Steve Dower in branch 'master': bpo-33614: Ensures module definition files for the stable ABI on Windows are correctly regenerated. (GH-7165)

[issue33667] Mock calls on mutable objects

2018-05-28 Thread Pawel
Pawel added the comment: Ok, fair enough. Thank You for explanation. I was just surprised with this behaviour. On the other hand, I don't like mutable objects and I'm trying to avoid them. -- ___ Python tracker

[issue32458] test_asyncio: test_start_tls_server_1() fails randomly

2018-05-28 Thread Yury Selivanov
Change by Yury Selivanov : -- pull_requests: +6801 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33505] Optimize asyncio.ensure_future by reordering if conditions

2018-05-28 Thread Yury Selivanov
Change by Yury Selivanov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue33654] asyncio: transports don't support switching between Protocol and BufferedProtocol

2018-05-28 Thread Yury Selivanov
Change by Yury Selivanov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed type: -> behavior ___ Python tracker ___

[issue32832] doctest should support custom ps1/ps2 prompts

2018-05-28 Thread Sergey B Kirpichev
Sergey B Kirpichev added the comment: > They support _more than one_ set of PS1/PS2 conventions. I saw this, not sure if that's required. IMHO, same effect should be possible by running doctest several times with different conventions. > Who would it help? In principle, any project, that

[issue30945] loop.create_server does not detect if the interface is IPv6 enabled

2018-05-28 Thread Yury Selivanov
Yury Selivanov added the comment: Does anybody wants to make a PR to fix this? -- ___ Python tracker ___ ___ Python-bugs-list

[issue32762] Choose protocol implementation on transport.set_protocol()

2018-05-28 Thread Yury Selivanov
Yury Selivanov added the comment: Closing in favour of https://bugs.python.org/issue33654 -- resolution: -> duplicate stage: -> resolved status: open -> closed type: -> behavior ___ Python tracker

[issue33669] str.format should raise exception when placeholder number doesn't match argument number

2018-05-28 Thread Eric V. Smith
Eric V. Smith added the comment: I still think it's a job for a linter, even if the compiler optimizes away the call to .format(). -- ___ Python tracker ___

[issue33614] Compilation of Python fails on AMD64 Windows8.1 Refleaks 3.x

2018-05-28 Thread Steve Dower
Change by Steve Dower : -- keywords: +patch pull_requests: +6800 stage: needs patch -> patch review ___ Python tracker ___ ___

[issue33654] asyncio: transports don't support switching between Protocol and BufferedProtocol

2018-05-28 Thread miss-islington
miss-islington added the comment: New changeset bc3a002e7d5a921e233a5ee0b0f5610c6510b647 by Miss Islington (bot) in branch '3.7': bpo-33654: Support BufferedProtocol in set_protocol() and start_tls() (GH-7130) https://github.com/python/cpython/commit/bc3a002e7d5a921e233a5ee0b0f5610c6510b647

[issue33505] Optimize asyncio.ensure_future by reordering if conditions

2018-05-28 Thread Yury Selivanov
Yury Selivanov added the comment: New changeset f8fdb368e3d8d048bffc248fbe1023651c276671 by Yury Selivanov (Miss Islington (bot)) in branch '3.7': bpo-33505: Optimize asyncio.ensure_future by reordering if conditions (GH-6836) (#7162)

[issue32458] test_asyncio: test_start_tls_server_1() fails randomly

2018-05-28 Thread Yury Selivanov
Yury Selivanov added the comment: https://github.com/python/cpython/pull/7130 is in. It includes many tests for TLS tests as well as bugfixes to asyncio code. Hopefully this all will make tests more stable. -- ___ Python tracker

[issue33654] asyncio: transports don't support switching between Protocol and BufferedProtocol

2018-05-28 Thread miss-islington
Change by miss-islington : -- pull_requests: +6799 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33654] asyncio: transports don't support switching between Protocol and BufferedProtocol

2018-05-28 Thread Yury Selivanov
Yury Selivanov added the comment: New changeset dbf102271fcc316f353c7e0a283811b661d128f2 by Yury Selivanov in branch 'master': bpo-33654: Support BufferedProtocol in set_protocol() and start_tls() (GH-7130) https://github.com/python/cpython/commit/dbf102271fcc316f353c7e0a283811b661d128f2

[issue33673] Install python-docs-theme even if Sphinx is already installed

2018-05-28 Thread Andrés Delfino
Andrés Delfino added the comment: This applies to Windows's make.bat. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue33673] Install python-docs-theme even if Sphinx is already installed

2018-05-28 Thread Andrés Delfino
Change by Andrés Delfino : -- keywords: +patch pull_requests: +6798 stage: -> patch review ___ Python tracker ___ ___

[issue33673] Install python-docs-theme even if Sphinx is already installed

2018-05-28 Thread Andrés Delfino
New submission from Andrés Delfino : python-docs-theme is being installed only if Sphinx is not installed too. PR fixes this. -- components: Demos and Tools messages: 317892 nosy: adelfino priority: normal severity: normal status: open title: Install python-docs-theme even if Sphinx is

[issue33669] str.format should raise exception when placeholder number doesn't match argument number

2018-05-28 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: If issue28308 be implemented, it may be that the Python compiler itself will emit a warning. -- ___ Python tracker ___

[issue33669] str.format should raise exception when placeholder number doesn't match argument number

2018-05-28 Thread Eric V. Smith
Eric V. Smith added the comment: This was a deliberate design choice, and as Serhiy notes, at least partially driven by translations. It seems to me it would be a job for a linter to point out a problem, if the string is a constant. -- nosy: +eric.smith

[issue33469] RuntimeError after closing loop that used run_in_executor

2018-05-28 Thread Yury Selivanov
Yury Selivanov added the comment: Ah, I see, the callback that tracks the state of the wrapped concurrent.Future doesn't check that the loop is closed and its future has been cancelled. I think this is a bug. -- ___ Python tracker

[issue32591] Deprecate sys.set_coroutine_wrapper and replace it with more focused API(s)

2018-05-28 Thread Yury Selivanov
Change by Yury Selivanov : -- stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue33505] Optimize asyncio.ensure_future by reordering if conditions

2018-05-28 Thread miss-islington
Change by miss-islington : -- pull_requests: +6797 ___ Python tracker ___

[issue33469] RuntimeError after closing loop that used run_in_executor

2018-05-28 Thread Yury Selivanov
Yury Selivanov added the comment: Hopefully asyncio.run() in Python 3.7 will handle this case correctly. -- ___ Python tracker

[issue33505] Optimize asyncio.ensure_future by reordering if conditions

2018-05-28 Thread Yury Selivanov
Yury Selivanov added the comment: New changeset e549c4be5fb010f5faf12236af8faa720a1429be by Yury Selivanov (jimmylai) in branch 'master': bpo-33505: Optimize asyncio.ensure_future by reordering if conditions (GH-6836)

[issue23749] asyncio missing wrap_socket (starttls)

2018-05-28 Thread Yury Selivanov
Change by Yury Selivanov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue31096] asyncio.stream.FlowControlMixin._drain_helper may lead to a blocking behavior

2018-05-28 Thread Yury Selivanov
Yury Selivanov added the comment: Documenting this would be a great first step. -- ___ Python tracker ___

[issue32374] Document that m_traverse for multi-phase initialized modules can be called with m_state=NULL

2018-05-28 Thread miss-islington
miss-islington added the comment: New changeset 6ec325d48348fb52a421354ba563ff9c1f368054 by Miss Islington (bot) in branch '3.6': bpo-32374: Ignore Python-level exceptions in test_bad_traverse (GH-7145)

[issue33671] Efficient zero-copy for shutil.copy* functions (Linux, OSX and Win)

2018-05-28 Thread Giampaolo Rodola'
Change by Giampaolo Rodola' : -- nosy: +SilentGhost, StyXman, asvetlov, desbma, facundobatista, gps, josh.r, martin.panter, ncoghlan, neologix, petr.viktorin, pitrou, python-dev, r.david.murray, tarek, vstinner, yselivanov ___

[issue33667] Mock calls on mutable objects

2018-05-28 Thread Lady Red
Lady Red added the comment: To have the behavior that you are expecting, I believe the mock would have to store a deep copy of every mutable object that is passed in to any of it's calls, in case that object later mutates. That would really expand the memory and time

[issue33672] Fix Task.__repr__ crash when trying to format Cython's bogus coroutines

2018-05-28 Thread Yury Selivanov
Change by Yury Selivanov : -- keywords: +patch pull_requests: +6796 stage: -> patch review ___ Python tracker ___

[issue33672] Fix Task.__repr__ crash when trying to format Cython's bogus coroutines

2018-05-28 Thread Yury Selivanov
Change by Yury Selivanov : -- components: asyncio nosy: asvetlov, yselivanov priority: normal severity: normal status: open title: Fix Task.__repr__ crash when trying to format Cython's bogus coroutines type: behavior versions: Python 3.6, Python 3.7, Python 3.8

[issue33639] Use high-performance os.sendfile() in shutil.copy*

2018-05-28 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: Closing as duplicate of #33671. -- stage: resolved -> patch review ___ Python tracker ___

[issue33639] Use high-performance os.sendfile() in shutil.copy*

2018-05-28 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: Closing as duplicate of #33671. -- resolution: -> duplicate stage: patch review -> resolved status: open -> closed superseder: -> Efficient zero-copy for shutil.copy* functions (Linux, OSX and Win)

[issue33666] Document removal of os.errno

2018-05-28 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: And here is a list of names removed in 3.6: asynchat.fifo asyncio.coroutines.futures asyncio.futures.Error asyncio.futures.reprlib asyncio.tasks.linecache asyncio.tasks.traceback copy.builtins copy._copy_with_constructor

[issue33671] Efficient zero-copy for shutil.copy* functions (Linux, OSX and Win)

2018-05-28 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: PR: https://github.com/python/cpython/pull/7160 -- ___ Python tracker ___

[issue33671] Efficient zero-copy for shutil.copy* functions (Linux, OSX and Win)

2018-05-28 Thread Giampaolo Rodola'
Change by Giampaolo Rodola' : -- pull_requests: +6795 ___ Python tracker ___ ___

[issue33671] Efficient zero-copy for shutil.copy* functions (Linux, OSX and Win)

2018-05-28 Thread Giampaolo Rodola'
Change by Giampaolo Rodola' : -- title: Efficient efficient zero-copy syscalls for shutil.copy* functions (Linux, OSX and Win) -> Efficient zero-copy for shutil.copy* functions (Linux, OSX and Win) ___ Python tracker

[issue31647] asyncio: StreamWriter write_eof() after close raises mysterious AttributeError

2018-05-28 Thread Yury Selivanov
Change by Yury Selivanov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue31647] asyncio: StreamWriter write_eof() after close raises mysterious AttributeError

2018-05-28 Thread Yury Selivanov
Yury Selivanov added the comment: Merged, thanks for looking into this! BTW, if you have any other bugfixes in mind, today is pretty much last chance to get them into 3.7.0 -- ___ Python tracker

[issue33671] Efficient efficient zero-copy syscalls for shutil.copy* functions (Linux, OSX and Win)

2018-05-28 Thread Giampaolo Rodola'
New submission from Giampaolo Rodola' : Patch in attachment uses platform specific zero-copy syscalls on Linux and Solaris (os.sendfile(2)), Windows (CopyFileW) and OSX (fcopyfile(2)) speeding up shutil.copyfile() and other functions using it (copy(), copy2(), copytree(),

[issue31467] cElementTree behaves differently compared to ElementTree

2018-05-28 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: -6786 ___ Python tracker ___

[issue31647] asyncio: StreamWriter write_eof() after close raises mysterious AttributeError

2018-05-28 Thread Yury Selivanov
Yury Selivanov added the comment: New changeset 1f21ae710d83a37c872355612b58958cef4d5f95 by Yury Selivanov (Miss Islington (bot)) in branch '3.7': bpo-31647: Fix write_eof() after close() for SelectorSocketTransport (GH-7149) (GH-7153)

[issue33666] Document removal of os.errno

2018-05-28 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Here is a list of all names removed in 3.7 (except modules that was removed as a whole): abc.WeakSet argparse._collections argparse._copy argparse._ensure_value argparse._textwrap ast._NUM_TYPES asyncio.async

[issue32533] SSLSocket read/write thread-unsafety

2018-05-28 Thread Steve Dower
Change by Steve Dower : -- keywords: +patch pull_requests: +6794 stage: needs patch -> patch review ___ Python tracker ___

[issue33257] Race conditions in Tkinter with non-threaded Tcl

2018-05-28 Thread Ivan Pozdeev
Ivan Pozdeev added the comment: Found yet another race condition -- when creating multiple Tk()s. Attached example (loops indefinitely inside Tcl: some internal list becomes circular for some reason). The obvious fix by wrapping Tcl calls with locks in Tkapp_New

[issue33670] Use errorlevel of Sphinx main() in Doc\make.bat

2018-05-28 Thread Andrés Delfino
Andrés Delfino added the comment: After the PR: C:\Users\adelfino\Desktop\Personal\repos\cpython\Doc>make venv Using py -3.6 (found with py.exe) Merging Misc/NEWS with py -3.6 -m blurb Running Sphinx v1.7.4 Sphinx error: Builder name venv not registered or available

[issue32458] test_asyncio: test_start_tls_server_1() fails randomly

2018-05-28 Thread Giampaolo Rodola'
Change by Giampaolo Rodola' : -- nosy: -giampaolo.rodola ___ Python tracker ___ ___

[issue32458] test_asyncio: test_start_tls_server_1() fails randomly

2018-05-28 Thread STINNER Victor
STINNER Victor added the comment: > OK, sounds good, will do that. Race condition! I created https://github.com/python/cpython/pull/7157 to increase the timeout from 5 seconds to 60 seconds. -- ___ Python tracker

[issue32458] test_asyncio: test_start_tls_server_1() fails randomly

2018-05-28 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +6793 ___ Python tracker ___ ___

[issue32458] test_asyncio: test_start_tls_server_1() fails randomly

2018-05-28 Thread Yury Selivanov
Yury Selivanov added the comment: > If the purpose is to detect when the test hangs: use a timeout of 5 minutes, > or at least 1 minute (60 seconds). OK, sounds good, will do that. -- ___ Python tracker

[issue32458] test_asyncio: test_start_tls_server_1() fails randomly

2018-05-28 Thread STINNER Victor
STINNER Victor added the comment: > Yeah, I agree. The current timeout for the test is 5 seconds and it tries to > transfer 2mb of data, which isn't that much actually. I'll bump the timeout > and reduce the amount of data transferred in >

[issue33670] Use errorlevel of Sphinx main() in Doc\make.bat

2018-05-28 Thread Andrés Delfino
Change by Andrés Delfino : -- keywords: +patch pull_requests: +6792 stage: -> patch review ___ Python tracker ___

[issue33670] Use errorlevel of Sphinx main() in Doc\make.bat

2018-05-28 Thread Andrés Delfino
New submission from Andrés Delfino : Doc\make.bat is exiting without exposing Sphinx's main() return value, showing weird things like: C:\Users\adelfino\Desktop\Personal\repos\cpython\Doc>make venv Using py -3.6 (found with py.exe) Merging Misc/NEWS with py -3.6 -m blurb

[issue32374] Document that m_traverse for multi-phase initialized modules can be called with m_state=NULL

2018-05-28 Thread miss-islington
Change by miss-islington : -- pull_requests: +6791 ___ Python tracker ___

[issue32832] doctest should support custom ps1/ps2 prompts

2018-05-28 Thread Tim Peters
Tim Peters added the comment: You missed my point about IPython: forget "In/Out arrays, etc". What you suggest is inadequate for _just_ changing PS1/PS2 for IPython. Again, read their `parse()` function. They support _more than one_ set of PS1/PS2 conventions. So the

[issue33623] Fix possible SIGSGV when asyncio.Future is created in __del__

2018-05-28 Thread miss-islington
miss-islington added the comment: New changeset 51d0a2c8ddcb9f58d71ff0a62be4e31a1af3f139 by Miss Islington (bot) in branch '3.7': bpo-33623: Fix possible SIGSGV when asyncio.Future is created in __del__ (GH-7080)

[issue33669] str.format should raise exception when placeholder number doesn't match argument number

2018-05-28 Thread Xiang Zhang
Xiang Zhang added the comment: Yes, this is a breaking change. A currently working piece of code suddenly raises an exception. But, please note Serhiy in your example you have the same bug as me, you've gotten an oversight bug in it: it's {:d} not %s. That's why I want the

[issue31647] asyncio: StreamWriter write_eof() after close raises mysterious AttributeError

2018-05-28 Thread miss-islington
Change by miss-islington : -- pull_requests: +6790 ___ Python tracker ___

[issue31647] asyncio: StreamWriter write_eof() after close raises mysterious AttributeError

2018-05-28 Thread miss-islington
Change by miss-islington : -- pull_requests: +6789 ___ Python tracker ___

[issue33666] Document removal of os.errno

2018-05-28 Thread Petr Viktorin
Change by Petr Viktorin : -- title: os.errno gone absent without official leave (AWOL) -> Document removal of os.errno ___ Python tracker

[issue31647] asyncio: StreamWriter write_eof() after close raises mysterious AttributeError

2018-05-28 Thread Yury Selivanov
Yury Selivanov added the comment: New changeset 23f587e395e41bd5e116312b036183f42bc4159b by Yury Selivanov (twisteroid ambassador) in branch 'master': bpo-31647: Fix write_eof() after close() for SelectorSocketTransport (GH-7149)

[issue33669] str.format should raise exception when placeholder number doesn't match argument number

2018-05-28 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This will break the following case: def geterrmsg(n): return ('function doesn't have arguments' if n == 0 else 'function have a single argument' if n == 1 else 'function have %d arguments')

[issue33623] Fix possible SIGSGV when asyncio.Future is created in __del__

2018-05-28 Thread miss-islington
Change by miss-islington : -- pull_requests: +6788 ___ Python tracker ___

[issue33623] Fix possible SIGSGV when asyncio.Future is created in __del__

2018-05-28 Thread miss-islington
Change by miss-islington : -- pull_requests: +6787 ___ Python tracker ___

[issue33623] Fix possible SIGSGV when asyncio.Future is created in __del__

2018-05-28 Thread Yury Selivanov
Yury Selivanov added the comment: New changeset 35230d08e09de4e2e52658d5cb09e5b0ca965418 by Yury Selivanov in branch 'master': bpo-33623: Fix possible SIGSGV when asyncio.Future is created in __del__ (#7080)

[issue33623] Fix possible SIGSGV when asyncio.Future is created in __del__

2018-05-28 Thread Yury Selivanov
Yury Selivanov added the comment: There's nothing specific here to uvloop except the fact that it was compiled with Cython, so module finalization/GC pattern is slightly different to that of vanilla asyncio. Serhiy, I'm merging this PR since I'd like to avoid having

[issue32458] test_asyncio: test_start_tls_server_1() fails randomly

2018-05-28 Thread Yury Selivanov
Yury Selivanov added the comment: > It's a race condition which doesn't depend on the OS, but on the system load. Yeah, I agree. The current timeout for the test is 5 seconds and it tries to transfer 2mb of data, which isn't that much actually. I'll bump the timeout

[issue33666] os.errno gone absent without official leave (AWOL)

2018-05-28 Thread STINNER Victor
STINNER Victor added the comment: > If document disappearing of os.errno, we should document disappearing of all > other names in other modules in all versions. Miro proposed to document the removal of os.errno since errno is a commonly used module, as the os module. I

[issue33666] os.errno gone absent without official leave (AWOL)

2018-05-28 Thread STINNER Victor
Change by STINNER Victor : -- title: os.errno gone AWOL -> os.errno gone absent without official leave (AWOL) ___ Python tracker

[issue33666] os.errno gone AWOL

2018-05-28 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: If document disappearing of os.errno, we should document disappearing of all other names in other modules in all versions. It is possible to write a script that outputs dir(mod) for all modules and compare results between

[issue33669] str.format should raise exception when placeholder number doesn't match argument number

2018-05-28 Thread Xiang Zhang
New submission from Xiang Zhang : I'm somewhat surprised when I have code like `"hello %s".format(person)` in my project there is no exception raised and "hello %s" returned. Have several tries it seems `str.format` won't check argument number. >>> '{} {}'.format(1)

[issue33623] Fix possible SIGSGV when asyncio.Future is created in __del__

2018-05-28 Thread Peter Bašista
Peter Bašista added the comment: > Can this crash be reproduced without uvloop? I am not aware of a way to reproduce this without uvloop. > What is the backtrace of the assertion failure? Without uvloop, the following exception is raised: Exception ignored in: > Traceback

[issue33666] os.errno gone AWOL

2018-05-28 Thread Miro Hrončok
Miro Hrončok added the comment: I can document this, yes. I've opened this issue so I could prep a PR. -- ___ Python tracker ___

[issue33666] os.errno gone AWOL

2018-05-28 Thread STINNER Victor
STINNER Victor added the comment: > os.errno as well as os.sys or os.abc is an implementation detail. I agree but... > It can be changed without notice even in a bugfix release. Projects that > depend on it are incorrect and should be fixed. I don't think that it would

[issue33666] os.errno gone AWOL

2018-05-28 Thread Petr Viktorin
Petr Viktorin added the comment: I think this was closed prematurely. > Projects that depend on it are incorrect and should be fixed. That's definitely correct; no one here is arguing against it. However, there are projects out there depending on it -- it worked since

[issue33012] Invalid function cast warnings with gcc 8 for METH_NOARGS

2018-05-28 Thread Xavier de Gaye
Xavier de Gaye added the comment: > There are still quite a few similar warnings on git-master. Do they indicate > the same problem or should I open new issues? This is the same issue, the warning line ends with [-Wcast-function-type]. --

<    1   2   3   >