[issue33781] audioop.c: fbound() casts double to int for its return value

2018-06-06 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: It was my mistake. fbound() should be return double. But since it is always used with floor(), it is better to move floor() inside it. -- nosy: +serhiy.storchaka pull_requests: +7073 ___ Python tracker

[issue33781] audioop.c: fbound() casts double to int for its return value

2018-06-06 Thread miss-islington
Change by miss-islington : -- pull_requests: +7072 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue33782] VSTS Windows-PR: internal error

2018-06-06 Thread Steve Dower
Steve Dower added the comment: Right. This build failed to start, which is why there's only one section on the left hand side (normally you'll see all the build steps there, and clicking on them will show their logs). I think it'll be an internal race condition. I'll pass back whatever info

[issue33781] audioop.c: fbound() casts double to int for its return value

2018-06-06 Thread STINNER Victor
STINNER Victor added the comment: New changeset 45e4efba7fa2abe61d25e4f8b5bf482e19ff1280 by Victor Stinner in branch 'master': bpo-33781: audioop: enhance rounding double as int (GH-7447) https://github.com/python/cpython/commit/45e4efba7fa2abe61d25e4f8b5bf482e19ff1280 -- _

[issue33782] VSTS Windows-PR: internal error

2018-06-06 Thread STINNER Victor
STINNER Victor added the comment: > The "build not retained" state just means it'll get cleaned up after seven > days. Oh ok. But I'm confused, I don't see where are the logs. I clicked on Timeline, Code coverage, Tests: all are empty. In the logs ZIP, I cannot see any command related to Py

[issue33774] Document that @lru_cache caches based on exactly how the function arguments are specified

2018-06-06 Thread Al-Scandar Solstag
Al-Scandar Solstag added the comment: Hi Raymond, I think I understand what you mean, and would suggest something along the lines of: """ Note that lru_cache only guarantees cache matches on the exact way function arguments are specified, so the following ways of calling 'def f(a, b=7)' are

[issue31044] FAIL: test_makedev (test.test_posix.PosixTester) on AMD64 FreeBSD CURRENT

2018-06-06 Thread STINNER Victor
STINNER Victor added the comment: I enabled again the test in the master branch, the FreeBSD kernel bug has been fixed 10 months ago: * https://svnweb.freebsd.org/base?view=revision&revision=321920 * https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221048 Technically, we could reenable the

[issue31044] FAIL: test_makedev (test.test_posix.PosixTester) on AMD64 FreeBSD CURRENT

2018-06-06 Thread STINNER Victor
STINNER Victor added the comment: New changeset b5d702e5e7291eed21666ed931da2a5e92c28a65 by Victor Stinner in branch 'master': bpo-31044, test_posix: Reenable makedev() tests on FreeBSD (#7449) https://github.com/python/cpython/commit/b5d702e5e7291eed21666ed931da2a5e92c28a65 -- ___

[issue33779] Error while installing python 3.6.5 on windows 10

2018-06-06 Thread Steve Dower
Steve Dower added the comment: Did you have a previous install? It looks like it is registered but somehow you don't have the ability to replace it. If you're comfortable with using regedit.exe, you could try renaming SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\{9d1b786e-0fd4-4386-ab

[issue33782] VSTS Windows-PR: internal error

2018-06-06 Thread Steve Dower
Steve Dower added the comment: I'd already started discussing this with the VSTS team, it seems to be a bug on their side. The "build not retained" state just means it'll get cleaned up after seven days. People with login access can mark a build to be kept permanently, which changes that st

[issue22454] Adding the opposite function of shlex.split()

2018-06-06 Thread R. David Murray
R. David Murray added the comment: I like it, myself, though there is some danger in promoting the idea that this is a "safe" operation. It theoretically should be, but it increases the attack surface slightly if you actually use it (that is, using shell=False is always safer, by at least a

[issue22454] Adding the opposite function of shlex.split()

2018-06-06 Thread Cheryl Sabella
Cheryl Sabella added the comment: Hi Vinay, You made the most recent changes to shlex, so I was wondering what you thought of this suggestion. Thanks! -- nosy: +cheryl.sabella, vinay.sajip ___ Python tracker

[issue33687] uu.py calls os.path.chmod which doesn't exist

2018-06-06 Thread Xiang Zhang
Change by Xiang Zhang : -- nosy: +r.david.murray ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue33687] uu.py calls os.path.chmod which doesn't exist

2018-06-06 Thread Xiang Zhang
Xiang Zhang added the comment: I modified it for the feature, not maintain it. I remember at that time I get the feeling it's somewhat strange there are two APIs, with similar functionality resides in two modules, need to be updated. -- nosy: -r.david.murray ___

[issue33687] uu.py calls os.path.chmod which doesn't exist

2018-06-06 Thread R. David Murray
R. David Murray added the comment: The email module uses it, so I would object to its being removed. It may not be used often (probably only when working with old email archives), but there's no good reason I can see to break something that currently works. -- nosy: +r.david.murray

[issue33782] VSTS Windows-PR: internal error

2018-06-06 Thread STINNER Victor
Change by STINNER Victor : -- assignee: -> steve.dower ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https

[issue33782] VSTS Windows-PR: internal error

2018-06-06 Thread STINNER Victor
STINNER Victor added the comment: By the way, it seems like tests were not run on the Linux-PR job: https://python.visualstudio.com/cpython/_build?buildId=6467&tab=summary&_a=summary Linux-PR / Build Linux-PR_20180606.13: "No test runs are available for this build." "Retained state Build no

[issue33782] VSTS Windows-PR: internal error

2018-06-06 Thread STINNER Victor
New submission from STINNER Victor : On my PR https://github.com/python/cpython/pull/7447 "VSTS: Windows-PR" failed: "Windows-PR_20180606.13 failed". https://python.visualstudio.com/cpython/_build?buildId=6469 "The request was failed due to an internal service error. Please try again." -

[issue31044] FAIL: test_makedev (test.test_posix.PosixTester) on AMD64 FreeBSD CURRENT

2018-06-06 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +7071 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue33781] audioop.c: fbound() casts double to int for its return value

2018-06-06 Thread STINNER Victor
STINNER Victor added the comment: Oh, fbound() cast to (int) has been done by... myself :-D commit f2b9a340ef143099726fb642951410e4ad793c7f Author: Victor Stinner Date: Tue May 7 23:49:15 2013 +0200 audioop: explicit cast to fix a compiler warning diff --git a/Modules/audioop.c b/Modu

[issue33781] audioop.c: fbound() casts double to int for its return value

2018-06-06 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +7070 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-l

[issue33687] uu.py calls os.path.chmod which doesn't exist

2018-06-06 Thread STINNER Victor
STINNER Victor added the comment: Is the uu module still maintained? Christian Heimes wants to remove the module: https://github.com/tiran/peps/blob/oldbatteries/pep-.rst Xiang Zhang made a change in uu last year to add a new feature: new backtick optional parameter, bpo-30103. -

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

2018-06-06 Thread STINNER Victor
STINNER Victor added the comment: Another variant seen on AppVeyor (PR 7439, master branch): https://ci.appveyor.com/project/python/cpython/build/3.8build16980 == ERROR: test_create_connection_ssl_failed_certificate (test.te

[issue33781] audioop.c: fbound() casts double to int for its return value

2018-06-06 Thread STINNER Victor
New submission from STINNER Victor : Extract of Python 2.7, Modules/audioop.c: static int fbound(double val, double minval, double maxval) { if (val > maxval) val = maxval; else if (val < minval + 1) val = minval; return val; } Example of usage: double factor,

[issue33780] [subprocess] Better Unicode support for shell=True on Windows

2018-06-06 Thread Yoni Rozenshein
New submission from Yoni Rozenshein : In subprocess, the implementation of shell=True on Windows is to launch a subprocess with using {comspec} /c "{args}" (normally comspec=cmd.exe). By default, the output of cmd is encoded with the "active" codepage. In Python 3.6, you can decode this using

[issue33764] AppVeyor builds interrupted before tests complete

2018-06-06 Thread STINNER Victor
STINNER Victor added the comment: Steve Dower: "Are we sure we haven't actually regressed something here and it's actually taking more resources? (...)" According to AppVeyor support, there was an issue on their side: "Regarding disk quota -- we are extremely sorry. This was not your fault,

[issue33765] AppVeyor didn't start on my PR 7365

2018-06-06 Thread STINNER Victor
STINNER Victor added the comment: AppVeyor is back! I close the issue. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___ _

[issue33779] Error while installing python 3.6.5 on windows 10

2018-06-06 Thread STINNER Victor
STINNER Victor added the comment: Extract of logs: [48E0:48FC][2018-06-06T15:06:11]i360: Creating a system restore point. [48E0:48FC][2018-06-06T15:06:11]w363: Could not create system restore point, error: 0x80070514. Continuing... [4B7C:4B80][2018-06-06T15:06:11]i370: Session begin, registra

[issue33779] Error while installing python 3.6.5 on windows 10

2018-06-06 Thread Siddhartha Bose
New submission from Siddhartha Bose : Hi Team, I am getting below error while trying to install python 3.6.5 on windows 10. 0X80070005 Access is denied. Logs attached. Also when I see control panel it shows me under program and feartures however unable to uninstall. I am logged in as adm

[issue33625] Release GIL for grp.getgr{nam, gid} and pwd.getpw{nam, uid}

2018-06-06 Thread STINNER Victor
Change by STINNER Victor : -- nosy: +vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue33778] update Unicode database to 11.0

2018-06-06 Thread STINNER Victor
STINNER Victor added the comment: Benjamin: would you mind to explain how to update Unicode in Python? I would like to document it, if you are not available for example, or don't want to do it anymore. I'm asking for my general idea of having at least two maintainers per "CPython maintenanc

[issue33751] Failed separate testTruncateOnWindows in test_file

2018-06-06 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +7069 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

<    1   2