[issue27513] email.utils.getaddresses does not handle Header objects

2019-06-03 Thread Zackery Spytz
Change by Zackery Spytz : -- keywords: +patch pull_requests: +13682 stage: -> patch review pull_request: https://github.com/python/cpython/pull/13797 ___ Python tracker ___

[issue37141] Allow multiple separators in Stream.readuntil

2019-06-03 Thread Jeffrey Kintscher
Change by Jeffrey Kintscher : -- nosy: +Jeffrey.Kintscher ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36707] The "m" ABI flag of SOABI for pymalloc is no longer needed

2019-06-03 Thread Kubilay Kocak
Kubilay Kocak added the comment: Those script names would already have code to handle name changes based on existing abiflags/soabi string (as FreeBSD does), and would be trivial to modify for 'm' removal. For third party stuff: we use setuptools --record for 'everything', so as long as

[issue37134] [EASY] Use PEP570 syntax in the documentation

2019-06-03 Thread Grant Jenks
Grant Jenks added the comment: FWIW, I would rather not see the docs littered with "/". I've taught Python to hundreds of professional software engineers over the last five years and in all that time nobody has ever asked when the args need to be positional. It's easy to experiment to find

[issue36707] The "m" ABI flag of SOABI for pymalloc is no longer needed

2019-06-03 Thread Ned Deily
Ned Deily added the comment: Another user-visible difference: $ ls /tmp/py37/bin/python* /tmp/py37/bin/python3/tmp/py37/bin/python3.7-config /tmp/py37/bin/python3.7m-config /tmp/py37/bin/python3.7 /tmp/py37/bin/python3.7m /tmp/py37/bin/python3-config $ ls /tmp/py38/bin/python*

[issue37134] [EASY] Use PEP570 syntax in the documentation

2019-06-03 Thread Raymond Hettinger
Raymond Hettinger added the comment: > Another part of the PEP's reasoning was that this notation > is difficult to understand at least partially because it > is rarely encountered, so "people don't understand it" as > a reason to exclude it from the documentation becomes a > bit of a

[issue36707] The "m" ABI flag of SOABI for pymalloc is no longer needed

2019-06-03 Thread Ned Deily
Ned Deily added the comment: > One question I have is, can/does SOABI flag removal affect any third party > package/extension builds in any way, particularly affecting the names of > files they produce? Yep, the default file names of C extension modules differ on most/all? Unix-y platforms

[issue36964] `python3 -m venv NAME`: virtualenv is not portable

2019-06-03 Thread Marco Sulla
Marco Sulla added the comment: > Changing VIRTUAL_ENV will break code VIRTUAL_ENV it's the same if you don't move the venv. Moving it will be an unofficial unsupported bonus, and if you coded bad and it doesn't work, it's your fault. -- ___

[issue36707] The "m" ABI flag of SOABI for pymalloc is no longer needed

2019-06-03 Thread Kubilay Kocak
Kubilay Kocak added the comment: For FreeBSD Python language ports, the change doesn't have a big negative impact for the Python language/interpreter ports themselves We have the following block in lang/python3? ports: .if ${PORT_OPTIONS:MPYMALLOC} ABIFLAGS:= m${ABIFLAGS} .endif .if

[issue21492] email.header.decode_header sometimes returns bytes, sometimes str

2019-06-03 Thread Ezio Melotti
Ezio Melotti added the comment: If we can't fix the behavior, it should at least be documented. Currently the docs says "This function returns a list of (decoded_string, charset) pairs containing each of the decoded parts of the header.". One could assume that this means that a Unicode

[issue37130] pathlib.with_name() doesn't like unnamed files.

2019-06-03 Thread Jeffrey Kintscher
Change by Jeffrey Kintscher : -- nosy: +Jeffrey.Kintscher ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37134] [EASY] Use PEP570 syntax in the documentation

2019-06-03 Thread Paul Ganssle
Paul Ganssle added the comment: > I respectfully disagree with logic, "the language now permits this, so we > should change all the docs to display it everywhere". That moves it from > optional knowledge to mandatory knowledge, from a day ten lesson to a day one > lesson, from "once in a

[issue33416] Add endline and endcolumn to every AST node

2019-06-03 Thread Guido van Rossum
Guido van Rossum added the comment: It seems we're keeping the new PyCode_New() signature, so we can do the same here. Just document it; a versionchanged (if there isn't one yet) and a mention in What's New sound appropriate. -- ___ Python

[issue37134] [EASY] Use PEP570 syntax in the documentation

2019-06-03 Thread Raymond Hettinger
Raymond Hettinger added the comment: I respectfully disagree with logic, "the language now permits this, so we should change all the docs to display it everywhere". That moves it from optional knowledge to mandatory knowledge, from a day ten lesson to a day one lesson, from "once in a

[issue37134] [EASY] Use PEP570 syntax in the documentation

2019-06-03 Thread STINNER Victor
STINNER Victor added the comment: A first enhancement would be to add an index entry for "/" at: https://docs.python.org/dev/genindex-Symbols.html > I'll note that Googling on: "python slash in formal argument list" ... We have to find a cute name for the "/ operator" in function definition!

[issue37137] test_asyncio: test_cancel_gather_2() dangling thread

2019-06-03 Thread STINNER Victor
STINNER Victor added the comment: Thanks Andrew! Sorry that you had to revert your change :-( We can reconsider to merge again your change after beta1 (if our release manager is fine with that). -- ___ Python tracker

[issue36818] Add PyInterpreterState.runtime.

2019-06-03 Thread STINNER Victor
STINNER Victor added the comment: By the way, I have questions about the rationale of this change. > Currently we use the _PyRuntime static global to access the runtime state in > various places. At the same time, in thread contexts we get access to the > thread state from Thread-Local

[issue36818] Add PyInterpreterState.runtime.

2019-06-03 Thread STINNER Victor
STINNER Victor added the comment: This change introduced a regression: https://bugs.python.org/issue37135#msg344511 I had to revert the change to fix Python for 3.8 beta1 release. -- resolution: fixed -> status: closed -> open ___ Python tracker

[issue36818] Add PyInterpreterState.runtime.

2019-06-03 Thread STINNER Victor
STINNER Victor added the comment: New changeset 0fd2c300c2a85b3b227a907b2a39ef79fa86d850 by Victor Stinner in branch 'master': Revert "bpo-36818: Add PyInterpreterState.runtime field. (gh-13129)" (GH-13795) https://github.com/python/cpython/commit/0fd2c300c2a85b3b227a907b2a39ef79fa86d850

[issue37140] ctypes change made clang fail to build

2019-06-03 Thread Paul Monson
Change by Paul Monson : -- keywords: +patch pull_requests: +13681 stage: -> patch review pull_request: https://github.com/python/cpython/pull/13796 ___ Python tracker ___

[issue15474] Differentiate decorator and decorator factory in docs

2019-06-03 Thread Windson Yang
Windson Yang added the comment: Hi, Andrés Delfino. Are you still working on it? -- nosy: +Windson Yang ___ Python tracker ___ ___

[issue37135] test_multiprocessing_spawn segfaults on AMD64 FreeBSD CURRENT Shared 3.x

2019-06-03 Thread STINNER Victor
STINNER Victor added the comment: > commit 396e0a8d9dc65453cb9d53500d0a620602656cfe (refs/bisect/bad) Extract of this change: static inline void -exit_thread_if_finalizing(_PyRuntimeState *runtime, PyThreadState *tstate) +exit_thread_if_finalizing(PyThreadState *tstate) { +

[issue36818] Add PyInterpreterState.runtime.

2019-06-03 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +13680 pull_request: https://github.com/python/cpython/pull/13795 ___ Python tracker ___

[issue37135] test_multiprocessing_spawn segfaults on AMD64 FreeBSD CURRENT Shared 3.x

2019-06-03 Thread STINNER Victor
STINNER Victor added the comment: I used git bisect and I found: commit 396e0a8d9dc65453cb9d53500d0a620602656cfe (refs/bisect/bad) Author: Eric Snow Date: Fri May 31 21:16:47 2019 -0600 bpo-36818: Add PyInterpreterState.runtime field. (gh-13129) stress.py starts to crash at this

[issue35814] Syntax quirk with variable annotations

2019-06-03 Thread Ivan Levkivskyi
Change by Ivan Levkivskyi : -- pull_requests: +13679 pull_request: https://github.com/python/cpython/pull/13794 ___ Python tracker ___

[issue37135] test_multiprocessing_spawn segfaults on AMD64 FreeBSD CURRENT Shared 3.x

2019-06-03 Thread STINNER Victor
STINNER Victor added the comment: If you apply attached sleep_at_exit.patch and run attach stress.py, you should quickly get a crash: $ git apply sleep_at_exit.patch $ make && ./python stress.py Segmentation fault (core dumped) That's a simplified example of the multiprocessing crash.

[issue37135] test_multiprocessing_spawn segfaults on AMD64 FreeBSD CURRENT Shared 3.x

2019-06-03 Thread STINNER Victor
Change by STINNER Victor : Added file: https://bugs.python.org/file48387/stress.py ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue37135] test_multiprocessing_spawn segfaults on AMD64 FreeBSD CURRENT Shared 3.x

2019-06-03 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Note that the core dump that we are talking about is something that we produced afterwards when trying to reproduce the issue. The core that is produced as part of the tests could be different. I am trying to get access to the test files. --

[issue33416] Add endline and endcolumn to every AST node

2019-06-03 Thread Ivan Levkivskyi
Ivan Levkivskyi added the comment: So what was the conclusion about PyCode_New()? Situation is quite similar here (except that these functions are used less often). Should we just document the changes in What's New? -- ___ Python tracker

[issue36839] Support the buffer protocol in code objects

2019-06-03 Thread Inada Naoki
Inada Naoki added the comment: On Tue, Jun 4, 2019 at 8:45 AM Dino Viehland wrote: > > The 20MB of savings is actually the amount of byte code that exists in the IG > code base. Wait, do you expect you can reduce 100% saving of co_code object? co_code takes 0byte? You said "the overhead it

[issue37135] test_multiprocessing_spawn segfaults on AMD64 FreeBSD CURRENT Shared 3.x

2019-06-03 Thread STINNER Victor
STINNER Victor added the comment: I marked bpo-37143 "multiprocessing crashed with EXCEPTION_ACCESS_VIOLATION on Python on x86 Windows7 3.x" as a duplicate of this issue. Even if bpo-37143 looks very different (crash in a different file, on a different operating system), I'm now quite sure

[issue37143] multiprocessing crashed with EXCEPTION_ACCESS_VIOLATION on Python on x86 Windows7 3.x

2019-06-03 Thread STINNER Victor
STINNER Victor added the comment: I mark this issue as a duplicate of bpo-37135. -- resolution: -> duplicate stage: -> resolved status: open -> closed ___ Python tracker

[issue37143] multiprocessing crashed with EXCEPTION_ACCESS_VIOLATION on Python on x86 Windows7 3.x

2019-06-03 Thread STINNER Victor
STINNER Victor added the comment: New fresh crash on x86 Windows7 3.x, even after the revert: https://buildbot.python.org/all/#/builders/58/builds/2566 == ERROR: test_multiprocessing (test.test_venv.BasicTest)

[issue37135] test_multiprocessing_spawn segfaults on AMD64 FreeBSD CURRENT Shared 3.x

2019-06-03 Thread STINNER Victor
STINNER Victor added the comment: I looked at the coredump with Pablo. In short, the main thread is calling Py_Exit() to exit the process and so released memory, and a daemon thread does crash on calling PyEval_RestoreThread() because tstate memory was freed. The question is now if this bug

[issue36656] Please add race-free os.link and os.symlink wrapper / helper

2019-06-03 Thread Robert Collins
Robert Collins added the comment: I'd like to add a few notes; please do consider Windows interactions here - Windows does not have the same model for inode replacement that Posix has. Secondly, I note that the thread model discussed here hasn't been particular well articulated. In

[issue35621] asyncio.create_subprocess_exec() only works with main event loop

2019-06-03 Thread miss-islington
miss-islington added the comment: New changeset 9535aff9421f0a5639f6e4c4bb0f07a743ea8dba by Miss Islington (bot) (Andrew Svetlov) in branch 'master': Revert "bpo-35621: Support running subprocesses in asyncio when loop is executed in non-main thread (#13630)" (GH-13793)

[issue37135] test_multiprocessing_spawn segfaults on AMD64 FreeBSD CURRENT Shared 3.x

2019-06-03 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: CURRENT-amd64% lldb ./python -c python.core (lldb) target create "./python" --core "python.core" Core file '/home/pablo/cpython/python.core' (x86_64) was loaded. (lldb) bt * thread #1, name = 'python', stop reason = signal SIGBUS * frame #0:

[issue37140] ctypes change made clang fail to build

2019-06-03 Thread Paul Monson
Paul Monson added the comment: Reading the related bugs more carefully I think the struct/union passing conventions are different on Windows x64 and Linux. I have a fix which works for Windows but preserves the prior code for Linux. -- ___

[issue37137] test_asyncio: test_cancel_gather_2() dangling thread

2019-06-03 Thread Andrew Svetlov
Andrew Svetlov added the comment: Got you. https://github.com/python/cpython/pull/13793 -- ___ Python tracker ___ ___

[issue35621] asyncio.create_subprocess_exec() only works with main event loop

2019-06-03 Thread Andrew Svetlov
Change by Andrew Svetlov : -- pull_requests: +13678 pull_request: https://github.com/python/cpython/pull/13793 ___ Python tracker ___

[issue31006] typing.NamedTuple should add annotations to its constructor (__new__) parameters.

2019-06-03 Thread Ivan Levkivskyi
Ivan Levkivskyi added the comment: Thanks! It looks like this was fixed in typing and then forward ported to CPython. -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker

[issue37135] test_multiprocessing_spawn segfaults on AMD64 FreeBSD CURRENT Shared 3.x

2019-06-03 Thread STINNER Victor
STINNER Victor added the comment: > FTR Victor reverted GH-13714 that triggers this. Sadly, this revert wasn't enough. New fresh coredump on "AMD64 FreeBSD CURRENT Shared 3.x": https://buildbot.python.org/all/#builders/168/builds/1145 Warning -- Dangling processes: {} Warning -- Dangling

[issue36839] Support the buffer protocol in code objects

2019-06-03 Thread Dino Viehland
Dino Viehland added the comment: The 20MB of savings is actually the amount of byte code that exists in the IG code base. I was just measuring the web site code, and not the other various Python code in the process (e.g. no std lib code, no 3rd party libraries, etc...). The IG code base

[issue37140] ctypes change made clang fail to build

2019-06-03 Thread Paul Monson
Paul Monson added the comment: If I undo the changes to StructUnionType_paramfunc then test_pass_by_value (ctypes.test.test_structures.StructureTestCase) fails on x64 on Windows. Looking at the code I don't think this is specific to Windows. This is a test for fixing this issue:

[issue37137] test_asyncio: test_cancel_gather_2() dangling thread

2019-06-03 Thread STINNER Victor
STINNER Victor added the comment: > 2. Revert added watchers entirely I prefer this option just because we must fix all bugs as soon as possible to get the beta1 released, and this bug is just one bug in a list of bugs. I might try to help you *later* to fix the change to prevent this bug.

[issue37137] test_asyncio: test_cancel_gather_2() dangling thread

2019-06-03 Thread Andrew Svetlov
Andrew Svetlov added the comment: We have two options: 1. Apply https://github.com/python/cpython/pull/13792 to wait for dangling threads 2. Revert added watchers entirely What do you prefer? -- ___ Python tracker

[issue37137] test_asyncio: test_cancel_gather_2() dangling thread

2019-06-03 Thread Andrew Svetlov
Change by Andrew Svetlov : -- pull_requests: +13677 pull_request: https://github.com/python/cpython/pull/13792 ___ Python tracker ___

[issue37137] test_asyncio: test_cancel_gather_2() dangling thread

2019-06-03 Thread STINNER Victor
STINNER Victor added the comment: > I suspect that I've added this dangling thread by > https://github.com/python/cpython/blob/master/Lib/asyncio/unix_events.py#L1248-L1251 > :( Can you please try to revert commit 13ed07998ad93dbdd94991ba0451b9b559f07972? --

[issue37137] test_asyncio: test_cancel_gather_2() dangling thread

2019-06-03 Thread Andrew Svetlov
Andrew Svetlov added the comment: Working on PR -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

2019-06-03 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- nosy: -pablogsal ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

2019-06-03 Thread Andrew Svetlov
Change by Andrew Svetlov : -- nosy: -asvetlov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

2019-06-03 Thread Inada Naoki
Change by Inada Naoki : -- pull_requests: +13676 pull_request: https://github.com/python/cpython/pull/13787 ___ Python tracker ___

[issue37137] test_asyncio: test_cancel_gather_2() dangling thread

2019-06-03 Thread Andrew Svetlov
Andrew Svetlov added the comment: I suspect that I've added this dangling thread by https://github.com/python/cpython/blob/master/Lib/asyncio/unix_events.py#L1248-L1251 :( -- nosy: +asvetlov ___ Python tracker

[issue35763] IDLE calltips: make positional note less obtrusive

2019-06-03 Thread Terry J. Reedy
Change by Terry J. Reedy : -- keywords: +patch pull_requests: +13675 stage: test needed -> patch review pull_request: https://github.com/python/cpython/pull/13791 ___ Python tracker

[issue5680] Simulate command-line arguments for program run in IDLE

2019-06-03 Thread Cheryl Sabella
Cheryl Sabella added the comment: I've pushed a change for a more generic dialog for a 'Run Custom' option and I changed the keybinding to Shift-F5. Sorry for not doing that on the initial commit; I didn't fully understand the difference between what you were asking for and the minimal

[issue37146] opcode cache for LOAD_GLOBAL emits false alarm in memory leak hunting

2019-06-03 Thread STINNER Victor
STINNER Victor added the comment: INADA-san wrote PR 13787 to disable opcache when Python is compiled in debug mode. Pablo and me approved the change, so I merged it. Pablo wrote a more robust solution, PR 13789, to disable opcache only in regrtest, to look for memory leaks. But INADA-san

[issue37146] opcode cache for LOAD_GLOBAL emits false alarm in memory leak hunting

2019-06-03 Thread STINNER Victor
STINNER Victor added the comment: New changeset eddef861b49f1635222a9e1771231c34a807debf by Victor Stinner (Inada Naoki) in branch 'master': bpo-37146: disable opcache when Py_DEBUG is defined (GH-13787) https://github.com/python/cpython/commit/eddef861b49f1635222a9e1771231c34a807debf

[issue36889] Merge StreamWriter and StreamReader into just asyncio.Stream

2019-06-03 Thread Andrew Svetlov
Change by Andrew Svetlov : -- pull_requests: +13674 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/13790 ___ Python tracker ___

[issue36707] The "m" ABI flag of SOABI for pymalloc is no longer needed

2019-06-03 Thread Miro Hrončok
Miro Hrončok added the comment: I'm not sure either. So far most affected buildscripts are confused by: /usr/include/python3.Xm -> /usr/include/python3.X /usr/lib64/libpython3.Xm -> /usr/lib64/libpython3.X extension.cpython-3Xm-arch-linux-gnu.so -> extension.cpython-3X-arch-linux-gnu.so

[issue37146] opcode cache for LOAD_GLOBAL emits false alarm in memory leak hunting

2019-06-03 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +13673 pull_request: https://github.com/python/cpython/pull/13789 ___ Python tracker ___

[issue36707] The "m" ABI flag of SOABI for pymalloc is no longer needed

2019-06-03 Thread STINNER Victor
STINNER Victor added the comment: > It's usually just custom ugly-hardcoded autotools/cmake. Nothing severe > enough. However, this change still is not documented anywhere in > https://docs.python.org/dev/whatsnew/3.8.html I concur that it should be documented. It's on my TODO list. But

[issue37093] http.client aborts header parsing upon encountering non-ASCII header names

2019-06-03 Thread Tim Burke
Change by Tim Burke : -- keywords: +patch pull_requests: +13672 stage: test needed -> patch review pull_request: https://github.com/python/cpython/pull/13788 ___ Python tracker

[issue37146] opcode cache for LOAD_GLOBAL emits false alarm in memory leak hunting

2019-06-03 Thread Inada Naoki
Change by Inada Naoki : -- keywords: +patch pull_requests: +13671 stage: -> patch review pull_request: https://github.com/python/cpython/pull/13787 ___ Python tracker ___

[issue37134] [EASY] Use PEP570 syntax in the documentation

2019-06-03 Thread Gregory P. Smith
Gregory P. Smith added the comment: I agree with Brett and Carol here. This is part of the language syntax. We can educate people to that effect more if desired (I like the blog post idea). People will figure it out. We've already got high ranked stackoverflow answers related to this

[issue37137] test_asyncio: test_cancel_gather_2() dangling thread

2019-06-03 Thread STINNER Victor
STINNER Victor added the comment: My second attempt isn't fully successful :-( test_asyncio still fails with ENV_CHANGED :-( https://buildbot.python.org/all/#/builders/185/builds/488 test_current_task_no_running_loop_implicit (test.test_asyncio.test_tasks.CCurrentLoopTests) ... Warning --

[issue37145] collections.abc.MappingView mixins rely on undocumented _mapping

2019-06-03 Thread Geoffrey Sneddon
Geoffrey Sneddon added the comment: How do you use ItemsView without: * relying on __init__ and _mapping, which are both private implementation details, or * reimplementing __len__, __contains__, and __iter__? Given you can't use the mixin implementations of __len__, __contains__, and

[issue37137] test_asyncio: test_cancel_gather_2() dangling thread

2019-06-03 Thread STINNER Victor
STINNER Victor added the comment: I push a fix in asyncio, instead of trying to fix individual asyncio tests: New changeset 0f0a30f4da4b529e0f7df857b9f575b231b32758 by Victor Stinner in branch 'master': bpo-34037, asyncio: add BaseEventLoop.wait_executor_on_close (GH-13786)

[issue36707] The "m" ABI flag of SOABI for pymalloc is no longer needed

2019-06-03 Thread Miro Hrončok
Miro Hrončok added the comment: It's usually just custom ugly-hardcoded autotools/cmake. Nothing severe enough. However, this change still is not documented anywhere in https://docs.python.org/dev/whatsnew/3.8.html -- ___ Python tracker

[issue34037] asyncio: BaseEventLoop.close() shutdowns the executor without waiting causing leak of dangling threads

2019-06-03 Thread STINNER Victor
STINNER Victor added the comment: New changeset 0f0a30f4da4b529e0f7df857b9f575b231b32758 by Victor Stinner in branch 'master': bpo-34037, asyncio: add BaseEventLoop.wait_executor_on_close (GH-13786) https://github.com/python/cpython/commit/0f0a30f4da4b529e0f7df857b9f575b231b32758

[issue34037] asyncio: BaseEventLoop.close() shutdowns the executor without waiting causing leak of dangling threads

2019-06-03 Thread STINNER Victor
STINNER Victor added the comment: "executor.shutdown(wait=False)" was added by this change: commit 4ca7355901049ff9a873cf236091e6780d7a8126 Author: Antoine Pitrou Date: Sun Oct 20 00:54:10 2013 +0200 Issue #19299: fix refleak test failures in test_asyncio Guido van Rossum proposed to

[issue34037] asyncio: BaseEventLoop.close() shutdowns the executor without waiting causing leak of dangling threads

2019-06-03 Thread STINNER Victor
STINNER Victor added the comment: I wrote PR 13786 to fix this issue. -- versions: +Python 3.8 -Python 3.7 ___ Python tracker ___

[issue37137] test_asyncio: test_cancel_gather_2() dangling thread

2019-06-03 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +13670 pull_request: https://github.com/python/cpython/pull/13786 ___ Python tracker ___

[issue37029] PyObject_Free is O(N) where N = # of arenas

2019-06-03 Thread Tim Peters
Tim Peters added the comment: Thank you, Friedl! I appreciate the extra confirmation - and especially on even bigger test cases :-) -- ___ Python tracker ___

[issue37134] [EASY] Use PEP570 syntax in the documentation

2019-06-03 Thread Carol Willing
Carol Willing added the comment: Tim's message resonated with me. Confusing users is something that I believe that we wish to minimize. I confess that I had a similar reaction as Tim when I saw functions with a trailing `/`. What I did find helpful was adding to the middle of the parameter

[issue37124] test_msilib is potentially leaking references and memory blocks

2019-06-03 Thread Steve Dower
Steve Dower added the comment: I have no idea. I don't ever use msilib, but there are a few people who do that don't have any way to get bugs fixed, so I'll help merge. If it's just the test leak, probably it's in the test. I don't recall the change having any impact on resource usage. But

[issue37137] test_asyncio: test_cancel_gather_2() dangling thread

2019-06-03 Thread STINNER Victor
STINNER Victor added the comment: My change didn't fix the issue: https://buildbot.python.org/all/#/builders/176/builds/680 test_proc_exited (test.test_asyncio.test_subprocess.SubprocessTransportTests) ... Warning -- threading_cleanup() failed to cleanup -1 threads (count: 0, dangling: 1)

[issue37146] opcode cache for LOAD_GLOBAL emits false alarm in memory leak hunting

2019-06-03 Thread STINNER Victor
New submission from STINNER Victor : opcode cache for LOAD_GLOBAL introduced false alarm in memory leak hunting (python3 -m test -R 3:3 ...). => opcache: bpo-26219. Before the change: $ git checkout 91234a16367b56ca03ee289f7c03a34d4cfec4c8^ $ make && ./python -m test -R 3:3 test_pprint

[issue26219] implement per-opcode cache in ceval

2019-06-03 Thread STINNER Victor
STINNER Victor added the comment: The opcode cache introduced an issue in reference leak hunting: see bpo-37146. -- ___ Python tracker ___

[issue36964] `python3 -m venv NAME`: virtualenv is not portable

2019-06-03 Thread Brett Cannon
Brett Cannon added the comment: Changing VIRTUAL_ENV will break code, so I'm not sure if it's worth changing. -- ___ Python tracker ___

[issue37134] [EASY] Use PEP570 syntax in the documentation

2019-06-03 Thread Brett Cannon
Brett Cannon added the comment: FYI when Guido said "call on the steering council" I think he meant open an issue at https://github.com/python/steering-council/issues as this will get lost otherwise (i.e. Guido already removed himself from the nosy list so this already doesn't have the

[issue37120] Provide knobs to disable session ticket generation on TLS 1.3

2019-06-03 Thread Christian Heimes
Change by Christian Heimes : -- resolution: -> fixed stage: patch review -> commit review status: open -> pending ___ Python tracker ___

[issue36868] New behavior of OpenSSL hostname verification not exposed, incorrectly documented

2019-06-03 Thread miss-islington
miss-islington added the comment: New changeset cad4ff65eb12649cd650059b15d8e12f2ae951ef by Miss Islington (bot) in branch '3.7': bpo-36868: Fix what's new for SSLContext.hostname_checks_common_name (GH-13248) https://github.com/python/cpython/commit/cad4ff65eb12649cd650059b15d8e12f2ae951ef

[issue37120] Provide knobs to disable session ticket generation on TLS 1.3

2019-06-03 Thread Christian Heimes
Christian Heimes added the comment: I have merged the PR to land the feature in time for the feature freeze. Regarding your comment on client_context.num_ticket getter: IMHO it's not a good idea to raise an exception on attribute access. It may break introspection. --

[issue37134] [EASY] Use PEP570 syntax in the documentation

2019-06-03 Thread Tim Peters
Tim Peters added the comment: I haven't looked at anything in this PR, so just popping in to confirm that the first time I saw stuff like: len(obj, /) in the docs I had no idea at all what it was trying to say. I thought it was a typo. Also the second, third, fourth, ..., times I saw

[issue37120] Provide knobs to disable session ticket generation on TLS 1.3

2019-06-03 Thread Christian Heimes
Christian Heimes added the comment: New changeset 78c7d527799dacca91b9ed67057cb996efe526b0 by Christian Heimes in branch 'master': bpo-37120: Add SSLContext.num_tickets (GH-13719) https://github.com/python/cpython/commit/78c7d527799dacca91b9ed67057cb996efe526b0 --

[issue37130] pathlib.with_name() doesn't like unnamed files.

2019-06-03 Thread Brett Cannon
Change by Brett Cannon : -- stage: -> test needed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37130] pathlib.with_name() doesn't like unnamed files.

2019-06-03 Thread Brett Cannon
Brett Cannon added the comment: The inconsistency is a bit weird. Looking at https://github.com/python/cpython/blob/master/Lib/pathlib.py#L825 the question is why is self.name not being set for '.' but it is for '..'. I suspect there's special-casing for '.' somewhere that sets self.name to

[issue37140] ctypes change made clang fail to build

2019-06-03 Thread Paul Monson
Paul Monson added the comment: The change causing the build failure comes from this commit. https://github.com/python/cpython/pull/3806/commits/ea8a0dcea68409d37f3ad9e60e42777c76ad903b The commit comment says: "Fix copy of structures when passed by value." Steve, do you recall what this

[issue36868] New behavior of OpenSSL hostname verification not exposed, incorrectly documented

2019-06-03 Thread miss-islington
Change by miss-islington : -- keywords: +patch pull_requests: +13669 stage: -> patch review pull_request: https://github.com/python/cpython/pull/13784 ___ Python tracker ___

[issue36868] New behavior of OpenSSL hostname verification not exposed, incorrectly documented

2019-06-03 Thread miss-islington
miss-islington added the comment: New changeset 47eb2234061524562a4b484e3a395f4fdd6c1b76 by Miss Islington (bot) (Christian Heimes) in branch 'master': bpo-36868: Fix what's new for SSLContext.hostname_checks_common_name (GH-13248)

[issue34001] LibreSSL does not tolerate setting minimum_version greater than maximum_version

2019-06-03 Thread Christian Heimes
Change by Christian Heimes : -- pull_requests: +13668 pull_request: https://github.com/python/cpython/pull/13783 ___ Python tracker ___

[issue34271] Please support logging of SSL master secret by env variable SSLKEYLOGFILE

2019-06-03 Thread Christian Heimes
Christian Heimes added the comment: New changeset e35d1ba9eab07a59b98b700c5e18ceb13b2561a6 by Christian Heimes in branch 'master': bpo-34271: Fix compatibility with 1.0.2 (GH-13728) https://github.com/python/cpython/commit/e35d1ba9eab07a59b98b700c5e18ceb13b2561a6 --

[issue37081] Test with OpenSSL 1.1.1c

2019-06-03 Thread miss-islington
miss-islington added the comment: New changeset 3344197040fe1b05a3244bdb16d429f4647f35b8 by Miss Islington (bot) in branch '3.7': [3.7] bpo-37081: Test with OpenSSL 1.1.1c (GH-13631) (GH-13782) https://github.com/python/cpython/commit/3344197040fe1b05a3244bdb16d429f4647f35b8 --

[issue37134] [EASY] Use PEP570 syntax in the documentation

2019-06-03 Thread Raymond Hettinger
Raymond Hettinger added the comment: > If you think me pushing for this change will impact somehow > our ability to work together I will close the PR and the issue. Not at all. I always enjoy working with you and appreciate the depth of thinking you bring to every task :-) Here, we just

[issue37111] Logging - Inconsistent behaviour when handling unicode

2019-06-03 Thread Steve Dower
Steve Dower added the comment: I agree with Paul. Consistency with open() is the most important aspect here, and when we investigated changing that to UTF-8 it was decided to be too disruptive. That said, I'm not opposed to adding encoding/errors to basicConfig if someone wants to do that

[issue37081] Test with OpenSSL 1.1.1c

2019-06-03 Thread miss-islington
Change by miss-islington : -- pull_requests: +13667 pull_request: https://github.com/python/cpython/pull/13782 ___ Python tracker ___

[issue37081] Test with OpenSSL 1.1.1c

2019-06-03 Thread Christian Heimes
Christian Heimes added the comment: New changeset 06651ee418b5e4e013195d6b702763a1220706a7 by Christian Heimes in branch 'master': bpo-37081: Test with OpenSSL 1.1.1c (GH-13631) https://github.com/python/cpython/commit/06651ee418b5e4e013195d6b702763a1220706a7 --

[issue37134] [EASY] Use PEP570 syntax in the documentation

2019-06-03 Thread Guido van Rossum
Change by Guido van Rossum : -- nosy: -gvanrossum ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36027] Support negative exponents in pow() where a modulus is specified.

2019-06-03 Thread Mark Dickinson
Mark Dickinson added the comment: @Petr: Thanks for the quick fix! -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue37135] test_multiprocessing_spawn segfaults on AMD64 FreeBSD CURRENT Shared 3.x

2019-06-03 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > FTR Victor reverted GH-13714 that triggers this. Given the nature of the bugs, I would recommend to watch the buildbots -- ___ Python tracker

  1   2   3   >