[issue37701] shutil.copyfile raises SpecialFileError for symlink to fifo

2019-07-28 Thread Christopher Hunt
Christopher Hunt added the comment: Likewise when the destination is a symlink - though in that case the value of `follow_symlinks` should probably not matter. -- ___ Python tracker

[issue37701] shutil.copyfile raises SpecialFileError for symlink to fifo

2019-07-28 Thread Christopher Hunt
New submission from Christopher Hunt : Currently shutil.copyfile raises SpecialFileError when src is a link to a fifo. To reproduce: import os import shutil import tempfile d = tempfile.mkdtemp() fifo = os.path.join(d, 'fifo') link_to_fifo = os.path.join(d,

[issue37700] shutil.copyfile does not raise SpecialFileError for socket files

2019-07-28 Thread Christopher Hunt
Christopher Hunt added the comment: See also: the comment from https://github.com/python/cpython/blob/e1b900247227dad49d8231f1d028872412230ab4/Lib/shutil.py#L245: > # XXX What about other special files? (sockets, devices...) -- ___ Python tracker

[issue37700] shutil.copyfile does not raise SpecialFileError for socket files

2019-07-28 Thread Christopher Hunt
New submission from Christopher Hunt : Currently shutil.copyfile only raises SpecialFileError for named pipes. When trying to use the function to copy a socket file, the exception raised depends on the platform, for example: macOS: "[Errno 102] Operation not supported on socket:

[issue37699] Explicit mention of raised ValueError's after .detach() of underlying IO buffer

2019-07-28 Thread Brian Skinn
New submission from Brian Skinn : Once the underlying buffer/stream is .detach()ed from an instance of a subclass of TextIOBase or BufferedIOBase, accession of most attributes defined on TextIOBase/BufferedIOBase or the IOBase parent, as well as calling of most methods defined on

[issue37699] Explicit mention of raised ValueError's after .detach() of underlying IO buffer

2019-07-28 Thread Brian Skinn
Change by Brian Skinn : -- type: enhancement -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37678] Incorrect behaviour for user@password URI pattern in urlparse

2019-07-28 Thread Giovanni Cappellotto
Giovanni Cappellotto added the comment: What do you mean that urlparse act as unexpected? I tried your example and I think urlparse's behavior is correct. >From the RFC 1738: > Octets must be encoded if they have no corresponding graphic > character within the US-ASCII coded character set,

[issue21992] New AST node Else() should be introduced

2019-07-28 Thread Giovanni Cappellotto
Change by Giovanni Cappellotto : -- nosy: +potomak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37666] urllib.requests.urlopen doesn't support cadata=

2019-07-28 Thread Giovanni Cappellotto
Change by Giovanni Cappellotto : -- nosy: +potomak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37692] IDLE: clarify shell part of highlight sample

2019-07-28 Thread Terry J. Reedy
Terry J. Reedy added the comment: A comment on the PR discussed the label changes made. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue36002] configure --enable-optimizations with clang fails to detect llvm-profdata

2019-07-28 Thread Doyle Rowland
Change by Doyle Rowland : -- keywords: +patch pull_requests: +14764 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14998 ___ Python tracker ___

[issue36044] PROFILE_TASK for PGO build is not a good workload

2019-07-28 Thread miss-islington
miss-islington added the comment: New changeset 36fd7b6f01127bc6a8b4a37a363e0aa9cfd76506 by Miss Islington (bot) in branch '3.8': bpo-36044: Avoid warnings in Windows PGO build and add lzma, bz2 and sqlite coverage (GH-14985)

[issue36044] PROFILE_TASK for PGO build is not a good workload

2019-07-28 Thread Gregory P. Smith
Gregory P. Smith added the comment: i doubt test_lzma test_bz2 and test_sqlite matter. What matters there is compiling the underlying lzma, bz2, and sqlite3 libraries with PGO. that isn't done as part of our build system. regardless, those tests are fast enough so i've approved the PR to

[issue36044] PROFILE_TASK for PGO build is not a good workload

2019-07-28 Thread miss-islington
Change by miss-islington : -- pull_requests: +14763 pull_request: https://github.com/python/cpython/pull/14997 ___ Python tracker ___

[issue36044] PROFILE_TASK for PGO build is not a good workload

2019-07-28 Thread miss-islington
miss-islington added the comment: New changeset e1b900247227dad49d8231f1d028872412230ab4 by Miss Islington (bot) (Steve Dower) in branch 'master': bpo-36044: Avoid warnings in Windows PGO build and add lzma, bz2 and sqlite coverage (GH-14985)

[issue37697] Incorporate changes from importlib_metadata 0.19

2019-07-28 Thread Jason R. Coombs
Change by Jason R. Coombs : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue37697] Incorporate changes from importlib_metadata 0.19

2019-07-28 Thread Jason R. Coombs
Jason R. Coombs added the comment: New changeset f96334c17946683dd4fb5a84e86a7a4caa4b487d by Jason R. Coombs (Miss Islington (bot)) in branch '3.8': bpo-37697: Sync with importlib_metadata 0.19 (GH-14993) (GH-14995)

[issue37685] Fix equality checks for some types

2019-07-28 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +14762 pull_request: https://github.com/python/cpython/pull/14996 ___ Python tracker ___

[issue37697] Incorporate changes from importlib_metadata 0.19

2019-07-28 Thread miss-islington
Change by miss-islington : -- pull_requests: +14761 pull_request: https://github.com/python/cpython/pull/14995 ___ Python tracker ___

[issue37697] Incorporate changes from importlib_metadata 0.19

2019-07-28 Thread Jason R. Coombs
Jason R. Coombs added the comment: New changeset 049460da9c7b5f51732e2966195c44713af9dc4c by Jason R. Coombs in branch 'master': bpo-37697: Sync with importlib_metadata 0.19 (#14993) https://github.com/python/cpython/commit/049460da9c7b5f51732e2966195c44713af9dc4c --

[issue34101] PyBuffer_GetPointer() not documented

2019-07-28 Thread hai shi
Change by hai shi : -- keywords: +patch pull_requests: +14760 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14994 ___ Python tracker ___

[issue37697] Incorporate changes from importlib_metadata 0.19

2019-07-28 Thread Jason R. Coombs
Change by Jason R. Coombs : -- keywords: +patch pull_requests: +14759 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14993 ___ Python tracker ___

[issue37697] Incorporate changes from importlib_metadata 0.19

2019-07-28 Thread Jason R. Coombs
Jason R. Coombs added the comment: Okay, I think the issue was that I had failed to `make regen-importlib`. After doing that, the tests are passing. PR incoming. -- ___ Python tracker

[issue37698] Update doc of PyBuffer_ToContiguous

2019-07-28 Thread hai shi
New submission from hai shi : Due to https://github.com/python/cpython/blob/master/Objects/memoryobject.c#L985, order could be 'A' in PyBuffer_ToContiguous() -- assignee: docs@python components: Documentation messages: 348585 nosy: docs@python, shihai1991 priority: normal severity:

[issue37698] Update doc of PyBuffer_ToContiguous

2019-07-28 Thread hai shi
Change by hai shi : -- keywords: +patch pull_requests: +14758 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14992 ___ Python tracker ___

[issue37692] IDLE: clarify shell part of highlight sample

2019-07-28 Thread miss-islington
miss-islington added the comment: New changeset c94386d01372e69a67935bf284bfab31dac2adab by Miss Islington (bot) in branch '3.8': bpo-37692: Improve highlight config sample (GH-14983) https://github.com/python/cpython/commit/c94386d01372e69a67935bf284bfab31dac2adab --

[issue37692] IDLE: clarify shell part of highlight sample

2019-07-28 Thread miss-islington
miss-islington added the comment: New changeset d30626443d3ca0ea690c6124bdc95a53c12ecd9d by Miss Islington (bot) in branch '3.7': bpo-37692: Improve highlight config sample (GH-14983) https://github.com/python/cpython/commit/d30626443d3ca0ea690c6124bdc95a53c12ecd9d -- nosy:

[issue37697] Incorporate changes from importlib_metadata 0.19

2019-07-28 Thread Jason R. Coombs
Jason R. Coombs added the comment: I've started work on this in https://github.com/jaraco/cpython/commit/ee913fd4b1cc3bb324f43bfebd4f1006f90c2b6e, but two tests are failing: == FAIL: test_egg_info

[issue37697] Incorporate changes from importlib_metadata 0.19

2019-07-28 Thread Jason R. Coombs
New submission from Jason R. Coombs : Importlib_metadata 0.19 is about to release. Let's sync the code with that milestone (https://gitlab.com/python-devs/importlib_metadata/-/milestones/20). -- components: Library (Lib) messages: 348581 nosy: barry, jaraco priority: normal severity:

[issue37692] IDLE: clarify shell part of highlight sample

2019-07-28 Thread miss-islington
Change by miss-islington : -- pull_requests: +14757 pull_request: https://github.com/python/cpython/pull/14991 ___ Python tracker ___

[issue37692] IDLE: clarify shell part of highlight sample

2019-07-28 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset b222955355c8077a3ceca79195731663d7c3dd5f by Terry Jan Reedy in branch 'master': bpo-37692: Improve highlight config sample (#14983) https://github.com/python/cpython/commit/b222955355c8077a3ceca79195731663d7c3dd5f --

[issue37692] IDLE: clarify shell part of highlight sample

2019-07-28 Thread miss-islington
Change by miss-islington : -- pull_requests: +14756 pull_request: https://github.com/python/cpython/pull/14990 ___ Python tracker ___

[issue37696] FileIO.read() on a closed TTY throws an exception prematurely

2019-07-28 Thread David Wilson
David Wilson added the comment: Happy to send a patch for this if we can agree on the semantic being incorrect, and more importantly, someone is happy to review the patch once it reaches GitHub ;) -- ___ Python tracker

[issue37696] FileIO.read() on a closed TTY throws an exception prematurely

2019-07-28 Thread David Wilson
New submission from David Wilson : Given: $ cat tty-failure.py import pty import os master, slave = pty.openpty() master = os.fdopen(master, 'r+b', 0) slave = os.fdopen(slave, 'r+b', 0) slave.write(b'foo') slave.close() print(master.read()) On Python 2,

[issue34313] Tkinter crashes with Tk-related error on macOS with ActiveTcl 8.6

2019-07-28 Thread royf
royf added the comment: I started having a similar issue after updating to macOS Mojave 10.14.6. I'm not using idle, but the following minimal code has a similar issue: ```python import tkinter as tk w = tk.Tk() w.mainloop() ``` The crash happens on `mainloop`. This worked for me on macOS

[issue36674] "unittest.TestCase.debug" should honour "skip" (and other test controls)

2019-07-28 Thread Michael Foord
Michael Foord added the comment: "I don't know why run() returns None for skipIf cases instead of returning a TestResult with non-empty skipped, as it does for skipTest, or if the None is a separate bug." That does sound like a bug. -- ___

[issue37668] Allow individual test to be specified by "#" or "."

2019-07-28 Thread Michael Foord
Change by Michael Foord : -- resolution: -> rejected stage: -> resolved status: open -> closed ___ Python tracker ___ ___

[issue37669] Make mock_open return per-file content

2019-07-28 Thread Michael Foord
Michael Foord added the comment: Can you suggest an API for doing this? -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue1760357] ZipFile.write fails with bad modification time

2019-07-28 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Linsey Alvarez, I am not sure how it's related to email. So I am removing the email tag and changing the subject back. -- components: -email nosy: +xtreak title: loveubyl...@gmail.com -> ZipFile.write fails with bad modification time

[issue1760357] loveubyl...@gmail.com

2019-07-28 Thread Linsey Alvarez
Change by Linsey Alvarez : -- components: +email nosy: +Linsey Alvarez, barry, r.david.murray ___ Python tracker ___ ___

[issue1760357] loveubyl...@gmail.com

2019-07-28 Thread Linsey Alvarez
Change by Linsey Alvarez : -- title: ZipFile.write fails with bad modification time -> loveubyl...@gmail.com ___ Python tracker ___

[issue33772] Fix few dead code paths

2019-07-28 Thread Zackery Spytz
New submission from Zackery Spytz : PR 7418 has been merged, so I think this issue can be closed. -- nosy: +ZackerySpytz ___ Python tracker ___

[issue2920] Patch to print symbolic value of errno in OSError.__str__()

2019-07-28 Thread Zackery Spytz
Change by Zackery Spytz : -- title: Patch to print symbolic value or errno in EnvironmentError.__str__() -> Patch to print symbolic value of errno in OSError.__str__() versions: +Python 3.9 -Python 3.3 ___ Python tracker

[issue37628] IDLE: Fix Font sample (config dialog) geometry

2019-07-28 Thread Tal Einat
Tal Einat added the comment: Terry, thanks for reviewing, helping get this fully ready, and merging. Kyle, thanks for the kind feedback, it's truly heart-warming! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___