[issue34410] itertools.tee not thread-safe; can segfault interpreter when wrapped iterator releases GIL

miss-islington added the comment: New changeset 6e3809c7ce9fbee11c3a3f89dd7e89829b7581ac by Miss Islington (bot) in branch '3.8': bpo-34410: Fix a crash in the tee iterator when re-enter it. (GH-15625) https://github.com/python/cpython/commit/6e3809c7ce9fbee11c3a3f89dd7e89829b7581ac

[issue38061] FreeBSD: Optimize subprocess.Popen(close_fds=True) using closefrom()

Kubilay Kocak added the comment: @Victor I mounted fdescfs on the buildbot workers to make the tests run faster. You're correct that it's not enabled by default. If we could look at the initial support being as simple as possible, we can look to backport this to 2.7 as well --

[issue15817] Misc/gdbinit: Expose command documentation to gdb help

Zachary Ware added the comment: New changeset 1f86fdcfc57270ee569cc58269a4e08afe7608ec by Zachary Ware (Florian Bruhin) in branch 'master': bpo-15817: gdbinit: Document commands after defining them (GH-15021) https://github.com/python/cpython/commit/1f86fdcfc57270ee569cc58269a4e08afe7608ec

[issue34410] itertools.tee not thread-safe; can segfault interpreter when wrapped iterator releases GIL

Change by Serhiy Storchaka : -- pull_requests: +15394 pull_request: https://github.com/python/cpython/pull/15740 ___ Python tracker ___

[issue38061] FreeBSD: Optimize subprocess.Popen(close_fds=True) using closefrom()

Kubilay Kocak added the comment: We're tracking this in our downstream bug: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221700 There's a patch there you may base something upstream on Open question: closefrom(2) test in ./configure && ifdef __FreeBSD__ ? --

[issue15382] os.utime() mishandles some arguments

STINNER Victor added the comment: By the way, error messages are now also correct: >>> os.utime("x", ns=None) Traceback (most recent call last): File "", line 1, in TypeError: utime: 'ns' must be a tuple of two ints >>> os.utime("x", times=(0, 0), ns=None) Traceback (most recent call

[issue15382] os.utime() mishandles some arguments

STINNER Victor added the comment: > The documentation issue was fixed in issue23738. The documentation no longer > claims that ns can be None. If specified it must be a tuple of floats. tuple of integers, not tuple a floats. Python 3.9 documentation says: "If ns is specified, it must be a

[issue34155] email.utils.parseaddr mistakenly parse an email

Riccardo Schirone added the comment: CVE-2019-16056 has been assigned to this issue. See https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-16056 . -- nosy: +rschiron ___ Python tracker

[issue38062] Clarify that atexit.unregister matches by equality, not identity

Change by Mark Dickinson : -- assignee: -> docs@python components: +Documentation nosy: +docs@python versions: +Python 3.7, Python 3.8 ___ Python tracker ___

[issue38062] Clarify that atexit.unregister matches by equality, not identity

New submission from Mark Dickinson : Suppose I have a class that looks like this: class A: def cleanup(self): print("Doing essential cleanup") and on an instance `a = A()`, I do: `atexit.register(a.cleanup)`. Then it's not obvious from the documentation that an

[issue38038] Remove urllib.parse._splittype from xmlrpc.client

STINNER Victor added the comment: > Let's remove the deprecated urllib.parse._splituser and > urllib.parse._splittype from xmlrpc.client splittype() is deprecated, _splittype() is not deprecated. Should we deprecate _splittype() as well? I don't know the rationale of splittype()

[issue34410] itertools.tee not thread-safe; can segfault interpreter when wrapped iterator releases GIL

Change by miss-islington : -- pull_requests: +15392 pull_request: https://github.com/python/cpython/pull/15737 ___ Python tracker ___

[issue34410] itertools.tee not thread-safe; can segfault interpreter when wrapped iterator releases GIL

Serhiy Storchaka added the comment: New changeset 526a01467b3277f9fcf7f91e66c23321caa1245d by Serhiy Storchaka in branch 'master': bpo-34410: Fix a crash in the tee iterator when re-enter it. (GH-15625) https://github.com/python/cpython/commit/526a01467b3277f9fcf7f91e66c23321caa1245d

[issue38007] Regression: name of PyType_Spec::slots conflicts with Qt macro

STINNER Victor added the comment: I don't understand this issue, it mostly contains reference to other bugs. Can someone please try to elaborate the issue? "Regression: name of PyType_Spec::slots conflicts with Qt macro" What is "::slots"? Is it C++ syntax? I don't understand how "slots"

[issue34410] itertools.tee not thread-safe; can segfault interpreter when wrapped iterator releases GIL

Change by miss-islington : -- pull_requests: +15393 pull_request: https://github.com/python/cpython/pull/15738 ___ Python tracker ___

[issue34037] asyncio: BaseEventLoop.close() shutdowns the executor without waiting causing leak of dangling threads

STINNER Victor added the comment: I change the version to Python 3.9: the 3.8 branch don't accept new features anymore. -- versions: +Python 3.9 -Python 3.8 ___ Python tracker

[issue38061] FreeBSD: Optimize subprocess.Popen(close_fds=True) using closefrom()

STINNER Victor added the comment: > FreeBSD has a similar concept using /dev/fd "file-descriptor file system". > (...) I'm not sure how it is supposed to work. Sadly, on my FreeBSD VM, it seems like /dev/fd/ is not mounted with fdescfs by default, but as a regular directory with 3 hardcoded

[issue38061] FreeBSD: Optimize subprocess.Popen(close_fds=True) using closefrom()

STINNER Victor added the comment: Oh, _posixsubprocess uses /dev/fd/ on FreeBSD, but only if it's mounted file system (expected to be fdescfs filesystem): #if defined(__FreeBSD__) || (defined(__APPLE__) && defined(__MACH__)) # define FD_DIR "/dev/fd" #else # define FD_DIR "/proc/self/fd"

[issue38061] FreeBSD: Optimize subprocess.Popen(close_fds=True) using closefrom()

STINNER Victor added the comment: > On Linux, _posixsubprocess lists the content of /proc/self/fd/ to only close > open file descriptor, after fork() and before exec(). This code is specific to Linux because it uses the SYS_getdents64 syscall. FreeBSD has a similar concept using /dev/fd

[issue34410] itertools.tee not thread-safe; can segfault interpreter when wrapped iterator releases GIL

Change by Serhiy Storchaka : -- pull_requests: +15391 pull_request: https://github.com/python/cpython/pull/15736 ___ Python tracker ___

[issue38061] FreeBSD: Optimize subprocess.Popen(close_fds=True) using closefrom()

STINNER Victor added the comment: See also bpo-13788: "os.closerange optimization". -- ___ Python tracker ___ ___ Python-bugs-list

[issue27898] regexp performance degradation between 2.7.6 and 2.7.12

Change by Serhiy Storchaka : -- status: open -> pending ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue13788] os.closerange optimization

STINNER Victor added the comment: See also bpo-38061: "FreeBSD: Optimize subprocess.Popen(close_fds=True) using closefrom()". -- ___ Python tracker ___

[issue38061] FreeBSD: Optimize subprocess.Popen(close_fds=True) using closefrom()

Change by STINNER Victor : -- nosy: +koobs ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38061] FreeBSD: Optimize subprocess.Popen(close_fds=True) using closefrom()

STINNER Victor added the comment: A workaround is to use close_fds=False which is only safe if all code used in Python implements the PEP 446. This PEP mentions the FreeBSD issue, mentioning bpo-11284 with MAXFD=655,000: "The operation can be slow if MAXFD is large. For example, on a

[issue37790] subprocess.Popen() is extremely slow

STINNER Victor added the comment: I create bpo-38061 "FreeBSD: Optimize subprocess.Popen(close_fds=True) using closefrom()". -- ___ Python tracker ___

[issue38061] FreeBSD: Optimize subprocess.Popen(close_fds=True) using closefrom()

New submission from STINNER Victor : The default value of subprocess.Popen "close_fds" parameter changed to True in Python 3. Compared to Python 2, close_fds=True can make Popen 10x slower: see bpo-37790. A single close(fd) syscall is cheap. But when MAXFDS (maximum file descriptor number)

[issue21024] PyTypeObject tp_doc is char* instead of const char*

Change by Serhiy Storchaka : -- resolution: -> out of date stage: -> resolved status: open -> closed ___ Python tracker ___ ___

<    1   2   3   4