[issue38192] Fix invocation of EchoClientProtocol

2019-09-16 Thread Hrvoje Nikšić
New submission from Hrvoje Nikšić : This is a followup on issue38178. While testing the new code, I noticed that my change introduced a bug, where the code still attempts to pass "loop" when constructing an EchoClientProtocol. A pull request is attached. Also, I've noticed that the MyProtocol

[issue28556] typing.py upgrades

2019-09-16 Thread Ivan Levkivskyi
Change by Ivan Levkivskyi : -- pull_requests: +15808 pull_request: https://github.com/python/cpython/pull/16204 ___ Python tracker ___ _

[issue38155] Add __all__ to the datetime module

2019-09-16 Thread Tahia K
Change by Tahia K : -- keywords: +patch pull_requests: +15807 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/16203 ___ Python tracker _

[issue38155] Add __all__ to the datetime module

2019-09-16 Thread Tahia K
Tahia K added the comment: Thanks @corona10. I've posted a PR with all these bits. -- ___ Python tracker ___ ___ Python-bugs-list m

[issue38193] http.client should be "runnable" like http.server

2019-09-16 Thread Will Boyce
New submission from Will Boyce : I think it would be both sensible and useful if the `http.client` library exposed a "runnable" interface (similar to `http.server`). I would suggest keeping it simple, for example: python -m http.client python -m http.client -o -- components: Libra

[issue28556] typing.py upgrades

2019-09-16 Thread miss-islington
Change by miss-islington : -- pull_requests: +15809 pull_request: https://github.com/python/cpython/pull/16205 ___ Python tracker ___ __

[issue28556] typing.py upgrades

2019-09-16 Thread Ivan Levkivskyi
Ivan Levkivskyi added the comment: New changeset 81528ba2e81c39f4d6bca5b785e818c7d08b8501 by Ivan Levkivskyi in branch 'master': bpo-28556: Update the opening note in typing docs (GH-16204) https://github.com/python/cpython/commit/81528ba2e81c39f4d6bca5b785e818c7d08b8501 -- ___

[issue28556] typing.py upgrades

2019-09-16 Thread miss-islington
Change by miss-islington : -- pull_requests: +15810 pull_request: https://github.com/python/cpython/pull/16206 ___ Python tracker ___ __

[issue28556] typing.py upgrades

2019-09-16 Thread miss-islington
miss-islington added the comment: New changeset 733193d050f317a7965faac6c3718e6e8316a8a0 by Miss Islington (bot) in branch '3.7': bpo-28556: Update the opening note in typing docs (GH-16204) https://github.com/python/cpython/commit/733193d050f317a7965faac6c3718e6e8316a8a0 -- __

[issue28556] typing.py upgrades

2019-09-16 Thread miss-islington
miss-islington added the comment: New changeset 7076764992cd29e0e1f8b0ac2b92403e1a698aa6 by Miss Islington (bot) in branch '3.8': bpo-28556: Update the opening note in typing docs (GH-16204) https://github.com/python/cpython/commit/7076764992cd29e0e1f8b0ac2b92403e1a698aa6 -- __

[issue38194] Consistently add exist_ok / missing_ok parameters to directory creation/deletion functions

2019-09-16 Thread Tim Hoffmann
New submission from Tim Hoffmann : The following functions accept exist_ok/missing_ok parameters: - Path.mkdir(exist_ok) - os.makedirs(exist_ok) - shutil.copytree(dirs_exist_ok) - (https://bugs.python.org/issue20849) - Path.unlink(missing_ok) - (https://bugs.python.org/issue33123) For consiste

[issue38183] test_idle fails on AMD64 FreeBSD CURRENT Shared 3.x: GetUserCfgDir() fails with PermissionError

2019-09-16 Thread miss-islington
Change by miss-islington : -- pull_requests: +15811 stage: commit review -> patch review pull_request: https://github.com/python/cpython/pull/16207 ___ Python tracker ___ _

[issue38183] test_idle fails on AMD64 FreeBSD CURRENT Shared 3.x: GetUserCfgDir() fails with PermissionError

2019-09-16 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 0048afc16a7e7301d5c565237db271505e5fbed9 by Terry Jan Reedy in branch 'master': bpo-38183: Test_idle ignores user config directory GH-16198) https://github.com/python/cpython/commit/0048afc16a7e7301d5c565237db271505e5fbed9 --

[issue38183] test_idle fails on AMD64 FreeBSD CURRENT Shared 3.x: GetUserCfgDir() fails with PermissionError

2019-09-16 Thread miss-islington
Change by miss-islington : -- pull_requests: +15812 pull_request: https://github.com/python/cpython/pull/16208 ___ Python tracker ___ __

[issue38177] test_tools: test.test_tools.test_unparse.UnparseTestCase: test_tools leaked [36, 36, 36] references

2019-09-16 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Pyt

[issue37224] test__xxsubinterpreters failed on AMD64 Windows8.1 Refleaks 3.8

2019-09-16 Thread Kyle Stanley
Kyle Stanley added the comment: Upon further consideration, I don't think this will address the issue. If the RuntimeError was not being raised, this failure would be consistent rather than intermittent. I think I have have gotten a bit mixed up, even if the return value of PyErr_Format is

[issue38183] test_idle fails on AMD64 FreeBSD CURRENT Shared 3.x: GetUserCfgDir() fails with PermissionError

2019-09-16 Thread miss-islington
miss-islington added the comment: New changeset 523497cbdc8292bfc12938aaaca0ad02a7708c25 by Miss Islington (bot) in branch '3.7': bpo-38183: Test_idle ignores user config directory GH-16198) https://github.com/python/cpython/commit/523497cbdc8292bfc12938aaaca0ad02a7708c25 -- __

[issue38183] test_idle fails on AMD64 FreeBSD CURRENT Shared 3.x: GetUserCfgDir() fails with PermissionError

2019-09-16 Thread miss-islington
miss-islington added the comment: New changeset ad845becf29afe0507a46a4b885a9670b5d7639d by Miss Islington (bot) in branch '3.8': bpo-38183: Test_idle ignores user config directory GH-16198) https://github.com/python/cpython/commit/ad845becf29afe0507a46a4b885a9670b5d7639d -- nosy: +

[issue38183] test_idle fails on AMD64 FreeBSD CURRENT Shared 3.x: GetUserCfgDir() fails with PermissionError

2019-09-16 Thread Kubilay Kocak
Kubilay Kocak added the comment: I can restart the worker to create the environment that reproduces the issue at any time to confirm the test passes, just let me know -- ___ Python tracker _

[issue30458] [security][CVE-2019-9740][CVE-2019-9947] HTTP Header Injection (follow-up of CVE-2016-5699)

2019-09-16 Thread Ned Deily
Ned Deily added the comment: If I understand Jason's message correctly, the changes for Issue30458 introduced a regression in 3.7.4 and will introduce the same regression in other branches as they are released, including 3.5.8 whose rc1 is now in testing. 3.7.5rc1 is scheduled to be tagged

[issue36274] http.client cannot send non-ASCII request lines

2019-09-16 Thread Ned Deily
Ned Deily added the comment: See msg352596 in Issue30458 for discussion of whether the regression should be considered a "release blocker" for the imminent 3.7.5 and 3.5.8 releases. -- keywords: +3.7regression nosy: +ned.deily ___ Python tracker <

[issue38013] AsyncGenerator breaks when not iterated fully with RuntimeError("can't send non-None value to a just-started coroutine")

2019-09-16 Thread Ned Deily
Ned Deily added the comment: > I've added 'release blocker' priority to don't miss this bugfix for the next > release. Note that 3.7.5rc1 is scheduled to be tagged today so we need to make a decision on whether to hold the release for a fix. From a quick test, it looks like the behavior wa

[issue35379] IDLE's close fails io is set to None on Mac

2019-09-16 Thread Terry J. Reedy
Change by Terry J. Reedy : -- pull_requests: +15813 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16212 ___ Python tracker ___ __

[issue35379] IDLE's close fails io is set to None on Mac

2019-09-16 Thread Terry J. Reedy
Terry J. Reedy added the comment: By reading idlelib code, I determined that the error must arise from EditorWindow.close being called twice. I confirmed this with a debug print. EW.close is called from close_event, PyShell.close, and filelist.close_all_callback. For the AttributeError I se

[issue35379] IDLE's close fails io is set to None on Mac

2019-09-16 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset dfd34a9cd58e8150c324190f746de919e140abe8 by Terry Jan Reedy in branch 'master': bpo-35379: When exiting IDLE, catch any AttributeError. (GH-16212) https://github.com/python/cpython/commit/dfd34a9cd58e8150c324190f746de919e140abe8 -- __

[issue35379] IDLE's close fails io is set to None on Mac

2019-09-16 Thread miss-islington
Change by miss-islington : -- pull_requests: +15815 pull_request: https://github.com/python/cpython/pull/16214 ___ Python tracker ___ __

[issue35379] IDLE's close fails io is set to None on Mac

2019-09-16 Thread miss-islington
Change by miss-islington : -- pull_requests: +15814 stage: commit review -> patch review pull_request: https://github.com/python/cpython/pull/16213 ___ Python tracker ___ _

[issue38175] Memory leak in comparison of sqlite.Row objects

2019-09-16 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +15816 pull_request: https://github.com/python/cpython/pull/16215 ___ Python tracker ___

[issue38175] Memory leak in comparison of sqlite.Row objects

2019-09-16 Thread miss-islington
miss-islington added the comment: New changeset 4ac1be28281d8961e71b13623c3671245c125760 by Miss Islington (bot) in branch '3.7': bpo-38175: Fix a memory leak in comparison of sqlite3.Row objects. (GH-16155) https://github.com/python/cpython/commit/4ac1be28281d8961e71b13623c3671245c125760 -

[issue38175] Memory leak in comparison of sqlite.Row objects

2019-09-16 Thread miss-islington
miss-islington added the comment: New changeset f04299d978793be33828dc4d5f46e9b54c81a0a2 by Miss Islington (bot) in branch '3.8': bpo-38175: Fix a memory leak in comparison of sqlite3.Row objects. (GH-16155) https://github.com/python/cpython/commit/f04299d978793be33828dc4d5f46e9b54c81a0a2 -

[issue38013] AsyncGenerator breaks when not iterated fully with RuntimeError("can't send non-None value to a just-started coroutine")

2019-09-16 Thread Andrew Svetlov
Andrew Svetlov added the comment: Thanks, Ned. I love to include this in 3.7.5. I've pinged Yuri offline with ask for review -- ___ Python tracker ___

[issue38185] Weird way of case-insensitive indexing of sqlite3.Row

2019-09-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset f669581a9527afb0d2325f9845a86715c0ba365d by Serhiy Storchaka in branch 'master': bpo-38185: Fixed case-insensitive string comparison in sqlite3.Row indexing. (GH-16190) https://github.com/python/cpython/commit/f669581a9527afb0d2325f9845a86715

[issue38185] Weird way of case-insensitive indexing of sqlite3.Row

2019-09-16 Thread miss-islington
Change by miss-islington : -- pull_requests: +15818 pull_request: https://github.com/python/cpython/pull/16217 ___ Python tracker ___ __

[issue38185] Weird way of case-insensitive indexing of sqlite3.Row

2019-09-16 Thread miss-islington
Change by miss-islington : -- pull_requests: +15817 pull_request: https://github.com/python/cpython/pull/16216 ___ Python tracker ___ __

[issue38183] test_idle fails on AMD64 FreeBSD CURRENT Shared 3.x: GetUserCfgDir() fails with PermissionError

2019-09-16 Thread Terry J. Reedy
Terry J. Reedy added the comment: Except for an unrelated gui test on AMD Alpine, the revised tests pass all buildbots. So try with the reproducing condition whenever you want. -- stage: patch review -> commit review ___ Python tracker

[issue35379] IDLE's close fails io is set to None on Mac

2019-09-16 Thread miss-islington
miss-islington added the comment: New changeset 73ccc3322f7ad0d016478ef20237bccd0a314f0a by Miss Islington (bot) in branch '3.8': bpo-35379: When exiting IDLE, catch any AttributeError. (GH-16212) https://github.com/python/cpython/commit/73ccc3322f7ad0d016478ef20237bccd0a314f0a -- n

[issue35379] IDLE's close fails io is set to None on Mac

2019-09-16 Thread miss-islington
miss-islington added the comment: New changeset 3d916a7b1ee29896bece4a6a37d8084fa3c1abf6 by Miss Islington (bot) in branch '3.7': bpo-35379: When exiting IDLE, catch any AttributeError. (GH-16212) https://github.com/python/cpython/commit/3d916a7b1ee29896bece4a6a37d8084fa3c1abf6 --

[issue38183] test_idle fails on AMD64 FreeBSD CURRENT Shared 3.x: GetUserCfgDir() fails with PermissionError

2019-09-16 Thread Kubilay Kocak
Kubilay Kocak added the comment: Thanks Terry, I've restarted the worker under sudo The following builds are underway: https://buildbot.python.org/all/#/builders/168/builds/1467 (default) https://buildbot.python.org/all/#/builders/212/builds/218 (3.8) https://buildbot.python.org/all/#/builde

[issue35379] IDLE's close fails io is set to None on Mac

2019-09-16 Thread Terry J. Reedy
Terry J. Reedy added the comment: Before closing this, I want to review #17822 and if the specific fix is superceded by this one, remove it. -- stage: patch review -> commit review ___ Python tracker __

[issue38188] Incorrect Argument Order for Calls to _winapi.DuplicateHandle() in multiprocessing.reduction.DupHandle

2019-09-16 Thread Eryk Sun
Eryk Sun added the comment: As far as I can tell, reduction.send_handle isn't used internally in the Windows implementation, and it's also not a documented API function. However, it is tested on Windows in test_fd_transfer in Lib/test/_test_multiprocessing.py. As it turns out, the bug that C

[issue38185] Weird way of case-insensitive indexing of sqlite3.Row

2019-09-16 Thread miss-islington
miss-islington added the comment: New changeset d8d653c2d0d267eb1e44f6cdb916945029fec3b1 by Miss Islington (bot) in branch '3.8': bpo-38185: Fixed case-insensitive string comparison in sqlite3.Row indexing. (GH-16190) https://github.com/python/cpython/commit/d8d653c2d0d267eb1e44f6cdb91694502

[issue38185] Weird way of case-insensitive indexing of sqlite3.Row

2019-09-16 Thread miss-islington
miss-islington added the comment: New changeset 80cb055aa45f37951b8e3097fe4367d443d455ae by Miss Islington (bot) in branch '3.7': bpo-38185: Fixed case-insensitive string comparison in sqlite3.Row indexing. (GH-16190) https://github.com/python/cpython/commit/80cb055aa45f37951b8e3097fe4367d44

[issue38195] A bug in the multiprocessing module

2019-09-16 Thread eshkrig
New submission from eshkrig : Hi! I found a bug in the multiprocessing module. The documentation (https://docs.python.org/3.6/library/multiprocessing.html) for the Queue.get method says: "If timeout is a positive number, it blocks at most timeout seconds ..." But the Queue.get method freezes

[issue38175] Memory leak in comparison of sqlite.Row objects

2019-09-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset be257bcad12b1d72a2c2a8199d2291ae22bccf78 by Serhiy Storchaka in branch '2.7': [2.7] bpo-38175: Fix a memory leak in comparison of sqlite3.Row objects. (GH-16155). (GH-16215) https://github.com/python/cpython/commit/be257bcad12b1d72a2c2a8199d2

[issue38175] Memory leak in comparison of sqlite.Row objects

2019-09-16 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

<    1   2