[issue39087] [C API] No efficient C API to get UTF-8 string from unicode object.

2019-12-24 Thread Inada Naoki
Inada Naoki added the comment: > I like this idea, but I think that we should at least notify Python-Dev about > all additions to the public C API. If somebody have objections or better > idea, it is better to know earlier. I created a post about this issue in discuss.python.org.

[issue38753] AsyncMock not cited as new in 3.8

2019-12-24 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Thanks John for the report and patch. Closing it as resolved. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue38753] AsyncMock not cited as new in 3.8

2019-12-24 Thread miss-islington
miss-islington added the comment: New changeset 8c0f0016e2d39f86589187db75012238c4e760e9 by Miss Islington (bot) in branch '3.8': bpo-38753: AsyncMock added in version 3.8 (GH-17102) https://github.com/python/cpython/commit/8c0f0016e2d39f86589187db75012238c4e760e9 -- nosy:

[issue39040] Wrong attachement filename when mail mime header was too long

2019-12-24 Thread Abhilash Raj
Abhilash Raj added the comment: I double checked, there should be 4 commits in the PR and last 2 have the changes that you asked for in the test case and NEWS entry. Your previous comment will point at the old diff, you might have to look at the full diff here:

[issue38999] Python launcher on Windows does not detect active venv

2019-12-24 Thread Ross Boylan
Ross Boylan added the comment: As someone who finds the current behavior surprising, and having lost significant time because of it, I have a couple of comments. 1) If the venv created a python3 (or 2, as appropriate) file, would the expected behavior with !#/usr/bin/env python3 be restored?

[issue34444] Module's __file__ should be absolute always ("." in sys.path)

2019-12-24 Thread daniel hahler
daniel hahler added the comment: > And changing this to have to check every time import runs if an entry in > sys.path is absolute would be costly (that's not a insignificant number of > stat calls which we always try to avoid during import when possible). This could be done when inserting

[issue39090] Document various options for getting the absolute path from pathlib.Path objects

2019-12-24 Thread Chris Barker
Chris Barker added the comment: Yes Please! I'd offer to help, but I really don't get the intricacies involved. I will offer to proofread and copy-edit though, if that's helpful. And I note that coincidentally, just in the last week, I needed to make an absolute path from a Path, and it

[issue39040] Wrong attachement filename when mail mime header was too long

2019-12-24 Thread R. David Murray
R. David Murray added the comment: I don't see the change to the test in the PR. Did you miss a push or is github doing something wonky with the review? (I haven't used github review in a while and I had forgetten how hard it is to use...) --

[issue34444] Module's __file__ should be absolute always ("." in sys.path)

2019-12-24 Thread Brett Cannon
Brett Cannon added the comment: So if you were to insert '.' via PYTHONPATH it would be made absolute as the site module makes all entries in sys.path absolute during startup. And changing this to have to check every time import runs if an entry in sys.path is absolute would be costly

[issue39111] Misleading documentation for NotImplemented

2019-12-24 Thread Brett Cannon
Change by Brett Cannon : -- nosy: -brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue39131] signing needs two serialisation passes

2019-12-24 Thread R. David Murray
R. David Murray added the comment: Ideally this should be exposed by extending the content manager. Instantiating MIME classes is part of the old API, not the new. The code in the PR may well be correct, but class should be hidden from the normal user (of the new API). I'm not sure what

[issue39131] signing needs two serialisation passes

2019-12-24 Thread Jasper Spaans
Change by Jasper Spaans : -- keywords: +patch pull_requests: +17149 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17695 ___ Python tracker ___

[issue39132] Adding funcitonality to determine if a constant string node is triple quoted

2019-12-24 Thread Batuhan
New submission from Batuhan : I was working on a preceding system for AST unparser and @pablogsal said there is an issue with docstrings (they printed in the same line even it was like 1000 chars long). So determining something is a triple quoted or not is simple with preceding system but I

[issue39131] signing needs two serialisation passes

2019-12-24 Thread Jasper Spaans
New submission from Jasper Spaans : When creating multipart/signed messages, this currently require two serialisation passes: once to extract the flattened contents to be signed, and once to actually serialise the message. The PR this ticket will be linked to contains a new class,

[issue39130] Dict is reversable from v3.8 and should say that in the doc

2019-12-24 Thread Khalid Mammadov
Change by Khalid Mammadov : -- keywords: +patch pull_requests: +17148 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17694 ___ Python tracker ___

[issue39130] Dict is reversable from v3.8 and should say that in the doc

2019-12-24 Thread Khalid Mammadov
Change by Khalid Mammadov : -- assignee: docs@python components: Documentation nosy: docs@python, khalidmammadov priority: normal severity: normal status: open title: Dict is reversable from v3.8 and should say that in the doc type: enhancement versions: Python 3.8

[issue39129] Incorrect import of TimeoutError while creating happy eyeballs connection

2019-12-24 Thread Andrew Svetlov
Andrew Svetlov added the comment: The main problem of mock-based tests in asyncio is that the tests become unreliably very easy after mocked asyncio internal changes. I'm +0 on adding the proposed test. The better idea is serving on explicit AF_INET '127.0.0.1:' address when the connection

[issue39129] Incorrect import of TimeoutError while creating happy eyeballs connection

2019-12-24 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Is there a way this can be tested? I tried simulating OSError for IPv4 address and returning socket for ipv6 one like it resolves correctly. I guess that's the underlying idea of happy eyeballs but a test can be added for basic workflow since it

[issue39129] Incorrect import of TimeoutError while creating happy eyeballs connection

2019-12-24 Thread miss-islington
Change by miss-islington : -- pull_requests: +17147 pull_request: https://github.com/python/cpython/pull/17693 ___ Python tracker ___

[issue39115] Clarify Python MIME type

2019-12-24 Thread Andrew Svetlov
Andrew Svetlov added the comment: As you mentioned, IANA did not registry any programming language except JavaScript; I think that's fine. You can consider text/x-python and application/x-python-code as unofficial but permanent MIME types that are used in Python written programs at least;

[issue39129] Incorrect import of TimeoutError while creating happy eyeballs connection

2019-12-24 Thread Andrew Svetlov
Change by Andrew Svetlov : -- keywords: +patch pull_requests: +17146 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17691 ___ Python tracker ___

[issue39129] Incorrect import of TimeoutError while creating happy eyeballs connection

2019-12-24 Thread Andrew Svetlov
Andrew Svetlov added the comment: You are right. Hmm, I thought that Happy Eyeballs is better tested. -- ___ Python tracker ___

[issue39128] Document happy eyeball parameters in loop.create_connection signature docs

2019-12-24 Thread Andrew Svetlov
Andrew Svetlov added the comment: Ideally, a small chapter with a description of Happy Eyeballs algorithm would be nice to have but I don't insist. Updating the method signature is a big step anyway. -- keywords: +easy ___ Python tracker

[issue38225] iscoroutinefunction broken with cython - allow tagging of functions as async?

2019-12-24 Thread Andrew Svetlov
Andrew Svetlov added the comment: I'd like to hear Yuri's opinion for the idea of adding an attribute. Another question is the name: I have proposed __awaitable__ but maybe __async__ is slightly better? -- ___ Python tracker