[issue45217] ConfigParser does not accept "No value" reversely to the doc

2021-09-17 Thread Łukasz Langa
Łukasz Langa added the comment: Thanks for the patch, Nikita! ✨ 🍰 ✨ -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue45217] ConfigParser does not accept "No value" reversely to the doc

2021-09-17 Thread Łukasz Langa
Łukasz Langa added the comment: New changeset a10726d3141d8f52a108c4daf70eefa29401e2fc by Miss Islington (bot) in branch '3.10': bpo-45217: adds note that `allow_no_value` in `configparser` is optional (GH-28396) (GH-28418) https://github.com/python/cpython/commit/a10726d3141d8f52a108c4daf70e

[issue10611] sys.exit() in a test causes a test run to die

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- nosy: +serhiy.storchaka nosy_count: 4.0 -> 5.0 pull_requests: +26829 pull_request: https://github.com/python/cpython/pull/28180 ___ Python tracker _

[issue45233] Allow split key dictionaries with values owned by other objects.

2021-09-17 Thread Mark Shannon
Mark Shannon added the comment: An alternative placement for the flag bits: Stride bits in the dictkeys. Ownership bits in the low bits of ma_used. This would still allow us to remove the version tag at some point. -- ___ Python tracker

[issue45233] Allow split key dictionaries with values owned by other objects.

2021-09-17 Thread Mark Shannon
New submission from Mark Shannon : Currently, if a dictionary is split, then the dictionary owns the memory for the values. Unless the values is the unique empty-values array. In order to support lazily created dictionaries for objects (see https://github.com/faster-cpython/ideas/issues/72#is

[issue45232] ascii codec is used by default when LANG is not set

2021-09-17 Thread Olivier Delhomme
New submission from Olivier Delhomme : $ python3 --version Python 3.6.4 Setting LANG to en_US.UTF8 works like a charm $ export LANG=en_US.UTF8 $ python3 Python 3.6.4 (default, Jan 11 2018, 16:45:55) [GCC 4.8.5] on linux Type "help", "copyright", "credits" or "license" for more information.

[issue45120] Windows cp encodings "UNDEFINED" entries update

2021-09-17 Thread Eryk Sun
Eryk Sun added the comment: > From Eryk's description it sounds like we should always add > WC_NO_BEST_FIT_CHARS as an option to MultiByteToWideChar() > in order to make sure it doesn't use best fit variants > unless explicitly requested. The concept of a "best fit" encoding is unrelated to

[issue45116] Performance regression 3.10b1 and later on Windows: Py_DECREF() not inlined in PGO build

2021-09-17 Thread STINNER Victor
STINNER Victor added the comment: I added Py_ALWAYS_INLINE to run benchmarks more easily. Even if Py_INCREF() is converted back to a macro, there are now multiple static inline functions which are short and performance critical. Using Py_ALWAYS_INLINE *may* speed up the Python debug builds a

[issue45116] Performance regression 3.10b1 and later on Windows: Py_DECREF() not inlined in PGO build

2021-09-17 Thread STINNER Victor
STINNER Victor added the comment: New changeset 6b413551284a94cfe31377c9c607ff890aa06c26 by Victor Stinner in branch 'main': bpo-45116: Add the Py_ALWAYS_INLINE macro (GH-28390) https://github.com/python/cpython/commit/6b413551284a94cfe31377c9c607ff890aa06c26 -- ___

[issue5846] Deprecate obsolete functions in unittest

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: It is an internal function. We can remove it without deprecation. -- ___ Python tracker ___ ___

[issue45228] Stack buffer overflow in parsing J1939 network address

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue45187] Some tests in test_socket are not run

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 0f4449ecb0d678984b1343d60c070dcb1bd62e56 by Łukasz Langa in branch '3.9': [3.9] bpo-45187: Collect test_socket tests using unittest (GH-28317) (GH-28413) https://github.com/python/cpython/commit/0f4449ecb0d678984b1343d60c070dcb1bd62e56 --

[issue45116] Performance regression 3.10b1 and later on Windows: Py_DECREF() not inlined in PGO build

2021-09-17 Thread STINNER Victor
STINNER Victor added the comment: > the entire eval function is now too big for PGO on MSVC I don't think that the issue is specific to MSVC. If a function becomes too big, it becomes less efficient for CPU caches. One idea would be to move the least common opcodes into a slow-path, in a se

[issue45217] ConfigParser does not accept "No value" reversely to the doc

2021-09-17 Thread Łukasz Langa
Łukasz Langa added the comment: New changeset 3ea1c4b66887e7ca920db487f6ffc5f1db3c873f by Miss Islington (bot) in branch '3.9': bpo-45217: adds note that `allow_no_value` in `configparser` is optional (GH-28396) (GH-28416) https://github.com/python/cpython/commit/3ea1c4b66887e7ca920db487f6ffc

[issue45217] ConfigParser does not accept "No value" reversely to the doc

2021-09-17 Thread miss-islington
Change by miss-islington : -- pull_requests: +26828 pull_request: https://github.com/python/cpython/pull/28418 ___ Python tracker ___ __

[issue44211] Duplicate '.bmp' key in mimetypes.py, maps to both 'image/bmp' and 'image/x-ms-bmp'

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: It is not clear whether we want to backport this change. -- ___ Python tracker ___ ___ Python-b

[issue45219] Expose indexing and other simple operations on dict-keys in internal API

2021-09-17 Thread Mark Shannon
Change by Mark Shannon : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue45219] Expose indexing and other simple operations on dict-keys in internal API

2021-09-17 Thread Mark Shannon
Mark Shannon added the comment: New changeset 064464fc38269e70f7e3a34cb25fc9085ab85782 by Mark Shannon in branch 'main': bpo-45219: Factor dictkey indexing (GH-28389) https://github.com/python/cpython/commit/064464fc38269e70f7e3a34cb25fc9085ab85782 -- __

[issue45217] ConfigParser does not accept "No value" reversely to the doc

2021-09-17 Thread miss-islington
Change by miss-islington : -- nosy: +miss-islington nosy_count: 4.0 -> 5.0 pull_requests: +26827 pull_request: https://github.com/python/cpython/pull/28416 ___ Python tracker _

[issue45217] ConfigParser does not accept "No value" reversely to the doc

2021-09-17 Thread Łukasz Langa
Łukasz Langa added the comment: New changeset cb07838ab756564988b1ffd23871f1222a832446 by Nikita Sobolev in branch 'main': bpo-45217: adds note that `allow_no_value` in `configparser` is optional (GH-28396) https://github.com/python/cpython/commit/cb07838ab756564988b1ffd23871f1222a832446 --

[issue45107] Improve LOAD_METHOD specialization

2021-09-17 Thread Ken Jin
Ken Jin added the comment: New changeset 70bed6f9936c811472b376edd93c37bcf8f06f35 by Ken Jin in branch 'main': bpo-45107: Make LOAD_METHOD_CLASS safer and faster, clean up comments (GH-28177) https://github.com/python/cpython/commit/70bed6f9936c811472b376edd93c37bcf8f06f35 -- _

[issue45187] Some tests in test_socket are not run

2021-09-17 Thread miss-islington
miss-islington added the comment: New changeset 5a5684a14b1417fea27af6b6a89eb7faec7fb80a by Miss Islington (bot) in branch '3.10': bpo-45187: Collect test_socket tests using unittest (GH-28317) https://github.com/python/cpython/commit/5a5684a14b1417fea27af6b6a89eb7faec7fb80a -- ___

[issue45162] Remove old deprecated unittest features

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue45162] Remove old deprecated unittest features

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset b0a6ede3d0bd6fa4ffe413ab4dfc1059201df25b by Serhiy Storchaka in branch 'main': bpo-45162: Remove many old deprecated unittest features (GH-28268) https://github.com/python/cpython/commit/b0a6ede3d0bd6fa4ffe413ab4dfc1059201df25b -- _

[issue45212] Dangling threads in skipped tests in test_socket

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I have merged the backported PRs because they are blockers for my other PR which is a blocker for my other PR which is a blocker for my other PR and several future PRs. -- ___ Python tracker

[issue45212] Dangling threads in skipped tests in test_socket

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +26826 pull_request: https://github.com/python/cpython/pull/28414 ___ Python tracker ___

[issue45187] Some tests in test_socket are not run

2021-09-17 Thread Łukasz Langa
Change by Łukasz Langa : -- pull_requests: +26825 pull_request: https://github.com/python/cpython/pull/28413 ___ Python tracker ___ _

[issue45187] Some tests in test_socket are not run

2021-09-17 Thread Łukasz Langa
Łukasz Langa added the comment: New changeset 0361335b80b435ca3694981b41f8269e390eb892 by Serhiy Storchaka in branch 'main': bpo-45187: Collect test_socket tests using unittest (GH-28317) https://github.com/python/cpython/commit/0361335b80b435ca3694981b41f8269e390eb892 -- nosy: +luka

[issue45187] Some tests in test_socket are not run

2021-09-17 Thread miss-islington
Change by miss-islington : -- nosy: +miss-islington nosy_count: 2.0 -> 3.0 pull_requests: +26824 pull_request: https://github.com/python/cpython/pull/28412 ___ Python tracker _

[issue45212] Dangling threads in skipped tests in test_socket

2021-09-17 Thread Łukasz Langa
Łukasz Langa added the comment: Haha, which you just did. Cool. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue45212] Dangling threads in skipped tests in test_socket

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 10c3cf78518f4b31e1527c2795694b1bcb092696 by Serhiy Storchaka in branch '3.9': [3.9] bpo-45212: Fix dangling threads in skipped tests in test_socket (GH-28361) (GH-28408) https://github.com/python/cpython/commit/10c3cf78518f4b31e1527c2795694b1

[issue45212] Dangling threads in skipped tests in test_socket

2021-09-17 Thread Łukasz Langa
Łukasz Langa added the comment: We can add a comment to the effect that "the wait here needs to be longer than the client-side (0.01s)". Since you already merged the change to `main`, it will be easiest to merge the backports as well and add the comment in a follow-up series. -- nosy

[issue45212] Dangling threads in skipped tests in test_socket

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset ce59ac93626004894c2b291ec599a36cfa9fb0be by Serhiy Storchaka in branch '3.10': [3.10] bpo-45212: Fix dangling threads in skipped tests in test_socket (GH-28361) (GH-28409) https://github.com/python/cpython/commit/ce59ac93626004894c2b291ec599a

[issue45217] ConfigParser does not accept "No value" reversely to the doc

2021-09-17 Thread Łukasz Langa
Łukasz Langa added the comment: No, it shouldn't be the default. It never was before (this is a library that we've maintained for 20+ years now) and changing it now would mean that existing applications would stop validating their configuration in the way they did up to now. .ini files are u

[issue45116] Performance regression 3.10b1 and later on Windows: Py_DECREF() not inlined in PGO build

2021-09-17 Thread Ken Jin
Ken Jin added the comment: @neonene Thanks for the truly excellent investigation! @Raymond and @Steve, If I understood OP (neonene) properly, changing Py_DECREF to a macro won't get back the entire 7% lost performance in pyperformance. neonene's investigations suggest that the entire eval fu

[issue45227] Control reaches end of non-void function in specialize.c

2021-09-17 Thread Ken Jin
Ken Jin added the comment: Fixed in https://github.com/python/cpython/commit/4857e53890408fd5a8ee0e83c0250dd5355b3de3. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker

[issue45203] Improve specialization stats for LOAD_METHOD and BINARY_SUBSCR

2021-09-17 Thread Ken Jin
Ken Jin added the comment: New changeset 4857e53890408fd5a8ee0e83c0250dd5355b3de3 by Ken Jin in branch 'main': bpo-45203: fix compiler warnings (GH-28357) https://github.com/python/cpython/commit/4857e53890408fd5a8ee0e83c0250dd5355b3de3 -- ___ Py

[issue45231] make regen-all changes files on Linux

2021-09-17 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +26823 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28411 ___ Python tracker ___ _

[issue43219] shutil.copy raises IsADirectoryError when the directory does not actually exist

2021-09-17 Thread Alex Grund
Alex Grund added the comment: The changelog wrongfully links to https://bugs.python.org/issue41928 instead of this issue. Also the fix introduced a regression: Trying to copy a directory now raises a FileNotFoundError -- nosy: +Alex Grund ___ Pyt

[issue45231] make regen-all changes files on Linux

2021-09-17 Thread STINNER Victor
STINNER Victor added the comment: See also my PR 28410 which fix Python built out of the source tree. -- ___ Python tracker ___ ___

[issue45020] Freeze all modules imported during startup.

2021-09-17 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +26822 pull_request: https://github.com/python/cpython/pull/28410 ___ Python tracker ___ __

[issue45020] Freeze all modules imported during startup.

2021-09-17 Thread STINNER Victor
STINNER Victor added the comment: There is also a minor issue, "make regen-frozen" changes the end of line of two PCbuild/ files: see bpo-45231. -- ___ Python tracker ___ ___

[issue45231] make regen-all changes files on Linux

2021-09-17 Thread STINNER Victor
New submission from STINNER Victor : "make regen-frozen" changes PCbuild/_freeze_module.vcxproj and PCbuild/_freeze_module.vcxproj.filters changes files end of line on Linux. I'm working on a fix. When Python is built out of the source free, "make regen-pegen" changes Parser/parser.c and Too

[issue45227] Control reaches end of non-void function in specialize.c

2021-09-17 Thread Ken Jin
Ken Jin added the comment: Please see https://bugs.python.org/issue45203. A fix is available at https://github.com/python/cpython/pull/28357 or https://github.com/python/cpython/pull/28386. But we're waiting for Windows CI to pass. -- nosy: +kj _

[issue45020] Freeze all modules imported during startup.

2021-09-17 Thread STINNER Victor
STINNER Victor added the comment: It's no longer possible to build Python from a different directory. Example: git clean -fdx mkdir build cd build/ ../configure --with-pydebug make It fails with: ../Programs/_freeze_module importlib._bootstrap ../Lib/importlib/_bootstrap.py ../Python/frozen

[issue5846] Deprecate obsolete functions in unittest

2021-09-17 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: _makeLoader is not deprecated yet, so we might keep this open a little bit more. -- ___ Python tracker ___

[issue5846] Deprecate obsolete functions in unittest

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue45228] Stack buffer overflow in parsing J1939 network address

2021-09-17 Thread miss-islington
miss-islington added the comment: New changeset 98fef200bbfd8adec27799265deb200ab5e4513e by Miss Islington (bot) in branch '3.9': bpo-45228: Fix stack buffer overflow in parsing J1939 address (GH-28404) https://github.com/python/cpython/commit/98fef200bbfd8adec27799265deb200ab5e4513e --

[issue5846] Deprecate obsolete functions in unittest

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- versions: +Python 3.11 -Python 3.4 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue5846] Deprecate obsolete functions in unittest

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset b2b035a949eff1dc54b5bafe2bc9ce72b4d24438 by Serhiy Storchaka in branch 'main': bpo-5846: Fix deprecations for obsolete unittest functions and add tests. (GH-28382) https://github.com/python/cpython/commit/b2b035a949eff1dc54b5bafe2bc9ce72b4d24

[issue45228] Stack buffer overflow in parsing J1939 network address

2021-09-17 Thread miss-islington
miss-islington added the comment: New changeset 62c74f34e7541cf5c9780661b260c53617291804 by Miss Islington (bot) in branch '3.10': bpo-45228: Fix stack buffer overflow in parsing J1939 address (GH-28404) https://github.com/python/cpython/commit/62c74f34e7541cf5c9780661b260c53617291804 -

[issue45230] Something wrong when Calculate "3==3 is not True"

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: No, it is a feature. Python allows you to chain comparison operations, so you can write 0 < x <= 10 which is equivalent to (0 < x) and (x <= 10). And "is" is a comparison operation. So `3==3 is not True` is equivalent to `(3==3) and (3 is not True)` which

[issue45212] Dangling threads in skipped tests in test_socket

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +26821 pull_request: https://github.com/python/cpython/pull/28409 ___ Python tracker ___

[issue45212] Dangling threads in skipped tests in test_socket

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +26820 pull_request: https://github.com/python/cpython/pull/28408 ___ Python tracker ___

[issue45228] Stack buffer overflow in parsing J1939 network address

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 773319545ba60577bc140aa46eac83b360240b7a by Serhiy Storchaka in branch 'main': bpo-45228: Fix stack buffer overflow in parsing J1939 address (GH-28404) https://github.com/python/cpython/commit/773319545ba60577bc140aa46eac83b360240b7a ---

[issue45228] Stack buffer overflow in parsing J1939 network address

2021-09-17 Thread miss-islington
Change by miss-islington : -- nosy: +miss-islington nosy_count: 1.0 -> 2.0 pull_requests: +26818 pull_request: https://github.com/python/cpython/pull/28406 ___ Python tracker _

[issue45228] Stack buffer overflow in parsing J1939 network address

2021-09-17 Thread miss-islington
Change by miss-islington : -- pull_requests: +26819 pull_request: https://github.com/python/cpython/pull/28407 ___ Python tracker ___ __

[issue45229] Always use unittest for collecting tests in regrtests

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- dependencies: +Some tests in test_socket are not run, test.test_ssl.TestEnumerations is not run ___ Python tracker ___

[issue45230] Something wrong when Calculate "3==3 is not True"

2021-09-17 Thread Wang Bingchao
New submission from Wang Bingchao <819576...@qq.com>: I use python3.7 python3.6 python2.7, and run the following code: print(3==3 is not True) print(3==3 is True) print(3==2 is not True) print(3==2 is True) I got the same results as follow: True False False False but I don't think it is a reas

[issue45229] Always use unittest for collecting tests in regrtests

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: PR 28405 contains simple changes for 60 test files. It does not cover files which use complex code for generating list of test classes and running doctests (because there are subtle differences between running doctests with run_doctest() and via DocTestSui

[issue44848] Upgrade macOS and Windows installers to use SQLite 3.36.0

2021-09-17 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Thanks, Steve. I'll pull in main and see how the CI fares. -- ___ Python tracker ___ ___ Pytho

[issue45229] Always use unittest for collecting tests in regrtests

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +26817 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28405 ___ Python tracker ___

[issue45120] Windows cp encodings "UNDEFINED" entries update

2021-09-17 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: Just to be clear: The Python code page encodings are (mostly) taken from the unicode.org set of mappings (ftp://ftp.unicode.org/Public/MAPPINGS/VENDORS/). This is our standards body for such mappings, where possible. In some cases, the Unicode consortium

[issue45229] Always use unittest for collecting tests in regrtests

2021-09-17 Thread Serhiy Storchaka
New submission from Serhiy Storchaka : Currently regrtest supports two ways of collecting and running tests in module. 1. If the module contains the "test_main" function, regrtest just calls it. This function usually calls run_unittest() with a list of test classes, composed manually, it can

[issue45217] ConfigParser does not accept "No value" reversely to the doc

2021-09-17 Thread sbougnoux
sbougnoux added the comment: Thanks for your prompt answer. Don't you think it should be the default? It seems like unneeded precision. Just if you want to check one don't miss a value, but in that case, one can use 'allow_no_value=False'. -- ___

[issue45228] Stack buffer overflow in parsing J1939 network address

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +26816 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28404 ___ Python tracker ___

[issue45228] Stack buffer overflow in parsing J1939 network address

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- versions: +Python 3.10, Python 3.9 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

<    1   2