[issue23224] LZMADecompressor object is only initialized in __init__

2016-12-01 Thread Aaron Hill
Aaron Hill added the comment: I've upload a patch which should address the issue in both the lzma and bz2 modules. -- keywords: +patch nosy: +Aaron1011 Added file: http://bugs.python.org/file45730/fix-lzma-bz2-segfaults.patch ___ Python tr

[issue23247] Crash in the reset() method of StreamWriter of CJK codecs

2015-07-16 Thread Aaron Hill
Aaron Hill added the comment: I've added a test case to exercise reset() -- Added file: http://bugs.python.org/file39934/fix-multibytecodec-segfault-with-test.patch ___ Python tracker <http://bugs.python.org/is

[issue23247] Crash in the reset() method of StreamWriter of CJK codecs

2015-07-15 Thread Aaron Hill
Aaron Hill added the comment: The patch didn't get attached for some reason. It's attached now. -- Added file: http://bugs.python.org/file39933/fix-multibytecodec-segfault.patch ___ Python tracker <http://bugs.python.o

[issue23247] Crash in the reset() method of StreamWriter of CJK codecs

2015-07-15 Thread Aaron Hill
Aaron Hill added the comment: The included patch fixes the issue, and modifies the existing unittest to prevent a future regression. The patch corrects an issue where the 'pending' struct field was NULL, but was used as the input to multibytecodec_en

[issue23247] Multibyte codec StreamWriter.reset() crashes

2015-07-15 Thread Aaron Hill
Aaron Hill added the comment: This is also present in the latest Python 3.6. I'm going to work on providing a patch for this, unless someone else already is -- nosy: +Aaron1011 versions: +Python 3.6 ___ Python tracker <http://bugs.py

[issue23004] mock_open() should allow reading binary data

2014-12-19 Thread Aaron Hill
Aaron Hill added the comment: I've fixed the formatting issues. -- Added file: http://bugs.python.org/file37510/mock-open-allow-binary-data-fix-formatting.patch ___ Python tracker <http://bugs.python.org/is

[issue23004] mock_open() should allow reading binary data

2014-12-15 Thread Aaron Hill
Aaron Hill added the comment: I've fixed the issues you pointed out. Is there a better way than uploading a new patch file to make changes? -- Added file: http://bugs.python.org/file37458/mock-open-allow-binary-without-coerce-fixup.patch ___ P

[issue23004] mock_open() should allow reading binary data

2014-12-14 Thread Aaron Hill
Aaron Hill added the comment: Thanks, I've fixed that. Not sure why I thought decoding and re-encoding would work with any binary data. I've also updated one of the tests to use non-utf8-decodeable binary data, to prevent a future regression. -- Added file: http://bugs.

[issue23004] mock_open() should allow reading binary data

2014-12-13 Thread Aaron Hill
Aaron Hill added the comment: I've created a new patch, which addresses the problem. Your example now currently returns [b'foo\n', b'bar\n'] -- Added file: http://bugs.python.org/file37440/mock-open-allow-binary-data-updated.patch _

[issue23004] mock_open() should allow reading binary data

2014-12-12 Thread Aaron Hill
Aaron Hill added the comment: I've created a patch that fixes this, and added an accompanying unit test (which fails without the change). -- keywords: +patch nosy: +Aaron1011 Added file: http://bugs.python.org/file37435/mock-open-allow-binary-data.

[issue18216] gettext doesn't check MO versions

2014-10-28 Thread Aaron Hill
Aaron Hill added the comment: Awesome! Thanks! -- ___ Python tracker <http://bugs.python.org/issue18216> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18216] gettext doesn't check MO versions

2014-10-25 Thread Aaron Hill
Aaron Hill added the comment: Is there anything that needs to be changed? -- ___ Python tracker <http://bugs.python.org/issue18216> ___ ___ Python-bugs-list mailin

[issue18216] gettext doesn't check MO versions

2014-10-17 Thread Aaron Hill
Aaron Hill added the comment: I've added a second patch, which properly distinguishes between major and minor revisions, and updates the docs to account for the new behavior. -- ___ Python tracker <http://bugs.python.org/is

[issue18216] gettext doesn't check MO versions

2014-10-17 Thread Aaron Hill
Changes by Aaron Hill : Added file: http://bugs.python.org/file36958/gettext-mo-fixup.patch ___ Python tracker <http://bugs.python.org/issue18216> ___ ___ Python-bug

[issue18216] gettext doesn't check MO versions

2014-10-17 Thread Aaron Hill
Changes by Aaron Hill : Removed file: http://bugs.python.org/file36957/gettext-mo-fix-minor-version.patch ___ Python tracker <http://bugs.python.org/issue18216> ___ ___

[issue18216] gettext doesn't check MO versions

2014-10-17 Thread Aaron Hill
Changes by Aaron Hill : Added file: http://bugs.python.org/file36957/gettext-mo-fix-minor-version.patch ___ Python tracker <http://bugs.python.org/issue18216> ___ ___

[issue18216] gettext doesn't check MO versions

2014-10-17 Thread Aaron Hill
Aaron Hill added the comment: Okay, then. I'll just leave it out. -- ___ Python tracker <http://bugs.python.org/issue18216> ___ ___ Python-bugs-list m

[issue18216] gettext doesn't check MO versions

2014-10-17 Thread Aaron Hill
Aaron Hill added the comment: Does anyone have any thoughts about throwing a warning for an unexpected minor revision? -- ___ Python tracker <http://bugs.python.org/issue18

[issue5843] Normalization error in urlunparse

2014-10-09 Thread Aaron Hill
Aaron Hill added the comment: In order to fix this, I think ParseResult needs to have two additional fields, indicating with an empty prefix or query string are used. Both ParseResult.fragment and ParseResult.query omit the leading '#' or '?' from their value. This ma

[issue18216] gettext doesn't check MO versions

2014-10-07 Thread Aaron Hill
Aaron Hill added the comment: That sounds good. Should a warning be thrown for an unexpected minor revision? -- ___ Python tracker <http://bugs.python.org/issue18

[issue18216] gettext doesn't check MO versions

2014-10-06 Thread Aaron Hill
Changes by Aaron Hill : -- keywords: +patch nosy: +Aaron1011 Added file: http://bugs.python.org/file36828/gettext-mo-version.patch ___ Python tracker <http://bugs.python.org/issue18

[issue22037] Poor grammar in asyncio TCP echo client example

2014-07-22 Thread Aaron Hill
New submission from Aaron Hill: The last sentence in the explanation of the TCP echo client currently reads: "At run_until_complete() exit, the loop is no more running, so there is no need to stop the loop in case of an error". The grammar should be improved to something like "