[issue37347] Reference-counting problem in sqlite

2019-06-25 Thread Aleksandr Balezin
Aleksandr Balezin added the comment: I've pushed changes https://github.com/python/cpython/pull/14268/commits/bce7fdc952b14c23821e184e82b3944f6e10aaa9. Could I ask for clarification on callback and Py_DECREF(something)? -- ___ Python tr

[issue37347] Reference-counting problem in sqlite

2019-06-24 Thread Aleksandr Balezin
Aleksandr Balezin added the comment: At my point of view, dererencing from sqlite destructor has next flaws: - relying on external library which can has bugs - using different routine for reference-counting(complicates code) - loosing support for old sqlite version Of cause, if it's nece

[issue37347] Reference-counting problem in sqlite

2019-06-21 Thread Aleksandr Balezin
Aleksandr Balezin added the comment: Because destructor can be registered only for particular functions. For example sqlite3_progress_handler() can't register destructor. -- ___ Python tracker <https://bugs.python.org/is

[issue37347] Reference-counting problem in sqlite

2019-06-20 Thread Aleksandr Balezin
Change by Aleksandr Balezin : -- pull_requests: -14092 ___ Python tracker <https://bugs.python.org/issue37347> ___ ___ Python-bugs-list mailing list Unsub

[issue37347] Reference-counting problem in sqlite

2019-06-20 Thread Aleksandr Balezin
Change by Aleksandr Balezin : -- pull_requests: +14094 pull_request: https://github.com/python/cpython/pull/14268 ___ Python tracker <https://bugs.python.org/issue37

[issue37347] Reference-counting problem in sqlite

2019-06-20 Thread Aleksandr Balezin
Change by Aleksandr Balezin : -- keywords: +patch pull_requests: +14092 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14265 ___ Python tracker <https://bugs.python.org/issu

[issue37347] Reference-counting problem in sqlite

2019-06-20 Thread Aleksandr Balezin
Change by Aleksandr Balezin : Added file: https://bugs.python.org/file48430/bug.py ___ Python tracker <https://bugs.python.org/issue37347> ___ ___ Python-bugs-list mailin

[issue37347] Reference-counting problem in sqlite

2019-06-20 Thread Aleksandr Balezin
New submission from Aleksandr Balezin : There are a couple of bugs in sqlite bindings have been found related to reference-counting. Short info: sqlite connection class uses a dict to keep references to callbacks. This mechanism is not suitable for objects which equals but not the same. con

[issue36613] asyncio._wait() don't remove callback in case of exception

2019-04-12 Thread Aleksandr Balezin
Change by Aleksandr Balezin : -- keywords: +patch pull_requests: +12728 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue36613> ___ _

[issue36613] asyncio._wait() don't remove callback in case of exception

2019-04-12 Thread Aleksandr Balezin
New submission from Aleksandr Balezin : Attached script shows unexpected behavior of the wait() function. The wait_ function adds done callback on every call and removes it only if a waiter is successfully awaited. In case of CancelledError exception during "await waiter", callbacks

[issue20825] containment test for "ip_network in ip_network"

2017-05-23 Thread Aleksandr Balezin
Aleksandr Balezin added the comment: I've reviewed this patch and want to make some advices. - hasattr is unwanted here. There is no any similar usage hasattr in this module. Also before hasattr there is a call of _ipversion method. If other is not instance of BaseNetwork it will

[issue25430] speed up ipaddress __contain__ method

2017-05-23 Thread Aleksandr Balezin
Aleksandr Balezin added the comment: I think this patch can be easily applied. There are no any breaking changes. My colleagues and I assume that ipaddress module would work fast because it is easy to imagine tasks, operate with ton of networks. Also, current comparison implementation works as

[issue25431] implement address in network in ipaddress module

2016-03-28 Thread Aleksandr Balezin
Aleksandr Balezin added the comment: Any news? -- ___ Python tracker <http://bugs.python.org/issue25431> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue25431] implement address in network in ipaddress module

2015-10-17 Thread Aleksandr Balezin
Changes by Aleksandr Balezin : -- versions: +Python 3.4, Python 3.6 ___ Python tracker <http://bugs.python.org/issue25431> ___ ___ Python-bugs-list mailin

[issue25430] speed up ipaddress __contain__ method

2015-10-17 Thread Aleksandr Balezin
Changes by Aleksandr Balezin : -- versions: +Python 3.4, Python 3.6 ___ Python tracker <http://bugs.python.org/issue25430> ___ ___ Python-bugs-list mailin