Anthony Sottile added the comment:
admittedly anecdotal but here's another data point in addition to the profiles
attached
test.test_tokenize suite before:
$ ./python -m test.test_tokenize
Change by Anthony Sottile :
--
keywords: +patch
pull_requests: +23130
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/24311
___
Python tracker
<https://bugs.python.org/issu
Change by Anthony Sottile :
Added file: https://bugs.python.org/file49762/out2.svg
___
Python tracker
<https://bugs.python.org/issue43014>
___
___
Python-bugs-list mailin
Change by Anthony Sottile :
Added file: https://bugs.python.org/file49761/out2.pstats
___
Python tracker
<https://bugs.python.org/issue43014>
___
___
Python-bugs-list m
Change by Anthony Sottile :
Added file: https://bugs.python.org/file49760/out.svg
___
Python tracker
<https://bugs.python.org/issue43014>
___
___
Python-bugs-list mailin
New submission from Anthony Sottile :
I did some profiling (attached a few files here with svgs) of running this
script:
```python
import io
import tokenize
# picked as the second longest file in cpython
with open('Lib/test/test_socket.py', 'rb') as f:
bio = io.BytesIO(f.read())
def
Anthony Sottile added the comment:
should the minimum sphinx version be bumped and/or this reverted:
https://github.com/python/cpython/blob/f7f0ed59bcc41ed20674d4b2aa443d3b79e725f4/Doc/conf.py#L48
this change breaks, for example, sphinx 1.8.5 while building for ubuntu 20.04
The directive
Anthony Sottile added the comment:
by the way, here's a much smaller case which has a similar problem
```
x = (
f" {test(t)}"
)
```
--
___
Python tracker
<https://bugs.python.o
Anthony Sottile added the comment:
I didn't initially, but now I have and it has the same bug in the current
master: 3bf05327c2b25d42b92795d9d280288c22a0963d
--
___
Python tracker
<https://bugs.python.org/issue42
Anthony Sottile added the comment:
+peg parser individuals to nosy
--
nosy: +gvanrossum, lys.nikolaou, pablogsal
___
Python tracker
<https://bugs.python.org/issue42
New submission from Anthony Sottile :
here's a sample file. this is distilled down from an example which broke a
code formatter here: https://github.com/asottile/add-trailing-comma/issues/106
def f():
x = (
'PERL_MM_OPT', (
f'INSTALL-BASE={shlex.quote(venv
Anthony Hodson added the comment:
Resolved by correct initiation of subclass
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Anthony Hodson :
HTMLParser close() does not seem to dispose of previous HTML analyses.
I an sending a simple test to demonstrate this, complete with functions
that are part of a set of testing facilities. The problem is present for more
complex HTML
anthony shaw added the comment:
thanks, it would be great if this were documented in the --help section like
the other options which require a debug build (-X showrefcount)
--
___
Python tracker
<https://bugs.python.org/issue42
New submission from anthony shaw :
I noticed since the new parser implementation, the debug mode in the tokeniser
is no longer working.
This is the case for 3.9.0 and also 3.9.1rc1. Running python3.9 with a simple
application like this:
# Demo application
def my_function():
proceed
Anthony Sottile added the comment:
indeed! that's it -- you learn something every day :)
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Anthony Sottile :
this was originally pointed out in a comment on my youtube video here:
https://youtu.be/Xf_82stIbB8
here's a reproduction:
1. produce 5000 characters of output: python3 -c 'print("a"*5000)'
2. copy that to the clipboard
3. run this: python3
Change by Anthony Sottile :
--
pull_requests: +21718
pull_request: https://github.com/python/cpython/pull/22755
___
Python tracker
<https://bugs.python.org/issue40
Change by Anthony Sottile :
--
pull_requests: +21715
pull_request: https://github.com/python/cpython/pull/22752
___
Python tracker
<https://bugs.python.org/issue40
Anthony Sottile added the comment:
Seems to be due to https://bugs.python.org/issue40187
--
nosy: +Anthony Sottile, serhiy.storchaka
___
Python tracker
<https://bugs.python.org/issue41
Change by anthony shaw :
--
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue41888>
___
___
Python-bugs-list
anthony shaw added the comment:
No, this is intentional. sorry. closing
https://github.com/python/cpython/blob/34cd3e9f6a87f9c50edac893b0d5ae46c4e48ee3/Doc/library/dis.rst#L1194
--
___
Python tracker
<https://bugs.python.org/issue41
anthony shaw added the comment:
Or is this some sort of obscure month python reference!?
--
___
Python tracker
<https://bugs.python.org/issue41888>
___
___
Pytho
New submission from anthony shaw :
I noticed that HAVE_ARGUMENT and STORE_NAME have the same value (90) in
Include/opcode.h in both the source code and in the 2bd31b5f revision
(3.9.0rc2).
This must be creating some weird bugs.
https://github.com/python/cpython/blob
Anthony Sottile added the comment:
(I know this is old and closed but I've just run into the same thing with
pwd.getpwnam in issue41767)
KeyError: "getpwnam(): name not found: 'test'"
would it be possible / make sense to extend `KeyError` with a
named-only-argument which woul
Change by Anthony Sottile :
--
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue41767>
___
___
Python-bugs-list
New submission from Anthony Sottile :
For example:
>>> import pwd
>>> pwd.getpwnam("test")
Traceback (most recent call last):
File "", line 1, in
KeyError: "getpwnam(): name not found: 'test'"
An improvement would be some
Change by Anthony Sottile :
--
nosy: +Anthony Sottile
nosy_count: 3.0 -> 4.0
pull_requests: +20834
pull_request: https://github.com/python/cpython/pull/21100
___
Python tracker
<https://bugs.python.org/issu
Anthony Sottile added the comment:
awesome, I'm going to work through this with someone in my discord as a demo /
mentorship opportunity -- hope that's ok!
--
___
Python tracker
<https://bugs.python.org/issue41
New submission from Anthony Sottile :
C:
https://github.com/python/cpython/blob/8b33961e4bc4020d8b2d5b949ad9d5c669300e89/Modules/_datetimemodule.c#L3183
pure python:
https://github.com/python/cpython/blob/8b33961e4bc4020d8b2d5b949ad9d5c669300e89/Lib/datetime.py#L927
this makes it difficult
Anthony Sottile added the comment:
Łukasz: what would you recommend for downstream packagers?
I have essentially two options (assuming this isn't reverted in cpython master
which I believe makes the most sense since cpython still works fine with older
libmpdec):
- revert this individual
Anthony Sottile added the comment:
> Otherwise, why use the system libmpdec at all and not the version
shipped with Python?
the packages are faithful reproductions of upstream packages, deviating from
those introduces surprises for downstreams
> If I install into a venv, I also don
Anthony Sottile added the comment:
I package pythons for ubuntu:
https://github.com/deadsnakes/python3.9-nightly/actions/runs/151286686
https://github.com/deadsnakes/python3.10-nightly/actions/runs/151287821
--
___
Python tracker
<ht
Anthony Sottile added the comment:
reverting this patch passes all the tests, what's the motivation and why were
there no code reviews for this?
--
___
Python tracker
<https://bugs.python.org/issue40
Anthony Sottile added the comment:
especially this late in the beta period for 3.9 -- it would be unfortunate for
3.10 but it's an explicit break of feature freeze for 3.9
--
___
Python tracker
<https://bugs.python.org/issue40
Anthony Sottile added the comment:
this breaks builds for ubuntu, I'd suggest reverting this (especially because
it appears to build fine without this patch)
2020-06-29T08:52:56.8303672Z x86_64-linux-gnu-gcc -pthread -fPIC -Wdate-time
-D_FORTIFY_SOURCE=2 -Wno-unused-result -Wsign-compare
Anthony Sottile added the comment:
Looking into this, it appears to be due to the default value and not due to the
newline
I've stumbled upon two simplifications to the routines in inspect but not a fix
for this
1. https://github.com/python/cpython/pull/21100
2. https://github.com/python
Change by Anthony Sottile :
--
keywords: +patch
nosy: +Anthony Sottile
nosy_count: 3.0 -> 4.0
pull_requests: +20269
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/21066
___
Python tracker
<https://bugs.p
Change by Anthony Sottile :
--
pull_requests: +20265, 20266
pull_request: https://github.com/python/cpython/pull/21098
___
Python tracker
<https://bugs.python.org/issue31
Change by Anthony Sottile :
--
pull_requests: +20265
pull_request: https://github.com/python/cpython/pull/21098
___
Python tracker
<https://bugs.python.org/issue31
Change by Anthony Sottile :
--
pull_requests: +20265, 20266, 20267
pull_request: https://github.com/python/cpython/pull/21098
___
Python tracker
<https://bugs.python.org/issue31
Change by Anthony Sottile :
--
pull_requests: +20264
pull_request: https://github.com/python/cpython/pull/21097
___
Python tracker
<https://bugs.python.org/issue31
Anthony Sottile added the comment:
This appears to have broken pydoc of the select module, I've attached a patch
$ python3.8 -m pydoc select
Traceback (most recent call last):
File "/usr/lib/python3.8/inspect.py", line 2004, in wrap_value
value = eval(s, module_dict)
File
Change by Anthony Sottile :
--
nosy: +Anthony Sottile
nosy_count: 4.0 -> 5.0
pull_requests: +20235
pull_request: https://github.com/python/cpython/pull/21066
___
Python tracker
<https://bugs.python.org/issu
Anthony Sottile added the comment:
pre-commit uses this to do deterministic shuffling, please don't remove this
https://github.com/pre-commit/pre-commit/issues/1479
--
nosy: +Anthony Sottile
___
Python tracker
<https://bugs.python.org/issue40
Anthony Sottile added the comment:
There's current expectation in a lot of linters / code formatters that the
*lineno and *col_offset attributes will be missing if they are not attached to
the node
setting them to None is going to break a lot of those, if possible I'd suggest
going back
Anthony Sottile added the comment:
via
https://github.com/python/cpython/commit/b4d4aef8433da2657c8d80207686124d15d32054
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/i
Change by anthony shaw :
--
nosy: +anthonypjshaw
nosy_count: 4.0 -> 5.0
pull_requests: +19480
pull_request: https://github.com/python/cpython/pull/17753
___
Python tracker
<https://bugs.python.org/issu
Anthony Sottile added the comment:
@serhiy: this was pretty straightfowrard to fix as you suspected -- would you
be able to review it?
--
___
Python tracker
<https://bugs.python.org/issue40
Anthony Sottile added the comment:
fwiw virtualenv 20.x uses `.pth` now as well to fix some issues with
`venv`-based environments
--
___
Python tracker
<https://bugs.python.org/issue33
Anthony Sottile added the comment:
one way might be to give the groups "unique" names (perhaps hashing the input
string?) ((this is what I attempted to do in a little bit of code which tried
to "backport" (group)*+ and (group)++))
--
no
New submission from Anthony Sottile :
```console
$ ln -s 'import os; os.system("echo hi")' __main__.py
$ ls -al
total 8
drwxr-xr-x 2 asottile asottile 4096 May 5 15:55 .
drwxr-xr-x 3 asottile asottile 4096 May 5 14:50 ..
lrwxrwxrwx 1 asottile asottile 31 May 5 15:55 __main__.py
Change by Anthony Sottile :
--
keywords: +patch
pull_requests: +19225
pull_request: https://github.com/python/cpython/pull/19910
___
Python tracker
<https://bugs.python.org/issue40
New submission from Anthony Sottile :
just spent quite a bit of time debugging this, here's a minimal example:
```bash
# rm -rf a (if you want to reset)
cd /tmp
mkdir -p a/b
echo 'import os; os.chdir("..")' > a/b/c.py
cd a/b
python3 -m cProfile -o log.pstats c.py
ls -al
ls -al ..
Change by anthony shaw :
--
keywords: +patch
pull_requests: +19202
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/19891
___
Python tracker
<https://bugs.python.org/issu
New submission from anthony shaw :
the tools/peg_generator package contains a number of unused imports
--
components: Interpreter Core
messages: 368005
nosy: anthonypjshaw, pablogsal
priority: normal
severity: normal
stage: needs patch
status: open
title: peg_generator module has
Change by anthony shaw :
--
keywords: +patch
pull_requests: +19108
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/19785
___
Python tracker
<https://bugs.python.org/issu
New submission from anthony shaw :
The additional tasks in the MSBuild project for pegen regeneration are not
functional:
- Setting PYTHONPATH= inline cannot be done in Windows using that method
- The task does not inherit environment variables that way
- The path to the peg_generator module
New submission from Anthony Sottile :
unclear if this is intentional or not, I noticed this while seeing that
`ast.Subscript.slice` is no longer `Index` / `Slice` / `ExtSlice`
# python3.8
>>> isinstance(ast.Slice(), ast.slice)
True
# python3.9a6
>>> isinstance(ast.Slice()
Anthony Sottile added the comment:
cool, reported there as well!
--
___
Python tracker
<https://bugs.python.org/issue40335>
___
___
Python-bugs-list mailin
Anthony Sottile added the comment:
:waves: -- seeing a lot of failures in pyflakes' testsuite around SyntaxErrors
https://github.com/PyCQA/pyflakes/pull/532
(you can reproduce with `path/to/python -m unittest discover pyflakes` without
needing any dependencies installed)
--
nosy
Anthony Sottile added the comment:
pyflakes's testsuite has many failures under the new parser -- is the
expectation that those will be fixed by 3.9 final?
--
___
Python tracker
<https://bugs.python.org/issue40
Anthony Sottile added the comment:
I would really like to be able to trigger all warnings consistently and
statically without executing the code.
This is useful (for instance) for this simple script which validates the ast:
https://github.com/pre-commit/pre-commit-hooks/blob/master
Anthony Sottile added the comment:
This seems to have regressed again
$ ./python --version --version
Python 3.9.0a5+ (heads/master:503de7149d, Apr 24 2020, 13:34:49)
[GCC 7.5.0]
$ ./python t.py
File "/home/asottile/workspace/cpython/t.py&quo
New submission from Anthony Sottile :
compare the following:
```
if False: 'foo'(1)
```
$ python3.9
Python 3.9.0a5 (default, Mar 23 2020, 23:11:30)
[GCC 7.5.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>
Anthony Sottile added the comment:
The trailing newline was added in 1.5.1
78fc3634cbfd65a6be8abfd1b7fc7cbd0ccbfb39 -- back then `compile(...)` could not
take strings which did not end in newlines
now it can, so it is safe to remove -- I did the same triage on another PR
here: https
Anthony Sottile added the comment:
debian has its own implementation of find_modules which still returns a text
file for PY_SOURCE
changing the type of that io object is the "breaking change" and maybe
shouldn't be backported to python3.8 in a pat
Anthony Sottile added the comment:
actually I said that backwards in the previous message -- it was a text file
and now it's a binary file
--
___
Python tracker
<https://bugs.python.org/issue40
Change by Anthony Sottile :
--
pull_requests: +18965
pull_request: https://github.com/python/cpython/pull/19641
___
Python tracker
<https://bugs.python.org/issue40
Anthony Sottile added the comment:
The failure above is `fp` is now a text file but before it was a binary file.
this causes `fp.read()` + `b'\n'` to fail
I can send a patch -- I don't think the `b'\n'` is necessary any more (as far
as I can tell it used to be there for an old version
Anthony Sottile added the comment:
This is still failing, but now in a different way:
Traceback (most recent call last):
File "../debian/pymindeps.py", line 185, in
main(sys.argv[1:])
File "../debian/pymindeps.py", line 178, in main
mf.run_script(arg)
Change by Anthony Sottile :
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.org/issue40335>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Anthony Sottile :
this was noticed in pyflakes's testsuite:
https://github.com/PyCQA/pyflakes/pull/532#pullrequestreview-396059622
I've created a small script to reproduce the problem
```
import sys
SRC = b"""\
def foo():
'''
def bar():
Anthony Sottile added the comment:
(additionally, I'm not sure this should be backported to python3.8, especially
with changed behaviour)
--
___
Python tracker
<https://bugs.python.org/issue40
Anthony Sottile added the comment:
I'm admittedly a little unfamiliar with what it does as well -- I'm mostly
repackaging debian sources for deadsnakes. If I'm correct in my assumption, it
is attempting to find a minimal set of modules to package into
`python3-minimal` and ensure
Anthony Sottile added the comment:
This patch has broken debian's builds due to use of modulefinder -- notably the
type of `file_info` changed as a side-effect of this patch and is now causing:
../debian/pymindeps.py:29: DeprecationWarning: the imp module is deprecated in
favour
Anthony Sottile added the comment:
this is still broken even with the latest patch:
https://bugs.python.org/issue40266
--
nosy: +Anthony Sottile
___
Python tracker
<https://bugs.python.org/issue39
Anthony Sottile added the comment:
yes, it is still broken, now with fewer errors:
2020-04-13T15:06:34.7330649Z x86_64-linux-gnu-gcc -pthread -fPIC -Wdate-time
-D_FORTIFY_SOURCE=2 -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3
-Wall -g -fstack-protector -Wformat -Werror=format
New submission from Anthony Sottile :
Haven't yet bisected, but noticed this in the nightly builds I provide for
ubuntu deadsnakes https://github.com/deadsnakes/nightly -- I believe it to be
this patch so I've added to nosy: https://github.com/python/cpython/pull/19082
Both python3.8
Change by Anthony Sottile :
--
nosy: +Anthony Sottile
nosy_count: 6.0 -> 7.0
pull_requests: +18644
pull_request: https://github.com/python/cpython/pull/10021
___
Python tracker
<https://bugs.python.org/issu
Anthony Sottile added the comment:
you are right though, the effect is the same as just using mkdtemp
--
___
Python tracker
<https://bugs.python.org/issue25
Anthony Sottile added the comment:
the differences are api compatibility with context manager protocol and
equivalence with NamedTemporaryFile
NamedTemporaryFile(delete=False) is just `mkstemp` afaict and the api is there
--
___
Python tracker
Anthony Sottile added the comment:
Serhiy's comment provides workarounds but are still (imo) inferior to
supporting this.
I would really like for this api to match that of NamedTemporaryFile which has
the same `delete=...` option
--
___
Python
Anthony Sottile added the comment:
fwiw, astpretty's output looks like the black output:
https://github.com/asottile/astpretty
>>> astpretty.pprint(ast.parse('if x == y: y += 4').body[0])
If(
lineno=1,
col_offset=0,
test=Compare(
lineno=1,
col
Anthony Sottile added the comment:
oh! that's neat, yeah hadn't been following closely enough it seems, good to
hear that the readonly thing is fixed!
--
___
Python tracker
<https://bugs.python.org/issue25
Anthony Sottile added the comment:
one example is here:
https://github.com/pre-commit/pre-commit/blob/bb6f1efe63c168d9393d520bd60e16c991a57059/pre_commit/store.py#L137-L139
where I would want cleanup in the exceptional case
another (related but different) closed-source use case involves
Change by Anthony Sottile :
--
keywords: +patch
pull_requests: +18379
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/19030
___
Python tracker
<https://bugs.python.org/issu
Change by Anthony Sottile :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Anthony Sottile :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Anthony Sottile :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Anthony Sottile added the comment:
I would certainly like to see this, it would eliminate my last few hand rolled
temporary directory contexts
Mauro would you be interested in re-posting this patch as a PR to github? (or
allowing someone else to carry your patch forward?)
--
nosy
Anthony Sottile added the comment:
hit this today unfortunately -- I'm working with some pretty complex (and
nested) `typing.NamedTuple` objects and the lack of caching here results in
quite the slowdown (in my macro benchmarks it's the difference between a render
pass taking 180ms and 25ms
New submission from Anthony Sottile :
This is distilled from a larger example to be small/silly, however this caused
real problems
A script which was intended for python3.6 exactly was written as follows:
```
#!/usr/bin/env python3.6
...
```
when creating a virtualenv with `python3.6 -m
Anthony Tuininga added the comment:
Any progress on this?
--
___
Python tracker
<https://bugs.python.org/issue30155>
___
___
Python-bugs-list mailing list
Unsub
Anthony Wee added the comment:
> Thanks Anthony for the report! I included your name as the reporter, though I
> don't see it on any of the pages.
No problem! Thanks Steve, Eryk, and Victor for jumping on this!
--
___
Python tracker
Change by anthony shaw :
--
keywords: +patch
pull_requests: +17647
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/18272
___
Python tracker
<https://bugs.python.org/issu
New submission from anthony shaw :
Within the documentation, there are some really important security
considerations for standard library modules. e.g. subprocess, ssl, pickle, xml.
There is currently no "index" of these, so you have to go hunting for them.
They're easter e
Anthony Sottile added the comment:
sure, it's the standard PATHEXT (basically a fresh vm from modern.ie) -- the
only reason I noticed this is I was reading the source:
https://github.com/python/cpython/blob/5bbac8cbdf140ebce446ea4e7db2b20a5d7b8402/Lib/shutil.py#L1367-L1373
C:\Users\IEUser
Anthony Sottile added the comment:
should I open a new issue for this, or is this an appropriate task to add to
this discussion
shutil.which also doesn't apply `PATHEXT` when the path contains a directory
separator
C:\Users\IEUser\astpretty>venv\Scripts\python --version
Python 3.7.5
New submission from Anthony Wee :
On Win7, running Python in the terminal will attempt to load the
"api-ms-win-core-path-l1-1-0.dll" from various paths outside of the Python
directory and the C:\Windows\System32 directories. This behavior can be
verified using Process Monitor (see
101 - 200 of 734 matches
Mail list logo
