[issue19307] Improve TypeError message in json.loads()

2013-10-20 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker <http://bugs.python.org/issue19307> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue17759] test_urllibnet.test_bad_address() fails on Ubuntu 13.04

2013-10-18 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- resolution: -> invalid status: open -> closed ___ Python tracker <http://bugs.python.org/issue17759> ___ ___ Python-bugs-

[issue17759] test_urllibnet.test_bad_address() fails on Ubuntu 13.04

2013-10-18 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: I'm going to close this as invalid: Python 3.3.2+ (3.3:247344a0d12e, Oct 18 2013, 13:14:59) [GCC 4.8.1] on linux Type "help", "copyright", "credits" or "license" for more information. >>> from socket i

[issue16662] load_tests not invoked in package/__init__.py

2013-10-18 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On the second failure, the expected output just needs to be updated. Is that the right thing to do? -- ___ Python tracker <http://bugs.python.org/issue16

[issue16662] load_tests not invoked in package/__init__.py

2013-10-18 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: The failure in test_discovery.py is odd. It's failing because loadTestsFromModule() is being passed a keyword arguemnt use_load_tests=False. On the surface, the failure makes sense because if you look in test_discover.py, it's defining a

[issue19279] UTF-7 to UTF-8 decoding crash

2013-10-18 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- versions: -Python 2.6 ___ Python tracker <http://bugs.python.org/issue19279> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19279] UTF-7 to UTF-8 decoding crash

2013-10-18 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Oct 18, 2013, at 02:33 PM, Barry A. Warsaw wrote: >2.6.9 doesn't produce a SystemError afaict: Please note that 2.6.9 is security only, so the threshold for worrying about things is a remotely exploitable security vulnerability that cannot be re

[issue19279] UTF-7 to UTF-8 decoding crash

2013-10-18 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: 2.6.9 doesn't produce a SystemError afaict: Python 2.6.9rc1+ (unknown, Oct 18 2013, 10:29:22) [GCC 4.4.3] on linux3 Type "help", "copyright", "credits" or "license" for more information. >>> content = b&#

[issue13146] Writing a pyc file is not atomic

2013-10-17 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Aug 15, 2013, at 08:25 PM, Antoine Pitrou wrote: >Barry, do you still want to keep this issue open? I don't necessarily need to. We've patched the Ubuntu version to be safe, so I guess we'll just carry that del

[issue19266] Rename contextlib.ignore to contextlib.suppress

2013-10-15 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker <http://bugs.python.org/issue19266> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19232] Speed up _decimal import

2013-10-12 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker <http://bugs.python.org/issue19232> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19218] Use of MutableMapping in os module slows down interpreter startup

2013-10-10 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker <http://bugs.python.org/issue19218> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19216] stat cache for import bootstrap

2013-10-10 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker <http://bugs.python.org/issue19216> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue9548] locale can be imported at startup but relies on too many library modules

2013-10-09 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker <http://bugs.python.org/issue9548> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19209] Remove import copyreg from os module

2013-10-09 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker <http://bugs.python.org/issue19209> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19205] Don't import re and sysconfig in site.py

2013-10-09 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker <http://bugs.python.org/issue19205> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16040] nntplib: unlimited readline() from connection

2013-10-01 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Oct 01, 2013, at 01:44 PM, Arfrever Frehtes Taifersar Arahesis wrote: >s/lenght/length/ in new comment in Lib/nntplib.py Fixed, thanks. -- ___ Python tracker <http://bugs.python.org/issu

[issue16040] nntplib: unlimited readline() from connection

2013-09-30 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- versions: -Python 2.6 ___ Python tracker <http://bugs.python.org/issue16040> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16040] nntplib: unlimited readline() from connection

2013-09-30 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- versions: -Python 2.7 ___ Python tracker <http://bugs.python.org/issue16040> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16040] nntplib: unlimited readline() from connection

2013-09-30 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Sep 30, 2013, at 09:43 PM, Jyrki Pulliainen wrote: >I also wonder if there should be data error risen instead? Current docstrings >of the errors are not that well fit. I guess a data error makes the least nonsense here, so I'll change it over to

[issue16040] nntplib: unlimited readline() from connection

2013-09-30 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Looks great, thanks! I'll apply this to 2.6.9 but let others forward port it to 2.7. -- ___ Python tracker <http://bugs.python.org/is

[issue16041] poplib: unlimited readline() from connection

2013-09-30 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Sep 30, 2013, at 08:41 PM, Arfrever Frehtes Taifersar Arahesis wrote: > >Arfrever Frehtes Taifersar Arahesis added the comment: > >> New changeset 7214e3324a45 by Barry Warsaw in branch '2.6': >> - Issue #16041: CVE-2013-1

[issue16041] poplib: unlimited readline() from connection

2013-09-30 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- versions: -Python 2.6 ___ Python tracker <http://bugs.python.org/issue16041> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16041] poplib: unlimited readline() from connection

2013-09-29 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Looks good, although only the POP3 exception is actually tested. The POP3_SSL exception isn't tested. Any chance you could add a test for that (obviously, only if `import ssl` succeeds)? -- ___ Python tr

[issue16037] httplib: header parsing is not unlimited

2013-09-29 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Thanks! -- versions: -Python 2.6 ___ Python tracker <http://bugs.python.org/issue16037> ___ ___ Python-bugs-list mailin

[issue16037] httplib: header parsing is not unlimited

2013-09-29 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: I'm just going to go ahead and commit this patch to 2.6 with the change I mentioned. Does anything else need to be done for 2.6? -- ___ Python tracker <http://bugs.python.org/is

[issue16037] httplib: header parsing is not unlimited

2013-09-29 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: As we discussed in other issues regarding the similar problem, I don't really want to introduce a new exception in a point release of 2.6. Is there any reason not to just raise HTTPException with the error message text? Code that has to work a

[issue19092] ExitStack.__exit__ incorrectly suppresses exceptions in __exit__ callbacks of inner context managers

2013-09-25 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker <http://bugs.python.org/issue19092> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16038] ftplib: unlimited readline() from connection

2013-09-25 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- versions: -Python 2.6 ___ Python tracker <http://bugs.python.org/issue16038> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16038] ftplib: unlimited readline() from connection

2013-09-24 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Sep 24, 2013, at 09:59 PM, Serhiy Storchaka wrote: >Added file: http://bugs.python.org/file31862/ftplib_maxline.patch This looks great and fixes the test failure problem. Thanks! Serhiy, please feel free to apply this to the 2.6 branch, or let me know

[issue19084] No way to use TLS-PSK from python ssl

2013-09-24 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker <http://bugs.python.org/issue19084> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16038] ftplib: unlimited readline() from connection

2013-09-24 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Sep 24, 2013, at 01:12 PM, Giampaolo Rodola' wrote: >Giampaolo Rodola' added the comment: > >I believe the problem is the set of next_retr_data attribute here: > >def test_retrlines_too_long(self): >self.server

[issue16038] ftplib: unlimited readline() from connection

2013-09-23 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Sep 23, 2013, at 06:33 PM, Giampaolo Rodola' wrote: >Barry can you paste the traceback caused by the race condition? What's not >clear to me is when (what line) it occurs. One solution might be to send a >"NOOP" command (se

[issue16038] ftplib: unlimited readline() from connection

2013-09-23 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Sep 23, 2013, at 03:36 PM, Serhiy Storchaka wrote: >What about time.sleep(0.1)? I usually don't like introducing sleeps to fix race conditions, but if that's the only option for landing this patch, maybe we'll have to hold o

[issue16042] smtplib: unlimited readline() from connection

2013-09-22 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Please don't add 2.6 back to the Versions, unless there's actually something to do for 2.6. AFAIK, this issue is resolved for 2.6. -- versions: -Python 2.6 ___ Python tracker <http://bugs.python.o

[issue16039] imaplib: unlimited readline() from connection

2013-09-22 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Since the merge 2.6 -> 2.7 did not apply cleanly, and had other problems. I null merged the 2.6 changes. I'll leave it to Benjamin to work out whatever patches 2.7 needs. -- versions: -Python 2.6 __

[issue16039] imaplib: unlimited readline() from connection

2013-09-22 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Looks good for 2.6. The NEWS file hunk doesn't apply, but I'll fix that when I commit this to 2.6. -- ___ Python tracker <http://bugs.python.o

[issue16038] ftplib: unlimited readline() from connection

2013-09-22 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Okay, this one is quite odd. It's definitely a timing issue. If I put a `import time; time.sleep(1)` at the beginning of test_retrlines_too_line() -- i.e. first line of the method -- then the test reliably passes. If I put a `print(len(line))` just b

[issue19043] Remove detailed listing of all versions from LICENSE, Doc/license.rst

2013-09-18 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker <http://bugs.python.org/issue19043> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16038] ftplib: unlimited readline() from connection

2013-09-16 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Succeeds on OS X 10.8 (although there are other failures) -- ___ Python tracker <http://bugs.python.org/issue16038> ___ ___

[issue16038] ftplib: unlimited readline() from connection

2013-09-16 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Yep, confirmed that ftplib.patch causes test_ftplib to fail, at least on Ubuntu 10.04 chroot. -- ___ Python tracker <http://bugs.python.org/issue16

[issue14984] netrc module allows read of non-secured .netrc file

2013-09-16 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Sep 16, 2013, at 03:12 PM, R. David Murray wrote: >Well, I was planning to merge it, since 2.7 needs the fix as well. Oh yeah, that's fine of course. And thanks! -- ___ Python tracker <http://bugs

[issue14984] netrc module allows read of non-secured .netrc file

2013-09-16 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: @RDM: Please commit to 2.6 and null merge to 2.7. Thanks! -- ___ Python tracker <http://bugs.python.org/issue14984> ___ ___

[issue14984] netrc module allows read of non-secured .netrc file

2013-09-15 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: @RDM: In netrc.rst, s/posix/POSIX/ It also looks like you're keeping the ownership test. Did I misunderstand msg197815? I thought you were only going to keep the permission test? -- ___ Python tracker

[issue16038] ftplib: unlimited readline() from connection

2013-09-15 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: == FAIL: test_retrlines_too_long (__main__.TestFTPClass) -- Traceback (most recent call last): File "Lib

[issue14984] netrc module allows read of non-secured .netrc file

2013-09-15 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: FWIW, the Ubuntu manpage netrc(5) says: password string Supply a password. If this token is present, the auto-login process will supply the specified string if the remote server requires a password as part of

[issue18747] Re-seed OpenSSL's PRNG after fork

2013-09-15 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: After further contemplation and without objection from __ap__ and Crys on IRC, I am de-targeting this for 2.6. I won't apply it for 2.6.9. -- versions: -Python 2.6 ___ Python tracker <http://bugs.py

[issue14984] netrc module allows read of non-secured .netrc file

2013-09-15 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Sep 15, 2013, at 06:51 PM, R. David Murray wrote: >I could write a 2.6 test for the permissions part, but not for the incorrect >owner part. Do you want one without the other? Yeah, I guess you can't mock os or stat in 2.6. ;) Let's tes

[issue16042] smtplib: unlimited readline() from connection

2013-09-15 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Sep 15, 2013, at 05:34 PM, Serhiy Storchaka wrote: >Oh, right. The correct code should be as I proposed in msg173413 or... as >Andrew has committed. Good. Excellent. So we're good for this in 2

[issue14984] netrc module allows read of non-secured .netrc file

2013-09-15 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +benjamin.peterson, georg.brandl, larry priority: high -> release blocker ___ Python tracker <http://bugs.python.org/issu

[issue14984] netrc module allows read of non-secured .netrc file

2013-09-15 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Sep 15, 2013, at 06:05 PM, R. David Murray wrote: >For the security fix, the check should only be done if the file is the the >default .netrc. (Which would also make your error message >correct...otherwise it is not :) Also, it would make more

[issue18709] SSL module fails to handle NULL bytes inside subjectAltNames general names (CVE-2013-4238)

2013-09-15 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: I'm removing 2.6 from the Versions field since AFAIK we've resolved this issue for 2.6. This way it'll be easier to scan the blockers for 2.6.9. If anyone things we still have things to address for this issue in 2.6.9, please reassign

[issue16042] smtplib: unlimited readline() from connection

2013-09-15 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Sep 15, 2013, at 04:47 PM, Serhiy Storchaka wrote: >It is not important in the context of this issue, but readline(0) is blocked >and returns 1-character string. Move the length check above >self.sslobj.read(1). For readability you can also mov

[issue16042] smtplib: unlimited readline() from connection

2013-09-15 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Patch looks great, thanks Andrew. All tests pass. Feel free to commit to the 2.6 branch along with a NEWS file entry. -- ___ Python tracker <http://bugs.python.org/issue16

[issue19025] Deleting attribute of Enum gives misleading error message

2013-09-15 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker <http://bugs.python.org/issue19025> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16040] nntplib: unlimited readline() from connection

2013-09-15 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Any more thoughts on this bug w.r.t. 2.6.9? It seems that without a patch for any version of Python, and with 2.6.9 coming soon, a fix for this just won't make it into 2.6.9. That doesn't bother me too much, and I'm willing to just kno

[issue16043] xmlrpc: gzip_decode has unlimited read()

2013-09-15 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- versions: -Python 2.6 ___ Python tracker <http://bugs.python.org/issue16043> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue15873] datetime: add ability to parse RFC 3339 dates and times

2013-09-11 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker <http://bugs.python.org/issue15873> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18924] Enum members are easily replaced

2013-09-04 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Sep 04, 2013, at 08:18 PM, Eli Bendersky wrote: >[Barry, how come your name in the tracker is linked to your website? me >wants...] Go to "Your Details" in the left sidebar and enter a "Homepage". --

[issue18924] Enum members are easily replaced

2013-09-04 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Sep 04, 2013, at 07:47 PM, Ethan Furman wrote: >I'm pretty sure we don't want that. Agreed, although a "we're all consenting adults" argument could be made. -- ___ Python trac

[issue16037] httplib: header parsing is not delimited

2013-09-03 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: blocker for 2.6.9 -- priority: critical -> release blocker ___ Python tracker <http://bugs.python.org/issue16037> ___ ___ Py

[issue16042] smtplib: unlimited readline() from connection

2013-09-03 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: blocker for 2.6.9 -- priority: critical -> release blocker ___ Python tracker <http://bugs.python.org/issue16042> ___ ___ Py

[issue16043] xmlrpc: gzip_decode has unlimited read()

2013-09-03 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: blocker for 2.6.9 -- priority: critical -> release blocker ___ Python tracker <http://bugs.python.org/issue16043> ___ ___ Py

[issue16038] ftplib: unlimited readline() from connection

2013-09-03 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: blocker for 2.6.9 -- nosy: +barry priority: critical -> release blocker ___ Python tracker <http://bugs.python.org/issu

[issue16040] nntplib: unlimited readline() from connection

2013-09-03 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: blocker for 2.6.9 -- nosy: +barry priority: critical -> release blocker ___ Python tracker <http://bugs.python.org/issu

[issue18747] Re-seed OpenSSL's PRNG after fork

2013-09-03 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: blocker for 2.6.9 -- nosy: +larry priority: normal -> release blocker ___ Python tracker <http://bugs.python.org/issu

[issue16039] imaplib: unlimited readline() from connection

2013-09-03 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: blocker for 2.6.9 -- nosy: +barry priority: critical -> release blocker ___ Python tracker <http://bugs.python.org/issu

[issue18891] Master patch for content manager addtion to email package.

2013-09-03 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Sep 03, 2013, at 07:37 AM, Stephen J. Turnbull wrote: >I'm thinking this may be overengineering, but I may as well post it and find >out for sure. :-) Is it worth encapsulating MIME types? They're "really" >pairs as far as m

[issue18747] Re-seed OpenSSL's PRNG after fork

2013-08-22 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Aug 21, 2013, at 11:49 AM, Christian Heimes wrote: >I have taken care of Antoine's and Victor's reviews. The fix has landed in >Python 2.7, 3.3 and 3.4. What about 2.6, 3.1 and 3.2? After all it's a >security fix (although I don&#x

[issue16248] Security bug in tkinter allows for untrusted, arbitrary code execution.

2013-08-20 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- versions: -Python 2.6 ___ Python tracker <http://bugs.python.org/issue16248> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16248] Security bug in tkinter allows for untrusted, arbitrary code execution.

2013-08-20 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Applied the fix to 2.6 and null merged into 2.7. This didn't need a NEWS entry because the regression hadn't been released yet. I'll remove 2.6 from the Versions now. -- ___ Python

[issue18677] Enhanced context managers with ContextManagerExit and None

2013-08-12 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker <http://bugs.python.org/issue18677> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue17997] ssl.match_hostname(): sub string wildcard should not match IDNA prefix

2013-08-12 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker <http://bugs.python.org/issue17997> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18709] SSL module fails to handle NULL bytes inside subjectAltNames general names (CVE-2013-4073)

2013-08-12 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker <http://bugs.python.org/issue18709> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18472] Update PEP 8 to encourage modern conventions

2013-08-01 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Aug 01, 2013, at 12:19 PM, Nick Coghlan wrote: >I *didn't* make any changes in relation to Barry's comment about having the >commentary intermixed with the guidelines. I quite like the notion of >stripping PEP 8 down to just the essent

[issue16662] load_tests not invoked in package/__init__.py

2013-07-31 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Seems like this patch does the trick for my very limited testing. -- keywords: +patch Added file: http://bugs.python.org/file31102/16662.diff ___ Python tracker <http://bugs.python.org/issue16

[issue16662] load_tests not invoked in package/__init__.py

2013-07-31 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Hah, I just ran into this too. I was perplexed why my load_tests() function wasn't being called and ended up pdb'ing unittest's discover, and found exactly this problem. I'm not surprised lifeless beat me to it. (My use case was to pig

[issue18472] Update PEP 8 to encourage modern conventions

2013-07-29 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Jul 28, 2013, at 04:59 AM, Raymond Hettinger wrote: >- Regarding line length, I think it is reasonable to mention that many >organizations are settling on 100 as a compromise. On newer laptops you >can still fit two terminal windows (with a reason

[issue18472] Update PEP 8 to encourage modern conventions

2013-07-29 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Jul 28, 2013, at 09:48 PM, Nick Coghlan wrote: > >Nick Coghlan added the comment: > >"with statements are good", basically. `with ExitStack() as stack` is even better :) -- ___

[issue18472] Update PEP 8 to encourage modern conventions

2013-07-29 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Jul 27, 2013, at 03:13 PM, Guido van Rossum wrote: >- I think we should recommend against tabs outright. They are getting more >- and more misunderstood. +1 >- Regarding line length, I think it is reasonable to mention that many >- organ

[issue18472] Update PEP 8 to encourage modern conventions

2013-07-29 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Comments on the diff. > -Two good reasons to break a particular rule: > +Some especially good reasons to ignore a particular guideline: It's probably enough to just s/Two/Some/ - not sure the 'especially' emphasis is really needed. >

[issue18585] Add a text truncation function

2013-07-29 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Jul 29, 2013, at 01:55 PM, Antoine Pitrou wrote: >Perhaps the "placeholder" argument should actually include the last >whitespace, to allow people to omit the whitespace, or use a non-breaking >space instead? > > >>>

[issue15805] Add stdout redirection tool to contextlib

2013-07-23 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Jul 23, 2013, at 04:24 AM, Alexander Belopolsky wrote: >@contextlib.contextmanager >def redirect_stdout(stream): >old_stdout = sys.stdout >sys.stdout = stream >yield >sys.stdout = old_stdout Make that: @contextlib.

[issue18531] Undocumented different between METH_KEYWORDS and **kws

2013-07-22 Thread Barry A. Warsaw
New submission from Barry A. Warsaw: A colleague discovered an interesting implementation different between C-defined functions and Python-defined functions called with **kws arguments. He tried to do this: >>> from collections import defaultdict >>> '{foo}{bar}&#x

[issue15805] Add stdout redirection tool to contextlib

2013-07-22 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: In general, I like where this is going. I agree that a stdout redirector is probably the most common case, and for that, it almost always (for me) redirects to an open file. The use case for stderr redirection is usually, but not always, to redirect stderr to

[issue18510] if Enum member value is not hashable an exception is raised

2013-07-19 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker <http://bugs.python.org/issue18510> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue10434] Document the rules for "public names"

2013-07-16 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker <http://bugs.python.org/issue10434> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18472] PEP 8 updates - internal interfaces and import *

2013-07-16 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker <http://bugs.python.org/issue18472> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18440] hash() and __hash__() do not document their size constraints

2013-07-15 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/issue18440> ___ ___ Python-bugs-list

[issue18440] hash() and __hash__() do not document their size constraints

2013-07-15 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- versions: -Python 3.2 ___ Python tracker <http://bugs.python.org/issue18440> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18440] hash() and __hash__() do not document their size constraints

2013-07-13 Thread Barry A. Warsaw
New submission from Barry A. Warsaw: If you have a custom object that implements __hash__() and it returns a value wider than Py_ssize_t, built-in hash() on the object will truncate information. This is because hash() takes the value returned by obj.__hash__() and coerces it through

[issue18417] urlopen() has a hidden default for its timeout argument

2013-07-10 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Jul 10, 2013, at 05:53 AM, R. David Murray wrote: >Please see issue 14425 and then let us know if this is still valid. It's >been a while since I looked at the code and I no longer remember the details, >but I seemed confident in my conclusi

[issue18422] is_package missing so can't use -m

2013-07-10 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker <http://bugs.python.org/issue18422> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18417] urlopen() has a hidden default for its timeout argument

2013-07-09 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Targeting only 3.4 because, while this should no break any (reasonable ) backward compatibility, it is technically an API change and thus should not get backported. -- ___ Python tracker <http://bugs.python.

[issue18417] urlopen() has a hidden default for its timeout argument

2013-07-09 Thread Barry A. Warsaw
New submission from Barry A. Warsaw: urllib.request.urlopen() takes a `timeout` argument with a default value, but the default value is "hidden" and undocumented. As implemented, the value is socket._GLOBAL_DEFAULT_TIMEOUT, but even this isn't really correct or useful. The p

[issue18412] Minor problem in PEP 8

2013-07-09 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: I clarified the wording. -- nosy: +barry resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/i

[issue13655] Python SSL stack doesn't have a default CA Store

2013-07-08 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Jul 08, 2013, at 11:56 AM, Antoine Pitrou wrote: >I don't think it's a good idea to maintain a list of hard-coded >paths in Python: it's not manageable, and it will always become >outdated. If there was a widely-respected stand

[issue18394] cgi.FieldStorage triggers ResourceWarning sometimes

2013-07-07 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker <http://bugs.python.org/issue18394> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18395] Make _Py_char2wchar() and _Py_wchar2char() public

2013-07-07 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker <http://bugs.python.org/issue18395> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue15767] add ModuleNotFoundError

2013-07-02 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Jul 02, 2013, at 07:16 AM, Serhiy Storchaka wrote: >If most user code should catch a ModuleNotFoundError exception, perhaps it >will be better rename old ImportError to ImportlibError (or ImportingError, >or ImportMachineryError, or BaseImportError

<    7   8   9   10   11   12   13   14   15   16   >