New submission from Bill Parker:
In reviewing calls to strcpy(string, ), I found three instances which could
be re-written as *string = '\0'; which would save the minor overhead of a
function call. The patch file is below:
--- install.c.orig 2015-05-20 14:11:27.723397005 -0700
Bill Parker added the comment:
At the moment, I'm not sure if it's needed or not, but if it's only an
issue with XP, then it might not be worth fixing...:)
On Thu, Apr 9, 2015 at 1:35 PM, STINNER Victor rep...@bugs.python.org
wrote:
STINNER Victor added the comment:
/* Win9x appears
Bill Parker added the comment:
Per Ned Deily, I did send 'ffi.c.patch' to the guys upstream at:
https://sourceware.org/libffi/
So hopefully they can review and fix it in the next release :)...
Given that Python is spread out, perhaps when a component is selected, it could
display source
Bill Parker added the comment:
In directory 'PC', file '_msi.c', I found another call to
malloc() which was not checked for a return value of NULL
which would indicate failure. The new patch file is below:
--- _msi.c.orig 2015-04-02 15:01:02.882326352 -0700
+++ _msi.c 2015-04-04 16:36
Bill Parker added the comment:
Addition of file 'ffi.c.patch'...
--
Added file: http://bugs.python.org/file38849/ffi.c.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23878
New submission from Bill Parker:
Hello All,
In reviewing code for Python-3.4.3 in directory
'Modules/_ctypes/libffi/src/arm', file 'ffi.c', I found a pair
of calls to calloc() which do not test for a return value
of NULL, indicating failure. The patch file below corrects
this issue
Bill Parker added the comment:
I would check 23855 as well, since the malloc() missing a sanity check,
which could be a more serious issue ..
On Sat, Apr 4, 2015 at 1:32 AM, Berker Peksag rep...@bugs.python.org
wrote:
Berker Peksag added the comment:
Thanks for the patch, Bill. If you want
New submission from Bill Parker:
Hello All,
In reviewing code in directory Python-3.4.3/Modules, file
'mmapmodule', I found a call to 'lseek()' without a check for
a return value of -1, indicating failure. The patch file below
corrects this issue (diff -u format):
--- mmapmodule.c.orig
New submission from Bill Parker:
Hello All,
In reviewing code in Python-3.4.3/PC/_msi.c, I found a call to malloc() at
line 326 in function 'static PyObject* msierror(int status)' in which the call
is made and assigned to variable 'res', but no check for NULL, indicating
failure is made
