Brian Curtin added the comment:
I don't think this should have been closed just yet. If the issue still exists
in 2.x, it could still be fixed in the remaining 2.6 release, or any of the
future 2.7 releases.
You are right that it won't apply to 3.x since hotshot is
Changes by Brian Curtin :
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue9262>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
I would forget about slicing or using startswith. "win32" is the platform name
for Python on Windows whether or not it's 64-bit (see PC/pyconfig.h), so I'd
just check """sys.platform == 'w
Brian Curtin added the comment:
You forgot "self." on at least lines 1042 and 1044 in Lib/subprocess.py --
multiple test failures occur on Windows 7 due to a NameError for the global
stdout_thread not being defined. It seems "self." would also be needed on 1049
and 105
Brian Curtin added the comment:
Thanks for the patch. Fixed in r83007 through r83010.
--
assignee: -> brian.curtin
components: +Documentation, Extension Modules
nosy: +brian.curtin
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
type: -> be
Brian Curtin added the comment:
Looks good to me.
--
___
Python tracker
<http://bugs.python.org/issue5673>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
issue9079a.diff doesn't compile on Windows - timeval isn't defined. You'd have
to include Winsock2.h [0]. Adding something like the following within the
HAVE_FTIME block would work...
#ifdef MS_WINDOWS
#include
#endif
I don't currently hav
Brian Curtin added the comment:
Here are the errors I get:
Error 104 error C2037: left of 'tv_sec' specifies undefined struct/union
'timeval'c:\python-dev\py3k\Python\pytime.c 46 pythoncore
Error 105 error C2037: left of 'tv_usec' sp
Brian Curtin added the comment:
I won't have time to review this, but I can say issue9079b.diff works fine on
Windows.
--
___
Python tracker
<http://bugs.python.org/i
Changes by Brian Curtin :
--
components: +Extension Modules, Windows
nosy: +brian.curtin
stage: -> unit test needed
versions: +Python 3.2
___
Python tracker
<http://bugs.python.org/iss
Brian Curtin added the comment:
issue9324.diff checks the signal value after argument parsing and before
sending it onward towards the system call.
It only lets you use the following signals, per
http://msdn.microsoft.com/en-us/library/xdkz3x12.aspx
SIGABRT
SIGFPE
SIGILL
SIGINT
SIGSEGV
Brian Curtin added the comment:
Oops, note to myself that there's a long line in signalmodule.c.
--
___
Python tracker
<http://bugs.python.org/issue9324>
___
___
Changes by Brian Curtin :
--
assignee: d...@python -> brian.curtin
___
Python tracker
<http://bugs.python.org/issue7579>
___
___
Python-bugs-list mai
New submission from Brian Curtin :
A recent sysconfig test which should have been skipped on Windows (now fixed)
exposed a bug in the assertIn/assertNotIn methods. If the "container" you are
testing doesn't support membership testing or iteration, such as None value
when a prev
New submission from Brian Curtin :
#1578269 introduced os.symlink support for Windows 6.0, but it requires the
SeCreateSymbolicLinkPrivilege privilege to be enabled for the calling user,
which is not always the case. Documentation needs to be added on the specific
details here, possibly
Brian Curtin added the comment:
Closed. I created #9332 for the remaining side issues.
--
status: pending -> closed
___
Python tracker
<http://bugs.python.org/issue1
New submission from Brian Curtin :
As it currently stands, the possibility exists that some users might not have
the SeCreateSymbolicLinkPrivilege privilege enabled (depending on security
settings, corporate policy, etc). There should be some method of enabling that
privilege outside of the
Brian Curtin added the comment:
I knew there was a reason I was thinking my whole idea was slightly
ridiculous...duh.
--
resolution: -> rejected
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Brian Curtin added the comment:
That's a way better idea. It would also cut down some of the code in
Lib/test/symlink_support.py. I'll take a whack at that and see how it looks.
--
___
Python tracker
<http://bugs.python.
Changes by Brian Curtin :
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue9291>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
One additional change was needed to compile on Windows:
Index: PC/config.c
===
--- PC/config.c (revision 83087)
+++ PC/config.c (working copy)
@@ -116,7 +116,7 @@
{"parser", PyI
Changes by Brian Curtin :
--
dependencies: +Add ntpath.sameopenfile support for Windows
___
Python tracker
<http://bugs.python.org/issue8879>
___
___
Python-bug
Brian Curtin added the comment:
Here's a patch implementing ntpath.sameopenfile with _getfileinformation in
Modules/posixmodule.c.
Martin's suggestion is the best way of doing this, which was the basis for
_getfileinformation implementation. It returns a tuple of the three releva
Brian Curtin added the comment:
Fixed by Ezio Melotti in r83103.
--
nosy: +brian.curtin
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
type: -> behavior
___
Python tracker
<http://bugs.pytho
Brian Curtin added the comment:
msg77014 could bring startup time down significantly so I'm -1 on that.
Overall I've never found difficulty in running scripts with the right version
so I don't have a strong enough opinion on any of it. I think it's probably
something whic
Brian Curtin added the comment:
Committed to py3k in r83154 and release27-maint in r83155.
--
nosy: +brian.curtin
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bug
Brian Curtin added the comment:
I don't think we should have a list of three alternatives to the single way you
really should be creating diffs. If you are working on Python you should have
Subversion and run "svn diff", or have Mercurual and run "hg diff".
I gue
Brian Curtin added the comment:
Until Rietveld has a defined place in our workflow, I don't think that's a good
idea.
I think that will be a part of the process in the future, but we're not
defining that here.
--
___
Python
Brian Curtin added the comment:
"svn diff" is already explained a few times in the doc, including the line
above the suggested change.
--
resolution: -> rejected
stage: -> committed/rejected
status: open -> closed
___
Py
Brian Curtin added the comment:
Python 3.1.2 (r312:79149, Mar 21 2010, 00:41:52) [MSC v.1500 32 bit (Intel)] on
win32
Type "help", "copyright", "credits" or "license" for more information.
>>> ^D
File "", line 1
♦
^
Changes by Brian Curtin :
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue1682942>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
Do you have pyreadline installed? If so, that is causing it. If not, it's
something else as Ctrl-D is not an EOF character on Windows.
--
___
Python tracker
<http://bugs.python.org/i
Changes by Brian Curtin :
--
nosy: -brian.curtin
___
Python tracker
<http://bugs.python.org/issue9362>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
I uploaded the current patch to Rietveld and reviewed it there, CC'ed Łukasz.
http://codereview.appspot.com/1848051/show is the link.
I only gave the tests a once-over since they failed for not having the test
file Łukasz meant to include. I'll re
Brian Curtin added the comment:
I'm guessing assigning to Christian was accidental - taking it back for myself.
--
assignee: christian.heimes -> brian.curtin
priority: low -> normal
stage: committed/rejected ->
___
Python
Brian Curtin added the comment:
How does this patch look? It changes RegexObject to _sre.SRE_Pattern and
MatchObject to _sre.SRE_Match. Additionally, references are used to link to
those classes generically as "match objects" or "compiled regular expressions"
rather t
Brian Curtin added the comment:
I didn't actually want to use _sre.SRE_* but I'm not exactly sure how to hide
it. It's more correct that way, but it takes this issue the wrong direction by
exposing it.
I think it should be denoted as a class but with a generic name, if that
Brian Curtin added the comment:
Unless this is confirmed to have been fixed, it should not be closed.
--
nosy: +brian.curtin
status: pending -> open
___
Python tracker
<http://bugs.python.org/iss
Changes by Brian Curtin :
--
status: pending -> open
___
Python tracker
<http://bugs.python.org/issue4841>
___
___
Python-bugs-list mailing list
Unsubscri
Brian Curtin added the comment:
Both machines I've seen this on were true multicore, no VMs. One is dual core
the other is 16.
--
___
Python tracker
<http://bugs.python.org/i
New submission from Brian Curtin :
Raymond informed me that #1578269 introduced breakage to compilation under
Visual Studio 2005 due to three undefined symbols. I'm not currently setup to
build under 2005, so I just offer this patch which defines the values as they
are seen in VS
Brian Curtin added the comment:
Fixed in r83407 (py3k), r83409 (release31-maint), and r83410 (release27-maint).
--
assignee: -> brian.curtin
components: +Extension Modules -Library (Lib)
resolution: -> fixed
stage: patch review -> committed/rejected
status: open
Brian Curtin added the comment:
Although you say this is fairly common, I haven't heard of anyone using or
requesting this type of feature. Do you have any real-world use cases for this?
Before we start adding more read methods I think we should know who wants them
and why.
I'
Brian Curtin added the comment:
The test added here is crashing my Windows 7 x64 machine on py3k in debug mode.
It hangs indefinitely in release mode. This isn't occurring with the
buildbots...
(Sorry for not reporting this sooner...I came to see the status and apparently
the mess
Changes by Brian Curtin :
Removed file: http://bugs.python.org/file18132/enable_symlink.diff
___
Python tracker
<http://bugs.python.org/issue9333>
___
___
Python-bug
Brian Curtin added the comment:
Here's a patch implementing a similar idea to what Jason mentioned, complete
with the test updates and code removals. It initially adds win_symlink as
"_symlink", and on module initialization it will be renamed to "symlink" if th
Brian Curtin added the comment:
Forgot to mention: I've only run this on Win7 at the moment. I'll need to take
a look at how this works on older Windows.
--
___
Python tracker
<http://bugs.python.
Brian Curtin added the comment:
I'll have to investigate the possibility of the privilege occurring on XP --
I'm doubtful that it exists there, but I'll confirm.
Currently "os._symlink" is not exposed -- it gets swallowed up in Lib/os.py in
the "nt"
Brian Curtin added the comment:
Unless anyone plans on a patch I say we let this go. As of 2.5 we provide x64
installers, and with most users running on 64-bit OS'es I would say it's better
to suggest they use a 64-bit compiled Python to obtain an even larger
addressable space.
New submission from Brian Curtin :
I just realized test_multiprocessing is being skipped on Windows because a few
relative imports of _multiprocessing are failing in win32 specific code blocks.
Attached is a trivial patch to remove the relative import, enabling the tests
to run and succeed on
Brian Curtin added the comment:
Fixed in r83722 (py3k) and r837274 (release31-maint).
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
versions: -Python 2.7
___
Python tracker
<http://bug
Brian Curtin added the comment:
Tim,
I updated your test to use some of the newer and preferred unittest features
and made a change to do the common stuff in loops. The _subprocess.c changes
look fine to me. See attached issue3210_py3k.diff.
--
nosy: +brian.curtin
Added file: http
Changes by Brian Curtin :
--
stage: unit test needed -> patch review
___
Python tracker
<http://bugs.python.org/issue3210>
___
___
Python-bugs-list mai
Brian Curtin added the comment:
Ah ok. I got hooked onto new unittest stuff and overdid it. Whoops.
In that case, I guess just the last lines converting your "assert_" to
"assertFalse" would be my only suggestion.
--
___
P
Brian Curtin added the comment:
Those two signals are only intended to work with os.kill -- they are specific
to the GenerateConsoleCtrlEvent function in Modules/posixmodule.c. I'll have to
change the documentation to note that.
If you want to send those events to other processes, h
Brian Curtin added the comment:
Fixed the first part, denoting that signal.CTRL_C_EVENT and
signal.CTRL_BREAK_EVENT are for os.kill only. Done in r83745 (py3k) and r83746
(release27-maint).
Leaving open for the second part about their usage
Brian Curtin added the comment:
Fixed in r83763 (py3k), r83764 (release31-maint), and r83765 (release27-maint).
Thanks for reporting this.
--
resolution: -> fixed
stage: patch review -> committed/rejected
versions: +Python 3.1
___
Python t
Brian Curtin added the comment:
"I don't have python3 installed at work, sorry."
Does that mean you have been using the patch with 2.x? If so, that's not valid.
--
___
Python tracker
<http://bu
Brian Curtin added the comment:
"I've been using the subprocess-timeout-v5.patch patch with 2.x. Isn't that
version supposed to work with 2.x?"
Actually, yes, so I was wrong at first. The v5 patch will work with 2.x, but
that's not the most up to date or correct patc
Changes by Brian Curtin :
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue949667>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
Attached is a patch using Ronald's suggestion to rework this as a switch
statement. Also included is a minor reworking that Paul noticed in
Lib/test/test_signal.py.
Added the people who responded to the python-dev checkin comments to the nosy
list. Feel
Brian Curtin added the comment:
Shouldn't the tests calculate line wrapping based on what is set, rather than
brute forcing it to be 80?
--
nosy: +brian.curtin
stage: -> unit test needed
versions: +Python 3.2 -Python 3.3
___
Python tracke
Changes by Brian Curtin :
--
components: +Windows
versions: +Python 2.7, Python 3.1, Python 3.2 -Python 2.6, Python 3.0
___
Python tracker
<http://bugs.python.org/issue1508
New submission from Brian Curtin :
The fix for #2304 causes issues on Windows if you have file associations setup
that aren't Python interpters. In my case I have an association setup to open
.py files in gvim, which causes the shell tests to hang until I quit the
editor, then it
Brian Curtin added the comment:
Attached is a patch that fixes this for me, and I *think* it's looking in the
most correct area for the information.
Tim or any other Windows users, would you mind seeing that the skip does not
occur on your machines, thus allowing it to properly run
Brian Curtin added the comment:
I've tried changing privileges for a user and I'm not seeing that they get
reflected in real-time while an application is running. Maybe I'm not doing it
right, but I'm not seeing it. I'm also not able to find anything about that
being
Brian Curtin added the comment:
Yeah that's much better :)
I should have asked if you left out sys.executable out intentionally before
coming up with my patch...I assumed it was intended to be different due to
shell=1 or something.
Go ahead and apply if you want.
--
ass
Brian Curtin added the comment:
Fixed in r83983, r83984, and r83985. Thanks, Tim.
--
assignee: tim.golden -> brian.curtin
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
title: Skip subprocess shell tests on Windows per file assoc
Brian Curtin added the comment:
I just fixed a similar problem for #9513 but the problem was only ever seen
when test_multiprocessing was run through regrtest on 3.x on Windows. Removing
the relative import dot on _multiprocessing imports let them succeed.
I've never actually seen this
Brian Curtin added the comment:
I should correct myself. As seen on the 2.6 Win7 buildbot[0],
test_multiprocessing is skipped there likely due to the "from
._multiprocessing..." ImportError. I kind of remember this now but didn't want
to backport the fix to release26-mai
Brian Curtin added the comment:
Ok, it turns out this is in fact a regression from 2.6.5. My prior
investigation for that 3.x issue must not have been on the 2.6 version I
thought it was.
Barry: the fix from #9513 (e.g., r83722) will correct this.
--
priority: normal -> rele
Brian Curtin added the comment:
Here's the patch. All four changes are one char each and live within
win32-specific blocks.
--
keywords: +patch
Added file: http://bugs.python.org/file18526/issue9600.diff
___
Python tracker
<http://bugs.py
Brian Curtin added the comment:
Committed in r84031.
Thanks for reporting this, cipater.
--
assignee: -> brian.curtin
resolution: accepted -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
___
Python tr
Changes by Brian Curtin :
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue9566>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
I committed the code you speak of (posix__getfinalpathname in
Modules/posixmodule.c), but I don't know if I have a great answer for that
question. It looks like VOLUME_NAME_NT (path with volume device path) should
just be changed to VOLUME_NAME_DOS (path
Brian Curtin added the comment:
sockdefine.patch seems fine to me.
--
___
Python tracker
<http://bugs.python.org/issue4835>
___
___
Python-bugs-list mailin
Changes by Brian Curtin :
--
stage: -> needs patch
type: -> feature request
versions: +Python 3.2 -Python 3.1
___
Python tracker
<http://bugs.python.org/
Brian Curtin added the comment:
I have zero knowledge and experience when it comes to curses so I'm afraid I
can't really provide much here.
One thing I can say is that this patch would have to be converted to be
compiled by MSVC rather than MinGW. That was an early issue with #2
New submission from Brian Curtin :
"""
with file("sample.py", "r") as f:
pass
"""
The above code comes out of 2to3 with no modifications suggested. "file" is
gone in 3.x and could be substituted with "open" usage in
Brian Curtin added the comment:
> (not sure its for this thread though but...) Windows on default limits
> the amount of memory for 32 bit processes to 2GB. There's a bit in
> the PE image which tells 64 bit windows to give it 4GB (on 32 bit
> windows PAE needs to be enab
Brian Curtin added the comment:
+1
These are apparently so commonly looked up that there are even two websites
dedicated to these options: http://strftime.org/ and http://strfti.me/. Even
Sauce Labs put the format options on the side of the coffee mugs they handed
out at PyCon 2010
Brian Curtin added the comment:
Your patch works for me on Win7.
I'll put together a patch for the malloc/free thing in your first bullet point.
--
___
Python tracker
<http://bugs.python.org/i
Brian Curtin added the comment:
When you install what? Python, Blender, or clonk?
Can you take a screenshot of the message that you see, possibly along with more
details about what it is that you are doing?
--
nosy: +brian.curtin
___
Python
New submission from Brian Curtin :
Using Cygwin 1.7, there are build failures for both _curses, _curses_panel, and
_io.
The curses failures are because symlinking /usr/include/{n}curses.h from
/usr/include/{n}curses.h was removed in recent versions [0], so I added
"-I/usr/include/nc
Brian Curtin added the comment:
This patch lets everything build ok, but a run of regrtest segfaults usually
after a few tests (using -r) and there are nearly constant stack traces printed
to stderr about not being able to remap the Cygwin bz2 DLL's address space.
I used extern as R
Brian Curtin added the comment:
Committed to py3k in r84295.
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.o
Changes by Brian Curtin :
--
nosy: +asksol
___
Python tracker
<http://bugs.python.org/issue8296>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Brian Curtin :
Removed file: http://bugs.python.org/file17073/issue8521.diff
___
Python tracker
<http://bugs.python.org/issue8521>
___
___
Python-bugs-list m
Brian Curtin added the comment:
Attached is a better patch which, I think, uses better names.
CreateKeyEx, OpenKeyEx, and DeleteKeyEx (x64 only) all take named arguments.
key, sub_key, reserved, and access are the names of the arguments. The tests
run Create and Open regardless, but use
Brian Curtin added the comment:
+1 on option 1
--
___
Python tracker
<http://bugs.python.org/issue8781>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Brian Curtin :
--
nosy: +flox
stage: -> needs patch
type: -> behavior
___
Python tracker
<http://bugs.python.org/issue9692>
___
___
Python-bugs-
Changes by Brian Curtin :
--
components: +Installation, Windows -None
stage: -> needs patch
title: 2755 -> Error 2755, "failure to find drive" when installing Python
type: -> behavior
___
Python tracker
<http://bug
Changes by Brian Curtin :
Removed file: http://bugs.python.org/file18660/unnamed
___
Python tracker
<http://bugs.python.org/issue9624>
___
___
Python-bugs-list mailin
Changes by Brian Curtin :
--
status: open -> languishing
versions: +Python 3.2 -Python 2.7
___
Python tracker
<http://bugs.python.org/issue1697175>
___
___
Py
Brian Curtin added the comment:
I'm not able to reproduce this. Do you have anything installed like pyreadline?
--
assignee: ronaldoussoren ->
nosy: +brian.curtin
versions: -Python 2.6
___
Python tracker
<http://bugs.python.or
Changes by Brian Curtin :
--
assignee: -> brian.curtin
components: +Extension Modules -Library (Lib)
versions: -Python 2.7
___
Python tracker
<http://bugs.python.org/iss
Changes by Brian Curtin :
--
keywords: +needs review
stage: -> patch review
versions: -Python 2.5, Python 2.6, Python 3.3
___
Python tracker
<http://bugs.python.org/iss
Brian Curtin added the comment:
> Important tools (like ease_install, pypm) from `Script` directory are
> already including version prefixes in their names (tool-2.7.exe).
>
> This means that it should not be a big problem having several Scripts
> directories on your path.
Brian Curtin added the comment:
s/append existing paths/append new paths/
--
___
Python tracker
<http://bugs.python.org/issue7231>
___
___
Python-bugs-list mailin
Changes by Brian Curtin :
--
assignee: -> brian.curtin
___
Python tracker
<http://bugs.python.org/issue2122>
___
___
Python-bugs-list mailing list
Unsubscri
301 - 400 of 1139 matches
Mail list logo