Charles Wohlganger added the comment:
The PR contains all the requested features, as well as mutual deletion
(requested on PR page), and I have separated out the options for mutual
deletion triggered by delete or triggered by backspace. I've found in usage
that it was irritating to have both
Changes by Charles Wohlganger <charles.wohlgan...@gmail.com>:
--
pull_requests: -2554
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python
Changes by Charles Wohlganger <charles.wohlgan...@gmail.com>:
--
keywords: +patch
pull_requests: +3565
stage: needs patch -> patch review
___
Python tracker <rep...@bugs.python.org>
<https://bugs.pyt
Changes by Charles Wohlganger <charles.wohlgan...@gmail.com>:
--
keywords: +patch
pull_requests: +3517
stage: -> patch review
___
Python tracker <rep...@bugs.python.org>
<https://bugs.pyt
Changes by Charles Wohlganger <charles.wohlgan...@gmail.com>:
--
pull_requests: +3253
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Charles Wohlganger added the comment:
ZoomHeight has been put back into being an extension. This was because
configdialog assumes autoexpand was an extension, and the idleconf tests all
need at least one extension to exist to be useful. Zoomheight is pointless in
almost any modern desktop
Charles Wohlganger added the comment:
I am not sure I understand your concern. As part of mainlining the extensions,
all of their keybindings were moved to config-keys.def . There is nothing to
prevent users from changing the keybindings or preventing us from making the
defaults different
Charles Wohlganger added the comment:
Modulo is defined mathematically as the remainder of Euclidian division. I.E. a
positive r where a % b = r is equivalent to a = b * x + r. I think it confuses
the issue to say "-190 % 12 were the mathematical equivalent -10", when that is
t
Charles Wohlganger added the comment:
Unfortunately, it looks like config deletes settings for extensions when they
are not found - which is what will happen with this patch. One solution would
be to have separate config files for 2 and 3
Charles Wohlganger added the comment:
The patch moves all config variables to config-main, config-highlight (for
highlight colors), and config-keys (for keys). Keys and highlights are
configurable in their respective tabs. Parens and Code Context options are in
the Highlighting tab, Format
Changes by Charles Wohlganger <charles.wohlgan...@gmail.com>:
Added file: http://bugs.python.org/file47031/test_parenclose.py
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Charles Wohlganger added the comment:
I've uploaded a test file and updated ParenClose.
--
Added file: http://bugs.python.org/file47030/ParenClose.py
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Changes by Charles Wohlganger <charles.wohlgan...@gmail.com>:
Added file: http://bugs.python.org/file47029/test_parenclose.py
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Charles Wohlganger added the comment:
Menus items were placed where they appeared as extensions. It would be no
difficulty for me to move them around.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Charles Wohlganger added the comment:
Changes to master have introduced tests with hardcoded values for what
extensions are expected to be loaded by IDLE. Given that this patch turn all
current extensions into mainlined modules, none of them are loaded as
extensions and all of the related
Charles Wohlganger added the comment:
I (foolishly) was committing to master for a different IDLE enhancement. Until
that one is pulled, I don't think I can make a new PR without it also having
all the changes from my previous one.
New uploaded file has docstrings for the ParenClose class
Charles Wohlganger added the comment:
I've written an extension (see file) that does auto insertion of closing
parens, brackets, braces, ticks, and quotes. It also (optionally) skips the
closers when they are typed right next to the already exiting one. It also
takes into account triple-ticks
Charles Wohlganger added the comment:
I modified Mark Rosen's newTabExtension to work with more recent versions of
IDLE, as it wasn't working when I tried it on mine. It's not clear if it ever
could when it was originally working, but I can't get it to move tabs between
multiple window
Charles Wohlganger added the comment:
Pull Request is passing build tests. Please check for pushing to master at your
convenience.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Charles Wohlganger added the comment:
Thank you, Cheryl Sabella. I think I've found which tests I've missed running.
Now to fix all the bugs...
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Charles Wohlganger added the comment:
Pull request won't pass build test, but passes the full idle test on my
workstation.
Primary cause seems to be:
ImportError: cannot import name 'EditorWindow' from 'idlelib.editor'
I can also import EditorWindow by itself on my workstation. None
Changes by Charles Wohlganger <charles.wohlgan...@gmail.com>:
--
pull_requests: +2718
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Charles Wohlganger added the comment:
I've rolled pretty much all this was going to do, other than underlining and
font work into #27099. Trying to bring parenmatch into main otherwise would
have been just as much of a hassle.
--
___
Python tracker
Charles Wohlganger added the comment:
Progress Update: I've moved all of the basic functionality of the extensions
into the regular parts of IDLE, including menus and keyboard shortcuts.
parenmatch and codecontext have all of their settings now in the Highlighting
settings tab. I have added
Charles Wohlganger added the comment:
Implimenting #27099 seems the more reasonable solution to me, so I'll work on
that when I have free time.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Charles Wohlganger added the comment:
The pull request has been changed to only have the theme element able to be
selected. #22705 hasn't had activity in a few years. Is there something I can
do to move it along?
--
___
Python tracker <
Changes by Charles Wohlganger <charles.wohlgan...@gmail.com>:
--
pull_requests: +2554
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
New submission from Charles Wohlganger:
Current IDLE parenmatch highlighting uses the 'hilite' style when highlighting
the parens/expression.
Desired behavior is to use a user-setting based style that is independent from
the hilite style (which is used for highlighting selected text). Desired
Charles Wohlganger added the comment:
'opener' sounds fine to me. I agree it makes much more sense than 'default'.
I don't know much about Emacs, and couldn't find what their parens highlighting
styles were. I can't think of anything sensible that isn't in this extension
with this enhancement
Changes by Charles Wohlganger <charles.wohlgan...@gmail.com>:
--
pull_requests: +2504
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Charles Wohlganger added the comment:
There are two changes:
First - The flash-delay option is for how until the parens that are highlighted
will stop highlighting. The flash-delay option for the ParenMatch only affects
the 'default' style. Similarly the 'expressions' style does not use
Changes by Charles Wohlganger <charles.wohlgan...@gmail.com>:
--
pull_requests: +2366
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Changes by Charles Wohlganger <charles.wohlgan...@gmail.com>:
--
pull_requests: +2363
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Changes by Charles Wohlganger <charles.wohlgan...@gmail.com>:
--
pull_requests: -2362
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Changes by Charles Wohlganger <charles.wohlgan...@gmail.com>:
--
pull_requests: +2362
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
New submission from Charles Wohlganger:
Sorry, I'm new to this, and I've done it out of order. Commit #2306 covers the
following:
In IDLE, parenmatch extension:
Add highlighting left and right parens to styles.
Make flash-delay setting independent of parens highlighting style. Currently
36 matches
Mail list logo
