Claudiu Popa added the comment:
I'm adding another example here, where the lineno reporting is wrong:
from ast import parse
n = parse('''
def test():
return f"{a}"
''')
f = n.body[0].body[0].value.values[0]
n = f.value
print(&
New submission from Claudiu Popa:
Hi,
In Python 3.5, the lineno for dict and set display ASTs is the line number of
the first value, not the line number of the display character, as it was until
3.5. Here's an example:
from ast import parse
module = parse('''
Claudiu Popa added the comment:
Hello,
Can anyone review the last patch? Hopefully it is the final version, since the
beta is really at the corner and I definitely would like to have this in 3.5.
--
___
Python tracker
<http://bugs.python.
Changes by Claudiu Popa :
--
nosy: +Claudiu.Popa
___
Python tracker
<http://bugs.python.org/issue21423>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Claudiu Popa :
--
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue21423>
___
___
Python-bugs-list mailing list
Unsubscrib
Claudiu Popa added the comment:
The latest patch drops the symlink check, since it can be added later.
--
Added file: http://bugs.python.org/file39133/issue22080_2.patch
___
Python tracker
<http://bugs.python.org/issue22
Claudiu Popa added the comment:
Here's the patch.
--
keywords: +patch
stage: needs patch -> patch review
Added file: http://bugs.python.org/file39132/issue23917.patch
___
Python tracker
<http://bugs.python.org
Changes by Claudiu Popa :
--
stage: needs patch -> test needed
___
Python tracker
<http://bugs.python.org/issue21574>
___
___
Python-bugs-list mailing list
Un
Changes by Claudiu Popa :
--
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue23701>
___
___
Python-bugs-list mailing list
Unsubscrib
Claudiu Popa added the comment:
That's actually expected, since sys.excepthook is a builtin, so there's no
source code to be retrieved (the same holds for other builtins, such as next,
range etc).
--
nosy: +Claudiu.Popa
resolution: -> not a bug
stage: -> resol
Changes by Claudiu Popa :
--
nosy: +Claudiu.Popa
___
Python tracker
<http://bugs.python.org/issue23990>
___
___
Python-bugs-list mailing list
Unsubscribe:
Claudiu Popa added the comment:
Isn't this already supported by the patch added in issue17457?
--
nosy: +Claudiu.Popa
___
Python tracker
<http://bugs.python.org/is
Claudiu Popa added the comment:
Will do, thanks.
--
assignee: -> Claudiu.Popa
stage: -> needs patch
type: -> behavior
___
Python tracker
<http://bugs.python.or
New submission from Claudiu Popa:
winreg.QueryValue's docstring has an "interesting" comment at the end:
"But the underlying API call doesn't return the type, Lame Lame Lame, DONT USE
THIS!!!"
The documentation
(https://docs.python.org/3.4/library/winreg.h
Changes by Claudiu Popa :
--
nosy: +Claudiu.Popa
___
Python tracker
<http://bugs.python.org/issue23681>
___
___
Python-bugs-list mailing list
Unsubscribe:
Claudiu Popa added the comment:
Well, we should have test files for each format imghdr supports. Doesn't PIL
have test files for them?
--
___
Python tracker
<http://bugs.python.org/is
Claudiu Popa added the comment:
Thank you for the review. The new patch uses the name UnLoadKey for the API.
--
Added file: http://bugs.python.org/file38481/issue21518_6.patch
___
Python tracker
<http://bugs.python.org/issue21
Claudiu Popa added the comment:
> The patch adds support only for unbound methods and requires additional
> parameter for this.
Just curios, which part works only for unbound methods?
> It is not what should be done in this issue at all.
> It should be easier to write it myself t
Claudiu Popa added the comment:
In general, the patch looks good, I left a couple of comments on Rietvld. It
should be applied to 3.5 only. Also, there are some image test files which
aren't included in this patch, could you update it to include them? T
Claudiu Popa added the comment:
I find the new error messages clear and straight to the point. It would be nice
if this would get into 3.5.
--
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org/issu
Changes by Claudiu Popa :
--
nosy: +Claudiu.Popa
___
Python tracker
<http://bugs.python.org/issue22964>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Claudiu Popa :
--
nosy: +Claudiu.Popa
versions: +Python 3.5
___
Python tracker
<http://bugs.python.org/issue22189>
___
___
Python-bugs-list mailin
Changes by Claudiu Popa :
--
nosy: +Claudiu.Popa
___
Python tracker
<http://bugs.python.org/issue21385>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Claudiu Popa :
--
nosy: +Claudiu.Popa
___
Python tracker
<http://bugs.python.org/issue21478>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Claudiu Popa :
--
nosy: +Claudiu.Popa
___
Python tracker
<http://bugs.python.org/issue21271>
___
___
Python-bugs-list mailing list
Unsubscribe:
Claudiu Popa added the comment:
This was recently fixed in 3.5 by 73afda5a4e4c.
--
nosy: +Claudiu.Popa
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Claudiu Popa :
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue11705>
___
___
Changes by Claudiu Popa :
--
nosy: +Claudiu.Popa
type: -> behavior
versions: +Python 3.5 -Python 2.7, Python 3.1, Python 3.2, Python 3.3
___
Python tracker
<http://bugs.python.org/issu
Changes by Claudiu Popa :
--
nosy: +Claudiu.Popa
___
Python tracker
<http://bugs.python.org/issue7877>
___
___
Python-bugs-list mailing list
Unsubscribe:
Claudiu Popa added the comment:
This was fixed a couple of months ago:
https://hg.python.org/cpython/rev/07968254be96. Also, malloc was changed to
PyMem_New a couple of weeks ago: https://hg.python.org/cpython/rev/036a2aceae93
--
nosy: +Claudiu.Popa
resolution: -> fixed
stage: ne
Changes by Claudiu Popa :
Added file: http://bugs.python.org/file38382/issue21518_5.patch
___
Python tracker
<http://bugs.python.org/issue21518>
___
___
Python-bugs-list m
Claudiu Popa added the comment:
This was fixed by a different patch in
https://hg.python.org/cpython/rev/5f3dd0a2b1ab
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bug
Changes by Claudiu Popa :
--
nosy: -Claudiu.Popa
___
Python tracker
<http://bugs.python.org/issue13397>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Claudiu Popa :
--
nosy: +Claudiu.Popa
versions: +Python 3.5 -Python 2.7, Python 3.2, Python 3.3
___
Python tracker
<http://bugs.python.org/issue4
Claudiu Popa added the comment:
Thanks, Serhiy. Only the security issue is fixed in this patch, since eval is
replaced by ast.literal_eval and nothing else. Indeed, if the data is something
else than what dbm expects after ast.literal_eval, then it would fail, but it
would have failed
Claudiu Popa added the comment:
Thanks, Victor. I thought the same thing, but the file is deleted here already,
here:
https://hg.python.org/cpython/file/981ba93bcbde/Lib/test/test_dbm_dumb.py#l228
--
___
Python tracker
<http://bugs.python.
Changes by Claudiu Popa :
Added file: http://bugs.python.org/file37823/issue23078.patch
___
Python tracker
<http://bugs.python.org/issue23078>
___
___
Python-bugs-list m
Claudiu Popa added the comment:
Ups, sorry about that, I'll update the patch.
--
___
Python tracker
<http://bugs.python.org/issue23078>
___
___
Python-bugs-l
Changes by Claudiu Popa :
Added file: http://bugs.python.org/file37820/issue21518_4.patch
___
Python tracker
<http://bugs.python.org/issue21518>
___
___
Python-bugs-list m
Claudiu Popa added the comment:
Ups, the last patch included an extra file.
--
Added file: http://bugs.python.org/file37819/issue21518_3.patch
___
Python tracker
<http://bugs.python.org/issue21
Claudiu Popa added the comment:
Here's a patch which does this. One problem could be that
staticmethod(some_callable) or classmethod(some_callable) aren't callable per
se, but given the fact that users expects Foo.staticmethod or Foo.klassmethod
to be callable when patching
Claudiu Popa added the comment:
Thanks for the tip, Guido. The new patch uses exception chaining. If this needs
backporting, most probably the first patch can be used.
--
Added file: http://bugs.python.org/file37813/issue22885_1.patch
___
Python
Changes by Claudiu Popa :
--
priority: normal -> high
stage: -> patch review
versions: +Python 3.5
___
Python tracker
<http://bugs.python.org/issue22885>
___
__
Claudiu Popa added the comment:
Here's a patch which uses ast.literal_eval instead. This doesn't get code
executed, since literal_eval will fail loudly for anything other than a
literal. There are some issues to consider:
- let the current ast.literal_eval call bubble out wit
Claudiu Popa added the comment:
Ping. :-)
--
___
Python tracker
<http://bugs.python.org/issue22522>
___
___
Python-bugs-list mailing list
Unsubscribe:
Claudiu Popa added the comment:
Thanks, Antoine! Here's the new version, with your comments addressed.
--
Added file: http://bugs.python.org/file37744/issue21817_2.patch
___
Python tracker
<http://bugs.python.org/is
Claudiu Popa added the comment:
The new patch drops the weird error dance from test_unload_key, it seems to
work without it, I don't remember how it failed without it.
--
Added file: http://bugs.python.org/file37742/issue21518_2.patch
___
P
Claudiu Popa added the comment:
Here's a cleaned up version of the patch.
--
Added file: http://bugs.python.org/file37741/issue22080_1.patch
___
Python tracker
<http://bugs.python.org/is
Claudiu Popa added the comment:
Here's the updated version of this patch.
--
type: behavior -> enhancement
versions: -Python 3.4
Added file: http://bugs.python.org/file37738/issue21817_1.patch
___
Python tracker
<http://bugs.python.org
Changes by Claudiu Popa :
--
nosy: +Claudiu.Popa, yselivanov
versions: +Python 3.5 -Python 2.6, Python 2.7, Python 3.1, Python 3.2
___
Python tracker
<http://bugs.python.org/issue6
Claudiu Popa added the comment:
Yury, regarding your last message, is it actually possible to have a subclass
which doesn't have a __doc__ attribute in its __dict__, except using slots?
__doc__ seems to be set to None every time if it's not specified, so I don't
know how cou
New submission from Claudiu Popa:
Hi,
Doing the following on Windows leads to a nasty crash "python_d -m test
test_ctypes":
[1/1] test_ctypes
Fatal Python error: Segmentation fault
Current thread 0x16fc (most recent call first):
File "E:\Projects\repos\cpython\lib\u
Claudiu Popa added the comment:
Alright, I'll update my patch later this week.
--
___
Python tracker
<http://bugs.python.org/issue15582>
___
___
Python-bugs-l
Claudiu Popa added the comment:
I don't know why there's no review link for your patch. Anyway..
+self.assertTrue(c.complete("A.foo", 0) in ['A.foo(', 'A.foobar('])
+self.assertTrue(c.complete("A.foo", 1) in ['A.foo
Claudiu Popa added the comment:
Looks good to me. You might want to sign the contributor agreement:
https://www.python.org/psf/contrib/contrib-form/. This is required for
non-trivial contributions. You'll get a * next to your name after signing it.
--
stage: patch review ->
Claudiu Popa added the comment:
Here's a refreshed patch, which applies cleanly on tip. Also, I added a test
for the code that generates an infinite loop.
--
nosy: +Claudiu.Popa
versions: +Python 3.5 -Python 3.2, Python 3.3, Python 3.4
Added file: http://bugs.python.org/file
New submission from Claudiu Popa:
Hi,
The following code gives similar errors for both PyPy and Python 2 when called,
but totally different AST objects.
Given the following code, PyPy says that `print(4)` is an _ast.Print, while
Python 2 believes that it is an _ast.Expr (which wraps a Call
Claudiu Popa added the comment:
Thank you for your feedback, Terry.
1. IDLE is behaving differently than the builtin interpreter. It should be
higher priority, because it
leads beginners into believing that code objects are picklable.
2. No, wrapping code objects in a CodePickler with
Claudiu Popa added the comment:
Here's a refreshed patch:
- raising_conversion_error is now raise_conversion_error
- the decorator uses functools.wraps
- the ConversionError is instantiated with the first argument of the caught
expression
- the reraising of ConversionError has the exce
Changes by Claudiu Popa :
--
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue22522>
___
___
Python-bugs-list mailing list
Unsubscrib
Claudiu Popa added the comment:
Terry, can I do something to move this issue forward?
--
___
Python tracker
<http://bugs.python.org/issue21986>
___
___
Python-bug
Changes by Claudiu Popa :
--
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org/issue18615>
___
___
Python-bugs-list mai
Changes by Claudiu Popa :
--
nosy: +Claudiu.Popa
___
Python tracker
<http://bugs.python.org/issue11694>
___
___
Python-bugs-list mailing list
Unsubscribe:
Claudiu Popa added the comment:
I'm not sure that Glenn receives this, he is not in the nosy list.
2014-07-18 16:45:36 glangford set nosy: - glangford
--
nosy: +Claudiu.Popa
___
Python tracker
<http://bugs.python.org/is
New submission from Claudiu Popa:
It seems that sys.excepthook doesn't receive the traceback when an error occurs
during a code.InteractiveInterpreter run. The problem is here:
https://hg.python.org/cpython/file/5ade1061fa3d/Lib/code.py#l168. last_tb was
previously set to None right b
Claudiu Popa added the comment:
Indeed, it's a preexisting bug. I'll try to come up with a patch shortly.
--
___
Python tracker
<http://bugs.python.o
Claudiu Popa added the comment:
I'd say that this should be fixed, it breaks the expectancy imposed by the
documentation, so +1 from me.
--
nosy: +Claudiu.Popa
___
Python tracker
<http://bugs.python.org/is
Changes by Claudiu Popa :
--
components: +Library (Lib)
versions: +Python 3.5 -Python 3.3
___
Python tracker
<http://bugs.python.org/issue16837>
___
___
Python-bug
Changes by Claudiu Popa :
--
stage: patch review -> test needed
___
Python tracker
<http://bugs.python.org/issue16512>
___
___
Python-bugs-list mailing list
Un
Claudiu Popa added the comment:
The patch looks good. Could you add a test?
--
nosy: +Claudiu.Popa
___
Python tracker
<http://bugs.python.org/issue22143>
___
___
Claudiu Popa added the comment:
Looks good. Could you add a test that reproduces the intended behaviour?
--
nosy: +Claudiu.Popa
___
Python tracker
<http://bugs.python.org/issue22
Claudiu Popa added the comment:
Is there something I can do to move this forward?
--
___
Python tracker
<http://bugs.python.org/issue21518>
___
___
Python-bug
Changes by Claudiu Popa :
--
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue22080>
___
___
Python-bugs-list mailing list
Unsubscrib
Claudiu Popa added the comment:
Thank you for committing it. :-)
--
___
Python tracker
<http://bugs.python.org/issue16104>
___
___
Python-bugs-list mailin
Claudiu Popa added the comment:
Here's the new version which fixes the comments from the review.
--
Added file: http://bugs.python.org/file36592/issue17442_2.patch
___
Python tracker
<http://bugs.python.org/is
Claudiu Popa added the comment:
Actually, no, it seems that I didn't receive any mail regarding them. I'll
update the patch accordingly.
--
___
Python tracker
<http://bugs.python.o
Changes by Claudiu Popa :
--
nosy: -Claudiu.Popa
___
Python tracker
<http://bugs.python.org/issue20752>
___
___
Python-bugs-list mailing list
Unsubscribe:
Claudiu Popa added the comment:
If there is nothing left to do for this patch, can it be committed?
--
Added file: http://bugs.python.org/file36590/16104.patch
___
Python tracker
<http://bugs.python.org/issue16
Claudiu Popa added the comment:
If the patch doesn't need anything else, can it be committed?
--
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org
Claudiu Popa added the comment:
No problem, thank you for committing it.
--
___
Python tracker
<http://bugs.python.org/issue19546>
___
___
Python-bugs-list mailin
Changes by Claudiu Popa :
--
nosy: -Claudiu.Popa
___
Python tracker
<http://bugs.python.org/issue10312>
___
___
Python-bugs-list mailing list
Unsubscribe:
Claudiu Popa added the comment:
Thank you, Guido.
--
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org/issue21527>
___
___
Python-
Claudiu Popa added the comment:
Serhiy, is there anything left to do for this patch?
--
___
Python tracker
<http://bugs.python.org/issue18615>
___
___
Python-bug
Claudiu Popa added the comment:
I'm referring to the "TypeError: 'OSError' object is not iterable" failure.
--
___
Python tracker
<http:
Claudiu Popa added the comment:
A similar issue was fixed a couple of days ago in file_util.py, with
f01413758114. It would be nice to have similar tests.
--
nosy: +Claudiu.Popa
___
Python tracker
<http://bugs.python.org/issue22
Changes by Claudiu Popa :
--
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org/issue22098>
___
___
Python-bugs-list mai
Changes by Claudiu Popa :
Added file: http://bugs.python.org/file36494/issue21527.patch
___
Python tracker
<http://bugs.python.org/issue21527>
___
___
Python-bugs-list m
Changes by Claudiu Popa :
--
nosy: +Claudiu.Popa
___
Python tracker
<http://bugs.python.org/issue22281>
___
___
Python-bugs-list mailing list
Unsubscribe:
Claudiu Popa added the comment:
Here's a short patch.
--
keywords: +patch
stage: needs patch -> patch review
Added file: http://bugs.python.org/file36467/issue22098.patch
___
Python tracker
<http://bugs.python.org
Changes by Claudiu Popa :
--
stage: needs patch -> patch review
___
Python tracker
<http://bugs.python.org/issue21740>
___
___
Python-bugs-list mailing list
Un
Changes by Claudiu Popa :
--
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue22182>
___
___
Python-bugs-list mailing list
Unsubscrib
Changes by Claudiu Popa :
--
stage: needs patch -> patch review
___
Python tracker
<http://bugs.python.org/issue9731>
___
___
Python-bugs-list mailing list
Un
Changes by Claudiu Popa :
--
stage: test needed -> patch review
___
Python tracker
<http://bugs.python.org/issue1764286>
___
___
Python-bugs-list mai
Changes by Claudiu Popa :
--
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue20752>
___
___
Python-bugs-list mailing list
Unsubscrib
Changes by Claudiu Popa :
--
stage: needs patch -> patch review
___
Python tracker
<http://bugs.python.org/issue21986>
___
___
Python-bugs-list mailing list
Un
Claudiu Popa added the comment:
That makes sense. Quoting from the data model: "When inheriting from a class
without __slots__, the __dict__ attribute of that class will always be
accessible, so a __slots__ definition in the subclass is meaningless".
In the current case, for the lit
Changes by Claudiu Popa :
--
stage: -> patch review
type: -> behavior
versions: +Python 3.5 -Python 3.2, Python 3.3
___
Python tracker
<http://bugs.python.org/i
Changes by Claudiu Popa :
--
resolution: -> rejected
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Claudiu Popa :
--
stage: -> commit review
type: -> enhancement
___
Python tracker
<http://bugs.python.org/issue13938>
___
___
Python-bugs-list
Claudiu Popa added the comment:
Any type of feedback regarding this approach will be appreciated.
--
___
Python tracker
<http://bugs.python.org/issue21
1 - 100 of 217 matches
Mail list logo
