[issue31560] hashlib.blake2: error in example for signed cookies

2017-09-23 Thread Dmitry Chestnykh
New submission from Dmitry Chestnykh: The example for creating and verifying signed cookies with hashlib.blake2 doesn't work. Corrected in GitHub PR #3694. -- assignee: docs@python components: Documentation messages: 302787 nosy: dchest, docs@python priority: normal pull_requests: 3692

[issue26798] add BLAKE2 to hashlib

2016-05-08 Thread Dmitry Chestnykh
Dmitry Chestnykh added the comment: > I have replaced verify() with compare_digest(). +>>> compare_digesty(cookie, '0102030405060708090a0b0c0d0e0f00') Typo here. Also, this doesn't look like it compares the digest. Maybe you can keep the verify() function, but make it use co

[issue26798] add BLAKE2 to hashlib

2016-05-08 Thread Dmitry Chestnykh
Dmitry Chestnykh added the comment: Christian: yes, and I'm also happy that you kept the drawing of hash tree, as it helps a lot with understanding of terminology. I had a quick look at the patch and it looks good to me. Some comments, which you can ignore: In keyed hashing example there's