Dong-hee Na added the comment:
> I'd like to add it anyway.
Nice ;)
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue42171>
___
___
Python-
Dong-hee Na added the comment:
@adkhunt
Do you want to submit the patch for this?
If you want, please ping me on your PR
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue42
Change by Dong-hee Na :
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue42161>
___
___
Python-bugs-list mailing list
Unsubscribe:
Dong-hee Na added the comment:
I close this issue with rejected status.
Thank you serhiy, pablogsal and Inada-san for discussion ;)
--
resolution: -> rejected
stage: patch review -> resolved
status: open -> closed
___
Python tracke
Dong-hee Na added the comment:
I will close this issue by tomorrow with rejected ;)
--
___
Python tracker
<https://bugs.python.org/issue42147>
___
___
Python-bug
Dong-hee Na added the comment:
> Sometimes the work of the core developer is to say "No" to his own code.
Thank you for the careful sentence.
For clear the air, I never think that my patch should be accepted.
This is why I always get reviews from other core devs and I
Change by Dong-hee Na :
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue42151>
___
___
Python-bugs-list mailing list
Unsubscribe:
Dong-hee Na added the comment:
Sorry for the offtopic
@methane
Looks like Inada san is the right expression. ;)
> But China and Korea don't reverse name.
This is a very intereting fact, the national system of Korea are using
surname-given name order or printing with a distinc sect
Dong-hee Na added the comment:
@pablogsal, @serhiy.storchaka
> I would advise against having more branching, especially for code that is
> rare:
About bpo-41902, I believe those patches affect all range objects which is
created with step is one .
I believe the usage of creation of
Dong-hee Na added the comment:
s / will not effort / will not be affected
--
___
Python tracker
<https://bugs.python.org/issue42147>
___
___
Python-bugs-list m
Dong-hee Na added the comment:
@methane
To be more precise, [[] for _ in range(1)] will not effort this patch
because range(1) does not create longrangeiter object.
This patch will affect to if the number is veeery large.
On the other hand, GH-22479 is affect to all index API
Dong-hee Na added the comment:
if somebody try to sum very large value with range.
sum(range(1 << 1000, (1 << 1000) + 100))
it can be affected by this patch.
--
___
Python tracker
<https://bugs.python
Change by Dong-hee Na :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue42145>
___
___
Python-bugs-list mailing list
Unsubscribe:
Dong-hee Na added the comment:
s/
I approach as same case that step=1 is quite a lot usecase until user designate
step value.
/My assumtion is that step=1 is quite often usecase until user designate step
value.
--
___
Python tracker
<ht
Dong-hee Na added the comment:
At bpo-41092, we decide not to optimize mulitply operation itself.
I approach as same case that step=1 is quite a lot usecase until user designate
step value.
If range with longobject is not that much use case, I can agree with your
opinion
Change by Dong-hee Na :
--
keywords: +patch
pull_requests: +21886
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/22971
___
Python tracker
<https://bugs.python.org/issu
New submission from Dong-hee Na :
This is a similar case with https://bugs.python.org/issue41902
A quite possible usecase when the user use range with big number
./python -m pyperf compare_to longrange_master.json longrange_opt.json
Mean +- std dev: [longrange_master] 6.45 us +- 0.09 us
Change by Dong-hee Na :
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue42132>
___
___
Python-bugs-list mailing list
Unsubscribe:
Dong-hee Na added the comment:
@gvanrossum, @taleinat
I've already provided the mimesniffing through PyPI ;)
https://pypi.org/project/mimesniff/
The interface is similar to imghdr.what :)
--
___
Python tracker
<https://bugs.python.org/issue40
Dong-hee Na added the comment:
I close this issue as rejected!
During the sprint, I could hear a lot of opinions from core devs including
Guido, Tal, and Christian.
The overall conclusion for me is not to add this time.
if the mimetypes module is extracted from stdlib to pypi package, we
Change by Dong-hee Na :
--
resolution: -> wont fix
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Dong-hee Na added the comment:
New changeset b52432cb8cd7f5f1fc71ea3b7c0ea11573d504f0 by Mark Shannon in
branch 'master':
bpo-42057: Add regression test to master. (GH-22893)
https://github.com/python/cpython/commit/b52432cb8cd7f5f1fc71ea3b7c0ea11573d504f0
--
nosy: +corona10
Dong-hee Na added the comment:
I am +1 on this idea.
--
___
Python tracker
<https://bugs.python.org/issue42111>
___
___
Python-bugs-list mailing list
Unsub
Change by Dong-hee Na :
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue42111>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Dong-hee Na :
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue42115>
___
___
Python-bugs-list mailing list
Unsubscribe:
Dong-hee Na added the comment:
> It would be better to fix copyreg._reduce_ex() instead of disabling pickling
> for these types one by one
I agree :)
--
___
Python tracker
<https://bugs.python.org/i
Change by Dong-hee Na :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Dong-hee Na added the comment:
New changeset c0f22fb8b3006936757cebb959cee94e285bc503 by Dong-hee Na in branch
'master':
bpo-41902: Micro optimization for range.index if step is 1 (GH-22479)
https://github.com/python/cpython/commit/c0f22fb8b3006936757cebb959cee94e285bc503
Change by Dong-hee Na :
--
nosy: +corona10, vstinner
___
Python tracker
<https://bugs.python.org/issue42087>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Dong-hee Na :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Dong-hee Na added the comment:
Okay this is the theme bug.
https://github.com/python/python-docs-theme/pull/57
--
___
Python tracker
<https://bugs.python.org/issue42
Change by Dong-hee Na :
--
title: docs.python.org for 3.10 missing the new refererence record. -> sphinx3
renders diffrently docs.python.org for 3.10
___
Python tracker
<https://bugs.python.org/issu
Dong-hee Na added the comment:
One more regression is that
code background highlight is not applied after sphinx version3
See
https://docs.python.org/3.10/c-api/dict.html#c.PyDict_Next
https://docs.python.org/3.9/c-api/dict.html#c.PyDict_Next
--
stage: patch review
Change by Dong-hee Na :
--
nosy: +Mariatta
___
Python tracker
<https://bugs.python.org/issue42042>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Dong-hee Na :
--
keywords: +patch
pull_requests: +21702
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/22739
___
Python tracker
<https://bugs.python.org/issu
Dong-hee Na added the comment:
sphinx2
(Pdb) par[0].attributes
{'ids': ['c._PyObject_New'], 'classes': [], 'names': ['c._PyObject_New'],
'dupnames': [], 'backrefs': [], 'first': False}
sphinx3
(Pdb) par[0].attributes
{'ids': ['c._PyObject_New'], 'classes': [], 'names': [], 'dupnames
Dong-hee Na added the comment:
This is the regression bug caused by sphinx==3.2.1
If we roll back the sphinx version(2.4.4), it is okay.
I am investigating what causes this issue.
--
___
Python tracker
<https://bugs.python.org/issue42
Dong-hee Na added the comment:
New changeset 644e94272a89196801825cb69a56377bf62d256a by Erlend Egeberg
Aasland in branch 'master':
bpo-42021: Fix possible ref leaks during _sqlite3 module init (GH-22673)
https://github.com/python/cpython/commit/644e94272a89196801825cb69a56377bf62d256a
New submission from Dong-hee Na :
For example
https://docs.python.org/3.10/c-api/bool.html?highlight=pydict_new#c.PyDict_New
should display
`Return value: New reference.`
but not, this looks like a regression bug.
other version display `Return value: New reference.` very well
Dong-hee Na added the comment:
@ZackerySpytz Thank you for work :)
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Dong-hee Na added the comment:
New changeset 76b1913daf883b6592815d139f62f3a7fbe3c322 by Dong-hee Na in branch
'3.8':
[3.8] bpo-32793: Fix a duplicate debug message in smtplib (GH-15341) (GH-22683)
https://github.com/python/cpython/commit/76b1913daf883b6592815d139f62f3a7fbe3c322
Dong-hee Na added the comment:
> Also, see the comment from Victor here:
> https://github.com/python/cpython/pull/22478#issuecomment-702201260
Okay got it
--
___
Python tracker
<https://bugs.python.org/i
Change by Dong-hee Na :
--
versions: -Python 3.7
___
Python tracker
<https://bugs.python.org/issue32793>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Dong-hee Na :
--
pull_requests: +21655
pull_request: https://github.com/python/cpython/pull/22683
___
Python tracker
<https://bugs.python.org/issue32
Dong-hee Na added the comment:
3.7 only can be applied security fix.
https://cpython-devguide.readthedocs.io/#branchstatus
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue32
Dong-hee Na added the comment:
What's the purpose of using AC, did the change improve performance?
It can make hard to track the code history.
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue40
Change by Dong-hee Na :
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue41972>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Dong-hee Na :
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue41971>
___
___
Python-bugs-list mailing list
Unsubscribe:
Dong-hee Na added the comment:
Thank you Victor!
--
resolution: fixed ->
stage: resolved -> patch review
status: closed -> open
___
Python tracker
<https://bugs.python.or
Change by Dong-hee Na :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Dong-hee Na :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Dong-hee Na added the comment:
New changeset d646e91f5c4f4b76f96494103d440ed0b6257425 by Dong-hee Na in branch
'master':
bpo-41922: Use PEP 590 vectorcall to speed up reversed() (GH-22523)
https://github.com/python/cpython/commit/d646e91f5c4f4b76f96494103d440ed0b6257425
Change by Dong-hee Na :
--
keywords: +patch
pull_requests: +21529
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/22523
___
Python tracker
<https://bugs.python.org/issu
Change by Dong-hee Na :
--
assignee: -> corona10
___
Python tracker
<https://bugs.python.org/issue41922>
___
___
Python-bugs-list mailing list
Unsubscrib
New submission from Dong-hee Na :
reversed is also a very well-used type.
if shows 10+ percent performance improvement from baseline and this metric.
And this improvement looks acceptable from viewing builtin types which are
applied PEP 590 (frozenset, list, set, dict)
reversed creation
Change by Dong-hee Na :
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue7946>
___
___
Python-bugs-list mailing list
Unsubscribe:
Dong-hee Na added the comment:
@vstinner @pablo @mark
On my local machine (without cpu isolation),
PR 22480 does not affect performance issues.
import pyperf
runner = pyperf.Runner()
runner.timeit(name="bench long divide",
stmt="""
for i in range(1,
Change by Dong-hee Na :
--
pull_requests: +21509
pull_request: https://github.com/python/cpython/pull/22492
___
Python tracker
<https://bugs.python.org/issue41
Dong-hee Na added the comment:
Mean +- std dev: [master-compute] 317 ns +- 3 ns -> [bpo-41902-compute] 287 ns
+- 6 ns: 1.11x faster (-10%)
--
___
Python tracker
<https://bugs.python.org/issu
Dong-hee Na added the comment:
I found another optimal case and this looks more practical usecase than
range.index
--
Added file: https://bugs.python.org/file49485/bench_range_compute_item.py
___
Python tracker
<https://bugs.python.org/issue41
Dong-hee Na added the comment:
> s there reason to believe that range.index is performed often enough that
> it's worth the extra code and maintenance cost here?
There are at least 3 reasons
1. pointer comparaition optimization quite common usecase in CPython codebase.
e.x) list.c
Dong-hee Na added the comment:
PR 22479 and PR 22480 are different approaches.
I (and Victor) want to check which approach might be better.
PR 22480 would affect overall long division performance
PR 22479 assumes that step=1 case is very often (e.g range(100), range(-100,
100
Change by Dong-hee Na :
--
pull_requests: +21498
pull_request: https://github.com/python/cpython/pull/22480
___
Python tracker
<https://bugs.python.org/issue41
Dong-hee Na added the comment:
For the record with optimization
Mean +- std dev: [range_master] 112 ns +- 3 ns -> [range_opt] 99.3 ns +- 1.8
ns: 1.13x faster (-12%)
--
___
Python tracker
<https://bugs.python.org/issu
Dong-hee Na added the comment:
> do you build Python with PGO+LTO optimizations
Nope, but I will try to run the benchmark
> What is your OS and CPU? Do you use CPU isolation on Linux?
macOS, intel i9 with 8 cores
--
___
Python tracker
Dong-hee Na added the comment:
For practical use case
>>> a = range(-2, 10)
>>> a.index(2)
--
___
Python tracker
<https://bugs.python.org/issue41902>
___
__
Dong-hee Na added the comment:
For optimization case,
>>> a = range(0, 1)
>>> a.index(3)
3
--
___
Python tracker
<https://bugs.
Change by Dong-hee Na :
--
keywords: +patch
pull_requests: +21496
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/22479
___
Python tracker
<https://bugs.python.org/issu
Change by Dong-hee Na :
Added file: https://bugs.python.org/file49483/bench_range_step.py
___
Python tracker
<https://bugs.python.org/issue41902>
___
___
Python-bug
New submission from Dong-hee Na :
if we declare range without setting step, we don't have to process divide
operation.
here is the benchmark result both setting step and without step,
With my patch, there is no performance degrade with range.index when the step
is not one and showing 19
Dong-hee Na added the comment:
Now the suggestion is applied!
Thank you Pablo and Victor!!!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Dong-hee Na added the comment:
New changeset fa7ce080175f65d678a7d5756c94f82887fc9803 by Dong-hee Na in branch
'master':
bpo-41870: Avoid the test when nargs=0 (GH-22462)
https://github.com/python/cpython/commit/fa7ce080175f65d678a7d5756c94f82887fc9803
Change by Dong-hee Na :
--
pull_requests: +21488
pull_request: https://github.com/python/cpython/pull/22462
___
Python tracker
<https://bugs.python.org/issue41
Change by Dong-hee Na :
--
pull_requests: -21486
___
Python tracker
<https://bugs.python.org/issue41870>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Dong-hee Na :
--
pull_requests: +21486
pull_request: https://github.com/python/cpython/pull/22460
___
Python tracker
<https://bugs.python.org/issue41
Dong-hee Na added the comment:
Now float() is faster!
Thank you for your contribution, Dennis :)
And thank you Victor as co-reviewer!
--
nosy: +vstinner
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Pytho
Dong-hee Na added the comment:
New changeset e8acc355d430b45f1c3ff83312e72272262a854f by Dennis Sweeney in
branch 'master':
bpo-41873: Add vectorcall for float() (GH-22432)
https://github.com/python/cpython/commit/e8acc355d430b45f1c3ff83312e72272262a854f
--
nosy: +corona10
Dong-hee Na added the comment:
New changeset 24ba3b0df5e5f2f237d7b23b4017ba12f16320ae by Dong-hee Na in branch
'master':
bpo-41875: Use __builtin_unreachable when possible (GH-22433)
https://github.com/python/cpython/commit/24ba3b0df5e5f2f237d7b23b4017ba12f16320ae
Dong-hee Na added the comment:
Now I close this issue.
Thank you, Mark!
--
nosy: +Mark.Shannon
___
Python tracker
<https://bugs.python.org/issue41870>
___
___
Dong-hee Na added the comment:
New changeset a195bceff7b552c5f86dec7894ff24dcc87235da by Dong-hee Na in branch
'master':
bpo-41870: Use PEP 590 vectorcall to speed up bool() (GH-22427)
https://github.com/python/cpython/commit/a195bceff7b552c5f86dec7894ff24dcc87235da
Dong-hee Na added the comment:
I am able to reproduce this issue on my gcc 4.4.7
root@ef9b356a9deb:/home/cpython# gcc --version
gcc (Ubuntu/Linaro 4.4.7-8ubuntu7) 4.4.7
Copyright (C) 2010 Free Software Foundation, Inc.
This is free software; see the source for copying conditions
Change by Dong-hee Na :
--
versions: +Python 3.10
___
Python tracker
<https://bugs.python.org/issue41875>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Dong-hee Na :
--
nosy: +serhiy.storchaka, vstinner
___
Python tracker
<https://bugs.python.org/issue41875>
___
___
Python-bugs-list mailing list
Unsub
Change by Dong-hee Na :
--
keywords: +patch
pull_requests: +21464
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/22433
___
Python tracker
<https://bugs.python.org/issu
Change by Dong-hee Na :
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue41875>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Dong-hee Na :
--
components: +Interpreter Core
___
Python tracker
<https://bugs.python.org/issue41870>
___
___
Python-bugs-list mailing list
Unsub
Change by Dong-hee Na :
--
keywords: +patch
pull_requests: +21461
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/22427
___
Python tracker
<https://bugs.python.org/issu
New submission from Dong-hee Na :
bool type is well-used builtin types, I noticed that if we use vector call to
bool type, it shows the awesome performance enhancement.
Mean +- std dev: [master] 91.4 us +- 3.3 us -> [vectorcall] 48.6 us +- 3.1 us:
1.88x faster (-47%)
--
assig
Dong-hee Na added the comment:
see also: https://bugs.python.org/issue40686
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue41864>
___
___
Dong-hee Na added the comment:
New changeset 2afd1751dd9a35d4ec03b708e3e5cddd72c43f7e by Dong-hee Na in branch
'master':
bpo-1635741: Port _bisect module to multi-phase init (GH-22415)
https://github.com/python/cpython/commit/2afd1751dd9a35d4ec03b708e3e5cddd72c43f7e
Change by Dong-hee Na :
--
pull_requests: +21451
pull_request: https://github.com/python/cpython/pull/22415
___
Python tracker
<https://bugs.python.org/issue1635
Change by Dong-hee Na :
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue41797>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Dong-hee Na :
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue41739>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Dong-hee Na :
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue41832>
___
___
Python-bugs-list mailing list
Unsubscribe:
Dong-hee Na added the comment:
see https://bugs.python.org/issue41229
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue40213>
___
___
Pytho
Dong-hee Na added the comment:
@rhettinger
I like the idea to add more informative information,
However, since the type is the structsequence the change can cause the
ValueError: too many values to unpack when the variable is used as a tuple.
But the if such use case is not often used
Change by Dong-hee Na :
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue40915>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Dong-hee Na :
--
pull_requests: +21353
pull_request: https://github.com/python/cpython/pull/22305
___
Python tracker
<https://bugs.python.org/issue35
Change by Dong-hee Na :
--
assignee: -> corona10
___
Python tracker
<https://bugs.python.org/issue35293>
___
___
Python-bugs-list mailing list
Unsubscrib
Dong-hee Na added the comment:
/home/travis/virtualenv/python3.6.10/lib/python3.6/site-packages/sphinx/util/nodes.py:151:
FutureWarning:
The iterable returned by Node.traverse()
https://travis-ci.com/github/python/cpython/jobs/386971271
The issue is still left, I am going
701 - 800 of 1592 matches
Mail list logo
