Eduardo Seabra added the comment:
I've added three lines to cls.code to test_hyperparser. So I can test for
subscripts with double quotes, single quotes and with no strings at all.
Should I implement try_open_completions_event for COMPLETE_DICTIONARY? Calling
this event everytime someone
Eduardo Seabra added the comment:
From the example, I couldn't know if the patch should also autocomplete int
and other types. So here's a patch that autocompletes string dictionary keys.
I'm new contributing so let me know if I made anything wrong and I'll fix as
soon as possible
Eduardo Seabra added the comment:
Berker Peksag, I don't think your patch is okay.
When symlinks is set to true, it should copy the symbolic link of the
directory. Your code is calling copytree instead.
I think the following patch is working, no errors on regression tests.
--
nosy
Eduardo Seabra added the comment:
I've attached a patch with @mmarkk proposal.
--
keywords: +patch
nosy: +Eduardo.Seabra
Added file: http://bugs.python.org/file35662/issue21579.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Eduardo Seabra added the comment:
I've also increased the test coverage of filecmp.py. Don't know if I should
merge my patch with Alex.Volkov's patch. I'm uploading it as a separate patch.
--
nosy: +Eduardo.Seabra
Added file: http://bugs.python.org/file32801/test_filecmp.patch