Eli Bendersky added the comment:
Here's a patch adding documentation to the *Interface classes.
I must say I'm not very psyched about the with_* methods. Their outputs are
inconsistent, unlike in *Network, where all return strings.
--
Eli Bendersky added the comment:
Sarbjit: first of all, look at the up-to-date documentation for 3.3 (it's
available online at http://docs.python.org/dev/
Then, on a checkout of the 3.3 code (default branch) you can apply Daniel's
patch (it's in the "Files" section i
Changes by Eli Bendersky :
--
nosy: -eli.bendersky
___
Python tracker
<http://bugs.python.org/issue15231>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
My job is done here. Éric - assigning to you for distutils2, once it becomes
relevant.
--
assignee: docs@python -> eric.araujo
___
Python tracker
<http://bugs.python.org/issu
Eli Bendersky added the comment:
Sarbjit, if you look at the docs of 3.3, I think most of what you're asking for
is there (especially once you count Daniel's commit). What else is missing in
your opinion?
--
___
Python trac
Changes by Eli Bendersky :
--
versions: +Python 2.7
___
Python tracker
<http://bugs.python.org/issue15586>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
I provided some comments on your patch in the code-review tool. Thanks for the
contribution, Daniel. It's fine to first apply these changes to 3.3 and then
backport to 2.7 (I don't think 3.2 is necessary because most users use the
online d
Changes by Eli Bendersky :
--
versions: +Python 2.7, Python 3.3, Python 3.4
___
Python tracker
<http://bugs.python.org/issue15586>
___
___
Python-bugs-list mailin
Eli Bendersky added the comment:
Please note that the documentation of ET has been significantly improved in
3.3, with added examples, etc. You can start by backporting whatever is
relevant to earlier versions (2.7/3.2) - do not add new documentation contents
to 2.7/3.2 before the changes
Changes by Eli Bendersky :
--
nosy: +eli.bendersky
___
Python tracker
<http://bugs.python.org/issue15572>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
Nick, your commit incorporates my latest patch (ipaddr_refdoc_network.2.patch),
right?
--
___
Python tracker
<http://bugs.python.org/issue14
Eli Bendersky added the comment:
Backported in 014b36383a54 and 29bdbcadf299
--
___
Python tracker
<http://bugs.python.org/issue15231>
___
___
Python-bugs-list m
Eli Bendersky added the comment:
Attaching an updated patch that completes the documentation of network objects
(attributes, methods and operations). Additionally, inserted the "provisional
package" note and a "new in 3.3" notice.
--
Added file: http://bugs.
Eli Bendersky added the comment:
Attaching part 1 of the patch for documenting the network objects. Contains
general introduction, detailed documentation of constructors and all attributes.
Left to document: methods, operations (like iterating, "in", comparison
operators)
--
Eli Bendersky added the comment:
By the way, Nick, was not this module intended to be introduced as provisional
in 3.3? At least PEP 411 lists it as one of the candidates.
--
___
Python tracker
<http://bugs.python.org/issue14
Eli Bendersky added the comment:
Thanks Nick. I've addressed your review comments and will be pushing the doc
update.
--
___
Python tracker
<http://bugs.python.org/is
Eli Bendersky added the comment:
Alright, attaching an attempt at improving the reference docs. This only
handles the address objects for now:
1. Grouping address objects together, network objects together, interface
objects together
2. Explain that everything IPv4Address exposes is also
Eli Bendersky added the comment:
I disagree about the HOWTO vs. doc thing, but I don't see it as a major issue
so I won't dwell on it.
I'm now in the process of throwing together a patch for the reference doc -
also bundling the address objects together, the network object
Eli Bendersky added the comment:
The docs don't mention that addresses can also be packed in bytes
--
___
Python tracker
<http://bugs.python.org/is
Eli Bendersky added the comment:
FWIW I would prefer this HOWTO to be part of the document itself. Splitting a
document to two parts and keeping them separated is problematic exactly for the
same reasons as external documentation in general - it can be forgotten when
things get updated
Eli Bendersky added the comment:
Attaching a patch for the howto
--
Added file: http://bugs.python.org/file26612/ipaddr_howto.1.patch
___
Python tracker
<http://bugs.python.org/issue14
Eli Bendersky added the comment:
Ah, probably hosts() replaced iterhosts()
--
___
Python tracker
<http://bugs.python.org/issue14814>
___
___
Python-bugs-list m
Eli Bendersky added the comment:
P.S. I intend to prepare patch(es) eventually, but I will document the problems
I find here, in case anyone is interested to discuss.
--
___
Python tracker
<http://bugs.python.org/issue14
Eli Bendersky added the comment:
I'm looking at the docs. Started with the HOWTO (Doc/howto/ipaddress.rst)
This example:
>>> net4 = ipaddress.ip_network('192.0.2.0/24')
>>> for x in net4.iterhosts():
print(x)
Seems to be wrong:
...
Traceback (most rec
Eli Bendersky added the comment:
Yes, if the new phrasing looks OK I will backport to 3.2 & 2.7
--
___
Python tracker
<http://bugs.python.org/issue15231>
___
Eli Bendersky added the comment:
I've committed a rephrase [the Misc/NEWS entry is IMHO unnecessary for tiny
documentation clarifications].
Since there's no distutils2/packaging in 3.3 at the moment, I think we're done.
Éric - would you like to keep this issue alive to rememb
Eli Bendersky added the comment:
Feel free to change it, I don't mind. I think the intention is clear anyway.
--
___
Python tracker
<http://bugs.python.org/is
Eli Bendersky added the comment:
Éric - what is missing?
--
___
Python tracker
<http://bugs.python.org/issue15231>
___
___
Python-bugs-list mailing list
Unsub
Eli Bendersky added the comment:
I think it can go into 3.3 but only if it gets reviewed by another core dev
(we're in release candidate stage now). Senthil - can you review the patch
together with me?
As for customizing the stream, yes, go ahead and open a new issue for it, and
a
Eli Bendersky added the comment:
Makes sense. I agree that publicly exposing the left/right attributes makes
sense. But let's do it properly:
1. Add an example to the documentation
2. Add some tests to Lib/test/test_filecmp.py that verify these attributes
behave as expected
In additi
Eli Bendersky added the comment:
Committed in f315cfa22630
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Eli Bendersky added the comment:
Sorry about the commit message. Ignore it, I got the issue number wrong :)
--
nosy: +eli.bendersky
___
Python tracker
<http://bugs.python.org/issue15
Changes by Eli Bendersky :
--
nosy: -eli.bendersky
___
Python tracker
<http://bugs.python.org/issue15321>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
The patch looks reasonable to me. Martin/Éric - any objections to committing?
--
nosy: +eli.bendersky
___
Python tracker
<http://bugs.python.org/issue15
New submission from Eli Bendersky :
The default ignore list of filecmp.dircmp is ['RCS', 'CVS', 'tags'].
This predates even Subversion! I suggest to freshen up this module to also
ignore the dirs for SVN, Mercurial, Git and Bazaar.
[this is a new f
Eli Bendersky added the comment:
Yes, code samples would help clarifying the rationale for this request
--
nosy: +eli.bendersky
versions: +Python 3.4 -Python 3.3
___
Python tracker
<http://bugs.python.org/issue15
Eli Bendersky added the comment:
Even if this is a problem at all, it's certainly not something that must be
fixed by 3.3
--
versions: +Python 3.4 -Python 3.3
___
Python tracker
<http://bugs.python.org/i
Changes by Eli Bendersky :
--
nosy: -eli.bendersky
___
Python tracker
<http://bugs.python.org/issue1470548>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eli Bendersky :
--
assignee: eli.bendersky ->
___
Python tracker
<http://bugs.python.org/issue15381>
___
___
Python-bugs-list mailing list
Unsubscri
Eli Bendersky added the comment:
I'd like to take a shot at this, if Antoine doesn't mind. I'll prepare a patch
for bytesio.c
Question: what set of benchmarks would it be good to run to make sure this
doesn't degrade the performance of BytesIO in various cases?
Eli Bendersky added the comment:
I wonder if this is a fair comparison, Serhiy. Strings are unicode underneath,
so they have a large overhead per string (more data to copy around). Increasing
the length of the strings changes the game because due to PEP 393, the overhead
for ASCII-only
Eli Bendersky added the comment:
Frankly, I don't think the problem is serious enough to warrant a backport to
3.2, given that 3.3 gonna be out in a few weeks. The issue was open for 5 years
without anyone seriously complaining :)
--
___
P
Eli Bendersky added the comment:
This optimization for StringIO was done in issue #13149
--
___
Python tracker
<http://bugs.python.org/issue15381>
___
___
Pytho
New submission from Eli Bendersky :
>From this pydev thread:
>http://mail.python.org/pipermail/python-dev/2012-July/120981.html
"BytesIO is actually missing an optimisation that is already used in
StringIO: the StringIO C implementation uses a fragment accumulator
internally, an
Eli Bendersky added the comment:
Committed fixes to raise ImportError in both Python 3.2 and 3.3
At the moment no test added because I'm having trouble using
import_fresh_module to avoid re-importing of pyexpat in the etree tests (it
gets imported a
Eli Bendersky added the comment:
Benjamin, what "old behavior"? Did it happen to raise ImportError historically
and only recent changes made it RuntimeError? I'm not sure this is the case.
--
___
Python tracker
<http://bugs.pyt
Eli Bendersky added the comment:
I tried blocking the import of 'pyexpat' in a test by using
test.support.import_fresh_module, placing 'pyexpat' into the blocked list, but
it doesn't work (i.e. pyexpat, if it
Eli Bendersky added the comment:
I agree. Any improvement is preferred over just letting this decay in the issue
tracker ;-)
--
___
Python tracker
<http://bugs.python.org/issue14
Eli Bendersky added the comment:
I posted a message to python-dev about the performance issue
--
___
Python tracker
<http://bugs.python.org/issue1767933>
___
___
Eli Bendersky added the comment:
Fixed the invariant violation in changeset 64ff90e07d71
I'll review the performance difference separately
--
___
Python tracker
<http://bugs.python.org/issu
Changes by Eli Bendersky :
--
nosy: -eli.bendersky
___
Python tracker
<http://bugs.python.org/issue13997>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eli Bendersky :
--
nosy: -eli.bendersky
___
Python tracker
<http://bugs.python.org/issue10685>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eli Bendersky :
--
nosy: -eli.bendersky
___
Python tracker
<http://bugs.python.org/issue13386>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
ping
--
___
Python tracker
<http://bugs.python.org/issue14332>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eli Bendersky :
--
nosy: -eli.bendersky
___
Python tracker
<http://bugs.python.org/issue9325>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eli Bendersky :
--
nosy: -eli.bendersky
___
Python tracker
<http://bugs.python.org/issue10342>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eli Bendersky :
--
nosy: -eli.bendersky
___
Python tracker
<http://bugs.python.org/issue9914>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eli Bendersky :
--
nosy: -eli.bendersky
___
Python tracker
<http://bugs.python.org/issue10908>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eli Bendersky :
--
versions: -Python 3.3
___
Python tracker
<http://bugs.python.org/issue15083>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
I agree, but this will now be delayed to 3.4, since it's not a bug-fixing
change in functionality.
P.S. is there any way to create a test for it?
--
assignee: -> eli.bendersky
priority: normal -> low
type: -> behavior
versions
Eli Bendersky added the comment:
I'd also expand the doc of register_namespace to note what it should and
shouldn't be used for (once this feature is added).
--
___
Python tracker
<http://bugs.python.o
Eli Bendersky added the comment:
I'm changing the issue name to reflect the direction it's taken. Florent, once
3.3 is branched, could you please refresh the patch vs. head for 3.4 (don't
forget the "what's new") and I'll review it for commit.
-
Eli Bendersky added the comment:
About (1):
It's customary for Python to accept "truthful" values (like non-empty strings)
as True. I see no harm in that. Strict type-checking to boolean True in each
and every place is not necessary.
About (2):
Similarly, this isn't pr
Eli Bendersky added the comment:
I agree with Serhiy that this is more of a documentation/understanding issue
than a real bug. I've clarified the doc of ElementTree.write a bit to make it
explicit what stream is expected for 'write'.
--
assignee: -> docs
Eli Bendersky added the comment:
Closing, as I don't think it's terribly important to backport this.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.py
Eli Bendersky added the comment:
Serhiy, can you also take a look at #9458 - it may be related?
--
___
Python tracker
<http://bugs.python.org/issue1767
Eli Bendersky added the comment:
Done (except 5 and 6, which are non-issues on a second look)
--
status: open -> closed
versions: +Python 3.3 -Python 2.7
___
Python tracker
<http://bugs.python.org/issu
Eli Bendersky added the comment:
Fixed in 3.3
Thanks for the patch
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue15296>
___
___
Py
Eli Bendersky added the comment:
Switching this to 3.3 only
Fixes for 1-3 committed in caea3c64442b
--
___
Python tracker
<http://bugs.python.org/issue13
Eli Bendersky added the comment:
Eric: your note appears to be fixed in the code.
Can this issue be closed?
--
nosy: +eli.bendersky
___
Python tracker
<http://bugs.python.org/issue14
Changes by Eli Bendersky :
--
priority: -> deferred blocker
___
Python tracker
<http://bugs.python.org/issue14790>
___
___
Python-bugs-list mailing list
Un
Eli Bendersky added the comment:
Serhiy - why did you remove that documentation bit?
--
___
Python tracker
<http://bugs.python.org/issue15296>
___
___
Python-bug
Eli Bendersky added the comment:
Thanks, this looks much better. I've reviewed the _4 patch with some minor
comments.
--
___
Python tracker
<http://bugs.python.org/issu
Eli Bendersky added the comment:
Can this be honestly classified as a bugfix though? If it's a feature it will
have to be postponed to 3.4
--
___
Python tracker
<http://bugs.python.org/is
Eli Bendersky added the comment:
Thanks for your work on this, Serhiy. I made some comments in the code-review
tool, mainly about the complexity of the resulting code.
Great work on switching the tests to unittest, much appreciated.
--
___
Python
Eli Bendersky added the comment:
I see no harm in modifying the signature of the private _serialize_* functions
to accept another argument or dict of options.
--
___
Python tracker
<http://bugs.python.org/issue14
Changes by Eli Bendersky :
--
components: +Library (Lib)
stage: -> test needed
versions: +Python 3.4 -Python 3.2
___
Python tracker
<http://bugs.python.org/issu
Eli Bendersky added the comment:
Please make sure that the patch(es) apply cleanly to 3.3, since this is the
version I'll be focusing on.
--
___
Python tracker
<http://bugs.python.org/i
Eli Bendersky added the comment:
Serhiy, note that _SimpleElementPath is now gone in 3.3, since ElementPath.py
is always there in stdlib. Could you update the patch to reflect this?
Another thing. I'm trying really hard to phase out the doctest tests of etree,
replacing them with uni
Changes by Eli Bendersky :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue14202>
___
___
Python-bugs-list mailing list
Unsubscri
Eli Bendersky added the comment:
I will try to find time to review it before the fork, but since time is tight I
don't promise.
That said, this patch falls more into the bugfix category than a new feature,
so I think it will be OK after beta as
Changes by Eli Bendersky :
--
nosy: +eli.bendersky
___
Python tracker
<http://bugs.python.org/issue13823>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eli Bendersky :
--
nosy: +eli.bendersky
___
Python tracker
<http://bugs.python.org/issue9458>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eli Bendersky :
--
nosy: +eli.bendersky
___
Python tracker
<http://bugs.python.org/issue1767933>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
Martin, thanks for the explanation. The patch LGTM, then.
Could it be useful to document this a bit more explicitly in the description of
sys.getsizeof? The most intuitive thing to expect from it is to compute the
*total* size including contained objects. So
Eli Bendersky added the comment:
Out of curiosity, why don't the constituents of Element (i.e. the tag, the
attributes dict, etc.) count for its size?
--
___
Python tracker
<http://bugs.python.org/is
Eli Bendersky added the comment:
No need, the cause for the segfault is known. What happens is that Element
objects from the Python module get intermixed with Element objects from the C
module, and these are incompatible. The C module traversal functions assume
they can cast Elements to a
Eli Bendersky added the comment:
Opened #15083 to track the *actual* solution to this problem, which should
restructure the tests to be safer.
--
superseder: -> Rewrite ElementTree tests in a cleaner and safer way
___
Python tracker
&l
New submission from Eli Bendersky :
As #15075 demonstrated, the ET tests are sensitive to execution order because
of the way they operate.
Two sets of tests (one for the C module and one for the pure Python module)
operate from the same test code, monkey-patching the imported module. This
Eli Bendersky added the comment:
Here is a patch that solves the current problem.
A longer term solution would be to have a cleaner test plan for ET in general,
without monkey-patching at all, and without state that causes test-order
dependencies.
--
keywords: +patch
Added file
Eli Bendersky added the comment:
As suspected, the cause is that xinclude_loader manages to somehow import the C
version of ET, although test_xml_etree tries to enforce the Python version.
This is probably because test___all__ imports all modules and leaves stuff in
the import cache.
What
Eli Bendersky added the comment:
After some tinkering I found which test when run before test_xml_etree causes
it to crash:
$ ./python -m test.regrtest test___all__ test_xml_etree
[1/2] test___all__
[2/2] test_xml_etree
Fatal Python error: Segmentation fault
Current thread 0x7f771ecec700
New submission from Eli Bendersky :
The XincludeTest test-case in test_xml_etree is now skipped, because it fails
in an intermittent manner. I can reproduce the failure when running full
regrtest with -j1, but not -j8, and not when run individually.
The failure is most likely due to the test
Eli Bendersky added the comment:
Note: last traces of Python bootstrap code were removed from _elementtree in
changeset 652d148bdc1d
--
___
Python tracker
<http://bugs.python.org/issue13
Eli Bendersky added the comment:
This looks rejected to me. Any opposition to closing the issue?
--
___
Python tracker
<http://bugs.python.org/issue14
Eli Bendersky added the comment:
Agree with Serhiy. Why are these flags required in Element?
Also, I'm moving this to 3.4 since the patch came too late in the 3.3 process -
the first beta is very soon, after which we prefer not to add new features.
--
priority: normal -> l
Changes by Eli Bendersky :
--
nosy: -eli.bendersky
___
Python tracker
<http://bugs.python.org/issue12907>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eli Bendersky :
--
nosy: -eli.bendersky
___
Python tracker
<http://bugs.python.org/issue13455>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eli Bendersky :
--
nosy: -eli.bendersky
___
Python tracker
<http://bugs.python.org/issue14097>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eli Bendersky :
--
nosy: -eli.bendersky
___
Python tracker
<http://bugs.python.org/issue1040439>
___
___
Python-bugs-list mailing list
Unsubscribe:
501 - 600 of 1229 matches
Mail list logo