Eric Smith e...@trueblade.com added the comment:
No, it won't be backported to 2.6. It's clearly a new feature.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1578269
Eric Smith e...@trueblade.com added the comment:
My concern about testing is that we're adding a feature that won't be tested by
the buildbots. Although I don't have any suggestions (other than possibly
adding the specific permission to the buildbots).
If there is a skip test, it should
Eric Smith e...@trueblade.com added the comment:
Assigning to Raymond, per his request in the c.l.p. thread.
--
assignee: georg.brandl - rhettinger
nosy: +eric.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7734
Eric Smith e...@trueblade.com added the comment:
Yes, Run as administrator solves the permissions problem, leaving an error in
test_posixpath that I'll investigate.
What's the expectations with the buildbots? Will these tests work there? We
could create a branch and run a buildbot test
Eric Smith e...@trueblade.com added the comment:
I'm indeed seeing the same test_posixpath errors that Jason reported.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1578269
Eric Smith e...@trueblade.com added the comment:
I don't see where the patch is outdated.
I'm attaching an updated patch 18 that works cleanly against r77557. It also
fixes an unterminated comment.
XP runs correctly (without the new functionality) with this patch. However, on
Windows 7
Eric Smith e...@trueblade.com added the comment:
It looks correct to me, assuming this comment is correct:
/* scan back until we hit a nonzero digit. significant digit 'i'
is s0[i] if i nd0, s0[i+1] if i = nd0. */
I didn't verify the comment itself
Eric Smith e...@trueblade.com added the comment:
I have a few minor comments posted on Rietveld, but nothing that would keep you
from checking this in.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7632
Eric Smith e...@trueblade.com added the comment:
Is the intention to write Decimal.__format__ in C, too? That would be quite a
bit of work, and I'm not sure I could recommend it. But I'm not sure if your
plan is to get rid of all Python code or not.
If your plan is to rewrite absolutely
Eric Smith e...@trueblade.com added the comment:
There's no perfect answer. And since we've gotten this far without anyone
caring, and 2.7 is basically the end of life for this issue, perhaps doing
nothing is the best course. Any change we make will affect code that runs in
both 2.6 and 2.7
Changes by Eric Smith e...@trueblade.com:
--
nosy: +eric.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7649
___
___
Python-bugs-list mailing
Eric Smith e...@trueblade.com added the comment:
This looks like a signed vs. unsigned char problem. What platform are you on?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7649
Changes by Eric Smith e...@trueblade.com:
--
nosy: +doerwalter
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7649
___
___
Python-bugs-list mailing
Eric Smith e...@trueblade.com added the comment:
Shouldn't it work the same as it does for integers?
u'%c' % 0x7f
u'\x7f'
u'%c' % '\x7f'
u'\x7f'
u'%c' % 0x80
u'\x80'
u'%c' % '\x80'
u'\uff80'
That would imply to me it shouldn't be an error, it should just return u'\x80
Changes by Eric Smith e...@trueblade.com:
--
keywords: +easy
priority: high - normal
stage: test needed - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7649
Changes by Eric Smith e...@trueblade.com:
--
nosy: +eric.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7641
___
___
Python-bugs-list mailing
Eric Smith e...@trueblade.com added the comment:
This is a duplicate of issue 5965.
--
resolution: - duplicate
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7641
Changes by Eric Smith e...@trueblade.com:
--
nosy: +eric.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7622
___
___
Python-bugs-list mailing
Eric Smith e...@trueblade.com added the comment:
I'm testing on a Fedora Core 6 i386 box and an Intel Mac 32-bit 10.5 box. I
only see this on debug builds. I've tested trunk, py3k, release31-maint, and
release26-maint (just for giggles).
The error shows up in debug builds of trunk, py3k
Eric Smith e...@trueblade.com added the comment:
I think we should use whatever style is currently being used in the code. If we
want to go back through this code (or any other code) and PEP7-ify it, that
should be a separate task.
Alternately, we could PEP7-ify it first, then apply
Changes by Eric Smith e...@trueblade.com:
--
nosy: +eric.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7566
___
___
Python-bugs-list mailing
Eric Smith e...@trueblade.com added the comment:
With patch 17 all tests pass on XP. I'm (still) working on getting a
Windows 7 environment to test there.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1578269
Eric Smith e...@trueblade.com added the comment:
It's in the last sentence of this section:
http://www.python.org/doc/faq/general/#why-doesn-t-python-have-a-with-statement-for-attribute-assignments
--
___
Python tracker rep...@bugs.python.org
http
Eric Smith e...@trueblade.com added the comment:
This is a duplicate of issue 7455.
--
nosy: +eric.smith
resolution: - duplicate
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7542
Eric Smith e...@trueblade.com added the comment:
I can reproduce it on a Fedora (fc6) Linux box. It's not a decimal
problem, but a plain locale problem:
import locale
locale.setlocale(locale.LC_NUMERIC, 'fi_FI')
'fi_FI'
locale.localeconv()
Traceback (most recent call last):
File stdin
Eric Smith e...@trueblade.com added the comment:
I apologize (again) Jason, for taking forever to move forward on this.
With patch 16 on XP, I get this error on test_platform:
==
ERROR: test_architecture_via_symlink (__main__
Eric Smith e...@trueblade.com added the comment:
I can duplicate this on Fedora Core 6, x86, r76872. I simplified the
command line down to:
./python Lib/test/regrtest.py -j1 -v test_format
(and any value for j = 1 causes the error).
--
nosy: +eric.smith
title: test_format
Eric Smith e...@trueblade.com added the comment:
8.1.2 does start with Starting in Python 2.6, although I suppose there
could be a versionadded tag.
--
nosy: +eric.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7527
Eric Smith e...@trueblade.com added the comment:
This is a duplicate of issue 6902. I have a patch for that in the works.
--
resolution: - duplicate
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7483
New submission from Eric Smith e...@trueblade.com:
The documentation says: If the referenced object does not have a, b and
c attributes, of course, the end result is still a run-time exception.
For the given example, this is likely not true. Since the attributes are
being assigned
Eric Smith e...@trueblade.com added the comment:
In addition, quote is undocumented, although there is a test for it. It
should also be documented and/or have a docstring.
--
nosy: +eric.smith
___
Python tracker rep...@bugs.python.org
http
Eric Smith e...@trueblade.com added the comment:
Can you add a test for this?
--
nosy: +eric.smith
stage: - test needed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7455
Eric Smith e...@trueblade.com added the comment:
Eric, this patch affects a bunch of formatting tests, particularly
in Lib/test/test_types.py; I don't know whether you're trying to
keep trunk and py3k formatting tests synchronized for ease of
maintenance. Are you?
No, I've basically given
Eric Smith e...@trueblade.com added the comment:
See the discussion on python-dev, in particular Martin's comment at
http://mail.python.org/pipermail/python-dev/2009-December/094412.html
The solutions to this seem too complex for 2.x. It is not a problem in 3.x.
--
resolution: - wont
Eric Smith e...@trueblade.com added the comment:
I've raised the issue with unicode and locale on python-dev:
http://mail.python.org/pipermail/python-dev/2009-December/094408.html
Pending the outcome of that decision, I'll move forward on this issue
Eric Smith e...@trueblade.com added the comment:
I don't see any documentation that a struct lconv should be interpreted
as UTF-8. In fact Googling struct lconv utf-8 gives this bug report as
the first hit.
lconv.thousands_sep is char*. It's never been clear to me if this means
pointer
Eric Smith e...@trueblade.com added the comment:
In trunk, Modules/_localemodule.c also treats these as string of char,
so at least we're consistent.
In py3k, mbstowcs is used and the result passed to PyUnicode_FromWideChar.
I'm not sure how you'd address this in locale in trunk, or if we want
Eric Smith e...@trueblade.com added the comment:
When and if this is implemented, there's a test in test_float.py that
needs to be deleted. Search on if not '#' in fmt:, added in r76632.
--
___
Python tracker rep...@bugs.python.org
http
Eric Smith e...@trueblade.com added the comment:
Added tests to trunk in r76632 and py3k in r76634.
Note that the only thing that was changed are the tests. The actual
functionality was fixed earlier when the float formatting was reworked
as part of the short float repr changes
Eric Smith e...@trueblade.com added the comment:
The patch looks okay to me, and works on 2.7. Although it's slightly out
of date with respect to line numbers, it still applies cleanly.
My trivial suggestions are that I'd replace:
x += PyOS_snprintf(buffer + 8, bufflen - 8, .%06d, us);
with
x
Eric Smith e...@trueblade.com added the comment:
If you have a question to ask, this is not the proper forum. Please see
python-list http://mail.python.org/mailman/listinfo/python-list
--
nosy: +eric.smith
resolution: - invalid
status: open - closed
Eric Smith e...@trueblade.com added the comment:
This patch has tests that currently pass on trunk. I think this is the
desired behavior. I need to augment the tests for format() testing.
--
Added file: http://bugs.python.org/file15431/issue4482_tests-1.patch
Eric Smith e...@trueblade.com added the comment:
This version adds format() testing and fixes the comments (I hope).
--
Added file: http://bugs.python.org/file15432/issue4482_tests-2.patch
___
Python tracker rep...@bugs.python.org
http
Eric Smith e...@trueblade.com added the comment:
I think you need to put an assert before the line with bufflen-x, since
that's the calculation you're trying to ensure doesn't underflow. And I
guess that technically you should inspect the result of PyOS_snprintf
for an error, but given that we
Eric Smith e...@trueblade.com added the comment:
In 2.7, I get:
$ ./python.exe
Python 2.7a0 (trunk:76501, Nov 24 2009, 14:57:21)
[GCC 4.0.1 (Apple Inc. build 5465)] on darwin
Type help, copyright, credits or license for more information.
import locale
locale.setlocale(locale.LC_NUMERIC
Eric Smith e...@trueblade.com added the comment:
I can duplicate this on Linux. The difference is the values in the
locale for the separators, specifically,
locale.localeconv()['thousands_sep'].
locale.localeconv()['thousands_sep']
'\xc2\xa0'
The question is: since a struct lconv contains
Changes by Eric Smith e...@trueblade.com:
--
nosy: +eric.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7406
___
___
Python-bugs-list mailing
Eric Smith e...@trueblade.com added the comment:
Thanks for looking at this, Mark.
Your patch looks okay to me, but Objects/stringlib/formatter.h still has
some 'F' - 'f' logic in it, although it turns out that it's wrong:
#if PY_VERSION_HEX 0x0301000
/* 'F' is the same as 'f', per
Eric Smith e...@trueblade.com added the comment:
Here's a patch which adds some tests and fixes complex.
I'm currently testing with PY_NO_SHORT_FLOAT_REPR on Windows. If that's
okay, and if you don't have any objections, I'll commit this. While I'm
at it I'll modify Objects/stringlib
Changes by Eric Smith e...@trueblade.com:
--
versions: +Python 2.7
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3382
___
___
Python-bugs-list
Eric Smith e...@trueblade.com added the comment:
Committed (with a few more tests) in r76583.
--
resolution: - accepted
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3382
Eric Smith e...@trueblade.com added the comment:
This does not apply to 2.x. In both py3k and trunk,
Objects/bytearrayobject.c uses stringlib with some private defines. But
since those defines are only used in bytearrayobject.c, there's nothing
to be gained by factoring then out
Eric Smith e...@trueblade.com added the comment:
Fixed in r76595.
--
resolution: - accepted
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5748
Eric Smith e...@trueblade.com added the comment:
According to http://docs.python.org/library/imputil.html, imputil is
deprecated and it has been removed in 3.x. Further, I don't see
import_module in imputil (2.6 or trunk), it's just an example on that
documentation page.
--
nosy
Eric Smith e...@trueblade.com added the comment:
I'm going to close this, but if you find the problem (and especially if
you develop a patch to resolve it), please post back here.
--
status: open - closed
___
Python tracker rep...@bugs.python.org
Eric Smith e...@trueblade.com added the comment:
Thanks for tackling the last few bits, Mark. I think we're done,
although I admit I haven't verified what state the documentation is in.
I suggest we close this issue and if any problems occur open them as new
issues
Eric Smith e...@trueblade.com added the comment:
MvL made this comment in
http://www.mail-archive.com/python-...@python.org/msg43844.html
I'm copying it here so it doesn't get lost and because I think he makes
a good point that many people would miss (at least I didn't think
Eric Smith e...@trueblade.com added the comment:
It's a padding issue, having to do with putting values at the correct
word boundaries.
--
nosy: +eric.smith
resolution: - invalid
stage: - committed/rejected
status: open - closed
___
Python tracker
Eric Smith e...@trueblade.com added the comment:
What are the types and values of cluster and r?
Can you reproduce this in a self-contained script?
--
nosy: +eric.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7358
Eric Smith e...@trueblade.com added the comment:
It's basically because nothing comes after it. If you put something
after it, such as a zero length integer, you'll see:
from struct import calcsize
calcsize(ci)
8
calcsize(ic)
5
calcsize(ic0i)
8
Changes by Eric Smith e...@trueblade.com:
--
nosy: +eric.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7343
___
___
Python-bugs-list mailing
Changes by Eric Smith e...@trueblade.com:
--
nosy: +eric.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7347
___
___
Python-bugs-list mailing
Eric Smith e...@trueblade.com added the comment:
When building on XP with windows symlink draft 15.patch, I get:
Build started: Project: _hashlib, Configuration: Release|Win32
Performing Pre-Build Event...
Found a working perl at 'c:\opt\cygwin\bin\perl.exe'
Found an SSL directory
Eric Smith e...@trueblade.com added the comment:
Thanks, Walter. I'll finish my patch, then.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7309
Eric Smith e...@trueblade.com added the comment:
I agree there's not much value in making the attributes read/write, but
it looks like all of the exceptions allow it, so I don't really want to
make these exceptions the only ones that are different
Eric Smith e...@trueblade.com added the comment:
It looks like PyUnicode_FromFormatV is computing callcount incorrectly.
It's looking for 'S', 'R', or 'A' immediately following '%', before the
width. It seems to me it should be treating them the same as 's',
although I'll admit to not having
Eric Smith e...@trueblade.com added the comment:
I'm not sure why reason should be restricted to a string. This patch
(against trunk) just converts reason to a string when str() is called.
I'll add tests and fix the other places in exceptions.c where similar
shortcuts are taken without checking
Eric Smith e...@trueblade.com added the comment:
Actually attach the patch.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7309
___
___
Python
Eric Smith e...@trueblade.com added the comment:
One more time with the patch attachment.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7309
Changes by Eric Smith e...@trueblade.com:
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7309
___
___
Python-bugs-list mailing list
Unsubscribe
Changes by Eric Smith e...@trueblade.com:
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7309
___
___
Python-bugs-list mailing list
Unsubscribe
Eric Smith e...@trueblade.com added the comment:
For some reason I'm not able to attach the patch file. I'll look at
that, but in the meantime here's the preliminary patch against trunk:
Index: Objects/exceptions.c
===
--- Objects
Eric Smith e...@trueblade.com added the comment:
The patch that is (hopefully) attached is a first, incomplete cut just
for demonstration purposes. I still need to cover all of the cases where
PyString_AS_STRING are called without type checking. Also, as Ezio
points out, start and end are used
Changes by Eric Smith e...@trueblade.com:
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7309
___
___
Python-bugs-list mailing list
Unsubscribe
Eric Smith e...@trueblade.com added the comment:
Another patch against trunk which deals with:
UnicodeEncodeError: reason and encoding
UnicodeDecodeError: reason and encoding
UnicodeTranslateError: reason
Still needs tests. Also, the unchecked use of start and end needs to be
addressed. I'm
Changes by Eric Smith e...@trueblade.com:
Removed file: http://bugs.python.org/file15331/issue7309.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7309
Changes by Eric Smith e...@trueblade.com:
Added file: http://bugs.python.org/file15337/issue7309-1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7309
Changes by Eric Smith e...@trueblade.com:
Removed file: http://bugs.python.org/file15336/issue7309.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7309
Eric Smith e...@trueblade.com added the comment:
Tests need to cover issues like:
# assigning a non-string to e.object
e = UnicodeDecodeError(, , 0, 1, )
e.object = None
print str(e)
# start and end out of range
e = UnicodeDecodeError(, , 0, 1, )
e.start = 1000
e.end = 1001
print str(e
Eric Smith e...@trueblade.com added the comment:
For 2.x, I'd just raise an exception. No one is going to be using a step
of LONG_MIN.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7298
Eric Smith e...@trueblade.com added the comment:
I reviewed the issue on Rietveld, and it looks fine to me with the
exception of my comment about the tests. The comment is mostly a nit, so
if you don't agree don't worry about it.
I tested it with and without pydebug and the tests pass.
I think
Changes by Eric Smith e...@trueblade.com:
--
nosy: +eric.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7298
___
___
Python-bugs-list mailing
Eric Smith e...@trueblade.com added the comment:
so str.format() might raise an OverflowError for values = 128 (or =
256?)
Maybe, but the issue you reported is in unicode.format() (not
str.format()), and I think that should be fixed. I'm trying to think of
how best to address
New submission from Eric Smith e...@trueblade.com:
subprocess.py includes this comment, in list2cmdline():
# See
# http://msdn.microsoft.com/library/en-us/vccelng/htm/progs_12.asp
MSDN gets reorganized with surprising regularity, and this URL is no
longer valid. I think the current URL
Changes by Eric Smith e...@trueblade.com:
--
versions: +Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7294
___
___
Python-bugs-list
Changes by Eric Smith e...@trueblade.com:
--
assignee: - eric.smith
versions: +Python 2.6, Python 3.1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7294
Eric Smith e...@trueblade.com added the comment:
Fixed in:
trunk: r76168
release26-maint: r76169
py3k: r76170
release31-maint: r76171
--
priority: - low
resolution: - fixed
stage: - committed/rejected
status: open - closed
___
Python tracker rep
Eric Smith e...@trueblade.com added the comment:
I agree with Raymond here. This use case isn't special enough, or the
performance of the current one way to do it bad enough to warrant
changing set. I recommend closing this issue.
--
nosy: +eric.smith
Eric Smith e...@trueblade.com added the comment:
I still get 'Connection reset by peer' on OS/X 10.5.8 with this patch
(http://bugs.python.org/file15242/issue6748.patch).
--
nosy: +eric.smith
___
Python tracker rep...@bugs.python.org
http
Eric Smith e...@trueblade.com added the comment:
http://www.python.org/dev/buildbot/all/builders/x86%20FreeBSD%20trunk
reports:
FreeBSD 6.2-RELEASE (VMWare Image, 256MB, 10GB on P4/1.8GHz Host)
--
nosy: +eric.smith
___
Python tracker rep
Changes by Eric Smith e...@trueblade.com:
--
resolution: - invalid
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7234
Changes by Eric Smith e...@trueblade.com:
--
resolution: - invalid
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7236
Eric Smith e...@trueblade.com added the comment:
The patch (http://bugs.python.org/file15228/kevent.patch) works for me
under OS X 10.5.8 Intel.
All tests pass, except test_telnetlib which fails intermittently with
and without the patch.
Python 3.2a0 (py3k:75951, Oct 29 2009, 11:38:58)
[GCC
Eric Smith e...@trueblade.com added the comment:
I'm not sure what release it would be blocking. The oldest version I
have on hand is 2.4, and it's a problem there. If it hasn't caused an
actual problem in that long, then I don't see it as all that critical.
--
nosy: +eric.smith
Eric Smith e...@trueblade.com added the comment:
r75913: Fix _json.c to use PyOS_string_to_double. Change made after
consulting with Bob Ippolito.
This completes the removal of calls to PyOS_ascii_strtod.
--
___
Python tracker rep...@bugs.python.org
Eric Smith e...@trueblade.com added the comment:
r75743: Fix cPickle.c to use PyOS_string_to_double.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7117
Eric Smith e...@trueblade.com added the comment:
r75745: Fix stropmodule.c to use PyOS_string_to_double.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7117
Eric Smith e...@trueblade.com added the comment:
r75824: Fix ast.c to use PyOS_string_to_double.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7117
Eric Smith e...@trueblade.com added the comment:
r75846: Fix marshal.c to use PyOS_string_to_double.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7117
Eric Smith e...@trueblade.com added the comment:
I think the next step on my side is to remove _PyOS_double_to_string,
and make all of the internal code call PyOS_double_to_string. The
distinction is that _PyOS_double_to_string gets passed a buffer and
length, but PyOS_double_to_string returns
401 - 500 of 790 matches
Mail list logo
