[issue18709] SSL module fails to handle NULL bytes inside subjectAltNames general names (CVE-2013-4238)

Charles-François Natali added the comment: The test is failing on Tiger buildbots: == FAIL: test_parse_cert_CVE_2013_4238 (test.test_ssl.BasicSocketTests

[issue18808] Thread.join returns before PyThreadState is destroyed

Charles-François Natali added the comment: The first patch looks good, as for the second one, it'll take some time :-) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18808

[issue18643] implement socketpair() on Windows

Charles-François Natali added the comment: Alright, I think I know what's happening. The Python implementation uses a TCP socket, whereas the native implementation uses AF_UNIX socket. The maximum size of data that can be written to a socket without blocking is given by its send/receive buffers

[issue18643] implement socketpair() on Windows

Changes by Charles-François Natali cf.nat...@gmail.com: Added file: http://bugs.python.org/file31458/sendall_write.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18643

[issue18763] subprocess: file descriptors should be closed after preexec_fn is called

Changes by Charles-François Natali cf.nat...@gmail.com: -- resolution: - fixed stage: commit review - committed/rejected status: open - closed versions: +Python 2.7, Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org

[issue18643] implement socketpair() on Windows

Charles-François Natali added the comment: Here's a patch. Note that I'm still not sure whether it belong to the socket module or test.support. -- keywords: +needs review, patch stage: needs patch - patch review versions: +Python 3.4 Added file: http://bugs.python.org/file31452

[issue18643] implement socketpair() on Windows

Charles-François Natali added the comment: On Linux, many tests of test_socket are failing with the pure Python implementation. The only failing tests I see are due to the fact that the Python implementation uses AF_INET instead of AF_UNIX, which is normal since Windows doesn't have AF_UNIX

[issue16853] add a Selector to the select module

Charles-François Natali added the comment: Alright, I've updated the patch to have a distinct selectors module, and with Guido's comments. Before I post it for final review, I have three more questions: 1) In the documentation, I don't know how to best refer to files object registered: is file

[issue18756] os.urandom() fails under high load

Charles-François Natali added the comment: New changeset fe949918616c by Antoine Pitrou in branch 'default': Issue #18756: Improve error reporting in os.urandom() when the failure is due to something else than /dev/urandom not existing. http://hg.python.org/cpython/rev/fe949918616c Antoine

[issue18756] os.urandom() fails under high load

Charles-François Natali added the comment: Or more precisely, just run the test in a subprocess. That should fix the OS X failure if we don't restore the RLIMIT_NOFILE limits, and will make the test more robust (but you can't reuse the new test, since it won't work with lazy-opening

[issue16853] add a Selector to the select module

Charles-François Natali added the comment: Didn't you forget to upload it? I wanted to have answer to my questions first :-): Before I post it for final review, I have three more questions: -- ___ Python tracker rep...@bugs.python.org http

[issue18643] implement socketpair() on Windows

Charles-François Natali added the comment: self.assertEqual(sock.family, socket.AF_UNIX) AssertionError: 2 != 1 This is normal. == FAIL: test_sendall_interrupted (test.test_socket.GeneralModuleTests

[issue18816] mmap.flush() is always synchronous, hurting performance

Charles-François Natali added the comment: I propose to add an optional keyword parameter with default value SYNC (compatibility) but that can be ASYNC, INVALIDATE (can be SYNC|INVALIDATE and ASYNC|INVALIDATE too). AFAICT it's mostly useless on a modern OS. MS_INVALIDATE is a no-op

[issue18811] add ssl-based generator to random module

Charles-François Natali added the comment: How about we generalize SystemRandom so users can implement a custom RNG class wby providing a method rng(amount) - bytes? The random module already makes it easy: Class Random can also be subclassed if you want to use a different basic generator

[issue18763] subprocess: file descriptors should be closed after preexec_fn is called

Charles-François Natali added the comment: Here's a patch with a more robust test: the previous test worked, but assume that only stdin, stdout and stderr FDs would be open in the child process. This might not hold anymore in a near future (/dev/urandom persistent FD). The new test is much

[issue18763] subprocess: file descriptors should be closed after preexec_fn is called

Charles-François Natali added the comment: I don't understand why os.dup2() is more reliable than os.pipe() for a unit test? I use dup2() because it allows me to specify a target FD, so the parent can know precisely which FD was opened by the preexec hook, and check it's closed in the child

[issue18763] subprocess: file descriptors should be closed after preexec_fn is called

Charles-François Natali added the comment: You might also add a check: self.assertLessEqual(remaining_fds, {0, 1, 2}) Well no, because the interpreter might have other FDs open than stdin, stdout and stderr. -- ___ Python tracker rep

[issue18763] subprocess: file descriptors should be closed after preexec_fn is called

Charles-François Natali added the comment: Close_fds is not supposed to close them? Yes, but some new fds might be open in the child process, e.g. for /dev/urandom. That's why it's better to check that this precise FD is closed. Of course, if the /dev/urandom FD gets assigned the same FD

[issue18806] socketmodule: fix/improve setipaddr() numeric addresses handling

Charles-François Natali added the comment: Hum... Apparently, before this bug was fixed, glibc's getaddrinfo() would retrieve the list of interfaces at every call, even if AI_ADDRCONFIG was not set: http://sourceware.org/git/?p=glibc.git;a=commitdiff;h=fa3fc0fe5f452d0aa7e435d8f32e992958683819

[issue18806] socketmodule: fix/improve setipaddr() numeric addresses handling

Charles-François Natali added the comment: So it might be better to just use inet_pton() instead. But then it won't set the scope ID if the user doesn't provide it... -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18806

[issue18747] Re-seed OpenSSL's PRNG after fork

Charles-François Natali added the comment: STINNER Victor added the comment: PySSL_RAND_atfork_parent() still uses getpid(). This number is not very random in the *parent* process :-) :-) IMO this patch has been rushed in and should be reverted for now. It's still not async-signal safe

[issue18747] Re-seed OpenSSL's PRNG after fork

Charles-François Natali added the comment: PySSL_RAND_atfork_parent() still uses getpid(). This number is not very random in the *parent* process :-) That's fine and doesn't diminish the properties of the PRNG. In fact the patch could use a hard coded value to perturb the PRNG. It's only

[issue18811] add ssl-based generator to random module

New submission from Charles-François Natali: Now that the ssl module exposes RAND_bytes() (issue #12049), it might be interesting to implement a SSLRandom generator to the random module, to have a cryptographically strong generator without the os.urandom() overhead. Thoughts

[issue18811] add ssl-based generator to random module

Charles-François Natali added the comment: It doesn't look like OpenSSL's PRNG is much faster than /dev/urandom if Python keeps a persistent fd: $ python3.3 prng.py loops: 100 bytes: 16 /dev/urandom (fd)1.2181 os.urandom() 3.2892 RAND_pseudo_bytes1.2924

[issue18763] subprocess: file descriptors should be closed after preexec_fn is called

Charles-François Natali added the comment: Using self.assertLessEqual() would provide better message on error. Done. You don't want to fix Python 2.7 and 3.3? It is a bug in my opinion. Patch for 2.7 attached (without test though, because 2.7 lacks a fd_status.py helper, which would make

[issue18623] Factor out the _SuppressCoreFiles context manager

Charles-François Natali added the comment: Could you post your patch without the '--git' option? Apparently it doesn't work well with the code review tool. It would be nice if there was a more explicit way to test the creation of core files, however. One possibility would be to fork

[issue18794] select.devpoll objects have no close() method

Charles-François Natali added the comment: Just to be explicit (there are typos in Victor's original messages): it's about select.devpoll, for Solaris-derivatives with /dev/poll, and not for select.poll, based on poll() syscall. -- ___ Python

[issue16853] add a Selector to the select module

Charles-François Natali added the comment: I've lost track -- who is waiting for whom? I reviewed the patch selector-12.diff and received zero response AFAICT. (Maybe the email from Rietveld didn't make it?) I was on vacation, and then had to cope with many emails :-) I'll update

[issue18792] test_ftplib timeouts

Charles-François Natali added the comment: Some ftplib tests sometimes time out. Seem they seem to try to connect to localhost (rather than 127.0.0.1), I was wondering if this could be a DNS issue and if we should resolve localhost in advance like Charles-François did for some other tests

[issue18792] test_ftplib timeouts

Charles-François Natali added the comment: Changing support.HOST from 'localhost' to '127.0.0.1' means that on dual-stack hosts (I don't think the test suite would run on IPv6-only hosts anyway), the tests will now always use IPv4, whereas they are currently using either IPv6 or IPv4 addresses

[issue18792] test_ftplib timeouts

Charles-François Natali added the comment: That would only be true if the server we are contacting happens to listen on both IPv6 and IPv4, right? I don't think we have such a situation in the test suite. Ah, I thought some code was using getaddrinfo() to select an arbitrary bind() address

[issue18747] Re-seed OpenSSL's PRNG after fork

Charles-François Natali added the comment: Christian Heimes added the comment: I have taken care of Antoine's and Victor's reviews. The fix has landed in Python 2.7, 3.3 and 3.4. What about 2.6, 3.1 and 3.2? After all it's a security fix (although I don't consider its severity as high

[issue18747] Re-seed OpenSSL's PRNG after fork

Charles-François Natali added the comment: Which part of the function is not async-signal safe? It doesn't interact with any file descriptors nor does it use any syscalls except for getpid() and time(). gettimeofday() and RAND_add() The functions which are guaranteed to be async-signal safe

[issue18747] Re-seed OpenSSL's PRNG after fork

Charles-François Natali added the comment: 2013/8/21 Antoine Pitrou rep...@bugs.python.org: Instead of reseeding in the child, you can perturb the state in the parent after fork. As far as I understand, only the child callback in pthread_atfork() needs to be async-signal-safe: That's

[issue18747] Re-seed OpenSSL's PRNG after fork

Charles-François Natali added the comment: Another, probably cleaner way would be to finally add the atfork() module (issue #16500), and register this reseed hook (which could then be implemented in ssl.py). Wouldn't that still suffer from the double-fork() issue? Not for the officially

[issue15233] atexit: guarantee order of execution of registered functions?

Charles-François Natali added the comment: Backported to 2.7. -- resolution: - fixed stage: commit review - committed/rejected status: open - closed versions: -Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15233

[issue18792] test_ftplib timeouts

Charles-François Natali added the comment: LGTM -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18792 ___ ___ Python-bugs-list mailing list

[issue18763] subprocess: file descriptors should be closed after preexec_fn is called

Changes by Charles-François Natali cf.nat...@gmail.com: -- nosy: +sbt ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18763 ___ ___ Python-bugs-list

[issue6923] Need pthread_atfork-like functionality in CPython

Changes by Charles-François Natali cf.nat...@gmail.com: -- resolution: - duplicate stage: needs patch - committed/rejected status: open - closed superseder: - Add an 'atfork' module ___ Python tracker rep...@bugs.python.org http://bugs.python.org

[issue12641] Remove -mno-cygwin from distutils

Changes by Charles-François Natali cf.nat...@gmail.com: -- title: Test - Remove -mno-cygwin from distutils ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12641

[issue18806] socketmodule: fix/improve setipaddr() numeric addresses handling

New submission from Charles-François Natali: Currently, setipaddr() has this code to special-case numeric IPv4 addresses and avoid a name resolution: if (sscanf(name, %d.%d.%d.%d%c, d1, d2, d3, d4, ch) == 4 0 = d1 d1 = 255 0 = d2 d2 = 255 0 = d3 d3 = 255 0 = d4 d4

[issue18748] libgcc_s.so.1 must be installed for pthread_cancel to work

Charles-François Natali added the comment: On Linux, you can try to set the LD_PRELOAD environment variable as a workaround. LD_PRELOAD=libgcc_s.so.1 python bug.py You may need to specify the full path. I don't think that'll work. Despite its name, using LD_PRELOAD won't preload

[issue18418] Thread.isAlive() sometimes True after fork

Changes by Charles-François Natali cf.nat...@gmail.com: -- stage: - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18418

[issue18747] Re-seed OpenSSL's PRNG after fork

Charles-François Natali added the comment: 2013/8/17 Christian Heimes rep...@bugs.python.org: Here is a patch that is based on Apache's mod_ssl code. mod_ssl perturbs the PRNG state more often but I think that's overkill for Python. The new patch only affects the PRNG state of the child

[issue18763] subprocess: file descriptors should be closed after preexec_fn is called

Charles-François Natali added the comment: With patch :) -- Added file: http://bugs.python.org/file31342/subprocess_close.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18763 ___diff -r

[issue18720] Switch suitable constants in the socket module to IntEnum

Charles-François Natali added the comment: I've just had a quick look at the patch, but from what I can see, socket.getaddrinfo() will return a raw integer for the family, and not an AddressFamily instance. That's unfortunate. -- ___ Python tracker

[issue18643] implement socketpair() on Windows

Charles-François Natali added the comment: I was thinking about dropping the C wrapper from socketmodule.c, and replacing it with a pure Python implementation (e.g. the one posted by Richard on python-dev). What do you think? -- ___ Python tracker

[issue16463] testConnectTimeout of test_timeout TCPTimeoutTestCasefailures fails intermittently

Charles-François Natali added the comment: Here's an updated patch using the lru_cache decorator. -- Added file: http://bugs.python.org/file31312/connect_timeout-1.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16463

[issue18748] libgcc_s.so.1 must be installed for pthread_cancel to work

Charles-François Natali added the comment: Unfortunately, there's not much we can do about it: if dlsym() fails - which is the case here either because read() fails with EBADF, or because the file descriptor now points to another stream (i.e. not libgcc), the libc aborts (here upon

[issue18748] libgcc_s.so.1 must be installed for pthread_cancel to work

Charles-François Natali added the comment: Perhaps the only thing we could do would be try to preload libgcc by calling one of those APIs at startup? Yeah, I was thinking about doing this in PyThread_init_thread() but... But I'm not sure it's a good idea to add such a platform-specific

[issue18756] os.urandom() fails under high load

Charles-François Natali added the comment: If os.urandom() doesn't fail, something else will fail soon after. the random pool can be exhausted, but this is not soon after I think. In Linux and Mac OS X, ulimit -n defaults to 512 and 256. I don't think he's referring to the entropy pool

[issue18756] os.urandom() fails under high load

Charles-François Natali added the comment: 2013/8/16, Tarek Ziadé rep...@bugs.python.org: I use greenlets. But, I don't know - are you suggesting os.urandom() should be marked in the documentation as DOES NOT SCALE and I should use another API ? Which one ? Well, even with greenlets, I

[issue18756] os.urandom() fails under high load

Charles-François Natali added the comment: I do many calls on urandom() so that's the FD bottleneck. So os.urandom() isn't your biggest problem here. Of course it is. But it looks like you know better without having looked at the code. :) So please explain me :-) os.urandom() can only

[issue18756] os.urandom() fails under high load

Charles-François Natali added the comment: Why locking? /dev/urandom is a pseudo char device. You can have multiple readers on the same fd without any locking. You must put a lock around the open() call, though, to avoid calling it several times and losing an fd. Exactly (unless the FD

[issue18756] os.urandom() fails under high load

Charles-François Natali added the comment: In the light of the recent Android issue with PRNGs [1] I don't think that Python should roll out its own CPRNG. I'd rather use the operation system's CPRNG or OpenSSL's CPRNG. After all we aren't crypto experts. I'd rather point my finger

[issue18756] os.urandom() fails under high load

Charles-François Natali added the comment: Attaching a patch to make error reporting better. Why didn't you include ENODEV? Apparently it can be reported in some corner cases, e.g. in this patch: http://lfs-matrix.net/patches/downloads/linux/linux-2.6.14.2-pseudo_random-1.patch Otherwise

[issue16463] testConnectTimeout of test_timeout TCPTimeoutTestCasefailures fails intermittently

Changes by Charles-François Natali cf.nat...@gmail.com: Added file: http://bugs.python.org/file31320/connect_timeout-2.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16463

[issue18756] os.urandom() fails under high load

Charles-François Natali added the comment: Updated error handling patch testing for ENODEV. LGTM, you can apply to 2.7 and 3.x (I just hope all those errnos are available on every POSIX platform ;-). -- ___ Python tracker rep...@bugs.python.org

[issue18720] Switch suitable constants in the socket module to IntEnum

Charles-François Natali added the comment: The attached patch fixes it in a similar vein to what was done for the family accessor: getaddrinfo is overridden in Python and does the necessary conversion. Am I the only one thinking that wrapping every C function with a Python counterpart

[issue18763] subprocess: file descriptors should be closed after preexec_fn is called

New submission from Charles-François Natali: Currently, when passed close_fds=True, the subprocess module closes FDs before calling preexec_fn (if provided). This can be an issue if preexec_fn opens some file descriptors, which would then be inherited in the child process. Here's a patch

[issue16463] testConnectTimeout of test_timeout TCPTimeoutTestCasefailures fails intermittently

Charles-François Natali added the comment: Should be fixed now! -- resolution: - fixed stage: commit review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16463

[issue17684] Skip tests in test_socket like testFDPassSeparate on OS X

Charles-François Natali added the comment: Charles-Francois: why did you commit this to default only, and not to 3.3? I overlooked it (apparently, the issue was tagged 3.4 only, and I didn't double-check that the code was present in 3.3 as well). Should be better now! -- versions

[issue18078] threading.Condition to allow notify on a specific waiter

Charles-François Natali added the comment: FWIW, I don't support adding this functionality. I don't see precedents for Condition Variables behaving this way in other languages. Also, I don't think it is worth the added complexity, learning curve, and maintenance burden. Condition

[issue16853] add a Selector to the select module

Charles-François Natali added the comment: Guido van Rossum added the comment: Can you try again with the failing assert replaced with this? self.assertTrue(0.018 = t2-t0 = 0.028, t2-t0) That should be a better way to check that code works. I'm still getting - less frequent

[issue10897] UNIX mmap unnecessarily dup() file descriptor

Charles-François Natali added the comment: This can only be raised (above the hard limit) by a privileged process, so I would be out of luck there, as I could not convince my sysadmins to raise this further. We all know that feeling :-) Meanwhile, I will just use my own module, so feel

[issue16463] testConnectTimeout of test_timeout TCPTimeoutTestCasefailures fails intermittently

Charles-François Natali added the comment: The problem is that the test passes a DNS address to connect(), which means that it has to perform a name resolution first. And since there's not timeout on gethostbyname()/getaddrinfo() you can end up well above the timeout. The hostnames should

[issue16463] testConnectTimeout of test_timeout TCPTimeoutTestCasefailures fails intermittently

Charles-François Natali added the comment: And here's a patch. -- keywords: +patch Added file: http://bugs.python.org/file31137/connect_timeout.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16463

[issue18643] implement socketpair() on Windows

New submission from Charles-François Natali: socketpair() is quite useful, notably for tests. Currently, it's not defined on Windows. Since it's rather easy to implement, it would be nice to have it, if not in the stdlib, at least in test.support. -- components: Library (Lib) messages

[issue15233] atexit: guarantee order of execution of registered functions?

Charles-François Natali added the comment: Unless anyone objects, I'll backport it soonish. -- stage: - commit review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15233

[issue12015] possible characters in temporary file name is too few

Changes by Charles-François Natali cf.nat...@gmail.com: -- keywords: +easy, needs review stage: - patch review type: - enhancement versions: +Python 3.4 -Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12015

[issue18296] test_os.test_trailers() is failing on AMD64 FreeBSD 9.0 dtrace 3.x

Charles-François Natali added the comment: The test shouldn't pass 4096 as nbytes: apparently, recent FreeBSD kernels zero-fill. -- nosy: +neologix ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18296

[issue16945] rewrite CGIHTTPRequestHandler to always use subprocess

Charles-François Natali added the comment: Marking #10496 as a dependency (since it could prevent Python from running with low level privileges). -- dependencies: +Python startup should not require passwd entry ___ Python tracker rep

[issue18418] Thread.isAlive() sometimes True after fork

Charles-François Natali added the comment: I've posted another review (not sure you receive notifications). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18418

[issue10496] Python startup should not require passwd entry

Changes by Charles-François Natali cf.nat...@gmail.com: -- keywords: +needs review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10496

[issue1611154] os.path.exists(file/) failure on Solaris 9

Changes by Charles-François Natali cf.nat...@gmail.com: -- status: open - pending ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1611154

[issue17070] PEP 433: Use the new cloexec to improve security and avoid bugs

Charles-François Natali added the comment: Time to close this one, since the PEP has been superseeded by PEP 446? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17070

[issue11757] test_subprocess.test_communicate_timeout_large_ouput failure on select(): negative timeout?

Changes by Charles-François Natali cf.nat...@gmail.com: -- status: pending - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11757

[issue12999] _XOPEN_SOURCE and _XOPEN_SOURCE_EXTENDED usage on Solaris

Charles-François Natali added the comment: OK, let's close then. We can still re-open if this pops up again. -- status: pending - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12999

[issue10897] UNIX mmap unnecessarily dup() file descriptor

Charles-François Natali added the comment: I changed my mind, and think we should keep the current behavior: it guarantees resize() won't break, and doesn't cost much. One extra FD per mmap is not a huge hit. If that's a problem, then the user can raise the RLIMIT_NOFILE

[issue12588] test_capi.test_subinterps() failed on OpenBSD (powerpc)

Changes by Charles-François Natali cf.nat...@gmail.com: -- status: open - pending ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12588

[issue16038] ftplib: unlimited readline() from connection

Charles-François Natali added the comment: So, what now? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16038 ___ ___ Python-bugs-list mailing

[issue18325] test_kqueue fails in OpenBSD

Charles-François Natali added the comment: Should be fixed now. Thanks for the report, and sorry for the delay! -- resolution: - fixed stage: - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http

[issue16635] Interpreter not closing stdout/stderr on exit

Changes by Charles-François Natali cf.nat...@gmail.com: -- resolution: - rejected stage: - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16635

[issue16853] add a Selector to the select module

Charles-François Natali added the comment: Here's a patch, based on the version in tulip's repo. I've added doc update and tests. I also made the following changes: - BaseSelector is an abstract base class (so one could imagine user code implementing its own selector on top

[issue16853] add a Selector to the select module

Charles-François Natali added the comment: Version addressing Antoine and Christian's comments. -- Added file: http://bugs.python.org/file31133/selector-12.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16853

[issue10496] Python startup should not require passwd entry

Charles-François Natali added the comment: Is there a hope to get this fixed? It can be needed to e.g. run python as nobody user (used for example for CGI scripts, etc). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10496

[issue18596] enable usage of AddressSanitizer in CPython [PATCH]

Charles-François Natali added the comment: The warning is due to the Py_ADDRESS_IN_RANGE() macro: it's a know limitation, we have the same problem with valgrind. This would be a nice neature. It would IMO be even nicer to have an ASAN-enabled buildbot. -- nosy: +neologix

[issue18418] Thread.isAlive() sometimes True after fork

Charles-François Natali added the comment: Bump. Did you see my review at http://bugs.python.org/review/18418/#ps8668 ? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18418

[issue18408] Fixes crashes found by pyfailmalloc

Charles-François Natali added the comment: Victor, how about adding pyfailmalloc to the main repo (maybe under Tools), with a script making it easy to run the tests suite with it enabled? This way, it'll make it easier to run it from time to time (one could eve imagine making it part

[issue18418] Thread.isAlive() sometimes True after fork

Charles-François Natali added the comment: If you want a consistent reproducible test case for this I believe you will need to replace the Thread object's __started with a test wrapper who's set() method blocks waiting for for the fork to have happened before doing the actual set

[issue18471] Typo in heapq documentation

New submission from François Pinard: Within http://docs.python.org/3/library/heapq.html#theory, a sentence begins with When an event schedule while it should be spelled When an event schedules. The same may be observed in Python 2 documentation. -- assignee: docs@python components

[issue18418] Thread.isAlive() sometimes True after fork

Charles-François Natali added the comment: This is just a special-case of the more general problem of forking() in a multi-threaded program (see #16500 and #6721). Since fork() can occur at any time, even though your data structures are protected by locks, they can end up in an inconsistent

[issue18308] checkRecvmsgAddress wrong in test_socket.py (AIX failures)

Charles-François Natali added the comment: Fixed, thanks! -- resolution: - fixed stage: - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18308

[issue18308] checkRecvmsgAddress wrong in test_socket.py (AIX failures)

Charles-François Natali added the comment: I think the safest solution is not to compare scope_id when comparing addresses. Agreed. However, it might be simpler to special-case the IPv6 addresses comparison by overriding it in the IPv6 sendmsg base test. Could you try the patch attached

[issue11185] test_wait4 error on AIX

Changes by Charles-François Natali cf.nat...@gmail.com: -- assignee: - neologix ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11185

[issue18328] Use after free in pystate.c

Charles-François Natali added the comment: Well, tstate is freed, but is not used afterwards, it's just comparing the pointer against the TLS. -- nosy: +neologix ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18328

[issue18328] Use after free in pystate.c

Charles-François Natali added the comment: I think it's unsafe. The address of a pointer should not be used once the pointer has been freed. Dereferencing a freed pointer is unsafe. A pointer is just an address, there's nothing inherently unsafe with comparing a pointer with a value

[issue17914] add os.cpu_count()

Changes by Charles-François Natali cf.nat...@gmail.com: -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17914

[issue11016] Re-implementation of the stat module in C

Charles-François Natali added the comment: I still fail to understand why you just don't ditch the Python implementation. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11016

[issue18078] threading.Condition to allow notify on a specific waiter

Charles-François Natali added the comment: I'm not convinced it's really useful. Furthermore, the complexity is rather bad: if T is the average number of waiting threads, an C the number of conditions being waited on, the wait is O(C) (appending to C wait queues) and wakeup is O(CT) (C removal

<    1   2   3   4   5   6   7   8   9   10   >