New submission from Greg Turner:
Kinda trivial but...
Something like the enclosed, untested patch would seem to make new_class work a
bit more like type_new.
To be explicit, the difference is whether or not to respect virtual subclasses.
So, for example, as implemented, we can implement
Greg Turner added the comment:
Also:
In types.prepare_class, here is what currently happens:
we let x be, in order of preference:
(a) the explicitly given type if, one is given, else
(b) type(bases[0]), if it exists, else
(c) type
and then, if isinstance(x, type), we run
Greg Turner added the comment:
> perhaps "isinstance(x, type)" should have been "issubclass(x, type)" to
> correctly capture how python 2 does it.
Actually, scratch that -- its a brain fart.
IIUC new_class was created because, at the time, there was no exposed turn
Changes by Greg Turner :
--
title: types._calculate_meta nit: isinstance != PyType_IsSubtype ->
Lib/types.py nit: isinstance != PyType_IsSubtype
___
Python tracker
<http://bugs.python.org/issu
Greg Turner added the comment:
Just added a commit message.
--
Added file: http://bugs.python.org/file37349/fix_types_calculate_meta_v3.patch
___
Python tracker
<http://bugs.python.org/issue22
Greg Turner added the comment:
Here are some tests for this... first, some tests that pass right now and
demonstrate, I think, correctness of the second batch of tests.
--
Added file: http://bugs.python.org/file37350/test_virtual_metaclasses.patch
Greg Turner added the comment:
And some analogous tests for types.py, which don't pass without
fix_types_calculate_meta_v3.patch.
--
Added file:
http://bugs.python.org/file37351/test_virtual_metaclasses_in_types_module.patch
___
Python tr
Greg Turner added the comment:
And some analogous tests for types.py, which don't pass without
fix_types_calculate_meta_v3.patch.
--
Added file:
http://bugs.python.org/file37352/test_virtual_metaclasses_in_types_module.patch
___
Python tr
Greg Turner added the comment:
Fixed a trivial typo in test_virtual_metaclass_in_types_module.patch
--
versions: +Python 3.5
Added file:
http://bugs.python.org/file37356/test_virtual_metaclasses_in_types_module_v2.patch
___
Python tracker
<h
Changes by Greg Turner :
--
components: Distutils
nosy: dstufft, eric.araujo, gmt
priority: normal
severity: normal
status: open
title: \\di
___
Python tracker
<http://bugs.python.org/issue23
Changes by Greg Turner :
--
status: open -> closed
title: \\di -> bleh, sorry, my cat reported this non-bug :)
___
Python tracker
<http://bugs.python.org/i
New submission from Greg Turner:
Clinical Presentation:
Sometimes a developer consuming distutils will write what seems like a
perfectly sensible setup.py, but something inscrutable happens: setup.py bombs
out claiming "error: each element of 'ext_modules' option must be an Exte
Greg Turner added the comment:
Here's the same deal more-or-less for issue 23114... this time I expended
considerably less effort verifying that it's not a bad idea. At a glance,
though, it looks fine, and solved an instance of the issue 23114 problem I was
able to repro on my b
Greg Turner added the comment:
Perhaps it is worth addressing, briefly, the following hypothetical question,
as a litmus test against the faint dis-encapsulation code-smell some folks
might be picking up from this:
In a hypothetcial world without setuptools, would these changes have merit
Greg Turner added the comment:
Huzzah
--
Added file:
http://bugs.python.org/file44619/0001-distutils-type-checks-can-fail-issue-23102.patch
___
Python tracker
<http://bugs.python.org/issue23
Greg Turner added the comment:
Double Huzzah.
I can probably cook up a test and even look at those method invocations in
considerably less than the existing 1.5-year lifecycle of this bug, but not
necessarily immediately due to reasons.
--
Added file:
http://bugs.python.org
16 matches
Mail list logo
