Guilherme Polo added the comment:
Shift+Tab does look better to me too. But, one can change the default
shortcut like Kurt mentioned.
Are IDLE users ready to have the default dedent shortcut changed ?
--
nosy: +gpolo
___
Python tracker
<h
Guilherme Polo added the comment:
For config-extensions.def:
What do you think about moving all shortcuts to config-keys and then
always use the name of the shorcut in config-extensions instead of the
shorcut ?
For config-main.def:
For the [Keys] section I believe it would be better to
Guilherme Polo added the comment:
Maybe we can agree on the feature being added ? I don't see much use for
controlling how much time the insertion cursor is on and how much time
it is off, but maybe just choosing between blink and no-blink would be
good to have. I would prefer to just g
Guilherme Polo added the comment:
Victor, I have changed your tkinter patch a bit and applied on r70641.
The issue is marking only python 2.7 right now, aren't these changes
supposed to be applied 26-maint, py3k and 30-maint too ?
--
___
P
Changes by Guilherme Polo :
--
nosy: +gpolo
___
Python tracker
<http://bugs.python.org/issue5035>
___
___
Python-bugs-list mailing list
Unsubscribe:
Guilherme Polo added the comment:
I tried it here but it didn't hang. But I did notice the editor window
was created and then disappeared, differently from what happens in
python-trunk.
I don't believe creating new files is a good solution, idle on
python-trunk doesn't need to
Guilherme Polo added the comment:
I see this occurring everywhere, but the proposed solution may not be
enough. I can still create a directory with a tab on it and it will fail
too.
The proper solution (in my head) would involve changing the interaction
of GrepDialog with OutupWindow, but then
Guilherme Polo added the comment:
Uhm, I don't agree with this TkinterTest name since it is only doing a
minor test on _tkinter._flatten. This same class is indicated in
tests_gui but it doesn't require gui to run, it should be indicated only
in tests_nogui.
Then there is TclTest wh
Guilherme Polo added the comment:
platform: Windows XP
In a file (cf attached file) with mixed tabs and spaces, the line
following "else:" appears at the same level than "else:", while the file
probably still works with Python 2.6. At least, IDLE 2.5 or IDLE 2.4 or
vim don
Changes by Guilherme Polo :
--
___
Python tracker
<http://bugs.python.org/issue5129>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/m
Guilherme Polo added the comment:
Patch attached, if someone can create a test for it then that would be
very good.
--
keywords: +patch
Added file: http://bugs.python.org/file13404/fix_5129.diff
___
Python tracker
<http://bugs.python.org/issue5
Guilherme Polo added the comment:
You do not need IDLE to reproduce the problem:
import Tkinter
text = Tkinter.Text()
text.pack()
text.insert('1.0',
'class C:\n\tdef m(self, c):\n'
'if c:\nc = False\n&#x
Guilherme Polo added the comment:
It turns out that the problem is not in differences between IDLE in 2.5
and the one in 2.6, instead it is caused by the usage of Tk 8.5 by IDLE
2.6 (included in the Windows package). Changing to Tk 8.4, IDLE 2.6
displays in the same way as 2.5 (tested on Linux
Guilherme Polo added the comment:
I just tried it here under Windows XP (using python 2.6.1 from
python.org) and the untabify dialog showed up with 8 as the default
number of columns per tab (although there are at least two bugs with
this dialog: i) I clicked on cancel but it still untabified
Guilherme Polo added the comment:
Patch with a test attached.
--
keywords: +patch
message_count: 1.0 -> 2.0
nosy: +gpolo
nosy_count: 1.0 -> 2.0
versions: +Python 2.7, Python 3.0, Python 3.1
Added file: http://bugs.python.org/file13297/issue_547
Guilherme Polo added the comment:
Unfortunately this is a tix issue, so we can't fix it from python. See
http://sourceforge.net/tracker/index.php?func=detail&aid=1864027&group_id=5649&atid=105649
Leaving this open as a reminder to incldue a newer tix in
Guilherme Polo added the comment:
Assigning to kbk since 5234 was assigned to him.
--
assignee: -> kbk
message_count: 2.0 -> 3.0
nosy: +gpolo, kbk
nosy_count: 1.0 -> 3.0
___
Python tracker
<http://bugs.python.o
Guilherme Polo added the comment:
Closing in favor of 5233, I see the fix being applied to both 2.7 and
3.1 if accepted.
--
message_count: 3.0 -> 4.0
nosy: +gpolo
nosy_count: 3.0 -> 4.0
resolution: -> duplicate
status: open -> closed
superseder: -> Enhance 2
Guilherme Polo added the comment:
It should be okay to move tk tests to somewhere in
Lib/lib-tk/test/test_tkinter/ (answering the final question). Even the
rest of test_tcl could be relocated to that place.
--
message_count: 4.0 -> 5.0
___
Pyt
Guilherme Polo added the comment:
Please use test_support.TestSkipped instead of showing a skip message
using print.
--
message_count: 3.0 -> 4.0
nosy: +gpolo
nosy_count: 1.0 -> 2.0
___
Python tracker
<http://bugs.python.org/
Guilherme Polo added the comment:
Fixed in r70223 and r70225.
Thanks for reporting.
--
resolution: accepted -> fixed
status: open -> closed
versions: -Python 3.0
___
Python tracker
<http://bugs.python.org/
Guilherme Polo added the comment:
Merges: r70220, r70221, r70222
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Guilherme Polo added the comment:
Merges: r70220, r70221, r70222
___
Python tracker
<http://bugs.python.org/issue5193>
___
___
Python-bugs-list mailing list
Unsubscribe:
Guilherme Polo added the comment:
Fixed in r70219.
___
Python tracker
<http://bugs.python.org/issue4792>
___
___
Python-bugs-list mailing list
Unsubscribe:
Guilherme Polo added the comment:
I will be committing this but I'm afraid a test won't be added for it.
Several people told me that creating multiple tcl interpreters (even if
only one is active at some point) is problematic, specially in older tcl
versions.
So if someone can find a
Guilherme Polo added the comment:
Fixed in r70218, I will be merging into the other branches still today.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Guilherme Polo added the comment:
In this case I'm closing it.
--
resolution: -> rejected
status: open -> closed
___
Python tracker
<http://bugs.python
Guilherme Polo added the comment:
I lost the race, congrats Jean :P
I was going to copy & paste part of the man page.
--
nosy: +gpolo
resolution: -> invalid
status: open -> closed
___
Python tracker
<http://bugs.python.
Guilherme Polo added the comment:
Do you mean something like this:
import Tkinter
def insert():
text.insert('end', 'buh\n')
text.see('end')
text.after(100, insert)
text = Tkinter.Text()
text.pack(expand=True, fill='both', side='lef
Changes by Guilherme Polo :
Removed file:
http://bugs.python.org/file13035/check_tpiter_before_overriding_msg.diff
___
Python tracker
<http://bugs.python.org/issue5
Guilherme Polo added the comment:
Why close ? It is still a valid feature request (with no patch yet).
--
nosy: +gpolo
___
Python tracker
<http://bugs.python.org/issue539
Changes by Guilherme Polo :
--
nosy: -gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue3833>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Guilherme Polo :
___
Python tracker
<http://bugs.python.org/issue3833>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/o
Changes by Guilherme Polo :
___
Python tracker
<http://bugs.python.org/issue3833>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/o
Guilherme Polo added the comment:
agreed. most platforms should be using the openssl version, i will
update the non-openssl implementations to behave the same.
I don't think this is worth being a release blocker. I'll do it for 3.0.1.
--
nosy: +grego
Guilherme Polo added the comment:
Nice.
I said tests in hope wave gets more tests, since right one there is a
single one. I will see if I can produce something.
___
Python tracker
<http://bugs.python.org/issue5
Guilherme Polo added the comment:
Thanks for taking a look, my bad for taking so long to reply.
I'm adding a new patch now. This one, besides the fix needed mentioned
above, disregards tp_iter from old class instances (since they are
always available and tell us nothing).
Added file:
Guilherme Polo added the comment:
(Btw, the suggestion to check for tp_iter came from Antoine Pitrou. It
seemed fine to me.)
___
Python tracker
<http://bugs.python.org/issue5
Changes by Guilherme Polo :
--
components: +Interpreter Core
type: -> behavior
versions: +Python 2.7, Python 3.1
___
Python tracker
<http://bugs.python.org/iss
New submission from Guilherme Polo :
Hi,
I find it weird that given this sample code:
def g():
yield iter(None)
list(*g())
I get this traceback:
Traceback (most recent call last):
File "a1.py", line 3, in
list(*g())
TypeError: type object argument after * must be a seq
New submission from Guilherme Polo :
I guess this happened due to the transition from rsplit to rindex.
--
assignee: brett.cannon
components: Library (Lib)
files: _resolve_name_rindex.diff
keywords: easy, patch
messages: 81621
nosy: brett.cannon, gpolo
severity: normal
status: open
Guilherme Polo added the comment:
I see what you want to do, but I fell really uncomfortable by totally
ignoring IOError. I could get a bad file descriptor under Linux too, and
I wouldn't like to see it discarded for no reason.
Now, is there some problem if we remove the calls to the
Guilherme Polo added the comment:
Wouldn't it be better if you only ignored the 'illegal seek' error
instead of ignoring any ioerror (should it even be always discarded) ? I
get a 'bad file descriptor' under Windows 7, but, again, can it be
always discarded ?
Y
Changes by Guilherme Polo :
--
keywords: +patch
Added file: http://bugs.python.org/file13000/oldtkaqua.diff
___
Python tracker
<http://bugs.python.org/issue5
Guilherme Polo added the comment:
Thanks for remembering, Daniel.
Closing as noted above.
--
resolution: -> out of date
status: open -> closed
superseder: -> Remove dead code from Tkinter.py
___
Python tracker
<http://bugs.python.org
Guilherme Polo added the comment:
Thanks Eric, committed in r69473.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Guilherme Polo added the comment:
I've added some tests for it on r69467 now.
___
Python tracker
<http://bugs.python.org/issue4890>
___
___
Python-bugs-list m
Guilherme Polo added the comment:
The abort still happens occasionally, see:
http://www.python.org/dev/buildbot/all/OS%20X%20x86%20trunk/builds/118/step-test/0
(last lines)
I've talked with Daniel Steffen, who is one of the maintainers of Tcl/Tk
on Mac OSX, and I was told that all
New submission from Guilherme Polo :
Tkinter.Text.search is supposed to return a string, but this is not
always true. The problem is much more likely to be noticed while using
Tk 8.5.
--
components: Tkinter
files: ensure_search_returns_str.diff
keywords: patch
messages: 81465
nosy
Guilherme Polo added the comment:
Fixed on r69461, r69462, r69463 and r69464, thanks.
Will be adding tests for Tkinter.Text.search for trunk and py3k only.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.p
Changes by Guilherme Polo :
--
assignee: -> gpolo
___
Python tracker
<http://bugs.python.org/issue4890>
___
___
Python-bugs-list mailing list
Unsubscri
Guilherme Polo added the comment:
This is a duplicate, see issue1028.
--
nosy: +gpolo
resolution: -> duplicate
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Changes by Guilherme Polo :
Removed file: http://bugs.python.org/file12958/checking_for_failed_tk_load.diff
___
Python tracker
<http://bugs.python.org/issue5122>
___
___
Changes by Guilherme Polo :
Removed file:
http://bugs.python.org/file12960/checking_for_failed_tk_load-2.diff
___
Python tracker
<http://bugs.python.org/issue5
Guilherme Polo added the comment:
A bit cleaner patch.
Added file: http://bugs.python.org/file12971/protect_tk_loading.diff
___
Python tracker
<http://bugs.python.org/issue5
Guilherme Polo added the comment:
Another way to reproduce it (tested using debug build):
Python 2.7a0 (trunk:69375:69376M, Feb 6 2009, 20:27:09)
[GCC 4.3.2] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>>
Guilherme Polo added the comment:
Committed now.
trunk: r69376, r69377
release26-maint: r69378
py3k: r69380
release30-maint: r69381 (hand-merged, as you may notice I forgot to
split the patch in two again in py3k)
--
resolution: -> fixed
status: open ->
Guilherme Polo added the comment:
> Eric Smith added the comment:
> .
> .
> Which I assume is the expected behavior.
Yes it is expected.
>
> Also with the third patch installed, the regrtest's all pass.
>
Very nice.
And Eric, thanks for the patienc
Guilherme Polo added the comment:
Found a place still out of sync, it is fixed on this new patch. To
reproduce the problem with the previous patch try this:
import os
del os.environ['DISPLAY']
import Tkinter
Tkinter.Tk()
Tkinter.Tcl().loadtk() # should hang now (with a proper
Guilherme Polo added the comment:
Any chance you can look at the proposed patch, Martin ? I found out that
it was you who reported this deadlock back then, so you might want to
review the patch.
--
nosy: +loewis
___
Python tracker
<h
Guilherme Polo added the comment:
Here is a better patch, for some definition of better.
It syncs the failed attempt to load tk that may occur in
_tkinter.Tkapp_TkInit, _tkinter.Tcl_AppInit and tkappinit.Tcl_AppInit.
And that is done only for tk < 8.4.14 now.
Said that, I'm a bit
Guilherme Polo added the comment:
Ok, I've found the cause of the problem and the patch attached should
solve it but shouldn't be applied! This was just a quick fix I did to
confirm what I expected, I will add something more correct later.
_tkinter is aware of this deadlock that we a
Guilherme Polo added the comment:
After "I have isolated it now:", there should be this interactive
session (but gmail ate it apparently):
>>> import os
>>> del os.environ['DISPLAY']
>>> import Tkinter
>>> t = Tkinter.Tcl()
>>> t
Guilherme Polo added the comment:
> When I run "./python Lib/test/regrtest.py test_tcl test_ttk_guionly", it
> hangs.
I have isolated it now:
Traceback (most recent call last):
File "", line 1, in
File "/home/gpolo/python-dev/python-trunk/Lib/lib-tk/Tk
Guilherme Polo added the comment:
Eric, I noticed you said Fedora 6, so I checked which tcl/tk it
includes and apparently it is 8.4.13, is that correct ?
I tried using tcl/tk 8.4.13 and I managed to hang it too :)
Try running test_tcl followed by test_ttk_guionly with regrtest
Guilherme Polo added the comment:
Attaching patch to show how ttk.py would be with this new module.
Added file: http://bugs.python.org/file12948/ttk_withdeploader.diff
___
Python tracker
<http://bugs.python.org/issue5
New submission from Guilherme Polo :
Hi,
It seems to me that it would be useful to add something to indicate
which packages should be loaded, and how they should be loaded, when a
Tcl interpreter is created through Tkinter.Tk. Right now every extension
has to add some boilerplate code to load a
Guilherme Polo added the comment:
> That's not really a meaningful difference, though.. if the application
> uses this code continuously then the conditions will pile up in memory
> until it fills up.
I'm not trying to discourage you to do the complete fix (for these two
Guilherme Polo added the comment:
Can you tell what:
print(tkinter.Tcl().tk.call('info', 'patchlevel'))
prints ? Specifically to know which tk 8.5.x has the problem.
___
Python tracker
<http://bu
New submission from Guilherme Polo :
Hi, I'm going to try explaining in short why I think each of these
functions in _tkinter could be marked as deprecated and then removed on
2.8 (if it is decided to do it) and 3.1.
globalcall: It is not used anywhere in tkinter. It was abandoned, and
do
Guilherme Polo added the comment:
>> Besides, not calling ConditionFinalize doesn't introduce memory leaks
>
> Are you sure about this? On Unix, TclpFinalizeCondition does
>
>pthread_cond_destroy(pcondPtr);
>ckfree((char *) pcondPtr);
>
> bo
Guilherme Polo added the comment:
It is much more important to fix the memory leak anyway, it is possible
to notice real problems using test_tkleak1.py and watching the process
with ps or something else provided by the platform. Besides, not calling
ConditionFinalize doesn't introduce m
Guilherme Polo added the comment:
Commited in r69217 (r69219), r69220, r69222, r69223
Martin, I will open another ticket about GlobalCall deprecation, later
today.
--
resolution: accepted -> fixed
status: open -> closed
___
Python tracker
Guilherme Polo added the comment:
Any chance I can get this in ? I'm using something very similar to test
the ttk wrapper and will also be using in other tests, extensions would
also benefit from it, and old code doesn't get affected to it.
--
versions: +Python 3.1 -
Guilherme Polo added the comment:
Uhm, is it fine to remove it for good in 3.1 ? And then add a warning in
2.7 when it gets called which in turns just call Tkapp_Call ?
___
Python tracker
<http://bugs.python.org/issue1581
Guilherme Polo added the comment:
Do we still want to say _tkinter.c supports tcl/tk from version 8.2 and
newer ? If yes, then we should add a no-op Tcl_ConditionFinalize when
using tcl older than 8.3, because that was when this function got added.
Besides that, the patch looks fine to me too
Guilherme Polo added the comment:
It seems to be good now after a recent modification in how tests are
performed, closing. Sorry for the fuss.
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/iss
Guilherme Polo added the comment:
Thanks for verifying, closing as invalid.
--
nosy: +gpolo
resolution: -> invalid
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Guilherme Polo added the comment:
This is not really related to IDLE, it is how the Text widget behaves
under Linux, you will notice the same with tcl/tk 8.5.
Nevertheless, I would prefer to have the same results under Windows and
Linux.
--
nosy: +gpolo
New submission from Guilherme Polo :
Recently I've added this test named test_ttk_guionly, and I noticed some
buildslaves went red, like amd64 gentoo trunk and x86 FreeBSD trunk (I
though there were others for the reason I'm going to say next, but
didn't found on a quick look).
Guilherme Polo added the comment:
> For some reason the recently added test_ttk_guionly is causing Tcl to
> abort on Mac. I would prefer to disable the test for now, except if some
> mac owner has the time to fix it.
Just saw it didn't cause an abort with the buildslave heller
New submission from Guilherme Polo :
For some reason the recently added test_ttk_guionly is causing Tcl to
abort on Mac. I would prefer to disable the test for now, except if some
mac owner has the time to fix it.
I would like to know the tcl version being used on the noller-osx86
buildslave
Guilherme Polo added the comment:
As an side-side-note, I find much more important to add some kind of
test discovery since it is being duplicated in several packages in Lib/
and will continue being duplicated.
--
nosy: +gpolo
___
Python tracker
Guilherme Polo added the comment:
> It's
> also the only quick way in IDLE to be sure that the text widget is
> scrolled all the way to the left, since there's no horizontal scrollbar.
> (Any idea why that is? I assumed it's to discourage long lines, but I
&
Guilherme Polo added the comment:
> Weeble added the comment:
>
> I *think* the primary reason for overriding the home key behaviour was
> not for the interactive shell, but to make it easier to edit code. Most
> programmer's editors that do automatic indentation also let yo
Guilherme Polo added the comment:
> Weeble added the comment:
>
> Well, the status quo depends on an unsupported field - "anchor".
Better not repeat the mistake then ?
> As far
> as I can tell, the only other option that allows any customisation of
> cursor beha
Guilherme Polo added the comment:
> Weeble added the comment:
>
> In summary, Tk 8.5 changed the name of the "anchor" mark to be unique to
> each Text widget. The code to make the home key toggle between column 0
> and the start of the text tries to make use of the
Guilherme Polo added the comment:
Added in r69063
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue5083>
___
__
Guilherme Polo added the comment:
> Well, if the libraries for Ttk are not included then the tests should
> get skipped when the import fails.
>
Ah yes, good you said that because I wasn't doing it.
> A key reason to leaving something out of 'all' is if it takes a
Guilherme Polo added the comment:
samples: r69053 and r69055
Closing the issue now, thanks.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Guilherme Polo added the comment:
> Do the tests require human interaction? If so, it should definitely be
> another option.
>
No interaction is needed for the current ones.
> Otherwise, I'm don't know if we'll be wreaking havok with the buildbots
> by inclu
Guilherme Polo added the comment:
Uhm, maybe this 'gui' resource is too special to live in use_resources ?
Maybe a new option in regrtest would be better ?
___
Python tracker
<http://bugs.python.
Guilherme Polo added the comment:
r69051 in py3k
Now only samples are missing, I will be doing these later today I think.
And there is an issue regarding regrtest (gui resource), see issue5083.
___
Python tracker
<http://bugs.python.org/issue2
Guilherme Polo added the comment:
Added in python-trunk now: r69050
I will be merging it into py3k now, and my bad for taking so long to do
this.
___
Python tracker
<http://bugs.python.org/issue2
Guilherme Polo added the comment:
Mark,
I'm not a very huge user of tkinter, but I can tell you it would be
tricky to try getting a PyTclObject. It needs to be exposed if you want
to test it without relying on Tcl, but, to me they are just a
"temporary" object that serves
New submission from Guilherme Polo :
I would like to add a 'gui' resource in regrtest, this would be nice for
the ttk module that I'm planning to do add very soon (after I solve
another issue about tests).
--
components: Tests
files: regrtest_gui_resource.diff
keywords:
Guilherme Polo added the comment:
Why didn't you use assertRaises in place of that try/except for a test ?
I was somewhat following this issue and just saw it being commited, but
the change was being discussed. Aren't you supposed to commit these kind
of changes only after e
Guilherme Polo added the comment:
> "DC (0 hz) assumption"?
> wave.py makes the assumption that what the user wants is whatever
> happens to be in the file, however arbitrary. (That 8 bit samples are
> unsigned bytes is probably an artifact of early ADC logic. Typically yo
Guilherme Polo added the comment:
Not going to happen, python 2.5.4 is already out there.
--
resolution: -> wont fix
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Guilherme Polo added the comment:
I was going to reply about your "code layout" answer but forgot. Well,
each one has their preferences so I'm not going to question yours.
The only problem is that there is no maintainer for wave.py, so, the
more you follow the rules for Pyt
201 - 300 of 659 matches
Mail list logo
