[issue23550] Add to unicodedata a function to query the Quick_Check property for a character

Hammerite added the comment: For good measure, here is a patch that makes all of Berker's suggested stylistic changes, but applies them to the pre-existing code in makeunicodedata.py and unicodedata.c. So all of the existing docstrings are converted from '...\n\' to '...\n' form

[issue23550] Add to unicodedata a function to query the Quick_Check property for a character

Hammerite added the comment: My remark about the arrays not being static is not entirely accurate. _PyUnicode_CategoryNames, _PyUnicode_BidirectionalNames and _PyUnicode_EastAsianWidthNames are not static, however decomp_prefix is static. It would not add any significant bulk to the patch

[issue23550] Add to unicodedata a function to query the Quick_Check property for a character

Hammerite added the comment: Here is a new patch. This version addresses several issues raised in review by Ezio Melotti and Berker Peksag. Where I have not (yet) addressed an issue, I have explained why not in my previous post. I attempted to preview my changes to the documentation

[issue23550] Add to unicodedata a function to query the Quick_Check property for a character

Hammerite added the comment: I tried to add these responses within the code review section of the site, but I am unable to do so; when I click Send Message, I am taken to a page that consists of the text 500 Server Error and no other content. Therefore I am responding to the code review

[issue23550] Add to unicodedata a function to query the Quick_Check property for a character

Hammerite added the comment: Berker, I had not seen your or Ezio's review comments. The user interface here is new to me and I did not know to seek them out separately from the issue page. Thank you for pointing them out to me. I shall go through and look at the suggestions that were made

[issue23550] Add to unicodedata a function to query the Quick_Check property for a character

Hammerite added the comment: I'm a registered contributor now, in case that is a roadblock. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23550

[issue23550] Add to unicodedata a function to query the Quick_Check property for a character

Hammerite added the comment: Here is a better patch that includes the changes to unicodedata.h The problem before was that the diff tool can't cope with line ending differences. I just fixed the line endings manually. -- Added file: http://bugs.python.org/file38323/quick_check_2.patch

[issue23550] Add to unicodedata a function to query the Quick_Check property for a character

Hammerite added the comment: Here is an initial attempt at a patch that implements the new function. Notes on this patch: - The function as implemented here returns a string: Yes, No, or Maybe. In light of the fact that Python now has enums, it is probably more appropriate that unicodedata

[issue23550] Add to unicodedata a function to query the Quick_Check property for a character

Hammerite added the comment: No, I haven't done any work on it. Is that the done thing when suggesting something? I'm sorry, I wasn't aware. I could look into it. I am unfamiliar with the CPython codebase, but I can have a go. -- ___ Python

[issue23550] Add to unicodedata a function to query the Quick_Check property for a character

New submission from Hammerite: Unicode Standard Annex #15 (http://unicode.org/reports/tr15/#Stable_Code_Points) describes how each character in Unicode, for each of the four normalisation forms, has a Quick_Check value that aids in determining whether a given string is in that normalisation