[issue46550] __slots__ updates despite being read-only

2022-01-28 Thread Ian Lee
Ian Lee added the comment: @ronaldoussoren - right, I agree that I think that raising the AttributeErrors is the right thing. The part that feels like a bug to me is that the exception is saying it is read only and yet it is not being treated it that way (even though as you point out

[issue46550] __slots__ updates despite being read-only

2022-01-27 Thread Ian Lee
Ian Lee added the comment: @sobolevn - Hmm, interesting.. I tested in python 3.9 which I had available, and I can reproduce your result, but I think it's different because you are using a tuple. If I use a list then I see my same reported behavior in 3.9: ```python Python 3.9.10 (main, Jan

[issue46550] __slots__ updates despite being read-only

2022-01-27 Thread Ian Lee
New submission from Ian Lee : Hi there - I admit that I don't really understand the internals here, so maybe there is a good reason for this, but I thought it was weird when I just ran across it. If I create a new class `A`, and set it's `__slots`: ```python ➜ ~ docker run -it python:3.10

[issue27187] Relax __all__ location requirement in PEP 8

2016-06-07 Thread Ian Lee
Changes by Ian Lee <ianlee1...@gmail.com>: Added file: http://bugs.python.org/file43296/issue-27187-patch3.txt ___ Python tracker <rep...@bugs.python.org> <http://bugs.python

[issue27187] Relax __all__ location requirement in PEP 8

2016-06-07 Thread Ian Lee
Ian Lee added the comment: Good catch. I'm uploading a new patch that addresses ``from __future__`` imports issue explicitly. -- ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/i

[issue27191] Add formatting around methods in PEP 8

2016-06-02 Thread Ian Lee
New submission from Ian Lee: Noticed a couple methods in the text that aren't backtick quoted. -- assignee: docs@python components: Documentation files: rst-formatting.txt messages: 267015 nosy: IanLee1521, barry, docs@python priority: normal severity: normal status: open title: Add

[issue27187] Relax __all__ location requirement in PEP 8

2016-06-02 Thread Ian Lee
Ian Lee added the comment: I added a comment on a pull request related to this that shows some of the cases that we probably don't want to allow: https://github.com/PyCQA/pycodestyle/pull/523#issuecomment-223464775 -- ___ Python tracker <

[issue23061] Update pep8 to specify explicitly 'module level' imports at top of file

2016-06-02 Thread Ian Lee
Ian Lee added the comment: Are there any other concerns with the patch that I would be able to clean up? -- nosy: +barry ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/i

[issue27187] Relax __all__ location requirement in PEP 8

2016-06-02 Thread Ian Lee
Changes by Ian Lee <ianlee1...@gmail.com>: Added file: http://bugs.python.org/file43134/issue-27187-patch2.txt ___ Python tracker <rep...@bugs.python.org> <http://bugs.python

[issue27187] Relax __all__ location requirement in PEP 8

2016-06-02 Thread Ian Lee
Ian Lee added the comment: I might also suggest that the entire "Version bookkeeping" section could be removed in this case, as it would be covered by my newly added dunder section. -- ___ Python tracker <rep...@bugs.pyth

[issue27187] Relax __all__ location requirement in PEP 8

2016-06-02 Thread Ian Lee
Ian Lee added the comment: I think that it should be updated to specify that all dunders ('__all__', '__version__', '__author__', etc) should be placed after the module docstring and before any imports. See issue-27187-patch1.txt for a possible update. -- Added file: http

[issue27187] Relax __all__ location requirement in PEP 8

2016-06-02 Thread Ian Lee
Changes by Ian Lee <ianlee1...@gmail.com>: -- nosy: +IanLee1521 ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue27187> ___ __

[issue26763] Update PEP-8 regarding binary operators

2016-04-15 Thread Ian Lee
Ian Lee added the comment: > Aren't there many other examples in the PEP that need to be adjusted, since > we're changing the style not just for 'and' and 'or' but for all binary > operators? Admittedly I'd only looked in that one section last night, but I just went throug

[issue26763] Update PEP-8 regarding binary operators

2016-04-15 Thread Ian Lee
Ian Lee added the comment: Link to GitHub branch with the patch as a commit [1]. [1] https://github.com/python/peps/compare/master...IanLee1521:issue26763 -- ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/i

[issue26763] Update PEP-8 regarding binary operators

2016-04-15 Thread Ian Lee
Ian Lee added the comment: Discussion link missing from msg263453: https://mail.python.org/pipermail/python-ideas/2016-April/039774.html -- ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/i

[issue26763] Update PEP-8 regarding binary operators

2016-04-15 Thread Ian Lee
New submission from Ian Lee: Following up from discussion on python-ideas [1] about updating PEP-8 regarding wrapping lines before rather than after binary operators. -- files: wrap-before-binary-operator.patch keywords: patch messages: 263453 nosy: IanLee1521, gvanrossum priority

[issue23639] Not documented special names

2015-03-13 Thread Ian Lee
Changes by Ian Lee ianlee1...@gmail.com: -- nosy: +IanLee1521 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23639 ___ ___ Python-bugs-list mailing

[issue23182] Update grammar tests to use new style

2015-01-07 Thread Ian Lee
New submission from Ian Lee: Per Guido's suggestion on the p...@python.org mailing list, I'm creating this issue to update the argument annotation tests at cpython/Lib/test/test_grammar.py to use the new style wording Guido requested on GitHub [1] that I proposed and was merged into PEP-8 [2

[issue23182] Update grammar tests to use new style for annotated function definitions

2015-01-07 Thread Ian Lee
Changes by Ian Lee ianlee1...@gmail.com: -- title: Update grammar tests to use new style - Update grammar tests to use new style for annotated function definitions ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23182

[issue23061] Update pep8 to specify explicitly 'module level' imports at top of file

2014-12-21 Thread Ian Lee
Ian Lee added the comment: So one concern that was brought up on GitHub was the fact that currently this is not actually followed universally in the Python standard library. In particular there are 636 errors in the standard library ``python pep8.py --select E402 --statistics /usr/lib

[issue23061] Update pep8 to specify explicitly 'module level' imports at top of file

2014-12-21 Thread Ian Lee
Ian Lee added the comment: I should add that I would be happy to patch the standard libraries to be compliant w.r.t. the imports at top of the files. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23061

[issue23061] Update pep8 to specify explicitly 'module level' imports at top of file

2014-12-15 Thread Ian Lee
New submission from Ian Lee: Minor update pep8 to specify explicitly that Imports at top of file refers specifically to module level imports, per input from Nick Coghlan @ https://github.com/jcrocholl/pep8/pull/304#issuecomment-66939162 -- assignee: docs@python components