[issue39766] unittest's assertRaises removes locals from tracebacks

2021-05-11 Thread Jackson Riley
Jackson Riley added the comment: +1 - I was surprised not to be able to get locals from many of the frames in pdb upon an unexpected exception being raised inside an assertRaises. Thanks for raising this issue Daniel. -- nosy: +jacksonriley

[issue38866] test_pyclbr replace asyncore

2019-11-21 Thread Jackson Riley
Change by Jackson Riley : -- pull_requests: +16803 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17316 ___ Python tracker <https://bugs.python.org/issu

[issue28533] Replace asyncore

2019-11-20 Thread Jackson Riley
Jackson Riley added the comment: Lib/test/test_pyclbr.py - subissue issue38866 A trivial one! -- nosy: +jacksonriley ___ Python tracker <https://bugs.python.org/issue28

[issue38866] test_pyclbr replace asyncore

2019-11-20 Thread Jackson Riley
New submission from Jackson Riley : sub-issue of (issue28533)[https://bugs.python.org/issue28533] -- components: Tests files: pyclbr.patch keywords: patch messages: 357087 nosy: jacksonriley priority: normal severity: normal status: open title: test_pyclbr replace asyncore Added file

[issue34716] MagicMock.__divmod__ should return a pair

2019-11-20 Thread Jackson Riley
Change by Jackson Riley : -- keywords: +patch pull_requests: +16784 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17291 ___ Python tracker <https://bugs.python.org/issu

[issue34716] MagicMock.__divmod__ should return a pair

2019-11-20 Thread Jackson Riley
Jackson Riley added the comment: Ah thank you Vedran, that makes sense. In that case, I think I'll make a start on implementing Serhiy's second suggestion - returning a pair of MagicMock instances when MagicMock.__divmod__

[issue17306] Improve the way abstract base classes are shown in help()

2019-11-20 Thread Jackson Riley
Change by Jackson Riley : -- pull_requests: +16771 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17278 ___ Python tracker <https://bugs.python.org/issu

[issue34716] MagicMock.__divmod__ should return a pair

2019-11-13 Thread Jackson Riley
Jackson Riley added the comment: On second thoughts, perhaps option 2 is best (more in keeping with the usual behaviour of MagicMock). Alternatively, could I propose a fourth option: 4. Change the behaviour of MagicMock more generally such that trying to unpack a MagicMock instance into two

[issue34716] MagicMock.__divmod__ should return a pair

2019-11-12 Thread Jackson Riley
Jackson Riley added the comment: Hi Serhiy, Option 3 sounds most sensible to me. I'd be happy to pick up this issue, please do let me know. -- nosy: +jacksonriley ___ Python tracker <https://bugs.python.org/is

[issue17306] Improve the way abstract base classes are shown in help()

2019-11-12 Thread Jackson Riley
Jackson Riley added the comment: Hi Raymond - here's a first attempt at adding class-level docstrings, based off the format of Sequence.__doc__. Apologies if some things are not well worded etc. It looks like all of the non-magic methods have docstrings already but if you think the

[issue36092] unittest.mock's patch.object and patch.dict are not supported on classmethod, propery and staticmethod

2019-11-12 Thread Jackson Riley
Jackson Riley added the comment: Thanks Karthikeyan! -- ___ Python tracker <https://bugs.python.org/issue36092> ___ ___ Python-bugs-list mailing list Unsub

[issue23692] Undocumented feature prevents re module from finding certain matches

2019-11-12 Thread Jackson Riley
Jackson Riley added the comment: Hi Matthew, Serhiy, I tried to identify the right places in re to fix things but have found it a bit difficult. I wrote up my attempt (at https://enhackathon.github.io/2019/11/04/JacksonRiley.html) which includes some examples that behave differently from

[issue17306] Improve the way abstract base classes are shown in help()

2019-11-12 Thread Jackson Riley
Jackson Riley added the comment: Hi Raymond, I'm working with Ben on the EnHackathon project (https://enhackathon.github.io/) and am planning on working on this issue. Is that alright? Please do say if there's anything extra wanted or if you have any guidance (this is my

[issue36092] unittest.mock's patch.object and patch.dict are not supported on classmethod, propery and staticmethod

2019-11-12 Thread Jackson Riley
Jackson Riley added the comment: Hi Karthikeyan, It seems that test_patch_descriptor has been removed by Chris Withers on 1st of May 2019 under commit adbf178. I would therefore propose that this bug be marked as closed/resolved. Cheers, Jackson -- nosy: +jacksonriley

[issue23692] Undocumented feature prevents re module from finding certain matches

2019-11-04 Thread Jackson Riley
Jackson Riley added the comment: I've got a bit confused and am doubting myself - is the below output expected? >>> m = re.match('(?:()|(?(1)()|z)){1,2}(?(2)a|z)', 'a') >>> m.groups() ('', '') >>> m = re.match('(?:()|

[issue23692] Undocumented feature prevents re module from finding certain matches

2019-11-04 Thread Jackson Riley
Jackson Riley added the comment: Ah thank you very much Serhiy, that's super helpful! -- ___ Python tracker <https://bugs.python.org/issue23692> ___ ___

[issue23692] Undocumented feature prevents re module from finding certain matches

2019-11-04 Thread Jackson Riley
Jackson Riley added the comment: Hi Matthew, thank you for your suggestions of where to start. Could you possibly give a pointer to the place in the code where the 'capture changed' counter is incremented? I had a bit of a hunt and couldn't find it but may have been looki

[issue9182] document “--” as a way to distinguish option w/ narg='+' from positional argument in argparse

2019-10-31 Thread Jackson Riley
Jackson Riley added the comment: Hi all, I'm a newcomer and wanted to try to make this change, is it still wanted/needed? -- nosy: +jacksonriley ___ Python tracker <https://bugs.python.org/i

[issue9338] argparse optionals with nargs='?', '*' or '+' can't be followed by positionals

2019-10-31 Thread Jackson Riley
Jackson Riley added the comment: I'm a newcomer and thought about trying to follow up on this and potentially update existing patches, would this be a good idea? -- nosy: +jacksonriley ___ Python tracker <https://bugs.python.org/i